[GitHub] spark pull request #20285: [SPARK-22735][ML][DOC] Added VectorSizeHint docs ...

2018-01-17 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20285#discussion_r162223829 --- Diff: examples/src/main/python/ml/vector_size_hint_example.py --- @@ -0,0 +1,57 @@ +# +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] spark issue #20302: [SPARK-23094] Fix invalid character handling in JsonData...

2018-01-17 Thread brkyvz
Github user brkyvz commented on the issue: https://github.com/apache/spark/pull/20302 cc @hvanhovell @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20302: [SPARK-23094] Fix invalid character handling in J...

2018-01-17 Thread brkyvz
GitHub user brkyvz opened a pull request: https://github.com/apache/spark/pull/20302 [SPARK-23094] Fix invalid character handling in JsonDataSource ## What changes were proposed in this pull request? There were two related fixes regarding `from_json`, `get_json_object` and

[GitHub] spark issue #20243: [SPARK-23052][SS] Migrate ConsoleSink to data source V2 ...

2018-01-17 Thread tdas
Github user tdas commented on the issue: https://github.com/apache/spark/pull/20243 LGTM, assuming tests pass. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20226: [SPARK-23034][SQL] Override `nodeName` for all *S...

2018-01-17 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/20226#discussion_r162224065 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -45,7 +46,12 @@ trait CodegenSupport extends

[GitHub] spark pull request #19247: [Spark-21996][SQL] read files with space in name ...

2018-01-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19247 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20255: [SPARK-23064][DOCS][SS] Added documentation for s...

2018-01-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20255 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20286: [SPARK-23119][SS] Minor fixes to V2 streaming API...

2018-01-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20286 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20255: [SPARK-23064][DOCS][SS] Added documentation for stream-s...

2018-01-17 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/20255 Merging to master and 2.3. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20286: [SPARK-23119][SS] Minor fixes to V2 streaming APIs

2018-01-17 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/20286 LGTM. Merging to master and 2.3. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20285: [SPARK-22735][ML][DOC] Added VectorSizeHint docs and exa...

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20285 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86302/ Test PASSed. ---

[GitHub] spark issue #20255: [SPARK-23064][DOCS][SS] Added documentation for stream-s...

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20255 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86303/ Test PASSed. ---

[GitHub] spark issue #20285: [SPARK-22735][ML][DOC] Added VectorSizeHint docs and exa...

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20285 **[Test build #86302 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86302/testReport)** for PR 20285 at commit

[GitHub] spark issue #20285: [SPARK-22735][ML][DOC] Added VectorSizeHint docs and exa...

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20285 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20255: [SPARK-23064][DOCS][SS] Added documentation for stream-s...

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20255 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20255: [SPARK-23064][DOCS][SS] Added documentation for stream-s...

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20255 **[Test build #86303 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86303/testReport)** for PR 20255 at commit

[GitHub] spark issue #18906: [SPARK-21692][PYSPARK][SQL] Add nullability support to P...

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18906 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18906: [SPARK-21692][PYSPARK][SQL] Add nullability support to P...

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18906 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86293/ Test PASSed. ---

[GitHub] spark issue #18906: [SPARK-21692][PYSPARK][SQL] Add nullability support to P...

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18906 **[Test build #86293 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86293/testReport)** for PR 18906 at commit

[GitHub] spark issue #20286: [SPARK-23119][SS] Minor fixes to V2 streaming APIs

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20286 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20286: [SPARK-23119][SS] Minor fixes to V2 streaming APIs

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20286 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86292/ Test PASSed. ---

[GitHub] spark issue #20286: [SPARK-23119][SS] Minor fixes to V2 streaming APIs

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20286 **[Test build #86292 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86292/testReport)** for PR 20286 at commit

[GitHub] spark issue #20255: [SPARK-23064][DOCS][SS] Added documentation for stream-s...

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20255 **[Test build #86303 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86303/testReport)** for PR 20255 at commit

[GitHub] spark issue #20285: [SPARK-22735][ML][DOC] Added VectorSizeHint docs and exa...

2018-01-17 Thread MrBago
Github user MrBago commented on the issue: https://github.com/apache/spark/pull/20285 Thanks for the review @BryanCutler, I've added a java example & uploaded 2 screenshots. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20285: [SPARK-22735][ML][DOC] Added VectorSizeHint docs and exa...

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20285 **[Test build #86302 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86302/testReport)** for PR 20285 at commit

[GitHub] spark issue #20285: [SPARK-22735][ML][DOC] Added VectorSizeHint docs and exa...

2018-01-17 Thread MrBago
Github user MrBago commented on the issue: https://github.com/apache/spark/pull/20285 https://user-images.githubusercontent.com/223219/35074422-9c192bf6-fba2-11e7-8be1-35279db1df49.png;> --- - To unsubscribe,

[GitHub] spark issue #20285: [SPARK-22735][ML][DOC] Added VectorSizeHint docs and exa...

2018-01-17 Thread MrBago
Github user MrBago commented on the issue: https://github.com/apache/spark/pull/20285 https://user-images.githubusercontent.com/223219/35074406-90b074ea-fba2-11e7-853b-45e3c447fe68.png;> --- - To unsubscribe,

[GitHub] spark issue #19885: [SPARK-22587] Spark job fails if fs.defaultFS and applic...

2018-01-17 Thread merlintang
Github user merlintang commented on the issue: https://github.com/apache/spark/pull/19885 @jerryshao can you backport this to branch 2.2 as well. thanks --- - To unsubscribe, e-mail:

[GitHub] spark issue #20297: [SPARK-23020][CORE] Fix races in launcher code, test.

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20297 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86289/ Test PASSed. ---

[GitHub] spark issue #20299: [SPARK-23135][ui] Fix rendering of accumulators in the s...

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20299 **[Test build #86301 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86301/testReport)** for PR 20299 at commit

[GitHub] spark issue #20297: [SPARK-23020][CORE] Fix races in launcher code, test.

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20297 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20299: [SPARK-23135][ui] Fix rendering of accumulators in the s...

2018-01-17 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20299 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20297: [SPARK-23020][CORE] Fix races in launcher code, test.

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20297 **[Test build #86289 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86289/testReport)** for PR 20297 at commit

[GitHub] spark issue #20299: [SPARK-23135][ui] Fix rendering of accumulators in the s...

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20299 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86291/ Test FAILed. ---

[GitHub] spark issue #20299: [SPARK-23135][ui] Fix rendering of accumulators in the s...

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20299 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20299: [SPARK-23135][ui] Fix rendering of accumulators in the s...

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20299 **[Test build #86291 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86291/testReport)** for PR 20299 at commit

[GitHub] spark pull request #20255: [SPARK-23064][DOCS][SS] Added documentation for s...

2018-01-17 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/20255#discussion_r162199330 --- Diff: docs/structured-streaming-programming-guide.md --- @@ -1089,6 +1101,300 @@ streamingDf.join(staticDf, "type", "right_join") # right outer join

[GitHub] spark pull request #20255: [SPARK-23064][DOCS][SS] Added documentation for s...

2018-01-17 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/20255#discussion_r162212307 --- Diff: docs/structured-streaming-programming-guide.md --- @@ -1089,6 +1101,300 @@ streamingDf.join(staticDf, "type", "right_join") # right outer join

[GitHub] spark issue #20226: [SPARK-23034][SQL] Override `nodeName` for all *ScanExec...

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20226 **[Test build #86300 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86300/testReport)** for PR 20226 at commit

[GitHub] spark issue #20275: [SPARK-23085][ML] API parity for mllib.linalg.Vectors.sp...

2018-01-17 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/20275 Unless someone like @jkbradley or @MLnick objects, I think this doesn't hurt and actually makes things a little more consistent. ---

[GitHub] spark issue #20226: [SPARK-23034][SQL] Override `nodeName` for all *ScanExec...

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20226 **[Test build #86299 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86299/testReport)** for PR 20226 at commit

[GitHub] spark issue #20226: [SPARK-23034][SQL] Override `nodeName` for all *ScanExec...

2018-01-17 Thread tejasapatil
Github user tejasapatil commented on the issue: https://github.com/apache/spark/pull/20226 Jenkins retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20269: [SPARK-23029] [DOCS] Specifying default units of configu...

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20269 **[Test build #4058 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4058/testReport)** for PR 20269 at commit

[GitHub] spark pull request #20300: [MINOR] Fix typos in ML scaladocs

2018-01-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20300 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20300: [MINOR] Fix typos in ML scaladocs

2018-01-17 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/20300 Merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...

2018-01-17 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/19247 Thanks! Merging to master and 2.3. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19247 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86288/ Test PASSed. ---

[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19247 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19247 **[Test build #86288 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86288/testReport)** for PR 19247 at commit

[GitHub] spark issue #20243: [SPARK-23052][SS] Migrate ConsoleSink to data source V2 ...

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20243 **[Test build #86298 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86298/testReport)** for PR 20243 at commit

[GitHub] spark issue #20300: [MINOR] Fix typos in ML scaladocs

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20300 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20300: [MINOR] Fix typos in ML scaladocs

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20300 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86294/ Test PASSed. ---

[GitHub] spark issue #20300: [MINOR] Fix typos in ML scaladocs

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20300 **[Test build #86294 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86294/testReport)** for PR 20300 at commit

[GitHub] spark issue #20301: [SPARK-23131][CORE][WIP] Stackoverflow using ML and Kryo...

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20301 **[Test build #86297 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86297/testReport)** for PR 20301 at commit

[GitHub] spark pull request #20301: [SPARK-23131][CORE][WIP] Stackoverflow using ML a...

2018-01-17 Thread srowen
GitHub user srowen opened a pull request: https://github.com/apache/spark/pull/20301 [SPARK-23131][CORE][WIP] Stackoverflow using ML and Kryo serializer ## What changes were proposed in this pull request? Update chill to 0.9.2, Kryo to 4.0.x, to get bug fixes and

[GitHub] spark issue #20239: [SPARK-23047][PYTHON][SQL] Change MapVector to NullableM...

2018-01-17 Thread icexelloss
Github user icexelloss commented on the issue: https://github.com/apache/spark/pull/20239 Thanks for everyone for review! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #20294: [SPARK-23132][PYTHON][ML] Run doctests in ml.imag...

2018-01-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20294 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20294: [SPARK-23132][PYTHON][ML] Run doctests in ml.image when ...

2018-01-17 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20294 Merged to master and branch-2.3. Thanks for reviewing this, @srowen, @imatiach-msft, @MrBago and @BryanCutler. ---

[GitHub] spark issue #20295: [WIP][SPARK-23011] Support alternative function form wit...

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20295 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20300: [MINOR] Fix typos in ML scaladocs

2018-01-17 Thread BryanCutler
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/20300 Thanks @srowen, I honestly tried to look for more and was surprised this was all I could find! --- - To unsubscribe,

[GitHub] spark issue #20295: [WIP][SPARK-23011] Support alternative function form wit...

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20295 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86290/ Test FAILed. ---

[GitHub] spark issue #20295: [WIP][SPARK-23011] Support alternative function form wit...

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20295 **[Test build #86290 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86290/testReport)** for PR 20295 at commit

[GitHub] spark pull request #20239: [SPARK-23047][PYTHON][SQL] Change MapVector to Nu...

2018-01-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20239 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20243: [SPARK-23052][SS] Migrate ConsoleSink to data source V2 ...

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20243 **[Test build #86296 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86296/testReport)** for PR 20243 at commit

[GitHub] spark issue #20239: [SPARK-23047][PYTHON][SQL] Change MapVector to NullableM...

2018-01-17 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20239 Merged to master and branch-2.3. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #20288: [SPARK-23122][PYTHON][SQL] Deprecate register* fo...

2018-01-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20288#discussion_r162198033 --- Diff: python/pyspark/sql/catalog.py --- @@ -224,92 +224,20 @@ def dropGlobalTempView(self, viewName): """

[GitHub] spark pull request #20282: [SPARK-23093][SS] Don't change run id when reconf...

2018-01-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20282 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20282: [SPARK-23093][SS] Don't change run id when reconfiguring...

2018-01-17 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/20282 LGTM. Merging to master and 2.3. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #20225: [SPARK-23033][SS] Don't use task level retry for ...

2018-01-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20225 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20282: [SPARK-23093][SS] Don't change run id when reconfiguring...

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20282 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20282: [SPARK-23093][SS] Don't change run id when reconfiguring...

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20282 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86285/ Test PASSed. ---

[GitHub] spark issue #20282: [SPARK-23093][SS] Don't change run id when reconfiguring...

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20282 **[Test build #86285 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86285/testReport)** for PR 20282 at commit

[GitHub] spark issue #20225: [SPARK-23033][SS] Don't use task level retry for continu...

2018-01-17 Thread tdas
Github user tdas commented on the issue: https://github.com/apache/spark/pull/20225 LGTM. Merging this to master and 2.3 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20243: [SPARK-23052][SS] Migrate ConsoleSink to data source V2 ...

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20243 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20243: [SPARK-23052][SS] Migrate ConsoleSink to data source V2 ...

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20243 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86284/ Test PASSed. ---

[GitHub] spark issue #20243: [SPARK-23052][SS] Migrate ConsoleSink to data source V2 ...

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20243 **[Test build #86284 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86284/testReport)** for PR 20243 at commit

[GitHub] spark issue #20284: [SPARK-23103][core] Ensure correct sort order for negati...

2018-01-17 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/20284 Ah, thanks for the explanation! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20284: [SPARK-23103][core] Ensure correct sort order for negati...

2018-01-17 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20284 It is actually. Before, negative values (empty metrics all have value "-1") would show up when starting iteration from 0, and now they don't. ```

[GitHub] spark issue #20284: [SPARK-23103][core] Ensure correct sort order for negati...

2018-01-17 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/20284 @vanzin The unit test fix is not related to the sorting issue right? Also it's totally fine to include it in this PR since it's minor. ---

[GitHub] spark issue #20284: [SPARK-23103][core] Ensure correct sort order for negati...

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20284 **[Test build #86295 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86295/testReport)** for PR 20284 at commit

[GitHub] spark issue #20300: [MINOR] Fix typos in ML scaladocs

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20300 **[Test build #86294 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86294/testReport)** for PR 20300 at commit

[GitHub] spark issue #20225: [SPARK-23033][SS] Don't use task level retry for continu...

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20225 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86283/ Test PASSed. ---

[GitHub] spark issue #20225: [SPARK-23033][SS] Don't use task level retry for continu...

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20225 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20225: [SPARK-23033][SS] Don't use task level retry for continu...

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20225 **[Test build #86283 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86283/testReport)** for PR 20225 at commit

[GitHub] spark issue #20300: [MINOR] Fix typos in ML scaladocs

2018-01-17 Thread BryanCutler
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/20300 ping @holdenk @MLnick --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20300: [MINOR] Fix typos in ML scaladocs

2018-01-17 Thread BryanCutler
GitHub user BryanCutler opened a pull request: https://github.com/apache/spark/pull/20300 [MINOR] Fix typos in ML scaladocs ## What changes were proposed in this pull request? Fixed some typos found in ML scaladocs ## How was this patch tested? NA You can

[GitHub] spark issue #20284: [SPARK-23103][core] Ensure correct sort order for negati...

2018-01-17 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/20284 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #18906: [SPARK-21692][PYSPARK][SQL] Add nullability support to P...

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18906 **[Test build #86293 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86293/testReport)** for PR 18906 at commit

[GitHub] spark pull request #20243: [SPARK-23052][SS] Migrate ConsoleSink to data sou...

2018-01-17 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/20243#discussion_r162182456 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/ConsoleWriter.scala --- @@ -0,0 +1,57 @@ +/* + * Licensed to the

[GitHub] spark pull request #20045: [Spark-22360][SQL][TEST] Add unit tests for Windo...

2018-01-17 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20045#discussion_r162182000 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala --- @@ -246,13 +246,24 @@ class

[GitHub] spark issue #20286: [SPARK-23119][SS] Minor fixes to V2 streaming APIs

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20286 **[Test build #86292 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86292/testReport)** for PR 20286 at commit

[GitHub] spark issue #20299: [SPARK-23135][ui] Fix rendering of accumulators in the s...

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20299 **[Test build #86291 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86291/testReport)** for PR 20299 at commit

[GitHub] spark pull request #20299: [SPARK-23135][ui] Fix rendering of accumulators i...

2018-01-17 Thread vanzin
GitHub user vanzin opened a pull request: https://github.com/apache/spark/pull/20299 [SPARK-23135][ui] Fix rendering of accumulators in the stage page. This follows the behavior of 2.2: only named accumulators with a value are rendered. Screenshot:

[GitHub] spark pull request #20284: [SPARK-23103][core] Ensure correct sort order for...

2018-01-17 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20284#discussion_r162168466 --- Diff: common/kvstore/src/test/java/org/apache/spark/util/kvstore/DBIteratorSuite.java --- @@ -112,7 +114,8 @@ public void setup() throws Exception {

[GitHub] spark issue #20298: [SPARK-22976][Core]: Cluster mode driver dir removed whi...

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20298 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20045: [Spark-22360][SQL][TEST] Add unit tests for Window Speci...

2018-01-17 Thread smurakozi
Github user smurakozi commented on the issue: https://github.com/apache/spark/pull/20045 @gatorsmile @hvanhovell @jiangxb1987, could you have a look, please? --- - To unsubscribe, e-mail:

[GitHub] spark issue #20190: [SPARK-22976][Core]: Cluster mode driver directories can...

2018-01-17 Thread RussellSpitzer
Github user RussellSpitzer commented on the issue: https://github.com/apache/spark/pull/20190 @jerryshao https://github.com/apache/spark/pull/20298 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark pull request #20298: [SPARK-22976][Core]: Cluster mode driver dir remo...

2018-01-17 Thread RussellSpitzer
GitHub user RussellSpitzer opened a pull request: https://github.com/apache/spark/pull/20298 [SPARK-22976][Core]: Cluster mode driver dir removed while running ## What changes were proposed in this pull request? The clean up logic on the worker perviously determined the

[GitHub] spark pull request #20284: [SPARK-23103][core] Ensure correct sort order for...

2018-01-17 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20284#discussion_r162166090 --- Diff: common/kvstore/src/test/java/org/apache/spark/util/kvstore/DBIteratorSuite.java --- @@ -112,7 +114,8 @@ public void setup() throws Exception {

[GitHub] spark issue #19872: [SPARK-22274][PYTHON][SQL] User-defined aggregation func...

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19872 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86280/ Test PASSed. ---

<    1   2   3   4   5   6   7   >