[GitHub] spark issue #21119: [SPARK-19826][ML][PYTHON]add spark.ml Python API for PIC

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21119 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21119: [SPARK-19826][ML][PYTHON]add spark.ml Python API for PIC

2018-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21119 **[Test build #89943 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89943/testReport)** for PR 21119 at commit [`6d00f34`](https://github.com/apache/spark/commit/6

[GitHub] spark issue #21119: [SPARK-19826][ML][PYTHON]add spark.ml Python API for PIC

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21119 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89943/ Test FAILed. ---

[GitHub] spark issue #21119: [SPARK-19826][ML][PYTHON]add spark.ml Python API for PIC

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21119 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21119: [SPARK-19826][ML][PYTHON]add spark.ml Python API for PIC

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21119 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2730/ Tes

[GitHub] spark issue #21119: [SPARK-19826][ML][PYTHON]add spark.ml Python API for PIC

2018-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21119 **[Test build #89943 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89943/testReport)** for PR 21119 at commit [`6d00f34`](https://github.com/apache/spark/commit/6d

[GitHub] spark issue #21182: [SPARK-24068] Propagating DataFrameReader's options to T...

2018-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21182 **[Test build #89942 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89942/testReport)** for PR 21182 at commit [`8a8ff3f`](https://github.com/apache/spark/commit/8a

[GitHub] spark issue #21182: [SPARK-24068] Propagating DataFrameReader's options to T...

2018-04-27 Thread MaxGekk
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/21182 jenkins, retest this, please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21186: [SPARK-22279][SPARK-24112] Enable `convertMetastoreOrc` ...

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21186 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21186: [SPARK-22279][SPARK-24112] Enable `convertMetastoreOrc` ...

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21186 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2729/ Tes

[GitHub] spark issue #21049: [SPARK-23957][SQL] Remove redundant sort operators from ...

2018-04-27 Thread henryr
Github user henryr commented on the issue: https://github.com/apache/spark/pull/21049 @dilipbiswal thanks for the clarification. I agree that this particular case - where the alias is the root of a logical plan - might need special handling. Is there any reason to actually us

[GitHub] spark pull request #21171: [SPARK-24104] SQLAppStatusListener overwrites met...

2018-04-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21171 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21186: [SPARK-22279][SPARK-24112] Enable `convertMetastoreOrc` ...

2018-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21186 **[Test build #89941 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89941/testReport)** for PR 21186 at commit [`5383299`](https://github.com/apache/spark/commit/53

[GitHub] spark pull request #21119: [SPARK-19826][ML][PYTHON]add spark.ml Python API ...

2018-04-27 Thread huaxingao
Github user huaxingao commented on a diff in the pull request: https://github.com/apache/spark/pull/21119#discussion_r184809072 --- Diff: python/pyspark/ml/clustering.py --- @@ -1156,6 +1156,201 @@ def getKeepLastCheckpoint(self): return self.getOrDefault(self.keepLastC

[GitHub] spark pull request #21119: [SPARK-19826][ML][PYTHON]add spark.ml Python API ...

2018-04-27 Thread huaxingao
Github user huaxingao commented on a diff in the pull request: https://github.com/apache/spark/pull/21119#discussion_r184808830 --- Diff: python/pyspark/ml/clustering.py --- @@ -1156,6 +1156,201 @@ def getKeepLastCheckpoint(self): return self.getOrDefault(self.keepLastC

[GitHub] spark pull request #21186: [SPARK-22279][SPARK-24112] Enable `convertMetasto...

2018-04-27 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/21186 [SPARK-22279][SPARK-24112] Enable `convertMetastoreOrc` and add `convertMetastore.TableProperty` conf ## What changes were proposed in this pull request? We reverted `spark.sql.hive.

[GitHub] spark issue #21171: [SPARK-24104] SQLAppStatusListener overwrites metrics on...

2018-04-27 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/21171 LGTM. Merging to master / 2.3. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21173: [SPARK-23856][SQL] Add an option `queryTimeout` in JDBCO...

2018-04-27 Thread MaxGekk
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/21173 What about timeout for this query: https://github.com/maropu/spark/blob/f134548bd6b7b9f2bc2c508698404a61eb9ea43e/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala#

[GitHub] spark issue #21028: [SPARK-23922][SQL] Add arrays_overlap function

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21028 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21028: [SPARK-23922][SQL] Add arrays_overlap function

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21028 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89935/ Test FAILed. ---

[GitHub] spark issue #21028: [SPARK-23922][SQL] Add arrays_overlap function

2018-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21028 **[Test build #89935 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89935/testReport)** for PR 21028 at commit [`5925104`](https://github.com/apache/spark/commit/5

[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89934/ Test PASSed. ---

[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...

2018-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #89934 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89934/testReport)** for PR 21109 at commit [`fbec452`](https://github.com/apache/spark/commit/f

[GitHub] spark issue #20894: [SPARK-23786][SQL] Checking column names of csv headers

2018-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20894 **[Test build #89940 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89940/testReport)** for PR 20894 at commit [`1fffc16`](https://github.com/apache/spark/commit/1f

[GitHub] spark issue #21041: [SPARK-23962][SQL][TEST] Fix race in currentExecutionIds...

2018-04-27 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/21041 I submitted a PR for SPARK-23894, https://github.com/apache/spark/pull/21185, please take a look. --- - To unsubscribe, e-mail: r

[GitHub] spark issue #21185: [SPARK-23894][CORE][SQL] Defensively clear ActiveSession...

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21185 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21185: [SPARK-23894][CORE][SQL] Defensively clear ActiveSession...

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21185 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2728/ Tes

[GitHub] spark issue #21185: [SPARK-23894][CORE][SQL] Defensively clear ActiveSession...

2018-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21185 **[Test build #89939 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89939/testReport)** for PR 21185 at commit [`2a4944f`](https://github.com/apache/spark/commit/2a

[GitHub] spark pull request #21185: [SPARK-23894][CORE][SQL] Defensively clear Active...

2018-04-27 Thread squito
GitHub user squito opened a pull request: https://github.com/apache/spark/pull/21185 [SPARK-23894][CORE][SQL] Defensively clear ActiveSession in Executors Because SparkSession.getActiveSession uses an InheritableThreadLocal, the ThreadPool in executors might end up inheriting the

[GitHub] spark issue #21169: [SPARK-23715][SQL] the input of to/from_utc_timestamp ca...

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21169 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89931/ Test PASSed. ---

[GitHub] spark issue #21169: [SPARK-23715][SQL] the input of to/from_utc_timestamp ca...

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21169 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21169: [SPARK-23715][SQL] the input of to/from_utc_timestamp ca...

2018-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21169 **[Test build #89931 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89931/testReport)** for PR 21169 at commit [`e9d1f24`](https://github.com/apache/spark/commit/e

[GitHub] spark issue #21181: [SPARK-23736][SQL][FOLLOWUP] Error message should contai...

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21181 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21181: [SPARK-23736][SQL][FOLLOWUP] Error message should contai...

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21181 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89927/ Test PASSed. ---

[GitHub] spark issue #21181: [SPARK-23736][SQL][FOLLOWUP] Error message should contai...

2018-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21181 **[Test build #89927 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89927/testReport)** for PR 21181 at commit [`5660de8`](https://github.com/apache/spark/commit/5

[GitHub] spark issue #21021: [SPARK-23921][SQL] Add array_sort function

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21021 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89933/ Test FAILed. ---

[GitHub] spark issue #21021: [SPARK-23921][SQL] Add array_sort function

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21021 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21021: [SPARK-23921][SQL] Add array_sort function

2018-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21021 **[Test build #89933 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89933/testReport)** for PR 21021 at commit [`175d981`](https://github.com/apache/spark/commit/1

[GitHub] spark issue #20937: [SPARK-23094][SPARK-23723][SPARK-23724][SQL] Support cus...

2018-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20937 **[Test build #89938 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89938/testReport)** for PR 20937 at commit [`e0cebf4`](https://github.com/apache/spark/commit/e0

[GitHub] spark pull request #21178: [SPARK-24110][Thrift-Server] Avoid UGI.loginUserF...

2018-04-27 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/21178#discussion_r184784052 --- Diff: sql/hive-thriftserver/src/main/java/org/apache/hive/service/auth/HiveAuthFactory.java --- @@ -362,4 +371,34 @@ public static void verifyProxyAcce

[GitHub] spark issue #21145: [SPARK-24073][SQL]: Rename DataReaderFactory to ReadTask...

2018-04-27 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/21145 It sounds like both `ReadTask ` and `DataReaderFactory ` are not a good name here. Any better idea? --- - To unsubscribe, e-

[GitHub] spark pull request #21133: [SPARK-24013][SQL] Remove unneeded compress in Ap...

2018-04-27 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21133#discussion_r184778315 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproximatePercentile.scala --- @@ -238,12 +238,6 @@ object Ap

[GitHub] spark issue #21041: [SPARK-23962][SQL][TEST] Fix race in currentExecutionIds...

2018-04-27 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/21041 @dongjoon-hyun thanks for reporting this. I think this is the same as https://issues.apache.org/jira/browse/SPARK-23894 . I am nearly certain its not directly caused by this change, but some existi

[GitHub] spark pull request #21174: [SPARK-24085][SQL] Query returns UnsupportedOpera...

2018-04-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21174 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21182: [SPARK-24068] Propagating DataFrameReader's options to T...

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21182 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21182: [SPARK-24068] Propagating DataFrameReader's options to T...

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21182 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89929/ Test FAILed. ---

[GitHub] spark issue #21182: [SPARK-24068] Propagating DataFrameReader's options to T...

2018-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21182 **[Test build #89929 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89929/testReport)** for PR 21182 at commit [`8a8ff3f`](https://github.com/apache/spark/commit/8

[GitHub] spark issue #21174: [SPARK-24085][SQL] Query returns UnsupportedOperationExc...

2018-04-27 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/21174 Thanks! Merged to master/2.3 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mai

[GitHub] spark issue #21174: [SPARK-24085][SQL] Query returns UnsupportedOperationExc...

2018-04-27 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/21174 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.a

[GitHub] spark pull request #21178: [SPARK-24110][Thrift-Server] Avoid UGI.loginUserF...

2018-04-27 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/21178#discussion_r184774268 --- Diff: sql/hive-thriftserver/src/main/java/org/apache/hive/service/auth/HiveAuthFactory.java --- @@ -18,14 +18,11 @@ package org.apache.hive.servi

[GitHub] spark pull request #21178: [SPARK-24110][Thrift-Server] Avoid UGI.loginUserF...

2018-04-27 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/21178#discussion_r184774034 --- Diff: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIService.scala --- @@ -52,8 +52,22 @@ private[hive] class

[GitHub] spark issue #21184: [WIP][SPARK-24051][SQL] Replace Aliases with the same ex...

2018-04-27 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/21184 @hvanhovell I created this PR to discuss all together the problem in details with a basic solution which can help understanding better the problem. Honestly I am not happy with this change. So if w

[GitHub] spark pull request #21129: [SPARK-7132][ML] Add fit with validation set to s...

2018-04-27 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/21129#discussion_r184768987 --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/shared/SharedParamsCodeGen.scala --- @@ -95,7 +95,9 @@ private[shared] object SharedParamsCodeGe

[GitHub] spark issue #21184: [WIP][SPARK-24051][SQL] Replace Aliases with the same ex...

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21184 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21184: [WIP][SPARK-24051][SQL] Replace Aliases with the same ex...

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21184 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2727/ Tes

[GitHub] spark issue #21184: [WIP][SPARK-24051][SQL] Replace Aliases with the same ex...

2018-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21184 **[Test build #89937 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89937/testReport)** for PR 21184 at commit [`d676b62`](https://github.com/apache/spark/commit/d6

[GitHub] spark pull request #21184: [WIP][SPARK-24051][SQL] Replace Aliases with the ...

2018-04-27 Thread mgaido91
GitHub user mgaido91 opened a pull request: https://github.com/apache/spark/pull/21184 [WIP][SPARK-24051][SQL] Replace Aliases with the same exprId ## What changes were proposed in this pull request? If a user reuses the same column in different selects, it can happen that

[GitHub] spark issue #21183: [SPARK-22210][ML] Add seed for LDA variationalTopicInfer...

2018-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21183 **[Test build #89936 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89936/testReport)** for PR 21183 at commit [`e647e85`](https://github.com/apache/spark/commit/e

[GitHub] spark issue #21183: [SPARK-22210][ML] Add seed for LDA variationalTopicInfer...

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21183 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21183: [SPARK-22210][ML] Add seed for LDA variationalTopicInfer...

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21183 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89936/ Test PASSed. ---

[GitHub] spark issue #20701: [SPARK-23528][ML] Add numIter to ClusteringSummary

2018-04-27 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/20701 kindly ping @holdenk --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: review

[GitHub] spark pull request #21097: [SPARK-14682][ML] Provide evaluateEachIteration m...

2018-04-27 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/21097#discussion_r184760717 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/GBTClassifierSuite.scala --- @@ -365,6 +365,20 @@ class GBTClassifierSuite extends MLTe

[GitHub] spark pull request #21097: [SPARK-14682][ML] Provide evaluateEachIteration m...

2018-04-27 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/21097#discussion_r184763088 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/GBTRegressor.scala --- @@ -269,6 +269,21 @@ class GBTRegressionModel private[ml]( n

[GitHub] spark issue #21122: [SPARK-24017] [SQL] Refactor ExternalCatalog to be an in...

2018-04-27 Thread henryr
Github user henryr commented on the issue: https://github.com/apache/spark/pull/21122 cc @rdblue --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark

[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...

2018-04-27 Thread zecevicp
Github user zecevicp commented on the issue: https://github.com/apache/spark/pull/21109 I added benchmark code in `JoinBenchmark`. The tests show 8x improvement over non-optimized code. Although, it should be noted that the results depend on the exact range conditions and the calculat

[GitHub] spark issue #21183: [SPARK-22210][ML] Add seed for LDA variationalTopicInfer...

2018-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21183 **[Test build #89936 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89936/testReport)** for PR 21183 at commit [`e647e85`](https://github.com/apache/spark/commit/e6

[GitHub] spark issue #21183: [SPARK-22210][ML] Add seed for LDA variationalTopicInfer...

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21183 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21040: [SPARK-23930][SQL] Add slice function

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21040 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89923/ Test PASSed. ---

[GitHub] spark issue #21040: [SPARK-23930][SQL] Add slice function

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21040 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21028: [SPARK-23922][SQL] Add arrays_overlap function

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21028 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2726/ Tes

[GitHub] spark issue #21028: [SPARK-23922][SQL] Add arrays_overlap function

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21028 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21040: [SPARK-23930][SQL] Add slice function

2018-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21040 **[Test build #89923 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89923/testReport)** for PR 21040 at commit [`72ed607`](https://github.com/apache/spark/commit/7

[GitHub] spark issue #21028: [SPARK-23922][SQL] Add arrays_overlap function

2018-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21028 **[Test build #89935 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89935/testReport)** for PR 21028 at commit [`5925104`](https://github.com/apache/spark/commit/59

[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...

2018-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #89934 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89934/testReport)** for PR 21109 at commit [`fbec452`](https://github.com/apache/spark/commit/fb

[GitHub] spark pull request #21183: [SPARK-22210][ML] Add seed for LDA variationalTop...

2018-04-27 Thread ludatabricks
GitHub user ludatabricks opened a pull request: https://github.com/apache/spark/pull/21183 [SPARK-22210][ML] Add seed for LDA variationalTopicInference ## What changes were proposed in this pull request? - Add seed parameter for variationalTopicInference - Add seed

[GitHub] spark issue #21021: [SPARK-23921][SQL] Add array_sort function

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21021 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21021: [SPARK-23921][SQL] Add array_sort function

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21021 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2725/ Tes

[GitHub] spark issue #21028: [SPARK-23922][SQL] Add arrays_overlap function

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21028 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21028: [SPARK-23922][SQL] Add arrays_overlap function

2018-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21028 **[Test build #89932 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89932/testReport)** for PR 21028 at commit [`eafca0f`](https://github.com/apache/spark/commit/e

[GitHub] spark issue #21028: [SPARK-23922][SQL] Add arrays_overlap function

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21028 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89932/ Test FAILed. ---

[GitHub] spark issue #21021: [SPARK-23921][SQL] Add array_sort function

2018-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21021 **[Test build #89933 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89933/testReport)** for PR 21021 at commit [`175d981`](https://github.com/apache/spark/commit/17

[GitHub] spark issue #21028: [SPARK-23922][SQL] Add arrays_overlap function

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21028 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2724/ Tes

[GitHub] spark issue #21028: [SPARK-23922][SQL] Add arrays_overlap function

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21028 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21028: [SPARK-23922][SQL] Add arrays_overlap function

2018-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21028 **[Test build #89932 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89932/testReport)** for PR 21028 at commit [`eafca0f`](https://github.com/apache/spark/commit/ea

[GitHub] spark issue #21021: [SPARK-23921][SQL] Add array_sort function

2018-04-27 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/21021 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #21028: [SPARK-23922][SQL] Add arrays_overlap function

2018-04-27 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/21028#discussion_r184741553 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -19,14 +19,41 @@ package org.apache.spar

[GitHub] spark issue #21169: [SPARK-23715][SQL] the input of to/from_utc_timestamp ca...

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21169 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21021: [SPARK-23921][SQL] Add array_sort function

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21021 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21169: [SPARK-23715][SQL] the input of to/from_utc_timestamp ca...

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21169 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2723/ Tes

[GitHub] spark issue #21021: [SPARK-23921][SQL] Add array_sort function

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21021 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89925/ Test FAILed. ---

[GitHub] spark issue #21021: [SPARK-23921][SQL] Add array_sort function

2018-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21021 **[Test build #89925 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89925/testReport)** for PR 21021 at commit [`175d981`](https://github.com/apache/spark/commit/1

[GitHub] spark issue #21169: [SPARK-23715][SQL] the input of to/from_utc_timestamp ca...

2018-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21169 **[Test build #89931 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89931/testReport)** for PR 21169 at commit [`e9d1f24`](https://github.com/apache/spark/commit/e9

[GitHub] spark pull request #20490: [SPARK-23323][SQL]: Support commit coordinator fo...

2018-04-27 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/20490#discussion_r184736836 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2.scala --- @@ -116,21 +118,44 @@ object DataWritingSparkTa

[GitHub] spark issue #21181: [SPARK-23736][SQL][FOLLOWUP] Error message should contai...

2018-04-27 Thread mn-mikke
Github user mn-mikke commented on the issue: https://github.com/apache/spark/pull/21181 It makes sense. Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: revi

[GitHub] spark issue #21028: [SPARK-23922][SQL] Add arrays_overlap function

2018-04-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21028 **[Test build #89930 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89930/testReport)** for PR 21028 at commit [`076fc69`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #21028: [SPARK-23922][SQL] Add arrays_overlap function

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21028 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21028: [SPARK-23922][SQL] Add arrays_overlap function

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21028 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89930/ Test FAILed. ---

[GitHub] spark issue #21028: [SPARK-23922][SQL] Add arrays_overlap function

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21028 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21028: [SPARK-23922][SQL] Add arrays_overlap function

2018-04-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21028 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2722/ Tes

<    1   2   3   4   >