[GitHub] spark issue #21589: [SPARK-24591][CORE] Number of cores and executors in the...

2018-07-18 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/21589 It is precisely because the audience that I am concerned with is not limited to just data scientists or notebook users and their particular needs that I am far from convinced that exposing inter

[GitHub] spark pull request #21802: [SPARK-23928][SQL] Add shuffle collection functio...

2018-07-18 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21802#discussion_r203560440 --- Diff: python/pyspark/sql/functions.py --- @@ -2382,6 +2382,20 @@ def array_sort(col): return Column(sc._jvm.functions.array_sort(_to_java_column(

[GitHub] spark pull request #21488: SPARK-18057 Update structured streaming kafka fro...

2018-07-18 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/21488#discussion_r203561847 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsetReader.scala --- @@ -115,7 +116,7 @@ private[kafka010] class Kafk

[GitHub] spark issue #21589: [SPARK-24591][CORE] Number of cores and executors in the...

2018-07-18 Thread ssimeonov
Github user ssimeonov commented on the issue: https://github.com/apache/spark/pull/21589 @markhamstra I am confused about your API evaluation criteria. You are not arguing about the specific benefits these changes can provide immediately to an increasing majority of Spark use

[GitHub] spark issue #21808: [SPARK-21261][DOCS][SQL] SQL Regex document fix

2018-07-18 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/21808 Merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@

[GitHub] spark pull request #21811: [SPARK-24801][CORE] Avoid memory waste by empty b...

2018-07-18 Thread countmdm
GitHub user countmdm opened a pull request: https://github.com/apache/spark/pull/21811 [SPARK-24801][CORE] Avoid memory waste by empty byte[] arrays in SaslEncryption$EncryptedMessage ## What changes were proposed in this pull request? Initialize SaslEncryption$EncryptedMes

[GitHub] spark issue #21811: [SPARK-24801][CORE] Avoid memory waste by empty byte[] a...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21811 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21811: [SPARK-24801][CORE] Avoid memory waste by empty byte[] a...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21811 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21808: [SPARK-21261][DOCS][SQL] SQL Regex document fix

2018-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21808 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21811: [SPARK-24801][CORE] Avoid memory waste by empty byte[] a...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21811 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21811: [SPARK-24801][CORE] Avoid memory waste by empty byte[] a...

2018-07-18 Thread countmdm
Github user countmdm commented on the issue: https://github.com/apache/spark/pull/21811 Yes. On Wed, Jul 18, 2018 at 4:43 PM, UCB AMPLab wrote: > Can one of the admins verify this patch? > > — > You are receiving this because you authored the thread.

[GitHub] spark issue #20146: [SPARK-11215][ML] Add multiple columns support to String...

2018-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20146 **[Test build #93246 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93246/testReport)** for PR 20146 at commit [`c003bd3`](https://github.com/apache/spark/commit/c

[GitHub] spark issue #20146: [SPARK-11215][ML] Add multiple columns support to String...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20146 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20146: [SPARK-11215][ML] Add multiple columns support to String...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20146 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93246/ Test PASSed. ---

[GitHub] spark issue #21589: [SPARK-24591][CORE] Number of cores and executors in the...

2018-07-18 Thread markhamstra
Github user markhamstra commented on the issue: https://github.com/apache/spark/pull/21589 I don't accept you assertions of what constitutes the majority and minority of Spark users or use cases or their relative importance. As a long-time maintainer of the Spark scheduler, it is also

[GitHub] spark issue #20146: [SPARK-11215][ML] Add multiple columns support to String...

2018-07-18 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20146 It shows AppVeyor build failed. But I can't find the failed part in the details. Maybe I miss it? cc @felixcheung @HyukjinKwon --- -

[GitHub] spark issue #20146: [SPARK-11215][ML] Add multiple columns support to String...

2018-07-18 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20146 Seems it is timeout: `Build execution time has reached the maximum allowed time for your plan (90 minutes).` Can we set up the building time? --- ---

[GitHub] spark issue #21809: [SPARK-24851] : Map a Stage ID to it's Associated Job ID...

2018-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21809 **[Test build #93247 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93247/testReport)** for PR 21809 at commit [`7be0520`](https://github.com/apache/spark/commit/7

[GitHub] spark issue #21809: [SPARK-24851] : Map a Stage ID to it's Associated Job ID...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21809 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21809: [SPARK-24851] : Map a Stage ID to it's Associated Job ID...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21809 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93247/ Test PASSed. ---

[GitHub] spark issue #20838: [SPARK-23698] Resolve undefined names in Python 3

2018-07-18 Thread BryanCutler
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/20838 I don't think it's your PR, let's try again On Tue, Jul 17, 2018, 5:54 PM cclauss wrote: > Three (different) failures in a row. Should I break this PR into separate > PRs?

[GitHub] spark issue #20838: [SPARK-23698] Resolve undefined names in Python 3

2018-07-18 Thread BryanCutler
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/20838 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: review

[GitHub] spark issue #20838: [SPARK-23698] Resolve undefined names in Python 3

2018-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20838 **[Test build #93253 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93253/testReport)** for PR 20838 at commit [`2c4f15c`](https://github.com/apache/spark/commit/2c

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-18 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r203573819 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala --- @@ -270,11 +273,43 @@ private[state] c

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-18 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r203573621 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala --- @@ -64,21 +66,143 @@ class StateStoreSuite extends

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-18 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r203573306 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala --- @@ -64,21 +66,143 @@ class StateStoreSuite extends

[GitHub] spark issue #21533: [SPARK-24195][Core] Bug fix for local:/ path in SparkCon...

2018-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21533 **[Test build #4220 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4220/testReport)** for PR 21533 at commit [`eb46ccf`](https://github.com/apache/spark/commit/

[GitHub] spark issue #21799: [SPARK-24852][ML] Update spark.ml to use Instrumentation...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21799 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1107/

[GitHub] spark issue #21799: [SPARK-24852][ML] Update spark.ml to use Instrumentation...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21799 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21799: [SPARK-24852][ML] Update spark.ml to use Instrumentation...

2018-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21799 **[Test build #93254 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93254/testReport)** for PR 21799 at commit [`dddccf6`](https://github.com/apache/spark/commit/dd

[GitHub] spark issue #21451: [SPARK-24296][CORE][WIP] Replicate large blocks as a str...

2018-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21451 **[Test build #93250 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93250/testReport)** for PR 21451 at commit [`335e26d`](https://github.com/apache/spark/commit/3

[GitHub] spark issue #21451: [SPARK-24296][CORE][WIP] Replicate large blocks as a str...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21451 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21451: [SPARK-24296][CORE][WIP] Replicate large blocks as a str...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21451 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93250/ Test FAILed. ---

[GitHub] spark issue #21804: [SPARK-24268][SQL] Use datatype.catalogString in error m...

2018-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21804 **[Test build #93252 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93252/testReport)** for PR 21804 at commit [`5ffc793`](https://github.com/apache/spark/commit/5

[GitHub] spark issue #21804: [SPARK-24268][SQL] Use datatype.catalogString in error m...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21804 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21804: [SPARK-24268][SQL] Use datatype.catalogString in error m...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21804 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93252/ Test FAILed. ---

[GitHub] spark issue #21805: [SPARK-24850][SQL] fix str representation of CachedRDDBu...

2018-07-18 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21805 Can you add tests? cc: @gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-18 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r203577561 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala --- @@ -64,21 +66,143 @@ class StateStoreSuite e

[GitHub] spark issue #21810: [SPARK-24854][SQL] Gathering all Avro options into the A...

2018-07-18 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21810 Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-18 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r203577783 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala --- @@ -270,11 +273,43 @@ private[s

[GitHub] spark issue #21729: [SPARK-24755][Core] Executor loss can cause task to not ...

2018-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21729 **[Test build #93248 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93248/testReport)** for PR 21729 at commit [`f9ed226`](https://github.com/apache/spark/commit/f

[GitHub] spark issue #21806: [SPARK-24846][SQL] Made hashCode ExprId independent of j...

2018-07-18 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21806 LGTM too --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spa

[GitHub] spark issue #20856: [SPARK-23731][SQL] FileSourceScanExec throws NullPointer...

2018-07-18 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20856 cc @hvanhovell too --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: review

[GitHub] spark issue #21729: [SPARK-24755][Core] Executor loss can cause task to not ...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21729 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93248/ Test PASSed. ---

[GitHub] spark issue #21729: [SPARK-24755][Core] Executor loss can cause task to not ...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21729 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark pull request #21810: [SPARK-24854][SQL] Gathering all Avro options int...

2018-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21810 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21451: [SPARK-24296][CORE][WIP] Replicate large blocks as a str...

2018-07-18 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/21451 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h..

[GitHub] spark issue #21451: [SPARK-24296][CORE][WIP] Replicate large blocks as a str...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21451 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1108/

[GitHub] spark issue #21451: [SPARK-24296][CORE][WIP] Replicate large blocks as a str...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21451 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21451: [SPARK-24296][CORE][WIP] Replicate large blocks as a str...

2018-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21451 **[Test build #93255 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93255/testReport)** for PR 21451 at commit [`335e26d`](https://github.com/apache/spark/commit/33

[GitHub] spark issue #21729: [SPARK-24755][Core] Executor loss can cause task to not ...

2018-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21729 **[Test build #93249 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93249/testReport)** for PR 21729 at commit [`6316e5b`](https://github.com/apache/spark/commit/6

[GitHub] spark issue #21729: [SPARK-24755][Core] Executor loss can cause task to not ...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21729 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93249/ Test PASSed. ---

[GitHub] spark issue #21729: [SPARK-24755][Core] Executor loss can cause task to not ...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21729 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21700: [SPARK-24717][SS] Split out max retain version of state ...

2018-07-18 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/spark/pull/21700 @tdas Addressed review comments. Please take a look again. Thanks in advance! --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark issue #21777: [WIP][SPARK-24498][SQL] Add JDK compiler for runtime cod...

2018-07-18 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21777 > Except the TPC-DS queries, are we able to find some workloads that could perform faster using the bytecode generated by the JDK compiler? Since I don't have real workloads or non-TPCDS quer

[GitHub] spark issue #21700: [SPARK-24717][SS] Split out max retain version of state ...

2018-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21700 **[Test build #93256 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93256/testReport)** for PR 21700 at commit [`cf78a2a`](https://github.com/apache/spark/commit/cf

[GitHub] spark issue #21589: [SPARK-24591][CORE] Number of cores and executors in the...

2018-07-18 Thread ssimeonov
Github user ssimeonov commented on the issue: https://github.com/apache/spark/pull/21589 > Repartitioning based upon a snapshot of the number of cores available cluster-wide is clearly not the correct thing to do in many instances and use cases. I wholeheartedly agree and I c

[GitHub] spark pull request #21635: [SPARK-24594][YARN] Introducing metrics for YARN

2018-07-18 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/21635#discussion_r203580155 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMasterSource.scala --- @@ -0,0 +1,49 @@ +/* + * Licensed

[GitHub] spark issue #21469: [SPARK-24441][SS] Expose total estimated size of states ...

2018-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21469 **[Test build #93257 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93257/testReport)** for PR 21469 at commit [`32d0418`](https://github.com/apache/spark/commit/32

[GitHub] spark issue #21589: [SPARK-24591][CORE] Number of cores and executors in the...

2018-07-18 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21589 I wouldn't argue who more take care of or represent users or not though. That's easily biased. If there's a technical concern from a committer or PMC, I wouldn't go for it. --- --

[GitHub] spark pull request #21440: [SPARK-24307][CORE] Support reading remote cached...

2018-07-18 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/21440#discussion_r203581903 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -659,6 +659,11 @@ private[spark] class BlockManager( * Get block

[GitHub] spark issue #21739: [SPARK-22187][SS] Update unsaferow format for saved stat...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21739 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21739: [SPARK-22187][SS] Update unsaferow format for saved stat...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21739 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1109/

[GitHub] spark issue #21739: [SPARK-22187][SS] Update unsaferow format for saved stat...

2018-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21739 **[Test build #93258 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93258/testReport)** for PR 21739 at commit [`c262e87`](https://github.com/apache/spark/commit/c2

[GitHub] spark issue #21803: [SPARK-24849][SQL] Converting a value of StructType to a...

2018-07-18 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21803 (As I described in the jira) What's this func is used for? Is this related to the other work? --- - To unsubscribe, e-mail: revie

[GitHub] spark pull request #21812: SPARK UI K8S : this parameter's illustration(spar...

2018-07-18 Thread hehuiyuan
GitHub user hehuiyuan opened a pull request: https://github.com/apache/spark/pull/21812 SPARK UI K8S : this parameter's illustration(spark.kubernetes.executor.label.[LabelName] ) [链接地址:](http://spark.apache.org/docs/2.3.0/running-on-kubernetes.html) ![k8

[GitHub] spark issue #21533: [SPARK-24195][Core] Bug fix for local:/ path in SparkCon...

2018-07-18 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21533 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: revie

[GitHub] spark pull request #21803: [SPARK-24849][SQL] Converting a value of StructTy...

2018-07-18 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21803#discussion_r203584039 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructType.scala --- @@ -436,6 +436,14 @@ object StructType extends AbstractDataType {

[GitHub] spark issue #21812: SPARK UI K8S : this parameter's illustration(spark.kuber...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21812 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21812: SPARK UI K8S : this parameter's illustration(spark.kuber...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21812 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21812: SPARK UI K8S : this parameter's illustration(spark.kuber...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21812 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21533: [SPARK-24195][Core] Bug fix for local:/ path in SparkCon...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21533 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21533: [SPARK-24195][Core] Bug fix for local:/ path in SparkCon...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21533 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1110/

[GitHub] spark pull request #21734: [SPARK-24149][YARN][FOLLOW-UP] Add a config to co...

2018-07-18 Thread LantaoJin
Github user LantaoJin commented on a diff in the pull request: https://github.com/apache/spark/pull/21734#discussion_r203584220 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala --- @@ -193,8 +193,7 @@ object YarnSparkHadoopUtil

[GitHub] spark issue #21533: [SPARK-24195][Core] Bug fix for local:/ path in SparkCon...

2018-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21533 **[Test build #93259 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93259/testReport)** for PR 21533 at commit [`eb46ccf`](https://github.com/apache/spark/commit/eb

[GitHub] spark issue #21799: [SPARK-24852][ML] Update spark.ml to use Instrumentation...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21799 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21799: [SPARK-24852][ML] Update spark.ml to use Instrumentation...

2018-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21799 **[Test build #93254 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93254/testReport)** for PR 21799 at commit [`dddccf6`](https://github.com/apache/spark/commit/d

[GitHub] spark issue #21799: [SPARK-24852][ML] Update spark.ml to use Instrumentation...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21799 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93254/ Test PASSed. ---

[GitHub] spark issue #20146: [SPARK-11215][ML] Add multiple columns support to String...

2018-07-18 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20146 Yea, that looks due to time limit. I am seeing sometimes it hit the time limit issue. The problem is, it's kind of difficult to increase the build time (see also https://github.com/appv

[GitHub] spark issue #20146: [SPARK-11215][ML] Add multiple columns support to String...

2018-07-18 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20146 Meanwhile, will try to take another look to reduce the time, or see if we can split the test, or we can request the time limit increase again as a last resort. --- ---

[GitHub] spark issue #21638: [SPARK-22357][CORE] SparkContext.binaryFiles ignore minP...

2018-07-18 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21638 Yea, it's internal to Spark. Might be good to keep it but that concern should be secondary IMHO. --- - To unsubscribe, e-mai

[GitHub] spark issue #21782: [SPARK-24816][SQL] SQL interface support repartitionByRa...

2018-07-18 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/21782 cc @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@s

[GitHub] spark pull request #21804: [SPARK-24268][SQL] Use datatype.catalogString in ...

2018-07-18 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21804#discussion_r203585703 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/AbstractDataType.scala --- @@ -145,7 +145,7 @@ abstract class NumericType extends AtomicTyp

[GitHub] spark issue #11005: [SPARK-12506][SPARK-12126][SQL]use CatalystScan for JDBC...

2018-07-18 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/11005 Technical reason: It's kind of risky to rely on `CatalystScan` and completely replace the interface. I think I already see some tests were disabled here. Also, there look potential better sugges

[GitHub] spark issue #11005: [SPARK-12506][SPARK-12126][SQL]use CatalystScan for JDBC...

2018-07-18 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/11005 BTW, datasource v2 is in progress too to allow more push downs (see [SPARK-22386](https://issues.apache.org/jira/browse/SPARK-22386)). You might want to take a look --- --

[GitHub] spark issue #21812: SPARK UI K8S : this parameter's illustration(spark.kuber...

2018-07-18 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21812 @hehuiyuan, please ask a question via a mailing list. See also https://spark.apache.org/community.html --- - To unsubscribe,

[GitHub] spark issue #21781: [INFRA] Close stale PR

2018-07-18 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21781 Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark pull request #19420: [SPARK-22191] [SQL] Add hive serde example with s...

2018-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19420 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18125: [SPARK-20891][SQL] Reduce duplicate code typedagg...

2018-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18125 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19456: [SPARK] [Scheduler] Configurable default scheduli...

2018-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19456 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #17092: [SPARK-18450][ML] Scala API Change for LSH AND-am...

2018-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17092 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #17619: [SPARK-19755][Mesos] Blacklist is always active f...

2018-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17619 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #17973: [SPARK-20731][SQL] Add ability to change or omit ...

2018-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17973 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18229: [SPARK-20691][CORE] Difference between Storage Me...

2018-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18229 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20304: [SPARK-23139]Read eventLog file with mixed encodi...

2018-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20304 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21261: [SPARK-24203][core] Add spark.executor.bindAddres...

2018-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21261 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20177: [SPARK-22954][SQL] Fix the exception thrown by An...

2018-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20177 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #17894: [WIP][SPARK-17134][ML] Use level 2 BLAS operation...

2018-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17894 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18034: [SPARK-20797][MLLIB]fix LocalLDAModel.save() bug.

2018-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18034 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20319: [SPARK-22884][ML][TESTS] ML test for StructuredSt...

2018-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20319 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

<    1   2   3   4   5   6   >