Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/22001#discussion_r209272468
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -577,4 +577,17 @@ package object config {
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/22001#discussion_r209275201
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -929,6 +955,28 @@ class DAGScheduler(
// HadoopRDD whose
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/22001#discussion_r209277632
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -203,6 +203,17 @@ class DAGScheduler(
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/22001#discussion_r209273451
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -577,4 +577,17 @@ package object config {
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/22001#discussion_r209294652
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/CoarseGrainedSchedulerBackendSuite.scala
---
@@ -38,4 +46,83 @@ class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/22062#discussion_r209292284
--- Diff:
core/src/test/scala/org/apache/spark/shuffle/sort/ShuffleExternalSorterSuite.scala
---
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/22062#discussion_r209291439
--- Diff:
core/src/test/scala/org/apache/spark/shuffle/sort/ShuffleExternalSorterSuite.scala
---
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22011#discussion_r209289539
--- Diff: python/pyspark/rdd.py ---
@@ -2406,6 +2406,26 @@ def toLocalIterator(self):
sock_info =
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22063
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22011#discussion_r209287104
--- Diff: python/pyspark/rdd.py ---
@@ -2406,6 +2406,26 @@ def toLocalIterator(self):
sock_info =
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22063
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94567/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22063
**[Test build #94567 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94567/testReport)**
for PR 22063 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22068
Would it be better to update a comment in `DataFrameWriter.scala`, too?
```
* `compression` (default is the value specified in
`spark.sql.parquet.compression.codec`):
*
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22067
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94556/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22067
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22067
**[Test build #94556 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94556/testReport)**
for PR 22067 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22063
**[Test build #94567 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94567/testReport)**
for PR 22063 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22063
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22063
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22069
**[Test build #4239 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4239/testReport)**
for PR 22069 at commit
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22066#discussion_r209275505
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2831,4 +2831,17 @@ class SQLQuerySuite extends QueryTest with
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22069
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94555/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22069
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22069
**[Test build #94555 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94555/testReport)**
for PR 22069 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22001
**[Test build #94566 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94566/testReport)**
for PR 22001 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22011
**[Test build #94565 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94565/testReport)**
for PR 22011 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22066
**[Test build #94564 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94564/testReport)**
for PR 22066 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22001
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22001
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22011
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22011
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user mengxr commented on the issue:
https://github.com/apache/spark/pull/22001
test this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user mengxr commented on the issue:
https://github.com/apache/spark/pull/22011
@jiangxb1987 Please mention that tests will be added in a follow-up PR that
implements BarrierTaskContext.
---
-
To unsubscribe,
Github user mengxr commented on the issue:
https://github.com/apache/spark/pull/22011
test this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22007
**[Test build #94563 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94563/testReport)**
for PR 22007 at commit
Github user yucai commented on a diff in the pull request:
https://github.com/apache/spark/pull/22066#discussion_r209267827
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/hash.scala
---
@@ -778,21 +783,22 @@ case class HiveHash(children:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21732
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94554/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21732
**[Test build #94554 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94554/testReport)**
for PR 21732 at commit
Github user yucai commented on a diff in the pull request:
https://github.com/apache/spark/pull/22066#discussion_r209265323
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2831,4 +2831,17 @@ class SQLQuerySuite extends QueryTest with
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22066#discussion_r209260954
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2831,4 +2831,17 @@ class SQLQuerySuite extends QueryTest with
Github user LantaoJin commented on the issue:
https://github.com/apache/spark/pull/22066
Since you refactor your code copying from #22067 . Would you mind just use
that?
---
-
To unsubscribe, e-mail:
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/22062#discussion_r209262151
--- Diff:
core/src/main/java/org/apache/spark/shuffle/sort/ShuffleInMemorySorter.java ---
@@ -94,12 +94,20 @@ public int numRecords() {
}
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22067
**[Test build #94562 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94562/testReport)**
for PR 22067 at commit
Github user LantaoJin commented on the issue:
https://github.com/apache/spark/pull/22067
Add unit test with a rand() column in 'distribute by'
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user tgravescs commented on the issue:
https://github.com/apache/spark/pull/22053
Sounds like its not a correctness issue. I wasn't aware we were support
sparc, although looking at our docs I don't see that we list anything
explicitly. This is listed as an improvement and
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22066#discussion_r209259163
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/hash.scala
---
@@ -778,21 +783,22 @@ case class HiveHash(children:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22007
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22007
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94553/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22007
**[Test build #94553 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94553/testReport)**
for PR 22007 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22063
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94561/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22063
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22063
**[Test build #94561 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94561/testReport)**
for PR 22063 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22063
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21561#discussion_r209256325
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeans.scala ---
@@ -151,13 +152,9 @@ class BisectingKMeans private (
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21561#discussion_r209256004
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/NaiveBayes.scala ---
@@ -157,11 +157,15 @@ class NaiveBayes @Since("1.5.0") (
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22063
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22063
**[Test build #94561 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94561/testReport)**
for PR 22063 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22065
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22065
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94551/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22065
**[Test build #94551 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94551/testReport)**
for PR 22065 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22053
**[Test build #94560 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94560/testReport)**
for PR 22053 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22053
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22053
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22053
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user habren commented on the issue:
https://github.com/apache/spark/pull/21868
@HyukjinKwon Thanks for your comments. I will submit it to master soon
---
-
To unsubscribe, e-mail:
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22059
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22058
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22058
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22059
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21369
**[Test build #94559 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94559/testReport)**
for PR 21369 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21369
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/21369
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22070
**[Test build #4238 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4238/testReport)**
for PR 22070 at commit
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22070#discussion_r209242281
--- Diff: examples/src/main/python/sql/arrow.py ---
@@ -95,12 +95,12 @@ def grouped_map_pandas_udf_example(spark):
("id", "v"))
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22070#discussion_r209242073
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/sasl/SaslEncryption.java
---
@@ -231,17 +231,17 @@ public boolean release(int
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22068
**[Test build #4237 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4237/testReport)**
for PR 22068 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22064
**[Test build #4236 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4236/testReport)**
for PR 22064 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22068
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94550/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22037
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22011
**[Test build #94549 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94549/testReport)**
for PR 22011 at commit
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/22037
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22011
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94549/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22037
**[Test build #94558 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94558/testReport)**
for PR 22037 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22011
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22037
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22068
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22068
**[Test build #94550 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94550/testReport)**
for PR 22068 at commit
Github user yucai commented on the issue:
https://github.com/apache/spark/pull/22066
@cloud-fan @gatorsmile PR has been ready, kindly help review.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22066
**[Test build #94557 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94557/testReport)**
for PR 22066 at commit
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/spark/pull/22010#discussion_r209230417
--- Diff: core/src/test/scala/org/apache/spark/rdd/RDDSuite.scala ---
@@ -95,6 +95,18 @@ class RDDSuite extends SparkFunSuite with
SharedSparkContext {
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/spark/pull/22010#discussion_r209230438
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
@@ -396,7 +396,16 @@ abstract class RDD[T: ClassTag](
* Return a new RDD
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22053
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22053
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94548/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22053
**[Test build #94548 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94548/testReport)**
for PR 22053 at commit
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/22064
LGTM FWIW
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22037
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22037
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94552/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22037
**[Test build #94552 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94552/testReport)**
for PR 22037 at commit
301 - 400 of 526 matches
Mail list logo