Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22270
**[Test build #95457 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95457/testReport)**
for PR 22270 at commit
[`b83fa29`](https://github.com/apache/spark/commit/b8
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22270
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2693/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22270
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22198
Thanks for understanding, @maropu . Yes. We need to build consensus.
@gatorsmile and @cloud-fan . Could you give us a directional advice for
this PR? Basically, we are wondering if we
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7#discussion_r213913244
--- Diff: sql/core/src/test/resources/sql-tests/inputs/string-functions.sql
---
@@ -47,3 +47,7 @@ FROM (
encode(string(id + 3), 'utf-8') col4
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22197
**[Test build #95456 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95456/testReport)**
for PR 22197 at commit
[`41a7b83`](https://github.com/apache/spark/commit/41
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22260
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22260
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95452/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22260
**[Test build #95452 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95452/testReport)**
for PR 22260 at commit
[`2dff17b`](https://github.com/apache/spark/commit/2
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22204
ah, how about adding a new method in `SparkSession` e.g.,
`SparkSession.analyzeColumnCacheQuery`?
---
-
To unsubscribe, e-mail: r
Github user yucai commented on a diff in the pull request:
https://github.com/apache/spark/pull/22197#discussion_r213912108
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
---
@@ -1021,6 +1022,113 @@ class ParquetFilter
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22276
We can think about this API change in 3.0 release. Now, Spark 2.4 release
is not allowed to break the binary compatibility.
---
-
Github user MichaelChirico commented on the issue:
https://github.com/apache/spark/pull/22278
@HyukjinKwon this is about usability/user-friendliness. As mentioned,
despite being a seasoned R user & increasingly familiar with `SparkR`
documentation, I spent several minutes googling abo
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22138
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95450/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22138
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22138
**[Test build #95450 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95450/testReport)**
for PR 22138 at commit
[`7d13ee5`](https://github.com/apache/spark/commit/7
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22204
@maropu . Is this PR suggesting that the user need to use
`CacheManager.analyzeColumnCacheQuery`? In general `CacheManager` is internal
to Spark SQL, isn't it?
---
---
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22197#discussion_r213906227
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
---
@@ -1021,6 +1022,113 @@ class ParquetFi
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22267
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95453/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22267
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22267
**[Test build #95453 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95453/testReport)**
for PR 22267 at commit
[`cdbf81a`](https://github.com/apache/spark/commit/c
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22263#discussion_r213904343
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -162,7 +162,8 @@ statement
tableIdentifier partiti
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22197
**[Test build #95455 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95455/testReport)**
for PR 22197 at commit
[`04b88c5`](https://github.com/apache/spark/commit/04
Github user LuciferYang commented on the issue:
https://github.com/apache/spark/pull/22149
> Is that possible to add a test case?
Thanks for your reply Xiao, I tried to add a test case to reproduce bad
case, but it only reproduce in small probabilityï¼we need to ensure that Task
Github user yucai commented on the issue:
https://github.com/apache/spark/pull/22197
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22197
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22197
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95449/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22197
**[Test build #95449 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95449/testReport)**
for PR 22197 at commit
[`cb03fb7`](https://github.com/apache/spark/commit/c
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22198
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95448/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22198
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22278
I think there are many same instances. We should fix them everywhere
consistently. But I don't think it's worth enough fixing everywhere. It's
marked as deprecated and so it's deprecated, isn't
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22198
**[Test build #95448 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95448/testReport)**
for PR 22198 at commit
[`9a6da27`](https://github.com/apache/spark/commit/9
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22197
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95454/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22197
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22197
**[Test build #95454 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95454/testReport)**
for PR 22197 at commit
[`04b88c5`](https://github.com/apache/spark/commit/0
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22278
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22278
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22278
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user MichaelChirico opened a pull request:
https://github.com/apache/spark/pull/22278
emphasize deprecation
Was poking around documentation for `formals` of this method as I'd seen it
recommended and completely missed the `Deprecated` tag; even after seeing
elsewhere it's de
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22277
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22277
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22277
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user ajithme opened a pull request:
https://github.com/apache/spark/pull/22277
[SPARK-25276] Redundant constrains when using alias
Attaching a test to reproduce the issue. The test fails with following
message
test("redundant constrains") {
val tr = LocalRe
Github user sadhen closed the pull request at:
https://github.com/apache/spark/pull/22264
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
GitHub user sadhen reopened a pull request:
https://github.com/apache/spark/pull/22264
[SPARK-25256][SQL] Plan mismatch errors in Hive tests in 2.12
## What changes were proposed in this pull request?
### For `SPARK-5775 read array from
partitioned_parquet_with_key_and_comp
Github user sadhen commented on the issue:
https://github.com/apache/spark/pull/22264
@srowen please review, and this PR should be rebased on #22260 and then
tested.
---
-
To unsubscribe, e-mail: reviews-unsubscr..
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22209
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22209
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95444/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22209
**[Test build #95444 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95444/testReport)**
for PR 22209 at commit
[`b164bb1`](https://github.com/apache/spark/commit/b
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19691
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95451/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19691
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19691
**[Test build #95451 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95451/testReport)**
for PR 19691 at commit
[`6b18939`](https://github.com/apache/spark/commit/6
Github user tnachen commented on the issue:
https://github.com/apache/spark/pull/22146
I've been looking to mount additional volumes to the executor containers
and just tried out the PR.
It doesn't seem possible since if you add the container in the pod
template, BasicExecutorFeat
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22276
oh, yes, this is the issue of binary compatibility...
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For addit
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/2
Got it, I'll revert the changes in file source in this commit, thanks for
your reply.
---
-
To unsubscribe, e-mail: reviews
Github user yucai commented on the issue:
https://github.com/apache/spark/pull/22197
@cloud-fan I reverted to the previous version.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional co
Github user yucai commented on the issue:
https://github.com/apache/spark/pull/22197
@dongjoon-hyun Sorry for the late response, description is changed to:
> Although filter "ID < 100L" is generated by Spark, it fails to pushdown
into parquet actually, Spark still does the ful
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21721
Since I'm continuously working on data source v2 API, this gets my
attention. Do we have a story for the metrics in data source v2 streaming API?
It's weird to me that we add public APIs that only
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22274
@HyukjinKwon Sure.. here is the info. Please let me know if you need
anything else.
```
> sessionInfo()
R version 3.5.1 (2018-07-02)
Platform: x86_64-apple-darwin15.6.0 (64-b
Github user squito commented on the issue:
https://github.com/apache/spark/pull/22265
ah, of course, `_exception_message` is only used in the exception handling,
so we never get an error about an undefined name in any of the tests. Ok,
thanks for the explanations, I appreciate it!
Github user squito commented on the issue:
https://github.com/apache/spark/pull/22273
I'm kinda 'meh' / -0 on this change. My issue wasn't so much not seeing
something printed out, it was more (a) python output isn't integrated into
jenkins test reports and (b) I'm still learning my
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22197
**[Test build #95454 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95454/testReport)**
for PR 22197 at commit
[`04b88c5`](https://github.com/apache/spark/commit/04
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22267
**[Test build #95453 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95453/testReport)**
for PR 22267 at commit
[`cdbf81a`](https://github.com/apache/spark/commit/cd
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22267
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2692/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22267
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22260
LGTM, too.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.
Github user xuejianbest commented on a diff in the pull request:
https://github.com/apache/spark/pull/22048#discussion_r213888028
--- Diff: core/src/test/scala/org/apache/spark/util/UtilsSuite.scala ---
@@ -1184,6 +1184,25 @@ class UtilsSuite extends SparkFunSuite with
ResetSystemP
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22260
**[Test build #95452 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95452/testReport)**
for PR 22260 at commit
[`2dff17b`](https://github.com/apache/spark/commit/2d
Github user sadhen commented on the issue:
https://github.com/apache/spark/pull/22260
@maropu @srowen please review
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22237#discussion_r213886899
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/FailureSafeParser.scala
---
@@ -15,50 +15,51 @@
* limitations under the Licen
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22237#discussion_r213885777
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -554,18 +554,28 @@ case class JsonToStructs(
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22237#discussion_r213885328
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -554,18 +554,28 @@ case class JsonToStructs(
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22184
see `ParquetOptions`. Option can be specified per-query while SQL conf is
per-session.
---
-
To unsubscribe, e-mail: reviews-u
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22267#discussion_r213885090
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
---
@@ -1021,6 +1021,18 @@ class ParquetFil
Github user sadhen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22260#discussion_r213884979
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ProjectionOverSchema.scala
---
@@ -38,7 +38,7 @@ private[execution] case class
ProjectionO
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r213884870
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelperSuite.scala
---
@@ -35,6 +35,24 @@ class ExpressionEv
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22048#discussion_r213884655
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -301,16 +301,16 @@ class Dataset[T] private[sql](
// Compute the width
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/2
can we do it for data source v2 first? It seems hard to fix the file
source, as its reader function may lie about the return type.
Let's see what's the simplest fix to remove the hack for
Github user sadhen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22260#discussion_r213884559
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala ---
@@ -19,7 +19,7 @@ package org.apache.spark.sql.hive
imp
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22276
?? This doesn't break source compatibility but breaks binary compatibility.
---
-
To unsubscribe, e-mail: reviews-unsubscr...
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22275
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95441/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22275
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19691
@DazhuangSu Are u there?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: revie
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22275
**[Test build #95441 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95441/testReport)**
for PR 22275 at commit
[`d6fefee`](https://github.com/apache/spark/commit/d
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21912#discussion_r213884198
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -385,107 +385,124 @@ case class MapEntr
Github user sadhen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22260#discussion_r213884075
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala ---
@@ -19,7 +19,7 @@ package org.apache.spark.sql.hive
imp
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21912#discussion_r213883747
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java
---
@@ -452,6 +452,16 @@ public UnsafeArrayData copy(
Github user xuejianbest commented on a diff in the pull request:
https://github.com/apache/spark/pull/22048#discussion_r213883324
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -2794,6 +2794,27 @@ private[spark] object Utils extends Logging {
}
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22274
> The "date function on DataFrame" test fails consistently on my laptop.
@dilipbiswal, would you mind if I ask to list up R version (and additional
env information if possible)?
---
-
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22197
> Is it acceptable?
apparently not...
OK let's just check duplicated filed names twice: one in filter pushdown,
one in column pruning. And clean it up in followup PRs.
---
Github user xuejianbest commented on a diff in the pull request:
https://github.com/apache/spark/pull/22048#discussion_r213882803
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -301,16 +301,16 @@ class Dataset[T] private[sql](
// Compute the w
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19691
**[Test build #95451 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95451/testReport)**
for PR 19691 at commit
[`6b18939`](https://github.com/apache/spark/commit/6b
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21977#discussion_r213882447
--- Diff:
core/src/main/scala/org/apache/spark/api/python/PythonRunner.scala ---
@@ -62,14 +63,20 @@ private[spark] object PythonEvalType {
*/
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19691
Could anyone take over this then?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19691
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@s
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22253#discussion_r213881717
--- Diff:
sql/core/src/test/java/test/org/apache/spark/sql/JavaColumnExpressionSuite.java
---
@@ -0,0 +1,80 @@
+package test.org.apache.spark.sql;
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22253#discussion_r213881608
--- Diff:
sql/core/src/test/java/test/org/apache/spark/sql/JavaColumnExpressionSuite.java
---
@@ -0,0 +1,80 @@
+package test.org.apache.spark.sql;
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22255
I would also rather write the justification for this change, for instance,
linking the usage of this name in Parquet side, potential usage, etc.
---
---
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22255#discussion_r213881049
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetWriteSupport.scala
---
@@ -29,6 +29,7 @@ import org.apache.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22266#discussion_r213880767
--- Diff: dev/lint-python ---
@@ -82,6 +82,26 @@ else
rm "$PYCODESTYLE_REPORT_PATH"
fi
+python -m pip install flake8
--- End
1 - 100 of 586 matches
Mail list logo