[GitHub] spark issue #22402: [SPARK-25414][SS][TEST] make it clear that the numRows m...

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22402 **[Test build #96056 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96056/testReport)** for PR 22402 at commit

[GitHub] spark issue #17400: [SPARK-19981][SQL] Respect aliases in output partitionin...

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17400 **[Test build #96061 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96061/testReport)** for PR 17400 at commit

[GitHub] spark issue #20433: [SPARK-23264][SQL] Make INTERVAL keyword optional in INT...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20433 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22204: [SPARK-25196][SQL] Extends Analyze commands for cached t...

2018-09-13 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/22204 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20433: [SPARK-23264][SQL] Make INTERVAL keyword optional in INT...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20433 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #17400: [SPARK-19981][SQL] Respect aliases in output partitionin...

2018-09-13 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/17400 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20433: [SPARK-23264][SQL] Make INTERVAL keyword optional in INT...

2018-09-13 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20433 I'll update the migration guide when bumping up master branch version to next one. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20433: [SPARK-23264][SQL] Make INTERVAL keyword optional in INT...

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20433 **[Test build #96060 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96060/testReport)** for PR 20433 at commit

[GitHub] spark issue #22418: [SPARK-25427][SQL][TEST] Add BloomFilter creation test c...

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22418 **[Test build #96059 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96059/testReport)** for PR 22418 at commit

[GitHub] spark issue #22418: [SPARK-25427][SQL][TEST] Add BloomFilter creation test c...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22418 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22418: [SPARK-25427][SQL][TEST] Add BloomFilter creation test c...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22418 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22418: [SPARK-25427][SQL][TEST] Add BloomFilter creation...

2018-09-13 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/22418 [SPARK-25427][SQL][TEST] Add BloomFilter creation test cases ## What changes were proposed in this pull request? Spark supports BloomFilter creation for ORC files. This PR aims to

[GitHub] spark issue #22408: [SPARK-25417][SQL] ArrayContains function may return inc...

2018-09-13 Thread dilipbiswal
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/22408 @ushin @gatorsmile Here are the results from presto. Please let me know if you want me try any case in particular. One thing to note is that presto allows comparison between int and decimal. In

[GitHub] spark issue #22408: [SPARK-25417][SQL] ArrayContains function may return inc...

2018-09-13 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/22408 My general idea is to avoid risky implicit type casting at the beginning. We can relax it in the future, if needed. After all, users can manually cast the types after seeing the reasonable error

[GitHub] spark issue #22408: [SPARK-25417][SQL] ArrayContains function may return inc...

2018-09-13 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/22408 What is the corresponding behavior in Presto? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #22410: [SPARK-25418][SQL] The metadata of DataSource tab...

2018-09-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22410 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22408: [SPARK-25417][SQL] ArrayContains function may ret...

2018-09-13 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/22408#discussion_r217603789 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala --- @@ -735,6 +735,44 @@ class DataFrameFunctionsSuite extends

[GitHub] spark pull request #22038: [SPARK-25056][SQL] Unify the InConversion and Bin...

2018-09-13 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/22038#discussion_r217603577 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -485,8 +494,8 @@ object TypeCoercion {

[GitHub] spark issue #22038: [SPARK-25056][SQL] Unify the InConversion and BinaryComp...

2018-09-13 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/22038 @wangyum Can you put the sammary of the other databases behaivours in the PR description? --- - To unsubscribe, e-mail:

[GitHub] spark issue #22410: [SPARK-25418][SQL] The metadata of DataSource table shou...

2018-09-13 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/22410 LGTM Thanks! Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22410: [SPARK-25418][SQL] The metadata of DataSource tab...

2018-09-13 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/22410#discussion_r217603253 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -1309,6 +1312,8 @@ object HiveExternalCatalog {

[GitHub] spark issue #22408: [SPARK-25417][SQL] ArrayContains function may return inc...

2018-09-13 Thread dilipbiswal
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/22408 @maropu This is the case we were discussing for which @ueshin suggested using `findWiderTypeWithoutStringPromotion`. Lets see what @cloud-fan and @gatorsmile think and we will do accordingly.

[GitHub] spark issue #22408: [SPARK-25417][SQL] ArrayContains function may return inc...

2018-09-13 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/22408 How about this decimal case? ``` // v2.3.1 scala> spark.range(10).selectExpr("cast(id AS decimal(9, 0)) as value").selectExpr("array_contains(array(1, 2, 3), value)").show

[GitHub] spark pull request #22408: [SPARK-25417][SQL] ArrayContains function may ret...

2018-09-13 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/22408#discussion_r217601459 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala --- @@ -735,6 +735,44 @@ class DataFrameFunctionsSuite extends

[GitHub] spark issue #22408: [SPARK-25417][SQL] ArrayContains function may return inc...

2018-09-13 Thread dilipbiswal
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/22408 @maropu I thought we added this function in 2.4 :-). Yeah.. i will update the migration guide. --- - To unsubscribe,

[GitHub] spark issue #22408: [SPARK-25417][SQL] ArrayContains function may return inc...

2018-09-13 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/22408 plz update the migration guide. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #22408: [SPARK-25417][SQL] ArrayContains function may ret...

2018-09-13 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/22408#discussion_r217593872 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala --- @@ -735,6 +735,44 @@ class DataFrameFunctionsSuite extends

[GitHub] spark pull request #22410: [SPARK-25418][SQL] The metadata of DataSource tab...

2018-09-13 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/22410#discussion_r217592782 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -1309,6 +1312,8 @@ object HiveExternalCatalog {

[GitHub] spark issue #18106: [SPARK-20754][SQL] Support TRUNC (number)

2018-09-13 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/18106 +100, @wangyum . Thanks. :) --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #22410: [SPARK-25418][SQL] The metadata of DataSource tab...

2018-09-13 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22410#discussion_r217590735 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -1309,6 +1312,8 @@ object HiveExternalCatalog {

[GitHub] spark issue #18106: [SPARK-20754][SQL] Support TRUNC (number)

2018-09-13 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/18106 @dongjoon-hyun Actually `TRUNC (number)` not resolved. I will fix it soon. https://issues.apache.org/jira/browse/SPARK-23906 ---

[GitHub] spark issue #22364: [SPARK-25379][SQL] Improve AttributeSet and ColumnPrunin...

2018-09-13 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/22364 Can we replace the syntax(`(ouputSetA -- outputSetB).nonEmpty`) in other places, too? e.g.,

[GitHub] spark issue #22417: [SPARK-25426][SQL] Handles subexpression elimination con...

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22417 **[Test build #96058 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96058/testReport)** for PR 22417 at commit

[GitHub] spark issue #22417: [SPARK-25426][SQL] Handles subexpression elimination con...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22417 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22417: [SPARK-25426][SQL] Handles subexpression elimination con...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22417 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request #22417: [SPARK-25426][SQL] Handles subexpression eliminat...

2018-09-13 Thread maropu
GitHub user maropu opened a pull request: https://github.com/apache/spark/pull/22417 [SPARK-25426][SQL] Handles subexpression elimination config inside CodeGeneratorWithInterpretedFallback ## What changes were proposed in this pull request? This pr handled the subexpression

[GitHub] spark issue #22413: [SPARK-25425][SQL] Extra options overwrite session optio...

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22413 **[Test build #96057 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96057/testReport)** for PR 22413 at commit

[GitHub] spark issue #22413: [SPARK-25425][SQL] Extra options overwrite session optio...

2018-09-13 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/22413 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22402: [SPARK-25414][SS][TEST] make it clear that the numRows m...

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22402 **[Test build #96056 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96056/testReport)** for PR 22402 at commit

[GitHub] spark issue #22402: [SPARK-25414][SS] The numInputRows metrics can be incorr...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22402 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22402: [SPARK-25414][SS] The numInputRows metrics can be incorr...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22402 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22411: [SPARK-25421][SQL] Abstract an output path field ...

2018-09-13 Thread LantaoJin
Github user LantaoJin commented on a diff in the pull request: https://github.com/apache/spark/pull/22411#discussion_r217584439 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlanInfo.scala --- @@ -18,6 +18,7 @@ package org.apache.spark.sql.execution

[GitHub] spark pull request #22411: [SPARK-25421][SQL] Abstract an output path field ...

2018-09-13 Thread LantaoJin
Github user LantaoJin commented on a diff in the pull request: https://github.com/apache/spark/pull/22411#discussion_r217584359 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -440,7 +440,7 @@ case class DataSource( //

[GitHub] spark pull request #22415: [SPARK-25291][K8S] Fixing Flakiness of Executor P...

2018-09-13 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/22415#discussion_r217583729 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala --- @@

[GitHub] spark issue #22414: [SPARK-25424][SQL] Window duration and slide duration wi...

2018-09-13 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/22414 btw, what's the current behaivour of Spark in case of the nagative value? --- - To unsubscribe, e-mail:

[GitHub] spark pull request #22414: [SPARK-25424][SQL] Window duration and slide dura...

2018-09-13 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/22414#discussion_r217576901 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/TimeWindowSuite.scala --- @@ -122,11 +122,57 @@ class TimeWindowSuite

[GitHub] spark pull request #22414: [SPARK-25424][SQL] Window duration and slide dura...

2018-09-13 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/22414#discussion_r217576920 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/TimeWindowSuite.scala --- @@ -122,11 +122,57 @@ class TimeWindowSuite

[GitHub] spark pull request #22402: [SPARK-25414][SS] The numInputRows metrics can be...

2018-09-13 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22402#discussion_r217576877 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingQuerySuite.scala --- @@ -460,9 +460,9 @@ class StreamingQuerySuite extends

[GitHub] spark pull request #22414: [SPARK-25424][SQL] Window duration and slide dura...

2018-09-13 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/22414#discussion_r217576774 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/TimeWindowSuite.scala --- @@ -122,11 +122,57 @@ class TimeWindowSuite

[GitHub] spark pull request #22395: [SPARK-16323][SQL] Add IntegralDivide expression

2018-09-13 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22395#discussion_r217576598 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala --- @@ -314,6 +314,27 @@ case class Divide(left:

[GitHub] spark pull request #22414: [SPARK-25424][SQL] Window duration and slide dura...

2018-09-13 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/22414#discussion_r217576554 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/TimeWindow.scala --- @@ -35,29 +35,15 @@ case class TimeWindow( with

[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...

2018-09-13 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/21217 @HyukjinKwon thanks for pinging me. I'd wait for others to take over this first, if no one does, I can do it later. --- - To

[GitHub] spark issue #22414: [SPARK-25424][SQL] Window duration and slide duration wi...

2018-09-13 Thread raghavgautam
Github user raghavgautam commented on the issue: https://github.com/apache/spark/pull/22414 @tdas Can you please take a look ? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #18106: [SPARK-20754][SQL] Support TRUNC (number)

2018-09-13 Thread wangyum
Github user wangyum closed the pull request at: https://github.com/apache/spark/pull/18106 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22392: [SPARK-23200] Reset Kubernetes-specific config on Checkp...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22392 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22392: [SPARK-23200] Reset Kubernetes-specific config on Checkp...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22392 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96055/ Test PASSed. ---

[GitHub] spark issue #22392: [SPARK-23200] Reset Kubernetes-specific config on Checkp...

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22392 **[Test build #96055 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96055/testReport)** for PR 22392 at commit

[GitHub] spark issue #21217: [SPARK-24151][SQL] Fix CURRENT_DATE, CURRENT_TIMESTAMP t...

2018-09-13 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21217 Can anyone take over this then? cc @kiszk, @mgaido91 and @viirya as well FYI. --- - To unsubscribe, e-mail:

[GitHub] spark issue #19538: [SPARK-20393][WEBU UI][BACKPORT-2.0] Strengthen Spark to...

2018-09-13 Thread ambauma
Github user ambauma commented on the issue: https://github.com/apache/spark/pull/19538 No argument. On Thu, Sep 13, 2018, 12:25 PM Dongjoon Hyun wrote: > @ambauma Unfortunately, it seems to be too > old and the PR on 1.6 also is

[GitHub] spark issue #22227: [SPARK-25202] [SQL] Implements split with limit sql func...

2018-09-13 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/7 Seems fine otherwise. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22227: [SPARK-25202] [SQL] Implements split with limit s...

2018-09-13 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/7#discussion_r217563904 --- Diff: python/pyspark/sql/functions.py --- @@ -1671,18 +1671,32 @@ def repeat(col, n): @since(1.5) @ignore_unicode_prefix -def

[GitHub] spark pull request #22227: [SPARK-25202] [SQL] Implements split with limit s...

2018-09-13 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/7#discussion_r217563726 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala --- @@ -229,33 +229,53 @@ case class

[GitHub] spark pull request #22227: [SPARK-25202] [SQL] Implements split with limit s...

2018-09-13 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/7#discussion_r217563572 --- Diff: python/pyspark/sql/functions.py --- @@ -1671,18 +1671,32 @@ def repeat(col, n): @since(1.5) @ignore_unicode_prefix -def

[GitHub] spark pull request #22227: [SPARK-25202] [SQL] Implements split with limit s...

2018-09-13 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/7#discussion_r217563366 --- Diff: python/pyspark/sql/functions.py --- @@ -1671,18 +1671,32 @@ def repeat(col, n): @since(1.5) @ignore_unicode_prefix -def

[GitHub] spark pull request #22415: [SPARK-25291][K8S] Fixing Flakiness of Executor P...

2018-09-13 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/22415#discussion_r217561045 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala --- @@

[GitHub] spark issue #22231: [SPARK-25238][PYTHON] lint-python: Upgrade pycodestyle t...

2018-09-13 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22231 > OK... # noqa works within the flake8 wrapper around PyFlakes but does not work when PyFlakes is called outside of flake8. Also added r"comment" as you suggested. Is this a bug in

[GitHub] spark pull request #22415: [SPARK-25291][K8S] Fixing Flakiness of Executor P...

2018-09-13 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/22415#discussion_r217560548 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala --- @@

[GitHub] spark issue #22416: [SPARK-25291][K8S][BACKPORT] Fixing Flakiness of Executo...

2018-09-13 Thread liyinan926
Github user liyinan926 commented on the issue: https://github.com/apache/spark/pull/22416 OK, so we can merge the other one to both master and branch-2.4. --- - To unsubscribe, e-mail:

[GitHub] spark pull request #22415: [SPARK-25291][K8S] Fixing Flakiness of Executor P...

2018-09-13 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/22415#discussion_r217560220 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala --- @@

[GitHub] spark issue #22416: [SPARK-25291][K8S][BACKPORT] Fixing Flakiness of Executo...

2018-09-13 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22416 Yes @linyinan926 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22392: [SPARK-23200] Reset Kubernetes-specific config on Checkp...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22392 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22392: [SPARK-23200] Reset Kubernetes-specific config on Checkp...

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22392 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/3099/ ---

[GitHub] spark issue #22392: [SPARK-23200] Reset Kubernetes-specific config on Checkp...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22392 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22413: [SPARK-25425][SQL] Extra options overwrite session optio...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22413 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96051/ Test FAILed. ---

[GitHub] spark issue #22392: [SPARK-23200] Reset Kubernetes-specific config on Checkp...

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22392 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/3099/ ---

[GitHub] spark issue #22413: [SPARK-25425][SQL] Extra options overwrite session optio...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22413 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22413: [SPARK-25425][SQL] Extra options overwrite session optio...

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22413 **[Test build #96051 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96051/testReport)** for PR 22413 at commit

[GitHub] spark issue #22392: [SPARK-23200] Reset Kubernetes-specific config on Checkp...

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22392 **[Test build #96055 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96055/testReport)** for PR 22392 at commit

[GitHub] spark issue #22392: [SPARK-23200] Reset Kubernetes-specific config on Checkp...

2018-09-13 Thread foxish
Github user foxish commented on the issue: https://github.com/apache/spark/pull/22392 Jenkins, test this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22231: [SPARK-25238][PYTHON] lint-python: Upgrade pycodestyle t...

2018-09-13 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22231 Oh, that line isn't the error, although the warning says it is! It's really line 134, which actually has escaped back-ticks. I think you can honestly remove all of these back-ticks. ---

[GitHub] spark issue #22415: [SPARK-25291][K8S] Fixing Flakiness of Executor Pod test...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22415 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22415: [SPARK-25291][K8S] Fixing Flakiness of Executor Pod test...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22415 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22415: [SPARK-25291][K8S] Fixing Flakiness of Executor Pod test...

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22415 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/3098/ ---

[GitHub] spark issue #22415: [SPARK-25291][K8S] Fixing Flakiness of Executor Pod test...

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22415 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/3098/ ---

[GitHub] spark pull request #22415: [SPARK-25291][K8S] Fixing Flakiness of Executor P...

2018-09-13 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/22415#discussion_r217543984 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala --- @@

[GitHub] spark issue #19267: [WIP][SPARK-20628][CORE] Blacklist nodes when they trans...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19267 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22416: [SPARK-25291][K8S][BACKPORT] Fixing Flakiness of Executo...

2018-09-13 Thread liyinan926
Github user liyinan926 commented on the issue: https://github.com/apache/spark/pull/22416 @ifilonenko so this is the same as #22415 except that it's for `branch-2.4`, right? --- - To unsubscribe, e-mail:

[GitHub] spark pull request #21386: [SPARK-23928][SQL][WIP] Add shuffle collection fu...

2018-09-13 Thread pkuwm
Github user pkuwm closed the pull request at: https://github.com/apache/spark/pull/21386 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21386: [SPARK-23928][SQL][WIP] Add shuffle collection function.

2018-09-13 Thread pkuwm
Github user pkuwm commented on the issue: https://github.com/apache/spark/pull/21386 Thanks for reminding, @dongjoon-hyun --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #22416: [SPARK-25291][K8S][BACKPORT] Fixing Flakiness of Executo...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22416 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22416: [SPARK-25291][K8S][BACKPORT] Fixing Flakiness of Executo...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22416 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22416: [SPARK-25291][K8S][BACKPORT] Fixing Flakiness of Executo...

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22416 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/3097/ ---

[GitHub] spark issue #22416: [SPARK-25291][K8S][BACKPORT] Fixing Flakiness of Executo...

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22416 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/3097/ ---

[GitHub] spark issue #22415: [SPARK-25291][K8S] Fixing Flakiness of Executor Pod test...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22415 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22415: [SPARK-25291][K8S] Fixing Flakiness of Executor Pod test...

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22415 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22415: [SPARK-25291][K8S] Fixing Flakiness of Executor Pod test...

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22415 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/3096/ ---

[GitHub] spark issue #22385: [SPARK-25400][CORE][TEST] Increase test timeouts

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22385 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22385: [SPARK-25400][CORE][TEST] Increase test timeouts

2018-09-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22385 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96046/ Test PASSed. ---

[GitHub] spark issue #22385: [SPARK-25400][CORE][TEST] Increase test timeouts

2018-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22385 **[Test build #96046 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96046/testReport)** for PR 22385 at commit

[GitHub] spark issue #22415: [SPARK-25291][K8S] Fixing Flakiness of Executor Pod test...

2018-09-13 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22415 @holdenk @liyinan926 @felixcheung for merge since @mccheah is out --- - To unsubscribe, e-mail:

  1   2   3   4   5   >