[GitHub] spark issue #22419: [SPARK-23906][SQL] Add built-in UDF TRUNCATE(number)

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22419 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22419: [SPARK-23906][SQL] Add built-in UDF TRUNCATE(number)

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22419 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3234/

[GitHub] spark issue #22419: [SPARK-23906][SQL] Add built-in UDF TRUNCATE(number)

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22419 **[Test build #96242 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96242/testReport)** for PR 22419 at commit [`c715694`](https://github.com/apache/spark/commit/c7

[GitHub] spark pull request #22442: [SPARK-25447][SQL] Support JSON options by schema...

2018-09-19 Thread MaxGekk
Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/22442#discussion_r218748820 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -3611,6 +3611,20 @@ object functions { */ def schema_of_json(e:

[GitHub] spark pull request #22419: [SPARK-23906][SQL] Add built-in UDF TRUNCATE(numb...

2018-09-19 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/22419#discussion_r218749189 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala --- @@ -1245,3 +1245,80 @@ case class BRound(child: E

[GitHub] spark issue #22454: [SPARK-25445][BUILD][FOLLOWUP] Resolve issues in release...

2018-09-19 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22454 I've tested it manually to create a scala 2.12 build and also a scala 2.12 maven package. It works well, I'm merging it to master/2.4, thanks! --- --

[GitHub] spark issue #22448: [SPARK-25417][SQL] Improve findTightestCommonType to coe...

2018-09-19 Thread MaxGekk
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/22448 Just in case, there is similar code in `CSVInferSchema` (and in JSON probably too): https://github.com/apache/spark/blob/5264164a67df498b73facae207eda12ee133be7d/sql/core/src/main/scala/org/apache/s

[GitHub] spark pull request #22454: [SPARK-25445][BUILD][FOLLOWUP] Resolve issues in ...

2018-09-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22454 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22465: [SPARK-25457][SQL] IntegralDivide returns data ty...

2018-09-19 Thread mgaido91
GitHub user mgaido91 opened a pull request: https://github.com/apache/spark/pull/22465 [SPARK-25457][SQL] IntegralDivide returns data type of the operands ## What changes were proposed in this pull request? The PR proposes to return the data type of the operands as a result

[GitHub] spark issue #22465: [SPARK-25457][SQL] IntegralDivide returns data type of t...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22465 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22465: [SPARK-25457][SQL] IntegralDivide returns data type of t...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22465 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3235/

[GitHub] spark issue #22465: [SPARK-25457][SQL] IntegralDivide returns data type of t...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22465 **[Test build #96243 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96243/testReport)** for PR 22465 at commit [`19ff368`](https://github.com/apache/spark/commit/19

[GitHub] spark pull request #22450: [SPARK-25454][SQL] Avoid precision loss in divisi...

2018-09-19 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22450#discussion_r218754608 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecision.scala --- @@ -129,16 +129,17 @@ object DecimalPrecision ext

[GitHub] spark issue #21403: [SPARK-24341][SQL] Support only IN subqueries with the s...

2018-09-19 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21403 ah i see. Can you add it to the migration guide? We need to tell users what will break after upgrading to 2.4 and why. --- - T

[GitHub] spark pull request #22465: [SPARK-25457][SQL] IntegralDivide returns data ty...

2018-09-19 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/22465#discussion_r218756417 --- Diff: sql/core/src/test/resources/sql-tests/inputs/operators.sql --- @@ -26,6 +26,15 @@ select 5 div 0; select 5 div null; select null div 5;

[GitHub] spark pull request #22465: [SPARK-25457][SQL] IntegralDivide returns data ty...

2018-09-19 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22465#discussion_r218756921 --- Diff: sql/core/src/test/resources/sql-tests/inputs/operators.sql --- @@ -26,6 +26,15 @@ select 5 div 0; select 5 div null; select null div 5;

[GitHub] spark issue #21403: [SPARK-24341][SQL] Support only IN subqueries with the s...

2018-09-19 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/21403 @cloud-fan sure, I'll create a followup PR, thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For addit

[GitHub] spark pull request #22462: [SPARK-25460][SS] DataSourceV2: SS sources do not...

2018-09-19 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22462#discussion_r218757254 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/MicroBatchExecution.scala --- @@ -47,6 +47,9 @@ class MicroBatchExecution(

[GitHub] spark issue #22402: [SPARK-25414][SS][TEST] make it clear that the numRows m...

2018-09-19 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22402 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-

[GitHub] spark issue #22454: [SPARK-25445][BUILD][FOLLOWUP] Resolve issues in release...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22454 **[Test build #96227 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96227/testReport)** for PR 22454 at commit [`3179075`](https://github.com/apache/spark/commit/3

[GitHub] spark issue #22449: [SPARK-22666][ML][FOLLOW-UP] Improve testcase to tolerat...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22449 **[Test build #96241 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96241/testReport)** for PR 22449 at commit [`3dfd82c`](https://github.com/apache/spark/commit/3

[GitHub] spark issue #22449: [SPARK-22666][ML][FOLLOW-UP] Improve testcase to tolerat...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22449 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22454: [SPARK-25445][BUILD][FOLLOWUP] Resolve issues in release...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22454 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22454: [SPARK-25445][BUILD][FOLLOWUP] Resolve issues in release...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22454 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96227/ Test FAILed. ---

[GitHub] spark issue #22449: [SPARK-22666][ML][FOLLOW-UP] Improve testcase to tolerat...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22449 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96241/ Test PASSed. ---

[GitHub] spark issue #22402: [SPARK-25414][SS][TEST] make it clear that the numRows m...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22402 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3236/

[GitHub] spark issue #22402: [SPARK-25414][SS][TEST] make it clear that the numRows m...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22402 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22402: [SPARK-25414][SS][TEST] make it clear that the numRows m...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22402 **[Test build #96244 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96244/testReport)** for PR 22402 at commit [`0c661a0`](https://github.com/apache/spark/commit/0c

[GitHub] spark pull request #22450: [SPARK-25454][SQL] Avoid precision loss in divisi...

2018-09-19 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22450#discussion_r218758428 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecision.scala --- @@ -129,16 +129,17 @@ object DecimalPrecision exte

[GitHub] spark issue #22454: [SPARK-25445][BUILD][FOLLOWUP] Resolve issues in release...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22454 **[Test build #96236 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96236/testReport)** for PR 22454 at commit [`a417a90`](https://github.com/apache/spark/commit/a

[GitHub] spark pull request #22465: [SPARK-25457][SQL] IntegralDivide returns data ty...

2018-09-19 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/22465#discussion_r218759101 --- Diff: sql/core/src/test/resources/sql-tests/inputs/operators.sql --- @@ -26,6 +26,15 @@ select 5 div 0; select 5 div null; select null div 5;

[GitHub] spark issue #22454: [SPARK-25445][BUILD][FOLLOWUP] Resolve issues in release...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22454 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96236/ Test FAILed. ---

[GitHub] spark issue #22454: [SPARK-25445][BUILD][FOLLOWUP] Resolve issues in release...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22454 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark pull request #20761: [SPARK-20327][CORE][YARN] Add CLI support for YAR...

2018-09-19 Thread szyszy
Github user szyszy commented on a diff in the pull request: https://github.com/apache/spark/pull/20761#discussion_r218760548 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ResourceTypeValidator.scala --- @@ -0,0 +1,107 @@ +/* + * Licensed to t

[GitHub] spark pull request #22450: [SPARK-25454][SQL] Avoid precision loss in divisi...

2018-09-19 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22450#discussion_r218760543 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecision.scala --- @@ -129,16 +129,17 @@ object DecimalPrecision ext

[GitHub] spark pull request #22465: [SPARK-25457][SQL] IntegralDivide returns data ty...

2018-09-19 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22465#discussion_r218760897 --- Diff: sql/core/src/test/resources/sql-tests/inputs/operators.sql --- @@ -26,6 +26,15 @@ select 5 div 0; select 5 div null; select null div 5;

[GitHub] spark pull request #22450: [SPARK-25454][SQL] Avoid precision loss in divisi...

2018-09-19 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22450#discussion_r218761031 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecision.scala --- @@ -129,16 +129,17 @@ object DecimalPrecision ext

[GitHub] spark issue #22448: [SPARK-25417][SQL] Improve findTightestCommonType to coe...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22448 **[Test build #96232 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96232/testReport)** for PR 22448 at commit [`2304c7d`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #22448: [SPARK-25417][SQL] Improve findTightestCommonType to coe...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22448 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96232/ Test PASSed. ---

[GitHub] spark issue #22448: [SPARK-25417][SQL] Improve findTightestCommonType to coe...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22448 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark pull request #22465: [SPARK-25457][SQL] IntegralDivide returns data ty...

2018-09-19 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22465#discussion_r218761706 --- Diff: sql/core/src/test/resources/sql-tests/inputs/operators.sql --- @@ -26,6 +26,15 @@ select 5 div 0; select 5 div null; select null div 5;

[GitHub] spark issue #22450: [SPARK-25454][SQL] Avoid precision loss in division with...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22450 **[Test build #96229 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96229/testReport)** for PR 22450 at commit [`7c4b454`](https://github.com/apache/spark/commit/7

[GitHub] spark pull request #20761: [SPARK-20327][CORE][YARN] Add CLI support for YAR...

2018-09-19 Thread szyszy
Github user szyszy commented on a diff in the pull request: https://github.com/apache/spark/pull/20761#discussion_r218761991 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ResourceTypeValidator.scala --- @@ -0,0 +1,107 @@ +/* + * Licensed to t

[GitHub] spark issue #22462: [SPARK-25460][SS] DataSourceV2: SS sources do not respec...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22462 **[Test build #96230 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96230/testReport)** for PR 22462 at commit [`d238a66`](https://github.com/apache/spark/commit/d

[GitHub] spark pull request #22450: [SPARK-25454][SQL] Avoid precision loss in divisi...

2018-09-19 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22450#discussion_r218762046 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecision.scala --- @@ -129,16 +129,17 @@ object DecimalPrecision exte

[GitHub] spark pull request #20761: [SPARK-20327][CORE][YARN] Add CLI support for YAR...

2018-09-19 Thread szyszy
Github user szyszy commented on a diff in the pull request: https://github.com/apache/spark/pull/20761#discussion_r218762120 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -140,10 +140,19 @@ private[yarn] class YarnAllocator

[GitHub] spark issue #22450: [SPARK-25454][SQL] Avoid precision loss in division with...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22450 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96229/ Test PASSed. ---

[GitHub] spark issue #22450: [SPARK-25454][SQL] Avoid precision loss in division with...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22450 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22462: [SPARK-25460][SS] DataSourceV2: SS sources do not respec...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22462 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22462: [SPARK-25460][SS] DataSourceV2: SS sources do not respec...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22462 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96230/ Test PASSed. ---

[GitHub] spark issue #22451: [SPARK-24777][SQL] Add write benchmark for AVRO

2018-09-19 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/22451 btw, why this pr automatically links to the corresponding jira...?: https://issues.apache.org/jira/browse/SPARK-24777 --- - To un

[GitHub] spark pull request #20761: [SPARK-20327][CORE][YARN] Add CLI support for YAR...

2018-09-19 Thread szyszy
Github user szyszy commented on a diff in the pull request: https://github.com/apache/spark/pull/20761#discussion_r218762664 --- Diff: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala --- @@ -35,18 +36,22 @@ import org.apache.hadoop.yarn.conf.Ya

[GitHub] spark pull request #20761: [SPARK-20327][CORE][YARN] Add CLI support for YAR...

2018-09-19 Thread szyszy
Github user szyszy commented on a diff in the pull request: https://github.com/apache/spark/pull/20761#discussion_r218762926 --- Diff: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ResourceTypeHelperSuite.scala --- @@ -0,0 +1,152 @@ +/* + * Licensed to

[GitHub] spark issue #22447: [SPARK-25450][SQL] PushProjectThroughUnion rule uses the...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22447 **[Test build #96233 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96233/testReport)** for PR 22447 at commit [`7193de3`](https://github.com/apache/spark/commit/7

[GitHub] spark issue #21632: [SPARK-19591][ML][MLlib] Add sample weights to decision ...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21632 **[Test build #96235 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96235/testReport)** for PR 21632 at commit [`b9f2425`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #22447: [SPARK-25450][SQL] PushProjectThroughUnion rule uses the...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22447 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark pull request #20761: [SPARK-20327][CORE][YARN] Add CLI support for YAR...

2018-09-19 Thread szyszy
Github user szyszy commented on a diff in the pull request: https://github.com/apache/spark/pull/20761#discussion_r218763818 --- Diff: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ResourceTypeValidatorSuite.scala --- @@ -0,0 +1,150 @@ +/* + * Licensed

[GitHub] spark issue #21632: [SPARK-19591][ML][MLlib] Add sample weights to decision ...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21632 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22447: [SPARK-25450][SQL] PushProjectThroughUnion rule uses the...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22447 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96233/ Test PASSed. ---

[GitHub] spark issue #21632: [SPARK-19591][ML][MLlib] Add sample weights to decision ...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21632 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96235/ Test FAILed. ---

[GitHub] spark issue #22461: [SPARK-25453][SQL][TEST] OracleIntegrationSuite IllegalA...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22461 **[Test build #96231 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96231/testReport)** for PR 22461 at commit [`fb7b9d2`](https://github.com/apache/spark/commit/f

[GitHub] spark issue #22461: [SPARK-25453][SQL][TEST] OracleIntegrationSuite IllegalA...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22461 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22461: [SPARK-25453][SQL][TEST] OracleIntegrationSuite IllegalA...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22461 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96231/ Test FAILed. ---

[GitHub] spark pull request #20761: [SPARK-20327][CORE][YARN] Add CLI support for YAR...

2018-09-19 Thread szyszy
Github user szyszy commented on a diff in the pull request: https://github.com/apache/spark/pull/20761#discussion_r218764502 --- Diff: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ResourceTypeValidatorSuite.scala --- @@ -0,0 +1,150 @@ +/* + * Licensed

[GitHub] spark issue #22461: [SPARK-25453][SQL][TEST] OracleIntegrationSuite IllegalA...

2018-09-19 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/22461 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h..

[GitHub] spark pull request #20761: [SPARK-20327][CORE][YARN] Add CLI support for YAR...

2018-09-19 Thread szyszy
Github user szyszy commented on a diff in the pull request: https://github.com/apache/spark/pull/20761#discussion_r218765124 --- Diff: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/TestYarnResourceTypeHelper.scala --- @@ -0,0 +1,103 @@ +/* + * Licensed

[GitHub] spark pull request #22450: [SPARK-25454][SQL] Avoid precision loss in divisi...

2018-09-19 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22450#discussion_r218765559 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecision.scala --- @@ -129,16 +129,17 @@ object DecimalPrecision ext

[GitHub] spark issue #22450: [SPARK-25454][SQL] Avoid precision loss in division with...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22450 **[Test build #96237 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96237/testReport)** for PR 22450 at commit [`520b64e`](https://github.com/apache/spark/commit/5

[GitHub] spark issue #22450: [SPARK-25454][SQL] Avoid precision loss in division with...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22450 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark pull request #20761: [SPARK-20327][CORE][YARN] Add CLI support for YAR...

2018-09-19 Thread szyszy
Github user szyszy commented on a diff in the pull request: https://github.com/apache/spark/pull/20761#discussion_r218765708 --- Diff: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/TestYarnResourceTypeHelper.scala --- @@ -0,0 +1,103 @@ +/* + * Licensed

[GitHub] spark issue #22450: [SPARK-25454][SQL] Avoid precision loss in division with...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22450 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96237/ Test PASSed. ---

[GitHub] spark pull request #20761: [SPARK-20327][CORE][YARN] Add CLI support for YAR...

2018-09-19 Thread szyszy
Github user szyszy commented on a diff in the pull request: https://github.com/apache/spark/pull/20761#discussion_r218766068 --- Diff: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/TestYarnResourceTypeHelper.scala --- @@ -0,0 +1,103 @@ +/* + * Licensed

[GitHub] spark issue #22461: [SPARK-25453][SQL][TEST] OracleIntegrationSuite IllegalA...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22461 **[Test build #96245 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96245/testReport)** for PR 22461 at commit [`fb7b9d2`](https://github.com/apache/spark/commit/fb

[GitHub] spark pull request #20761: [SPARK-20327][CORE][YARN] Add CLI support for YAR...

2018-09-19 Thread szyszy
Github user szyszy commented on a diff in the pull request: https://github.com/apache/spark/pull/20761#discussion_r218766937 --- Diff: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/TestYarnResourceTypeHelper.scala --- @@ -0,0 +1,103 @@ +/* + * Licensed

[GitHub] spark issue #22355: [SPARK-25358][SQL] MutableProjection supports fallback t...

2018-09-19 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/22355 ping --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache

[GitHub] spark pull request #22466: [SPARK-25464][SQL]When database is dropped all th...

2018-09-19 Thread sandeep-katta
GitHub user sandeep-katta opened a pull request: https://github.com/apache/spark/pull/22466 [SPARK-25464][SQL]When database is dropped all the data related to it is deleted Modification content:If the database is external then not required to delete it's content. What cha

[GitHub] spark issue #22466: [SPARK-25464][SQL]When database is dropped all the data ...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22466 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19810: [SPARK-22599][SQL] In-Memory Table Pruning without Extra...

2018-09-19 Thread eyalfa
Github user eyalfa commented on the issue: https://github.com/apache/spark/pull/19810 @maropu , this looks rather cold :sunglasses: , but extremely interesting and relevant. --- - To unsubscribe, e-mail: reviews-uns

[GitHub] spark issue #20761: [SPARK-20327][CORE][YARN] Add CLI support for YARN custo...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20761 **[Test build #96246 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96246/testReport)** for PR 20761 at commit [`8603876`](https://github.com/apache/spark/commit/86

[GitHub] spark issue #22451: [SPARK-24777][SQL] Add write benchmark for AVRO

2018-09-19 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/22451 oh, I see. can you put it in the jira manually? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22466: [SPARK-25464][SQL]When database is dropped all the data ...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22466 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22466: [SPARK-25464][SQL]When database is dropped all the data ...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22466 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22451: [SPARK-24777][SQL] Add write benchmark for AVRO

2018-09-19 Thread gengliangwang
Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/22451 @maropu When I create this PR, I type to "[[" at the beginning of title, thus it fails to link to the JIRA. --- - To unsub

[GitHub] spark issue #22355: [SPARK-25358][SQL] MutableProjection supports fallback t...

2018-09-19 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22355 thanks, merging to master! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22462: [SPARK-25460][SS] DataSourceV2: SS sources do not...

2018-09-19 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22462#discussion_r218774367 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/MicroBatchExecution.scala --- @@ -47,6 +47,9 @@ class MicroBatchExecution(

[GitHub] spark pull request #22355: [SPARK-25358][SQL] MutableProjection supports fal...

2018-09-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22355 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22461: [SPARK-25453][SQL][TEST] OracleIntegrationSuite IllegalA...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22461 **[Test build #96228 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96228/testReport)** for PR 22461 at commit [`fb7b9d2`](https://github.com/apache/spark/commit/f

[GitHub] spark issue #22462: [SPARK-25460][SS] DataSourceV2: SS sources do not respec...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22462 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22462: [SPARK-25460][SS] DataSourceV2: SS sources do not respec...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22462 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3237/

[GitHub] spark issue #22462: [SPARK-25460][SS] DataSourceV2: SS sources do not respec...

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22462 **[Test build #96247 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96247/testReport)** for PR 22462 at commit [`d23c0ed`](https://github.com/apache/spark/commit/d2

[GitHub] spark issue #22461: [SPARK-25453][SQL][TEST] OracleIntegrationSuite IllegalA...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22461 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96228/ Test PASSed. ---

[GitHub] spark issue #22461: [SPARK-25453][SQL][TEST] OracleIntegrationSuite IllegalA...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22461 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22355: [SPARK-25358][SQL] MutableProjection supports fallback t...

2018-09-19 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/22355 Thanks for the merging! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: review

[GitHub] spark pull request #22467: [SPARK-25465][TEST] Refactor Parquet test suites ...

2018-09-19 Thread gengliangwang
GitHub user gengliangwang opened a pull request: https://github.com/apache/spark/pull/22467 [SPARK-25465][TEST] Refactor Parquet test suites in project Hive ## What changes were proposed in this pull request? Current the file [parquetSuites.scala](https://github.com/apache/

[GitHub] spark issue #22463: remove annotation @Experimental

2018-09-19 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22463 Why don't we just leave it or mark them as deprecated. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #22443: [SPARK-25339][TEST] Refactor FilterPushdownBenchmark

2018-09-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22443 **[Test build #96234 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96234/testReport)** for PR 22443 at commit [`075ef7a`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaData...

2018-09-19 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/spark/pull/22138 > just wondering why org.apache.spark.sql.kafka010.CachedKafkaProducer uses com.google.common.cache.LoadingCache? Because KafkaProducer is thread-safe unless it enables transaction, henc

[GitHub] spark issue #22467: [SPARK-25465][TEST] Refactor Parquet test suites in proj...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22467 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3238/

[GitHub] spark issue #22467: [SPARK-25465][TEST] Refactor Parquet test suites in proj...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22467 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22462: [SPARK-25460][SS] DataSourceV2: SS sources do not respec...

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22462 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3239/

<    1   2   3   4   5   6   7   8   9   10   >