[GitHub] maropu commented on a change in pull request #23880: [SPARK-26976][SQL] Forbid reserved keywords as table identifiers when ANSI mode is on

2019-02-24 Thread GitBox
maropu commented on a change in pull request #23880: [SPARK-26976][SQL] Forbid reserved keywords as table identifiers when ANSI mode is on URL: https://github.com/apache/spark/pull/23880#discussion_r259705484 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/p

[GitHub] dilipbiswal commented on a change in pull request #23883: [SPARK-26982][SQL] Enhance describe framework to describe the output of a query.

2019-02-24 Thread GitBox
dilipbiswal commented on a change in pull request #23883: [SPARK-26982][SQL] Enhance describe framework to describe the output of a query. URL: https://github.com/apache/spark/pull/23883#discussion_r259705316 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/comm

[GitHub] dilipbiswal commented on a change in pull request #23883: [SPARK-26982][SQL] Enhance describe framework to describe the output of a query.

2019-02-24 Thread GitBox
dilipbiswal commented on a change in pull request #23883: [SPARK-26982][SQL] Enhance describe framework to describe the output of a query. URL: https://github.com/apache/spark/pull/23883#discussion_r259705316 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/comm

[GitHub] dilipbiswal commented on a change in pull request #23883: [SPARK-26982][SQL] Enhance describe framework to describe the output of a query.

2019-02-24 Thread GitBox
dilipbiswal commented on a change in pull request #23883: [SPARK-26982][SQL] Enhance describe framework to describe the output of a query. URL: https://github.com/apache/spark/pull/23883#discussion_r259704753 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/comm

[GitHub] cloud-fan commented on a change in pull request #23854: [SPARK-22000][SQL] Address missing Upcast in JavaTypeInference.deserializerFor

2019-02-24 Thread GitBox
cloud-fan commented on a change in pull request #23854: [SPARK-22000][SQL] Address missing Upcast in JavaTypeInference.deserializerFor URL: https://github.com/apache/spark/pull/23854#discussion_r259703479 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/JavaT

[GitHub] viirya commented on a change in pull request #23883: [SPARK-26982][SQL] Enhance describe framework to describe the output of a query.

2019-02-24 Thread GitBox
viirya commented on a change in pull request #23883: [SPARK-26982][SQL] Enhance describe framework to describe the output of a query. URL: https://github.com/apache/spark/pull/23883#discussion_r259704331 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/t

[GitHub] viirya commented on a change in pull request #23883: [SPARK-26982][SQL] Enhance describe framework to describe the output of a query.

2019-02-24 Thread GitBox
viirya commented on a change in pull request #23883: [SPARK-26982][SQL] Enhance describe framework to describe the output of a query. URL: https://github.com/apache/spark/pull/23883#discussion_r259704177 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/t

[GitHub] cloud-fan commented on a change in pull request #23854: [SPARK-22000][SQL] Address missing Upcast in JavaTypeInference.deserializerFor

2019-02-24 Thread GitBox
cloud-fan commented on a change in pull request #23854: [SPARK-22000][SQL] Address missing Upcast in JavaTypeInference.deserializerFor URL: https://github.com/apache/spark/pull/23854#discussion_r259704058 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/JavaT

[GitHub] cloud-fan commented on a change in pull request #23854: [SPARK-22000][SQL] Address missing Upcast in JavaTypeInference.deserializerFor

2019-02-24 Thread GitBox
cloud-fan commented on a change in pull request #23854: [SPARK-22000][SQL] Address missing Upcast in JavaTypeInference.deserializerFor URL: https://github.com/apache/spark/pull/23854#discussion_r259703955 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/JavaT

[GitHub] viirya commented on a change in pull request #23883: [SPARK-26982][SQL] Enhance describe framework to describe the output of a query.

2019-02-24 Thread GitBox
viirya commented on a change in pull request #23883: [SPARK-26982][SQL] Enhance describe framework to describe the output of a query. URL: https://github.com/apache/spark/pull/23883#discussion_r259703929 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/t

[GitHub] cloud-fan commented on a change in pull request #23854: [SPARK-22000][SQL] Address missing Upcast in JavaTypeInference.deserializerFor

2019-02-24 Thread GitBox
cloud-fan commented on a change in pull request #23854: [SPARK-22000][SQL] Address missing Upcast in JavaTypeInference.deserializerFor URL: https://github.com/apache/spark/pull/23854#discussion_r259703479 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/JavaT

[GitHub] cloud-fan commented on a change in pull request #23854: [SPARK-22000][SQL] Address missing Upcast in JavaTypeInference.deserializerFor

2019-02-24 Thread GitBox
cloud-fan commented on a change in pull request #23854: [SPARK-22000][SQL] Address missing Upcast in JavaTypeInference.deserializerFor URL: https://github.com/apache/spark/pull/23854#discussion_r259703382 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/JavaT

[GitHub] MaxGekk edited a comment on issue #23878: [SPARK-26978][CORE] Avoid magic time constants

2019-02-24 Thread GitBox
MaxGekk edited a comment on issue #23878: [SPARK-26978][CORE] Avoid magic time constants URL: https://github.com/apache/spark/pull/23878#issuecomment-466900091 > probably should add `[SQL]` in the PR title? The PR touches not only `SQL`-related files as well as in `CORE`. --

[GitHub] gengliangwang commented on a change in pull request #23601: [SPARK-26673][SQL] File source V2 writes: create framework and migrate ORC

2019-02-24 Thread GitBox
gengliangwang commented on a change in pull request #23601: [SPARK-26673][SQL] File source V2 writes: create framework and migrate ORC URL: https://github.com/apache/spark/pull/23601#discussion_r259702180 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasour

[GitHub] Hellsen83 edited a comment on issue #23877: [SPARK-26449][PYTHON] Add transform method to DataFrame API

2019-02-24 Thread GitBox
Hellsen83 edited a comment on issue #23877: [SPARK-26449][PYTHON] Add transform method to DataFrame API URL: https://github.com/apache/spark/pull/23877#issuecomment-466900342 >>> from pyspark.sql.functions import col >>> df = spark.createDataFrame([(1, 1.0), (2, 2.)], ["i

[GitHub] Hellsen83 commented on issue #23877: [SPARK-26449][PYTHON] Add transform method to DataFrame API

2019-02-24 Thread GitBox
Hellsen83 commented on issue #23877: [SPARK-26449][PYTHON] Add transform method to DataFrame API URL: https://github.com/apache/spark/pull/23877#issuecomment-466900342 >>> from pyspark.sql.functions import col >>> df = spark.createDataFrame([(1, 1.0), (2, 2.)], ["int", "f

[GitHub] MaxGekk commented on issue #23878: [SPARK-26978][CORE] Avoid magic time constants

2019-02-24 Thread GitBox
MaxGekk commented on issue #23878: [SPARK-26978][CORE] Avoid magic time constants URL: https://github.com/apache/spark/pull/23878#issuecomment-466900091 > probably should add `[SQL]` in the PR title? The PR touches not only `SQL`-related files. --

[GitHub] maropu commented on a change in pull request #23880: [SPARK-26976][SQL] Forbid reserved keywords as table identifiers when ANSI mode is on

2019-02-24 Thread GitBox
maropu commented on a change in pull request #23880: [SPARK-26976][SQL] Forbid reserved keywords as table identifiers when ANSI mode is on URL: https://github.com/apache/spark/pull/23880#discussion_r259697801 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/p

[GitHub] HeartSaVioR commented on a change in pull request #23854: [SPARK-22000][SQL] Address missing Upcast in JavaTypeInference.deserializerFor

2019-02-24 Thread GitBox
HeartSaVioR commented on a change in pull request #23854: [SPARK-22000][SQL] Address missing Upcast in JavaTypeInference.deserializerFor URL: https://github.com/apache/spark/pull/23854#discussion_r259698163 ## File path: sql/core/src/test/java/test/org/apache/spark/sql/JavaBeanDese

[GitHub] HeartSaVioR commented on a change in pull request #23854: [SPARK-22000][SQL] Address missing Upcast in JavaTypeInference.deserializerFor

2019-02-24 Thread GitBox
HeartSaVioR commented on a change in pull request #23854: [SPARK-22000][SQL] Address missing Upcast in JavaTypeInference.deserializerFor URL: https://github.com/apache/spark/pull/23854#discussion_r259698608 ## File path: sql/core/src/test/java/test/org/apache/spark/sql/JavaBeanDese

[GitHub] SparkQA commented on issue #23854: [SPARK-22000][SQL] Address missing Upcast in JavaTypeInference.deserializerFor

2019-02-24 Thread GitBox
SparkQA commented on issue #23854: [SPARK-22000][SQL] Address missing Upcast in JavaTypeInference.deserializerFor URL: https://github.com/apache/spark/pull/23854#issuecomment-466897367 **[Test build #102739 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/102

[GitHub] maropu commented on a change in pull request #23880: [SPARK-26976][SQL] Forbid reserved keywords as table identifiers when ANSI mode is on

2019-02-24 Thread GitBox
maropu commented on a change in pull request #23880: [SPARK-26976][SQL] Forbid reserved keywords as table identifiers when ANSI mode is on URL: https://github.com/apache/spark/pull/23880#discussion_r259697801 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/p

[GitHub] cloud-fan commented on a change in pull request #23880: [SPARK-26976][SQL] Forbid reserved keywords as table identifiers when ANSI mode is on

2019-02-24 Thread GitBox
cloud-fan commented on a change in pull request #23880: [SPARK-26976][SQL] Forbid reserved keywords as table identifiers when ANSI mode is on URL: https://github.com/apache/spark/pull/23880#discussion_r259696282 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalys

[GitHub] maropu commented on a change in pull request #23880: [SPARK-26976][SQL] Forbid reserved keywords as table identifiers when ANSI mode is on

2019-02-24 Thread GitBox
maropu commented on a change in pull request #23880: [SPARK-26976][SQL] Forbid reserved keywords as table identifiers when ANSI mode is on URL: https://github.com/apache/spark/pull/23880#discussion_r259695200 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/p

[GitHub] dilipbiswal commented on issue #23883: [SPARK-26982][SQL] Enhance describe framework to describe the output of a query.

2019-02-24 Thread GitBox
dilipbiswal commented on issue #23883: [SPARK-26982][SQL] Enhance describe framework to describe the output of a query. URL: https://github.com/apache/spark/pull/23883#issuecomment-466891730 cc @cloud-fan @gatorsmile This is

[GitHub] AmplabJenkins commented on issue #23883: [SPARK-26982][SQL] Enhance describe framework to describe the output of a query.

2019-02-24 Thread GitBox
AmplabJenkins commented on issue #23883: [SPARK-26982][SQL] Enhance describe framework to describe the output of a query. URL: https://github.com/apache/spark/pull/23883#issuecomment-466891566 Merged build finished. Test PASSed. -

[GitHub] AmplabJenkins removed a comment on issue #23883: [SPARK-26982][SQL] Enhance describe framework to describe the output of a query.

2019-02-24 Thread GitBox
AmplabJenkins removed a comment on issue #23883: [SPARK-26982][SQL] Enhance describe framework to describe the output of a query. URL: https://github.com/apache/spark/pull/23883#issuecomment-466891568 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] AmplabJenkins removed a comment on issue #23883: [SPARK-26982][SQL] Enhance describe framework to describe the output of a query.

2019-02-24 Thread GitBox
AmplabJenkins removed a comment on issue #23883: [SPARK-26982][SQL] Enhance describe framework to describe the output of a query. URL: https://github.com/apache/spark/pull/23883#issuecomment-466891566 Merged build finished. Test PASSed. -

[GitHub] AmplabJenkins commented on issue #23883: [SPARK-26982][SQL] Enhance describe framework to describe the output of a query.

2019-02-24 Thread GitBox
AmplabJenkins commented on issue #23883: [SPARK-26982][SQL] Enhance describe framework to describe the output of a query. URL: https://github.com/apache/spark/pull/23883#issuecomment-466891568 Test PASSed. Refer to this link for build results (access rights to CI server needed): http

[GitHub] SparkQA removed a comment on issue #23883: [SPARK-26982][SQL] Enhance describe framework to describe the output of a query.

2019-02-24 Thread GitBox
SparkQA removed a comment on issue #23883: [SPARK-26982][SQL] Enhance describe framework to describe the output of a query. URL: https://github.com/apache/spark/pull/23883#issuecomment-466852418 **[Test build #102731 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestB

[GitHub] SparkQA commented on issue #23883: [SPARK-26982][SQL] Enhance describe framework to describe the output of a query.

2019-02-24 Thread GitBox
SparkQA commented on issue #23883: [SPARK-26982][SQL] Enhance describe framework to describe the output of a query. URL: https://github.com/apache/spark/pull/23883#issuecomment-466891234 **[Test build #102731 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/

[GitHub] HeartSaVioR edited a comment on issue #23827: [SPARK-26912][CORE][HISTORY] Allow setting permission for event_log

2019-02-24 Thread GitBox
HeartSaVioR edited a comment on issue #23827: [SPARK-26912][CORE][HISTORY] Allow setting permission for event_log URL: https://github.com/apache/spark/pull/23827#issuecomment-466881976 IMHO it may be better to explain the actual cases you've encountered to persuade others: like there're us

[GitHub] maropu commented on a change in pull request #23854: [SPARK-22000][SQL] Address missing Upcast in JavaTypeInference.deserializerFor

2019-02-24 Thread GitBox
maropu commented on a change in pull request #23854: [SPARK-22000][SQL] Address missing Upcast in JavaTypeInference.deserializerFor URL: https://github.com/apache/spark/pull/23854#discussion_r259691302 ## File path: sql/core/src/test/java/test/org/apache/spark/sql/JavaBeanDeseriali

[GitHub] HeartSaVioR commented on a change in pull request #23854: [SPARK-22000][SQL] Address missing Upcast in JavaTypeInference.deserializerFor

2019-02-24 Thread GitBox
HeartSaVioR commented on a change in pull request #23854: [SPARK-22000][SQL] Address missing Upcast in JavaTypeInference.deserializerFor URL: https://github.com/apache/spark/pull/23854#discussion_r259691084 ## File path: sql/core/src/test/java/test/org/apache/spark/sql/JavaBeanDese

[GitHub] HeartSaVioR commented on a change in pull request #23798: [SPARK-26890][DOC] Add list of available Dropwizard metrics in Spark and add additional configuration details to the monitoring docum

2019-02-24 Thread GitBox
HeartSaVioR commented on a change in pull request #23798: [SPARK-26890][DOC] Add list of available Dropwizard metrics in Spark and add additional configuration details to the monitoring documentation URL: https://github.com/apache/spark/pull/23798#discussion_r259685486 ## File path

[GitHub] HeartSaVioR commented on a change in pull request #23798: [SPARK-26890][DOC] Add list of available Dropwizard metrics in Spark and add additional configuration details to the monitoring docum

2019-02-24 Thread GitBox
HeartSaVioR commented on a change in pull request #23798: [SPARK-26890][DOC] Add list of available Dropwizard metrics in Spark and add additional configuration details to the monitoring documentation URL: https://github.com/apache/spark/pull/23798#discussion_r259687566 ## File path

[GitHub] HeartSaVioR commented on a change in pull request #23798: [SPARK-26890][DOC] Add list of available Dropwizard metrics in Spark and add additional configuration details to the monitoring docum

2019-02-24 Thread GitBox
HeartSaVioR commented on a change in pull request #23798: [SPARK-26890][DOC] Add list of available Dropwizard metrics in Spark and add additional configuration details to the monitoring documentation URL: https://github.com/apache/spark/pull/23798#discussion_r259687648 ## File path

[GitHub] HeartSaVioR commented on a change in pull request #23798: [SPARK-26890][DOC] Add list of available Dropwizard metrics in Spark and add additional configuration details to the monitoring docum

2019-02-24 Thread GitBox
HeartSaVioR commented on a change in pull request #23798: [SPARK-26890][DOC] Add list of available Dropwizard metrics in Spark and add additional configuration details to the monitoring documentation URL: https://github.com/apache/spark/pull/23798#discussion_r259687249 ## File path

[GitHub] HeartSaVioR commented on a change in pull request #23798: [SPARK-26890][DOC] Add list of available Dropwizard metrics in Spark and add additional configuration details to the monitoring docum

2019-02-24 Thread GitBox
HeartSaVioR commented on a change in pull request #23798: [SPARK-26890][DOC] Add list of available Dropwizard metrics in Spark and add additional configuration details to the monitoring documentation URL: https://github.com/apache/spark/pull/23798#discussion_r259687508 ## File path

[GitHub] HeartSaVioR commented on a change in pull request #23798: [SPARK-26890][DOC] Add list of available Dropwizard metrics in Spark and add additional configuration details to the monitoring docum

2019-02-24 Thread GitBox
HeartSaVioR commented on a change in pull request #23798: [SPARK-26890][DOC] Add list of available Dropwizard metrics in Spark and add additional configuration details to the monitoring documentation URL: https://github.com/apache/spark/pull/23798#discussion_r259686715 ## File path

[GitHub] cloud-fan commented on a change in pull request #23880: [SPARK-26976][SQL] Forbid reserved keywords as table identifiers when ANSI mode is on

2019-02-24 Thread GitBox
cloud-fan commented on a change in pull request #23880: [SPARK-26976][SQL] Forbid reserved keywords as table identifiers when ANSI mode is on URL: https://github.com/apache/spark/pull/23880#discussion_r259687685 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalys

[GitHub] cloud-fan commented on a change in pull request #23880: [SPARK-26976][SQL] Forbid reserved keywords as table identifiers when ANSI mode is on

2019-02-24 Thread GitBox
cloud-fan commented on a change in pull request #23880: [SPARK-26976][SQL] Forbid reserved keywords as table identifiers when ANSI mode is on URL: https://github.com/apache/spark/pull/23880#discussion_r259687477 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalys

[GitHub] AmplabJenkins removed a comment on issue #23787: [SPARK-26830][SQL][R] Vectorized R dapply() implementation

2019-02-24 Thread GitBox
AmplabJenkins removed a comment on issue #23787: [SPARK-26830][SQL][R] Vectorized R dapply() implementation URL: https://github.com/apache/spark/pull/23787#issuecomment-466885086 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.

[GitHub] AmplabJenkins removed a comment on issue #23787: [SPARK-26830][SQL][R] Vectorized R dapply() implementation

2019-02-24 Thread GitBox
AmplabJenkins removed a comment on issue #23787: [SPARK-26830][SQL][R] Vectorized R dapply() implementation URL: https://github.com/apache/spark/pull/23787#issuecomment-466885083 Merged build finished. Test PASSed. This is an

[GitHub] AmplabJenkins commented on issue #23787: [SPARK-26830][SQL][R] Vectorized R dapply() implementation

2019-02-24 Thread GitBox
AmplabJenkins commented on issue #23787: [SPARK-26830][SQL][R] Vectorized R dapply() implementation URL: https://github.com/apache/spark/pull/23787#issuecomment-466885086 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley

[GitHub] AmplabJenkins commented on issue #23787: [SPARK-26830][SQL][R] Vectorized R dapply() implementation

2019-02-24 Thread GitBox
AmplabJenkins commented on issue #23787: [SPARK-26830][SQL][R] Vectorized R dapply() implementation URL: https://github.com/apache/spark/pull/23787#issuecomment-466885083 Merged build finished. Test PASSed. This is an automat

[GitHub] SparkQA commented on issue #23787: [SPARK-26830][SQL][R] Vectorized R dapply() implementation

2019-02-24 Thread GitBox
SparkQA commented on issue #23787: [SPARK-26830][SQL][R] Vectorized R dapply() implementation URL: https://github.com/apache/spark/pull/23787#issuecomment-466884672 **[Test build #102730 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/102730/testReport)**

[GitHub] SparkQA removed a comment on issue #23787: [SPARK-26830][SQL][R] Vectorized R dapply() implementation

2019-02-24 Thread GitBox
SparkQA removed a comment on issue #23787: [SPARK-26830][SQL][R] Vectorized R dapply() implementation URL: https://github.com/apache/spark/pull/23787#issuecomment-466845057 **[Test build #102730 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/102730/testRepo

[GitHub] 10110346 edited a comment on issue #23884: [MINOR]Simplify boolean expression

2019-02-24 Thread GitBox
10110346 edited a comment on issue #23884: [MINOR]Simplify boolean expression URL: https://github.com/apache/spark/pull/23884#issuecomment-466883837 > > > How did you check this? I run`grep -e "== true" -e "== false" -e "!= true" -e "!= false"` in all the source code, and I quickly

[GitHub] 10110346 commented on issue #23884: [MINOR]Simplify boolean expression

2019-02-24 Thread GitBox
10110346 commented on issue #23884: [MINOR]Simplify boolean expression URL: https://github.com/apache/spark/pull/23884#issuecomment-466883837 > > > How did you check this? I run`grep -e "== true" -e "== false" -e "!= true" -e "!= false"` in all the source code, and I quickly looked

[GitHub] dilipbiswal commented on issue #23783: [SPARK-26854][SQL] Support ANY/SOME subquery

2019-02-24 Thread GitBox
dilipbiswal commented on issue #23783: [SPARK-26854][SQL] Support ANY/SOME subquery URL: https://github.com/apache/spark/pull/23783#issuecomment-466883280 @francis0407 Most of the analysis checks are done in CheckAnalysis. There is a method called checkSubqueryExpression that has checks sp

[GitHub] maropu commented on a change in pull request #23854: [SPARK-22000][SQL] Address missing Upcast in JavaTypeInference.deserializerFor

2019-02-24 Thread GitBox
maropu commented on a change in pull request #23854: [SPARK-22000][SQL] Address missing Upcast in JavaTypeInference.deserializerFor URL: https://github.com/apache/spark/pull/23854#discussion_r259685461 ## File path: sql/core/src/test/java/test/org/apache/spark/sql/JavaBeanDeseriali

[GitHub] HeartSaVioR edited a comment on issue #23827: [SPARK-26912][CORE][HISTORY] Allow setting permission for event_log

2019-02-24 Thread GitBox
HeartSaVioR edited a comment on issue #23827: [SPARK-26912][CORE][HISTORY] Allow setting permission for event_log URL: https://github.com/apache/spark/pull/23827#issuecomment-466881976 IMHO it may be better to explain the actual cases you've encountered to persuade others: like there're us

[GitHub] HeartSaVioR edited a comment on issue #23827: [SPARK-26912][CORE][HISTORY] Allow setting permission for event_log

2019-02-24 Thread GitBox
HeartSaVioR edited a comment on issue #23827: [SPARK-26912][CORE][HISTORY] Allow setting permission for event_log URL: https://github.com/apache/spark/pull/23827#issuecomment-466881976 IMHO it may be better to explain the actual cases you've encountered to persuade others: like there're us

[GitHub] HeartSaVioR edited a comment on issue #23827: [SPARK-26912][CORE][HISTORY] Allow setting permission for event_log

2019-02-24 Thread GitBox
HeartSaVioR edited a comment on issue #23827: [SPARK-26912][CORE][HISTORY] Allow setting permission for event_log URL: https://github.com/apache/spark/pull/23827#issuecomment-466881976 IMHO it may be better to explain the actual cases to persuade others: like there're users `U1, U2, U3, U4

[GitHub] HeartSaVioR commented on issue #23827: [SPARK-26912][CORE][HISTORY] Allow setting permission for event_log

2019-02-24 Thread GitBox
HeartSaVioR commented on issue #23827: [SPARK-26912][CORE][HISTORY] Allow setting permission for event_log URL: https://github.com/apache/spark/pull/23827#issuecomment-466881976 IMHO it may be better to explain the actual cases to persuade others: like there're users `U1, U2, U3, U4` with

[GitHub] francis0407 commented on issue #23783: [SPARK-26854][SQL] Support ANY/SOME subquery

2019-02-24 Thread GitBox
francis0407 commented on issue #23783: [SPARK-26854][SQL] Support ANY/SOME subquery URL: https://github.com/apache/spark/pull/23783#issuecomment-466881768 I'm not sure where to throw the analysis exception, how about this: ``` scala case class AnySubquery(...) { if (values.size >

[GitHub] AmplabJenkins removed a comment on issue #23867: [SPARK-26965][SQL] Makes ElementAt nullability more precise

2019-02-24 Thread GitBox
AmplabJenkins removed a comment on issue #23867: [SPARK-26965][SQL] Makes ElementAt nullability more precise URL: https://github.com/apache/spark/pull/23867#issuecomment-466879374 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs

[GitHub] AmplabJenkins commented on issue #23867: [SPARK-26965][SQL] Makes ElementAt nullability more precise

2019-02-24 Thread GitBox
AmplabJenkins commented on issue #23867: [SPARK-26965][SQL] Makes ElementAt nullability more precise URL: https://github.com/apache/spark/pull/23867#issuecomment-466879374 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkele

[GitHub] AmplabJenkins removed a comment on issue #23867: [SPARK-26965][SQL] Makes ElementAt nullability more precise

2019-02-24 Thread GitBox
AmplabJenkins removed a comment on issue #23867: [SPARK-26965][SQL] Makes ElementAt nullability more precise URL: https://github.com/apache/spark/pull/23867#issuecomment-466879365 Merged build finished. Test PASSed. This is a

[GitHub] AmplabJenkins commented on issue #23867: [SPARK-26965][SQL] Makes ElementAt nullability more precise

2019-02-24 Thread GitBox
AmplabJenkins commented on issue #23867: [SPARK-26965][SQL] Makes ElementAt nullability more precise URL: https://github.com/apache/spark/pull/23867#issuecomment-466879365 Merged build finished. Test PASSed. This is an automa

[GitHub] SparkQA removed a comment on issue #23867: [SPARK-26965][SQL] Makes ElementAt nullability more precise

2019-02-24 Thread GitBox
SparkQA removed a comment on issue #23867: [SPARK-26965][SQL] Makes ElementAt nullability more precise URL: https://github.com/apache/spark/pull/23867#issuecomment-466840733 **[Test build #102729 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/102729/testRep

[GitHub] SparkQA commented on issue #23867: [SPARK-26965][SQL] Makes ElementAt nullability more precise

2019-02-24 Thread GitBox
SparkQA commented on issue #23867: [SPARK-26965][SQL] Makes ElementAt nullability more precise URL: https://github.com/apache/spark/pull/23867#issuecomment-466879035 **[Test build #102729 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/102729/testReport)**

[GitHub] HeartSaVioR commented on issue #22952: [SPARK-20568][SS] Provide option to clean up completed files in streaming query

2019-02-24 Thread GitBox
HeartSaVioR commented on issue #22952: [SPARK-20568][SS] Provide option to clean up completed files in streaming query URL: https://github.com/apache/spark/pull/22952#issuecomment-466878704 Bump. Now this PR has follow-up works "on top of", which is not easy to maintain without getting thi

[GitHub] HeartSaVioR commented on issue #23840: [SPARK-24295][SS] Add option to retain only last batch in file stream sink metadata

2019-02-24 Thread GitBox
HeartSaVioR commented on issue #23840: [SPARK-24295][SS] Add option to retain only last batch in file stream sink metadata URL: https://github.com/apache/spark/pull/23840#issuecomment-466878222 Now this approach conflicts #23850, so I would rather want to let us choose one of alternatives.

[GitHub] SparkQA commented on issue #22952: [SPARK-20568][SS] Provide option to clean up completed files in streaming query

2019-02-24 Thread GitBox
SparkQA commented on issue #22952: [SPARK-20568][SS] Provide option to clean up completed files in streaming query URL: https://github.com/apache/spark/pull/22952#issuecomment-466877692 **[Test build #102738 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/10

[GitHub] HeartSaVioR commented on issue #22952: [SPARK-20568][SS] Provide option to clean up completed files in streaming query

2019-02-24 Thread GitBox
HeartSaVioR commented on issue #22952: [SPARK-20568][SS] Provide option to clean up completed files in streaming query URL: https://github.com/apache/spark/pull/22952#issuecomment-466877530 Just rolled back the change from 9e45876 to avoid initiating more discussion on removing archived en

[GitHub] ConeyLiu commented on a change in pull request #23853: [SPARK-26952][SQL] Row count statics should respect the data reported by data source

2019-02-24 Thread GitBox
ConeyLiu commented on a change in pull request #23853: [SPARK-26952][SQL] Row count statics should respect the data reported by data source URL: https://github.com/apache/spark/pull/23853#discussion_r259680735 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/dat

[GitHub] HeartSaVioR edited a comment on issue #23854: [SPARK-22000][SQL] Address missing Upcast in JavaTypeInference.deserializerFor

2019-02-24 Thread GitBox
HeartSaVioR edited a comment on issue #23854: [SPARK-22000][SQL] Address missing Upcast in JavaTypeInference.deserializerFor URL: https://github.com/apache/spark/pull/23854#issuecomment-466872757 d4c2060 only changes parameter names from ca124b9 so the build result would be expected to be

[GitHub] HeartSaVioR commented on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer

2019-02-24 Thread GitBox
HeartSaVioR commented on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer URL: https://github.com/apache/spark/pull/22138#issuecomment-466876354 Bump. This is not only an improvement but also a bugfix since this patch can properly release consumer for obsolete

[GitHub] HeartSaVioR commented on issue #23820: [SPARK-22860][CORE][YARN] Redact command line arguments for running Driver and Executor before logging (standalone and YARN)

2019-02-24 Thread GitBox
HeartSaVioR commented on issue #23820: [SPARK-22860][CORE][YARN] Redact command line arguments for running Driver and Executor before logging (standalone and YARN) URL: https://github.com/apache/spark/pull/23820#issuecomment-466875899 @jiangxb1987 @HyukjinKwon Friendly reminder. Would

[GitHub] AmplabJenkins removed a comment on issue #17084: [SPARK-24103][ML][MLLIB] ML Evaluators should use weight column - added weight column for binary classification evaluator

2019-02-24 Thread GitBox
AmplabJenkins removed a comment on issue #17084: [SPARK-24103][ML][MLLIB] ML Evaluators should use weight column - added weight column for binary classification evaluator URL: https://github.com/apache/spark/pull/17084#issuecomment-466875758 Test PASSed. Refer to this link for build res

[GitHub] SparkQA removed a comment on issue #17084: [SPARK-24103][ML][MLLIB] ML Evaluators should use weight column - added weight column for binary classification evaluator

2019-02-24 Thread GitBox
SparkQA removed a comment on issue #17084: [SPARK-24103][ML][MLLIB] ML Evaluators should use weight column - added weight column for binary classification evaluator URL: https://github.com/apache/spark/pull/17084#issuecomment-466864709 **[Test build #102734 has started](https://amplab.cs.

[GitHub] AmplabJenkins removed a comment on issue #17084: [SPARK-24103][ML][MLLIB] ML Evaluators should use weight column - added weight column for binary classification evaluator

2019-02-24 Thread GitBox
AmplabJenkins removed a comment on issue #17084: [SPARK-24103][ML][MLLIB] ML Evaluators should use weight column - added weight column for binary classification evaluator URL: https://github.com/apache/spark/pull/17084#issuecomment-466875756 Merged build finished. Test PASSed. ---

[GitHub] AmplabJenkins commented on issue #17084: [SPARK-24103][ML][MLLIB] ML Evaluators should use weight column - added weight column for binary classification evaluator

2019-02-24 Thread GitBox
AmplabJenkins commented on issue #17084: [SPARK-24103][ML][MLLIB] ML Evaluators should use weight column - added weight column for binary classification evaluator URL: https://github.com/apache/spark/pull/17084#issuecomment-466875758 Test PASSed. Refer to this link for build results (ac

[GitHub] AmplabJenkins commented on issue #17084: [SPARK-24103][ML][MLLIB] ML Evaluators should use weight column - added weight column for binary classification evaluator

2019-02-24 Thread GitBox
AmplabJenkins commented on issue #17084: [SPARK-24103][ML][MLLIB] ML Evaluators should use weight column - added weight column for binary classification evaluator URL: https://github.com/apache/spark/pull/17084#issuecomment-466875756 Merged build finished. Test PASSed. ---

[GitHub] SparkQA commented on issue #17084: [SPARK-24103][ML][MLLIB] ML Evaluators should use weight column - added weight column for binary classification evaluator

2019-02-24 Thread GitBox
SparkQA commented on issue #17084: [SPARK-24103][ML][MLLIB] ML Evaluators should use weight column - added weight column for binary classification evaluator URL: https://github.com/apache/spark/pull/17084#issuecomment-466875625 **[Test build #102734 has finished](https://amplab.cs.berkele

[GitHub] HeartSaVioR commented on issue #23850: [SPARK-26949][SS] Prevent 'purge' to remove needed batch files in CompactibleFileStreamLog

2019-02-24 Thread GitBox
HeartSaVioR commented on issue #23850: [SPARK-26949][SS] Prevent 'purge' to remove needed batch files in CompactibleFileStreamLog URL: https://github.com/apache/spark/pull/23850#issuecomment-466875513 cc. @zsxwing @brkyvz @jerryshao since they've authored parts of the file. ---

[GitHub] HeartSaVioR commented on a change in pull request #23854: [SPARK-22000][SQL] Address missing Upcast in JavaTypeInference.deserializerFor

2019-02-24 Thread GitBox
HeartSaVioR commented on a change in pull request #23854: [SPARK-22000][SQL] Address missing Upcast in JavaTypeInference.deserializerFor URL: https://github.com/apache/spark/pull/23854#discussion_r259650320 ## File path: sql/core/src/test/java/test/org/apache/spark/sql/JavaBeanDese

[GitHub] SparkQA commented on issue #23854: [SPARK-22000][SQL] Address missing Upcast in JavaTypeInference.deserializerFor

2019-02-24 Thread GitBox
SparkQA commented on issue #23854: [SPARK-22000][SQL] Address missing Upcast in JavaTypeInference.deserializerFor URL: https://github.com/apache/spark/pull/23854#issuecomment-466872997 **[Test build #102737 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/102

[GitHub] HeartSaVioR commented on issue #23854: [SPARK-22000][SQL] Address missing Upcast in JavaTypeInference.deserializerFor

2019-02-24 Thread GitBox
HeartSaVioR commented on issue #23854: [SPARK-22000][SQL] Address missing Upcast in JavaTypeInference.deserializerFor URL: https://github.com/apache/spark/pull/23854#issuecomment-466872757 d4c2060 only changes parameter names from ca124b9 so the build result would be expected to be same.

[GitHub] maropu commented on issue #23884: [MINOR]Simplify boolean expression

2019-02-24 Thread GitBox
maropu commented on issue #23884: [MINOR]Simplify boolean expression URL: https://github.com/apache/spark/pull/23884#issuecomment-466871507 How did you check this? I run`grep -e "== true" -e "== false" -e "!= true" -e "!= false"` in all the source code, and I quickly looked over the result

[GitHub] SparkQA commented on issue #23854: [SPARK-22000][SQL] Address missing Upcast in JavaTypeInference.deserializerFor

2019-02-24 Thread GitBox
SparkQA commented on issue #23854: [SPARK-22000][SQL] Address missing Upcast in JavaTypeInference.deserializerFor URL: https://github.com/apache/spark/pull/23854#issuecomment-466871142 **[Test build #102736 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/102

[GitHub] SparkQA removed a comment on issue #23868: [SPARK-26966][ML] Update to JPMML 1.4.8

2019-02-24 Thread GitBox
SparkQA removed a comment on issue #23868: [SPARK-26966][ML] Update to JPMML 1.4.8 URL: https://github.com/apache/spark/pull/23868#issuecomment-466830131 **[Test build #4572 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4572/testReport)** for PR 23868

[GitHub] SparkQA commented on issue #23868: [SPARK-26966][ML] Update to JPMML 1.4.8

2019-02-24 Thread GitBox
SparkQA commented on issue #23868: [SPARK-26966][ML] Update to JPMML 1.4.8 URL: https://github.com/apache/spark/pull/23868#issuecomment-466868971 **[Test build #4572 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4572/testReport)** for PR 23868 at commi

[GitHub] AmplabJenkins removed a comment on issue #23878: [SPARK-26978][CORE] Avoid magic time constants

2019-02-24 Thread GitBox
AmplabJenkins removed a comment on issue #23878: [SPARK-26978][CORE] Avoid magic time constants URL: https://github.com/apache/spark/pull/23878#issuecomment-466868173 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu

[GitHub] AmplabJenkins removed a comment on issue #23878: [SPARK-26978][CORE] Avoid magic time constants

2019-02-24 Thread GitBox
AmplabJenkins removed a comment on issue #23878: [SPARK-26978][CORE] Avoid magic time constants URL: https://github.com/apache/spark/pull/23878#issuecomment-466868159 Merged build finished. Test PASSed. This is an automated m

[GitHub] AmplabJenkins commented on issue #23878: [SPARK-26978][CORE] Avoid magic time constants

2019-02-24 Thread GitBox
AmplabJenkins commented on issue #23878: [SPARK-26978][CORE] Avoid magic time constants URL: https://github.com/apache/spark/pull/23878#issuecomment-466868159 Merged build finished. Test PASSed. This is an automated message f

[GitHub] AmplabJenkins commented on issue #23878: [SPARK-26978][CORE] Avoid magic time constants

2019-02-24 Thread GitBox
AmplabJenkins commented on issue #23878: [SPARK-26978][CORE] Avoid magic time constants URL: https://github.com/apache/spark/pull/23878#issuecomment-466868173 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins

[GitHub] AmplabJenkins removed a comment on issue #23880: [SPARK-26976][SQL] Forbid reserved keywords as table identifiers when ANSI mode is on

2019-02-24 Thread GitBox
AmplabJenkins removed a comment on issue #23880: [SPARK-26976][SQL] Forbid reserved keywords as table identifiers when ANSI mode is on URL: https://github.com/apache/spark/pull/23880#issuecomment-466867962 Merged build finished. Test PASSed.

[GitHub] AmplabJenkins removed a comment on issue #23880: [SPARK-26976][SQL] Forbid reserved keywords as table identifiers when ANSI mode is on

2019-02-24 Thread GitBox
AmplabJenkins removed a comment on issue #23880: [SPARK-26976][SQL] Forbid reserved keywords as table identifiers when ANSI mode is on URL: https://github.com/apache/spark/pull/23880#issuecomment-466867966 Test PASSed. Refer to this link for build results (access rights to CI server need

[GitHub] AmplabJenkins commented on issue #23880: [SPARK-26976][SQL] Forbid reserved keywords as table identifiers when ANSI mode is on

2019-02-24 Thread GitBox
AmplabJenkins commented on issue #23880: [SPARK-26976][SQL] Forbid reserved keywords as table identifiers when ANSI mode is on URL: https://github.com/apache/spark/pull/23880#issuecomment-466867962 Merged build finished. Test PASSed.

[GitHub] AmplabJenkins commented on issue #23880: [SPARK-26976][SQL] Forbid reserved keywords as table identifiers when ANSI mode is on

2019-02-24 Thread GitBox
AmplabJenkins commented on issue #23880: [SPARK-26976][SQL] Forbid reserved keywords as table identifiers when ANSI mode is on URL: https://github.com/apache/spark/pull/23880#issuecomment-466867966 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] SparkQA removed a comment on issue #23878: [SPARK-26978][CORE] Avoid magic time constants

2019-02-24 Thread GitBox
SparkQA removed a comment on issue #23878: [SPARK-26978][CORE] Avoid magic time constants URL: https://github.com/apache/spark/pull/23878#issuecomment-466828609 **[Test build #102726 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/102726/testReport)** for P

[GitHub] SparkQA commented on issue #23878: [SPARK-26978][CORE] Avoid magic time constants

2019-02-24 Thread GitBox
SparkQA commented on issue #23878: [SPARK-26978][CORE] Avoid magic time constants URL: https://github.com/apache/spark/pull/23878#issuecomment-466867852 **[Test build #102726 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/102726/testReport)** for PR 23878

[GitHub] SparkQA commented on issue #23880: [SPARK-26976][SQL] Forbid reserved keywords as table identifiers when ANSI mode is on

2019-02-24 Thread GitBox
SparkQA commented on issue #23880: [SPARK-26976][SQL] Forbid reserved keywords as table identifiers when ANSI mode is on URL: https://github.com/apache/spark/pull/23880#issuecomment-466867313 **[Test build #102735 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuil

[GitHub] maropu commented on issue #23880: [SPARK-26976][SQL] Forbid reserved keywords as table identifiers when ANSI mode is on

2019-02-24 Thread GitBox
maropu commented on issue #23880: [SPARK-26976][SQL] Forbid reserved keywords as table identifiers when ANSI mode is on URL: https://github.com/apache/spark/pull/23880#issuecomment-466867048 retest this please This is an auto

[GitHub] AmplabJenkins removed a comment on issue #17084: [SPARK-24103][ML][MLLIB] ML Evaluators should use weight column - added weight column for binary classification evaluator

2019-02-24 Thread GitBox
AmplabJenkins removed a comment on issue #17084: [SPARK-24103][ML][MLLIB] ML Evaluators should use weight column - added weight column for binary classification evaluator URL: https://github.com/apache/spark/pull/17084#issuecomment-466865342 Merged build finished. Test PASSed. ---

[GitHub] AmplabJenkins removed a comment on issue #17084: [SPARK-24103][ML][MLLIB] ML Evaluators should use weight column - added weight column for binary classification evaluator

2019-02-24 Thread GitBox
AmplabJenkins removed a comment on issue #17084: [SPARK-24103][ML][MLLIB] ML Evaluators should use weight column - added weight column for binary classification evaluator URL: https://github.com/apache/spark/pull/17084#issuecomment-466865343 Test PASSed. Refer to this link for build res

[GitHub] AmplabJenkins commented on issue #17084: [SPARK-24103][ML][MLLIB] ML Evaluators should use weight column - added weight column for binary classification evaluator

2019-02-24 Thread GitBox
AmplabJenkins commented on issue #17084: [SPARK-24103][ML][MLLIB] ML Evaluators should use weight column - added weight column for binary classification evaluator URL: https://github.com/apache/spark/pull/17084#issuecomment-466865343 Test PASSed. Refer to this link for build results (ac

  1   2   3   4   >