[GitHub] [spark] HyukjinKwon edited a comment on issue #25204: [SPARK-28441][SQL][Python] Fix error when PythonUDF is used in correlated scalar subquery

2019-07-20 Thread GitBox
HyukjinKwon edited a comment on issue #25204: [SPARK-28441][SQL][Python] Fix error when PythonUDF is used in correlated scalar subquery URL: https://github.com/apache/spark/pull/25204#issuecomment-513444241 Looks making sense to me from a cursory look. I will take a closer look if this doe

[GitHub] [spark] HyukjinKwon commented on issue #25204: [SPARK-28441][SQL][Python] Fix error when PythonUDF is used in correlated scalar subquery

2019-07-20 Thread GitBox
HyukjinKwon commented on issue #25204: [SPARK-28441][SQL][Python] Fix error when PythonUDF is used in correlated scalar subquery URL: https://github.com/apache/spark/pull/25204#issuecomment-513444241 Looks making sense to me. I will take a closer look if this doesn't get merged. cc @cloud-

[GitHub] [spark] HyukjinKwon edited a comment on issue #25204: [SPARK-28441][SQL][Python] Fix error when PythonUDF is used in correlated scalar subquery

2019-07-20 Thread GitBox
HyukjinKwon edited a comment on issue #25204: [SPARK-28441][SQL][Python] Fix error when PythonUDF is used in correlated scalar subquery URL: https://github.com/apache/spark/pull/25204#issuecomment-513444241 Looks making sense to me from a cursory look. I will take a closer look if this doe

[GitHub] [spark] HyukjinKwon commented on issue #25207: [SPARK-27815][SQL][FOLLOWUP][DOC] Update comment that references `PushDownPredicate`

2019-07-20 Thread GitBox
HyukjinKwon commented on issue #25207: [SPARK-27815][SQL][FOLLOWUP][DOC] Update comment that references `PushDownPredicate` URL: https://github.com/apache/spark/pull/25207#issuecomment-513444654 Wait, are you use if it's related to `do not leak SaveMode to file source v2` SPARK-27815? ---

[GitHub] [spark] HyukjinKwon commented on issue #25207: [SPARK-27815][SQL][FOLLOWUP][DOC] Update comment that references `PushDownPredicate`

2019-07-20 Thread GitBox
HyukjinKwon commented on issue #25207: [SPARK-27815][SQL][FOLLOWUP][DOC] Update comment that references `PushDownPredicate` URL: https://github.com/apache/spark/pull/25207#issuecomment-513444805 Oh, ah. got it. Okay, let me switch the JIRA and merge. --

[GitHub] [spark] HyukjinKwon commented on issue #24956: [SPARK-28155][SQL] Predicate pushdown in one pass for cascading joins

2019-07-20 Thread GitBox
HyukjinKwon commented on issue #24956: [SPARK-28155][SQL] Predicate pushdown in one pass for cascading joins URL: https://github.com/apache/spark/pull/24956#issuecomment-513444830 K. let me do that. I did this once before as well. ---

[GitHub] [spark] HyukjinKwon removed a comment on issue #24956: [SPARK-27815][SQL] Predicate pushdown in one pass for cascading joins

2019-07-20 Thread GitBox
HyukjinKwon removed a comment on issue #24956: [SPARK-27815][SQL] Predicate pushdown in one pass for cascading joins URL: https://github.com/apache/spark/pull/24956#issuecomment-513444830 K. let me do that. I did this once before as well. ---

[GitHub] [spark] HyukjinKwon commented on issue #24956: [SPARK-27815][SQL] Predicate pushdown in one pass for cascading joins

2019-07-20 Thread GitBox
HyukjinKwon commented on issue #24956: [SPARK-27815][SQL] Predicate pushdown in one pass for cascading joins URL: https://github.com/apache/spark/pull/24956#issuecomment-513445023 K. Let me do that. This is an automated messa

[GitHub] [spark] HyukjinKwon commented on issue #25207: [SPARK-27815][SQL][FOLLOWUP][DOC] Update comment that references `PushDownPredicate`

2019-07-20 Thread GitBox
HyukjinKwon commented on issue #25207: [SPARK-27815][SQL][FOLLOWUP][DOC] Update comment that references `PushDownPredicate` URL: https://github.com/apache/spark/pull/25207#issuecomment-513446009 Merged to master. This is an a

[GitHub] [spark] HyukjinKwon closed pull request #25207: [SPARK-27815][SQL][FOLLOWUP][DOC] Update comment that references `PushDownPredicate`

2019-07-20 Thread GitBox
HyukjinKwon closed pull request #25207: [SPARK-27815][SQL][FOLLOWUP][DOC] Update comment that references `PushDownPredicate` URL: https://github.com/apache/spark/pull/25207 This is an automated message from the Apache Git Se

[GitHub] [spark] AmplabJenkins commented on issue #25117: [SPARK-28454][Python] Validate LongType in _make_type_verifier

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #25117: [SPARK-28454][Python] Validate LongType in _make_type_verifier URL: https://github.com/apache/spark/pull/25117#issuecomment-513446517 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.ber

[GitHub] [spark] AmplabJenkins removed a comment on issue #25117: [SPARK-28454][Python] Validate LongType in _make_type_verifier

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #25117: [SPARK-28454][Python] Validate LongType in _make_type_verifier URL: https://github.com/apache/spark/pull/25117#issuecomment-513446514 Merged build finished. Test PASSed. This i

[GitHub] [spark] AmplabJenkins removed a comment on issue #25117: [SPARK-28454][Python] Validate LongType in _make_type_verifier

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #25117: [SPARK-28454][Python] Validate LongType in _make_type_verifier URL: https://github.com/apache/spark/pull/25117#issuecomment-513446517 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://ampla

[GitHub] [spark] AmplabJenkins commented on issue #25117: [SPARK-28454][Python] Validate LongType in _make_type_verifier

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #25117: [SPARK-28454][Python] Validate LongType in _make_type_verifier URL: https://github.com/apache/spark/pull/25117#issuecomment-513446514 Merged build finished. Test PASSed. This is an aut

[GitHub] [spark] SparkQA commented on issue #23531: [WIP][SPARK-24497][SQL] Support recursive SQL query

2019-07-20 Thread GitBox
SparkQA commented on issue #23531: [WIP][SPARK-24497][SQL] Support recursive SQL query URL: https://github.com/apache/spark/pull/23531#issuecomment-513446637 **[Test build #107937 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107937/testReport)** for PR 2

[GitHub] [spark] SparkQA commented on issue #25117: [SPARK-28454][Python] Validate LongType in _make_type_verifier

2019-07-20 Thread GitBox
SparkQA commented on issue #25117: [SPARK-28454][Python] Validate LongType in _make_type_verifier URL: https://github.com/apache/spark/pull/25117#issuecomment-513446635 **[Test build #107936 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107936/testReport)*

[GitHub] [spark] albertusk95 commented on a change in pull request #17673: [SPARK-20372] [ML] Word2Vec Continuous Bag of Words model

2019-07-20 Thread GitBox
albertusk95 commented on a change in pull request #17673: [SPARK-20372] [ML] Word2Vec Continuous Bag of Words model URL: https://github.com/apache/spark/pull/17673#discussion_r305571436 ## File path: mllib/src/main/scala/org/apache/spark/ml/feature/impl/Word2VecCBOWSolver.scala ##

[GitHub] [spark] albertusk95 commented on a change in pull request #17673: [SPARK-20372] [ML] Word2Vec Continuous Bag of Words model

2019-07-20 Thread GitBox
albertusk95 commented on a change in pull request #17673: [SPARK-20372] [ML] Word2Vec Continuous Bag of Words model URL: https://github.com/apache/spark/pull/17673#discussion_r305571545 ## File path: mllib/src/main/scala/org/apache/spark/ml/feature/impl/Word2VecCBOWSolver.scala ##

[GitHub] [spark] albertusk95 commented on a change in pull request #17673: [SPARK-20372] [ML] Word2Vec Continuous Bag of Words model

2019-07-20 Thread GitBox
albertusk95 commented on a change in pull request #17673: [SPARK-20372] [ML] Word2Vec Continuous Bag of Words model URL: https://github.com/apache/spark/pull/17673#discussion_r305571612 ## File path: mllib/src/main/scala/org/apache/spark/ml/feature/impl/Word2VecCBOWSolver.scala ##

[GitHub] [spark] AmplabJenkins commented on issue #23531: [WIP][SPARK-24497][SQL] Support recursive SQL query

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #23531: [WIP][SPARK-24497][SQL] Support recursive SQL query URL: https://github.com/apache/spark/pull/23531#issuecomment-513446991 Merged build finished. Test PASSed. This is an automated mess

[GitHub] [spark] AmplabJenkins removed a comment on issue #23531: [WIP][SPARK-24497][SQL] Support recursive SQL query

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #23531: [WIP][SPARK-24497][SQL] Support recursive SQL query URL: https://github.com/apache/spark/pull/23531#issuecomment-513446991 Merged build finished. Test PASSed. This is an automa

[GitHub] [spark] AmplabJenkins removed a comment on issue #23531: [WIP][SPARK-24497][SQL] Support recursive SQL query

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #23531: [WIP][SPARK-24497][SQL] Support recursive SQL query URL: https://github.com/apache/spark/pull/23531#issuecomment-513446994 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkel

[GitHub] [spark] AmplabJenkins commented on issue #23531: [WIP][SPARK-24497][SQL] Support recursive SQL query

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #23531: [WIP][SPARK-24497][SQL] Support recursive SQL query URL: https://github.com/apache/spark/pull/23531#issuecomment-513446994 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/j

[GitHub] [spark] SparkQA commented on issue #25117: [SPARK-28454][Python] Validate LongType in _make_type_verifier

2019-07-20 Thread GitBox
SparkQA commented on issue #25117: [SPARK-28454][Python] Validate LongType in _make_type_verifier URL: https://github.com/apache/spark/pull/25117#issuecomment-513448262 **[Test build #107936 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107936/testReport)

[GitHub] [spark] SparkQA removed a comment on issue #25117: [SPARK-28454][Python] Validate LongType in _make_type_verifier

2019-07-20 Thread GitBox
SparkQA removed a comment on issue #25117: [SPARK-28454][Python] Validate LongType in _make_type_verifier URL: https://github.com/apache/spark/pull/25117#issuecomment-513446635 **[Test build #107936 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107936/test

[GitHub] [spark] AmplabJenkins commented on issue #25117: [SPARK-28454][Python] Validate LongType in _make_type_verifier

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #25117: [SPARK-28454][Python] Validate LongType in _make_type_verifier URL: https://github.com/apache/spark/pull/25117#issuecomment-513448320 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berk

[GitHub] [spark] AmplabJenkins commented on issue #25117: [SPARK-28454][Python] Validate LongType in _make_type_verifier

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #25117: [SPARK-28454][Python] Validate LongType in _make_type_verifier URL: https://github.com/apache/spark/pull/25117#issuecomment-513448318 Merged build finished. Test PASSed. This is an aut

[GitHub] [spark] AmplabJenkins removed a comment on issue #25117: [SPARK-28454][Python] Validate LongType in _make_type_verifier

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #25117: [SPARK-28454][Python] Validate LongType in _make_type_verifier URL: https://github.com/apache/spark/pull/25117#issuecomment-513448320 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab

[GitHub] [spark] AmplabJenkins removed a comment on issue #25117: [SPARK-28454][Python] Validate LongType in _make_type_verifier

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #25117: [SPARK-28454][Python] Validate LongType in _make_type_verifier URL: https://github.com/apache/spark/pull/25117#issuecomment-513448318 Merged build finished. Test PASSed. This i

[GitHub] [spark] viirya commented on a change in pull request #25209: [SPARK-28456][SQL]Add a public API `Encoder.copyEncoder` to allow creating Encoder without touching Scala Reflection

2019-07-20 Thread GitBox
viirya commented on a change in pull request #25209: [SPARK-28456][SQL]Add a public API `Encoder.copyEncoder` to allow creating Encoder without touching Scala Reflection URL: https://github.com/apache/spark/pull/25209#discussion_r305572944 ## File path: sql/catalyst/src/main/scala/

[GitHub] [spark] albertusk95 commented on a change in pull request #25107: [SPARK-28344][SQL] detect ambiguous self-join and fail the query

2019-07-20 Thread GitBox
albertusk95 commented on a change in pull request #25107: [SPARK-28344][SQL] detect ambiguous self-join and fail the query URL: https://github.com/apache/spark/pull/25107#discussion_r305573260 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/analysis/DetectAmbig

[GitHub] [spark] albertusk95 commented on a change in pull request #25107: [SPARK-28344][SQL] detect ambiguous self-join and fail the query

2019-07-20 Thread GitBox
albertusk95 commented on a change in pull request #25107: [SPARK-28344][SQL] detect ambiguous self-join and fail the query URL: https://github.com/apache/spark/pull/25107#discussion_r305573273 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ##

[GitHub] [spark] mgaido91 commented on issue #25144: [SPARK-28369][SQL] Honor spark.sql.decimalOperations.nullOnOverflow in ScalaUDF result

2019-07-20 Thread GitBox
mgaido91 commented on issue #25144: [SPARK-28369][SQL] Honor spark.sql.decimalOperations.nullOnOverflow in ScalaUDF result URL: https://github.com/apache/spark/pull/25144#issuecomment-513450184 cc @JoshRosen @cloud-fan This

[GitHub] [spark] mgaido91 commented on issue #25136: [SPARK-28322][SQL] Add support to Decimal type for integral divide

2019-07-20 Thread GitBox
mgaido91 commented on issue #25136: [SPARK-28322][SQL] Add support to Decimal type for integral divide URL: https://github.com/apache/spark/pull/25136#issuecomment-513450267 cc @cloud-fan @gatorsmile This is an automated mes

[GitHub] [spark] AmplabJenkins commented on issue #21599: [SPARK-26218][SQL] Overflow on arithmetic operations returns incorrect result

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #21599: [SPARK-26218][SQL] Overflow on arithmetic operations returns incorrect result URL: https://github.com/apache/spark/pull/21599#issuecomment-513450302 Test PASSed. Refer to this link for build results (access rights to CI server needed): https:

[GitHub] [spark] AmplabJenkins commented on issue #21599: [SPARK-26218][SQL] Overflow on arithmetic operations returns incorrect result

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #21599: [SPARK-26218][SQL] Overflow on arithmetic operations returns incorrect result URL: https://github.com/apache/spark/pull/21599#issuecomment-513450299 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #21599: [SPARK-26218][SQL] Overflow on arithmetic operations returns incorrect result

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #21599: [SPARK-26218][SQL] Overflow on arithmetic operations returns incorrect result URL: https://github.com/apache/spark/pull/21599#issuecomment-513450302 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #21599: [SPARK-26218][SQL] Overflow on arithmetic operations returns incorrect result

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #21599: [SPARK-26218][SQL] Overflow on arithmetic operations returns incorrect result URL: https://github.com/apache/spark/pull/21599#issuecomment-513450299 Merged build finished. Test PASSed.

[GitHub] [spark] mgaido91 commented on issue #23701: [SPARK-26741][SQL] Allow using aggregate expressions in ORDER BY clause

2019-07-20 Thread GitBox
mgaido91 commented on issue #23701: [SPARK-26741][SQL] Allow using aggregate expressions in ORDER BY clause URL: https://github.com/apache/spark/pull/23701#issuecomment-513450405 cc @gatorsmile too, are there any more comments related to this PR? ---

[GitHub] [spark] mgaido91 edited a comment on issue #23701: [SPARK-26741][SQL] Allow using aggregate expressions in ORDER BY clause

2019-07-20 Thread GitBox
mgaido91 edited a comment on issue #23701: [SPARK-26741][SQL] Allow using aggregate expressions in ORDER BY clause URL: https://github.com/apache/spark/pull/23701#issuecomment-513450405 cc @gatorsmile too, are there any more comments related to this PR? It is a bug fix, so I think it would

[GitHub] [spark] SparkQA commented on issue #21599: [SPARK-26218][SQL] Overflow on arithmetic operations returns incorrect result

2019-07-20 Thread GitBox
SparkQA commented on issue #21599: [SPARK-26218][SQL] Overflow on arithmetic operations returns incorrect result URL: https://github.com/apache/spark/pull/21599#issuecomment-513450421 **[Test build #107938 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/1079

[GitHub] [spark] mgaido91 commented on a change in pull request #25208: [SPARK-28455][core] Avoid overflow when calculating executor timeout time.

2019-07-20 Thread GitBox
mgaido91 commented on a change in pull request #25208: [SPARK-28455][core] Avoid overflow when calculating executor timeout time. URL: https://github.com/apache/spark/pull/25208#discussion_r305574549 ## File path: core/src/main/scala/org/apache/spark/scheduler/dynalloc/ExecutorMoni

[GitHub] [spark] SparkQA commented on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION

2019-07-20 Thread GitBox
SparkQA commented on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION URL: https://github.com/apache/spark/pull/20999#issuecomment-513453383 **[Test build #107939 has started](https://amplab.cs.berkeley.edu/jenkins/job/Spark

[GitHub] [spark] maropu commented on a change in pull request #25074: [SPARK-27924][SQL] Support ANSI SQL Boolean-Predicate syntax

2019-07-20 Thread GitBox
maropu commented on a change in pull request #25074: [SPARK-27924][SQL] Support ANSI SQL Boolean-Predicate syntax URL: https://github.com/apache/spark/pull/25074#discussion_r305574593 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala

[GitHub] [spark] maropu commented on a change in pull request #25074: [SPARK-27924][SQL] Support ANSI SQL Boolean-Predicate syntax

2019-07-20 Thread GitBox
maropu commented on a change in pull request #25074: [SPARK-27924][SQL] Support ANSI SQL Boolean-Predicate syntax URL: https://github.com/apache/spark/pull/25074#discussion_r305574593 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala

[GitHub] [spark] SparkQA commented on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION

2019-07-20 Thread GitBox
SparkQA commented on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION URL: https://github.com/apache/spark/pull/20999#issuecomment-513453657 **[Test build #107939 has finished](https://amplab.cs.berkeley.edu/jenkins/job/Spar

[GitHub] [spark] AmplabJenkins commented on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION URL: https://github.com/apache/spark/pull/20999#issuecomment-513453661 Merged build finished. Test FAILed.

[GitHub] [spark] AmplabJenkins commented on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION URL: https://github.com/apache/spark/pull/20999#issuecomment-513453663 Test FAILed. Refer to this link for build results (access rights to CI ser

[GitHub] [spark] mgaido91 commented on a change in pull request #25206: [SPARK-28265][SQL] Add renameTable to TableCatalog API

2019-07-20 Thread GitBox
mgaido91 commented on a change in pull request #25206: [SPARK-28265][SQL] Add renameTable to TableCatalog API URL: https://github.com/apache/spark/pull/25206#discussion_r305574632 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/catalog/v2/TableCatalog.java ##

[GitHub] [spark] mgaido91 commented on a change in pull request #25206: [SPARK-28265][SQL] Add renameTable to TableCatalog API

2019-07-20 Thread GitBox
mgaido91 commented on a change in pull request #25206: [SPARK-28265][SQL] Add renameTable to TableCatalog API URL: https://github.com/apache/spark/pull/25206#discussion_r305574623 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/catalog/v2/TableCatalog.java ##

[GitHub] [spark] SparkQA removed a comment on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION

2019-07-20 Thread GitBox
SparkQA removed a comment on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION URL: https://github.com/apache/spark/pull/20999#issuecomment-513453383 **[Test build #107939 has started](https://amplab.cs.berkeley.edu/jenkins/

[GitHub] [spark] mgaido91 commented on a change in pull request #25206: [SPARK-28265][SQL] Add renameTable to TableCatalog API

2019-07-20 Thread GitBox
mgaido91 commented on a change in pull request #25206: [SPARK-28265][SQL] Add renameTable to TableCatalog API URL: https://github.com/apache/spark/pull/25206#discussion_r305574616 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/catalog/v2/TableCatalog.java ##

[GitHub] [spark] AmplabJenkins removed a comment on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION URL: https://github.com/apache/spark/pull/20999#issuecomment-513453661 Merged build finished. Test FAILed.

[GitHub] [spark] mgaido91 commented on a change in pull request #25206: [SPARK-28265][SQL] Add renameTable to TableCatalog API

2019-07-20 Thread GitBox
mgaido91 commented on a change in pull request #25206: [SPARK-28265][SQL] Add renameTable to TableCatalog API URL: https://github.com/apache/spark/pull/25206#discussion_r305574596 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/catalog/v2/TableCatalog.java ##

[GitHub] [spark] mgaido91 commented on a change in pull request #25206: [SPARK-28265][SQL] Add renameTable to TableCatalog API

2019-07-20 Thread GitBox
mgaido91 commented on a change in pull request #25206: [SPARK-28265][SQL] Add renameTable to TableCatalog API URL: https://github.com/apache/spark/pull/25206#discussion_r305574692 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.s

[GitHub] [spark] mgaido91 commented on a change in pull request #25206: [SPARK-28265][SQL] Add renameTable to TableCatalog API

2019-07-20 Thread GitBox
mgaido91 commented on a change in pull request #25206: [SPARK-28265][SQL] Add renameTable to TableCatalog API URL: https://github.com/apache/spark/pull/25206#discussion_r305574650 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/catalog/v2/TableCatalog.java ##

[GitHub] [spark] AmplabJenkins commented on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION URL: https://github.com/apache/spark/pull/20999#issuecomment-513453782 Test PASSed. Refer to this link for build results (access rights to CI ser

[GitHub] [spark] AmplabJenkins removed a comment on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION URL: https://github.com/apache/spark/pull/20999#issuecomment-513453663 Test FAILed. Refer to this link for build results (access rights t

[GitHub] [spark] AmplabJenkins commented on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION URL: https://github.com/apache/spark/pull/20999#issuecomment-513453780 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION URL: https://github.com/apache/spark/pull/20999#issuecomment-513453780 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION URL: https://github.com/apache/spark/pull/20999#issuecomment-513453782 Test PASSed. Refer to this link for build results (access rights t

[GitHub] [spark] mgaido91 commented on a change in pull request #25160: [SPARK-28399][ML] implement RobustScaler

2019-07-20 Thread GitBox
mgaido91 commented on a change in pull request #25160: [SPARK-28399][ML] implement RobustScaler URL: https://github.com/apache/spark/pull/25160#discussion_r305575109 ## File path: mllib/src/main/scala/org/apache/spark/ml/feature/RobustScaler.scala ## @@ -0,0 +1,292 @@ +/*

[GitHub] [spark] mgaido91 commented on a change in pull request #25160: [SPARK-28399][ML] implement RobustScaler

2019-07-20 Thread GitBox
mgaido91 commented on a change in pull request #25160: [SPARK-28399][ML] implement RobustScaler URL: https://github.com/apache/spark/pull/25160#discussion_r305575055 ## File path: mllib/src/main/scala/org/apache/spark/ml/feature/RobustScaler.scala ## @@ -0,0 +1,292 @@ +/*

[GitHub] [spark] mgaido91 commented on a change in pull request #25160: [SPARK-28399][ML] implement RobustScaler

2019-07-20 Thread GitBox
mgaido91 commented on a change in pull request #25160: [SPARK-28399][ML] implement RobustScaler URL: https://github.com/apache/spark/pull/25160#discussion_r305575344 ## File path: mllib/src/main/scala/org/apache/spark/ml/feature/StandardScaler.scala ## @@ -245,4 +224,85 @

[GitHub] [spark] mgaido91 commented on a change in pull request #25160: [SPARK-28399][ML] implement RobustScaler

2019-07-20 Thread GitBox
mgaido91 commented on a change in pull request #25160: [SPARK-28399][ML] implement RobustScaler URL: https://github.com/apache/spark/pull/25160#discussion_r305575148 ## File path: mllib/src/main/scala/org/apache/spark/ml/feature/RobustScaler.scala ## @@ -0,0 +1,292 @@ +/*

[GitHub] [spark] mgaido91 commented on a change in pull request #25160: [SPARK-28399][ML] implement RobustScaler

2019-07-20 Thread GitBox
mgaido91 commented on a change in pull request #25160: [SPARK-28399][ML] implement RobustScaler URL: https://github.com/apache/spark/pull/25160#discussion_r305575336 ## File path: mllib/src/main/scala/org/apache/spark/mllib/feature/StandardScaler.scala ## @@ -134,77 +136,

[GitHub] [spark] mgaido91 commented on a change in pull request #25160: [SPARK-28399][ML] implement RobustScaler

2019-07-20 Thread GitBox
mgaido91 commented on a change in pull request #25160: [SPARK-28399][ML] implement RobustScaler URL: https://github.com/apache/spark/pull/25160#discussion_r305575229 ## File path: mllib/src/main/scala/org/apache/spark/ml/feature/RobustScaler.scala ## @@ -0,0 +1,292 @@ +/*

[GitHub] [spark] mgaido91 commented on a change in pull request #25160: [SPARK-28399][ML] implement RobustScaler

2019-07-20 Thread GitBox
mgaido91 commented on a change in pull request #25160: [SPARK-28399][ML] implement RobustScaler URL: https://github.com/apache/spark/pull/25160#discussion_r305574976 ## File path: mllib/src/main/scala/org/apache/spark/ml/feature/RobustScaler.scala ## @@ -0,0 +1,292 @@ +/*

[GitHub] [spark] mgaido91 commented on a change in pull request #25160: [SPARK-28399][ML] implement RobustScaler

2019-07-20 Thread GitBox
mgaido91 commented on a change in pull request #25160: [SPARK-28399][ML] implement RobustScaler URL: https://github.com/apache/spark/pull/25160#discussion_r305575349 ## File path: mllib/src/main/scala/org/apache/spark/ml/feature/StandardScaler.scala ## @@ -245,4 +224,85 @

[GitHub] [spark] mgaido91 commented on a change in pull request #25160: [SPARK-28399][ML] implement RobustScaler

2019-07-20 Thread GitBox
mgaido91 commented on a change in pull request #25160: [SPARK-28399][ML] implement RobustScaler URL: https://github.com/apache/spark/pull/25160#discussion_r305575345 ## File path: mllib/src/main/scala/org/apache/spark/ml/feature/StandardScaler.scala ## @@ -245,4 +224,85 @

[GitHub] [spark] mgaido91 commented on a change in pull request #25160: [SPARK-28399][ML] implement RobustScaler

2019-07-20 Thread GitBox
mgaido91 commented on a change in pull request #25160: [SPARK-28399][ML] implement RobustScaler URL: https://github.com/apache/spark/pull/25160#discussion_r305575352 ## File path: mllib/src/main/scala/org/apache/spark/ml/feature/StandardScaler.scala ## @@ -245,4 +224,85 @

[GitHub] [spark] mgaido91 commented on a change in pull request #25160: [SPARK-28399][ML] implement RobustScaler

2019-07-20 Thread GitBox
mgaido91 commented on a change in pull request #25160: [SPARK-28399][ML] implement RobustScaler URL: https://github.com/apache/spark/pull/25160#discussion_r305575311 ## File path: mllib/src/main/scala/org/apache/spark/ml/feature/StandardScaler.scala ## @@ -245,4 +224,85 @

[GitHub] [spark] AmplabJenkins commented on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION URL: https://github.com/apache/spark/pull/20999#issuecomment-513457305 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION URL: https://github.com/apache/spark/pull/20999#issuecomment-513457309 Test PASSed. Refer to this link for build results (access rights to CI ser

[GitHub] [spark] AmplabJenkins removed a comment on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION URL: https://github.com/apache/spark/pull/20999#issuecomment-513457305 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION URL: https://github.com/apache/spark/pull/20999#issuecomment-513457309 Test PASSed. Refer to this link for build results (access rights t

[GitHub] [spark] SparkQA commented on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION

2019-07-20 Thread GitBox
SparkQA commented on issue #20999: [SPARK-14922][SPARK-17732][SPARK-23866][SQL] Support partition filters in ALTER TABLE DROP PARTITION URL: https://github.com/apache/spark/pull/20999#issuecomment-513457444 **[Test build #107940 has started](https://amplab.cs.berkeley.edu/jenkins/job/Spark

[GitHub] [spark] SparkQA commented on issue #21599: [SPARK-26218][SQL] Overflow on arithmetic operations returns incorrect result

2019-07-20 Thread GitBox
SparkQA commented on issue #21599: [SPARK-26218][SQL] Overflow on arithmetic operations returns incorrect result URL: https://github.com/apache/spark/pull/21599#issuecomment-513461108 **[Test build #107938 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107

[GitHub] [spark] AmplabJenkins commented on issue #21599: [SPARK-26218][SQL] Overflow on arithmetic operations returns incorrect result

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #21599: [SPARK-26218][SQL] Overflow on arithmetic operations returns incorrect result URL: https://github.com/apache/spark/pull/21599#issuecomment-513461158 Test FAILed. Refer to this link for build results (access rights to CI server needed): https:/

[GitHub] [spark] SparkQA removed a comment on issue #21599: [SPARK-26218][SQL] Overflow on arithmetic operations returns incorrect result

2019-07-20 Thread GitBox
SparkQA removed a comment on issue #21599: [SPARK-26218][SQL] Overflow on arithmetic operations returns incorrect result URL: https://github.com/apache/spark/pull/21599#issuecomment-513450421 **[Test build #107938 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuil

[GitHub] [spark] AmplabJenkins removed a comment on issue #21599: [SPARK-26218][SQL] Overflow on arithmetic operations returns incorrect result

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #21599: [SPARK-26218][SQL] Overflow on arithmetic operations returns incorrect result URL: https://github.com/apache/spark/pull/21599#issuecomment-513461153 Merged build finished. Test FAILed.

[GitHub] [spark] AmplabJenkins commented on issue #21599: [SPARK-26218][SQL] Overflow on arithmetic operations returns incorrect result

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #21599: [SPARK-26218][SQL] Overflow on arithmetic operations returns incorrect result URL: https://github.com/apache/spark/pull/21599#issuecomment-513461153 Merged build finished. Test FAILed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #21599: [SPARK-26218][SQL] Overflow on arithmetic operations returns incorrect result

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #21599: [SPARK-26218][SQL] Overflow on arithmetic operations returns incorrect result URL: https://github.com/apache/spark/pull/21599#issuecomment-513461158 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #23531: [WIP][SPARK-24497][SQL] Support recursive SQL query

2019-07-20 Thread GitBox
SparkQA commented on issue #23531: [WIP][SPARK-24497][SQL] Support recursive SQL query URL: https://github.com/apache/spark/pull/23531#issuecomment-513461268 **[Test build #107937 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107937/testReport)** for PR

[GitHub] [spark] SparkQA removed a comment on issue #23531: [WIP][SPARK-24497][SQL] Support recursive SQL query

2019-07-20 Thread GitBox
SparkQA removed a comment on issue #23531: [WIP][SPARK-24497][SQL] Support recursive SQL query URL: https://github.com/apache/spark/pull/23531#issuecomment-513446637 **[Test build #107937 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107937/testReport)**

[GitHub] [spark] AmplabJenkins commented on issue #23531: [WIP][SPARK-24497][SQL] Support recursive SQL query

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #23531: [WIP][SPARK-24497][SQL] Support recursive SQL query URL: https://github.com/apache/spark/pull/23531#issuecomment-513461404 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/je

[GitHub] [spark] AmplabJenkins removed a comment on issue #23531: [WIP][SPARK-24497][SQL] Support recursive SQL query

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #23531: [WIP][SPARK-24497][SQL] Support recursive SQL query URL: https://github.com/apache/spark/pull/23531#issuecomment-513461404 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkele

[GitHub] [spark] AmplabJenkins removed a comment on issue #23531: [WIP][SPARK-24497][SQL] Support recursive SQL query

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #23531: [WIP][SPARK-24497][SQL] Support recursive SQL query URL: https://github.com/apache/spark/pull/23531#issuecomment-513461402 Merged build finished. Test PASSed. This is an automa

[GitHub] [spark] AmplabJenkins commented on issue #23531: [WIP][SPARK-24497][SQL] Support recursive SQL query

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #23531: [WIP][SPARK-24497][SQL] Support recursive SQL query URL: https://github.com/apache/spark/pull/23531#issuecomment-513461402 Merged build finished. Test PASSed. This is an automated mess

[GitHub] [spark] MaxGekk opened a new pull request #25210: [SPARK-28432][SQL] New function - make_date

2019-07-20 Thread GitBox
MaxGekk opened a new pull request #25210: [SPARK-28432][SQL] New function - make_date URL: https://github.com/apache/spark/pull/25210 ## What changes were proposed in this pull request? New function `make_date()` takes 3 columns `year`, `month` and `day`, and makes new column of the

[GitHub] [spark] AmplabJenkins commented on issue #25210: [SPARK-28432][SQL] New function - make_date

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #25210: [SPARK-28432][SQL] New function - make_date URL: https://github.com/apache/spark/pull/25210#issuecomment-513463258 Can one of the admins verify this patch? This is an automated message

[GitHub] [spark] AmplabJenkins commented on issue #25210: [SPARK-28432][SQL] New function - make_date

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #25210: [SPARK-28432][SQL] New function - make_date URL: https://github.com/apache/spark/pull/25210#issuecomment-513463306 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//

[GitHub] [spark] AmplabJenkins commented on issue #25210: [SPARK-28432][SQL] New function - make_date

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #25210: [SPARK-28432][SQL] New function - make_date URL: https://github.com/apache/spark/pull/25210#issuecomment-513463305 Merged build finished. Test PASSed. This is an automated message from

[GitHub] [spark] beliefer commented on a change in pull request #25074: [SPARK-27924][SQL] Support ANSI SQL Boolean-Predicate syntax

2019-07-20 Thread GitBox
beliefer commented on a change in pull request #25074: [SPARK-27924][SQL] Support ANSI SQL Boolean-Predicate syntax URL: https://github.com/apache/spark/pull/25074#discussion_r305578293 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala

[GitHub] [spark] AmplabJenkins removed a comment on issue #25210: [SPARK-28432][SQL] New function - make_date

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #25210: [SPARK-28432][SQL] New function - make_date URL: https://github.com/apache/spark/pull/25210#issuecomment-513463306 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/j

[GitHub] [spark] AmplabJenkins removed a comment on issue #25210: [SPARK-28432][SQL] New function - make_date

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #25210: [SPARK-28432][SQL] New function - make_date URL: https://github.com/apache/spark/pull/25210#issuecomment-513463305 Merged build finished. Test PASSed. This is an automated mess

[GitHub] [spark] SparkQA commented on issue #25210: [SPARK-28432][SQL] New function - make_date

2019-07-20 Thread GitBox
SparkQA commented on issue #25210: [SPARK-28432][SQL] New function - make_date URL: https://github.com/apache/spark/pull/25210#issuecomment-513463432 **[Test build #107941 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107941/testReport)** for PR 25210 at c

[GitHub] [spark] AmplabJenkins removed a comment on issue #25210: [SPARK-28432][SQL] New function - make_date

2019-07-20 Thread GitBox
AmplabJenkins removed a comment on issue #25210: [SPARK-28432][SQL] New function - make_date URL: https://github.com/apache/spark/pull/25210#issuecomment-513463258 Can one of the admins verify this patch? This is an automated

[GitHub] [spark] ulysses-you commented on issue #25085: [SPARK-28313][SQL] Spark sql null type incompatible with hive void type

2019-07-20 Thread GitBox
ulysses-you commented on issue #25085: [SPARK-28313][SQL] Spark sql null type incompatible with hive void type URL: https://github.com/apache/spark/pull/25085#issuecomment-513464122 retest this please This is an automated mes

[GitHub] [spark] AmplabJenkins commented on issue #21599: [SPARK-26218][SQL] Overflow on arithmetic operations returns incorrect result

2019-07-20 Thread GitBox
AmplabJenkins commented on issue #21599: [SPARK-26218][SQL] Overflow on arithmetic operations returns incorrect result URL: https://github.com/apache/spark/pull/21599#issuecomment-513470181 Test PASSed. Refer to this link for build results (access rights to CI server needed): https:

  1   2   3   4   >