[GitHub] [spark] rednaxelafx edited a comment on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions

2019-08-27 Thread GitBox
rednaxelafx edited a comment on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#issuecomment-525603727 Thanks for working on this PR, @maropu ! The new generated code looks a lot better! I'll go into more detai

[GitHub] [spark] AmplabJenkins commented on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer

2019-08-27 Thread GitBox
AmplabJenkins commented on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer URL: https://github.com/apache/spark/pull/22138#issuecomment-525610812 Merged build finished. Test PASSed. This is an a

[GitHub] [spark] AmplabJenkins commented on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer

2019-08-27 Thread GitBox
AmplabJenkins commented on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer URL: https://github.com/apache/spark/pull/22138#issuecomment-525610816 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.be

[GitHub] [spark] cloud-fan commented on a change in pull request #25600: [SPARK-11150][SQL] Dynamic Partition Pruning

2019-08-27 Thread GitBox
cloud-fan commented on a change in pull request #25600: [SPARK-11150][SQL] Dynamic Partition Pruning URL: https://github.com/apache/spark/pull/25600#discussion_r318419254 ## File path: sql/core/src/main/scala/org/apache/spark/sql/dynamicpruning/PartitionPruning.scala ## @

[GitHub] [spark] SparkQA removed a comment on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer

2019-08-27 Thread GitBox
SparkQA removed a comment on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer URL: https://github.com/apache/spark/pull/22138#issuecomment-525581381 **[Test build #109847 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109847/te

[GitHub] [spark] SparkQA commented on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer

2019-08-27 Thread GitBox
SparkQA commented on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer URL: https://github.com/apache/spark/pull/22138#issuecomment-525610234 **[Test build #109847 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109847/testRepor

[GitHub] [spark] cloud-fan commented on a change in pull request #25600: [SPARK-11150][SQL] Dynamic Partition Pruning

2019-08-27 Thread GitBox
cloud-fan commented on a change in pull request #25600: [SPARK-11150][SQL] Dynamic Partition Pruning URL: https://github.com/apache/spark/pull/25600#discussion_r318418269 ## File path: sql/core/src/main/scala/org/apache/spark/sql/dynamicpruning/PartitionPruning.scala ## @

[GitHub] [spark] maropu commented on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions

2019-08-27 Thread GitBox
maropu commented on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#issuecomment-525609519 ok, I'll brush up the code based on the comment 1, 2, and 3. > under the "generated code in the current master" line

[GitHub] [spark] cloud-fan commented on a change in pull request #25600: [SPARK-11150][SQL] Dynamic Partition Pruning

2019-08-27 Thread GitBox
cloud-fan commented on a change in pull request #25600: [SPARK-11150][SQL] Dynamic Partition Pruning URL: https://github.com/apache/spark/pull/25600#discussion_r318417695 ## File path: sql/core/src/main/scala/org/apache/spark/sql/dynamicpruning/PartitionPruning.scala ## @

[GitHub] [spark] cloud-fan commented on a change in pull request #25600: [SPARK-11150][SQL] Dynamic Partition Pruning

2019-08-27 Thread GitBox
cloud-fan commented on a change in pull request #25600: [SPARK-11150][SQL] Dynamic Partition Pruning URL: https://github.com/apache/spark/pull/25600#discussion_r318415489 ## File path: sql/core/src/main/scala/org/apache/spark/sql/dynamicpruning/PartitionPruning.scala ## @

[GitHub] [spark] cloud-fan commented on a change in pull request #25600: [SPARK-11150][SQL] Dynamic Partition Pruning

2019-08-27 Thread GitBox
cloud-fan commented on a change in pull request #25600: [SPARK-11150][SQL] Dynamic Partition Pruning URL: https://github.com/apache/spark/pull/25600#discussion_r318414792 ## File path: sql/core/src/main/scala/org/apache/spark/sql/dynamicpruning/PartitionPruning.scala ## @

[GitHub] [spark] SparkQA commented on issue #24715: [SPARK-25474][SQL][DOCS] Update the docs for spark.sql.statistics.fallBackToHdfs

2019-08-27 Thread GitBox
SparkQA commented on issue #24715: [SPARK-25474][SQL][DOCS] Update the docs for spark.sql.statistics.fallBackToHdfs URL: https://github.com/apache/spark/pull/24715#issuecomment-525605893 **[Test build #109851 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/1

[GitHub] [spark] AmplabJenkins removed a comment on issue #24715: [SPARK-25474][SQL][DOCS] Update the docs for spark.sql.statistics.fallBackToHdfs

2019-08-27 Thread GitBox
AmplabJenkins removed a comment on issue #24715: [SPARK-25474][SQL][DOCS] Update the docs for spark.sql.statistics.fallBackToHdfs URL: https://github.com/apache/spark/pull/24715#issuecomment-525605357 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #24715: [SPARK-25474][SQL][DOCS] Update the docs for spark.sql.statistics.fallBackToHdfs

2019-08-27 Thread GitBox
AmplabJenkins removed a comment on issue #24715: [SPARK-25474][SQL][DOCS] Update the docs for spark.sql.statistics.fallBackToHdfs URL: https://github.com/apache/spark/pull/24715#issuecomment-525605353 Merged build finished. Test PASSed. -

[GitHub] [spark] AmplabJenkins commented on issue #24715: [SPARK-25474][SQL][DOCS] Update the docs for spark.sql.statistics.fallBackToHdfs

2019-08-27 Thread GitBox
AmplabJenkins commented on issue #24715: [SPARK-25474][SQL][DOCS] Update the docs for spark.sql.statistics.fallBackToHdfs URL: https://github.com/apache/spark/pull/24715#issuecomment-525605353 Merged build finished. Test PASSed. -

[GitHub] [spark] AmplabJenkins commented on issue #24715: [SPARK-25474][SQL][DOCS] Update the docs for spark.sql.statistics.fallBackToHdfs

2019-08-27 Thread GitBox
AmplabJenkins commented on issue #24715: [SPARK-25474][SQL][DOCS] Update the docs for spark.sql.statistics.fallBackToHdfs URL: https://github.com/apache/spark/pull/24715#issuecomment-525605357 Test PASSed. Refer to this link for build results (access rights to CI server needed): htt

[GitHub] [spark] maropu commented on a change in pull request #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries

2019-08-27 Thread GitBox
maropu commented on a change in pull request #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries URL: https://github.com/apache/spark/pull/25464#discussion_r318411125 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveHints.scala #

[GitHub] [spark] maropu commented on a change in pull request #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries

2019-08-27 Thread GitBox
maropu commented on a change in pull request #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries URL: https://github.com/apache/spark/pull/25464#discussion_r318411288 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveHints.scala #

[GitHub] [spark] maropu commented on a change in pull request #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries

2019-08-27 Thread GitBox
maropu commented on a change in pull request #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries URL: https://github.com/apache/spark/pull/25464#discussion_r318411503 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveHints.scala #

[GitHub] [spark] maropu commented on a change in pull request #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries

2019-08-27 Thread GitBox
maropu commented on a change in pull request #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries URL: https://github.com/apache/spark/pull/25464#discussion_r318399393 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveHints.scala #

[GitHub] [spark] AmplabJenkins removed a comment on issue #25606: [SPARK-28814][SQL][DOC] Document SET/RESET in SQL Reference

2019-08-27 Thread GitBox
AmplabJenkins removed a comment on issue #25606: [SPARK-28814][SQL][DOC] Document SET/RESET in SQL Reference URL: https://github.com/apache/spark/pull/25606#issuecomment-525603363 Can one of the admins verify this patch? This

[GitHub] [spark] HeartSaVioR edited a comment on issue #25577: [WIP][CORE][SPARK-28867] InMemoryStore checkpoint to speed up replay log file in HistoryServer

2019-08-27 Thread GitBox
HeartSaVioR edited a comment on issue #25577: [WIP][CORE][SPARK-28867] InMemoryStore checkpoint to speed up replay log file in HistoryServer URL: https://github.com/apache/spark/pull/25577#issuecomment-525578717 Thanks for pointing out about "recover live entities". I've commented in your

[GitHub] [spark] AmplabJenkins commented on issue #25606: [SPARK-28814][SQL][DOC] Document SET/RESET in SQL Reference

2019-08-27 Thread GitBox
AmplabJenkins commented on issue #25606: [SPARK-28814][SQL][DOC] Document SET/RESET in SQL Reference URL: https://github.com/apache/spark/pull/25606#issuecomment-525603857 Can one of the admins verify this patch? This is an a

[GitHub] [spark] cloud-fan commented on a change in pull request #25600: [SPARK-11150][SQL] Dynamic Partition Pruning

2019-08-27 Thread GitBox
cloud-fan commented on a change in pull request #25600: [SPARK-11150][SQL] Dynamic Partition Pruning URL: https://github.com/apache/spark/pull/25600#discussion_r318411372 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -216,6 +2

[GitHub] [spark] rednaxelafx commented on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions

2019-08-27 Thread GitBox
rednaxelafx commented on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#issuecomment-525603727 Thanks for working on this PR, @maropu ! The new generated code looks a lot better! I'll go into more detailed rev

[GitHub] [spark] AmplabJenkins removed a comment on issue #25606: [SPARK-28814][SQL][DOC] Document SET/RESET in SQL Reference

2019-08-27 Thread GitBox
AmplabJenkins removed a comment on issue #25606: [SPARK-28814][SQL][DOC] Document SET/RESET in SQL Reference URL: https://github.com/apache/spark/pull/25606#issuecomment-525603229 Can one of the admins verify this patch? This

[GitHub] [spark] AmplabJenkins commented on issue #25606: [SPARK-28814][SQL][DOC] Document SET/RESET in SQL Reference

2019-08-27 Thread GitBox
AmplabJenkins commented on issue #25606: [SPARK-28814][SQL][DOC] Document SET/RESET in SQL Reference URL: https://github.com/apache/spark/pull/25606#issuecomment-525603363 Can one of the admins verify this patch? This is an a

[GitHub] [spark] AmplabJenkins commented on issue #25606: [SPARK-28814][SQL][DOC] Document SET/RESET in SQL Reference

2019-08-27 Thread GitBox
AmplabJenkins commented on issue #25606: [SPARK-28814][SQL][DOC] Document SET/RESET in SQL Reference URL: https://github.com/apache/spark/pull/25606#issuecomment-525603229 Can one of the admins verify this patch? This is an a

[GitHub] [spark] sharangk opened a new pull request #25606: [SPARK-28814][SQL][DOC] Document SET/RESET in SQL Reference

2019-08-27 Thread GitBox
sharangk opened a new pull request #25606: [SPARK-28814][SQL][DOC] Document SET/RESET in SQL Reference URL: https://github.com/apache/spark/pull/25606 ### What changes were proposed in this pull request? Document SET/REST statement in SQL Reference Guide. ### Why are the changes n

[GitHub] [spark] cloud-fan commented on a change in pull request #24715: [SPARK-25474][SQL][DOCS] Update the docs for spark.sql.statistics.fallBackToHdfs

2019-08-27 Thread GitBox
cloud-fan commented on a change in pull request #24715: [SPARK-25474][SQL][DOCS] Update the docs for spark.sql.statistics.fallBackToHdfs URL: https://github.com/apache/spark/pull/24715#discussion_r318409103 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQL

[GitHub] [spark] cloud-fan commented on a change in pull request #24715: [SPARK-25474][SQL][DOCS] Update the docs for spark.sql.statistics.fallBackToHdfs

2019-08-27 Thread GitBox
cloud-fan commented on a change in pull request #24715: [SPARK-25474][SQL][DOCS] Update the docs for spark.sql.statistics.fallBackToHdfs URL: https://github.com/apache/spark/pull/24715#discussion_r318408974 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQL

[GitHub] [spark] cloud-fan commented on a change in pull request #25600: [SPARK-11150][SQL] Dynamic Partition Pruning

2019-08-27 Thread GitBox
cloud-fan commented on a change in pull request #25600: [SPARK-11150][SQL] Dynamic Partition Pruning URL: https://github.com/apache/spark/pull/25600#discussion_r318408096 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/DynamicPruning.scala #

[GitHub] [spark] cloud-fan commented on a change in pull request #25600: [SPARK-11150][SQL] Dynamic Partition Pruning

2019-08-27 Thread GitBox
cloud-fan commented on a change in pull request #25600: [SPARK-11150][SQL] Dynamic Partition Pruning URL: https://github.com/apache/spark/pull/25600#discussion_r318408096 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/DynamicPruning.scala #

[GitHub] [spark] cloud-fan commented on a change in pull request #25600: [SPARK-11150][SQL] Dynamic Partition Pruning

2019-08-27 Thread GitBox
cloud-fan commented on a change in pull request #25600: [SPARK-11150][SQL] Dynamic Partition Pruning URL: https://github.com/apache/spark/pull/25600#discussion_r318408011 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/DynamicPruning.scala #

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25600: [SPARK-11150][SQL] Dynamic Partition Pruning

2019-08-27 Thread GitBox
HyukjinKwon commented on a change in pull request #25600: [SPARK-11150][SQL] Dynamic Partition Pruning URL: https://github.com/apache/spark/pull/25600#discussion_r318405325 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ##

[GitHub] [spark] SparkQA commented on issue #24715: [SPARK-25474][SQL][DOCS] Update the docs for spark.sql.statistics.fallBackToHdfs

2019-08-27 Thread GitBox
SparkQA commented on issue #24715: [SPARK-25474][SQL][DOCS] Update the docs for spark.sql.statistics.fallBackToHdfs URL: https://github.com/apache/spark/pull/24715#issuecomment-525596848 **[Test build #109850 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/1

[GitHub] [spark] AmplabJenkins removed a comment on issue #24715: [SPARK-25474][SQL][DOCS] Update the docs for spark.sql.statistics.fallBackToHdfs

2019-08-27 Thread GitBox
AmplabJenkins removed a comment on issue #24715: [SPARK-25474][SQL][DOCS] Update the docs for spark.sql.statistics.fallBackToHdfs URL: https://github.com/apache/spark/pull/24715#issuecomment-525596352 Merged build finished. Test PASSed. -

[GitHub] [spark] AmplabJenkins removed a comment on issue #24715: [SPARK-25474][SQL][DOCS] Update the docs for spark.sql.statistics.fallBackToHdfs

2019-08-27 Thread GitBox
AmplabJenkins removed a comment on issue #24715: [SPARK-25474][SQL][DOCS] Update the docs for spark.sql.statistics.fallBackToHdfs URL: https://github.com/apache/spark/pull/24715#issuecomment-525596356 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #24715: [SPARK-25474][SQL][DOCS] Update the docs for spark.sql.statistics.fallBackToHdfs

2019-08-27 Thread GitBox
AmplabJenkins commented on issue #24715: [SPARK-25474][SQL][DOCS] Update the docs for spark.sql.statistics.fallBackToHdfs URL: https://github.com/apache/spark/pull/24715#issuecomment-525596352 Merged build finished. Test PASSed. -

[GitHub] [spark] AmplabJenkins commented on issue #24715: [SPARK-25474][SQL][DOCS] Update the docs for spark.sql.statistics.fallBackToHdfs

2019-08-27 Thread GitBox
AmplabJenkins commented on issue #24715: [SPARK-25474][SQL][DOCS] Update the docs for spark.sql.statistics.fallBackToHdfs URL: https://github.com/apache/spark/pull/24715#issuecomment-525596356 Test PASSed. Refer to this link for build results (access rights to CI server needed): htt

[GitHub] [spark] MGHawes commented on issue #25575: [SPARK-28818][SQL] Respect source column nullability in the arrays created by `freqItems()`

2019-08-27 Thread GitBox
MGHawes commented on issue #25575: [SPARK-28818][SQL] Respect source column nullability in the arrays created by `freqItems()` URL: https://github.com/apache/spark/pull/25575#issuecomment-525592248 Thanks, wasn't sure of the process -

[GitHub] [spark] maropu commented on issue #25575: [SPARK-28818][SQL] Respect source column nullability in the arrays created by `freqItems()`

2019-08-27 Thread GitBox
maropu commented on issue #25575: [SPARK-28818][SQL] Respect source column nullability in the arrays created by `freqItems()` URL: https://github.com/apache/spark/pull/25575#issuecomment-525591657 You don't need to do so and the commiltters will do later. --

[GitHub] [spark] MGHawes commented on issue #25575: [SPARK-28818][SQL] Respect source column nullability in the arrays created by `freqItems()`

2019-08-27 Thread GitBox
MGHawes commented on issue #25575: [SPARK-28818][SQL] Respect source column nullability in the arrays created by `freqItems()` URL: https://github.com/apache/spark/pull/25575#issuecomment-525590808 Thanks for the reviews @maropu, @srowen are we good to merge this? I obv. don't have write a

[GitHub] [spark] AmplabJenkins removed a comment on issue #25512: [SPARK-28782][SQL] Generator support in aggregate expressions

2019-08-27 Thread GitBox
AmplabJenkins removed a comment on issue #25512: [SPARK-28782][SQL] Generator support in aggregate expressions URL: https://github.com/apache/spark/pull/25512#issuecomment-525589500 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.

[GitHub] [spark] AmplabJenkins commented on issue #25512: [SPARK-28782][SQL] Generator support in aggregate expressions

2019-08-27 Thread GitBox
AmplabJenkins commented on issue #25512: [SPARK-28782][SQL] Generator support in aggregate expressions URL: https://github.com/apache/spark/pull/25512#issuecomment-525589495 Merged build finished. Test FAILed. This is an auto

[GitHub] [spark] AmplabJenkins removed a comment on issue #25512: [SPARK-28782][SQL] Generator support in aggregate expressions

2019-08-27 Thread GitBox
AmplabJenkins removed a comment on issue #25512: [SPARK-28782][SQL] Generator support in aggregate expressions URL: https://github.com/apache/spark/pull/25512#issuecomment-525589495 Merged build finished. Test FAILed. This is

[GitHub] [spark] AmplabJenkins commented on issue #25512: [SPARK-28782][SQL] Generator support in aggregate expressions

2019-08-27 Thread GitBox
AmplabJenkins commented on issue #25512: [SPARK-28782][SQL] Generator support in aggregate expressions URL: https://github.com/apache/spark/pull/25512#issuecomment-525589500 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berke

[GitHub] [spark] SparkQA removed a comment on issue #25512: [SPARK-28782][SQL] Generator support in aggregate expressions

2019-08-27 Thread GitBox
SparkQA removed a comment on issue #25512: [SPARK-28782][SQL] Generator support in aggregate expressions URL: https://github.com/apache/spark/pull/25512#issuecomment-525560148 **[Test build #109842 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109842/testR

[GitHub] [spark] SparkQA commented on issue #25512: [SPARK-28782][SQL] Generator support in aggregate expressions

2019-08-27 Thread GitBox
SparkQA commented on issue #25512: [SPARK-28782][SQL] Generator support in aggregate expressions URL: https://github.com/apache/spark/pull/25512#issuecomment-525589309 **[Test build #109842 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109842/testReport)*

[GitHub] [spark] AmplabJenkins removed a comment on issue #25604: [SPARK-28890][SQL] Upgrade Hive Metastore Client to the 3.1.2 for Hive 3.1

2019-08-27 Thread GitBox
AmplabJenkins removed a comment on issue #25604: [SPARK-28890][SQL] Upgrade Hive Metastore Client to the 3.1.2 for Hive 3.1 URL: https://github.com/apache/spark/pull/25604#issuecomment-525588445 Merged build finished. Test PASSed. ---

[GitHub] [spark] AmplabJenkins removed a comment on issue #25604: [SPARK-28890][SQL] Upgrade Hive Metastore Client to the 3.1.2 for Hive 3.1

2019-08-27 Thread GitBox
AmplabJenkins removed a comment on issue #25604: [SPARK-28890][SQL] Upgrade Hive Metastore Client to the 3.1.2 for Hive 3.1 URL: https://github.com/apache/spark/pull/25604#issuecomment-525588451 Test PASSed. Refer to this link for build results (access rights to CI server needed): ht

[GitHub] [spark] AmplabJenkins commented on issue #25604: [SPARK-28890][SQL] Upgrade Hive Metastore Client to the 3.1.2 for Hive 3.1

2019-08-27 Thread GitBox
AmplabJenkins commented on issue #25604: [SPARK-28890][SQL] Upgrade Hive Metastore Client to the 3.1.2 for Hive 3.1 URL: https://github.com/apache/spark/pull/25604#issuecomment-525588451 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://am

[GitHub] [spark] AmplabJenkins commented on issue #25604: [SPARK-28890][SQL] Upgrade Hive Metastore Client to the 3.1.2 for Hive 3.1

2019-08-27 Thread GitBox
AmplabJenkins commented on issue #25604: [SPARK-28890][SQL] Upgrade Hive Metastore Client to the 3.1.2 for Hive 3.1 URL: https://github.com/apache/spark/pull/25604#issuecomment-525588445 Merged build finished. Test PASSed. Th

[GitHub] [spark] SparkQA removed a comment on issue #25604: [SPARK-28890][SQL] Upgrade Hive Metastore Client to the 3.1.2 for Hive 3.1

2019-08-27 Thread GitBox
SparkQA removed a comment on issue #25604: [SPARK-28890][SQL] Upgrade Hive Metastore Client to the 3.1.2 for Hive 3.1 URL: https://github.com/apache/spark/pull/25604#issuecomment-525568939 **[Test build #109843 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder

[GitHub] [spark] SparkQA commented on issue #25604: [SPARK-28890][SQL] Upgrade Hive Metastore Client to the 3.1.2 for Hive 3.1

2019-08-27 Thread GitBox
SparkQA commented on issue #25604: [SPARK-28890][SQL] Upgrade Hive Metastore Client to the 3.1.2 for Hive 3.1 URL: https://github.com/apache/spark/pull/25604#issuecomment-525588219 **[Test build #109843 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109843

[GitHub] [spark] maropu commented on a change in pull request #20965: [SPARK-21870][SQL] Split aggregation code into small functions

2019-08-27 Thread GitBox
maropu commented on a change in pull request #20965: [SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#discussion_r318393079 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25600: [SPARK-11150][SQL] Dynamic Partition Pruning

2019-08-27 Thread GitBox
HyukjinKwon commented on a change in pull request #25600: [SPARK-11150][SQL] Dynamic Partition Pruning URL: https://github.com/apache/spark/pull/25600#discussion_r318392852 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ##

[GitHub] [spark] AmplabJenkins commented on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions

2019-08-27 Thread GitBox
AmplabJenkins commented on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#issuecomment-525583973 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.ber

[GitHub] [spark] AmplabJenkins removed a comment on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions

2019-08-27 Thread GitBox
AmplabJenkins removed a comment on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#issuecomment-525583973 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://ampla

[GitHub] [spark] AmplabJenkins removed a comment on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions

2019-08-27 Thread GitBox
AmplabJenkins removed a comment on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#issuecomment-525583968 Merged build finished. Test PASSed. This i

[GitHub] [spark] AmplabJenkins commented on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions

2019-08-27 Thread GitBox
AmplabJenkins commented on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#issuecomment-525583968 Merged build finished. Test PASSed. This is an aut

[GitHub] [spark] SparkQA commented on issue #20965: [WIP][SPARK-21870][SQL] Split aggregation code into small functions

2019-08-27 Thread GitBox
SparkQA commented on issue #20965: [WIP][SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#issuecomment-525582857 **[Test build #109849 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109849/testRep

[GitHub] [spark] SparkQA commented on issue #25605: [SPARK-28730][SPARK-28495][SQL][FOLLOW-UP] Revise the doc of option spark.sql.storeAssignmentPolicy

2019-08-27 Thread GitBox
SparkQA commented on issue #25605: [SPARK-28730][SPARK-28495][SQL][FOLLOW-UP] Revise the doc of option spark.sql.storeAssignmentPolicy URL: https://github.com/apache/spark/pull/25605#issuecomment-525582843 **[Test build #109848 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkP

[GitHub] [spark] AmplabJenkins removed a comment on issue #25605: [SPARK-28730][SPARK-28495][SQL][FOLLOW-UP] Revise the doc of option spark.sql.storeAssignmentPolicy

2019-08-27 Thread GitBox
AmplabJenkins removed a comment on issue #25605: [SPARK-28730][SPARK-28495][SQL][FOLLOW-UP] Revise the doc of option spark.sql.storeAssignmentPolicy URL: https://github.com/apache/spark/pull/25605#issuecomment-525582472 Test PASSed. Refer to this link for build results (access rights to

[GitHub] [spark] AmplabJenkins removed a comment on issue #25605: [SPARK-28730][SPARK-28495][SQL][FOLLOW-UP] Revise the doc of option spark.sql.storeAssignmentPolicy

2019-08-27 Thread GitBox
AmplabJenkins removed a comment on issue #25605: [SPARK-28730][SPARK-28495][SQL][FOLLOW-UP] Revise the doc of option spark.sql.storeAssignmentPolicy URL: https://github.com/apache/spark/pull/25605#issuecomment-525582464 Merged build finished. Test PASSed. -

[GitHub] [spark] AmplabJenkins commented on issue #25605: [SPARK-28730][SPARK-28495][SQL][FOLLOW-UP] Revise the doc of option spark.sql.storeAssignmentPolicy

2019-08-27 Thread GitBox
AmplabJenkins commented on issue #25605: [SPARK-28730][SPARK-28495][SQL][FOLLOW-UP] Revise the doc of option spark.sql.storeAssignmentPolicy URL: https://github.com/apache/spark/pull/25605#issuecomment-525582464 Merged build finished. Test PASSed. -

[GitHub] [spark] AmplabJenkins commented on issue #25605: [SPARK-28730][SPARK-28495][SQL][FOLLOW-UP] Revise the doc of option spark.sql.storeAssignmentPolicy

2019-08-27 Thread GitBox
AmplabJenkins commented on issue #25605: [SPARK-28730][SPARK-28495][SQL][FOLLOW-UP] Revise the doc of option spark.sql.storeAssignmentPolicy URL: https://github.com/apache/spark/pull/25605#issuecomment-525582472 Test PASSed. Refer to this link for build results (access rights to CI serv

[GitHub] [spark] AmplabJenkins removed a comment on issue #20965: [WIP][SPARK-21870][SQL] Split aggregation code into small functions

2019-08-27 Thread GitBox
AmplabJenkins removed a comment on issue #20965: [WIP][SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#issuecomment-525582073 Merged build finished. Test PASSed. T

[GitHub] [spark] AmplabJenkins removed a comment on issue #20965: [WIP][SPARK-21870][SQL] Split aggregation code into small functions

2019-08-27 Thread GitBox
AmplabJenkins removed a comment on issue #20965: [WIP][SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#issuecomment-525582078 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://a

[GitHub] [spark] AmplabJenkins commented on issue #20965: [WIP][SPARK-21870][SQL] Split aggregation code into small functions

2019-08-27 Thread GitBox
AmplabJenkins commented on issue #20965: [WIP][SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#issuecomment-525582078 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs

[GitHub] [spark] AmplabJenkins commented on issue #20965: [WIP][SPARK-21870][SQL] Split aggregation code into small functions

2019-08-27 Thread GitBox
AmplabJenkins commented on issue #20965: [WIP][SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#issuecomment-525582073 Merged build finished. Test PASSed. This is a

[GitHub] [spark] SparkQA removed a comment on issue #20965: [WIP][SPARK-21870][SQL] Split aggregation code into small functions

2019-08-27 Thread GitBox
SparkQA removed a comment on issue #20965: [WIP][SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#issuecomment-525541633 **[Test build #109839 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109839

[GitHub] [spark] SparkQA commented on issue #20965: [WIP][SPARK-21870][SQL] Split aggregation code into small functions

2019-08-27 Thread GitBox
SparkQA commented on issue #20965: [WIP][SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#issuecomment-525581630 **[Test build #109839 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109839/testRe

[GitHub] [spark] SparkQA commented on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer

2019-08-27 Thread GitBox
SparkQA commented on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer URL: https://github.com/apache/spark/pull/22138#issuecomment-525581381 **[Test build #109847 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109847/testReport

[GitHub] [spark] SparkQA commented on issue #25600: [SPARK-11150][SQL] Dynamic Partition Pruning

2019-08-27 Thread GitBox
SparkQA commented on issue #25600: [SPARK-11150][SQL] Dynamic Partition Pruning URL: https://github.com/apache/spark/pull/25600#issuecomment-525581360 **[Test build #109846 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109846/testReport)** for PR 25600 at

[GitHub] [spark] AmplabJenkins removed a comment on issue #25600: [SPARK-11150][SQL] Dynamic Partition Pruning

2019-08-27 Thread GitBox
AmplabJenkins removed a comment on issue #25600: [SPARK-11150][SQL] Dynamic Partition Pruning URL: https://github.com/apache/spark/pull/25600#issuecomment-525581041 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/

[GitHub] [spark] AmplabJenkins removed a comment on issue #25600: [SPARK-11150][SQL] Dynamic Partition Pruning

2019-08-27 Thread GitBox
AmplabJenkins removed a comment on issue #25600: [SPARK-11150][SQL] Dynamic Partition Pruning URL: https://github.com/apache/spark/pull/25600#issuecomment-525581037 Merged build finished. Test PASSed. This is an automated mes

[GitHub] [spark] AmplabJenkins commented on issue #25600: [SPARK-11150][SQL] Dynamic Partition Pruning

2019-08-27 Thread GitBox
AmplabJenkins commented on issue #25600: [SPARK-11150][SQL] Dynamic Partition Pruning URL: https://github.com/apache/spark/pull/25600#issuecomment-525581041 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/

[GitHub] [spark] AmplabJenkins commented on issue #25600: [SPARK-11150][SQL] Dynamic Partition Pruning

2019-08-27 Thread GitBox
AmplabJenkins commented on issue #25600: [SPARK-11150][SQL] Dynamic Partition Pruning URL: https://github.com/apache/spark/pull/25600#issuecomment-525581037 Merged build finished. Test PASSed. This is an automated message fro

[GitHub] [spark] cloud-fan commented on a change in pull request #25458: [SPARK-27931][SQL] Accept "true", "yes", "1", "false", "no", "0", and unique prefixes as input and trim input for the boolean d

2019-08-27 Thread GitBox
cloud-fan commented on a change in pull request #25458: [SPARK-27931][SQL] Accept "true", "yes", "1", "false", "no", "0", and unique prefixes as input and trim input for the boolean data type. URL: https://github.com/apache/spark/pull/25458#discussion_r318389066 ## File path: sql/

[GitHub] [spark] cloud-fan commented on issue #25601: [SPARK-28856][SQL] Implement SHOW DATABASES for Data Source V2 Tables

2019-08-27 Thread GitBox
cloud-fan commented on issue #25601: [SPARK-28856][SQL] Implement SHOW DATABASES for Data Source V2 Tables URL: https://github.com/apache/spark/pull/25601#issuecomment-525580222 shall we call it `SHOW NAMESPACES`? This is an

[GitHub] [spark] cloud-fan commented on a change in pull request #25605: [SPARK-28730][SPARK-28495][SQL][FOLLOW-UP] Revise the doc of option spark.sql.storeAssignmentPolicy

2019-08-27 Thread GitBox
cloud-fan commented on a change in pull request #25605: [SPARK-28730][SPARK-28495][SQL][FOLLOW-UP] Revise the doc of option spark.sql.storeAssignmentPolicy URL: https://github.com/apache/spark/pull/25605#discussion_r318388587 ## File path: sql/catalyst/src/main/scala/org/apache/sp

[GitHub] [spark] HeartSaVioR edited a comment on issue #25577: [WIP][CORE][SPARK-28867] InMemoryStore checkpoint to speed up replay log file in HistoryServer

2019-08-27 Thread GitBox
HeartSaVioR edited a comment on issue #25577: [WIP][CORE][SPARK-28867] InMemoryStore checkpoint to speed up replay log file in HistoryServer URL: https://github.com/apache/spark/pull/25577#issuecomment-525578717 Thanks for pointing out about "recover live entities". I've commented in your

[GitHub] [spark] HeartSaVioR edited a comment on issue #25577: [WIP][CORE][SPARK-28867] InMemoryStore checkpoint to speed up replay log file in HistoryServer

2019-08-27 Thread GitBox
HeartSaVioR edited a comment on issue #25577: [WIP][CORE][SPARK-28867] InMemoryStore checkpoint to speed up replay log file in HistoryServer URL: https://github.com/apache/spark/pull/25577#issuecomment-525578717 Thanks for pointing out about "recover live entities". I've commented in your

[GitHub] [spark] HeartSaVioR edited a comment on issue #25577: [WIP][CORE][SPARK-28867] InMemoryStore checkpoint to speed up replay log file in HistoryServer

2019-08-27 Thread GitBox
HeartSaVioR edited a comment on issue #25577: [WIP][CORE][SPARK-28867] InMemoryStore checkpoint to speed up replay log file in HistoryServer URL: https://github.com/apache/spark/pull/25577#issuecomment-525578717 Thanks for pointing out about "recover live entities". I've commented in your

[GitHub] [spark] HeartSaVioR commented on issue #25577: [WIP][CORE][SPARK-28867] InMemoryStore checkpoint to speed up replay log file in HistoryServer

2019-08-27 Thread GitBox
HeartSaVioR commented on issue #25577: [WIP][CORE][SPARK-28867] InMemoryStore checkpoint to speed up replay log file in HistoryServer URL: https://github.com/apache/spark/pull/25577#issuecomment-525578717 Thanks for pointing out about "recover live entities". I've commented in your comment

[GitHub] [spark] cloud-fan closed pull request #25570: [SPARK-23519][SQL] create view should work from query with duplicate output columns

2019-08-27 Thread GitBox
cloud-fan closed pull request #25570: [SPARK-23519][SQL] create view should work from query with duplicate output columns URL: https://github.com/apache/spark/pull/25570 This is an automated message from the Apache Git Servi

[GitHub] [spark] cloud-fan commented on issue #25570: [SPARK-23519][SQL] create view should work from query with duplicate output columns

2019-08-27 Thread GitBox
cloud-fan commented on issue #25570: [SPARK-23519][SQL] create view should work from query with duplicate output columns URL: https://github.com/apache/spark/pull/25570#issuecomment-525576389 thanks, merging to master! This i

[GitHub] [spark] dilipbiswal commented on issue #25525: [SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference

2019-08-27 Thread GitBox
dilipbiswal commented on issue #25525: [SPARK-28786][DOC][SQL]Document INSERT statement in SQL Reference URL: https://github.com/apache/spark/pull/25525#issuecomment-525575081 LGTM cc @gatorsmile @srowen for final sign off. ---

[GitHub] [spark] SparkQA commented on issue #25575: [SPARK-28818][SQL] Respect source column nullability in the arrays created by `freqItems()`

2019-08-27 Thread GitBox
SparkQA commented on issue #25575: [SPARK-28818][SQL] Respect source column nullability in the arrays created by `freqItems()` URL: https://github.com/apache/spark/pull/25575#issuecomment-525574846 **[Test build #109845 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullReque

[GitHub] [spark] AmplabJenkins commented on issue #25575: [SPARK-28818][SQL] Respect source column nullability in the arrays created by `freqItems()`

2019-08-27 Thread GitBox
AmplabJenkins commented on issue #25575: [SPARK-28818][SQL] Respect source column nullability in the arrays created by `freqItems()` URL: https://github.com/apache/spark/pull/25575#issuecomment-525574425 Test PASSed. Refer to this link for build results (access rights to CI server needed

[GitHub] [spark] AmplabJenkins commented on issue #25575: [SPARK-28818][SQL] Respect source column nullability in the arrays created by `freqItems()`

2019-08-27 Thread GitBox
AmplabJenkins commented on issue #25575: [SPARK-28818][SQL] Respect source column nullability in the arrays created by `freqItems()` URL: https://github.com/apache/spark/pull/25575#issuecomment-525574423 Merged build finished. Test PASSed. --

[GitHub] [spark] AmplabJenkins removed a comment on issue #25575: [SPARK-28818][SQL] Respect source column nullability in the arrays created by `freqItems()`

2019-08-27 Thread GitBox
AmplabJenkins removed a comment on issue #25575: [SPARK-28818][SQL] Respect source column nullability in the arrays created by `freqItems()` URL: https://github.com/apache/spark/pull/25575#issuecomment-525574423 Merged build finished. Test PASSed. --

[GitHub] [spark] AmplabJenkins removed a comment on issue #25575: [SPARK-28818][SQL] Respect source column nullability in the arrays created by `freqItems()`

2019-08-27 Thread GitBox
AmplabJenkins removed a comment on issue #25575: [SPARK-28818][SQL] Respect source column nullability in the arrays created by `freqItems()` URL: https://github.com/apache/spark/pull/25575#issuecomment-525574425 Test PASSed. Refer to this link for build results (access rights to CI serve

[GitHub] [spark] HeartSaVioR commented on issue #22282: [SPARK-23539][SS] Add support for Kafka headers in Structured Streaming

2019-08-27 Thread GitBox
HeartSaVioR commented on issue #22282: [SPARK-23539][SS] Add support for Kafka headers in Structured Streaming URL: https://github.com/apache/spark/pull/22282#issuecomment-525573132 @dongjinleekr Kindly reminder. This is an a

[GitHub] [spark] AmplabJenkins removed a comment on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer

2019-08-27 Thread GitBox
AmplabJenkins removed a comment on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer URL: https://github.com/apache/spark/pull/22138#issuecomment-525572488 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://ampl

[GitHub] [spark] SparkQA removed a comment on issue #25559: [WIP][DO-NOT-MERGE] Test updating Kinesis deps and current state of Kinesis Python tests

2019-08-27 Thread GitBox
SparkQA removed a comment on issue #25559: [WIP][DO-NOT-MERGE] Test updating Kinesis deps and current state of Kinesis Python tests URL: https://github.com/apache/spark/pull/25559#issuecomment-525544916 **[Test build #4846 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPul

[GitHub] [spark] SparkQA commented on issue #25559: [WIP][DO-NOT-MERGE] Test updating Kinesis deps and current state of Kinesis Python tests

2019-08-27 Thread GitBox
SparkQA commented on issue #25559: [WIP][DO-NOT-MERGE] Test updating Kinesis deps and current state of Kinesis Python tests URL: https://github.com/apache/spark/pull/25559#issuecomment-525572637 **[Test build #4846 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullReques

[GitHub] [spark] AmplabJenkins removed a comment on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer

2019-08-27 Thread GitBox
AmplabJenkins removed a comment on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer URL: https://github.com/apache/spark/pull/22138#issuecomment-525572483 Merged build finished. Test FAILed. This

[GitHub] [spark] AmplabJenkins commented on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer

2019-08-27 Thread GitBox
AmplabJenkins commented on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer URL: https://github.com/apache/spark/pull/22138#issuecomment-525572483 Merged build finished. Test FAILed. This is an a

  1   2   3   4   5   6   7   8   9   10   >