[GitHub] [spark] gatorsmile closed pull request #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference

2019-09-01 Thread GitBox
gatorsmile closed pull request #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25532 This is an automated message from the Apache Git Service. To respo

[GitHub] [spark] dilipbiswal commented on issue #24759: [SPARK-27395][SQL] Improve EXPLAIN command

2019-09-01 Thread GitBox
dilipbiswal commented on issue #24759: [SPARK-27395][SQL] Improve EXPLAIN command URL: https://github.com/apache/spark/pull/24759#issuecomment-526965464 @gatorsmile Sure.. I will address it. This is an automated message from

[GitHub] [spark] ulysses-you commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries

2019-09-01 Thread GitBox
ulysses-you commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries URL: https://github.com/apache/spark/pull/25464#issuecomment-526966728 Thanks a lot for review. > And, I personally think the error message is ambiguous to users, so can you rethink it a

[GitHub] [spark] ulysses-you edited a comment on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries

2019-09-01 Thread GitBox
ulysses-you edited a comment on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries URL: https://github.com/apache/spark/pull/25464#issuecomment-526966728 Thanks a lot for review. > And, I personally think the error message is ambiguous to users, so can you rethi

[GitHub] [spark] ulysses-you edited a comment on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries

2019-09-01 Thread GitBox
ulysses-you edited a comment on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries URL: https://github.com/apache/spark/pull/25464#issuecomment-526966728 Thanks a lot for review. > And, I personally think the error message is ambiguous to users, so can you rethi

[GitHub] [spark] ulysses-you edited a comment on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries

2019-09-01 Thread GitBox
ulysses-you edited a comment on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries URL: https://github.com/apache/spark/pull/25464#issuecomment-526966728 Thanks a lot for review. > And, I personally think the error message is ambiguous to users, so can you rethi

[GitHub] [spark] huaxingao commented on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference

2019-09-01 Thread GitBox
huaxingao commented on issue #25532: [SPARK-28790][DOC][SQL]Document CACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25532#issuecomment-526971559 Thanks! @gatorsmile @srowen @dilipbiswal This

[GitHub] [spark] advancedxy commented on issue #25306: [SPARK-28573][SQL] Convert InsertIntoTable(HiveTableRelation) to DataSource inserting for partitioned table

2019-09-01 Thread GitBox
advancedxy commented on issue #25306: [SPARK-28573][SQL] Convert InsertIntoTable(HiveTableRelation) to DataSource inserting for partitioned table URL: https://github.com/apache/spark/pull/25306#issuecomment-526974511 > cc @wangyum, after changes applied to HiveTableRelation, we don't modify

[GitHub] [spark] ulysses-you commented on a change in pull request #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries

2019-09-01 Thread GitBox
ulysses-you commented on a change in pull request #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries URL: https://github.com/apache/spark/pull/25464#discussion_r319787726 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveHints.sca

[GitHub] [spark] AmplabJenkins commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries

2019-09-01 Thread GitBox
AmplabJenkins commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries URL: https://github.com/apache/spark/pull/25464#issuecomment-526975867 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.

[GitHub] [spark] MrDLontheway opened a new pull request #25646: [SPARK-27336][SQL] Incorrect DataSet.summary() result

2019-09-01 Thread GitBox
MrDLontheway opened a new pull request #25646: [SPARK-27336][SQL] Incorrect DataSet.summary() result URL: https://github.com/apache/spark/pull/25646 ### What changes were proposed in this pull request? Change the default value of accuracy ### Why are the changes ne

[GitHub] [spark] AmplabJenkins removed a comment on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries

2019-09-01 Thread GitBox
AmplabJenkins removed a comment on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries URL: https://github.com/apache/spark/pull/25464#issuecomment-526975867 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.b

[GitHub] [spark] AmplabJenkins commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries

2019-09-01 Thread GitBox
AmplabJenkins commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries URL: https://github.com/apache/spark/pull/25464#issuecomment-526975864 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] AmplabJenkins removed a comment on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries

2019-09-01 Thread GitBox
AmplabJenkins removed a comment on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries URL: https://github.com/apache/spark/pull/25464#issuecomment-526975864 Merged build finished. Test PASSed. This is an a

[GitHub] [spark] AmplabJenkins commented on issue #25646: [SPARK-27336][SQL] Incorrect DataSet.summary() result

2019-09-01 Thread GitBox
AmplabJenkins commented on issue #25646: [SPARK-27336][SQL] Incorrect DataSet.summary() result URL: https://github.com/apache/spark/pull/25646#issuecomment-526976084 Can one of the admins verify this patch? This is an automat

[GitHub] [spark] ulysses-you commented on a change in pull request #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries

2019-09-01 Thread GitBox
ulysses-you commented on a change in pull request #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries URL: https://github.com/apache/spark/pull/25464#discussion_r319788105 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameHintSuite.scala ##

[GitHub] [spark] SparkQA commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries

2019-09-01 Thread GitBox
SparkQA commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries URL: https://github.com/apache/spark/pull/25464#issuecomment-526976147 **[Test build #109998 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109998/testReport)** for

[GitHub] [spark] ulysses-you commented on a change in pull request #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries

2019-09-01 Thread GitBox
ulysses-you commented on a change in pull request #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries URL: https://github.com/apache/spark/pull/25464#discussion_r319788105 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameHintSuite.scala ##

[GitHub] [spark] AmplabJenkins commented on issue #25646: [SPARK-27336][SQL] Incorrect DataSet.summary() result

2019-09-01 Thread GitBox
AmplabJenkins commented on issue #25646: [SPARK-27336][SQL] Incorrect DataSet.summary() result URL: https://github.com/apache/spark/pull/25646#issuecomment-526976808 Can one of the admins verify this patch? This is an automat

[GitHub] [spark] ulysses-you commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries

2019-09-01 Thread GitBox
ulysses-you commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries URL: https://github.com/apache/spark/pull/25464#issuecomment-526976715 @maropu Do you have any time to review this again ? This i

[GitHub] [spark] AmplabJenkins commented on issue #25646: [SPARK-27336][SQL] Incorrect DataSet.summary() result

2019-09-01 Thread GitBox
AmplabJenkins commented on issue #25646: [SPARK-27336][SQL] Incorrect DataSet.summary() result URL: https://github.com/apache/spark/pull/25646#issuecomment-526976885 Can one of the admins verify this patch? This is an automat

[GitHub] [spark] AmplabJenkins removed a comment on issue #25646: [SPARK-27336][SQL] Incorrect DataSet.summary() result

2019-09-01 Thread GitBox
AmplabJenkins removed a comment on issue #25646: [SPARK-27336][SQL] Incorrect DataSet.summary() result URL: https://github.com/apache/spark/pull/25646#issuecomment-526976808 Can one of the admins verify this patch? This is an

[GitHub] [spark] AmplabJenkins removed a comment on issue #25646: [SPARK-27336][SQL] Incorrect DataSet.summary() result

2019-09-01 Thread GitBox
AmplabJenkins removed a comment on issue #25646: [SPARK-27336][SQL] Incorrect DataSet.summary() result URL: https://github.com/apache/spark/pull/25646#issuecomment-526976084 Can one of the admins verify this patch? This is an

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25646: [SPARK-27336][SQL] Incorrect DataSet.summary() result

2019-09-01 Thread GitBox
HyukjinKwon commented on a change in pull request #25646: [SPARK-27336][SQL] Incorrect DataSet.summary() result URL: https://github.com/apache/spark/pull/25646#discussion_r319789570 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Approx

[GitHub] [spark] beliefer commented on issue #25172: [SPARK-28412][SQL] ANSI SQL: OVERLAY function support byte array

2019-09-01 Thread GitBox
beliefer commented on issue #25172: [SPARK-28412][SQL] ANSI SQL: OVERLAY function support byte array URL: https://github.com/apache/spark/pull/25172#issuecomment-526978278 @maropu Others have not responded. Could you ping them again or advance this PR?

[GitHub] [spark] beliefer commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-09-01 Thread GitBox
beliefer commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-526978392 @dongjoon-hyun Could you continue to review this PR? Thanks! This is

[GitHub] [spark] beliefer edited a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax

2019-09-01 Thread GitBox
beliefer edited a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-526978392 @dongjoon-hyun Could you continue to review this PR? Thanks!

[GitHub] [spark] HyukjinKwon commented on issue #25634: [SPARK-28929][CORE] Spark Logging level should be INFO instead of DEBUG in Executor Plugin API

2019-09-01 Thread GitBox
HyukjinKwon commented on issue #25634: [SPARK-28929][CORE] Spark Logging level should be INFO instead of DEBUG in Executor Plugin API URL: https://github.com/apache/spark/pull/25634#issuecomment-526979136 Yes, please keep the items in the PR description ...

[GitHub] [spark] MrDLontheway commented on a change in pull request #25646: [SPARK-27336][SQL] Incorrect DataSet.summary() result

2019-09-01 Thread GitBox
MrDLontheway commented on a change in pull request #25646: [SPARK-27336][SQL] Incorrect DataSet.summary() result URL: https://github.com/apache/spark/pull/25646#discussion_r319790285 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Appro

[GitHub] [spark] HyukjinKwon edited a comment on issue #24405: [SPARK-27506][SQL] Allow deserialization of Avro data using compatible schemas

2019-09-01 Thread GitBox
HyukjinKwon edited a comment on issue #24405: [SPARK-27506][SQL] Allow deserialization of Avro data using compatible schemas URL: https://github.com/apache/spark/pull/24405#issuecomment-526981210 Yes, please. What I am worried is that, 1. I would like to be very sure if this is somet

[GitHub] [spark] HyukjinKwon commented on issue #24405: [SPARK-27506][SQL] Allow deserialization of Avro data using compatible schemas

2019-09-01 Thread GitBox
HyukjinKwon commented on issue #24405: [SPARK-27506][SQL] Allow deserialization of Avro data using compatible schemas URL: https://github.com/apache/spark/pull/24405#issuecomment-526981210 Yes, please. What I am worried is that, 1. I would like to be very sure if this is something wo

[GitHub] [spark] xianyinxin closed pull request #25627: [SPARK-28923][SQL] Deduplicate the codes 'multipartIdentifier' and 'identifierSeq'

2019-09-01 Thread GitBox
xianyinxin closed pull request #25627: [SPARK-28923][SQL] Deduplicate the codes 'multipartIdentifier' and 'identifierSeq' URL: https://github.com/apache/spark/pull/25627 This is an automated message from the Apache Git Servi

[GitHub] [spark] xianyinxin commented on a change in pull request #25627: [SPARK-28923][SQL] Deduplicate the codes 'multipartIdentifier' and 'identifierSeq'

2019-09-01 Thread GitBox
xianyinxin commented on a change in pull request #25627: [SPARK-28923][SQL] Deduplicate the codes 'multipartIdentifier' and 'identifierSeq' URL: https://github.com/apache/spark/pull/25627#discussion_r319793404 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst

[GitHub] [spark] viirya closed pull request #25639: [SPARK-28933][ML] Reduce unnecessary shuffle in ALS when initializing factors

2019-09-01 Thread GitBox
viirya closed pull request #25639: [SPARK-28933][ML] Reduce unnecessary shuffle in ALS when initializing factors URL: https://github.com/apache/spark/pull/25639 This is an automated message from the Apache Git Service. To re

[GitHub] [spark] viirya commented on issue #25639: [SPARK-28933][ML] Reduce unnecessary shuffle in ALS when initializing factors

2019-09-01 Thread GitBox
viirya commented on issue #25639: [SPARK-28933][ML] Reduce unnecessary shuffle in ALS when initializing factors URL: https://github.com/apache/spark/pull/25639#issuecomment-526984025 Merged. Thanks all for review! This is an

[GitHub] [spark] viirya edited a comment on issue #25639: [SPARK-28933][ML] Reduce unnecessary shuffle in ALS when initializing factors

2019-09-01 Thread GitBox
viirya edited a comment on issue #25639: [SPARK-28933][ML] Reduce unnecessary shuffle in ALS when initializing factors URL: https://github.com/apache/spark/pull/25639#issuecomment-526984025 Merged to master. Thanks all for review! ---

[GitHub] [spark] AmplabJenkins commented on issue #23952: [SPARK-26929][SQL]fix table owner use user instead of principal when create table through spark-sql or beeline

2019-09-01 Thread GitBox
AmplabJenkins commented on issue #23952: [SPARK-26929][SQL]fix table owner use user instead of principal when create table through spark-sql or beeline URL: https://github.com/apache/spark/pull/23952#issuecomment-526984653 Can one of the admins verify this patch? --

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25646: [SPARK-27336][SQL] Incorrect DataSet.summary() result

2019-09-01 Thread GitBox
HyukjinKwon commented on a change in pull request #25646: [SPARK-27336][SQL] Incorrect DataSet.summary() result URL: https://github.com/apache/spark/pull/25646#discussion_r319795349 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Approx

[GitHub] [spark] SparkQA commented on issue #25641: [SPARK-28921][BUILD][K8S][2.4] Update kubernetes client to 4.4.2

2019-09-01 Thread GitBox
SparkQA commented on issue #25641: [SPARK-28921][BUILD][K8S][2.4] Update kubernetes client to 4.4.2 URL: https://github.com/apache/spark/pull/25641#issuecomment-526988989 **[Test build #109997 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109997/testRepor

[GitHub] [spark] AmplabJenkins commented on issue #25641: [SPARK-28921][BUILD][K8S][2.4] Update kubernetes client to 4.4.2

2019-09-01 Thread GitBox
AmplabJenkins commented on issue #25641: [SPARK-28921][BUILD][K8S][2.4] Update kubernetes client to 4.4.2 URL: https://github.com/apache/spark/pull/25641#issuecomment-526989219 Merged build finished. Test PASSed. This is an a

[GitHub] [spark] SparkQA removed a comment on issue #25641: [SPARK-28921][BUILD][K8S][2.4] Update kubernetes client to 4.4.2

2019-09-01 Thread GitBox
SparkQA removed a comment on issue #25641: [SPARK-28921][BUILD][K8S][2.4] Update kubernetes client to 4.4.2 URL: https://github.com/apache/spark/pull/25641#issuecomment-526960046 **[Test build #109997 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109997/te

[GitHub] [spark] AmplabJenkins commented on issue #25641: [SPARK-28921][BUILD][K8S][2.4] Update kubernetes client to 4.4.2

2019-09-01 Thread GitBox
AmplabJenkins commented on issue #25641: [SPARK-28921][BUILD][K8S][2.4] Update kubernetes client to 4.4.2 URL: https://github.com/apache/spark/pull/25641#issuecomment-526989223 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.be

[GitHub] [spark] AmplabJenkins removed a comment on issue #25641: [SPARK-28921][BUILD][K8S][2.4] Update kubernetes client to 4.4.2

2019-09-01 Thread GitBox
AmplabJenkins removed a comment on issue #25641: [SPARK-28921][BUILD][K8S][2.4] Update kubernetes client to 4.4.2 URL: https://github.com/apache/spark/pull/25641#issuecomment-526989223 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://ampl

[GitHub] [spark] AmplabJenkins removed a comment on issue #25641: [SPARK-28921][BUILD][K8S][2.4] Update kubernetes client to 4.4.2

2019-09-01 Thread GitBox
AmplabJenkins removed a comment on issue #25641: [SPARK-28921][BUILD][K8S][2.4] Update kubernetes client to 4.4.2 URL: https://github.com/apache/spark/pull/25641#issuecomment-526989219 Merged build finished. Test PASSed. This

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-09-01 Thread GitBox
HyukjinKwon commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#discussion_r319798616 ## File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ## @@ -3942,6 +3943,69 @@

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-09-01 Thread GitBox
HyukjinKwon commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#discussion_r319798708 ## File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ## @@ -3942,6 +3943,69 @@

[GitHub] [spark] brkyvz commented on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-09-01 Thread GitBox
brkyvz commented on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#issuecomment-526991370 Uh oh, can you please revert? On Sun, Sep 1, 2019, 8:44 PM Hyukjin Kwon wrote: > *@HyukjinKwon* commented on this pull request.

[GitHub] [spark] HyukjinKwon commented on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-09-01 Thread GitBox
HyukjinKwon commented on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#issuecomment-526991360 Let me revert this due to the build failure for now (had a quick chat with @brkyvz as well) --

[GitHub] [spark] HyukjinKwon commented on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-09-01 Thread GitBox
HyukjinKwon commented on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#issuecomment-526991449 Sure, thanks @brkyvz for confirmation officially! This is an automated

[GitHub] [spark] LuciferYang commented on a change in pull request #25309: [SPARK-28577][YARN]Resource capability requested for each executor add offHeapMemorySize

2019-09-01 Thread GitBox
LuciferYang commented on a change in pull request #25309: [SPARK-28577][YARN]Resource capability requested for each executor add offHeapMemorySize URL: https://github.com/apache/spark/pull/25309#discussion_r319799420 ## File path: resource-managers/yarn/src/main/scala/org/apache/

[GitHub] [spark] HyukjinKwon removed a comment on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-09-01 Thread GitBox
HyukjinKwon removed a comment on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#issuecomment-526991449 Sure, thanks @brkyvz for confirmation officially! This is an a

[GitHub] [spark] HyukjinKwon edited a comment on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-09-01 Thread GitBox
HyukjinKwon edited a comment on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#issuecomment-526991360 Let me revert this due to the build failure for now This is an

[GitHub] [spark] HyukjinKwon commented on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-09-01 Thread GitBox
HyukjinKwon commented on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#issuecomment-526991903 Sure, thanks @brkyvz for confirmation quickly! This is an automated me

[GitHub] [spark] HyukjinKwon removed a comment on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-09-01 Thread GitBox
HyukjinKwon removed a comment on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#issuecomment-526991360 Let me revert this due to the build failure for now This is an

[GitHub] [spark] LuciferYang commented on a change in pull request #25309: [SPARK-28577][YARN]Resource capability requested for each executor add offHeapMemorySize

2019-09-01 Thread GitBox
LuciferYang commented on a change in pull request #25309: [SPARK-28577][YARN]Resource capability requested for each executor add offHeapMemorySize URL: https://github.com/apache/spark/pull/25309#discussion_r319799420 ## File path: resource-managers/yarn/src/main/scala/org/apache/

[GitHub] [spark] LuciferYang commented on a change in pull request #25309: [SPARK-28577][YARN]Resource capability requested for each executor add offHeapMemorySize

2019-09-01 Thread GitBox
LuciferYang commented on a change in pull request #25309: [SPARK-28577][YARN]Resource capability requested for each executor add offHeapMemorySize URL: https://github.com/apache/spark/pull/25309#discussion_r319799420 ## File path: resource-managers/yarn/src/main/scala/org/apache/

[GitHub] [spark] HyukjinKwon commented on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-09-01 Thread GitBox
HyukjinKwon commented on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#issuecomment-526993643 Also, locally verified that the Maven build now works fine after reverting this one. -

[GitHub] [spark] HyukjinKwon opened a new pull request #25647: [SPARK-28946][R][DOCS] Add some more information about building SparkR on Windows

2019-09-01 Thread GitBox
HyukjinKwon opened a new pull request #25647: [SPARK-28946][R][DOCS] Add some more information about building SparkR on Windows URL: https://github.com/apache/spark/pull/25647 ### What changes were proposed in this pull request? This PR adds three more information: - Mentions

[GitHub] [spark] AmplabJenkins commented on issue #25647: [SPARK-28946][R][DOCS] Add some more information about building SparkR on Windows

2019-09-01 Thread GitBox
AmplabJenkins commented on issue #25647: [SPARK-28946][R][DOCS] Add some more information about building SparkR on Windows URL: https://github.com/apache/spark/pull/25647#issuecomment-526996684 Test PASSed. Refer to this link for build results (access rights to CI server needed): ht

[GitHub] [spark] AmplabJenkins commented on issue #25647: [SPARK-28946][R][DOCS] Add some more information about building SparkR on Windows

2019-09-01 Thread GitBox
AmplabJenkins commented on issue #25647: [SPARK-28946][R][DOCS] Add some more information about building SparkR on Windows URL: https://github.com/apache/spark/pull/25647#issuecomment-526996680 Merged build finished. Test PASSed.

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25647: [SPARK-28946][R][DOCS] Add some more information about building SparkR on Windows

2019-09-01 Thread GitBox
HyukjinKwon commented on a change in pull request #25647: [SPARK-28946][R][DOCS] Add some more information about building SparkR on Windows URL: https://github.com/apache/spark/pull/25647#discussion_r319803205 ## File path: R/WINDOWS.md ## @@ -20,25 +20,28 @@ license: |

[GitHub] [spark] SparkQA commented on issue #25647: [SPARK-28946][R][DOCS] Add some more information about building SparkR on Windows

2019-09-01 Thread GitBox
SparkQA commented on issue #25647: [SPARK-28946][R][DOCS] Add some more information about building SparkR on Windows URL: https://github.com/apache/spark/pull/25647#issuecomment-526996991 **[Test build #10 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/

[GitHub] [spark] AmplabJenkins removed a comment on issue #25647: [SPARK-28946][R][DOCS] Add some more information about building SparkR on Windows

2019-09-01 Thread GitBox
AmplabJenkins removed a comment on issue #25647: [SPARK-28946][R][DOCS] Add some more information about building SparkR on Windows URL: https://github.com/apache/spark/pull/25647#issuecomment-526996680 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25647: [SPARK-28946][R][DOCS] Add some more information about building SparkR on Windows

2019-09-01 Thread GitBox
AmplabJenkins removed a comment on issue #25647: [SPARK-28946][R][DOCS] Add some more information about building SparkR on Windows URL: https://github.com/apache/spark/pull/25647#issuecomment-526996684 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25647: [SPARK-28946][R][DOCS] Add some more information about building SparkR on Windows

2019-09-01 Thread GitBox
HyukjinKwon commented on a change in pull request #25647: [SPARK-28946][R][DOCS] Add some more information about building SparkR on Windows URL: https://github.com/apache/spark/pull/25647#discussion_r319803409 ## File path: R/WINDOWS.md ## @@ -20,25 +20,28 @@ license: |

[GitHub] [spark] AmplabJenkins commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries

2019-09-01 Thread GitBox
AmplabJenkins commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries URL: https://github.com/apache/spark/pull/25464#issuecomment-526998396 Merged build finished. Test FAILed. This is an automated

[GitHub] [spark] SparkQA removed a comment on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries

2019-09-01 Thread GitBox
SparkQA removed a comment on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries URL: https://github.com/apache/spark/pull/25464#issuecomment-526976147 **[Test build #109998 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109998/testReport

[GitHub] [spark] AmplabJenkins commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries

2019-09-01 Thread GitBox
AmplabJenkins commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries URL: https://github.com/apache/spark/pull/25464#issuecomment-526998398 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.e

[GitHub] [spark] SparkQA commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries

2019-09-01 Thread GitBox
SparkQA commented on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries URL: https://github.com/apache/spark/pull/25464#issuecomment-526998310 **[Test build #109998 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109998/testReport)** fo

[GitHub] [spark] AmplabJenkins removed a comment on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries

2019-09-01 Thread GitBox
AmplabJenkins removed a comment on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries URL: https://github.com/apache/spark/pull/25464#issuecomment-526998396 Merged build finished. Test FAILed. This is an a

[GitHub] [spark] AmplabJenkins removed a comment on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries

2019-09-01 Thread GitBox
AmplabJenkins removed a comment on issue #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries URL: https://github.com/apache/spark/pull/25464#issuecomment-526998398 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.be

[GitHub] [spark] HyukjinKwon commented on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-09-01 Thread GitBox
HyukjinKwon commented on issue #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#issuecomment-526999630 @rdblue sorry I had to revert this. Can you open a PR again with some fixes? --

[GitHub] [spark] SparkQA commented on issue #25647: [SPARK-28946][R][DOCS] Add some more information about building SparkR on Windows

2019-09-01 Thread GitBox
SparkQA commented on issue #25647: [SPARK-28946][R][DOCS] Add some more information about building SparkR on Windows URL: https://github.com/apache/spark/pull/25647#issuecomment-527001757 **[Test build #10 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder

[GitHub] [spark] AmplabJenkins commented on issue #25647: [SPARK-28946][R][DOCS] Add some more information about building SparkR on Windows

2019-09-01 Thread GitBox
AmplabJenkins commented on issue #25647: [SPARK-28946][R][DOCS] Add some more information about building SparkR on Windows URL: https://github.com/apache/spark/pull/25647#issuecomment-527001819 Test PASSed. Refer to this link for build results (access rights to CI server needed): htt

[GitHub] [spark] AmplabJenkins commented on issue #25647: [SPARK-28946][R][DOCS] Add some more information about building SparkR on Windows

2019-09-01 Thread GitBox
AmplabJenkins commented on issue #25647: [SPARK-28946][R][DOCS] Add some more information about building SparkR on Windows URL: https://github.com/apache/spark/pull/25647#issuecomment-527001817 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25647: [SPARK-28946][R][DOCS] Add some more information about building SparkR on Windows

2019-09-01 Thread GitBox
AmplabJenkins removed a comment on issue #25647: [SPARK-28946][R][DOCS] Add some more information about building SparkR on Windows URL: https://github.com/apache/spark/pull/25647#issuecomment-527001819 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on issue #25647: [SPARK-28946][R][DOCS] Add some more information about building SparkR on Windows

2019-09-01 Thread GitBox
SparkQA removed a comment on issue #25647: [SPARK-28946][R][DOCS] Add some more information about building SparkR on Windows URL: https://github.com/apache/spark/pull/25647#issuecomment-526996991 **[Test build #10 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequest

[GitHub] [spark] AmplabJenkins removed a comment on issue #25647: [SPARK-28946][R][DOCS] Add some more information about building SparkR on Windows

2019-09-01 Thread GitBox
AmplabJenkins removed a comment on issue #25647: [SPARK-28946][R][DOCS] Add some more information about building SparkR on Windows URL: https://github.com/apache/spark/pull/25647#issuecomment-527001817 Merged build finished. Test PASSed.

[GitHub] [spark] cloud-fan commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-09-01 Thread GitBox
cloud-fan commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#discussion_r319807957 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriterV2.scala ## @@ -0,0 +1,415 @

[GitHub] [spark] cloud-fan commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-09-01 Thread GitBox
cloud-fan commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#discussion_r319809059 ## File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ## @@ -3942,6 +3943,69 @@ o

[GitHub] [spark] cloud-fan commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-09-01 Thread GitBox
cloud-fan commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#discussion_r319809655 ## File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ## @@ -3942,6 +3943,69 @@ o

[GitHub] [spark] cloud-fan commented on a change in pull request #25363: [SPARK-28628][SQL] Implement SupportsNamespaces in V2SessionCatalog

2019-09-01 Thread GitBox
cloud-fan commented on a change in pull request #25363: [SPARK-28628][SQL] Implement SupportsNamespaces in V2SessionCatalog URL: https://github.com/apache/spark/pull/25363#discussion_r319810445 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2Se

[GitHub] [spark] MrDLontheway commented on a change in pull request #25646: [SPARK-27336][SQL] Incorrect DataSet.summary() result

2019-09-01 Thread GitBox
MrDLontheway commented on a change in pull request #25646: [SPARK-27336][SQL] Incorrect DataSet.summary() result URL: https://github.com/apache/spark/pull/25646#discussion_r319811793 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Appro

[GitHub] [spark] cloud-fan commented on a change in pull request #25363: [SPARK-28628][SQL] Implement SupportsNamespaces in V2SessionCatalog

2019-09-01 Thread GitBox
cloud-fan commented on a change in pull request #25363: [SPARK-28628][SQL] Implement SupportsNamespaces in V2SessionCatalog URL: https://github.com/apache/spark/pull/25363#discussion_r319812223 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/V2Se

[GitHub] [spark] cloud-fan commented on issue #25280: [SPARK-28548][SQL] explain() shows wrong result for persisted DataFrames after some operations

2019-09-01 Thread GitBox
cloud-fan commented on issue #25280: [SPARK-28548][SQL] explain() shows wrong result for persisted DataFrames after some operations URL: https://github.com/apache/spark/pull/25280#issuecomment-527012092 This is not a correctness issue. This is just an undocumented property "a dataframe can

[GitHub] [spark] cloud-fan commented on a change in pull request #25306: [SPARK-28573][SQL] Convert InsertIntoTable(HiveTableRelation) to DataSource inserting for partitioned table

2019-09-01 Thread GitBox
cloud-fan commented on a change in pull request #25306: [SPARK-28573][SQL] Convert InsertIntoTable(HiveTableRelation) to DataSource inserting for partitioned table URL: https://github.com/apache/spark/pull/25306#discussion_r319814740 ## File path: sql/hive/src/test/scala/org/apach

[GitHub] [spark] cloud-fan commented on a change in pull request #25306: [SPARK-28573][SQL] Convert InsertIntoTable(HiveTableRelation) to DataSource inserting for partitioned table

2019-09-01 Thread GitBox
cloud-fan commented on a change in pull request #25306: [SPARK-28573][SQL] Convert InsertIntoTable(HiveTableRelation) to DataSource inserting for partitioned table URL: https://github.com/apache/spark/pull/25306#discussion_r319814793 ## File path: sql/hive/src/test/scala/org/apach

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #25611: [SPARK-28901][SQL] SparkThriftServer's Cancel SQL Operation show it in JDBC Tab UI

2019-09-01 Thread GitBox
AngersZh commented on a change in pull request #25611: [SPARK-28901][SQL] SparkThriftServer's Cancel SQL Operation show it in JDBC Tab UI URL: https://github.com/apache/spark/pull/25611#discussion_r319814859 ## File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sq

[GitHub] [spark] cloud-fan commented on a change in pull request #25601: [SPARK-28856][SQL] Implement SHOW DATABASES for Data Source V2 Tables

2019-09-01 Thread GitBox
cloud-fan commented on a change in pull request #25601: [SPARK-28856][SQL] Implement SHOW DATABASES for Data Source V2 Tables URL: https://github.com/apache/spark/pull/25601#discussion_r319815174 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/Sh

[GitHub] [spark] cloud-fan commented on a change in pull request #25601: [SPARK-28856][SQL] Implement SHOW DATABASES for Data Source V2 Tables

2019-09-01 Thread GitBox
cloud-fan commented on a change in pull request #25601: [SPARK-28856][SQL] Implement SHOW DATABASES for Data Source V2 Tables URL: https://github.com/apache/spark/pull/25601#discussion_r319815174 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/Sh

[GitHub] [spark] cloud-fan commented on a change in pull request #25593: [SPARK-27992][SPARK-28881][PYTHON][2.4] Allow Python to join with connection thread to propagate errors

2019-09-01 Thread GitBox
cloud-fan commented on a change in pull request #25593: [SPARK-27992][SPARK-28881][PYTHON][2.4] Allow Python to join with connection thread to propagate errors URL: https://github.com/apache/spark/pull/25593#discussion_r319815834 ## File path: core/src/main/scala/org/apache/spark/a

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25593: [SPARK-27992][SPARK-28881][PYTHON][2.4] Allow Python to join with connection thread to propagate errors

2019-09-01 Thread GitBox
HyukjinKwon commented on a change in pull request #25593: [SPARK-27992][SPARK-28881][PYTHON][2.4] Allow Python to join with connection thread to propagate errors URL: https://github.com/apache/spark/pull/25593#discussion_r319816820 ## File path: core/src/main/scala/org/apache/spark

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25646: [SPARK-27336][SQL] Incorrect DataSet.summary() result

2019-09-01 Thread GitBox
HyukjinKwon commented on a change in pull request #25646: [SPARK-27336][SQL] Incorrect DataSet.summary() result URL: https://github.com/apache/spark/pull/25646#discussion_r319817318 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Approx

[GitHub] [spark] HyukjinKwon commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-09-01 Thread GitBox
HyukjinKwon commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#discussion_r319818093 ## File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ## @@ -3942,6 +3943,69 @@

[GitHub] [spark] MrDLontheway commented on a change in pull request #25646: [SPARK-27336][SQL] Incorrect DataSet.summary() result

2019-09-01 Thread GitBox
MrDLontheway commented on a change in pull request #25646: [SPARK-27336][SQL] Incorrect DataSet.summary() result URL: https://github.com/apache/spark/pull/25646#discussion_r319817970 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Appro

[GitHub] [spark] HyukjinKwon closed pull request #25646: [SPARK-27336][SQL] Incorrect DataSet.summary() result

2019-09-01 Thread GitBox
HyukjinKwon closed pull request #25646: [SPARK-27336][SQL] Incorrect DataSet.summary() result URL: https://github.com/apache/spark/pull/25646 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [spark] SparkQA commented on issue #25104: [SPARK-28341][SQL] create a public API for V2SessionCatalog

2019-09-01 Thread GitBox
SparkQA commented on issue #25104: [SPARK-28341][SQL] create a public API for V2SessionCatalog URL: https://github.com/apache/spark/pull/25104#issuecomment-527019206 **[Test build #11 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/11/testReport)**

[GitHub] [spark] cloud-fan commented on a change in pull request #25643: [SPARK-28939][SQL] Propagate SQLConf for plans executed by toRdd

2019-09-01 Thread GitBox
cloud-fan commented on a change in pull request #25643: [SPARK-28939][SQL] Propagate SQLConf for plans executed by toRdd URL: https://github.com/apache/spark/pull/25643#discussion_r319820681 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLExecutionRDD.sca

[GitHub] [spark] AmplabJenkins commented on issue #20505: [SPARK-23251][SQL] Add checks for collection element Encoders

2019-09-01 Thread GitBox
AmplabJenkins commented on issue #20505: [SPARK-23251][SQL] Add checks for collection element Encoders URL: https://github.com/apache/spark/pull/20505#issuecomment-527020333 Can one of the admins verify this patch? This is an

[GitHub] [spark] cloud-fan commented on a change in pull request #25643: [SPARK-28939][SQL] Propagate SQLConf for plans executed by toRdd

2019-09-01 Thread GitBox
cloud-fan commented on a change in pull request #25643: [SPARK-28939][SQL] Propagate SQLConf for plans executed by toRdd URL: https://github.com/apache/spark/pull/25643#discussion_r319821032 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLExecutionRDD.sca

<    1   2   3   >