[GitHub] [spark] dongjoon-hyun closed pull request #27077: [SPARK-30408][SQL] Should not remove orderBy in sortBy clause in Optimizer

2020-01-12 Thread GitBox
dongjoon-hyun closed pull request #27077: [SPARK-30408][SQL] Should not remove orderBy in sortBy clause in Optimizer URL: https://github.com/apache/spark/pull/27077 This is an automated message from the Apache Git Service. T

[GitHub] [spark] SparkQA commented on issue #27146: [SPARK-21869][SS][DOCS][FOLLOWUP] Document Kafka producer pool configuration

2020-01-12 Thread GitBox
SparkQA commented on issue #27146: [SPARK-21869][SS][DOCS][FOLLOWUP] Document Kafka producer pool configuration URL: https://github.com/apache/spark/pull/27146#issuecomment-573487753 **[Test build #116584 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/11658

[GitHub] [spark] HyukjinKwon commented on a change in pull request #27169: [SPARK-30485][SQL] Remove SQL configs deprecated in Spark 2.1 and 2.3

2020-01-12 Thread GitBox
HyukjinKwon commented on a change in pull request #27169: [SPARK-30485][SQL] Remove SQL configs deprecated in Spark 2.1 and 2.3 URL: https://github.com/apache/spark/pull/27169#discussion_r365631834 ## File path: python/pyspark/sql/tests/test_pandas_udf_scalar.py ## @@ -724

[GitHub] [spark] HyukjinKwon commented on a change in pull request #27169: [SPARK-30485][SQL] Remove SQL configs deprecated in Spark 2.1 and 2.3

2020-01-12 Thread GitBox
HyukjinKwon commented on a change in pull request #27169: [SPARK-30485][SQL] Remove SQL configs deprecated in Spark 2.1 and 2.3 URL: https://github.com/apache/spark/pull/27169#discussion_r365631790 ## File path: python/pyspark/sql/tests/test_arrow.py ## @@ -231,34 +205,6 @

[GitHub] [spark] HyukjinKwon commented on a change in pull request #27169: [SPARK-30485][SQL] Remove SQL configs deprecated in Spark 2.1 and 2.3

2020-01-12 Thread GitBox
HyukjinKwon commented on a change in pull request #27169: [SPARK-30485][SQL] Remove SQL configs deprecated in Spark 2.1 and 2.3 URL: https://github.com/apache/spark/pull/27169#discussion_r365631767 ## File path: python/pyspark/sql/tests/test_arrow.py ## @@ -160,32 +160,6 @

[GitHub] [spark] HyukjinKwon commented on a change in pull request #27169: [SPARK-30485][SQL] Remove SQL configs deprecated in Spark 2.1 and 2.3

2020-01-12 Thread GitBox
HyukjinKwon commented on a change in pull request #27169: [SPARK-30485][SQL] Remove SQL configs deprecated in Spark 2.1 and 2.3 URL: https://github.com/apache/spark/pull/27169#discussion_r365631743 ## File path: python/pyspark/sql/tests/test_arrow.py ## @@ -160,32 +160,6 @

[GitHub] [spark] AmplabJenkins removed a comment on issue #27146: [SPARK-21869][SS][DOCS][FOLLOWUP] Document Kafka producer pool configuration

2020-01-12 Thread GitBox
AmplabJenkins removed a comment on issue #27146: [SPARK-21869][SS][DOCS][FOLLOWUP] Document Kafka producer pool configuration URL: https://github.com/apache/spark/pull/27146#issuecomment-573486929 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #27146: [SPARK-21869][SS][DOCS][FOLLOWUP] Document Kafka producer pool configuration

2020-01-12 Thread GitBox
AmplabJenkins removed a comment on issue #27146: [SPARK-21869][SS][DOCS][FOLLOWUP] Document Kafka producer pool configuration URL: https://github.com/apache/spark/pull/27146#issuecomment-573486927 Merged build finished. Test PASSed. -

[GitHub] [spark] AmplabJenkins removed a comment on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods

2020-01-12 Thread GitBox
AmplabJenkins removed a comment on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods URL: https://github.com/apache/spark/pull/27181#issuecomment-573486882 Test PASSed. Refer to this link for build results (access rights to

[GitHub] [spark] AmplabJenkins removed a comment on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods

2020-01-12 Thread GitBox
AmplabJenkins removed a comment on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods URL: https://github.com/apache/spark/pull/27181#issuecomment-573486880 Merged build finished. Test PASSed. --

[GitHub] [spark] SparkQA removed a comment on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods

2020-01-12 Thread GitBox
SparkQA removed a comment on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods URL: https://github.com/apache/spark/pull/27181#issuecomment-573484233 **[Test build #116581 has started](https://amplab.cs.berkeley.edu/jenkins/jo

[GitHub] [spark] AmplabJenkins commented on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods

2020-01-12 Thread GitBox
AmplabJenkins commented on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods URL: https://github.com/apache/spark/pull/27181#issuecomment-573486882 Test PASSed. Refer to this link for build results (access rights to CI serve

[GitHub] [spark] HeartSaVioR commented on a change in pull request #27146: [SPARK-21869][SS][DOCS][FOLLOWUP] Document Kafka producer pool configuration

2020-01-12 Thread GitBox
HeartSaVioR commented on a change in pull request #27146: [SPARK-21869][SS][DOCS][FOLLOWUP] Document Kafka producer pool configuration URL: https://github.com/apache/spark/pull/27146#discussion_r365631595 ## File path: docs/structured-streaming-kafka-integration.md ## @@ -

[GitHub] [spark] AmplabJenkins commented on issue #27146: [SPARK-21869][SS][DOCS][FOLLOWUP] Document Kafka producer pool configuration

2020-01-12 Thread GitBox
AmplabJenkins commented on issue #27146: [SPARK-21869][SS][DOCS][FOLLOWUP] Document Kafka producer pool configuration URL: https://github.com/apache/spark/pull/27146#issuecomment-573486929 Test PASSed. Refer to this link for build results (access rights to CI server needed): https:/

[GitHub] [spark] AmplabJenkins commented on issue #27146: [SPARK-21869][SS][DOCS][FOLLOWUP] Document Kafka producer pool configuration

2020-01-12 Thread GitBox
AmplabJenkins commented on issue #27146: [SPARK-21869][SS][DOCS][FOLLOWUP] Document Kafka producer pool configuration URL: https://github.com/apache/spark/pull/27146#issuecomment-573486927 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods

2020-01-12 Thread GitBox
AmplabJenkins commented on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods URL: https://github.com/apache/spark/pull/27181#issuecomment-573486880 Merged build finished. Test PASSed. --

[GitHub] [spark] SparkQA commented on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods

2020-01-12 Thread GitBox
SparkQA commented on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods URL: https://github.com/apache/spark/pull/27181#issuecomment-573486760 **[Test build #116581 has finished](https://amplab.cs.berkeley.edu/jenkins/job/Spark

[GitHub] [spark] dongjoon-hyun edited a comment on issue #27077: [SPARK-30408][SQL] Should not remove orderBy in sortBy clause in Optimizer

2020-01-12 Thread GitBox
dongjoon-hyun edited a comment on issue #27077: [SPARK-30408][SQL] Should not remove orderBy in sortBy clause in Optimizer URL: https://github.com/apache/spark/pull/27077#issuecomment-573485861 Of course, it does. And, Apache Spark doesn't change the original semantic of `Seq(...).toDF.ord

[GitHub] [spark] dongjoon-hyun edited a comment on issue #27077: [SPARK-30408][SQL] Should not remove orderBy in sortBy clause in Optimizer

2020-01-12 Thread GitBox
dongjoon-hyun edited a comment on issue #27077: [SPARK-30408][SQL] Should not remove orderBy in sortBy clause in Optimizer URL: https://github.com/apache/spark/pull/27077#issuecomment-573485861 Of course, it does. And, Apache Spark doesn't change the original semantic of `Seq(...).toDF.ord

[GitHub] [spark] dongjoon-hyun commented on issue #27077: [SPARK-30408][SQL] Should not remove orderBy in sortBy clause in Optimizer

2020-01-12 Thread GitBox
dongjoon-hyun commented on issue #27077: [SPARK-30408][SQL] Should not remove orderBy in sortBy clause in Optimizer URL: https://github.com/apache/spark/pull/27077#issuecomment-573485861 Of course, it does. And, Apache Spark doesn't change the original semantic of `Seq(...).toDF.orderBy("b

[GitHub] [spark] AmplabJenkins removed a comment on issue #26440: [SPARK-20628][CORE][K8S] Start to improve Spark decommissioning & preemption support

2020-01-12 Thread GitBox
AmplabJenkins removed a comment on issue #26440: [SPARK-20628][CORE][K8S] Start to improve Spark decommissioning & preemption support URL: https://github.com/apache/spark/pull/26440#issuecomment-573485536 Test FAILed. Refer to this link for build results (access rights to CI server neede

[GitHub] [spark] AmplabJenkins removed a comment on issue #26440: [SPARK-20628][CORE][K8S] Start to improve Spark decommissioning & preemption support

2020-01-12 Thread GitBox
AmplabJenkins removed a comment on issue #26440: [SPARK-20628][CORE][K8S] Start to improve Spark decommissioning & preemption support URL: https://github.com/apache/spark/pull/26440#issuecomment-573485534 Merged build finished. Test FAILed. -

[GitHub] [spark] AmplabJenkins commented on issue #26440: [SPARK-20628][CORE][K8S] Start to improve Spark decommissioning & preemption support

2020-01-12 Thread GitBox
AmplabJenkins commented on issue #26440: [SPARK-20628][CORE][K8S] Start to improve Spark decommissioning & preemption support URL: https://github.com/apache/spark/pull/26440#issuecomment-573485536 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #26440: [SPARK-20628][CORE][K8S] Start to improve Spark decommissioning & preemption support

2020-01-12 Thread GitBox
AmplabJenkins commented on issue #26440: [SPARK-20628][CORE][K8S] Start to improve Spark decommissioning & preemption support URL: https://github.com/apache/spark/pull/26440#issuecomment-573485534 Merged build finished. Test FAILed. -

[GitHub] [spark] SparkQA commented on issue #26440: [SPARK-20628][CORE][K8S] Start to improve Spark decommissioning & preemption support

2020-01-12 Thread GitBox
SparkQA commented on issue #26440: [SPARK-20628][CORE][K8S] Start to improve Spark decommissioning & preemption support URL: https://github.com/apache/spark/pull/26440#issuecomment-573485390 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/Spark

[GitHub] [spark] AmplabJenkins removed a comment on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui

2020-01-12 Thread GitBox
AmplabJenkins removed a comment on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui URL: https://github.com/apache/spark/pull/26201#issuecomment-573485219 Merged build finished. Test PASSed. This is an automat

[GitHub] [spark] AmplabJenkins commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui

2020-01-12 Thread GitBox
AmplabJenkins commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui URL: https://github.com/apache/spark/pull/26201#issuecomment-573485223 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/je

[GitHub] [spark] AmplabJenkins removed a comment on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui

2020-01-12 Thread GitBox
AmplabJenkins removed a comment on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui URL: https://github.com/apache/spark/pull/26201#issuecomment-573485223 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkele

[GitHub] [spark] huaxingao commented on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods

2020-01-12 Thread GitBox
huaxingao commented on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods URL: https://github.com/apache/spark/pull/27181#issuecomment-573485221 Yes, I think ```weightCol``` should be set as well for ```OneVsRestModel._from_jav

[GitHub] [spark] AmplabJenkins commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui

2020-01-12 Thread GitBox
AmplabJenkins commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui URL: https://github.com/apache/spark/pull/26201#issuecomment-573485219 Merged build finished. Test PASSed. This is an automated messa

[GitHub] [spark] SparkQA commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui

2020-01-12 Thread GitBox
SparkQA commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui URL: https://github.com/apache/spark/pull/26201#issuecomment-573485065 **[Test build #116583 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/116583/testReport)** for PR 26

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27030: [SPARK-30244][SQL] Emit pre/post events for "Partition" methods in ExternalCatalogWithListener

2020-01-12 Thread GitBox
dongjoon-hyun commented on a change in pull request #27030: [SPARK-30244][SQL] Emit pre/post events for "Partition" methods in ExternalCatalogWithListener URL: https://github.com/apache/spark/pull/27030#discussion_r365630139 ## File path: sql/catalyst/src/test/scala/org/apache/spar

[GitHub] [spark] uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui

2020-01-12 Thread GitBox
uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui URL: https://github.com/apache/spark/pull/26201#issuecomment-573484866 retest this please. This is an automated message from the Apache Gi

[GitHub] [spark] HyukjinKwon commented on a change in pull request #27174: [SPARK-30490][SQL] Eliminate compiler warnings in Avro datasource

2020-01-12 Thread GitBox
HyukjinKwon commented on a change in pull request #27174: [SPARK-30490][SQL] Eliminate compiler warnings in Avro datasource URL: https://github.com/apache/spark/pull/27174#discussion_r365629991 ## File path: external/avro/src/main/scala/org/apache/spark/sql/avro/AvroUtils.scala ##

[GitHub] [spark] HyukjinKwon commented on a change in pull request #27174: [SPARK-30490][SQL] Eliminate compiler warnings in Avro datasource

2020-01-12 Thread GitBox
HyukjinKwon commented on a change in pull request #27174: [SPARK-30490][SQL] Eliminate compiler warnings in Avro datasource URL: https://github.com/apache/spark/pull/27174#discussion_r365629991 ## File path: external/avro/src/main/scala/org/apache/spark/sql/avro/AvroUtils.scala ##

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27030: [SPARK-30244][SQL] Emit pre/post events for "Partition" methods in ExternalCatalogWithListener

2020-01-12 Thread GitBox
dongjoon-hyun commented on a change in pull request #27030: [SPARK-30244][SQL] Emit pre/post events for "Partition" methods in ExternalCatalogWithListener URL: https://github.com/apache/spark/pull/27030#discussion_r365629981 ## File path: sql/catalyst/src/test/scala/org/apache/spar

[GitHub] [spark] apapi commented on issue #27077: [SPARK-30408][SQL] Should not remove orderBy in sortBy clause in Optimizer

2020-01-12 Thread GitBox
apapi commented on issue #27077: [SPARK-30408][SQL] Should not remove orderBy in sortBy clause in Optimizer URL: https://github.com/apache/spark/pull/27077#issuecomment-573484592 @dongjoon-hyun I can close this PR but I still think this is a defect because it is about optimizer not functio

[GitHub] [spark] kevinyu98 commented on issue #27130: [SPARK-25993][SQL][TESTS] Add test cases for CREATE EXTERNAL TABLE with subdirectories

2020-01-12 Thread GitBox
kevinyu98 commented on issue #27130: [SPARK-25993][SQL][TESTS] Add test cases for CREATE EXTERNAL TABLE with subdirectories URL: https://github.com/apache/spark/pull/27130#issuecomment-573484517 @dongjoon-hyun can we re-test it? I ran `HiveParquetSourceSuite` and `HiveOrcSourceSuite` local

[GitHub] [spark] prog012 commented on issue #27077: [SPARK-30408][SQL] Should not remove orderBy in sortBy clause in Optimizer

2020-01-12 Thread GitBox
prog012 commented on issue #27077: [SPARK-30408][SQL] Should not remove orderBy in sortBy clause in Optimizer URL: https://github.com/apache/spark/pull/27077#issuecomment-573484402 @dongjoon-hyun I can close this PR but I still think this is a defect because it is about optimizer not funct

[GitHub] [spark] AmplabJenkins commented on issue #26875: [SPARK-30245][SQL] Add cache for Like and RLike when pattern is not static

2020-01-12 Thread GitBox
AmplabJenkins commented on issue #26875: [SPARK-30245][SQL] Add cache for Like and RLike when pattern is not static URL: https://github.com/apache/spark/pull/26875#issuecomment-573484386 Merged build finished. Test PASSed. Th

[GitHub] [spark] AmplabJenkins removed a comment on issue #26875: [SPARK-30245][SQL] Add cache for Like and RLike when pattern is not static

2020-01-12 Thread GitBox
AmplabJenkins removed a comment on issue #26875: [SPARK-30245][SQL] Add cache for Like and RLike when pattern is not static URL: https://github.com/apache/spark/pull/26875#issuecomment-573484389 Test PASSed. Refer to this link for build results (access rights to CI server needed): h

[GitHub] [spark] prog012 removed a comment on issue #27077: [SPARK-30408][SQL] Should not remove orderBy in sortBy clause in Optimizer

2020-01-12 Thread GitBox
prog012 removed a comment on issue #27077: [SPARK-30408][SQL] Should not remove orderBy in sortBy clause in Optimizer URL: https://github.com/apache/spark/pull/27077#issuecomment-573484402 @dongjoon-hyun I can close this PR but I still think this is a defect because it is about optimizer n

[GitHub] [spark] AmplabJenkins commented on issue #26875: [SPARK-30245][SQL] Add cache for Like and RLike when pattern is not static

2020-01-12 Thread GitBox
AmplabJenkins commented on issue #26875: [SPARK-30245][SQL] Add cache for Like and RLike when pattern is not static URL: https://github.com/apache/spark/pull/26875#issuecomment-573484389 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://a

[GitHub] [spark] AmplabJenkins removed a comment on issue #26875: [SPARK-30245][SQL] Add cache for Like and RLike when pattern is not static

2020-01-12 Thread GitBox
AmplabJenkins removed a comment on issue #26875: [SPARK-30245][SQL] Add cache for Like and RLike when pattern is not static URL: https://github.com/apache/spark/pull/26875#issuecomment-573484386 Merged build finished. Test PASSed. ---

[GitHub] [spark] HyukjinKwon commented on issue #27158: [MINOR][BUILD][PYSPARK] Disable test_memory_limit test temporarily

2020-01-12 Thread GitBox
HyukjinKwon commented on issue #27158: [MINOR][BUILD][PYSPARK] Disable test_memory_limit test temporarily URL: https://github.com/apache/spark/pull/27158#issuecomment-573484250 Let me take a look today and see if it's able to fix. Otherwise yes, we might have to disable the test.

[GitHub] [spark] SparkQA commented on issue #26875: [SPARK-30245][SQL] Add cache for Like and RLike when pattern is not static

2020-01-12 Thread GitBox
SparkQA commented on issue #26875: [SPARK-30245][SQL] Add cache for Like and RLike when pattern is not static URL: https://github.com/apache/spark/pull/26875#issuecomment-573484238 **[Test build #116582 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/116582/

[GitHub] [spark] SparkQA commented on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods

2020-01-12 Thread GitBox
SparkQA commented on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods URL: https://github.com/apache/spark/pull/27181#issuecomment-573484233 **[Test build #116581 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkP

[GitHub] [spark] HyukjinKwon commented on issue #26875: [SPARK-30245][SQL] Add cache for Like and RLike when pattern is not static

2020-01-12 Thread GitBox
HyukjinKwon commented on issue #26875: [SPARK-30245][SQL] Add cache for Like and RLike when pattern is not static URL: https://github.com/apache/spark/pull/26875#issuecomment-573484115 retest this please This is an automated

[GitHub] [spark] AmplabJenkins commented on issue #27182: [SPARK-28752][BUILD][DOCS][FOLLOW-UP] Render examples imported from Jekyll properly via Rouge

2020-01-12 Thread GitBox
AmplabJenkins commented on issue #27182: [SPARK-28752][BUILD][DOCS][FOLLOW-UP] Render examples imported from Jekyll properly via Rouge URL: https://github.com/apache/spark/pull/27182#issuecomment-573483946 Test PASSed. Refer to this link for build results (access rights to CI server need

[GitHub] [spark] AmplabJenkins removed a comment on issue #27182: [SPARK-28752][BUILD][DOCS][FOLLOW-UP] Render examples imported from Jekyll properly via Rouge

2020-01-12 Thread GitBox
AmplabJenkins removed a comment on issue #27182: [SPARK-28752][BUILD][DOCS][FOLLOW-UP] Render examples imported from Jekyll properly via Rouge URL: https://github.com/apache/spark/pull/27182#issuecomment-573483946 Test PASSed. Refer to this link for build results (access rights to CI se

[GitHub] [spark] AmplabJenkins removed a comment on issue #27182: [SPARK-28752][BUILD][DOCS][FOLLOW-UP] Render examples imported from Jekyll properly via Rouge

2020-01-12 Thread GitBox
AmplabJenkins removed a comment on issue #27182: [SPARK-28752][BUILD][DOCS][FOLLOW-UP] Render examples imported from Jekyll properly via Rouge URL: https://github.com/apache/spark/pull/27182#issuecomment-573483945 Merged build finished. Test PASSed. ---

[GitHub] [spark] SparkQA removed a comment on issue #27182: [SPARK-28752][BUILD][DOCS][FOLLOW-UP] Render examples imported from Jekyll properly via Rouge

2020-01-12 Thread GitBox
SparkQA removed a comment on issue #27182: [SPARK-28752][BUILD][DOCS][FOLLOW-UP] Render examples imported from Jekyll properly via Rouge URL: https://github.com/apache/spark/pull/27182#issuecomment-573482740 **[Test build #116580 has started](https://amplab.cs.berkeley.edu/jenkins/job/Spa

[GitHub] [spark] AmplabJenkins commented on issue #27182: [SPARK-28752][BUILD][DOCS][FOLLOW-UP] Render examples imported from Jekyll properly via Rouge

2020-01-12 Thread GitBox
AmplabJenkins commented on issue #27182: [SPARK-28752][BUILD][DOCS][FOLLOW-UP] Render examples imported from Jekyll properly via Rouge URL: https://github.com/apache/spark/pull/27182#issuecomment-573483945 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA commented on issue #27182: [SPARK-28752][BUILD][DOCS][FOLLOW-UP] Render examples imported from Jekyll properly via Rouge

2020-01-12 Thread GitBox
SparkQA commented on issue #27182: [SPARK-28752][BUILD][DOCS][FOLLOW-UP] Render examples imported from Jekyll properly via Rouge URL: https://github.com/apache/spark/pull/27182#issuecomment-573483912 **[Test build #116580 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRe

[GitHub] [spark] HyukjinKwon closed pull request #27182: [SPARK-28752][BUILD][DOCS][FOLLOW-UP] Render examples imported from Jekyll properly via Rouge

2020-01-12 Thread GitBox
HyukjinKwon closed pull request #27182: [SPARK-28752][BUILD][DOCS][FOLLOW-UP] Render examples imported from Jekyll properly via Rouge URL: https://github.com/apache/spark/pull/27182 This is an automated message from the Apac

[GitHub] [spark] HyukjinKwon commented on issue #27182: [SPARK-28752][BUILD][DOCS][FOLLOW-UP] Render examples imported from Jekyll properly via Rouge

2020-01-12 Thread GitBox
HyukjinKwon commented on issue #27182: [SPARK-28752][BUILD][DOCS][FOLLOW-UP] Render examples imported from Jekyll properly via Rouge URL: https://github.com/apache/spark/pull/27182#issuecomment-573483739 Thanks. I double checked and here's the HTML output: Pygment: ```html

[GitHub] [spark] HyukjinKwon commented on issue #27182: [SPARK-28752][BUILD][DOCS][FOLLOW-UP] Render examples imported from Jekyll properly via Rouge

2020-01-12 Thread GitBox
HyukjinKwon commented on issue #27182: [SPARK-28752][BUILD][DOCS][FOLLOW-UP] Render examples imported from Jekyll properly via Rouge URL: https://github.com/apache/spark/pull/27182#issuecomment-573483777 I am going to merge this since we don't build the doc in PR builders. Merged to

[GitHub] [spark] AmplabJenkins removed a comment on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods

2020-01-12 Thread GitBox
AmplabJenkins removed a comment on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods URL: https://github.com/apache/spark/pull/27181#issuecomment-573483583 Merged build finished. Test PASSed. --

[GitHub] [spark] AmplabJenkins removed a comment on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods

2020-01-12 Thread GitBox
AmplabJenkins removed a comment on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods URL: https://github.com/apache/spark/pull/27181#issuecomment-573483587 Test PASSed. Refer to this link for build results (access rights to

[GitHub] [spark] AmplabJenkins commented on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods

2020-01-12 Thread GitBox
AmplabJenkins commented on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods URL: https://github.com/apache/spark/pull/27181#issuecomment-573483583 Merged build finished. Test PASSed. --

[GitHub] [spark] AmplabJenkins commented on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods

2020-01-12 Thread GitBox
AmplabJenkins commented on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods URL: https://github.com/apache/spark/pull/27181#issuecomment-573483587 Test PASSed. Refer to this link for build results (access rights to CI serve

[GitHub] [spark] zero323 commented on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods

2020-01-12 Thread GitBox
zero323 commented on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods URL: https://github.com/apache/spark/pull/27181#issuecomment-573483559 Shouldn't `weightCol` be set as well? --

[GitHub] [spark] SparkQA commented on issue #26440: [SPARK-20628][CORE][K8S] Start to improve Spark decommissioning & preemption support

2020-01-12 Thread GitBox
SparkQA commented on issue #26440: [SPARK-20628][CORE][K8S] Start to improve Spark decommissioning & preemption support URL: https://github.com/apache/spark/pull/26440#issuecomment-573483041 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRe

[GitHub] [spark] HyukjinKwon commented on issue #27182: [SPARK-28752][BUILD][DOCS][FOLLOW-UP] Render examples imported from Jekyll properly via Rouge

2020-01-12 Thread GitBox
HyukjinKwon commented on issue #27182: [SPARK-28752][BUILD][DOCS][FOLLOW-UP] Render examples imported from Jekyll properly via Rouge URL: https://github.com/apache/spark/pull/27182#issuecomment-573483072 Ah, let me fix the PR description to clarify.

[GitHub] [spark] dongjoon-hyun commented on issue #27182: [SPARK-28752][BUILD][DOCS][FOLLOW-UP] Render examples imported from Jekyll properly via Rouge

2020-01-12 Thread GitBox
dongjoon-hyun commented on issue #27182: [SPARK-28752][BUILD][DOCS][FOLLOW-UP] Render examples imported from Jekyll properly via Rouge URL: https://github.com/apache/spark/pull/27182#issuecomment-573482934 This is only for 3.0.0. Did I understand correctly, @HyukjinKwon ? -

[GitHub] [spark] HyukjinKwon commented on issue #27182: [SPARK-28752][BUILD][DOCS][FOLLOW-UP] Render examples imported from Jekyll properly via Rouge

2020-01-12 Thread GitBox
HyukjinKwon commented on issue #27182: [SPARK-28752][BUILD][DOCS][FOLLOW-UP] Render examples imported from Jekyll properly via Rouge URL: https://github.com/apache/spark/pull/27182#issuecomment-573482991 Yup. This is an autom

[GitHub] [spark] AmplabJenkins removed a comment on issue #27182: [SPARK-28752][BUILD][DOCS][FOLLOW-UP] Render examples imported from Jekyll properly via Rouge

2020-01-12 Thread GitBox
AmplabJenkins removed a comment on issue #27182: [SPARK-28752][BUILD][DOCS][FOLLOW-UP] Render examples imported from Jekyll properly via Rouge URL: https://github.com/apache/spark/pull/27182#issuecomment-573482883 Test PASSed. Refer to this link for build results (access rights to CI se

[GitHub] [spark] AmplabJenkins commented on issue #27182: [SPARK-28752][BUILD][DOCS][FOLLOW-UP] Render examples imported from Jekyll properly via Rouge

2020-01-12 Thread GitBox
AmplabJenkins commented on issue #27182: [SPARK-28752][BUILD][DOCS][FOLLOW-UP] Render examples imported from Jekyll properly via Rouge URL: https://github.com/apache/spark/pull/27182#issuecomment-573482883 Test PASSed. Refer to this link for build results (access rights to CI server need

[GitHub] [spark] AmplabJenkins removed a comment on issue #27182: [SPARK-28752][BUILD][DOCS][FOLLOW-UP] Render examples imported from Jekyll properly via Rouge

2020-01-12 Thread GitBox
AmplabJenkins removed a comment on issue #27182: [SPARK-28752][BUILD][DOCS][FOLLOW-UP] Render examples imported from Jekyll properly via Rouge URL: https://github.com/apache/spark/pull/27182#issuecomment-573482880 Merged build finished. Test PASSed. ---

[GitHub] [spark] HyukjinKwon commented on a change in pull request #27182: [SPARK-28752][BUILD][DOCS][FOLLOW-UP] Render examples imported from Jekyll properly via Rouge

2020-01-12 Thread GitBox
HyukjinKwon commented on a change in pull request #27182: [SPARK-28752][BUILD][DOCS][FOLLOW-UP] Render examples imported from Jekyll properly via Rouge URL: https://github.com/apache/spark/pull/27182#discussion_r365628562 ## File path: docs/_plugins/include_example.rb ##

[GitHub] [spark] AmplabJenkins commented on issue #27182: [SPARK-28752][BUILD][DOCS][FOLLOW-UP] Render examples imported from Jekyll properly via Rouge

2020-01-12 Thread GitBox
AmplabJenkins commented on issue #27182: [SPARK-28752][BUILD][DOCS][FOLLOW-UP] Render examples imported from Jekyll properly via Rouge URL: https://github.com/apache/spark/pull/27182#issuecomment-573482880 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA commented on issue #27182: [SPARK-28752][BUILD][DOCS][FOLLOW-UP] Render examples imported from Jekyll properly via Rouge

2020-01-12 Thread GitBox
SparkQA commented on issue #27182: [SPARK-28752][BUILD][DOCS][FOLLOW-UP] Render examples imported from Jekyll properly via Rouge URL: https://github.com/apache/spark/pull/27182#issuecomment-573482740 **[Test build #116580 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullReq

[GitHub] [spark] HyukjinKwon commented on issue #27182: [SPARK-28752][BUILD][DOCS][FOLLOW-UP] Render examples imported from Jekyll properly via Rouge

2020-01-12 Thread GitBox
HyukjinKwon commented on issue #27182: [SPARK-28752][BUILD][DOCS][FOLLOW-UP] Render examples imported from Jekyll properly via Rouge URL: https://github.com/apache/spark/pull/27182#issuecomment-573482683 cc @srowen, @dongjoon-hyun, @gatorsmile. Thanks for letting me know this Xiao.

[GitHub] [spark] huaxingao commented on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods

2020-01-12 Thread GitBox
huaxingao commented on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods URL: https://github.com/apache/spark/pull/27181#issuecomment-573482681 actually, should use ```_set``` instead of ```setLabelCol``` in ```OneVsRestModel.

[GitHub] [spark] HyukjinKwon opened a new pull request #27182: [SPARK-28752][BUILD][DOCS][FOLLOW-UP] Render examples imported from Jekyll properly via Rouge

2020-01-12 Thread GitBox
HyukjinKwon opened a new pull request #27182: [SPARK-28752][BUILD][DOCS][FOLLOW-UP] Render examples imported from Jekyll properly via Rouge URL: https://github.com/apache/spark/pull/27182 ### What changes were proposed in this pull request? This PR proposes to use Pygment compatible

[GitHub] [spark] AmplabJenkins removed a comment on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods

2020-01-12 Thread GitBox
AmplabJenkins removed a comment on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods URL: https://github.com/apache/spark/pull/27181#issuecomment-573481764 Test FAILed. Refer to this link for build results (access rights to

[GitHub] [spark] AmplabJenkins removed a comment on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods

2020-01-12 Thread GitBox
AmplabJenkins removed a comment on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods URL: https://github.com/apache/spark/pull/27181#issuecomment-573481763 Merged build finished. Test FAILed. --

[GitHub] [spark] SparkQA removed a comment on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods

2020-01-12 Thread GitBox
SparkQA removed a comment on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods URL: https://github.com/apache/spark/pull/27181#issuecomment-573480059 **[Test build #116579 has started](https://amplab.cs.berkeley.edu/jenkins/jo

[GitHub] [spark] SparkQA commented on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods

2020-01-12 Thread GitBox
SparkQA commented on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods URL: https://github.com/apache/spark/pull/27181#issuecomment-573481722 **[Test build #116579 has finished](https://amplab.cs.berkeley.edu/jenkins/job/Spark

[GitHub] [spark] AmplabJenkins commented on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods

2020-01-12 Thread GitBox
AmplabJenkins commented on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods URL: https://github.com/apache/spark/pull/27181#issuecomment-573481764 Test FAILed. Refer to this link for build results (access rights to CI serve

[GitHub] [spark] AmplabJenkins commented on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods

2020-01-12 Thread GitBox
AmplabJenkins commented on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods URL: https://github.com/apache/spark/pull/27181#issuecomment-573481763 Merged build finished. Test FAILed. --

[GitHub] [spark] huaxingao commented on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods

2020-01-12 Thread GitBox
huaxingao commented on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods URL: https://github.com/apache/spark/pull/27181#issuecomment-573481513 ```setLabelCol``` is called in ```OneVsRestModel._from_java``` ---

[GitHub] [spark] ulysses-you commented on issue #26875: [SPARK-30245][SQL] Add cache for Like and RLike when pattern is not static

2020-01-12 Thread GitBox
ulysses-you commented on issue #26875: [SPARK-30245][SQL] Add cache for Like and RLike when pattern is not static URL: https://github.com/apache/spark/pull/26875#issuecomment-573480257 @cloud-fan Do you have time to take a look again? Thanks in advance.

[GitHub] [spark] SparkQA commented on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods

2020-01-12 Thread GitBox
SparkQA commented on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods URL: https://github.com/apache/spark/pull/27181#issuecomment-573480059 **[Test build #116579 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkP

[GitHub] [spark] zero323 edited a comment on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods

2020-01-12 Thread GitBox
zero323 edited a comment on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods URL: https://github.com/apache/spark/pull/27181#issuecomment-573479873 > `setLabelCol` is still required. Is it really? [Doesn't seem](https:

[GitHub] [spark] zero323 removed a comment on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods

2020-01-12 Thread GitBox
zero323 removed a comment on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods URL: https://github.com/apache/spark/pull/27181#issuecomment-573479981 Retest this please.

[GitHub] [spark] zero323 commented on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods

2020-01-12 Thread GitBox
zero323 commented on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods URL: https://github.com/apache/spark/pull/27181#issuecomment-573479981 Retest this please.

[GitHub] [spark] zero323 commented on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods

2020-01-12 Thread GitBox
zero323 commented on issue #27181: [SPARK-30493][PYTHON][ML] Remove OneVsRestModel setClassifier, setLabelCol and setWeightCol methods URL: https://github.com/apache/spark/pull/27181#issuecomment-573479873 > `setLabelCol` is still required. Is it really? [Doesn't seem](https://spark

[GitHub] [spark] JkSelf commented on a change in pull request #26434: [SPARK-29544] [SQL] optimize skewed partition based on data size

2020-01-12 Thread GitBox
JkSelf commented on a change in pull request #26434: [SPARK-29544] [SQL] optimize skewed partition based on data size URL: https://github.com/apache/spark/pull/26434#discussion_r365626441 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/ReduceNumShuffle

[GitHub] [spark] SparkQA commented on issue #26440: [SPARK-20628][CORE][K8S] Start to improve Spark decommissioning & preemption support

2020-01-12 Thread GitBox
SparkQA commented on issue #26440: [SPARK-20628][CORE][K8S] Start to improve Spark decommissioning & preemption support URL: https://github.com/apache/spark/pull/26440#issuecomment-573479314 **[Test build #116578 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuild

[GitHub] [spark] AmplabJenkins removed a comment on issue #27030: [SPARK-30244][SQL] Emit pre/post events for "Partition" methods in ExternalCatalogWithListener

2020-01-12 Thread GitBox
AmplabJenkins removed a comment on issue #27030: [SPARK-30244][SQL] Emit pre/post events for "Partition" methods in ExternalCatalogWithListener URL: https://github.com/apache/spark/pull/27030#issuecomment-573479249 Test PASSed. Refer to this link for build results (access rights to CI se

[GitHub] [spark] AmplabJenkins commented on issue #27030: [SPARK-30244][SQL] Emit pre/post events for "Partition" methods in ExternalCatalogWithListener

2020-01-12 Thread GitBox
AmplabJenkins commented on issue #27030: [SPARK-30244][SQL] Emit pre/post events for "Partition" methods in ExternalCatalogWithListener URL: https://github.com/apache/spark/pull/27030#issuecomment-573479246 Merged build finished. Test PASSed. ---

[GitHub] [spark] AmplabJenkins commented on issue #27030: [SPARK-30244][SQL] Emit pre/post events for "Partition" methods in ExternalCatalogWithListener

2020-01-12 Thread GitBox
AmplabJenkins commented on issue #27030: [SPARK-30244][SQL] Emit pre/post events for "Partition" methods in ExternalCatalogWithListener URL: https://github.com/apache/spark/pull/27030#issuecomment-573479249 Test PASSed. Refer to this link for build results (access rights to CI server nee

[GitHub] [spark] AmplabJenkins removed a comment on issue #27030: [SPARK-30244][SQL] Emit pre/post events for "Partition" methods in ExternalCatalogWithListener

2020-01-12 Thread GitBox
AmplabJenkins removed a comment on issue #27030: [SPARK-30244][SQL] Emit pre/post events for "Partition" methods in ExternalCatalogWithListener URL: https://github.com/apache/spark/pull/27030#issuecomment-573479246 Merged build finished. Test PASSed. ---

[GitHub] [spark] SparkQA commented on issue #27030: [SPARK-30244][SQL] Emit pre/post events for "Partition" methods in ExternalCatalogWithListener

2020-01-12 Thread GitBox
SparkQA commented on issue #27030: [SPARK-30244][SQL] Emit pre/post events for "Partition" methods in ExternalCatalogWithListener URL: https://github.com/apache/spark/pull/27030#issuecomment-573479100 **[Test build #116570 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullR

[GitHub] [spark] SparkQA removed a comment on issue #27030: [SPARK-30244][SQL] Emit pre/post events for "Partition" methods in ExternalCatalogWithListener

2020-01-12 Thread GitBox
SparkQA removed a comment on issue #27030: [SPARK-30244][SQL] Emit pre/post events for "Partition" methods in ExternalCatalogWithListener URL: https://github.com/apache/spark/pull/27030#issuecomment-573457218 **[Test build #116570 has started](https://amplab.cs.berkeley.edu/jenkins/job/Spa

[GitHub] [spark] AmplabJenkins removed a comment on issue #27078: [SPARK-30409][SPARK-29173][SQL][TESTS] Use `NoOp` datasource in SQL benchmarks

2020-01-12 Thread GitBox
AmplabJenkins removed a comment on issue #27078: [SPARK-30409][SPARK-29173][SQL][TESTS] Use `NoOp` datasource in SQL benchmarks URL: https://github.com/apache/spark/pull/27078#issuecomment-573478679 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #27078: [SPARK-30409][SPARK-29173][SQL][TESTS] Use `NoOp` datasource in SQL benchmarks

2020-01-12 Thread GitBox
AmplabJenkins commented on issue #27078: [SPARK-30409][SPARK-29173][SQL][TESTS] Use `NoOp` datasource in SQL benchmarks URL: https://github.com/apache/spark/pull/27078#issuecomment-573478679 Test PASSed. Refer to this link for build results (access rights to CI server needed): https:

[GitHub] [spark] AmplabJenkins removed a comment on issue #27078: [SPARK-30409][SPARK-29173][SQL][TESTS] Use `NoOp` datasource in SQL benchmarks

2020-01-12 Thread GitBox
AmplabJenkins removed a comment on issue #27078: [SPARK-30409][SPARK-29173][SQL][TESTS] Use `NoOp` datasource in SQL benchmarks URL: https://github.com/apache/spark/pull/27078#issuecomment-573478675 Merged build finished. Test PASSed. ---

[GitHub] [spark] AmplabJenkins commented on issue #27078: [SPARK-30409][SPARK-29173][SQL][TESTS] Use `NoOp` datasource in SQL benchmarks

2020-01-12 Thread GitBox
AmplabJenkins commented on issue #27078: [SPARK-30409][SPARK-29173][SQL][TESTS] Use `NoOp` datasource in SQL benchmarks URL: https://github.com/apache/spark/pull/27078#issuecomment-573478675 Merged build finished. Test PASSed. ---

<    1   2   3   4   5   6   7   8   9   10   >