SparkQA commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616969597
**[Test build #121553 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121553/testReport)**
for PR 28274 at commit
SparkQA removed a comment on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616905435
**[Test build #121553 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121553/testReport)**
for PR 28274 at commit
zhengruifeng commented on a change in pull request #27758:
URL: https://github.com/apache/spark/pull/27758#discussion_r411885963
##
File path: mllib-local/src/main/scala/org/apache/spark/ml/impl/Utils.scala
##
@@ -27,4 +27,55 @@ private[ml] object Utils {
}
eps
}
zhengruifeng commented on a change in pull request #27758:
URL: https://github.com/apache/spark/pull/27758#discussion_r411884957
##
File path:
mllib/src/main/scala/org/apache/spark/mllib/clustering/DistanceMeasure.scala
##
@@ -154,22 +255,81 @@ object DistanceMeasure {
}
SparkQA removed a comment on issue #28267:
URL: https://github.com/apache/spark/pull/28267#issuecomment-616957488
**[Test build #121564 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121564/testReport)**
for PR 28267 at commit
AmplabJenkins commented on issue #28267:
URL: https://github.com/apache/spark/pull/28267#issuecomment-616964480
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
AmplabJenkins removed a comment on issue #28267:
URL: https://github.com/apache/spark/pull/28267#issuecomment-616964480
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on issue #28267:
URL: https://github.com/apache/spark/pull/28267#issuecomment-616964394
**[Test build #121564 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121564/testReport)**
for PR 28267 at commit
maropu commented on a change in pull request #21479:
URL: https://github.com/apache/spark/pull/21479#discussion_r409933251
##
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##
@@ -592,6 +592,7 @@ primaryExpression
| identifier
maropu commented on a change in pull request #21479:
URL: https://github.com/apache/spark/pull/21479#discussion_r409933251
##
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##
@@ -592,6 +592,7 @@ primaryExpression
| identifier
HeartSaVioR commented on a change in pull request #27620:
URL: https://github.com/apache/spark/pull/27620#discussion_r411779675
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSourceSuite.scala
##
@@ -1935,6 +1928,120 @@ class
HeartSaVioR commented on a change in pull request #27620:
URL: https://github.com/apache/spark/pull/27620#discussion_r411779675
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSourceSuite.scala
##
@@ -1935,6 +1928,120 @@ class
maropu commented on a change in pull request #28276:
URL: https://github.com/apache/spark/pull/28276#discussion_r411881765
##
File path: sql/core/src/test/resources/sql-tests/inputs/extract.sql
##
@@ -83,3 +83,21 @@ select extract(epoch from c) from t;
select
maropu commented on a change in pull request #28276:
URL: https://github.com/apache/spark/pull/28276#discussion_r411881765
##
File path: sql/core/src/test/resources/sql-tests/inputs/extract.sql
##
@@ -83,3 +83,21 @@ select extract(epoch from c) from t;
select
AmplabJenkins removed a comment on issue #28267:
URL: https://github.com/apache/spark/pull/28267#issuecomment-616961678
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on issue #28267:
URL: https://github.com/apache/spark/pull/28267#issuecomment-616955223
**[Test build #121563 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121563/testReport)**
for PR 28267 at commit
AmplabJenkins commented on issue #28267:
URL: https://github.com/apache/spark/pull/28267#issuecomment-616961678
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
SparkQA commented on issue #28267:
URL: https://github.com/apache/spark/pull/28267#issuecomment-616961593
**[Test build #121563 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121563/testReport)**
for PR 28267 at commit
AmplabJenkins removed a comment on issue #28278:
URL: https://github.com/apache/spark/pull/28278#issuecomment-616959583
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
To
AmplabJenkins commented on issue #28278:
URL: https://github.com/apache/spark/pull/28278#issuecomment-616960007
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
To respond to
AmplabJenkins commented on issue #28278:
URL: https://github.com/apache/spark/pull/28278#issuecomment-616959583
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
To respond to
SparkQA commented on issue #28248:
URL: https://github.com/apache/spark/pull/28248#issuecomment-616959717
**[Test build #121565 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121565/testReport)**
for PR 28248 at commit
zhengruifeng commented on issue #28229:
URL: https://github.com/apache/spark/pull/28229#issuecomment-616959227
also ping @mengxr @WeichenXu123
What about adding an option and letting end user to choose whether to enable
high-level BLAS?
gengliangwang commented on issue #28208:
URL: https://github.com/apache/spark/pull/28208#issuecomment-616959190
I see.
From the
https://issues.apache.org/jira/secure/attachment/13000621/improved_version.json,
if there are only nodes without edges, it seems providing node id is
jinwensc opened a new pull request #28278:
URL: https://github.com/apache/spark/pull/28278
… bigdecimal not both cast to double"
### What changes were proposed in this pull request?
Fix zhe bug when compare bigdecimal with string,both will cast to
double,result in precision
xwu99 commented on issue #27758:
URL: https://github.com/apache/spark/pull/27758#issuecomment-616958956
> In current impl, following Lemma is used in KMeans:
>
> 0, Let x be a point, let b be a center and o be the origin, then d(x,c) >=
|(d(x,o) - d(c,o))| = |norm-norm(c)|
>
zhengruifeng commented on issue #28229:
URL: https://github.com/apache/spark/pull/28229#issuecomment-616958445
I am OK if we can avoid performance regression on sparse datasets. It is up
to the end users to choose the right impl.
@srowen How you think about it?
AmplabJenkins commented on issue #28248:
URL: https://github.com/apache/spark/pull/28248#issuecomment-616957868
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
erenavsarogullari commented on issue #28208:
URL: https://github.com/apache/spark/pull/28208#issuecomment-616957907
Hi @gengliangwang,
Thanks for the review. `improved_version` link has just been updated as
AmplabJenkins removed a comment on issue #28248:
URL: https://github.com/apache/spark/pull/28248#issuecomment-616957868
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on issue #28267:
URL: https://github.com/apache/spark/pull/28267#issuecomment-616957488
**[Test build #121564 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121564/testReport)**
for PR 28267 at commit
gengliangwang commented on issue #28208:
URL: https://github.com/apache/spark/pull/28208#issuecomment-616956525
Hi @erenavsarogullari Thanks for the work.
The link
https://issues.apache.org/jira/secure/attachment/12999822/improved_version.json
is broken now. Could you fix it?
gengliangwang commented on a change in pull request #28208:
URL: https://github.com/apache/spark/pull/28208#discussion_r411874450
##
File path:
sql/core/src/main/scala/org/apache/spark/status/api/v1/sql/SqlResource.scala
##
@@ -84,18 +119,40 @@ private[v1] class SqlResource
gengliangwang commented on a change in pull request #28208:
URL: https://github.com/apache/spark/pull/28208#discussion_r411871518
##
File path:
sql/core/src/main/scala/org/apache/spark/status/api/v1/sql/SqlResource.scala
##
@@ -84,18 +119,40 @@ private[v1] class SqlResource
AmplabJenkins removed a comment on issue #28267:
URL: https://github.com/apache/spark/pull/28267#issuecomment-616955590
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on issue #28267:
URL: https://github.com/apache/spark/pull/28267#issuecomment-616955590
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
SparkQA commented on issue #28267:
URL: https://github.com/apache/spark/pull/28267#issuecomment-616955223
**[Test build #121563 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121563/testReport)**
for PR 28267 at commit
HyukjinKwon commented on issue #28267:
URL: https://github.com/apache/spark/pull/28267#issuecomment-616955226
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
HyukjinKwon commented on a change in pull request #28267:
URL: https://github.com/apache/spark/pull/28267#discussion_r411873134
##
File path:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/LocalityPreferredContainerPlacementStrategy.scala
##
@@ -63,16
AmplabJenkins removed a comment on issue #28267:
URL: https://github.com/apache/spark/pull/28267#issuecomment-616252341
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
To
gatorsmile commented on issue #28277:
URL: https://github.com/apache/spark/pull/28277#issuecomment-616954898
cc @cloud-fan
This is an automated message from the Apache Git Service.
To respond to the message, please log on
HyukjinKwon commented on a change in pull request #28267:
URL: https://github.com/apache/spark/pull/28267#discussion_r411873006
##
File path:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/LocalityPreferredContainerPlacementStrategy.scala
##
@@ -40,7 +40,7
HyukjinKwon commented on issue #28267:
URL: https://github.com/apache/spark/pull/28267#issuecomment-616954687
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
xwu99 commented on issue #28229:
URL: https://github.com/apache/spark/pull/28229#issuecomment-616953665
@zhengruifeng I am OK with inline switch instead of SparkConf.
My general points:
1) Matrix-multiply is highly optimized routine by the industry. If take
advantage of it,
AmplabJenkins commented on issue #28245:
URL: https://github.com/apache/spark/pull/28245#issuecomment-616952443
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
AmplabJenkins removed a comment on issue #28245:
URL: https://github.com/apache/spark/pull/28245#issuecomment-616952443
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on issue #28245:
URL: https://github.com/apache/spark/pull/28245#issuecomment-616899007
**[Test build #121552 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121552/testReport)**
for PR 28245 at commit
SparkQA commented on issue #28245:
URL: https://github.com/apache/spark/pull/28245#issuecomment-616951760
**[Test build #121552 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121552/testReport)**
for PR 28245 at commit
SparkQA commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616951288
**[Test build #121562 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121562/testReport)**
for PR 28274 at commit
AmplabJenkins removed a comment on issue #28123:
URL: https://github.com/apache/spark/pull/28123#issuecomment-616950244
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121557/
AmplabJenkins removed a comment on issue #28123:
URL: https://github.com/apache/spark/pull/28123#issuecomment-616950235
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To respond
AmplabJenkins commented on issue #28123:
URL: https://github.com/apache/spark/pull/28123#issuecomment-616950235
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
SparkQA commented on issue #28123:
URL: https://github.com/apache/spark/pull/28123#issuecomment-616950100
**[Test build #121557 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121557/testReport)**
for PR 28123 at commit
SparkQA removed a comment on issue #28123:
URL: https://github.com/apache/spark/pull/28123#issuecomment-616918507
**[Test build #121557 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121557/testReport)**
for PR 28123 at commit
asclepiusaka commented on issue #28267:
URL: https://github.com/apache/spark/pull/28267#issuecomment-616949634
@HyukjinKwon read again and fixed several more words.
This is an automated message from the Apache Git Service.
AmplabJenkins commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616949666
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
AmplabJenkins removed a comment on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616949666
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
zhengruifeng commented on issue #28270:
URL: https://github.com/apache/spark/pull/28270#issuecomment-616948950
Merged to master
This is an automated message from the Apache Git Service.
To respond to the message, please log
SparkQA commented on issue #28277:
URL: https://github.com/apache/spark/pull/28277#issuecomment-616948853
**[Test build #121561 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121561/testReport)**
for PR 28277 at commit
AmplabJenkins commented on issue #28277:
URL: https://github.com/apache/spark/pull/28277#issuecomment-616948943
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
AmplabJenkins removed a comment on issue #28277:
URL: https://github.com/apache/spark/pull/28277#issuecomment-616948943
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on issue #28277:
URL: https://github.com/apache/spark/pull/28277#issuecomment-616945610
**[Test build #121561 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121561/testReport)**
for PR 28277 at commit
zhengruifeng commented on issue #28229:
URL: https://github.com/apache/spark/pull/28229#issuecomment-616947377
I am not against this PR.
I don't think adding a spark conf is a good idea, but maybe we could add a
parameter for end user to switch between impls? or check the first vector
AmplabJenkins removed a comment on issue #28270:
URL: https://github.com/apache/spark/pull/28270#issuecomment-616945523
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on issue #28277:
URL: https://github.com/apache/spark/pull/28277#issuecomment-616943903
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on issue #28277:
URL: https://github.com/apache/spark/pull/28277#issuecomment-616945610
**[Test build #121561 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121561/testReport)**
for PR 28277 at commit
SparkQA removed a comment on issue #28270:
URL: https://github.com/apache/spark/pull/28270#issuecomment-616927142
**[Test build #121558 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121558/testReport)**
for PR 28270 at commit
AmplabJenkins commented on issue #28270:
URL: https://github.com/apache/spark/pull/28270#issuecomment-616945523
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
SparkQA commented on issue #28270:
URL: https://github.com/apache/spark/pull/28270#issuecomment-616945219
**[Test build #121558 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121558/testReport)**
for PR 28270 at commit
AmplabJenkins commented on issue #28277:
URL: https://github.com/apache/spark/pull/28277#issuecomment-616943903
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
huaxingao opened a new pull request #28277:
URL: https://github.com/apache/spark/pull/28277
### What changes were proposed in this pull request?
Document identifier in SQL Reference
### Why are the changes needed?
make SQL Reference complete
### Does this PR
zhengruifeng edited a comment on issue #28229:
URL: https://github.com/apache/spark/pull/28229#issuecomment-616937541
> Did you benchmark with native BLAS with a machine with AVX2 or AVX512 ?
The native optimization not only take advantage of multi-thread but also SIMD,
cache etc.
zhengruifeng commented on issue #28229:
URL: https://github.com/apache/spark/pull/28229#issuecomment-616937541
> Did you benchmark with native BLAS with a machine with AVX2 or AVX512 ?
The native optimization not only take advantage of multi-thread but also SIMD,
cache etc.
I
cloud-fan commented on issue #28275:
URL: https://github.com/apache/spark/pull/28275#issuecomment-616936535
good catch! merging to master/3.0
This is an automated message from the Apache Git Service.
To respond to the
HyukjinKwon commented on a change in pull request #28276:
URL: https://github.com/apache/spark/pull/28276#discussion_r411848301
##
File path: sql/core/src/test/resources/sql-tests/inputs/extract.sql
##
@@ -83,3 +83,21 @@ select extract(epoch from c) from t;
select
HyukjinKwon commented on a change in pull request #28276:
URL: https://github.com/apache/spark/pull/28276#discussion_r411847125
##
File path: sql/core/src/test/resources/sql-tests/inputs/extract.sql
##
@@ -83,3 +83,21 @@ select extract(epoch from c) from t;
select
HyukjinKwon commented on a change in pull request #28276:
URL: https://github.com/apache/spark/pull/28276#discussion_r411846223
##
File path: sql/core/src/test/resources/sql-tests/inputs/extract.sql
##
@@ -83,3 +83,21 @@ select extract(epoch from c) from t;
select
AmplabJenkins commented on issue #28208:
URL: https://github.com/apache/spark/pull/28208#issuecomment-616933190
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
AmplabJenkins removed a comment on issue #28208:
URL: https://github.com/apache/spark/pull/28208#issuecomment-616933190
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on issue #28208:
URL: https://github.com/apache/spark/pull/28208#issuecomment-616932880
**[Test build #121560 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121560/testReport)**
for PR 28208 at commit
xwu99 edited a comment on issue #28229:
URL: https://github.com/apache/spark/pull/28229#issuecomment-616930014
> Yeah I think we tried this and it hurt perf on sparse input, no? I'd have
to dig it out..
@srowen I will benchmark sparse cases, but could we use this to deal with
dense
AmplabJenkins removed a comment on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616931482
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
erenavsarogullari edited a comment on issue #28208:
URL: https://github.com/apache/spark/pull/28208#issuecomment-616931030
Last build failure seems irrelevant:
`org.apache.spark.sql.streaming.StreamingDeduplicationSuite.test no-data
flag`
AmplabJenkins commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616931482
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
erenavsarogullari commented on issue #28208:
URL: https://github.com/apache/spark/pull/28208#issuecomment-616931367
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
erenavsarogullari edited a comment on issue #28208:
URL: https://github.com/apache/spark/pull/28208#issuecomment-616931030
Last build failure seems irrelevant:
`org.apache.spark.sql.streaming.StreamingDeduplicationSuite.test no-data
flag`
SparkQA commented on issue #28274:
URL: https://github.com/apache/spark/pull/28274#issuecomment-616931195
**[Test build #121559 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121559/testReport)**
for PR 28274 at commit
erenavsarogullari commented on issue #28208:
URL: https://github.com/apache/spark/pull/28208#issuecomment-616931030
Last build failure seems irrelivant:
`org.apache.spark.sql.streaming.StreamingDeduplicationSuite.test no-data
flag`
xwu99 commented on issue #28229:
URL: https://github.com/apache/spark/pull/28229#issuecomment-616930014
> Yeah I think we tried this and it hurt perf on sparse input, no? I'd have
to dig it out..
@srowen I will benchmark sparse cases, but could we use this to deal with
dense only?
AmplabJenkins removed a comment on issue #28224:
URL: https://github.com/apache/spark/pull/28224#issuecomment-616928666
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
xwu99 commented on issue #28229:
URL: https://github.com/apache/spark/pull/28229#issuecomment-616928515
@srowen Thanks you for linking us!
>
> @xwu99 Could you please provide some performance results of your PR?
Our preliminary benchmark shows this approach can boost the
AmplabJenkins commented on issue #28224:
URL: https://github.com/apache/spark/pull/28224#issuecomment-616928666
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
SparkQA commented on issue #28224:
URL: https://github.com/apache/spark/pull/28224#issuecomment-616927985
**[Test build #121550 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121550/testReport)**
for PR 28224 at commit
SparkQA removed a comment on issue #28224:
URL: https://github.com/apache/spark/pull/28224#issuecomment-616879824
**[Test build #121550 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121550/testReport)**
for PR 28224 at commit
AmplabJenkins removed a comment on issue #28270:
URL: https://github.com/apache/spark/pull/28270#issuecomment-616927464
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins commented on issue #28270:
URL: https://github.com/apache/spark/pull/28270#issuecomment-616927464
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
SparkQA commented on issue #28270:
URL: https://github.com/apache/spark/pull/28270#issuecomment-616927142
**[Test build #121558 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121558/testReport)**
for PR 28270 at commit
srowen commented on issue #28229:
URL: https://github.com/apache/spark/pull/28229#issuecomment-616926839
Yeah I think we tried this and it hurt perf on sparse input, no? I'd have to
dig it out..
This is an automated message
AmplabJenkins commented on issue #28275:
URL: https://github.com/apache/spark/pull/28275#issuecomment-616925607
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
AmplabJenkins removed a comment on issue #28275:
URL: https://github.com/apache/spark/pull/28275#issuecomment-616925607
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
1 - 100 of 702 matches
Mail list logo