[GitHub] [spark] TJX2014 commented on a change in pull request #28534: [SPARK-31710][SQL] Adds TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS functions

2020-05-20 Thread GitBox
TJX2014 commented on a change in pull request #28534: URL: https://github.com/apache/spark/pull/28534#discussion_r428478287 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala ## @@ -424,6 +424,9 @@ object FunctionRegistry {

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28556: [SPARK-31736][SQL] Nested column aliasing for RepartitionByExpression/Join

2020-05-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28556: URL: https://github.com/apache/spark/pull/28556#issuecomment-631915587 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28556: [SPARK-31736][SQL] Nested column aliasing for RepartitionByExpression/Join

2020-05-20 Thread GitBox
AmplabJenkins commented on pull request #28556: URL: https://github.com/apache/spark/pull/28556#issuecomment-631915587 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] cloud-fan commented on a change in pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for join if applicable

2020-05-20 Thread GitBox
cloud-fan commented on a change in pull request #28123: URL: https://github.com/apache/spark/pull/28123#discussion_r428474929 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/bucketing/CoalesceBucketsInEquiJoin.scala ## @@ -0,0 +1,127 @@ +/* + * Licensed to

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28534: [SPARK-31710][SQL] Adds TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS functions

2020-05-20 Thread GitBox
HyukjinKwon commented on a change in pull request #28534: URL: https://github.com/apache/spark/pull/28534#discussion_r428474898 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala ## @@ -424,6 +424,9 @@ object FunctionRegistr

[GitHub] [spark] SparkQA commented on pull request #28556: [SPARK-31736][SQL] Nested column aliasing for RepartitionByExpression/Join

2020-05-20 Thread GitBox
SparkQA commented on pull request #28556: URL: https://github.com/apache/spark/pull/28556#issuecomment-631915185 **[Test build #122916 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122916/testReport)** for PR 28556 at commit [`b77a1ba`](https://github.com

[GitHub] [spark] viirya commented on a change in pull request #28556: [SPARK-31736][SQL] Nested column aliasing for RepartitionByExpression/Join

2020-05-20 Thread GitBox
viirya commented on a change in pull request #28556: URL: https://github.com/apache/spark/pull/28556#discussion_r428473655 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ## @@ -204,15 +211,8 @@ object GeneratorNeste

[GitHub] [spark] viirya commented on a change in pull request #28556: [SPARK-31736][SQL] Nested column aliasing for RepartitionByExpression/Join

2020-05-20 Thread GitBox
viirya commented on a change in pull request #28556: URL: https://github.com/apache/spark/pull/28556#discussion_r428473708 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala ## @@ -34,7 +34,8 @@ object NestedColumnAlias

[GitHub] [spark] GuoPhilipse commented on a change in pull request #28593: [SPARK-31710][SQL] Add two compatibility flag to cast long to timestamp

2020-05-20 Thread GitBox
GuoPhilipse commented on a change in pull request #28593: URL: https://github.com/apache/spark/pull/28593#discussion_r428473216 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala ## @@ -1277,7 +1285,11 @@ abstract class CastBase exte

[GitHub] [spark] cloud-fan commented on a change in pull request #28534: [SPARK-31710][SQL] Adds TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS functions

2020-05-20 Thread GitBox
cloud-fan commented on a change in pull request #28534: URL: https://github.com/apache/spark/pull/28534#discussion_r428472274 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala ## @@ -424,6 +424,9 @@ object FunctionRegistry

[GitHub] [spark] cloud-fan commented on a change in pull request #28534: [SPARK-31710][SQL] Adds TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS functions

2020-05-20 Thread GitBox
cloud-fan commented on a change in pull request #28534: URL: https://github.com/apache/spark/pull/28534#discussion_r428472315 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala ## @@ -424,6 +424,9 @@ object FunctionRegistry

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28534: [SPARK-31710][SQL] Adds TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS functions

2020-05-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-631909869 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28534: [SPARK-31710][SQL] Adds TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS functions

2020-05-20 Thread GitBox
AmplabJenkins commented on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-631909869 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28534: [SPARK-31710][SQL] Adds TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS functions

2020-05-20 Thread GitBox
SparkQA commented on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-631909451 **[Test build #122915 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122915/testReport)** for PR 28534 at commit [`97263e8`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28534: [SPARK-31710][SQL] Adds TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS functions

2020-05-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-631892624 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28534: [SPARK-31710][SQL] Adds TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS functions

2020-05-20 Thread GitBox
AmplabJenkins commented on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-631892624 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28534: [SPARK-31710][SQL] Adds TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS functions

2020-05-20 Thread GitBox
SparkQA commented on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-631892304 **[Test build #122913 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122913/testReport)** for PR 28534 at commit [`370bba7`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #28595: [SPARK-31781][ML][PySpark] Move param k (number of clusters) to shared params

2020-05-20 Thread GitBox
SparkQA commented on pull request #28595: URL: https://github.com/apache/spark/pull/28595#issuecomment-631892298 **[Test build #122914 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122914/testReport)** for PR 28595 at commit [`2d6e87b`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28595: [SPARK-31781][ML][PySpark] Move param k (number of clusters) to shared params

2020-05-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28595: URL: https://github.com/apache/spark/pull/28595#issuecomment-631890539 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28595: [SPARK-31781][ML][PySpark] Move param k (number of clusters) to shared params

2020-05-20 Thread GitBox
AmplabJenkins commented on pull request #28595: URL: https://github.com/apache/spark/pull/28595#issuecomment-631890539 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28534: [SPARK-31710][SQL] Adds TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS functions

2020-05-20 Thread GitBox
HyukjinKwon commented on a change in pull request #28534: URL: https://github.com/apache/spark/pull/28534#discussion_r42873 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala ## @@ -424,6 +424,9 @@ object FunctionRegistr

[GitHub] [spark] TJX2014 commented on a change in pull request #28534: [SPARK-31710][SQL] Adds TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS functions

2020-05-20 Thread GitBox
TJX2014 commented on a change in pull request #28534: URL: https://github.com/apache/spark/pull/28534#discussion_r428443365 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala ## @@ -424,6 +424,9 @@ object FunctionRegistry {

[GitHub] [spark] TJX2014 commented on a change in pull request #28534: [SPARK-31710][SQL] Adds TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS functions

2020-05-20 Thread GitBox
TJX2014 commented on a change in pull request #28534: URL: https://github.com/apache/spark/pull/28534#discussion_r428443365 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala ## @@ -424,6 +424,9 @@ object FunctionRegistry {

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28534: [SPARK-31710][SQL] Adds TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS functions

2020-05-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-631876701 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28534: [SPARK-31710][SQL] Adds TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS functions

2020-05-20 Thread GitBox
AmplabJenkins commented on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-631876701 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28534: [SPARK-31710][SQL] Adds TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS functions

2020-05-20 Thread GitBox
SparkQA commented on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-631876272 **[Test build #122912 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122912/testReport)** for PR 28534 at commit [`a6383a1`](https://github.com

[GitHub] [spark] cloud-fan commented on a change in pull request #28534: [SPARK-31710][SQL] Adds TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS functions

2020-05-20 Thread GitBox
cloud-fan commented on a change in pull request #28534: URL: https://github.com/apache/spark/pull/28534#discussion_r428439032 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala ## @@ -424,6 +424,9 @@ object FunctionRegistry

[GitHub] [spark] imback82 commented on pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for join if applicable

2020-05-20 Thread GitBox
imback82 commented on pull request #28123: URL: https://github.com/apache/spark/pull/28123#issuecomment-631869859 > 1. It's not possible to have an accurate cost model to guide this optimization. Do we have a heuristic? like coalescing 1 buckets to 2 is very likely to cause regression

[GitHub] [spark] cloud-fan commented on pull request #28523: [SPARK-31706][SQL] add back the support of streaming update mode

2020-05-20 Thread GitBox
cloud-fan commented on pull request #28523: URL: https://github.com/apache/spark/pull/28523#issuecomment-631869094 I thought you have canceled your veto in https://github.com/apache/spark/pull/28523#issuecomment-628164147 BTW, if someone leaves a veto, please be active to defend it.

[GitHub] [spark] imback82 commented on a change in pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for join if applicable

2020-05-20 Thread GitBox
imback82 commented on a change in pull request #28123: URL: https://github.com/apache/spark/pull/28123#discussion_r428435196 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/bucketing/CoalesceBucketsInEquiJoin.scala ## @@ -0,0 +1,127 @@ +/* + * Licensed to

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
HyukjinKwon commented on a change in pull request #28534: URL: https://github.com/apache/spark/pull/28534#discussion_r428433186 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -401,6 +401,81 @@ case class DayO

[GitHub] [spark] cloud-fan commented on pull request #28582: [SPARK-31762][SQL] Fix perf regression of date/timestamp formatting in toHiveString

2020-05-20 Thread GitBox
cloud-fan commented on pull request #28582: URL: https://github.com/apache/spark/pull/28582#issuecomment-631865472 thanks, merging to master/3.0! This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [spark] cloud-fan closed pull request #28582: [SPARK-31762][SQL] Fix perf regression of date/timestamp formatting in toHiveString

2020-05-20 Thread GitBox
cloud-fan closed pull request #28582: URL: https://github.com/apache/spark/pull/28582 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
HyukjinKwon commented on a change in pull request #28534: URL: https://github.com/apache/spark/pull/28534#discussion_r428431767 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala ## @@ -424,6 +424,9 @@ object FunctionRegistr

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
HyukjinKwon commented on a change in pull request #28534: URL: https://github.com/apache/spark/pull/28534#discussion_r428431767 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala ## @@ -424,6 +424,9 @@ object FunctionRegistr

[GitHub] [spark] HyukjinKwon commented on pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
HyukjinKwon commented on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-631862270 I would prefer this way over #28593. This is an automated message from the Apache Git Service. To respond t

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28593: [SPARK-31710][SQL] Add two compatibility flag to cast long to timestamp

2020-05-20 Thread GitBox
HyukjinKwon commented on a change in pull request #28593: URL: https://github.com/apache/spark/pull/28593#discussion_r428428811 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -2586,6 +2586,22 @@ object SQLConf { .checkValue(_

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28593: [SPARK-31710][SQL] Add two compatibility flag to cast long to timestamp

2020-05-20 Thread GitBox
HyukjinKwon commented on a change in pull request #28593: URL: https://github.com/apache/spark/pull/28593#discussion_r428428811 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -2586,6 +2586,22 @@ object SQLConf { .checkValue(_

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28593: [SPARK-31710][SQL] Add two compatibility flag to cast long to timestamp

2020-05-20 Thread GitBox
HyukjinKwon commented on a change in pull request #28593: URL: https://github.com/apache/spark/pull/28593#discussion_r428428811 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -2586,6 +2586,22 @@ object SQLConf { .checkValue(_

[GitHub] [spark] duanmeng commented on a change in pull request #28525: [SPARK-27562][Shuffle] Complete the verification mechanism for shuffle transmitted data

2020-05-20 Thread GitBox
duanmeng commented on a change in pull request #28525: URL: https://github.com/apache/spark/pull/28525#discussion_r428428247 ## File path: core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala ## @@ -626,16 +628,61 @@ final class ShuffleBlockFetcherIte

[GitHub] [spark] duanmeng commented on a change in pull request #28525: [SPARK-27562][Shuffle] Complete the verification mechanism for shuffle transmitted data

2020-05-20 Thread GitBox
duanmeng commented on a change in pull request #28525: URL: https://github.com/apache/spark/pull/28525#discussion_r428427803 ## File path: core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockResolver.scala ## @@ -170,11 +190,38 @@ private[spark] class IndexShuffleBlo

[GitHub] [spark] cloud-fan commented on a change in pull request #28128: [SPARK-31354] SparkContext only register one SparkSession ApplicationEnd listener

2020-05-20 Thread GitBox
cloud-fan commented on a change in pull request #28128: URL: https://github.com/apache/spark/pull/28128#discussion_r428427640 ## File path: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala ## @@ -1064,6 +1055,20 @@ object SparkSession extends Logging { // Priv

[GitHub] [spark] WeichenXu123 commented on pull request #28584: [SPARK-31730][CORE][TEST] Fix flaky tests in BarrierTaskContextSuite

2020-05-20 Thread GitBox
WeichenXu123 commented on pull request #28584: URL: https://github.com/apache/spark/pull/28584#issuecomment-631859882 Also fix this test like: ``` test("share messages with allGather() call") { val conf = new SparkConf() .setMaster("local-cluster[4, 1, 1024]")

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28593: [SPARK-31710][SQL] Add two compatibility flag to cast long to timestamp

2020-05-20 Thread GitBox
HyukjinKwon commented on a change in pull request #28593: URL: https://github.com/apache/spark/pull/28593#discussion_r428422910 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala ## @@ -1277,7 +1285,11 @@ abstract class CastBase exte

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test

2020-05-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28594: URL: https://github.com/apache/spark/pull/28594#issuecomment-631851933 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test

2020-05-20 Thread GitBox
AmplabJenkins commented on pull request #28594: URL: https://github.com/apache/spark/pull/28594#issuecomment-631851933 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test

2020-05-20 Thread GitBox
SparkQA removed a comment on pull request #28594: URL: https://github.com/apache/spark/pull/28594#issuecomment-631804956 **[Test build #122908 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122908/testReport)** for PR 28594 at commit [`0a37e82`](https://gi

[GitHub] [spark] Ngone51 commented on pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

2020-05-20 Thread GitBox
Ngone51 commented on pull request #28572: URL: https://github.com/apache/spark/pull/28572#issuecomment-631851718 thanks all! This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [spark] SparkQA commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test

2020-05-20 Thread GitBox
SparkQA commented on pull request #28594: URL: https://github.com/apache/spark/pull/28594#issuecomment-631851365 **[Test build #122908 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122908/testReport)** for PR 28594 at commit [`0a37e82`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28593: [SPARK-31710][SQL] Add two compatibility flag to cast long to timestamp

2020-05-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-631848306 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28593: [SPARK-31710][SQL] Add two compatibility flag to cast long to timestamp

2020-05-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-631848296 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #28593: [SPARK-31710][SQL] Add two compatibility flag to cast long to timestamp

2020-05-20 Thread GitBox
AmplabJenkins commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-631848296 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #28593: [SPARK-31710][SQL] Add two compatibility flag to cast long to timestamp

2020-05-20 Thread GitBox
SparkQA removed a comment on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-631815642 **[Test build #122910 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122910/testReport)** for PR 28593 at commit [`7f0ba76`](https://gi

[GitHub] [spark] SparkQA commented on pull request #28593: [SPARK-31710][SQL] Add two compatibility flag to cast long to timestamp

2020-05-20 Thread GitBox
SparkQA commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-631848096 **[Test build #122910 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122910/testReport)** for PR 28593 at commit [`7f0ba76`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test

2020-05-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28594: URL: https://github.com/apache/spark/pull/28594#issuecomment-631836881 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test

2020-05-20 Thread GitBox
AmplabJenkins commented on pull request #28594: URL: https://github.com/apache/spark/pull/28594#issuecomment-631836881 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test

2020-05-20 Thread GitBox
SparkQA removed a comment on pull request #28594: URL: https://github.com/apache/spark/pull/28594#issuecomment-631791158 **[Test build #122907 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122907/testReport)** for PR 28594 at commit [`a26fb26`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28595: [SPARK-31781][ML][PySpark] Move param k (number of clusters) to shared params

2020-05-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28595: URL: https://github.com/apache/spark/pull/28595#issuecomment-631836062 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122

[GitHub] [spark] SparkQA commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test

2020-05-20 Thread GitBox
SparkQA commented on pull request #28594: URL: https://github.com/apache/spark/pull/28594#issuecomment-631836233 **[Test build #122907 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122907/testReport)** for PR 28594 at commit [`a26fb26`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28595: [SPARK-31781][ML][PySpark] Move param k (number of clusters) to shared params

2020-05-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28595: URL: https://github.com/apache/spark/pull/28595#issuecomment-631836059 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA commented on pull request #28595: [SPARK-31781][ML][PySpark] Move param k (number of clusters) to shared params

2020-05-20 Thread GitBox
SparkQA commented on pull request #28595: URL: https://github.com/apache/spark/pull/28595#issuecomment-631836040 **[Test build #122911 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122911/testReport)** for PR 28595 at commit [`d259e5e`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #28595: [SPARK-31781][ML][PySpark] Move param k (number of clusters) to shared params

2020-05-20 Thread GitBox
SparkQA removed a comment on pull request #28595: URL: https://github.com/apache/spark/pull/28595#issuecomment-631833038 **[Test build #122911 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122911/testReport)** for PR 28595 at commit [`d259e5e`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #28595: [SPARK-31781][ML][PySpark] Move param k (number of clusters) to shared params

2020-05-20 Thread GitBox
AmplabJenkins commented on pull request #28595: URL: https://github.com/apache/spark/pull/28595#issuecomment-631836059 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28595: [SPARK-31781][ML][PySpark] Move param k (number of clusters) to shared params

2020-05-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28595: URL: https://github.com/apache/spark/pull/28595#issuecomment-631833284 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28595: [SPARK-31781][ML][PySpark] Move param k (number of clusters) to shared params

2020-05-20 Thread GitBox
AmplabJenkins commented on pull request #28595: URL: https://github.com/apache/spark/pull/28595#issuecomment-631833284 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28595: [SPARK-31781][ML][PySpark] Move param k (number of clusters) to shared params

2020-05-20 Thread GitBox
SparkQA commented on pull request #28595: URL: https://github.com/apache/spark/pull/28595#issuecomment-631833038 **[Test build #122911 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122911/testReport)** for PR 28595 at commit [`d259e5e`](https://github.com

[GitHub] [spark] huaxingao opened a new pull request #28595: [SPARK-31781][ML][PySpark] Move param k (number of clusters) to shared params

2020-05-20 Thread GitBox
huaxingao opened a new pull request #28595: URL: https://github.com/apache/spark/pull/28595 ### What changes were proposed in this pull request? Param k (number of clusters) is used for all the clustering algorithms, so move it to shared params. ### Why are the changes nee

[GitHub] [spark] dongjoon-hyun closed pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test

2020-05-20 Thread GitBox
dongjoon-hyun closed pull request #28594: URL: https://github.com/apache/spark/pull/28594 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] dbtsai commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test

2020-05-20 Thread GitBox
dbtsai commented on pull request #28594: URL: https://github.com/apache/spark/pull/28594#issuecomment-631825289 LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test

2020-05-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28594: URL: https://github.com/apache/spark/pull/28594#issuecomment-631824322 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test

2020-05-20 Thread GitBox
SparkQA commented on pull request #28594: URL: https://github.com/apache/spark/pull/28594#issuecomment-631824311 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/27551/ ---

[GitHub] [spark] AmplabJenkins commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test

2020-05-20 Thread GitBox
AmplabJenkins commented on pull request #28594: URL: https://github.com/apache/spark/pull/28594#issuecomment-631824322 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] dongjoon-hyun commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test

2020-05-20 Thread GitBox
dongjoon-hyun commented on pull request #28594: URL: https://github.com/apache/spark/pull/28594#issuecomment-631817059 Hi, @dbtsai . Could you review this PR? This is an automated message from the Apache Git Service. To re

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28593: [SPARK-31710][SQL] Add two compatibility flag to cast long to timestamp

2020-05-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-631816007 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28593: [SPARK-31710][SQL] Add two compatibility flag to cast long to timestamp

2020-05-20 Thread GitBox
AmplabJenkins commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-631816007 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test

2020-05-20 Thread GitBox
SparkQA commented on pull request #28594: URL: https://github.com/apache/spark/pull/28594#issuecomment-631816084 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/27551/ -

[GitHub] [spark] SparkQA commented on pull request #28593: [SPARK-31710][SQL] Add two compatibility flag to cast long to timestamp

2020-05-20 Thread GitBox
SparkQA commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-631815642 **[Test build #122910 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122910/testReport)** for PR 28593 at commit [`7f0ba76`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28593: [SPARK-31710][SQL] Add two compatibility flag to cast long to timestamp

2020-05-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-631810838 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122

[GitHub] [spark] SparkQA removed a comment on pull request #28593: [SPARK-31710][SQL] Add two compatibility flag to cast long to timestamp

2020-05-20 Thread GitBox
SparkQA removed a comment on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-631809545 **[Test build #122909 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122909/testReport)** for PR 28593 at commit [`a39067d`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28593: [SPARK-31710][SQL] Add two compatibility flag to cast long to timestamp

2020-05-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-631810835 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA commented on pull request #28593: [SPARK-31710][SQL] Add two compatibility flag to cast long to timestamp

2020-05-20 Thread GitBox
SparkQA commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-631810824 **[Test build #122909 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122909/testReport)** for PR 28593 at commit [`a39067d`](https://github.co

[GitHub] [spark] AmplabJenkins commented on pull request #28593: [SPARK-31710][SQL] Add two compatibility flag to cast long to timestamp

2020-05-20 Thread GitBox
AmplabJenkins commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-631810835 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #28593: [SPARK-31710][SQL] Add two compatibility flag to cast long to timestamp

2020-05-20 Thread GitBox
AmplabJenkins commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-631810012 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28593: [SPARK-31710][SQL] Add two compatibility flag to cast long to timestamp

2020-05-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-631810012 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28593: [SPARK-31710][SQL] Add two compatibility flag to cast long to timestamp

2020-05-20 Thread GitBox
SparkQA commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-631809545 **[Test build #122909 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122909/testReport)** for PR 28593 at commit [`a39067d`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test

2020-05-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28594: URL: https://github.com/apache/spark/pull/28594#issuecomment-631804786 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test

2020-05-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28594: URL: https://github.com/apache/spark/pull/28594#issuecomment-631804784 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test

2020-05-20 Thread GitBox
SparkQA commented on pull request #28594: URL: https://github.com/apache/spark/pull/28594#issuecomment-631804956 **[Test build #122908 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122908/testReport)** for PR 28594 at commit [`0a37e82`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test

2020-05-20 Thread GitBox
SparkQA commented on pull request #28594: URL: https://github.com/apache/spark/pull/28594#issuecomment-631804775 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/27550/ ---

[GitHub] [spark] AmplabJenkins commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test

2020-05-20 Thread GitBox
AmplabJenkins commented on pull request #28594: URL: https://github.com/apache/spark/pull/28594#issuecomment-631804784 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] github-actions[bot] commented on pull request #27436: [SPARK-30705][SQL] Improve CaseWhen sub-expression equality

2020-05-20 Thread GitBox
github-actions[bot] commented on pull request #27436: URL: https://github.com/apache/spark/pull/27436#issuecomment-631803512 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue ma

[GitHub] [spark] github-actions[bot] commented on pull request #27231: [SPARK-28478][SQL] Remove redundant null checks

2020-05-20 Thread GitBox
github-actions[bot] commented on pull request #27231: URL: https://github.com/apache/spark/pull/27231#issuecomment-631803519 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue ma

[GitHub] [spark] SparkQA commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test

2020-05-20 Thread GitBox
SparkQA commented on pull request #28594: URL: https://github.com/apache/spark/pull/28594#issuecomment-631803216 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/27550/ -

[GitHub] [spark] HeartSaVioR commented on a change in pull request #28363: [SPARK-27188][SS] FileStreamSink: provide a new option to have retention on output files

2020-05-20 Thread GitBox
HeartSaVioR commented on a change in pull request #28363: URL: https://github.com/apache/spark/pull/28363#discussion_r428373935 ## File path: docs/structured-streaming-programming-guide.md ## @@ -1860,7 +1860,10 @@ Here are the details of all the sinks in Spark. File Sink

[GitHub] [spark] HeartSaVioR commented on a change in pull request #28363: [SPARK-27188][SS] FileStreamSink: provide a new option to have retention on output files

2020-05-20 Thread GitBox
HeartSaVioR commented on a change in pull request #28363: URL: https://github.com/apache/spark/pull/28363#discussion_r428372910 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSinkLog.scala ## @@ -45,7 +46,20 @@ case class SinkFileStatu

[GitHub] [spark] SparkQA commented on pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test

2020-05-20 Thread GitBox
SparkQA commented on pull request #28594: URL: https://github.com/apache/spark/pull/28594#issuecomment-631791158 **[Test build #122907 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122907/testReport)** for PR 28594 at commit [`a26fb26`](https://github.com

[GitHub] [spark] dongjoon-hyun opened a new pull request #28594: [SPARK-31780][K8S][TESTS] Add R test tag to exclude R K8s image building and test

2020-05-20 Thread GitBox
dongjoon-hyun opened a new pull request #28594: URL: https://github.com/apache/spark/pull/28594 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How was t

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28593: [SPARK-31710][SQL] Add two compatibility flag to cast long to timestamp

2020-05-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-631785210 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122

[GitHub] [spark] SparkQA removed a comment on pull request #28593: [SPARK-31710][SQL] Add two compatibility flag to cast long to timestamp

2020-05-20 Thread GitBox
SparkQA removed a comment on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-631783497 **[Test build #122906 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122906/testReport)** for PR 28593 at commit [`4577fa8`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28128: [SPARK-31354] SparkContext only register one SparkSession ApplicationEnd listener

2020-05-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28128: URL: https://github.com/apache/spark/pull/28128#issuecomment-631785345 This is an automated message from the Apache Git Service. To respond to the message, please log on

  1   2   3   4   5   >