cloud-fan commented on a change in pull request #28592:
URL: https://github.com/apache/spark/pull/28592#discussion_r428615629
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateFormatter.scala
##
@@ -40,7 +43,23 @@ class Iso8601DateFormatter(
AmplabJenkins removed a comment on pull request #28534:
URL: https://github.com/apache/spark/pull/28534#issuecomment-632052714
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
cloud-fan commented on a change in pull request #28598:
URL: https://github.com/apache/spark/pull/28598#discussion_r428614900
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetTest.scala
##
@@ -162,4 +162,36 @@ private[sql] trait
AmplabJenkins commented on pull request #28534:
URL: https://github.com/apache/spark/pull/28534#issuecomment-632052702
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #28534:
URL: https://github.com/apache/spark/pull/28534#issuecomment-632052702
Merged build finished. Test PASSed.
This is an automated message from the Apache Git Service.
To
SparkQA removed a comment on pull request #28534:
URL: https://github.com/apache/spark/pull/28534#issuecomment-631930528
**[Test build #122918 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122918/testReport)**
for PR 28534 at commit
SparkQA commented on pull request #28534:
URL: https://github.com/apache/spark/pull/28534#issuecomment-632052069
**[Test build #122918 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122918/testReport)**
for PR 28534 at commit
AmplabJenkins removed a comment on pull request #28576:
URL: https://github.com/apache/spark/pull/28576#issuecomment-632051500
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #28576:
URL: https://github.com/apache/spark/pull/28576#issuecomment-632051493
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
SparkQA removed a comment on pull request #28576:
URL: https://github.com/apache/spark/pull/28576#issuecomment-631989880
**[Test build #122923 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122923/testReport)**
for PR 28576 at commit
AmplabJenkins commented on pull request #28576:
URL: https://github.com/apache/spark/pull/28576#issuecomment-632051493
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28576:
URL: https://github.com/apache/spark/pull/28576#issuecomment-632051200
**[Test build #122923 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122923/testReport)**
for PR 28576 at commit
cloud-fan commented on pull request #28534:
URL: https://github.com/apache/spark/pull/28534#issuecomment-632049705
Let's also add some UT in `DateExpressionsSuite`, which can test both
codegen and interpreted code path.
AmplabJenkins removed a comment on pull request #28556:
URL: https://github.com/apache/spark/pull/28556#issuecomment-632046933
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28556:
URL: https://github.com/apache/spark/pull/28556#issuecomment-632046933
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #28598:
URL: https://github.com/apache/spark/pull/28598#issuecomment-632046310
This is an automated message from the Apache Git Service.
To respond to the message, please log on
cloud-fan commented on a change in pull request #28534:
URL: https://github.com/apache/spark/pull/28534#discussion_r428607554
##
File path: sql/core/src/test/resources/sql-tests/results/ansi/datetime.sql.out
##
@@ -1,5 +1,65 @@
-- Automatically generated by SQLQueryTestSuite
SparkQA removed a comment on pull request #28556:
URL: https://github.com/apache/spark/pull/28556#issuecomment-631923918
**[Test build #122917 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122917/testReport)**
for PR 28556 at commit
AmplabJenkins commented on pull request #28598:
URL: https://github.com/apache/spark/pull/28598#issuecomment-632046310
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28556:
URL: https://github.com/apache/spark/pull/28556#issuecomment-632046065
**[Test build #122917 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122917/testReport)**
for PR 28556 at commit
yaooqinn commented on a change in pull request #28592:
URL: https://github.com/apache/spark/pull/28592#discussion_r428607225
##
File path: sql/core/src/test/resources/sql-tests/inputs/datetime-corrected.sql
##
@@ -0,0 +1,2 @@
+--SET spark.sql.legacy.timeParserPolicy=CORRECTED
cloud-fan commented on a change in pull request #28534:
URL: https://github.com/apache/spark/pull/28534#discussion_r428606868
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##
@@ -401,6 +401,83 @@ case class
SparkQA commented on pull request #28598:
URL: https://github.com/apache/spark/pull/28598#issuecomment-632045706
**[Test build #122930 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122930/testReport)**
for PR 28598 at commit
cloud-fan commented on a change in pull request #28592:
URL: https://github.com/apache/spark/pull/28592#discussion_r428605898
##
File path: sql/core/src/test/resources/sql-tests/inputs/datetime-corrected.sql
##
@@ -0,0 +1,2 @@
+--SET spark.sql.legacy.timeParserPolicy=CORRECTED
yaooqinn commented on a change in pull request #28592:
URL: https://github.com/apache/spark/pull/28592#discussion_r428606030
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateFormatter.scala
##
@@ -40,7 +43,23 @@ class Iso8601DateFormatter(
MaxGekk commented on pull request #28598:
URL: https://github.com/apache/spark/pull/28598#issuecomment-632043745
@cloud-fan @mswit-databricks @adrian-ionescu Please, review this PR.
This is an automated message from the
yaooqinn commented on a change in pull request #28592:
URL: https://github.com/apache/spark/pull/28592#discussion_r428604890
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateFormatter.scala
##
@@ -77,14 +96,14 @@ trait LegacyDateFormatter
MaxGekk opened a new pull request #28598:
URL: https://github.com/apache/spark/pull/28598
### What changes were proposed in this pull request?
Add `withAllParquetReaders` to `ParquetTest`. The function allow to run a
block of code for all available Parquet readers.
### Why are
cloud-fan commented on a change in pull request #28592:
URL: https://github.com/apache/spark/pull/28592#discussion_r428604480
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/TimestampFormatter.scala
##
@@ -61,8 +64,23 @@ class
cloud-fan commented on a change in pull request #28592:
URL: https://github.com/apache/spark/pull/28592#discussion_r428603874
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateFormatter.scala
##
@@ -77,14 +96,14 @@ trait LegacyDateFormatter
AmplabJenkins removed a comment on pull request #28128:
URL: https://github.com/apache/spark/pull/28128#issuecomment-632039530
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28128:
URL: https://github.com/apache/spark/pull/28128#issuecomment-632039530
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28128:
URL: https://github.com/apache/spark/pull/28128#issuecomment-632038999
**[Test build #122929 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122929/testReport)**
for PR 28128 at commit
vinooganesh commented on a change in pull request #28128:
URL: https://github.com/apache/spark/pull/28128#discussion_r428599620
##
File path: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
##
@@ -1064,6 +1055,20 @@ object SparkSession extends Logging {
//
cloud-fan edited a comment on pull request #28523:
URL: https://github.com/apache/spark/pull/28523#issuecomment-631869094
I thought you have canceled your veto in
https://github.com/apache/spark/pull/28523#issuecomment-628164147 , as what you
agreed on is exactly what this PR is doing.
AmplabJenkins commented on pull request #28592:
URL: https://github.com/apache/spark/pull/28592#issuecomment-632033075
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #28592:
URL: https://github.com/apache/spark/pull/28592#issuecomment-632033075
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #28592:
URL: https://github.com/apache/spark/pull/28592#issuecomment-632032488
**[Test build #122928 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122928/testReport)**
for PR 28592 at commit
AmplabJenkins removed a comment on pull request #28596:
URL: https://github.com/apache/spark/pull/28596#issuecomment-632027308
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28596:
URL: https://github.com/apache/spark/pull/28596#issuecomment-632027308
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #28596:
URL: https://github.com/apache/spark/pull/28596#issuecomment-631955215
**[Test build #122920 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122920/testReport)**
for PR 28596 at commit
SparkQA commented on pull request #28596:
URL: https://github.com/apache/spark/pull/28596#issuecomment-632026359
**[Test build #122920 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122920/testReport)**
for PR 28596 at commit
AmplabJenkins removed a comment on pull request #28592:
URL: https://github.com/apache/spark/pull/28592#issuecomment-632021186
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #28592:
URL: https://github.com/apache/spark/pull/28592#issuecomment-632021179
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
SparkQA removed a comment on pull request #28592:
URL: https://github.com/apache/spark/pull/28592#issuecomment-632013240
**[Test build #122926 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122926/testReport)**
for PR 28592 at commit
SparkQA commented on pull request #28592:
URL: https://github.com/apache/spark/pull/28592#issuecomment-632021131
**[Test build #122926 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122926/testReport)**
for PR 28592 at commit
AmplabJenkins commented on pull request #28592:
URL: https://github.com/apache/spark/pull/28592#issuecomment-632021179
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
sarutak commented on a change in pull request #28585:
URL: https://github.com/apache/spark/pull/28585#discussion_r428578312
##
File path: core/src/test/scala/org/apache/spark/ui/UISeleniumSuite.scala
##
@@ -784,6 +784,7 @@ class UISeleniumSuite extends SparkFunSuite with
AmplabJenkins removed a comment on pull request #28583:
URL: https://github.com/apache/spark/pull/28583#issuecomment-632017229
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28583:
URL: https://github.com/apache/spark/pull/28583#issuecomment-632017229
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
sarutak commented on a change in pull request #28585:
URL: https://github.com/apache/spark/pull/28585#discussion_r428578312
##
File path: core/src/test/scala/org/apache/spark/ui/UISeleniumSuite.scala
##
@@ -784,6 +784,7 @@ class UISeleniumSuite extends SparkFunSuite with
SparkQA commented on pull request #28583:
URL: https://github.com/apache/spark/pull/28583#issuecomment-632016717
**[Test build #122927 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122927/testReport)**
for PR 28583 at commit
AmplabJenkins commented on pull request #28592:
URL: https://github.com/apache/spark/pull/28592#issuecomment-632013979
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #28592:
URL: https://github.com/apache/spark/pull/28592#issuecomment-632013979
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #28592:
URL: https://github.com/apache/spark/pull/28592#issuecomment-632013240
**[Test build #122926 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122926/testReport)**
for PR 28592 at commit
AmplabJenkins removed a comment on pull request #28592:
URL: https://github.com/apache/spark/pull/28592#issuecomment-632010389
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28592:
URL: https://github.com/apache/spark/pull/28592#issuecomment-632010389
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #28597:
URL: https://github.com/apache/spark/pull/28597#issuecomment-632006364
Can one of the admins verify this patch?
This is an automated message from the Apache Git
AmplabJenkins commented on pull request #28597:
URL: https://github.com/apache/spark/pull/28597#issuecomment-632006901
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
To
AmplabJenkins commented on pull request #28597:
URL: https://github.com/apache/spark/pull/28597#issuecomment-632006364
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
To
AmplabJenkins removed a comment on pull request #28583:
URL: https://github.com/apache/spark/pull/28583#issuecomment-632004289
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #28583:
URL: https://github.com/apache/spark/pull/28583#issuecomment-632004284
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
SparkQA removed a comment on pull request #28583:
URL: https://github.com/apache/spark/pull/28583#issuecomment-631947436
**[Test build #122919 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122919/testReport)**
for PR 28583 at commit
AmplabJenkins commented on pull request #28583:
URL: https://github.com/apache/spark/pull/28583#issuecomment-632004284
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
1040979575 opened a new pull request #28597:
URL: https://github.com/apache/spark/pull/28597
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How
SparkQA commented on pull request #28583:
URL: https://github.com/apache/spark/pull/28583#issuecomment-632003894
**[Test build #122919 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122919/testReport)**
for PR 28583 at commit
akshatb1 commented on pull request #28258:
URL: https://github.com/apache/spark/pull/28258#issuecomment-632003872
@Ngone51 @jiangxb1987 Gentle ping, I have addressed your comments. Please
review when you get a chance. Thanks.
cfmcgrady commented on a change in pull request #23900:
URL: https://github.com/apache/spark/pull/23900#discussion_r428563913
##
File path: python/pyspark/sql/types.py
##
@@ -1616,6 +1616,12 @@ def to_arrow_type(dt):
if type(dt.elementType) == TimestampType:
AmplabJenkins removed a comment on pull request #28525:
URL: https://github.com/apache/spark/pull/28525#issuecomment-632000589
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
AmplabJenkins removed a comment on pull request #28525:
URL: https://github.com/apache/spark/pull/28525#issuecomment-632000580
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
SparkQA removed a comment on pull request #28525:
URL: https://github.com/apache/spark/pull/28525#issuecomment-631999704
**[Test build #122925 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122925/testReport)**
for PR 28525 at commit
SparkQA commented on pull request #28525:
URL: https://github.com/apache/spark/pull/28525#issuecomment-632000568
**[Test build #122925 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122925/testReport)**
for PR 28525 at commit
AmplabJenkins commented on pull request #28525:
URL: https://github.com/apache/spark/pull/28525#issuecomment-632000580
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28525:
URL: https://github.com/apache/spark/pull/28525#issuecomment-631999704
**[Test build #122925 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122925/testReport)**
for PR 28525 at commit
AmplabJenkins removed a comment on pull request #28525:
URL: https://github.com/apache/spark/pull/28525#issuecomment-631997557
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
SparkQA removed a comment on pull request #28525:
URL: https://github.com/apache/spark/pull/28525#issuecomment-631996474
**[Test build #122924 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122924/testReport)**
for PR 28525 at commit
AmplabJenkins removed a comment on pull request #28525:
URL: https://github.com/apache/spark/pull/28525#issuecomment-631997545
Merged build finished. Test FAILed.
This is an automated message from the Apache Git Service.
To
AmplabJenkins commented on pull request #28525:
URL: https://github.com/apache/spark/pull/28525#issuecomment-631997545
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28525:
URL: https://github.com/apache/spark/pull/28525#issuecomment-631997529
**[Test build #122924 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122924/testReport)**
for PR 28525 at commit
AmplabJenkins removed a comment on pull request #28525:
URL: https://github.com/apache/spark/pull/28525#issuecomment-631996898
This is an automated message from the Apache Git Service.
To respond to the message, please log on
turboFei commented on pull request #28525:
URL: https://github.com/apache/spark/pull/28525#issuecomment-631996915
Thanks for the review. I have modified the solution and save the digests
into independent file.
This is an
AmplabJenkins commented on pull request #28525:
URL: https://github.com/apache/spark/pull/28525#issuecomment-631996898
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
HyukjinKwon commented on pull request #28578:
URL: https://github.com/apache/spark/pull/28578#issuecomment-631996385
cc @gengliangwang FYI. Looks fine to me too
This is an automated message from the Apache Git Service.
To
HyukjinKwon commented on pull request #28585:
URL: https://github.com/apache/spark/pull/28585#issuecomment-631996492
cc @gengliangwang too FYI. seems okay to me too
This is an automated message from the Apache Git Service.
SparkQA commented on pull request #28525:
URL: https://github.com/apache/spark/pull/28525#issuecomment-631996474
**[Test build #122924 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122924/testReport)**
for PR 28525 at commit
turboFei commented on a change in pull request #28525:
URL: https://github.com/apache/spark/pull/28525#discussion_r428555017
##
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ShuffleIndexInformation.java
##
@@ -31,17 +34,44 @@
public class
TJX2014 commented on a change in pull request #28534:
URL: https://github.com/apache/spark/pull/28534#discussion_r428553501
##
File path: sql/core/src/test/resources/sql-tests/results/ansi/datetime.sql.out
##
@@ -1,5 +1,65 @@
-- Automatically generated by SQLQueryTestSuite
AmplabJenkins removed a comment on pull request #28576:
URL: https://github.com/apache/spark/pull/28576#issuecomment-631990533
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28576:
URL: https://github.com/apache/spark/pull/28576#issuecomment-631990533
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28576:
URL: https://github.com/apache/spark/pull/28576#issuecomment-631989880
**[Test build #122923 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122923/testReport)**
for PR 28576 at commit
HyukjinKwon commented on a change in pull request #28593:
URL: https://github.com/apache/spark/pull/28593#discussion_r428543986
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##
@@ -2586,6 +2586,22 @@ object SQLConf {
GuoPhilipse commented on a change in pull request #28593:
URL: https://github.com/apache/spark/pull/28593#discussion_r428529561
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##
@@ -2586,6 +2586,22 @@ object SQLConf {
SparkQA commented on pull request #28556:
URL: https://github.com/apache/spark/pull/28556#issuecomment-631965191
**[Test build #122922 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122922/testReport)**
for PR 28556 at commit
zhengruifeng commented on pull request #28595:
URL: https://github.com/apache/spark/pull/28595#issuecomment-631964130
Param `k` is also used in `RankingEvaluator` and `ALS`, is it reasonable to
reuse this shared param in them?
zhengruifeng commented on pull request #28590:
URL: https://github.com/apache/spark/pull/28590#issuecomment-631962737
I do not object this PR. Is there any way to recompute another metric in
evaluator without involving mllib.metrics?
AmplabJenkins removed a comment on pull request #28556:
URL: https://github.com/apache/spark/pull/28556#issuecomment-631962223
This is an automated message from the Apache Git Service.
To respond to the message, please log on
viirya commented on pull request #28556:
URL: https://github.com/apache/spark/pull/28556#issuecomment-631962148
@maropu I addressed your comments. Could you help take another look? Thanks.
This is an automated message from
AmplabJenkins commented on pull request #28556:
URL: https://github.com/apache/spark/pull/28556#issuecomment-631962223
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
viirya commented on a change in pull request #28556:
URL: https://github.com/apache/spark/pull/28556#discussion_r428520430
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala
##
@@ -82,6 +87,8 @@ object
sarutak commented on a change in pull request #28578:
URL: https://github.com/apache/spark/pull/28578#discussion_r427076227
##
File path: dev/run-tests.py
##
@@ -606,6 +609,8 @@ def main():
print("[info] Found the following changed modules:",
", ".join(x.name
401 - 500 of 558 matches
Mail list logo