[GitHub] [spark] SparkQA commented on pull request #28831: [SPARK-31993][SQL] Build arrays for passing variables generated from children for 'concat_ws' with columns having at least one of array type

2020-06-18 Thread GitBox
SparkQA commented on pull request #28831: URL: https://github.com/apache/spark/pull/28831#issuecomment-646451372 **[Test build #124242 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124242/testReport)** for PR 28831 at commit

[GitHub] [spark] cloud-fan commented on pull request #28835: [SPARK-31926][SQL][TESTS][FOLLOWUP][test-hive1.2][test-maven] Fix concurrency issue for ThriftCLIService to getPortNumber

2020-06-18 Thread GitBox
cloud-fan commented on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-646451325 thanks, merging to master! (don't backport as it's not a test only PR anymore) This is an automated message

[GitHub] [spark] beliefer commented on pull request #27428: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

2020-06-18 Thread GitBox
beliefer commented on pull request #27428: URL: https://github.com/apache/spark/pull/27428#issuecomment-646451298 cc @cloud-fan This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] ulysses-you opened a new pull request #28868: [SPARK-32029][SQL] Make activeSession null when application end

2020-06-18 Thread GitBox
ulysses-you opened a new pull request #28868: URL: https://github.com/apache/spark/pull/28868 ### What changes were proposed in this pull request? Make active session null when application is end. And add spark context check in `spark.withActive()` ### Why are the

[GitHub] [spark] cloud-fan closed pull request #28707: [SPARK-31894][SS] Introduce UnsafeRow format validation for streaming state store

2020-06-18 Thread GitBox
cloud-fan closed pull request #28707: URL: https://github.com/apache/spark/pull/28707 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] cloud-fan commented on pull request #28707: [SPARK-31894][SS] Introduce UnsafeRow format validation for streaming state store

2020-06-18 Thread GitBox
cloud-fan commented on pull request #28707: URL: https://github.com/apache/spark/pull/28707#issuecomment-646450708 thanks, merging to master! (I think this patch is too big to backport) This is an automated message from the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28841: [SPARK-31962][SQL] Provide option to load files after a specified date when reading from a folder path

2020-06-18 Thread GitBox
AmplabJenkins removed a comment on pull request #28841: URL: https://github.com/apache/spark/pull/28841#issuecomment-646447834 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28841: [SPARK-31962][SQL] Provide option to load files after a specified date when reading from a folder path

2020-06-18 Thread GitBox
AmplabJenkins removed a comment on pull request #28841: URL: https://github.com/apache/spark/pull/28841#issuecomment-646447828 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28841: [SPARK-31962][SQL] Provide option to load files after a specified date when reading from a folder path

2020-06-18 Thread GitBox
AmplabJenkins commented on pull request #28841: URL: https://github.com/apache/spark/pull/28841#issuecomment-646447828 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28835: [SPARK-31926][SQL][TESTS][FOLLOWUP][test-hive1.2][test-maven] Fix concurrency issue for ThriftCLIService to getPortNumber

2020-06-18 Thread GitBox
AmplabJenkins removed a comment on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-646447496 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #28841: [SPARK-31962][SQL] Provide option to load files after a specified date when reading from a folder path

2020-06-18 Thread GitBox
SparkQA removed a comment on pull request #28841: URL: https://github.com/apache/spark/pull/28841#issuecomment-646396659 **[Test build #124247 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124247/testReport)** for PR 28841 at commit

[GitHub] [spark] SparkQA commented on pull request #28841: [SPARK-31962][SQL] Provide option to load files after a specified date when reading from a folder path

2020-06-18 Thread GitBox
SparkQA commented on pull request #28841: URL: https://github.com/apache/spark/pull/28841#issuecomment-646447622 **[Test build #124247 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124247/testReport)** for PR 28841 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28835: [SPARK-31926][SQL][TESTS][FOLLOWUP][test-hive1.2][test-maven] Fix concurrency issue for ThriftCLIService to getPortNumber

2020-06-18 Thread GitBox
AmplabJenkins commented on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-646447496 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28835: [SPARK-31926][SQL][TESTS][FOLLOWUP][test-hive1.2][test-maven] Fix concurrency issue for ThriftCLIService to getPortNumber

2020-06-18 Thread GitBox
SparkQA removed a comment on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-646400501 **[Test build #124249 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124249/testReport)** for PR 28835 at commit

[GitHub] [spark] SparkQA commented on pull request #28835: [SPARK-31926][SQL][TESTS][FOLLOWUP][test-hive1.2][test-maven] Fix concurrency issue for ThriftCLIService to getPortNumber

2020-06-18 Thread GitBox
SparkQA commented on pull request #28835: URL: https://github.com/apache/spark/pull/28835#issuecomment-646446486 **[Test build #124249 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124249/testReport)** for PR 28835 at commit

[GitHub] [spark] cloud-fan closed pull request #27617: [SPARK-30865][SQL][SS] Refactor DateTimeUtils

2020-06-18 Thread GitBox
cloud-fan closed pull request #27617: URL: https://github.com/apache/spark/pull/27617 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] cloud-fan commented on pull request #27617: [SPARK-30865][SQL][SS] Refactor DateTimeUtils

2020-06-18 Thread GitBox
cloud-fan commented on pull request #27617: URL: https://github.com/apache/spark/pull/27617#issuecomment-646446303 thanks, merging to master! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28831: [SPARK-31993][SQL] Build arrays for passing variables generated from children for 'concat_ws' with columns having at least one

2020-06-18 Thread GitBox
AmplabJenkins removed a comment on pull request #28831: URL: https://github.com/apache/spark/pull/28831#issuecomment-646445485 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AngersZhuuuu commented on pull request #28805: [SPARK-28169][SQL] Convert scan predicate condition to CNF

2020-06-18 Thread GitBox
AngersZh commented on pull request #28805: URL: https://github.com/apache/spark/pull/28805#issuecomment-646445716 > The CNF process should break down `dt = 20190626 and id in (1,2,3)` to `Seq((dt = 20190626), (id in (1,2,3))`, and then these two sub-predicates will be processed in

[GitHub] [spark] AmplabJenkins commented on pull request #28831: [SPARK-31993][SQL] Build arrays for passing variables generated from children for 'concat_ws' with columns having at least one of array

2020-06-18 Thread GitBox
AmplabJenkins commented on pull request #28831: URL: https://github.com/apache/spark/pull/28831#issuecomment-646445485 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28831: [SPARK-31993][SQL] Build arrays for passing variables generated from children for 'concat_ws' with columns having at least one of arr

2020-06-18 Thread GitBox
SparkQA removed a comment on pull request #28831: URL: https://github.com/apache/spark/pull/28831#issuecomment-646368574 **[Test build #124243 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124243/testReport)** for PR 28831 at commit

[GitHub] [spark] SparkQA commented on pull request #28831: [SPARK-31993][SQL] Build arrays for passing variables generated from children for 'concat_ws' with columns having at least one of array type

2020-06-18 Thread GitBox
SparkQA commented on pull request #28831: URL: https://github.com/apache/spark/pull/28831#issuecomment-646444772 **[Test build #124243 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124243/testReport)** for PR 28831 at commit

[GitHub] [spark] gengliangwang commented on pull request #28805: [SPARK-28169][SQL] Convert scan predicate condition to CNF

2020-06-18 Thread GitBox
gengliangwang commented on pull request #28805: URL: https://github.com/apache/spark/pull/28805#issuecomment-646443250 > In this case, Spark will resolve Or condition as one expression, and since this expr has reference of "id", then it can't been push down. Sorry, could you explain

[GitHub] [spark] maropu commented on a change in pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for sort merge join if applicable

2020-06-18 Thread GitBox
maropu commented on a change in pull request #28123: URL: https://github.com/apache/spark/pull/28123#discussion_r442637400 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/bucketing/CoalesceBucketsInSortMergeJoin.scala ## @@ -0,0 +1,132 @@ +/* + * Licensed

[GitHub] [spark] maropu commented on a change in pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for sort merge join if applicable

2020-06-18 Thread GitBox
maropu commented on a change in pull request #28123: URL: https://github.com/apache/spark/pull/28123#discussion_r442637311 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/bucketing/CoalesceBucketsInSortMergeJoinSuite.scala ## @@ -0,0 +1,194 @@ +/* + *

[GitHub] [spark] zhli1142015 commented on pull request #28867: [SPARK-32028][WEBUI] fix app id link for multi attempts app in history summary page

2020-06-18 Thread GitBox
zhli1142015 commented on pull request #28867: URL: https://github.com/apache/spark/pull/28867#issuecomment-646440070 @dongjoon-hyun , @vanzin, @jerryshao , could you please help review this? This is an automated message

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28867: [SPARK-32028][WEBUI] fix app id link for multi attempts app in history summary page

2020-06-18 Thread GitBox
AmplabJenkins removed a comment on pull request #28867: URL: https://github.com/apache/spark/pull/28867#issuecomment-646438358 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] AmplabJenkins commented on pull request #28867: [SPARK-32028][WEBUI] fix app id link for multi attempts app in history summary page

2020-06-18 Thread GitBox
AmplabJenkins commented on pull request #28867: URL: https://github.com/apache/spark/pull/28867#issuecomment-646438634 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28867: [SPARK-32028][WEBUI] fix app id link for multi attempts app in history summary page

2020-06-18 Thread GitBox
AmplabJenkins commented on pull request #28867: URL: https://github.com/apache/spark/pull/28867#issuecomment-646438358 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] zhli1142015 opened a new pull request #28867: [SPARK-32028][WEBUI] fix app id link for multi attempts app in history summary page

2020-06-18 Thread GitBox
zhli1142015 opened a new pull request #28867: URL: https://github.com/apache/spark/pull/28867 ### What changes were proposed in this pull request? Fix app id link for multi attempts application in history summary page If attempt id is available (applications run yarn), app

[GitHub] [spark] cloud-fan commented on a change in pull request #28645: [SPARK-31826][SQL] Support composed type of case class for typed Scala UDF

2020-06-18 Thread GitBox
cloud-fan commented on a change in pull request #28645: URL: https://github.com/apache/spark/pull/28645#discussion_r442631441 ## File path: sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala ## @@ -581,4 +581,99 @@ class UDFSuite extends QueryTest with

[GitHub] [spark] cloud-fan commented on a change in pull request #28645: [SPARK-31826][SQL] Support composed type of case class for typed Scala UDF

2020-06-18 Thread GitBox
cloud-fan commented on a change in pull request #28645: URL: https://github.com/apache/spark/pull/28645#discussion_r442631217 ## File path: sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala ## @@ -581,4 +581,99 @@ class UDFSuite extends QueryTest with

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for sort merge join if applicable

2020-06-18 Thread GitBox
AmplabJenkins removed a comment on pull request #28123: URL: https://github.com/apache/spark/pull/28123#issuecomment-646435314 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for sort merge join if applicable

2020-06-18 Thread GitBox
AmplabJenkins commented on pull request #28123: URL: https://github.com/apache/spark/pull/28123#issuecomment-646435314 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for sort merge join if applicable

2020-06-18 Thread GitBox
SparkQA commented on pull request #28123: URL: https://github.com/apache/spark/pull/28123#issuecomment-646434778 **[Test build #124258 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124258/testReport)** for PR 28123 at commit

[GitHub] [spark] imback82 commented on a change in pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for sort merge join if applicable

2020-06-18 Thread GitBox
imback82 commented on a change in pull request #28123: URL: https://github.com/apache/spark/pull/28123#discussion_r442629743 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/bucketing/CoalesceBucketsInSortMergeJoin.scala ## @@ -0,0 +1,132 @@ +/* + *

[GitHub] [spark] imback82 commented on a change in pull request #28123: [SPARK-31350][SQL] Coalesce bucketed tables for sort merge join if applicable

2020-06-18 Thread GitBox
imback82 commented on a change in pull request #28123: URL: https://github.com/apache/spark/pull/28123#discussion_r442629600 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/bucketing/CoalesceBucketsInSortMergeJoinSuite.scala ## @@ -0,0 +1,194 @@ +/* + *

[GitHub] [spark] viirya commented on a change in pull request #27690: [SPARK-21514][SQL] Added a new option to use non-blobstore storage when writing into blobstore storage

2020-06-18 Thread GitBox
viirya commented on a change in pull request #27690: URL: https://github.com/apache/spark/pull/27690#discussion_r442627998 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -839,6 +839,17 @@ object SQLConf {

[GitHub] [spark] fqaiser94 commented on pull request #27066: [SPARK-31317][SQL] Add withField method to Column

2020-06-18 Thread GitBox
fqaiser94 commented on pull request #27066: URL: https://github.com/apache/spark/pull/27066#issuecomment-646429505 > Can you explain more about this? Please see the comment from @dbtsai [here](https://github.com/apache/spark/pull/27066#issuecomment-609512144) for a more thorough

[GitHub] [spark] srowen commented on pull request #28857: [SPARK-32023][Streaming]Generate spark streaming test jar with maven plugin maven-jar-plugin

2020-06-18 Thread GitBox
srowen commented on pull request #28857: URL: https://github.com/apache/spark/pull/28857#issuecomment-646427158 Hm, I'm a little uneasy about it, as that shade config was put in a long time ago to work around Guava issues. It may or may not be necessary, but, what if you leave it in?

[GitHub] [spark] ulysses-you commented on a change in pull request #28840: [SPARK-31999][SQL] Add REFRESH FUNCTION command

2020-06-18 Thread GitBox
ulysses-you commented on a change in pull request #28840: URL: https://github.com/apache/spark/pull/28840#discussion_r442622091 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala ## @@ -1341,6 +1341,16 @@ class SessionCatalog(

[GitHub] [spark] TJX2014 commented on a change in pull request #28856: [SPARK-31982][SQL]Function sequence doesn't handle date increments that cross DST

2020-06-18 Thread GitBox
TJX2014 commented on a change in pull request #28856: URL: https://github.com/apache/spark/pull/28856#discussion_r442621499 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala ## @@ -2698,7 +2721,11 @@ object Sequence

[GitHub] [spark] ulysses-you commented on a change in pull request #28840: [SPARK-31999][SQL] Add REFRESH FUNCTION command

2020-06-18 Thread GitBox
ulysses-you commented on a change in pull request #28840: URL: https://github.com/apache/spark/pull/28840#discussion_r442621427 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/LookupCatalog.scala ## @@ -155,4 +155,37 @@ private[sql] trait

[GitHub] [spark] TJX2014 commented on a change in pull request #28856: [SPARK-31982][SQL]Function sequence doesn't handle date increments that cross DST

2020-06-18 Thread GitBox
TJX2014 commented on a change in pull request #28856: URL: https://github.com/apache/spark/pull/28856#discussion_r442621499 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala ## @@ -2698,7 +2721,11 @@ object Sequence

[GitHub] [spark] TJX2014 commented on a change in pull request #28856: [SPARK-31982][SQL]Function sequence doesn't handle date increments that cross DST

2020-06-18 Thread GitBox
TJX2014 commented on a change in pull request #28856: URL: https://github.com/apache/spark/pull/28856#discussion_r442621330 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala ## @@ -2635,7 +2643,11 @@ object Sequence

[GitHub] [spark] ulysses-you commented on a change in pull request #28840: [SPARK-31999][SQL] Add REFRESH FUNCTION command

2020-06-18 Thread GitBox
ulysses-you commented on a change in pull request #28840: URL: https://github.com/apache/spark/pull/28840#discussion_r442620715 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/LookupCatalog.scala ## @@ -155,4 +155,37 @@ private[sql] trait

[GitHub] [spark] ulysses-you commented on a change in pull request #28840: [SPARK-31999][SQL] Add REFRESH FUNCTION command

2020-06-18 Thread GitBox
ulysses-you commented on a change in pull request #28840: URL: https://github.com/apache/spark/pull/28840#discussion_r442620118 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/LookupCatalog.scala ## @@ -155,4 +155,37 @@ private[sql] trait

[GitHub] [spark] HeartSaVioR commented on pull request #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector

2020-06-18 Thread GitBox
HeartSaVioR commented on pull request #25135: URL: https://github.com/apache/spark/pull/25135#issuecomment-646423684 That said, it can be unblocked if we concern about infinite timeout seriously (see the behavior fairly often) and consider as critical one tolerating additional complexity

[GitHub] [spark] AmplabJenkins commented on pull request #28805: [SPARK-28169][SQL] Convert scan predicate condition to CNF

2020-06-18 Thread GitBox
AmplabJenkins commented on pull request #28805: URL: https://github.com/apache/spark/pull/28805#issuecomment-646422173 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28805: [SPARK-28169][SQL] Convert scan predicate condition to CNF

2020-06-18 Thread GitBox
AmplabJenkins removed a comment on pull request #28805: URL: https://github.com/apache/spark/pull/28805#issuecomment-646422173 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #28805: [SPARK-28169][SQL] Convert scan predicate condition to CNF

2020-06-18 Thread GitBox
SparkQA commented on pull request #28805: URL: https://github.com/apache/spark/pull/28805#issuecomment-646421987 **[Test build #124256 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124256/testReport)** for PR 28805 at commit

[GitHub] [spark] SparkQA commented on pull request #27066: [SPARK-31317][SQL] Add withField method to Column

2020-06-18 Thread GitBox
SparkQA commented on pull request #27066: URL: https://github.com/apache/spark/pull/27066#issuecomment-646421998 **[Test build #124257 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124257/testReport)** for PR 27066 at commit

[GitHub] [spark] fqaiser94 commented on a change in pull request #27066: [SPARK-31317][SQL] Add withField method to Column

2020-06-18 Thread GitBox
fqaiser94 commented on a change in pull request #27066: URL: https://github.com/apache/spark/pull/27066#discussion_r442617361 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/complexTypesSuite.scala ## @@ -452,4 +453,91 @@ class

[GitHub] [spark] fqaiser94 commented on a change in pull request #27066: [SPARK-31317][SQL] Add withField method to Column

2020-06-18 Thread GitBox
fqaiser94 commented on a change in pull request #27066: URL: https://github.com/apache/spark/pull/27066#discussion_r442617236 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala ## @@ -539,3 +541,82 @@ case class

[GitHub] [spark] agrawaldevesh commented on a change in pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-18 Thread GitBox
agrawaldevesh commented on a change in pull request #28708: URL: https://github.com/apache/spark/pull/28708#discussion_r442615769 ## File path: core/src/main/scala/org/apache/spark/scheduler/MapStatus.scala ## @@ -178,6 +184,10 @@ private[spark] class HighlyCompressedMapStatus

[GitHub] [spark] HeartSaVioR commented on pull request #25135: [SPARK-28367][SS] Use new KafkaConsumer.poll API in Kafka connector

2020-06-18 Thread GitBox
HeartSaVioR commented on pull request #25135: URL: https://github.com/apache/spark/pull/25135#issuecomment-646420436 @Tagar Please refer the comment in JIRA issue:

[GitHub] [spark] AmplabJenkins commented on pull request #28831: [SPARK-31993][SQL] Build arrays for passing variables generated from children for 'concat_ws' with columns having at least one of array

2020-06-18 Thread GitBox
AmplabJenkins commented on pull request #28831: URL: https://github.com/apache/spark/pull/28831#issuecomment-646420162 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28831: [SPARK-31993][SQL] Build arrays for passing variables generated from children for 'concat_ws' with columns having at least one

2020-06-18 Thread GitBox
AmplabJenkins removed a comment on pull request #28831: URL: https://github.com/apache/spark/pull/28831#issuecomment-646420162 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #28831: [SPARK-31993][SQL] Build arrays for passing variables generated from children for 'concat_ws' with columns having at least one of arr

2020-06-18 Thread GitBox
SparkQA removed a comment on pull request #28831: URL: https://github.com/apache/spark/pull/28831#issuecomment-646349387 **[Test build #124239 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124239/testReport)** for PR 28831 at commit

[GitHub] [spark] SparkQA commented on pull request #28831: [SPARK-31993][SQL] Build arrays for passing variables generated from children for 'concat_ws' with columns having at least one of array type

2020-06-18 Thread GitBox
SparkQA commented on pull request #28831: URL: https://github.com/apache/spark/pull/28831#issuecomment-646419702 **[Test build #124239 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124239/testReport)** for PR 28831 at commit

[GitHub] [spark] agrawaldevesh commented on a change in pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-18 Thread GitBox
agrawaldevesh commented on a change in pull request #28708: URL: https://github.com/apache/spark/pull/28708#discussion_r442615585 ## File path: core/src/main/scala/org/apache/spark/internal/config/package.scala ## @@ -420,6 +420,30 @@ package object config {

[GitHub] [spark] xuanyuanking commented on pull request #28854: [MINOR][DOCS] Emphasize the Streaming tab is for DStream API

2020-06-18 Thread GitBox
xuanyuanking commented on pull request #28854: URL: https://github.com/apache/spark/pull/28854#issuecomment-646418641 Thanks for reviewing. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28866: [SPARK-31845][CORE][TESTS] DAGSchedulerSuite: Reuse completeNextStageWithFetchFailure

2020-06-18 Thread GitBox
AmplabJenkins removed a comment on pull request #28866: URL: https://github.com/apache/spark/pull/28866#issuecomment-646417972 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on pull request #28866: [SPARK-31845][CORE][TESTS] DAGSchedulerSuite: Reuse completeNextStageWithFetchFailure

2020-06-18 Thread GitBox
SparkQA removed a comment on pull request #28866: URL: https://github.com/apache/spark/pull/28866#issuecomment-646417341 **[Test build #124255 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124255/testReport)** for PR 28866 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28866: [SPARK-31845][CORE][TESTS] DAGSchedulerSuite: Reuse completeNextStageWithFetchFailure

2020-06-18 Thread GitBox
AmplabJenkins removed a comment on pull request #28866: URL: https://github.com/apache/spark/pull/28866#issuecomment-646417965 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28866: [SPARK-31845][CORE][TESTS] DAGSchedulerSuite: Reuse completeNextStageWithFetchFailure

2020-06-18 Thread GitBox
AmplabJenkins commented on pull request #28866: URL: https://github.com/apache/spark/pull/28866#issuecomment-646417965 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28866: [SPARK-31845][CORE][TESTS] DAGSchedulerSuite: Reuse completeNextStageWithFetchFailure

2020-06-18 Thread GitBox
SparkQA commented on pull request #28866: URL: https://github.com/apache/spark/pull/28866#issuecomment-646417952 **[Test build #124255 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124255/testReport)** for PR 28866 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28866: [SPARK-31845][CORE][TESTS] DAGSchedulerSuite: Reuse completeNextStageWithFetchFailure

2020-06-18 Thread GitBox
AmplabJenkins removed a comment on pull request #28866: URL: https://github.com/apache/spark/pull/28866#issuecomment-646417639 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28866: [SPARK-31845][CORE][TESTS] DAGSchedulerSuite: Reuse completeNextStageWithFetchFailure

2020-06-18 Thread GitBox
AmplabJenkins commented on pull request #28866: URL: https://github.com/apache/spark/pull/28866#issuecomment-646417639 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28866: [SPARK-31845][CORE][TESTS] DAGSchedulerSuite: Reuse completeNextStageWithFetchFailure

2020-06-18 Thread GitBox
SparkQA commented on pull request #28866: URL: https://github.com/apache/spark/pull/28866#issuecomment-646417341 **[Test build #124255 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124255/testReport)** for PR 28866 at commit

[GitHub] [spark] TJX2014 commented on a change in pull request #28856: [SPARK-31982][SQL]Function sequence doesn't handle date increments that cross DST

2020-06-18 Thread GitBox
TJX2014 commented on a change in pull request #28856: URL: https://github.com/apache/spark/pull/28856#discussion_r442613764 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala ## @@ -2635,7 +2643,11 @@ object Sequence

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28866: [SPARK-31845][CORE][TESTS] DAGSchedulerSuite: Reuse completeNextStageWithFetchFailure

2020-06-18 Thread GitBox
AmplabJenkins removed a comment on pull request #28866: URL: https://github.com/apache/spark/pull/28866#issuecomment-646416246 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28866: [SPARK-31845][CORE][TESTS] DAGSchedulerSuite: Reuse completeNextStageWithFetchFailure

2020-06-18 Thread GitBox
AmplabJenkins removed a comment on pull request #28866: URL: https://github.com/apache/spark/pull/28866#issuecomment-646416242 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28866: [SPARK-31845][CORE][TESTS] DAGSchedulerSuite: Reuse completeNextStageWithFetchFailure

2020-06-18 Thread GitBox
AmplabJenkins commented on pull request #28866: URL: https://github.com/apache/spark/pull/28866#issuecomment-646416242 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28866: [SPARK-31845][CORE][TESTS] DAGSchedulerSuite: Reuse completeNextStageWithFetchFailure

2020-06-18 Thread GitBox
SparkQA commented on pull request #28866: URL: https://github.com/apache/spark/pull/28866#issuecomment-646416228 **[Test build #124253 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124253/testReport)** for PR 28866 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28866: [SPARK-31845][CORE][TESTS] DAGSchedulerSuite: Reuse completeNextStageWithFetchFailure

2020-06-18 Thread GitBox
SparkQA removed a comment on pull request #28866: URL: https://github.com/apache/spark/pull/28866#issuecomment-646415577 **[Test build #124253 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124253/testReport)** for PR 28866 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28856: [SPARK-31982][SQL]Function sequence doesn't handle date increments that cross DST

2020-06-18 Thread GitBox
AmplabJenkins removed a comment on pull request #28856: URL: https://github.com/apache/spark/pull/28856#issuecomment-646415868 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28866: [SPARK-31845][CORE][TESTS] DAGSchedulerSuite: Reuse completeNextStageWithFetchFailure

2020-06-18 Thread GitBox
AmplabJenkins commented on pull request #28866: URL: https://github.com/apache/spark/pull/28866#issuecomment-646415860 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28856: [SPARK-31982][SQL]Function sequence doesn't handle date increments that cross DST

2020-06-18 Thread GitBox
AmplabJenkins commented on pull request #28856: URL: https://github.com/apache/spark/pull/28856#issuecomment-646415868 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28866: [SPARK-31845][CORE][TESTS] DAGSchedulerSuite: Reuse completeNextStageWithFetchFailure

2020-06-18 Thread GitBox
AmplabJenkins removed a comment on pull request #28866: URL: https://github.com/apache/spark/pull/28866#issuecomment-646415860 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28856: [SPARK-31982][SQL]Function sequence doesn't handle date increments that cross DST

2020-06-18 Thread GitBox
SparkQA commented on pull request #28856: URL: https://github.com/apache/spark/pull/28856#issuecomment-646415612 **[Test build #124254 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124254/testReport)** for PR 28856 at commit

[GitHub] [spark] SparkQA commented on pull request #28866: [SPARK-31845][CORE][TESTS] DAGSchedulerSuite: Reuse completeNextStageWithFetchFailure

2020-06-18 Thread GitBox
SparkQA commented on pull request #28866: URL: https://github.com/apache/spark/pull/28866#issuecomment-646415577 **[Test build #124253 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124253/testReport)** for PR 28866 at commit

[GitHub] [spark] wankunde commented on pull request #28857: [SPARK-32023][Streaming]Generate spark streaming test jar with maven plugin maven-jar-plugin

2020-06-18 Thread GitBox
wankunde commented on pull request #28857: URL: https://github.com/apache/spark/pull/28857#issuecomment-646414088 Hi @srowen, I have compared the compilation results with and without shade plugin. Their result classes are the same. So I don't think we need to keep shade plugin anymore.

[GitHub] [spark] holdenk commented on a change in pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-18 Thread GitBox
holdenk commented on a change in pull request #28708: URL: https://github.com/apache/spark/pull/28708#discussion_r442604350 ## File path: core/src/main/scala/org/apache/spark/MapOutputTracker.scala ## @@ -775,7 +802,12 @@ private[spark] class MapOutputTrackerMaster(

[GitHub] [spark] Ngone51 commented on a change in pull request #28848: [SPARK-32003][CORE] Unregister outputs for executor on fetch failure …

2020-06-18 Thread GitBox
Ngone51 commented on a change in pull request #28848: URL: https://github.com/apache/spark/pull/28848#discussion_r442610030 ## File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala ## @@ -1939,24 +1941,23 @@ private[spark] class DAGScheduler(

[GitHub] [spark] Ngone51 commented on a change in pull request #28848: [SPARK-32003][CORE] Unregister outputs for executor on fetch failure …

2020-06-18 Thread GitBox
Ngone51 commented on a change in pull request #28848: URL: https://github.com/apache/spark/pull/28848#discussion_r442610125 ## File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala ## @@ -1939,24 +1941,22 @@ private[spark] class DAGScheduler(

[GitHub] [spark] HyukjinKwon commented on pull request #28854: [MINOR][DOCS] Emphasize the Streaming tab is for DStream API

2020-06-18 Thread GitBox
HyukjinKwon commented on pull request #28854: URL: https://github.com/apache/spark/pull/28854#issuecomment-646412636 Merged to master and branch-3.0 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] HyukjinKwon closed pull request #28854: [MINOR][DOCS] Emphasize the Streaming tab is for DStream API

2020-06-18 Thread GitBox
HyukjinKwon closed pull request #28854: URL: https://github.com/apache/spark/pull/28854 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] AmplabJenkins commented on pull request #28860: [SPARK-32002][SQL]Support Extract valve from nested ArrayStruct

2020-06-18 Thread GitBox
AmplabJenkins commented on pull request #28860: URL: https://github.com/apache/spark/pull/28860#issuecomment-646410212 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28860: [SPARK-32002][SQL]Support Extract valve from nested ArrayStruct

2020-06-18 Thread GitBox
AmplabJenkins removed a comment on pull request #28860: URL: https://github.com/apache/spark/pull/28860#issuecomment-646410212 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28860: [SPARK-32002][SQL]Support Extract valve from nested ArrayStruct

2020-06-18 Thread GitBox
SparkQA commented on pull request #28860: URL: https://github.com/apache/spark/pull/28860#issuecomment-646409843 **[Test build #124252 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124252/testReport)** for PR 28860 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28866: [SPARK-31845][CORE][TESTS] DAGSchedulerSuite: Reuse completeNextStageWithFetchFailure

2020-06-18 Thread GitBox
AmplabJenkins removed a comment on pull request #28866: URL: https://github.com/apache/spark/pull/28866#issuecomment-646404851 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on pull request #28866: [SPARK-31845][CORE][TESTS] DAGSchedulerSuite: Reuse completeNextStageWithFetchFailure

2020-06-18 Thread GitBox
SparkQA removed a comment on pull request #28866: URL: https://github.com/apache/spark/pull/28866#issuecomment-646404216 **[Test build #124251 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124251/testReport)** for PR 28866 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28866: [SPARK-31845][CORE][TESTS] DAGSchedulerSuite: Reuse completeNextStageWithFetchFailure

2020-06-18 Thread GitBox
AmplabJenkins removed a comment on pull request #28866: URL: https://github.com/apache/spark/pull/28866#issuecomment-646404847 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28866: [SPARK-31845][CORE][TESTS] DAGSchedulerSuite: Reuse completeNextStageWithFetchFailure

2020-06-18 Thread GitBox
AmplabJenkins commented on pull request #28866: URL: https://github.com/apache/spark/pull/28866#issuecomment-646404847 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28866: [SPARK-31845][CORE][TESTS] DAGSchedulerSuite: Reuse completeNextStageWithFetchFailure

2020-06-18 Thread GitBox
SparkQA commented on pull request #28866: URL: https://github.com/apache/spark/pull/28866#issuecomment-646404833 **[Test build #124251 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124251/testReport)** for PR 28866 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28866: [SPARK-31845][CORE][TESTS] DAGSchedulerSuite: Reuse completeNextStageWithFetchFailure

2020-06-18 Thread GitBox
AmplabJenkins removed a comment on pull request #28866: URL: https://github.com/apache/spark/pull/28866#issuecomment-646404507 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] agrawaldevesh commented on a change in pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-18 Thread GitBox
agrawaldevesh commented on a change in pull request #28708: URL: https://github.com/apache/spark/pull/28708#discussion_r442581482 ## File path: core/src/main/scala/org/apache/spark/MapOutputTracker.scala ## @@ -775,7 +802,12 @@ private[spark] class MapOutputTrackerMaster(

[GitHub] [spark] AmplabJenkins commented on pull request #28866: [SPARK-31845][CORE][TESTS] DAGSchedulerSuite: Reuse completeNextStageWithFetchFailure

2020-06-18 Thread GitBox
AmplabJenkins commented on pull request #28866: URL: https://github.com/apache/spark/pull/28866#issuecomment-646404507 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28866: [SPARK-31845][CORE][TESTS] DAGSchedulerSuite: Reuse completeNextStageWithFetchFailure

2020-06-18 Thread GitBox
SparkQA commented on pull request #28866: URL: https://github.com/apache/spark/pull/28866#issuecomment-646404216 **[Test build #124251 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124251/testReport)** for PR 28866 at commit

  1   2   3   4   5   6   7   8   >