[GitHub] [spark] AmplabJenkins removed a comment on pull request #29159: [SPARK-32310][ML][PySpark][3.0] ML params default value parity

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-662540625 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #29159: [SPARK-32310][ML][PySpark][3.0] ML params default value parity

2020-07-22 Thread GitBox
SparkQA commented on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-662539960 **[Test build #126346 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126346/testReport)** for PR 29159 at commit

[GitHub] [spark] huaxingao commented on pull request #29159: [SPARK-32310][ML][PySpark][3.0] ML params default value parity

2020-07-22 Thread GitBox
huaxingao commented on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-662538212 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29159: [SPARK-32310][ML][PySpark][3.0] ML params default value parity

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-662535281 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29159: [SPARK-32310][ML][PySpark][3.0] ML params default value parity

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-662535265 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #29159: [SPARK-32310][ML][PySpark][3.0] ML params default value parity

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-662535265 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29159: [SPARK-32310][ML][PySpark][3.0] ML params default value parity

2020-07-22 Thread GitBox
SparkQA commented on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-662534615 **[Test build #126342 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126342/testReport)** for PR 29159 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #29159: [SPARK-32310][ML][PySpark][3.0] ML params default value parity

2020-07-22 Thread GitBox
SparkQA removed a comment on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-662505360 **[Test build #126342 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126342/testReport)** for PR 29159 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29190: [do not review][testing master PR build][discard] comment change

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29190: URL: https://github.com/apache/spark/pull/29190#issuecomment-662531954 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-662531900 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29190: [do not review][testing master PR build][discard] comment change

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29190: URL: https://github.com/apache/spark/pull/29190#issuecomment-662531954 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-662531900 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-22 Thread GitBox
SparkQA commented on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-662531198 **[Test build #126345 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126345/testReport)** for PR 29085 at commit

[GitHub] [spark] SparkQA commented on pull request #29190: [do not review][testing master PR build][discard] comment change

2020-07-22 Thread GitBox
SparkQA commented on pull request #29190: URL: https://github.com/apache/spark/pull/29190#issuecomment-662531082 **[Test build #126344 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126344/testReport)** for PR 29190 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #29186: [SPARK-32386][SS][TESTS] Fix temp view leaking in Structured Streaming tests

2020-07-22 Thread GitBox
SparkQA removed a comment on pull request #29186: URL: https://github.com/apache/spark/pull/29186#issuecomment-662342525 **[Test build #126323 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126323/testReport)** for PR 29186 at commit

[GitHub] [spark] AngersZhuuuu commented on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-22 Thread GitBox
AngersZh commented on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-662529996 @maropu add UT of ROW FORMAT DELIMIT in SQLQueryTestSuite. and seems all have done, slow net work and too comment, check tomorrow in company.

[GitHub] [spark] SparkQA commented on pull request #29186: [SPARK-32386][SS][TESTS] Fix temp view leaking in Structured Streaming tests

2020-07-22 Thread GitBox
SparkQA commented on pull request #29186: URL: https://github.com/apache/spark/pull/29186#issuecomment-662528384 **[Test build #126323 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126323/testReport)** for PR 29186 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29186: [SPARK-32386][SS][TESTS] Fix temp view leaking in Structured Streaming tests

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29186: URL: https://github.com/apache/spark/pull/29186#issuecomment-662529533 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29186: [SPARK-32386][SS][TESTS] Fix temp view leaking in Structured Streaming tests

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29186: URL: https://github.com/apache/spark/pull/29186#issuecomment-662529523 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] agrawaldevesh opened a new pull request #29190: [do not review][testing master PR build][discard] comment change

2020-07-22 Thread GitBox
agrawaldevesh opened a new pull request #29190: URL: https://github.com/apache/spark/pull/29190 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ###

[GitHub] [spark] AmplabJenkins commented on pull request #29186: [SPARK-32386][SS][TESTS] Fix temp view leaking in Structured Streaming tests

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29186: URL: https://github.com/apache/spark/pull/29186#issuecomment-662529523 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29188: URL: https://github.com/apache/spark/pull/29188#issuecomment-662519415 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29188: URL: https://github.com/apache/spark/pull/29188#issuecomment-662519424 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29188: URL: https://github.com/apache/spark/pull/29188#issuecomment-662519415 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base

2020-07-22 Thread GitBox
SparkQA removed a comment on pull request #29188: URL: https://github.com/apache/spark/pull/29188#issuecomment-662436635 **[Test build #126336 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126336/testReport)** for PR 29188 at commit

[GitHub] [spark] SparkQA commented on pull request #29188: [SPARK-32179][SPARK-32188][PYTHON][DOCS] Replace and redesign the documentation base

2020-07-22 Thread GitBox
SparkQA commented on pull request #29188: URL: https://github.com/apache/spark/pull/29188#issuecomment-662518810 **[Test build #126336 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126336/testReport)** for PR 29188 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29182: [SPARK-32003][CORE][2.4] When external shuffle service is used, unregister outputs for executor on fetch failure after executor

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29182: URL: https://github.com/apache/spark/pull/29182#issuecomment-662506783 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29182: [SPARK-32003][CORE][2.4] When external shuffle service is used, unregister outputs for executor on fetch failure after executor

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29182: URL: https://github.com/apache/spark/pull/29182#issuecomment-662506768 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-662509829 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-662509829 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #29182: [SPARK-32003][CORE][2.4] When external shuffle service is used, unregister outputs for executor on fetch failure after executor is lo

2020-07-22 Thread GitBox
SparkQA removed a comment on pull request #29182: URL: https://github.com/apache/spark/pull/29182#issuecomment-662505206 **[Test build #126341 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126341/testReport)** for PR 29182 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29182: [SPARK-32003][CORE][2.4] When external shuffle service is used, unregister outputs for executor on fetch failure after executor

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29182: URL: https://github.com/apache/spark/pull/29182#issuecomment-662506098 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29182: [SPARK-32003][CORE][2.4] When external shuffle service is used, unregister outputs for executor on fetch failure after executor is lost

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29182: URL: https://github.com/apache/spark/pull/29182#issuecomment-662506098 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29153: [SPARK-32310][ML][PySpark] ML params default value parity in feature and tuning

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29153: URL: https://github.com/apache/spark/pull/29153#issuecomment-662506123 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] Ngone51 commented on pull request #28911: [SPARK-32077][CORE] Support host-local shuffle data reading when external shuffle service is disabled

2020-07-22 Thread GitBox
Ngone51 commented on pull request #28911: URL: https://github.com/apache/spark/pull/28911#issuecomment-662509102 ping @squito Could you also take a look? Thanks! This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-22 Thread GitBox
SparkQA removed a comment on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-662346190 **[Test build #126325 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126325/testReport)** for PR 29085 at commit

[GitHub] [spark] SparkQA commented on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-22 Thread GitBox
SparkQA commented on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-662508644 **[Test build #126325 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126325/testReport)** for PR 29085 at commit

[GitHub] [spark] SparkQA commented on pull request #29153: [SPARK-32310][ML][PySpark] ML params default value parity in feature and tuning

2020-07-22 Thread GitBox
SparkQA commented on pull request #29153: URL: https://github.com/apache/spark/pull/29153#issuecomment-662505391 **[Test build #126343 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126343/testReport)** for PR 29153 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29182: [SPARK-32003][CORE][2.4] When external shuffle service is used, unregister outputs for executor on fetch failure after executor is lost

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29182: URL: https://github.com/apache/spark/pull/29182#issuecomment-662506768 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29182: [SPARK-32003][CORE][2.4] When external shuffle service is used, unregister outputs for executor on fetch failure after executor is lost

2020-07-22 Thread GitBox
SparkQA commented on pull request #29182: URL: https://github.com/apache/spark/pull/29182#issuecomment-662506747 **[Test build #126341 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126341/testReport)** for PR 29182 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29153: [SPARK-32310][ML][PySpark] ML params default value parity in feature and tuning

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29153: URL: https://github.com/apache/spark/pull/29153#issuecomment-662506123 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] dongjoon-hyun commented on pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

2020-07-22 Thread GitBox
dongjoon-hyun commented on pull request #29160: URL: https://github.com/apache/spark/pull/29160#issuecomment-662504233 Merged to master/3.0 since GitHub Action passed. Thank you all. I'll make a backporting PR to branch-2.4.

[GitHub] [spark] SparkQA commented on pull request #29159: [SPARK-32310][ML][PySpark][3.0] ML params default value parity

2020-07-22 Thread GitBox
SparkQA commented on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-662505360 **[Test build #126342 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126342/testReport)** for PR 29159 at commit

[GitHub] [spark] Ngone51 commented on a change in pull request #29014: [SPARK-32199][SPARK-32198] Reduce job failures during decommissioning

2020-07-22 Thread GitBox
Ngone51 commented on a change in pull request #29014: URL: https://github.com/apache/spark/pull/29014#discussion_r458860168 ## File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala ## @@ -1767,8 +1767,13 @@ private[spark] class DAGScheduler(

[GitHub] [spark] SparkQA commented on pull request #29182: [SPARK-32003][CORE][2.4] When external shuffle service is used, unregister outputs for executor on fetch failure after executor is lost

2020-07-22 Thread GitBox
SparkQA commented on pull request #29182: URL: https://github.com/apache/spark/pull/29182#issuecomment-662505206 **[Test build #126341 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126341/testReport)** for PR 29182 at commit

[GitHub] [spark] dongjoon-hyun closed pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

2020-07-22 Thread GitBox
dongjoon-hyun closed pull request #29160: URL: https://github.com/apache/spark/pull/29160 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29186: [SPARK-32386][SS][TESTS] Fix temp view leaking in Structured Streaming tests

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29186: URL: https://github.com/apache/spark/pull/29186#issuecomment-662503503 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29186: [SPARK-32386][SS][TESTS] Fix temp view leaking in Structured Streaming tests

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29186: URL: https://github.com/apache/spark/pull/29186#issuecomment-662503503 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] squito commented on pull request #28848: [SPARK-32003][CORE] When external shuffle service is used, unregister outputs for executor on fetch failure after executor is lost

2020-07-22 Thread GitBox
squito commented on pull request #28848: URL: https://github.com/apache/spark/pull/28848#issuecomment-662502752 @wypoon sorry, I mistakenly only merged this to master, but I should have also merged it to branch-3.0. Would you mind also opening a pr targeting branch-3.0?

[GitHub] [spark] SparkQA removed a comment on pull request #29186: [SPARK-32386][SS][TESTS] Fix temp view leaking in Structured Streaming tests

2020-07-22 Thread GitBox
SparkQA removed a comment on pull request #29186: URL: https://github.com/apache/spark/pull/29186#issuecomment-662327785 **[Test build #126320 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126320/testReport)** for PR 29186 at commit

[GitHub] [spark] SparkQA commented on pull request #29186: [SPARK-32386][SS][TESTS] Fix temp view leaking in Structured Streaming tests

2020-07-22 Thread GitBox
SparkQA commented on pull request #29186: URL: https://github.com/apache/spark/pull/29186#issuecomment-662502540 **[Test build #126320 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126320/testReport)** for PR 29186 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29159: [SPARK-32310][ML][PySpark][3.0] ML params default value parity

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-662501545 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] squito commented on pull request #28848: [SPARK-32003][CORE] When external shuffle service is used, unregister outputs for executor on fetch failure after executor is lost

2020-07-22 Thread GitBox
squito commented on pull request #28848: URL: https://github.com/apache/spark/pull/28848#issuecomment-662502026 merged to master, thanks everyone! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] AmplabJenkins commented on pull request #29159: [SPARK-32310][ML][PySpark][3.0] ML params default value parity

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-662501545 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] asfgit closed pull request #28848: [SPARK-32003][CORE] When external shuffle service is used, unregister outputs for executor on fetch failure after executor is lost

2020-07-22 Thread GitBox
asfgit closed pull request #28848: URL: https://github.com/apache/spark/pull/28848 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] squito commented on pull request #29182: [SPARK-32003][CORE][2.4] When external shuffle service is used, unregister outputs for executor on fetch failure after executor is lost

2020-07-22 Thread GitBox
squito commented on pull request #29182: URL: https://github.com/apache/spark/pull/29182#issuecomment-662501279 Jenkins, retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] huaxingao commented on pull request #29153: [SPARK-32310][ML][PySpark] ML params default value parity in feature and tuning

2020-07-22 Thread GitBox
huaxingao commented on pull request #29153: URL: https://github.com/apache/spark/pull/29153#issuecomment-662501152 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] huaxingao commented on pull request #29159: [SPARK-32310][ML][PySpark][3.0] ML params default value parity

2020-07-22 Thread GitBox
huaxingao commented on pull request #29159: URL: https://github.com/apache/spark/pull/29159#issuecomment-662500477 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] squito commented on a change in pull request #28848: [SPARK-32003][CORE] When external shuffle service is used, unregister outputs for executor on fetch failure after executor is lost

2020-07-22 Thread GitBox
squito commented on a change in pull request #28848: URL: https://github.com/apache/spark/pull/28848#discussion_r458853672 ## File path: core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ## @@ -548,6 +560,56 @@ class DAGSchedulerSuite extends

[GitHub] [spark] TJX2014 edited a comment on pull request #29156: [SPARK-32347][SQL] Hint in CTE should be resolved in Hints batch rule

2020-07-22 Thread GitBox
TJX2014 edited a comment on pull request #29156: URL: https://github.com/apache/spark/pull/29156#issuecomment-662487204 > > cannot resolve 'id' given input columns: [cte.id]; > > Do you know how this happens? The `id` column is there. Because the hint resolve ignore hint in

[GitHub] [spark] TJX2014 edited a comment on pull request #29156: [SPARK-32347][SQL] Hint in CTE should be resolved in Hints batch rule

2020-07-22 Thread GitBox
TJX2014 edited a comment on pull request #29156: URL: https://github.com/apache/spark/pull/29156#issuecomment-662487204 > > cannot resolve 'id' given input columns: [cte.id]; > > Do you know how this happens? The `id` column is there. Because the hint resolve ignore hint in

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29187: [SPARK-32387][SS] Extract UninterruptibleThread runner logic from KafkaOffsetReader

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29187: URL: https://github.com/apache/spark/pull/29187#issuecomment-662494647 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29187: [SPARK-32387][SS] Extract UninterruptibleThread runner logic from KafkaOffsetReader

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29187: URL: https://github.com/apache/spark/pull/29187#issuecomment-662494647 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #29187: [SPARK-32387][SS] Extract UninterruptibleThread runner logic from KafkaOffsetReader

2020-07-22 Thread GitBox
SparkQA removed a comment on pull request #29187: URL: https://github.com/apache/spark/pull/29187#issuecomment-662383880 **[Test build #126328 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126328/testReport)** for PR 29187 at commit

[GitHub] [spark] SparkQA commented on pull request #29187: [SPARK-32387][SS] Extract UninterruptibleThread runner logic from KafkaOffsetReader

2020-07-22 Thread GitBox
SparkQA commented on pull request #29187: URL: https://github.com/apache/spark/pull/29187#issuecomment-662493300 **[Test build #126328 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126328/testReport)** for PR 29187 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-662492562 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-22 Thread GitBox
SparkQA commented on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-662491908 **[Test build #126340 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126340/testReport)** for PR 29085 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-662492562 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] TJX2014 commented on a change in pull request #29156: [SPARK-32347][SQL] Hint in CTE should be resolved in Hints batch rule

2020-07-22 Thread GitBox
TJX2014 commented on a change in pull request #29156: URL: https://github.com/apache/spark/pull/29156#discussion_r458842763 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveHints.scala ## @@ -165,6 +165,24 @@ object ResolveHints {

[GitHub] [spark] AmplabJenkins commented on pull request #29168: [WIP][SPARK-32375][SQL] Basic functionality of table catalog v2 for JDBC

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29168: URL: https://github.com/apache/spark/pull/29168#issuecomment-662486290 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #29168: [WIP][SPARK-32375][SQL] Basic functionality of table catalog v2 for JDBC

2020-07-22 Thread GitBox
SparkQA removed a comment on pull request #29168: URL: https://github.com/apache/spark/pull/29168#issuecomment-662324201 **[Test build #126318 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126318/testReport)** for PR 29168 at commit

[GitHub] [spark] SparkQA commented on pull request #29145: [SPARK-32346][SQL] Support filters pushdown in Avro datasource

2020-07-22 Thread GitBox
SparkQA commented on pull request #29145: URL: https://github.com/apache/spark/pull/29145#issuecomment-662487764 **[Test build #126339 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126339/testReport)** for PR 29145 at commit

[GitHub] [spark] TJX2014 commented on pull request #29156: [SPARK-32347][SQL] Hint in CTE should be resolved in Hints batch rule

2020-07-22 Thread GitBox
TJX2014 commented on pull request #29156: URL: https://github.com/apache/spark/pull/29156#issuecomment-662487204 > > cannot resolve 'id' given input columns: [cte.id]; > > Do you know how this happens? The `id` column is there. Because the hint resolve ignore hint in CTE, and

[GitHub] [spark] TJX2014 edited a comment on pull request #29156: [SPARK-32347][SQL] Hint in CTE should be resolved in Hints batch rule

2020-07-22 Thread GitBox
TJX2014 edited a comment on pull request #29156: URL: https://github.com/apache/spark/pull/29156#issuecomment-662487204 > > cannot resolve 'id' given input columns: [cte.id]; > > Do you know how this happens? The `id` column is there. Because the hint resolve ignore hint in

[GitHub] [spark] TJX2014 edited a comment on pull request #29156: [SPARK-32347][SQL] Hint in CTE should be resolved in Hints batch rule

2020-07-22 Thread GitBox
TJX2014 edited a comment on pull request #29156: URL: https://github.com/apache/spark/pull/29156#issuecomment-662487204 > > cannot resolve 'id' given input columns: [cte.id]; > > Do you know how this happens? The `id` column is there. Because the hint resolve ignore hint in

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29145: [SPARK-32346][SQL] Support filters pushdown in Avro datasource

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29145: URL: https://github.com/apache/spark/pull/29145#issuecomment-662488532 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29168: [WIP][SPARK-32375][SQL] Basic functionality of table catalog v2 for JDBC

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29168: URL: https://github.com/apache/spark/pull/29168#issuecomment-662486290 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29145: [SPARK-32346][SQL] Support filters pushdown in Avro datasource

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29145: URL: https://github.com/apache/spark/pull/29145#issuecomment-662488532 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29168: [WIP][SPARK-32375][SQL] Basic functionality of table catalog v2 for JDBC

2020-07-22 Thread GitBox
SparkQA commented on pull request #29168: URL: https://github.com/apache/spark/pull/29168#issuecomment-662485050 **[Test build #126318 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126318/testReport)** for PR 29168 at commit

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-22 Thread GitBox
AngersZh commented on a change in pull request #29085: URL: https://github.com/apache/spark/pull/29085#discussion_r458829828 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ## @@ -679,64 +680,78 @@ class SparkSqlAstBuilder(conf:

[GitHub] [spark] bart-samwel commented on pull request #29181: [SPARK-32383][SQL] Preserve hash join (BHJ and SHJ) stream side ordering

2020-07-22 Thread GitBox
bart-samwel commented on pull request #29181: URL: https://github.com/apache/spark/pull/29181#issuecomment-662483694 Can you double check that the ordering is correct if there are NULLs involved, or outer join conditions? The tricky cases I see: - RIGHT / FULL SHJ. If the streaming

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

2020-07-22 Thread GitBox
AngersZh commented on a change in pull request #29085: URL: https://github.com/apache/spark/pull/29085#discussion_r458822655 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -745,7 +745,7 @@ class AstBuilder(conf:

[GitHub] [spark] zsxwing commented on pull request #28746: [SPARK-31922][CORE] logDebug "RpcEnv already stopped" error on LocalSparkCluster shutdown

2020-07-22 Thread GitBox
zsxwing commented on pull request #28746: URL: https://github.com/apache/spark/pull/28746#issuecomment-662477191 LGTM as well! This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] Ngone51 commented on a change in pull request #29032: [SPARK-32217] Plumb whether a worker would also be decommissioned along with executor

2020-07-22 Thread GitBox
Ngone51 commented on a change in pull request #29032: URL: https://github.com/apache/spark/pull/29032#discussion_r458819915 ## File path: core/src/main/scala/org/apache/spark/scheduler/ExecutorDecommissionInfo.scala ## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] Ngone51 commented on pull request #29032: [SPARK-32217] Plumb whether a worker would also be decommissioned along with executor

2020-07-22 Thread GitBox
Ngone51 commented on pull request #29032: URL: https://github.com/apache/spark/pull/29032#issuecomment-662475085 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29032: [SPARK-32217] Plumb whether a worker would also be decommissioned along with executor

2020-07-22 Thread GitBox
SparkQA commented on pull request #29032: URL: https://github.com/apache/spark/pull/29032#issuecomment-662474856 **[Test build #126338 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126338/testReport)** for PR 29032 at commit

[GitHub] [spark] tgravescs commented on pull request #29002: [SPARK-32175][CORE] Fix the order between initialization for ExecutorPlugin and starting heartbeat thread

2020-07-22 Thread GitBox
tgravescs commented on pull request #29002: URL: https://github.com/apache/spark/pull/29002#issuecomment-662473704 Yeah I think this is ok, especially since normally if your plugin is less then heartbeat time there shouldn't be any difference. I would like to test this with a couple

[GitHub] [spark] tgravescs commented on a change in pull request #29002: [SPARK-32175][CORE] Fix the order between initialization for ExecutorPlugin and starting heartbeat thread

2020-07-22 Thread GitBox
tgravescs commented on a change in pull request #29002: URL: https://github.com/apache/spark/pull/29002#discussion_r458816016 ## File path: core/src/main/scala/org/apache/spark/executor/Executor.scala ## @@ -227,6 +222,13 @@ private[spark] class Executor(

[GitHub] [spark] AmplabJenkins commented on pull request #29032: [SPARK-32217] Plumb whether a worker would also be decommissioned along with executor

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29032: URL: https://github.com/apache/spark/pull/29032#issuecomment-662471035 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29032: [SPARK-32217] Plumb whether a worker would also be decommissioned along with executor

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29032: URL: https://github.com/apache/spark/pull/29032#issuecomment-662471035 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] tgravescs commented on a change in pull request #29002: [SPARK-32175][CORE] Fix the order between initialization for ExecutorPlugin and starting heartbeat thread

2020-07-22 Thread GitBox
tgravescs commented on a change in pull request #29002: URL: https://github.com/apache/spark/pull/29002#discussion_r458814226 ## File path: core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala ## @@ -402,6 +403,73 @@ class ExecutorSuite extends SparkFunSuite

[GitHub] [spark] Ngone51 commented on pull request #29032: [SPARK-32217] Plumb whether a worker would also be decommissioned along with executor

2020-07-22 Thread GitBox
Ngone51 commented on pull request #29032: URL: https://github.com/apache/spark/pull/29032#issuecomment-662470154 retest this please. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] xuanyuanking commented on a change in pull request #28977: [SPARK-32389][TESTS] Add all hive.execution suite in the parallel test group

2020-07-22 Thread GitBox
xuanyuanking commented on a change in pull request #28977: URL: https://github.com/apache/spark/pull/28977#discussion_r458813200 ## File path: project/SparkBuild.scala ## @@ -486,9 +485,11 @@ object SparkParallelTestGrouping { ) private val DEFAULT_TEST_GROUP =

[GitHub] [spark] Ngone51 commented on pull request #28848: [SPARK-32003][CORE] When external shuffle service is used, unregister outputs for executor on fetch failure after executor is lost

2020-07-22 Thread GitBox
Ngone51 commented on pull request #28848: URL: https://github.com/apache/spark/pull/28848#issuecomment-662468893 still LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29187: [SPARK-32387][SS] Extract UninterruptibleThread runner logic from KafkaOffsetReader

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29187: URL: https://github.com/apache/spark/pull/29187#issuecomment-662465342 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29187: [SPARK-32387][SS] Extract UninterruptibleThread runner logic from KafkaOffsetReader

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29187: URL: https://github.com/apache/spark/pull/29187#issuecomment-662465342 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29189: [SPARK-32392][SQL] Reduce duplicate error log for executing sql statement operation in thrift server

2020-07-22 Thread GitBox
AmplabJenkins removed a comment on pull request #29189: URL: https://github.com/apache/spark/pull/29189#issuecomment-662464626 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #29189: [SPARK-32392][SQL] Reduce duplicate error log for executing sql statement operation in thrift server

2020-07-22 Thread GitBox
SparkQA removed a comment on pull request #29189: URL: https://github.com/apache/spark/pull/29189#issuecomment-662445659 **[Test build #126337 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126337/testReport)** for PR 29189 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29189: [SPARK-32392][SQL] Reduce duplicate error log for executing sql statement operation in thrift server

2020-07-22 Thread GitBox
AmplabJenkins commented on pull request #29189: URL: https://github.com/apache/spark/pull/29189#issuecomment-662464626 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29189: [SPARK-32392][SQL] Reduce duplicate error log for executing sql statement operation in thrift server

2020-07-22 Thread GitBox
SparkQA commented on pull request #29189: URL: https://github.com/apache/spark/pull/29189#issuecomment-662464211 **[Test build #126337 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126337/testReport)** for PR 29189 at commit

<    1   2   3   4   5   6   7   8   9   10   >