[GitHub] [spark] dongjoon-hyun closed pull request #29183: [SPARK-21117][SQL][FOLLOWUP] Define prettyName for WidthBucket

dongjoon-hyun closed pull request #29183: URL: https://github.com/apache/spark/pull/29183 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] dongjoon-hyun commented on pull request #29183: [SPARK-21117][SQL][FOLLOWUP] Define prettyName for WidthBucket

dongjoon-hyun commented on pull request #29183: URL: https://github.com/apache/spark/pull/29183#issuecomment-662358252 Thank you, @maropu and all. Merged to master for Apache Spark 3.1.0 on December 2020. This is an automate

[GitHub] [spark] AmplabJenkins commented on pull request #29187: [SPARK-32387][SS] Extract UninterruptibleThread runner logic from KafkaOffsetReader

AmplabJenkins commented on pull request #29187: URL: https://github.com/apache/spark/pull/29187#issuecomment-662357223 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] gaborgsomogyi opened a new pull request #29187: [SPARK-32387][SS] Extract UninterruptibleThread runner logic from KafkaOffsetReader

gaborgsomogyi opened a new pull request #29187: URL: https://github.com/apache/spark/pull/29187 ### What changes were proposed in this pull request? `UninterruptibleThread` running functionality is baked into `KafkaOffsetReader` which can be extracted into a class. The main intention is

[GitHub] [spark] LantaoJin commented on pull request #29062: [SPARK-32237][SQL] Resolve hint in CTE

LantaoJin commented on pull request #29062: URL: https://github.com/apache/spark/pull/29062#issuecomment-662354861 ``` WITH cte AS (SELECT /*+ REPARTITION(3) */ * FROM t) SELECT * FROM cte ``` throws `java.lang.IllegalStateException: Internal error: logical hint operator should hav

[GitHub] [spark] LantaoJin edited a comment on pull request #29062: [SPARK-32237][SQL] Resolve hint in CTE

LantaoJin edited a comment on pull request #29062: URL: https://github.com/apache/spark/pull/29062#issuecomment-662354861 ``` WITH cte AS (SELECT /*+ REPARTITION(3) */ * FROM t) SELECT * FROM cte ``` throws `java.lang.IllegalStateException: Internal error: logical hint operator sho

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

AmplabJenkins removed a comment on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-662350440 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

AmplabJenkins commented on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-662350440 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

AmplabJenkins removed a comment on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-662346816 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

AmplabJenkins commented on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-662346816 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

SparkQA commented on pull request #29085: URL: https://github.com/apache/spark/pull/29085#issuecomment-662346190 **[Test build #126325 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126325/testReport)** for PR 29085 at commit [`ce8184a`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29186: [SPARK-32386][SS][TESTS] Fix temp view leaking in Structured Streaming tests

AmplabJenkins removed a comment on pull request #29186: URL: https://github.com/apache/spark/pull/29186#issuecomment-662343077 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

AmplabJenkins removed a comment on pull request #29160: URL: https://github.com/apache/spark/pull/29160#issuecomment-662343043 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

AngersZh commented on a change in pull request #29085: URL: https://github.com/apache/spark/pull/29085#discussion_r458654492 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveScriptTransformationSuite.scala ## @@ -206,75 +169,83 @@ class HiveScr

[GitHub] [spark] AmplabJenkins commented on pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

AmplabJenkins commented on pull request #29160: URL: https://github.com/apache/spark/pull/29160#issuecomment-662343043 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] maropu commented on a change in pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

maropu commented on a change in pull request #29085: URL: https://github.com/apache/spark/pull/29085#discussion_r458654664 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/BaseScriptTransformationExec.scala ## @@ -87,17 +178,69 @@ trait BaseScriptTransforma

[GitHub] [spark] AmplabJenkins commented on pull request #29186: [SPARK-32386][SS][TESTS] Fix temp view leaking in Structured Streaming tests

AmplabJenkins commented on pull request #29186: URL: https://github.com/apache/spark/pull/29186#issuecomment-662343077 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

SparkQA commented on pull request #29160: URL: https://github.com/apache/spark/pull/29160#issuecomment-662342533 **[Test build #126324 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126324/testReport)** for PR 29160 at commit [`16eaf45`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #29186: [SPARK-32386][SS][TESTS] Fix temp view leaking in Structured Streaming tests

SparkQA commented on pull request #29186: URL: https://github.com/apache/spark/pull/29186#issuecomment-662342525 **[Test build #126323 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126323/testReport)** for PR 29186 at commit [`b654ebd`](https://github.com

[GitHub] [spark] maropu commented on a change in pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

maropu commented on a change in pull request #29085: URL: https://github.com/apache/spark/pull/29085#discussion_r458652781 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveScriptTransformationSuite.scala ## @@ -206,75 +169,83 @@ class HiveScriptTra

[GitHub] [spark] dongjoon-hyun commented on pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

dongjoon-hyun commented on pull request #29160: URL: https://github.com/apache/spark/pull/29160#issuecomment-662341945 Thank you, @cloud-fan . The PR is updated to use `Seq` instead of `Map`. This is an automated message from

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

dongjoon-hyun commented on a change in pull request #29160: URL: https://github.com/apache/spark/pull/29160#discussion_r458651760 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ## @@ -290,7 +290,7 @@ class DataFrameReader private[sql](sparkSess

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

AmplabJenkins removed a comment on pull request #29160: URL: https://github.com/apache/spark/pull/29160#issuecomment-662339436 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

AmplabJenkins commented on pull request #29160: URL: https://github.com/apache/spark/pull/29160#issuecomment-662339436 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

AngersZh commented on a change in pull request #29085: URL: https://github.com/apache/spark/pull/29085#discussion_r458649024 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveScriptTransformationSuite.scala ## @@ -206,75 +169,83 @@ class HiveScr

[GitHub] [spark] SparkQA commented on pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

SparkQA commented on pull request #29160: URL: https://github.com/apache/spark/pull/29160#issuecomment-662338839 **[Test build #126322 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126322/testReport)** for PR 29160 at commit [`2b47cd6`](https://github.com

[GitHub] [spark] cloud-fan commented on a change in pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

cloud-fan commented on a change in pull request #29160: URL: https://github.com/apache/spark/pull/29160#discussion_r458645317 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ## @@ -290,7 +290,7 @@ class DataFrameReader private[sql](sparkSession:

[GitHub] [spark] SparkQA commented on pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

SparkQA commented on pull request #29160: URL: https://github.com/apache/spark/pull/29160#issuecomment-662335140 **[Test build #126321 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126321/testReport)** for PR 29160 at commit [`4de7852`](https://github.com

[GitHub] [spark] HyukjinKwon commented on pull request #29180: [SPARK-17333][PYSPARK] Enable mypy on the repository

HyukjinKwon commented on pull request #29180: URL: https://github.com/apache/spark/pull/29180#issuecomment-662334741 I also tend to think it's not a good idea to put the types into the codes partially. It would make things more difficult to manage. Let's avoid to do it for now. -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

AmplabJenkins removed a comment on pull request #29160: URL: https://github.com/apache/spark/pull/29160#issuecomment-662331930 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

AmplabJenkins commented on pull request #29160: URL: https://github.com/apache/spark/pull/29160#issuecomment-662331930 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] dongjoon-hyun commented on pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

dongjoon-hyun commented on pull request #29160: URL: https://github.com/apache/spark/pull/29160#issuecomment-662331774 I updated the PR according to your comment, @cloud-fan . It looks much better indeed. Thank you so much.

[GitHub] [spark] cloud-fan commented on a change in pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

cloud-fan commented on a change in pull request #29107: URL: https://github.com/apache/spark/pull/29107#discussion_r458638512 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSetOperationsSuite.scala ## @@ -428,7 +428,7 @@ class DataFrameSetOperationsSuite e

[GitHub] [spark] cloud-fan commented on a change in pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

cloud-fan commented on a change in pull request #29107: URL: https://github.com/apache/spark/pull/29107#discussion_r458636985 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ## @@ -683,7 +683,7 @@ abstract class SparkStrategies extend

[GitHub] [spark] xuanyuanking commented on pull request #28977: [WIP] Add all hive.execution suite in the parallel test group

xuanyuanking commented on pull request #28977: URL: https://github.com/apache/spark/pull/28977#issuecomment-662328961 I think the A/B test shows the extra parallel test group for `hive.execution` suites takes effect: Test | Description | Scala test time |

[GitHub] [spark] cloud-fan commented on a change in pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

cloud-fan commented on a change in pull request #29107: URL: https://github.com/apache/spark/pull/29107#discussion_r458635997 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala ## @@ -337,6 +337,10 @@ trait CheckAnalysis extend

[GitHub] [spark] AmplabJenkins commented on pull request #29186: [SPARK-32386][SS][TESTS] Fix temp view leaking in Structured Streaming tests

AmplabJenkins commented on pull request #29186: URL: https://github.com/apache/spark/pull/29186#issuecomment-662328299 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29186: [SPARK-32386][SS][TESTS] Fix temp view leaking in Structured Streaming tests

AmplabJenkins removed a comment on pull request #29186: URL: https://github.com/apache/spark/pull/29186#issuecomment-662328299 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

dongjoon-hyun commented on a change in pull request #29160: URL: https://github.com/apache/spark/pull/29160#discussion_r458635678 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ## @@ -114,7 +114,7 @@ class DataFrameReader private[sql](sparkSess

[GitHub] [spark] SparkQA commented on pull request #29186: [SPARK-32386][SS][TESTS] Fix temp view leaking in Structured Streaming tests

SparkQA commented on pull request #29186: URL: https://github.com/apache/spark/pull/29186#issuecomment-662327785 **[Test build #126320 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126320/testReport)** for PR 29186 at commit [`98c5275`](https://github.com

[GitHub] [spark] cloud-fan commented on a change in pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

cloud-fan commented on a change in pull request #29107: URL: https://github.com/apache/spark/pull/29107#discussion_r458634082 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/PropagateEmptyRelation.scala ## @@ -50,7 +50,7 @@ object PropagateEmp

[GitHub] [spark] xuanyuanking opened a new pull request #29186: [SPARK-32386][SS][TESTS] Fix temp view leaking in Structured Streaming tests

xuanyuanking opened a new pull request #29186: URL: https://github.com/apache/spark/pull/29186 ### What changes were proposed in this pull request? Delete the temp view created by memory source stream writer in Structured Streaming tests. ### Why are the changes needed? The mem

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28977: [WIP] Add all hive.execution suite in the parallel test group

AmplabJenkins removed a comment on pull request #28977: URL: https://github.com/apache/spark/pull/28977#issuecomment-662324835 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29168: [WIP][SPARK-32375][SQL] Basic functionality of table catalog v2 for JDBC

AmplabJenkins removed a comment on pull request #29168: URL: https://github.com/apache/spark/pull/29168#issuecomment-662324831 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] cloud-fan commented on a change in pull request #29107: [SPARK-32308][SQL] Move by-name resolution logic of unionByName from API code to analysis phase

cloud-fan commented on a change in pull request #29107: URL: https://github.com/apache/spark/pull/29107#discussion_r458631494 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1387,7 +1388,7 @@ class Analyzer( i.cop

[GitHub] [spark] AmplabJenkins commented on pull request #29168: [WIP][SPARK-32375][SQL] Basic functionality of table catalog v2 for JDBC

AmplabJenkins commented on pull request #29168: URL: https://github.com/apache/spark/pull/29168#issuecomment-662324831 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #28977: [WIP] Add all hive.execution suite in the parallel test group

AmplabJenkins commented on pull request #28977: URL: https://github.com/apache/spark/pull/28977#issuecomment-662324835 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

AngersZh commented on a change in pull request #29085: URL: https://github.com/apache/spark/pull/29085#discussion_r458631113 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ## @@ -713,13 +714,18 @@ class SparkSqlAstBuilder(conf: SQ

[GitHub] [spark] SparkQA commented on pull request #28977: [WIP] Add all hive.execution suite in the parallel test group

SparkQA commented on pull request #28977: URL: https://github.com/apache/spark/pull/28977#issuecomment-662324250 **[Test build #126319 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126319/testReport)** for PR 28977 at commit [`21b9292`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #29168: [WIP][SPARK-32375][SQL] Basic functionality of table catalog v2 for JDBC

SparkQA commented on pull request #29168: URL: https://github.com/apache/spark/pull/29168#issuecomment-662324201 **[Test build #126318 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126318/testReport)** for PR 29168 at commit [`c4cc924`](https://github.com

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

dongjoon-hyun commented on a change in pull request #29160: URL: https://github.com/apache/spark/pull/29160#discussion_r458627500 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ## @@ -114,7 +114,7 @@ class DataFrameReader private[sql](sparkSess

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

dongjoon-hyun commented on a change in pull request #29160: URL: https://github.com/apache/spark/pull/29160#discussion_r458627500 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ## @@ -114,7 +114,7 @@ class DataFrameReader private[sql](sparkSess

[GitHub] [spark] cloud-fan closed pull request #29176: [MINOR][SQL][TESTS] Create tables once in JDBC tests

cloud-fan closed pull request #29176: URL: https://github.com/apache/spark/pull/29176 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [spark] cloud-fan commented on pull request #29176: [MINOR][SQL][TESTS] Create tables once in JDBC tests

cloud-fan commented on pull request #29176: URL: https://github.com/apache/spark/pull/29176#issuecomment-662321150 thanks, merging to master! This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

dongjoon-hyun commented on a change in pull request #29160: URL: https://github.com/apache/spark/pull/29160#discussion_r458626216 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ## @@ -114,7 +114,7 @@ class DataFrameReader private[sql](sparkSess

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

dongjoon-hyun commented on a change in pull request #29160: URL: https://github.com/apache/spark/pull/29160#discussion_r458626216 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ## @@ -114,7 +114,7 @@ class DataFrameReader private[sql](sparkSess

[GitHub] [spark] cloud-fan commented on a change in pull request #29166: [SPARK-32372][SQL] ResolveReferences.dedupRight should only rewrite attributes for ancestor nodes of the conflict plan

cloud-fan commented on a change in pull request #29166: URL: https://github.com/apache/spark/pull/29166#discussion_r458625525 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1237,20 +1250,42 @@ class Analyzer( if (c

[GitHub] [spark] maropu commented on pull request #29184: [MINOR][SQL] Fix warning message for ThriftCLIService.GetCrossReference and GetPrimaryKeys

maropu commented on pull request #29184: URL: https://github.com/apache/spark/pull/29184#issuecomment-662320088 late LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [spark] cloud-fan commented on a change in pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

cloud-fan commented on a change in pull request #29160: URL: https://github.com/apache/spark/pull/29160#discussion_r458624656 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ## @@ -114,7 +114,7 @@ class DataFrameReader private[sql](sparkSession:

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

AngersZh commented on a change in pull request #29085: URL: https://github.com/apache/spark/pull/29085#discussion_r458624125 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/BaseScriptTransformationSuite.scala ## @@ -0,0 +1,343 @@ +/* + * Licensed to th

[GitHub] [spark] maropu commented on a change in pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

maropu commented on a change in pull request #29085: URL: https://github.com/apache/spark/pull/29085#discussion_r458623671 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveScriptTransformationSuite.scala ## @@ -206,75 +169,83 @@ class HiveScriptTra

[GitHub] [spark] maropu commented on a change in pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

maropu commented on a change in pull request #29085: URL: https://github.com/apache/spark/pull/29085#discussion_r458623671 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveScriptTransformationSuite.scala ## @@ -206,75 +169,83 @@ class HiveScriptTra

[GitHub] [spark] AmplabJenkins commented on pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

AmplabJenkins commented on pull request #29160: URL: https://github.com/apache/spark/pull/29160#issuecomment-662317577 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

AmplabJenkins removed a comment on pull request #29160: URL: https://github.com/apache/spark/pull/29160#issuecomment-662317577 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

dongjoon-hyun commented on a change in pull request #29160: URL: https://github.com/apache/spark/pull/29160#discussion_r458619881 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ## @@ -114,7 +114,7 @@ class DataFrameReader private[sql](sparkSess

[GitHub] [spark] SparkQA commented on pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

SparkQA commented on pull request #29160: URL: https://github.com/apache/spark/pull/29160#issuecomment-662316877 **[Test build #126317 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126317/testReport)** for PR 29160 at commit [`4019789`](https://github.com

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

dongjoon-hyun commented on a change in pull request #29160: URL: https://github.com/apache/spark/pull/29160#discussion_r458619881 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ## @@ -114,7 +114,7 @@ class DataFrameReader private[sql](sparkSess

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

dongjoon-hyun commented on a change in pull request #29160: URL: https://github.com/apache/spark/pull/29160#discussion_r458619294 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ## @@ -114,7 +114,7 @@ class DataFrameReader private[sql](sparkSess

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

AngersZh commented on a change in pull request #29085: URL: https://github.com/apache/spark/pull/29085#discussion_r458620082 ## File path: sql/core/src/test/resources/sql-tests/inputs/transform.sql ## @@ -0,0 +1,72 @@ +-- Test data. +CREATE OR REPLACE TEMPORARY VIEW t1 AS S

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

AngersZh commented on a change in pull request #29085: URL: https://github.com/apache/spark/pull/29085#discussion_r458619650 ## File path: sql/core/src/test/resources/sql-tests/inputs/transform.sql ## @@ -0,0 +1,72 @@ +-- Test data. +CREATE OR REPLACE TEMPORARY VIEW t1 AS S

[GitHub] [spark] cloud-fan commented on a change in pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

cloud-fan commented on a change in pull request #29160: URL: https://github.com/apache/spark/pull/29160#discussion_r458618745 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ## @@ -114,7 +114,7 @@ class DataFrameReader private[sql](sparkSession:

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

AngersZh commented on a change in pull request #29085: URL: https://github.com/apache/spark/pull/29085#discussion_r458618057 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveScriptTransformationSuite.scala ## @@ -206,75 +169,83 @@ class HiveScr

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

AngersZh commented on a change in pull request #29085: URL: https://github.com/apache/spark/pull/29085#discussion_r458617941 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveScriptTransformationSuite.scala ## @@ -206,75 +169,83 @@ class HiveScr

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

AngersZh commented on a change in pull request #29085: URL: https://github.com/apache/spark/pull/29085#discussion_r458617007 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveScriptTransformationSuite.scala ## @@ -192,7 +137,25 @@ class HiveScri

[GitHub] [spark] cloud-fan closed pull request #29184: [MINOR][SQL] Fix warning message for ThriftCLIService.GetCrossReference and GetPrimaryKeys

cloud-fan closed pull request #29184: URL: https://github.com/apache/spark/pull/29184 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

AngersZh commented on a change in pull request #29085: URL: https://github.com/apache/spark/pull/29085#discussion_r458616565 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveScriptTransformationSuite.scala ## @@ -206,75 +169,83 @@ class HiveScr

[GitHub] [spark] maropu commented on a change in pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

maropu commented on a change in pull request #29085: URL: https://github.com/apache/spark/pull/29085#discussion_r458615634 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveScriptTransformationSuite.scala ## @@ -192,7 +137,25 @@ class HiveScriptTran

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

AngersZh commented on a change in pull request #29085: URL: https://github.com/apache/spark/pull/29085#discussion_r458616070 ## File path: sql/core/src/test/resources/sql-tests/results/transform.sql.out ## @@ -0,0 +1,160 @@ +-- Automatically generated by SQLQueryTestSuite +

[GitHub] [spark] cloud-fan commented on pull request #29184: [MINOR][SQL] Fix warning message for ThriftCLIService.GetCrossReference and GetPrimaryKeys

cloud-fan commented on pull request #29184: URL: https://github.com/apache/spark/pull/29184#issuecomment-662312854 thanks, merging to master! This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

AmplabJenkins removed a comment on pull request #29160: URL: https://github.com/apache/spark/pull/29160#issuecomment-662310779 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

AmplabJenkins removed a comment on pull request #29160: URL: https://github.com/apache/spark/pull/29160#issuecomment-662310771 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA removed a comment on pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

SparkQA removed a comment on pull request #29160: URL: https://github.com/apache/spark/pull/29160#issuecomment-662309777 **[Test build #126316 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126316/testReport)** for PR 29160 at commit [`a0c9095`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

AmplabJenkins commented on pull request #29160: URL: https://github.com/apache/spark/pull/29160#issuecomment-662310771 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

SparkQA commented on pull request #29160: URL: https://github.com/apache/spark/pull/29160#issuecomment-662310751 **[Test build #126316 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126316/testReport)** for PR 29160 at commit [`a0c9095`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

SparkQA commented on pull request #29160: URL: https://github.com/apache/spark/pull/29160#issuecomment-662309777 **[Test build #126316 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126316/testReport)** for PR 29160 at commit [`a0c9095`](https://github.com

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

AngersZh commented on a change in pull request #29085: URL: https://github.com/apache/spark/pull/29085#discussion_r458612159 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/BaseScriptTransformationExec.scala ## @@ -87,17 +178,69 @@ trait BaseScriptTran

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

AngersZh commented on a change in pull request #29085: URL: https://github.com/apache/spark/pull/29085#discussion_r458611727 ## File path: sql/core/src/test/resources/sql-tests/inputs/transform.sql ## @@ -0,0 +1,72 @@ +-- Test data. +CREATE OR REPLACE TEMPORARY VIEW t1 AS S

[GitHub] [spark] Ngone51 commented on a change in pull request #29166: [SPARK-32372][SQL] ResolveReferences.dedupRight should only rewrite attributes for ancestor nodes of the conflict plan

Ngone51 commented on a change in pull request #29166: URL: https://github.com/apache/spark/pull/29166#discussion_r458609757 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1237,20 +1250,43 @@ class Analyzer( if (con

[GitHub] [spark] dongjoon-hyun removed a comment on pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

dongjoon-hyun removed a comment on pull request #29160: URL: https://github.com/apache/spark/pull/29160#issuecomment-660845154 Retest this please. This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

dongjoon-hyun commented on a change in pull request #29160: URL: https://github.com/apache/spark/pull/29160#discussion_r458609575 ## File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ## @@ -211,6 +211,7 @@ class DataFrameReader private[sql](sparkSess

[GitHub] [spark] dongjoon-hyun commented on pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

dongjoon-hyun commented on pull request #29160: URL: https://github.com/apache/spark/pull/29160#issuecomment-662307263 Hi, @cloud-fan and @HyukjinKwon . This PR aims to fix this problem completely. Please review the approach. -

[GitHub] [spark] constzhou commented on a change in pull request #29094: [SPARK-24983][SQL] limit number of leaf expressions in a single project when collapse project to prevent driver oom

constzhou commented on a change in pull request #29094: URL: https://github.com/apache/spark/pull/29094#discussion_r458607522 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/CollapseProjectSuite.scala ## @@ -121,6 +121,17 @@ class CollapseProj

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

AngersZh commented on a change in pull request #29085: URL: https://github.com/apache/spark/pull/29085#discussion_r458608523 ## File path: sql/core/src/test/resources/sql-tests/inputs/transform.sql ## @@ -0,0 +1,72 @@ +-- Test data. +CREATE OR REPLACE TEMPORARY VIEW t1 AS S

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

AmplabJenkins removed a comment on pull request #29160: URL: https://github.com/apache/spark/pull/29160#issuecomment-662306904 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29160: [SPARK-32364][SQL] Use CaseInsensitiveMap for DataFrameReader/Writer options

AmplabJenkins commented on pull request #29160: URL: https://github.com/apache/spark/pull/29160#issuecomment-662306904 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

AngersZh commented on a change in pull request #29085: URL: https://github.com/apache/spark/pull/29085#discussion_r458608012 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/BaseScriptTransformationExec.scala ## @@ -56,10 +69,88 @@ trait BaseScriptTrans

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

AngersZh commented on a change in pull request #29085: URL: https://github.com/apache/spark/pull/29085#discussion_r458608774 ## File path: sql/core/src/test/resources/sql-tests/inputs/transform.sql ## @@ -0,0 +1,72 @@ +-- Test data. +CREATE OR REPLACE TEMPORARY VIEW t1 AS S

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

AngersZh commented on a change in pull request #29085: URL: https://github.com/apache/spark/pull/29085#discussion_r458606278 ## File path: sql/core/src/test/resources/sql-tests/results/transform.sql.out ## @@ -0,0 +1,160 @@ +-- Automatically generated by SQLQueryTestSuite +

[GitHub] [spark] maropu commented on a change in pull request #29085: [SPARK-32106][SQL]Implement SparkScriptTransformationExec in sql/core

maropu commented on a change in pull request #29085: URL: https://github.com/apache/spark/pull/29085#discussion_r458596110 ## File path: sql/core/src/test/resources/sql-tests/inputs/transform.sql ## @@ -0,0 +1,72 @@ +-- Test data. +CREATE OR REPLACE TEMPORARY VIEW t1 AS SELECT

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29184: [MINOR][SQL] Fix warning message for ThriftCLIService.GetCrossReference and GetPrimaryKeys

AmplabJenkins removed a comment on pull request #29184: URL: https://github.com/apache/spark/pull/29184#issuecomment-662300728 This is an automated message from the Apache Git Service. To respond to the message, please log on

<    4   5   6   7   8   9   10   11   >