[GitHub] [spark] Fokko commented on a change in pull request #29121: [SPARK-32319][PYSPARK] Remove unused imports

2020-07-24 Thread GitBox
Fokko commented on a change in pull request #29121: URL: https://github.com/apache/spark/pull/29121#discussion_r460374360 ## File path: python/pyspark/cloudpickle/cloudpickle.py ## @@ -57,7 +57,6 @@ from .compat import pickle from typing import Generic, Union, Tuple, Callable

[GitHub] [spark] Fokko commented on a change in pull request #29121: [SPARK-32319][PYSPARK] Remove unused imports

2020-07-24 Thread GitBox
Fokko commented on a change in pull request #29121: URL: https://github.com/apache/spark/pull/29121#discussion_r460374402 ## File path: python/pyspark/heapq3.py ## @@ -865,7 +865,7 @@ def nlargest(n, iterable, key=None): # If available, use C implementation try: -from _

[GitHub] [spark] viirya commented on a change in pull request #29229: [SPARK-32435][PYTHON] Remove heapq3 port from Python 3

2020-07-24 Thread GitBox
viirya commented on a change in pull request #29229: URL: https://github.com/apache/spark/pull/29229#discussion_r460372941 ## File path: python/pyspark/shuffle.py ## @@ -25,7 +25,7 @@ import random import sys -import pyspark.heapq3 as heapq +import heapq Review comment:

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29121: [SPARK-32319][PYSPARK] Remove unused imports

2020-07-24 Thread GitBox
AmplabJenkins removed a comment on pull request #29121: URL: https://github.com/apache/spark/pull/29121#issuecomment-663816674 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29121: [SPARK-32319][PYSPARK] Remove unused imports

2020-07-24 Thread GitBox
AmplabJenkins commented on pull request #29121: URL: https://github.com/apache/spark/pull/29121#issuecomment-663816674 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #29121: [SPARK-32319][PYSPARK] Remove unused imports

2020-07-24 Thread GitBox
SparkQA removed a comment on pull request #29121: URL: https://github.com/apache/spark/pull/29121#issuecomment-663803067 **[Test build #126525 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126525/testReport)** for PR 29121 at commit [`582a7ef`](https://gi

[GitHub] [spark] SparkQA commented on pull request #29121: [SPARK-32319][PYSPARK] Remove unused imports

2020-07-24 Thread GitBox
SparkQA commented on pull request #29121: URL: https://github.com/apache/spark/pull/29121#issuecomment-663816532 **[Test build #126525 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126525/testReport)** for PR 29121 at commit [`582a7ef`](https://github.co

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29229: [SPARK-32435][PYTHON] Remove heapq3 port from Python 3

2020-07-24 Thread GitBox
HyukjinKwon commented on a change in pull request #29229: URL: https://github.com/apache/spark/pull/29229#discussion_r460371504 ## File path: python/pyspark/shuffle.py ## @@ -498,7 +498,7 @@ def load(f): if current_chunk: chunks.append(iter(current_chunk))

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29229: [SPARK-32435][PYTHON] Remove heapq3 port from Python 3

2020-07-24 Thread GitBox
AmplabJenkins removed a comment on pull request #29229: URL: https://github.com/apache/spark/pull/29229#issuecomment-663816254 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29229: [SPARK-32435][PYTHON] Remove heapq3 port from Python 3

2020-07-24 Thread GitBox
AmplabJenkins commented on pull request #29229: URL: https://github.com/apache/spark/pull/29229#issuecomment-663816254 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29229: [SPARK-32435][PYTHON] Remove heapq3 port from Python 3

2020-07-24 Thread GitBox
SparkQA commented on pull request #29229: URL: https://github.com/apache/spark/pull/29229#issuecomment-663816172 **[Test build #126529 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126529/testReport)** for PR 29229 at commit [`d15a556`](https://github.com

[GitHub] [spark] HyukjinKwon commented on pull request #29229: [SPARK-32435][PYTHON] Remove heapq3 port from Python 3

2020-07-24 Thread GitBox
HyukjinKwon commented on pull request #29229: URL: https://github.com/apache/spark/pull/29229#issuecomment-663816066 @srowen, @JoshRosen @viirya can you take a look when you're available please? This is an automated message f

[GitHub] [spark] HyukjinKwon opened a new pull request #29229: [SPARK-32435][PYTHON] Remove heapq3 port from Python 3

2020-07-24 Thread GitBox
HyukjinKwon opened a new pull request #29229: URL: https://github.com/apache/spark/pull/29229 ### What changes were proposed in this pull request? This PR removes the manual port of `heapq3.py` introduced from SPARK-3073. The main reason of this was to support Python 2.6 and 2.7 beca

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29228: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-07-24 Thread GitBox
AmplabJenkins removed a comment on pull request #29228: URL: https://github.com/apache/spark/pull/29228#issuecomment-663815547 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29228: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-07-24 Thread GitBox
AmplabJenkins commented on pull request #29228: URL: https://github.com/apache/spark/pull/29228#issuecomment-663815547 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #29228: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-07-24 Thread GitBox
SparkQA removed a comment on pull request #29228: URL: https://github.com/apache/spark/pull/29228#issuecomment-663802397 **[Test build #126524 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126524/testReport)** for PR 29228 at commit [`acb4e80`](https://gi

[GitHub] [spark] SparkQA commented on pull request #29228: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-07-24 Thread GitBox
SparkQA commented on pull request #29228: URL: https://github.com/apache/spark/pull/29228#issuecomment-663815399 **[Test build #126524 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126524/testReport)** for PR 29228 at commit [`acb4e80`](https://github.co

[GitHub] [spark] gengliangwang commented on pull request #29020: [SPARK-23431][CORE] Expose stage level peak executor metrics via REST API

2020-07-24 Thread GitBox
gengliangwang commented on pull request #29020: URL: https://github.com/apache/spark/pull/29020#issuecomment-663815010 @dongjoon-hyun Thanks for the reminder! This is an automated message from the Apache Git Service. To respo

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28968: [SPARK-32010][PYTHON][CORE] Add InheritableThread for local properties and fixing a thread leak issue in pinned thread mode

2020-07-24 Thread GitBox
AmplabJenkins removed a comment on pull request #28968: URL: https://github.com/apache/spark/pull/28968#issuecomment-663814316 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28968: [SPARK-32010][PYTHON][CORE] Add InheritableThread for local properties and fixing a thread leak issue in pinned thread mode

2020-07-24 Thread GitBox
AmplabJenkins commented on pull request #28968: URL: https://github.com/apache/spark/pull/28968#issuecomment-663814316 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #28968: [SPARK-32010][PYTHON][CORE] Add InheritableThread for local properties and fixing a thread leak issue in pinned thread mode

2020-07-24 Thread GitBox
SparkQA removed a comment on pull request #28968: URL: https://github.com/apache/spark/pull/28968#issuecomment-663812052 **[Test build #126528 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126528/testReport)** for PR 28968 at commit [`a78fd43`](https://gi

[GitHub] [spark] SparkQA commented on pull request #28968: [SPARK-32010][PYTHON][CORE] Add InheritableThread for local properties and fixing a thread leak issue in pinned thread mode

2020-07-24 Thread GitBox
SparkQA commented on pull request #28968: URL: https://github.com/apache/spark/pull/28968#issuecomment-663814251 **[Test build #126528 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126528/testReport)** for PR 28968 at commit [`a78fd43`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29227: [SPARK-32434][CORE] Support Scala 2.13 in AbstractCommandBuilder and load-spark-env scripts

2020-07-24 Thread GitBox
AmplabJenkins removed a comment on pull request #29227: URL: https://github.com/apache/spark/pull/29227#issuecomment-663812247 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29227: [SPARK-32434][CORE] Support Scala 2.13 in AbstractCommandBuilder and load-spark-env scripts

2020-07-24 Thread GitBox
AmplabJenkins commented on pull request #29227: URL: https://github.com/apache/spark/pull/29227#issuecomment-663812247 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29227: [SPARK-32434][CORE] Support Scala 2.13 in AbstractCommandBuilder and load-spark-env scripts

2020-07-24 Thread GitBox
SparkQA commented on pull request #29227: URL: https://github.com/apache/spark/pull/29227#issuecomment-663812083 **[Test build #126522 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126522/testReport)** for PR 29227 at commit [`5ddfdbf`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #29227: [SPARK-32434][CORE] Support Scala 2.13 in AbstractCommandBuilder and load-spark-env scripts

2020-07-24 Thread GitBox
SparkQA removed a comment on pull request #29227: URL: https://github.com/apache/spark/pull/29227#issuecomment-663799771 **[Test build #126522 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126522/testReport)** for PR 29227 at commit [`5ddfdbf`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29227: [SPARK-32434][CORE] Support Scala 2.13 in AbstractCommandBuilder and load-spark-env scripts

2020-07-24 Thread GitBox
AmplabJenkins removed a comment on pull request #29227: URL: https://github.com/apache/spark/pull/29227#issuecomment-663812031 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29227: [SPARK-32434][CORE] Support Scala 2.13 in AbstractCommandBuilder and load-spark-env scripts

2020-07-24 Thread GitBox
AmplabJenkins commented on pull request #29227: URL: https://github.com/apache/spark/pull/29227#issuecomment-663812031 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #28968: [SPARK-32010][PYTHON][CORE] Add InheritableThread for local properties and fixing a thread leak issue in pinned thread mode

2020-07-24 Thread GitBox
SparkQA commented on pull request #28968: URL: https://github.com/apache/spark/pull/28968#issuecomment-663812052 **[Test build #126528 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126528/testReport)** for PR 28968 at commit [`a78fd43`](https://github.com

[GitHub] [spark] SparkQA removed a comment on pull request #29227: [SPARK-32434][CORE] Support Scala 2.13 in AbstractCommandBuilder and load-spark-env scripts

2020-07-24 Thread GitBox
SparkQA removed a comment on pull request #29227: URL: https://github.com/apache/spark/pull/29227#issuecomment-663798988 **[Test build #126521 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126521/testReport)** for PR 29227 at commit [`614d293`](https://gi

[GitHub] [spark] SparkQA commented on pull request #29227: [SPARK-32434][CORE] Support Scala 2.13 in AbstractCommandBuilder and load-spark-env scripts

2020-07-24 Thread GitBox
SparkQA commented on pull request #29227: URL: https://github.com/apache/spark/pull/29227#issuecomment-663811862 **[Test build #126521 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126521/testReport)** for PR 29227 at commit [`614d293`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28968: [SPARK-32010][PYTHON][CORE] Add InheritableThread for local properties and fixing a thread leak issue in pinned thread mode

2020-07-24 Thread GitBox
AmplabJenkins removed a comment on pull request #28968: URL: https://github.com/apache/spark/pull/28968#issuecomment-663811589 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28968: [SPARK-32010][PYTHON][CORE] Add InheritableThread for local properties and fixing a thread leak issue in pinned thread mode

2020-07-24 Thread GitBox
AmplabJenkins commented on pull request #28968: URL: https://github.com/apache/spark/pull/28968#issuecomment-663811589 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] HyukjinKwon commented on pull request #28968: [SPARK-32010][PYTHON][CORE] Add InheritableThread for local properties and fixing a thread leak issue in pinned thread mode

2020-07-24 Thread GitBox
HyukjinKwon commented on pull request #28968: URL: https://github.com/apache/spark/pull/28968#issuecomment-663811508 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [spark] HyukjinKwon commented on pull request #29222: [SPARK-32428] [EXAMPLES] Make BinaryClassificationMetricsExample cons…

2020-07-24 Thread GitBox
HyukjinKwon commented on pull request #29222: URL: https://github.com/apache/spark/pull/29222#issuecomment-663809518 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [spark] AmplabJenkins commented on pull request #29014: [SPARK-32199][SPARK-32198] Reduce job failures during decommissioning

2020-07-24 Thread GitBox
AmplabJenkins commented on pull request #29014: URL: https://github.com/apache/spark/pull/29014#issuecomment-663809218 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29014: [SPARK-32199][SPARK-32198] Reduce job failures during decommissioning

2020-07-24 Thread GitBox
AmplabJenkins removed a comment on pull request #29014: URL: https://github.com/apache/spark/pull/29014#issuecomment-663809218 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #29014: [SPARK-32199][SPARK-32198] Reduce job failures during decommissioning

2020-07-24 Thread GitBox
SparkQA commented on pull request #29014: URL: https://github.com/apache/spark/pull/29014#issuecomment-663809146 **[Test build #126527 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126527/testReport)** for PR 29014 at commit [`fb8f39d`](https://github.com

[GitHub] [spark] HyukjinKwon commented on pull request #29215: [SPARK-32363][PYTHON][BUILD][3.0] Fix flakiness in pip package testing in Jenkins

2020-07-24 Thread GitBox
HyukjinKwon commented on pull request #29215: URL: https://github.com/apache/spark/pull/29215#issuecomment-663809125 Thank you @dongjoon-hyun. This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29226: Fix flakyness of BlockManagerDecommissionIntegrationSuite

2020-07-24 Thread GitBox
AmplabJenkins removed a comment on pull request #29226: URL: https://github.com/apache/spark/pull/29226#issuecomment-663808753 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126

[GitHub] [spark] SparkQA removed a comment on pull request #29226: Fix flakyness of BlockManagerDecommissionIntegrationSuite

2020-07-24 Thread GitBox
SparkQA removed a comment on pull request #29226: URL: https://github.com/apache/spark/pull/29226#issuecomment-663808556 **[Test build #126526 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126526/testReport)** for PR 29226 at commit [`288c34e`](https://gi

[GitHub] [spark] xuanyuanking commented on a change in pull request #24173: [SPARK-27237][SS] Introduce State schema validation among query restart

2020-07-24 Thread GitBox
xuanyuanking commented on a change in pull request #24173: URL: https://github.com/apache/spark/pull/24173#discussion_r460363515 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStore.scala ## @@ -509,4 +549,3 @@ object StateStore exten

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29226: Fix flakyness of BlockManagerDecommissionIntegrationSuite

2020-07-24 Thread GitBox
AmplabJenkins removed a comment on pull request #29226: URL: https://github.com/apache/spark/pull/29226#issuecomment-663808748 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA commented on pull request #29226: Fix flakyness of BlockManagerDecommissionIntegrationSuite

2020-07-24 Thread GitBox
SparkQA commented on pull request #29226: URL: https://github.com/apache/spark/pull/29226#issuecomment-663808742 **[Test build #126526 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126526/testReport)** for PR 29226 at commit [`288c34e`](https://github.co

[GitHub] [spark] AmplabJenkins commented on pull request #29226: Fix flakyness of BlockManagerDecommissionIntegrationSuite

2020-07-24 Thread GitBox
AmplabJenkins commented on pull request #29226: URL: https://github.com/apache/spark/pull/29226#issuecomment-663808748 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29226: Fix flakyness of BlockManagerDecommissionIntegrationSuite

2020-07-24 Thread GitBox
AmplabJenkins removed a comment on pull request #29226: URL: https://github.com/apache/spark/pull/29226#issuecomment-663808623 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29226: Fix flakyness of BlockManagerDecommissionIntegrationSuite

2020-07-24 Thread GitBox
AmplabJenkins commented on pull request #29226: URL: https://github.com/apache/spark/pull/29226#issuecomment-663808623 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29226: Fix flakyness of BlockManagerDecommissionIntegrationSuite

2020-07-24 Thread GitBox
SparkQA commented on pull request #29226: URL: https://github.com/apache/spark/pull/29226#issuecomment-663808556 **[Test build #126526 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126526/testReport)** for PR 29226 at commit [`288c34e`](https://github.com

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29121: [SPARK-32319][PYSPARK] Remove unused imports

2020-07-24 Thread GitBox
HyukjinKwon commented on a change in pull request #29121: URL: https://github.com/apache/spark/pull/29121#discussion_r460362434 ## File path: python/pyspark/ml/tests/test_stat.py ## @@ -40,7 +40,7 @@ def test_chisquaretest(self): if __name__ == "__main__": -from pyspar

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29121: [SPARK-32319][PYSPARK] Remove unused imports

2020-07-24 Thread GitBox
HyukjinKwon commented on a change in pull request #29121: URL: https://github.com/apache/spark/pull/29121#discussion_r460362184 ## File path: python/pyspark/heapq3.py ## @@ -865,7 +865,7 @@ def nlargest(n, iterable, key=None): # If available, use C implementation try: -

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29121: [SPARK-32319][PYSPARK] Remove unused imports

2020-07-24 Thread GitBox
HyukjinKwon commented on a change in pull request #29121: URL: https://github.com/apache/spark/pull/29121#discussion_r460361924 ## File path: python/pyspark/cloudpickle/cloudpickle.py ## @@ -57,7 +57,6 @@ from .compat import pickle from typing import Generic, Union, Tuple, Ca

[GitHub] [spark] HyukjinKwon commented on pull request #29218: [SPARK-32408][BUILD] Enable crossPaths back to prevent side effects

2020-07-24 Thread GitBox
HyukjinKwon commented on pull request #29218: URL: https://github.com/apache/spark/pull/29218#issuecomment-663805469 Thank you @dongjoon-hyun. This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [spark] HyukjinKwon closed pull request #29212: [SPARK-32419][PYTHON][BUILD] Avoid using subshell for Conda env (de)activation in pip packaging test

2020-07-24 Thread GitBox
HyukjinKwon closed pull request #29212: URL: https://github.com/apache/spark/pull/29212 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] HyukjinKwon commented on pull request #29212: [SPARK-32419][PYTHON][BUILD] Avoid using subshell for Conda env (de)activation in pip packaging test

2020-07-24 Thread GitBox
HyukjinKwon commented on pull request #29212: URL: https://github.com/apache/spark/pull/29212#issuecomment-663805318 Merged to master. This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [spark] HyukjinKwon commented on pull request #29212: [SPARK-32419][PYTHON][BUILD] Avoid using subshell for Conda env (de)activation in pip packaging test

2020-07-24 Thread GitBox
HyukjinKwon commented on pull request #29212: URL: https://github.com/apache/spark/pull/29212#issuecomment-663805260 @dongjoon-hyun and @srowen, let me merge this to make GitHub Actions correctly tests pip packaging. At least it fixes the issue as shown above and I am pretty sure this fix

[GitHub] [spark] HyukjinKwon edited a comment on pull request #29217: [SPARK-32422][SQL][TESTS] Use python3 executable instead of python3.6 in IntegratedUDFTestUtils

2020-07-24 Thread GitBox
HyukjinKwon edited a comment on pull request #29217: URL: https://github.com/apache/spark/pull/29217#issuecomment-663804755 I think it's okay. Installing Python 3.8 in GitHub Actions overwrites `python3`. So, we won't face the tests being skipped even when we backport as long as there's th

[GitHub] [spark] HyukjinKwon edited a comment on pull request #29217: [SPARK-32422][SQL][TESTS] Use python3 executable instead of python3.6 in IntegratedUDFTestUtils

2020-07-24 Thread GitBox
HyukjinKwon edited a comment on pull request #29217: URL: https://github.com/apache/spark/pull/29217#issuecomment-663804755 I think it's okay. Installing Python 3.8 in GitHub Actions overwrites `python3`. So, we won't face the tests being skipped even when we backport as long as there's th

[GitHub] [spark] HyukjinKwon commented on pull request #29217: [SPARK-32422][SQL][TESTS] Use python3 executable instead of python3.6 in IntegratedUDFTestUtils

2020-07-24 Thread GitBox
HyukjinKwon commented on pull request #29217: URL: https://github.com/apache/spark/pull/29217#issuecomment-663804755 I think it's okay. Installing Python 3.8 in GitHub Actions overwrites `python3`. So, we won't face the tests being skipped even when we backport as long as the explicit Pyth

[GitHub] [spark] HyukjinKwon edited a comment on pull request #29217: [SPARK-32422][SQL][TESTS] Use python3 executable instead of python3.6 in IntegratedUDFTestUtils

2020-07-24 Thread GitBox
HyukjinKwon edited a comment on pull request #29217: URL: https://github.com/apache/spark/pull/29217#issuecomment-663804755 I think it's okay. Installing Python 3.8 in GitHub Actions overwrites `python3`. So, we won't face the tests being skipped even when we backport as long as there's th

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29227: [SPARK-32434][CORE] Support Scala 2.13 in AbstractCommandBuilder and load-spark-env scripts

2020-07-24 Thread GitBox
AmplabJenkins removed a comment on pull request #29227: URL: https://github.com/apache/spark/pull/29227#issuecomment-663803486 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29227: [SPARK-32434][CORE] Support Scala 2.13 in AbstractCommandBuilder and load-spark-env scripts

2020-07-24 Thread GitBox
AmplabJenkins commented on pull request #29227: URL: https://github.com/apache/spark/pull/29227#issuecomment-663803486 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #29227: [SPARK-32434][CORE] Support Scala 2.13 in AbstractCommandBuilder and load-spark-env scripts

2020-07-24 Thread GitBox
SparkQA removed a comment on pull request #29227: URL: https://github.com/apache/spark/pull/29227#issuecomment-663788798 **[Test build #126519 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126519/testReport)** for PR 29227 at commit [`a445d2f`](https://gi

[GitHub] [spark] SparkQA commented on pull request #29227: [SPARK-32434][CORE] Support Scala 2.13 in AbstractCommandBuilder and load-spark-env scripts

2020-07-24 Thread GitBox
SparkQA commented on pull request #29227: URL: https://github.com/apache/spark/pull/29227#issuecomment-663803331 **[Test build #126519 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126519/testReport)** for PR 29227 at commit [`a445d2f`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29121: [SPARK-32319][PYSPARK] Remove unused imports

2020-07-24 Thread GitBox
AmplabJenkins removed a comment on pull request #29121: URL: https://github.com/apache/spark/pull/29121#issuecomment-663803155 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29121: [SPARK-32319][PYSPARK] Remove unused imports

2020-07-24 Thread GitBox
AmplabJenkins commented on pull request #29121: URL: https://github.com/apache/spark/pull/29121#issuecomment-663803155 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29121: [SPARK-32319][PYSPARK] Remove unused imports

2020-07-24 Thread GitBox
SparkQA commented on pull request #29121: URL: https://github.com/apache/spark/pull/29121#issuecomment-663803067 **[Test build #126525 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126525/testReport)** for PR 29121 at commit [`582a7ef`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29228: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-07-24 Thread GitBox
AmplabJenkins removed a comment on pull request #29228: URL: https://github.com/apache/spark/pull/29228#issuecomment-663802552 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] dongjoon-hyun commented on pull request #29121: [SPARK-32319][PYSPARK] Remove unused imports

2020-07-24 Thread GitBox
dongjoon-hyun commented on pull request #29121: URL: https://github.com/apache/spark/pull/29121#issuecomment-663802581 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [spark] AmplabJenkins commented on pull request #29228: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-07-24 Thread GitBox
AmplabJenkins commented on pull request #29228: URL: https://github.com/apache/spark/pull/29228#issuecomment-663802552 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] agrawaldevesh commented on pull request #29226: Fix flakyness of BlockManagerDecommissionIntegrationSuite

2020-07-24 Thread GitBox
agrawaldevesh commented on pull request #29226: URL: https://github.com/apache/spark/pull/29226#issuecomment-663802421 Sorry it didn't work. I will make another go at it. This is an automated message from the Apache Git Serv

[GitHub] [spark] SparkQA commented on pull request #29228: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-07-24 Thread GitBox
SparkQA commented on pull request #29228: URL: https://github.com/apache/spark/pull/29228#issuecomment-663802397 **[Test build #126524 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126524/testReport)** for PR 29228 at commit [`acb4e80`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29002: [SPARK-32175][CORE] Fix the order between initialization for ExecutorPlugin and starting heartbeat thread

2020-07-24 Thread GitBox
AmplabJenkins removed a comment on pull request #29002: URL: https://github.com/apache/spark/pull/29002#issuecomment-663802208 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29002: [SPARK-32175][CORE] Fix the order between initialization for ExecutorPlugin and starting heartbeat thread

2020-07-24 Thread GitBox
AmplabJenkins removed a comment on pull request #29002: URL: https://github.com/apache/spark/pull/29002#issuecomment-663802206 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #29002: [SPARK-32175][CORE] Fix the order between initialization for ExecutorPlugin and starting heartbeat thread

2020-07-24 Thread GitBox
AmplabJenkins commented on pull request #29002: URL: https://github.com/apache/spark/pull/29002#issuecomment-663802206 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA removed a comment on pull request #29002: [SPARK-32175][CORE] Fix the order between initialization for ExecutorPlugin and starting heartbeat thread

2020-07-24 Thread GitBox
SparkQA removed a comment on pull request #29002: URL: https://github.com/apache/spark/pull/29002#issuecomment-663790544 **[Test build #126520 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126520/testReport)** for PR 29002 at commit [`0b8da96`](https://gi

[GitHub] [spark] SparkQA commented on pull request #29002: [SPARK-32175][CORE] Fix the order between initialization for ExecutorPlugin and starting heartbeat thread

2020-07-24 Thread GitBox
SparkQA commented on pull request #29002: URL: https://github.com/apache/spark/pull/29002#issuecomment-663802095 **[Test build #126520 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126520/testReport)** for PR 29002 at commit [`0b8da96`](https://github.co

[GitHub] [spark] titsuki commented on pull request #29222: [SPARK-32428] [EXAMPLES] Make BinaryClassificationMetricsExample cons…

2020-07-24 Thread GitBox
titsuki commented on pull request #29222: URL: https://github.com/apache/spark/pull/29222#issuecomment-663801010 @huaxingao @srowen Thanks for your reviews! I've also fixed the other examples. This is an automated message

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29228: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-07-24 Thread GitBox
AmplabJenkins removed a comment on pull request #29228: URL: https://github.com/apache/spark/pull/29228#issuecomment-663800607 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29228: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-07-24 Thread GitBox
AmplabJenkins removed a comment on pull request #29228: URL: https://github.com/apache/spark/pull/29228#issuecomment-663800601 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA removed a comment on pull request #29228: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-07-24 Thread GitBox
SparkQA removed a comment on pull request #29228: URL: https://github.com/apache/spark/pull/29228#issuecomment-663800430 **[Test build #126523 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126523/testReport)** for PR 29228 at commit [`14de6c2`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #29228: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-07-24 Thread GitBox
AmplabJenkins commented on pull request #29228: URL: https://github.com/apache/spark/pull/29228#issuecomment-663800601 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29228: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-07-24 Thread GitBox
SparkQA commented on pull request #29228: URL: https://github.com/apache/spark/pull/29228#issuecomment-663800599 **[Test build #126523 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126523/testReport)** for PR 29228 at commit [`14de6c2`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #29228: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-07-24 Thread GitBox
SparkQA commented on pull request #29228: URL: https://github.com/apache/spark/pull/29228#issuecomment-663800430 **[Test build #126523 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126523/testReport)** for PR 29228 at commit [`14de6c2`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29228: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-07-24 Thread GitBox
AmplabJenkins removed a comment on pull request #29228: URL: https://github.com/apache/spark/pull/29228#issuecomment-663799898 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29227: [SPARK-32434][CORE] Support Scala 2.13 in AbstractCommandBuilder and load-spark-env scripts

2020-07-24 Thread GitBox
AmplabJenkins removed a comment on pull request #29227: URL: https://github.com/apache/spark/pull/29227#issuecomment-663799916 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29227: [SPARK-32434][CORE] Support Scala 2.13 in AbstractCommandBuilder and load-spark-env scripts

2020-07-24 Thread GitBox
AmplabJenkins commented on pull request #29227: URL: https://github.com/apache/spark/pull/29227#issuecomment-663799916 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] beliefer commented on pull request #28917: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-07-24 Thread GitBox
beliefer commented on pull request #28917: URL: https://github.com/apache/spark/pull/28917#issuecomment-663799879 Because conflicts, I will close this PR. This is an automated message from the Apache Git Service. To respond t

[GitHub] [spark] AmplabJenkins commented on pull request #29228: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-07-24 Thread GitBox
AmplabJenkins commented on pull request #29228: URL: https://github.com/apache/spark/pull/29228#issuecomment-663799898 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] beliefer commented on pull request #29228: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-07-24 Thread GitBox
beliefer commented on pull request #29228: URL: https://github.com/apache/spark/pull/29228#issuecomment-663799816 cc @jiangxb1987 @Ngone51 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [spark] beliefer closed pull request #28917: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-07-24 Thread GitBox
beliefer closed pull request #28917: URL: https://github.com/apache/spark/pull/28917 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] beliefer opened a new pull request #29228: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-07-24 Thread GitBox
beliefer opened a new pull request #29228: URL: https://github.com/apache/spark/pull/29228 ### What changes were proposed in this pull request? `DAGSchedulerSuite` exists some issue: `afterEach` and init are called when the `SparkConf` of the default `SparkContext` has no configuratio

[GitHub] [spark] SparkQA commented on pull request #29227: [SPARK-32434][CORE] Support Scala 2.13 in AbstractCommandBuilder and load-spark-env scripts

2020-07-24 Thread GitBox
SparkQA commented on pull request #29227: URL: https://github.com/apache/spark/pull/29227#issuecomment-663799771 **[Test build #126522 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126522/testReport)** for PR 29227 at commit [`5ddfdbf`](https://github.com

[GitHub] [spark] dongjoon-hyun commented on pull request #29227: [SPARK-32434][CORE] Support Scala 2.13 in AbstractCommandBuilder and load-spark-env scripts

2020-07-24 Thread GitBox
dongjoon-hyun commented on pull request #29227: URL: https://github.com/apache/spark/pull/29227#issuecomment-663799656 @srowen . The order is flipped in three files. `else` statement is assigned to Scala 2.12 always. This is

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29227: [SPARK-32434][CORE] Support Scala 2.13 in AbstractCommandBuilder and load-spark-env scripts

2020-07-24 Thread GitBox
AmplabJenkins removed a comment on pull request #29227: URL: https://github.com/apache/spark/pull/29227#issuecomment-663799101 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29227: [SPARK-32434][CORE] Support Scala 2.13 in AbstractCommandBuilder and load-spark-env scripts

2020-07-24 Thread GitBox
AmplabJenkins commented on pull request #29227: URL: https://github.com/apache/spark/pull/29227#issuecomment-663799101 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #29227: [SPARK-32434][CORE] Support Scala 2.13 in AbstractCommandBuilder and load-spark-env scripts

2020-07-24 Thread GitBox
SparkQA commented on pull request #29227: URL: https://github.com/apache/spark/pull/29227#issuecomment-663798988 **[Test build #126521 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126521/testReport)** for PR 29227 at commit [`614d293`](https://github.com

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29227: [SPARK-32434][CORE] Support Scala 2.13 in AbstractCommandBuilder and load-spark-env scripts

2020-07-24 Thread GitBox
dongjoon-hyun commented on a change in pull request #29227: URL: https://github.com/apache/spark/pull/29227#discussion_r460355637 ## File path: bin/load-spark-env.cmd ## @@ -37,26 +37,24 @@ if [%SPARK_ENV_LOADED%] == [] ( rem Setting SPARK_SCALA_VERSION if not already set.

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29226: Fix flakyness of BlockManagerDecommissionIntegrationSuite

2020-07-24 Thread GitBox
AmplabJenkins removed a comment on pull request #29226: URL: https://github.com/apache/spark/pull/29226#issuecomment-663798416 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] imback82 commented on pull request #29020: [SPARK-23431][CORE] Expose stage level peak executor metrics via REST API

2020-07-24 Thread GitBox
imback82 commented on pull request #29020: URL: https://github.com/apache/spark/pull/29020#issuecomment-663798434 Thanks @wypoon for the suggestion. I updated the description, and hopefully that clarifies things a bit more.

[GitHub] [spark] AmplabJenkins commented on pull request #29226: Fix flakyness of BlockManagerDecommissionIntegrationSuite

2020-07-24 Thread GitBox
AmplabJenkins commented on pull request #29226: URL: https://github.com/apache/spark/pull/29226#issuecomment-663798416 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

  1   2   3   4   5   6   7   8   >