[GitHub] [spark] AmplabJenkins removed a comment on pull request #29807: [SPARK-32939][SQL]Avoid re-compute expensive expression

2020-09-18 Thread GitBox
AmplabJenkins removed a comment on pull request #29807: URL: https://github.com/apache/spark/pull/29807#issuecomment-695169067 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29807: [SPARK-32939][SQL]Avoid re-compute expensive expression

2020-09-18 Thread GitBox
AmplabJenkins commented on pull request #29807: URL: https://github.com/apache/spark/pull/29807#issuecomment-695169067 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29807: [SPARK-32939][SQL]Avoid re-compute expensive expression

2020-09-18 Thread GitBox
SparkQA commented on pull request #29807: URL: https://github.com/apache/spark/pull/29807#issuecomment-695168995 **[Test build #128885 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128885/testReport)** for PR 29807 at commit

[GitHub] [spark] AngersZhuuuu opened a new pull request #29807: [SPARK-32939][SQL]Avoid re-compute expensive expression

2020-09-18 Thread GitBox
AngersZh opened a new pull request #29807: URL: https://github.com/apache/spark/pull/29807 ### What changes were proposed in this pull request? ``` test("SPARK-32939: Expensive expr re-compute demo") { withTable("t") { withTempDir { loc => sql(

[GitHub] [spark] cchighman commented on pull request #28841: [SPARK-31962][SQL] Provide modifiedAfter and modifiedBefore options when filtering from a batch-based file data source

2020-09-18 Thread GitBox
cchighman commented on pull request #28841: URL: https://github.com/apache/spark/pull/28841#issuecomment-695165544 > BTW, welcome to the Apache Spark community and thank you for your first contribution, @cchighman . @Dooyoung-Hwang Thank you very much! Hopefully after compiling

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29781: [SPARK-32189][DOCS][PYTHON] Development - Setting PySpark with PyCharm

2020-09-18 Thread GitBox
AmplabJenkins removed a comment on pull request #29781: URL: https://github.com/apache/spark/pull/29781#issuecomment-695164896 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29781: [SPARK-32189][DOCS][PYTHON] Development - Setting PySpark with PyCharm

2020-09-18 Thread GitBox
AmplabJenkins commented on pull request #29781: URL: https://github.com/apache/spark/pull/29781#issuecomment-695164896 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #29781: [SPARK-32189][DOCS][PYTHON] Development - Setting PySpark with PyCharm

2020-09-18 Thread GitBox
SparkQA removed a comment on pull request #29781: URL: https://github.com/apache/spark/pull/29781#issuecomment-695162982 **[Test build #128884 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128884/testReport)** for PR 29781 at commit

[GitHub] [spark] SparkQA commented on pull request #29781: [SPARK-32189][DOCS][PYTHON] Development - Setting PySpark with PyCharm

2020-09-18 Thread GitBox
SparkQA commented on pull request #29781: URL: https://github.com/apache/spark/pull/29781#issuecomment-695164840 **[Test build #128884 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128884/testReport)** for PR 29781 at commit

[GitHub] [spark] cchighman commented on pull request #28841: [SPARK-31962][SQL] Provide modifiedAfter and modifiedBefore options when filtering from a batch-based file data source

2020-09-18 Thread GitBox
cchighman commented on pull request #28841: URL: https://github.com/apache/spark/pull/28841#issuecomment-695164039 > I roughly checked the code and I think you need to brush up more by referring the other code and the style doc. Could you? The proposed idea itself looks good and I think

[GitHub] [spark] AmplabJenkins commented on pull request #29781: [SPARK-32189][DOCS][PYTHON] Development - Setting PySpark with PyCharm

2020-09-18 Thread GitBox
AmplabJenkins commented on pull request #29781: URL: https://github.com/apache/spark/pull/29781#issuecomment-695163079 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29781: [SPARK-32189][DOCS][PYTHON] Development - Setting PySpark with PyCharm

2020-09-18 Thread GitBox
AmplabJenkins removed a comment on pull request #29781: URL: https://github.com/apache/spark/pull/29781#issuecomment-695163079 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #29781: [SPARK-32189][DOCS][PYTHON] Development - Setting PySpark with PyCharm

2020-09-18 Thread GitBox
SparkQA commented on pull request #29781: URL: https://github.com/apache/spark/pull/29781#issuecomment-695162982 **[Test build #128884 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128884/testReport)** for PR 29781 at commit

[GitHub] [spark] itholic commented on a change in pull request #29781: [SPARK-32189][DOCS][PYTHON] Development - Setting PySpark with PyCharm

2020-09-18 Thread GitBox
itholic commented on a change in pull request #29781: URL: https://github.com/apache/spark/pull/29781#discussion_r491267799 ## File path: python/docs/source/development/setting_ide.rst ## @@ -0,0 +1,62 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +or

[GitHub] [spark] cchighman commented on pull request #28841: [SPARK-31962][SQL] Provide modifiedAfter and modifiedBefore options when filtering from a batch-based file data source

2020-09-18 Thread GitBox
cchighman commented on pull request #28841: URL: https://github.com/apache/spark/pull/28841#issuecomment-695161492 > Shall we use `modificationTimeFilter`? the word `date` is not accurate since it can be referred to date without any hour/minute/seconds Semantics for the new options

[GitHub] [spark] cchighman commented on pull request #28841: [SPARK-31962][SQL] Provide modifiedAfter and modifiedBefore options when filtering from a batch-based file data source

2020-09-18 Thread GitBox
cchighman commented on pull request #28841: URL: https://github.com/apache/spark/pull/28841#issuecomment-695161242 > @cchighman > Thanks for understanding. I still think even in SS case we want to provide timestamp to effectively filter out files - the point is whether the timestamp is

[GitHub] [spark] cchighman commented on pull request #28841: [SPARK-31962][SQL] Provide modifiedAfter and modifiedBefore options when filtering from a batch-based file data source

2020-09-18 Thread GitBox
cchighman commented on pull request #28841: URL: https://github.com/apache/spark/pull/28841#issuecomment-695160233 > These timestamps should be inclusive or exclusive? e.g., `(modifiedAfter, modifiedBefore)`, `[modifiedAfter, modifiedBefore]`... Looks like the current code follows

[GitHub] [spark] cchighman commented on pull request #28841: [SPARK-31962][SQL] Provide modifiedAfter and modifiedBefore options when filtering from a batch-based file data source

2020-09-18 Thread GitBox
cchighman commented on pull request #28841: URL: https://github.com/apache/spark/pull/28841#issuecomment-695159898 > Should we specify the timezone here? What should the default timezone be? > @cloud-fan @MaxGekk @gengliangwang's comment here drew quick attention to the fact

[GitHub] [spark] cchighman commented on pull request #28841: [SPARK-31962][SQL] Provide modifiedAfter and modifiedBefore options when filtering from a batch-based file data source

2020-09-18 Thread GitBox
cchighman commented on pull request #28841: URL: https://github.com/apache/spark/pull/28841#issuecomment-695158666 > > I haven't looked into the detail yet, but Hadoop FS and a PathFilter API, does Spark file source support the path filter option? > > Hadoop's PathFilter only gives

[GitHub] [spark] cchighman commented on pull request #28841: [SPARK-31962][SQL] Provide modifiedAfter and modifiedBefore options when filtering from a batch-based file data source

2020-09-18 Thread GitBox
cchighman commented on pull request #28841: URL: https://github.com/apache/spark/pull/28841#issuecomment-695158320 > > The need arises since we only have one filtering strategy where pathGlobFilter is used in PartitioningAwareFileIndex and handling cleanly if we now have more than one

[GitHub] [spark] cchighman commented on pull request #28841: [SPARK-31962][SQL] Provide modifiedAfter and modifiedBefore options when filtering from a batch-based file data source

2020-09-18 Thread GitBox
cchighman commented on pull request #28841: URL: https://github.com/apache/spark/pull/28841#issuecomment-695158061 > `f` here is `FileStatus`. It looks inefficient to get the `FileStatus` again in https://github.com/apache/spark/pull/28841/files#diff-3c816e65d0bbdf16d46c7ea4e0b8cbaeR55

[GitHub] [spark] cchighman commented on pull request #28841: [SPARK-31962][SQL] Provide modifiedAfter and modifiedBefore options when filtering from a batch-based file data source

2020-09-18 Thread GitBox
cchighman commented on pull request #28841: URL: https://github.com/apache/spark/pull/28841#issuecomment-695157152 > @cchighman I like the idea of such filtering. > How about we follow the approach of the option `pathGlobFilter`:

[GitHub] [spark] AmplabJenkins commented on pull request #29804: [SPARK-32859][SQL] Introduce physical rule to decide bucketing dynamically

2020-09-18 Thread GitBox
AmplabJenkins commented on pull request #29804: URL: https://github.com/apache/spark/pull/29804#issuecomment-695156624 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29804: [SPARK-32859][SQL] Introduce physical rule to decide bucketing dynamically

2020-09-18 Thread GitBox
AmplabJenkins removed a comment on pull request #29804: URL: https://github.com/apache/spark/pull/29804#issuecomment-695156624 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #29804: [SPARK-32859][SQL] Introduce physical rule to decide bucketing dynamically

2020-09-18 Thread GitBox
SparkQA removed a comment on pull request #29804: URL: https://github.com/apache/spark/pull/29804#issuecomment-695115619 **[Test build #128883 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128883/testReport)** for PR 29804 at commit

[GitHub] [spark] SparkQA commented on pull request #29804: [SPARK-32859][SQL] Introduce physical rule to decide bucketing dynamically

2020-09-18 Thread GitBox
SparkQA commented on pull request #29804: URL: https://github.com/apache/spark/pull/29804#issuecomment-695156470 **[Test build #128883 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128883/testReport)** for PR 29804 at commit

[GitHub] [spark] cchighman commented on pull request #28841: [SPARK-31962][SQL] Provide modifiedAfter and modifiedBefore options when filtering from a batch-based file data source

2020-09-18 Thread GitBox
cchighman commented on pull request #28841: URL: https://github.com/apache/spark/pull/28841#issuecomment-695155611 @gengliangwang @cloud-fan @maropu @Dooyoung-Hwang @HeartSaVioR @HyukjinKwon Following up on this PR for next steps. We've seen a strong amount of constructive feedback

[GitHub] [spark] wzhfy commented on pull request #29764: [SPARK-32738][CORE][2.4] Should reduce the number of active threads if fatal error happens in `Inbox.process`

2020-09-18 Thread GitBox
wzhfy commented on pull request #29764: URL: https://github.com/apache/spark/pull/29764#issuecomment-695145607 @mridulm Closed. Thanks! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] wzhfy closed pull request #29764: [SPARK-32738][CORE][2.4] Should reduce the number of active threads if fatal error happens in `Inbox.process`

2020-09-18 Thread GitBox
wzhfy closed pull request #29764: URL: https://github.com/apache/spark/pull/29764 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] balajij81 edited a comment on pull request #23576: [SPARK-26655] [SS] Support multiple aggregates in append mode

2020-09-18 Thread GitBox
balajij81 edited a comment on pull request #23576: URL: https://github.com/apache/spark/pull/23576#issuecomment-695144270 I too agree that this PR is very valuable there are lot of use cases spark could be efficiently used for real-time streaming use cases.

[GitHub] [spark] balajij81 commented on pull request #23576: [SPARK-26655] [SS] Support multiple aggregates in append mode

2020-09-18 Thread GitBox
balajij81 commented on pull request #23576: URL: https://github.com/apache/spark/pull/23576#issuecomment-695144270 I too agree that this PR is very valuable there are lot of use cases spark could be efficiently for real-time streaming use cases.

[GitHub] [spark] github-actions[bot] commented on pull request #28497: [SPARK-31677][SS] Use kvstore to cache stream query progress

2020-09-18 Thread GitBox
github-actions[bot] commented on pull request #28497: URL: https://github.com/apache/spark/pull/28497#issuecomment-695139730 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue

[GitHub] [spark] github-actions[bot] commented on pull request #28755: [SPARK-29394][SQL]Support ISO 8601 format for intervals

2020-09-18 Thread GitBox
github-actions[bot] commented on pull request #28755: URL: https://github.com/apache/spark/pull/28755#issuecomment-695139727 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue

[GitHub] [spark] github-actions[bot] commented on pull request #28147: [SPARK-31357][SQL][WIP] Catalog API for view metadata

2020-09-18 Thread GitBox
github-actions[bot] commented on pull request #28147: URL: https://github.com/apache/spark/pull/28147#issuecomment-695139736 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue

[GitHub] [spark] github-actions[bot] commented on pull request #28036: [SPARK-26341][CORE]Expose executor memory metrics at the stage level, in the Stages tab

2020-09-18 Thread GitBox
github-actions[bot] commented on pull request #28036: URL: https://github.com/apache/spark/pull/28036#issuecomment-695139741 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue

[GitHub] [spark] viirya commented on a change in pull request #26935: [SPARK-30294][SS] Explicitly defines read-only StateStore and optimize for HDFSBackedStateStore

2020-09-18 Thread GitBox
viirya commented on a change in pull request #26935: URL: https://github.com/apache/spark/pull/26935#discussion_r491243565 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala ## @@ -253,7 +253,8 @@ case class

[GitHub] [spark] maropu commented on a change in pull request #29804: [SPARK-32859][SQL] Introduce physical rule to decide bucketing dynamically

2020-09-18 Thread GitBox
maropu commented on a change in pull request #29804: URL: https://github.com/apache/spark/pull/29804#discussion_r491243552 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -2764,6 +2764,14 @@ object SQLConf { .booleanConf

[GitHub] [spark] viirya commented on a change in pull request #26935: [SPARK-30294][SS] Explicitly defines read-only StateStore and optimize for HDFSBackedStateStore

2020-09-18 Thread GitBox
viirya commented on a change in pull request #26935: URL: https://github.com/apache/spark/pull/26935#discussion_r491241918 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStore.scala ## @@ -109,6 +109,41 @@ trait StateStore { def

[GitHub] [spark] maropu edited a comment on pull request #29804: [SPARK-32859][SQL] Introduce physical rule to decide bucketing dynamically

2020-09-18 Thread GitBox
maropu edited a comment on pull request #29804: URL: https://github.com/apache/spark/pull/29804#issuecomment-695134989 Looks an interesting idea, @c21 ! I'll check this later. This is an automated message from the Apache Git

[GitHub] [spark] maropu commented on a change in pull request #29804: [SPARK-32859][SQL] Introduce physical rule to decide bucketing dynamically

2020-09-18 Thread GitBox
maropu commented on a change in pull request #29804: URL: https://github.com/apache/spark/pull/29804#discussion_r491242019 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala ## @@ -165,6 +166,7 @@ case class FileSourceScanExec(

[GitHub] [spark] maropu commented on pull request #29804: [SPARK-32859][SQL] Introduce physical rule to decide bucketing dynamically

2020-09-18 Thread GitBox
maropu commented on pull request #29804: URL: https://github.com/apache/spark/pull/29804#issuecomment-695134989 Looks an interesting idea, @c21 ! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] mridulm commented on pull request #29764: [SPARK-32738][CORE][2.4] Should reduce the number of active threads if fatal error happens in `Inbox.process`

2020-09-18 Thread GitBox
mridulm commented on pull request #29764: URL: https://github.com/apache/spark/pull/29764#issuecomment-695131542 @wzhfy Can you close the PR please ? It has been merged to branch-2.4 This is an automated message from the

[GitHub] [spark] viirya commented on a change in pull request #29779: [SPARK-32180][PYTHON][DOCS][FOLLOW-UP] Rephrase and add some more information in installation guide

2020-09-18 Thread GitBox
viirya commented on a change in pull request #29779: URL: https://github.com/apache/spark/pull/29779#discussion_r491235435 ## File path: python/docs/source/getting_started/install.rst ## @@ -0,0 +1,138 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +or

[GitHub] [spark] maropu commented on pull request #29803: [SPARK-32874][SQL][FOLLOWUP][test-hive1.2][test-hadoop2.7] Fix spark-master-test-sbt-hadoop-2.7-hive-1.2

2020-09-18 Thread GitBox
maropu commented on pull request #29803: URL: https://github.com/apache/spark/pull/29803#issuecomment-695124152 late LGTM, thanks for the quick fix, @yaooqinn ! This is an automated message from the Apache Git Service. To

[GitHub] [spark] maropu commented on pull request #29805: [SPARK-32635][SQL][2.4] Fix foldable propagation

2020-09-18 Thread GitBox
maropu commented on pull request #29805: URL: https://github.com/apache/spark/pull/29805#issuecomment-695122960 late LGTM, thanks, @peter-toth ! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] maropu commented on pull request #29802: [SPARK-32635][SQL][FOLLOW-UP] Add a new test case in catalyst module

2020-09-18 Thread GitBox
maropu commented on pull request #29802: URL: https://github.com/apache/spark/pull/29802#issuecomment-695122624 late LGTM, thanks, all! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29804: [SPARK-32859][SQL] Introduce physical rule to decide bucketing dynamically

2020-09-18 Thread GitBox
AmplabJenkins removed a comment on pull request #29804: URL: https://github.com/apache/spark/pull/29804#issuecomment-695115867 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29804: [SPARK-32859][SQL] Introduce physical rule to decide bucketing dynamically

2020-09-18 Thread GitBox
AmplabJenkins commented on pull request #29804: URL: https://github.com/apache/spark/pull/29804#issuecomment-695115867 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29804: [SPARK-32859][SQL] Introduce physical rule to decide bucketing dynamically

2020-09-18 Thread GitBox
SparkQA commented on pull request #29804: URL: https://github.com/apache/spark/pull/29804#issuecomment-695115619 **[Test build #128883 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128883/testReport)** for PR 29804 at commit

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29788: [SPARK-32913][CORE][K8S] Improve ExecutorDecommissionInfo and ExecutorDecommissionState for different use cases

2020-09-18 Thread GitBox
dongjoon-hyun commented on a change in pull request #29788: URL: https://github.com/apache/spark/pull/29788#discussion_r491214032 ## File path: core/src/main/scala/org/apache/spark/ExecutorAllocationClient.scala ## @@ -17,7 +17,7 @@ package org.apache.spark -import

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29788: [SPARK-32913][CORE][K8S] Improve ExecutorDecommissionInfo and ExecutorDecommissionState for different use cases

2020-09-18 Thread GitBox
dongjoon-hyun commented on a change in pull request #29788: URL: https://github.com/apache/spark/pull/29788#discussion_r491214032 ## File path: core/src/main/scala/org/apache/spark/ExecutorAllocationClient.scala ## @@ -17,7 +17,7 @@ package org.apache.spark -import

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29781: [SPARK-32189][DOCS][PYTHON] Development - Setting PySpark with PyCharm

2020-09-18 Thread GitBox
dongjoon-hyun commented on a change in pull request #29781: URL: https://github.com/apache/spark/pull/29781#discussion_r491193767 ## File path: python/docs/source/development/setting_ide.rst ## @@ -0,0 +1,62 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29781: [SPARK-32189][DOCS][PYTHON] Development - Setting PySpark with PyCharm

2020-09-18 Thread GitBox
dongjoon-hyun commented on a change in pull request #29781: URL: https://github.com/apache/spark/pull/29781#discussion_r491193274 ## File path: python/docs/source/development/setting_ide.rst ## @@ -0,0 +1,62 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29779: [SPARK-32180][PYTHON][DOCS][FOLLOW-UP] Rephrase and add some more information in installation guide

2020-09-18 Thread GitBox
dongjoon-hyun commented on a change in pull request #29779: URL: https://github.com/apache/spark/pull/29779#discussion_r491192048 ## File path: python/docs/source/getting_started/install.rst ## @@ -0,0 +1,138 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [spark] dongjoon-hyun commented on pull request #29789: [SPARK-32898][CORE] Fix wrong executorRunTime when task killed before real start

2020-09-18 Thread GitBox
dongjoon-hyun commented on pull request #29789: URL: https://github.com/apache/spark/pull/29789#issuecomment-695086068 Merged to master/3.0. @Ngone51 . Could you make a backport to `branch-2.4`, please? This is an

[GitHub] [spark] dongjoon-hyun closed pull request #29789: [SPARK-32898][CORE] Fix wrong executorRunTime when task killed before real start

2020-09-18 Thread GitBox
dongjoon-hyun closed pull request #29789: URL: https://github.com/apache/spark/pull/29789 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] dongjoon-hyun commented on pull request #29798: [SPARK-32931][SQL] Unevaluable Expressions are not Foldable

2020-09-18 Thread GitBox
dongjoon-hyun commented on pull request #29798: URL: https://github.com/apache/spark/pull/29798#issuecomment-695084171 cc @sunchao and @viirya This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] dongjoon-hyun closed pull request #29802: [SPARK-32635][SQL][FOLLOW-UP] Add a new test case in catalyst module

2020-09-18 Thread GitBox
dongjoon-hyun closed pull request #29802: URL: https://github.com/apache/spark/pull/29802 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29799: [SPARK-32933][PYTHON] Use keyword-only syntax for keyword_only methods

2020-09-18 Thread GitBox
AmplabJenkins removed a comment on pull request #29799: URL: https://github.com/apache/spark/pull/29799#issuecomment-695029859 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #29799: [SPARK-32933][PYTHON] Use keyword-only syntax for keyword_only methods

2020-09-18 Thread GitBox
SparkQA removed a comment on pull request #29799: URL: https://github.com/apache/spark/pull/29799#issuecomment-695020379 **[Test build #128882 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128882/testReport)** for PR 29799 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29799: [SPARK-32933][PYTHON] Use keyword-only syntax for keyword_only methods

2020-09-18 Thread GitBox
AmplabJenkins commented on pull request #29799: URL: https://github.com/apache/spark/pull/29799#issuecomment-695029859 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29799: [SPARK-32933][PYTHON] Use keyword-only syntax for keyword_only methods

2020-09-18 Thread GitBox
SparkQA commented on pull request #29799: URL: https://github.com/apache/spark/pull/29799#issuecomment-695029502 **[Test build #128882 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128882/testReport)** for PR 29799 at commit

[GitHub] [spark] mridulm commented on pull request #29763: [SPARK-32738][CORE][3.0] Should reduce the number of active threads if fatal error happens in `Inbox.process`

2020-09-18 Thread GitBox
mridulm commented on pull request #29763: URL: https://github.com/apache/spark/pull/29763#issuecomment-695027046 Thanks for clarifying @HyukjinKwon , I was not aware of that ! I learn something new every day :-) This is

[GitHub] [spark] SparkQA commented on pull request #29799: [SPARK-32933][PYTHON] Use keyword-only syntax for keyword_only methods

2020-09-18 Thread GitBox
SparkQA commented on pull request #29799: URL: https://github.com/apache/spark/pull/29799#issuecomment-695020379 **[Test build #128882 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128882/testReport)** for PR 29799 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29799: [SPARK-32933][PYTHON] Use keyword-only syntax for keyword_only methods

2020-09-18 Thread GitBox
AmplabJenkins removed a comment on pull request #29799: URL: https://github.com/apache/spark/pull/29799#issuecomment-695017669 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29799: [SPARK-32933][PYTHON] Use keyword-only syntax for keyword_only methods

2020-09-18 Thread GitBox
AmplabJenkins commented on pull request #29799: URL: https://github.com/apache/spark/pull/29799#issuecomment-695017669 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] agrawaldevesh commented on a change in pull request #29788: [SPARK-32913][CORE][K8S] Improve ExecutorDecommissionInfo and ExecutorDecommissionState for different use cases

2020-09-18 Thread GitBox
agrawaldevesh commented on a change in pull request #29788: URL: https://github.com/apache/spark/pull/29788#discussion_r491107142 ## File path: core/src/main/scala/org/apache/spark/scheduler/ExecutorDecommissionReason.scala ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache

[GitHub] [spark] agrawaldevesh commented on a change in pull request #29788: [SPARK-32913][CORE][K8S] Improve ExecutorDecommissionInfo and ExecutorDecommissionState for different use cases

2020-09-18 Thread GitBox
agrawaldevesh commented on a change in pull request #29788: URL: https://github.com/apache/spark/pull/29788#discussion_r491083572 ## File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala ## @@ -2368,7 +2368,7 @@ private[scheduler] class

[GitHub] [spark] SparkQA removed a comment on pull request #29799: [SPARK-32933][PYTHON] Use keyword-only syntax for keyword_only methods

2020-09-18 Thread GitBox
SparkQA removed a comment on pull request #29799: URL: https://github.com/apache/spark/pull/29799#issuecomment-694982896 **[Test build #128881 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128881/testReport)** for PR 29799 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29799: [SPARK-32933][PYTHON] Use keyword-only syntax for keyword_only methods

2020-09-18 Thread GitBox
AmplabJenkins removed a comment on pull request #29799: URL: https://github.com/apache/spark/pull/29799#issuecomment-694993304 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29799: [SPARK-32933][PYTHON] Use keyword-only syntax for keyword_only methods

2020-09-18 Thread GitBox
AmplabJenkins commented on pull request #29799: URL: https://github.com/apache/spark/pull/29799#issuecomment-694993304 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29799: [SPARK-32933][PYTHON] Use keyword-only syntax for keyword_only methods

2020-09-18 Thread GitBox
SparkQA commented on pull request #29799: URL: https://github.com/apache/spark/pull/29799#issuecomment-694992925 **[Test build #128881 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128881/testReport)** for PR 29799 at commit

[GitHub] [spark] rednaxelafx commented on a change in pull request #29798: [SPARK-32931][SQL] Unevaluable Expressions are not Foldable

2020-09-18 Thread GitBox
rednaxelafx commented on a change in pull request #29798: URL: https://github.com/apache/spark/pull/29798#discussion_r491088433 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala ## @@ -318,7 +321,6 @@ trait Unevaluable

[GitHub] [spark] dongjoon-hyun closed pull request #29805: [SPARK-32635][SQL][2.4] Fix foldable propagation

2020-09-18 Thread GitBox
dongjoon-hyun closed pull request #29805: URL: https://github.com/apache/spark/pull/29805 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29799: [SPARK-32933][PYTHON] Use keyword-only syntax for keyword_only methods

2020-09-18 Thread GitBox
AmplabJenkins removed a comment on pull request #29799: URL: https://github.com/apache/spark/pull/29799#issuecomment-694983574 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29799: [SPARK-32933][PYTHON] Use keyword-only syntax for keyword_only methods

2020-09-18 Thread GitBox
AmplabJenkins commented on pull request #29799: URL: https://github.com/apache/spark/pull/29799#issuecomment-694983574 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29799: [SPARK-32933][PYTHON] Use keyword-only syntax for keyword_only methods

2020-09-18 Thread GitBox
SparkQA commented on pull request #29799: URL: https://github.com/apache/spark/pull/29799#issuecomment-694982896 **[Test build #128881 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128881/testReport)** for PR 29799 at commit

[GitHub] [spark] viirya commented on a change in pull request #29737: [SPARK-32864][SQL] Support ORC forced positional evolution

2020-09-18 Thread GitBox
viirya commented on a change in pull request #29737: URL: https://github.com/apache/spark/pull/29737#discussion_r491080641 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcQuerySuite.scala ## @@ -316,4 +317,33 @@ class HiveOrcQuerySuite extends

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29806: [SPARK-32187][PYTHON][DOCS] Doc on Python packaging

2020-09-18 Thread GitBox
AmplabJenkins removed a comment on pull request #29806: URL: https://github.com/apache/spark/pull/29806#issuecomment-694979963 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29806: [SPARK-32187][PYTHON][DOCS] Doc on Python packaging

2020-09-18 Thread GitBox
AmplabJenkins commented on pull request #29806: URL: https://github.com/apache/spark/pull/29806#issuecomment-694979963 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #29806: [SPARK-32187][PYTHON][DOCS] Doc on Python packaging

2020-09-18 Thread GitBox
SparkQA removed a comment on pull request #29806: URL: https://github.com/apache/spark/pull/29806#issuecomment-694966780 **[Test build #128880 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128880/testReport)** for PR 29806 at commit

[GitHub] [spark] SparkQA commented on pull request #29806: [SPARK-32187][PYTHON][DOCS] Doc on Python packaging

2020-09-18 Thread GitBox
SparkQA commented on pull request #29806: URL: https://github.com/apache/spark/pull/29806#issuecomment-694979561 **[Test build #128880 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128880/testReport)** for PR 29806 at commit

[GitHub] [spark] peter-toth commented on a change in pull request #29737: [SPARK-32864][SQL] Support ORC forced positional evolution

2020-09-18 Thread GitBox
peter-toth commented on a change in pull request #29737: URL: https://github.com/apache/spark/pull/29737#discussion_r491077606 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcUtils.scala ## @@ -142,13 +142,17 @@ object OrcUtils extends

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29749: [SPARK-32877][SQL] Fix Hive UDF not support decimal type in complex type

2020-09-18 Thread GitBox
AmplabJenkins removed a comment on pull request #29749: URL: https://github.com/apache/spark/pull/29749#issuecomment-694969733 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29749: [SPARK-32877][SQL] Fix Hive UDF not support decimal type in complex type

2020-09-18 Thread GitBox
AmplabJenkins commented on pull request #29749: URL: https://github.com/apache/spark/pull/29749#issuecomment-694969733 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #29749: [SPARK-32877][SQL] Fix Hive UDF not support decimal type in complex type

2020-09-18 Thread GitBox
SparkQA removed a comment on pull request #29749: URL: https://github.com/apache/spark/pull/29749#issuecomment-694908702 **[Test build #128879 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128879/testReport)** for PR 29749 at commit

[GitHub] [spark] SparkQA commented on pull request #29749: [SPARK-32877][SQL] Fix Hive UDF not support decimal type in complex type

2020-09-18 Thread GitBox
SparkQA commented on pull request #29749: URL: https://github.com/apache/spark/pull/29749#issuecomment-694969073 **[Test build #128879 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128879/testReport)** for PR 29749 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29806: [SPARK-32187][PYTHON][DOCS] Doc on Python packaging

2020-09-18 Thread GitBox
AmplabJenkins removed a comment on pull request #29806: URL: https://github.com/apache/spark/pull/29806#issuecomment-694967424 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29806: [SPARK-32187][PYTHON][DOCS] Doc on Python packaging

2020-09-18 Thread GitBox
AmplabJenkins commented on pull request #29806: URL: https://github.com/apache/spark/pull/29806#issuecomment-694967424 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29806: [SPARK-32187][PYTHON][DOCS] Doc on Python packaging

2020-09-18 Thread GitBox
SparkQA commented on pull request #29806: URL: https://github.com/apache/spark/pull/29806#issuecomment-694966780 **[Test build #128880 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128880/testReport)** for PR 29806 at commit

[GitHub] [spark] viirya commented on a change in pull request #29797: [SPARK-32932][SQL] Do not use local shuffle reader on RepartitionByExpression when coalescing disabled

2020-09-18 Thread GitBox
viirya commented on a change in pull request #29797: URL: https://github.com/apache/spark/pull/29797#discussion_r490732936 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ## @@ -705,7 +705,8 @@ abstract class SparkStrategies extends

[GitHub] [spark] viirya commented on a change in pull request #29797: [SPARK-32932][SQL] Do not use local shuffle reader on RepartitionByExpression when coalescing disabled

2020-09-18 Thread GitBox
viirya commented on a change in pull request #29797: URL: https://github.com/apache/spark/pull/29797#discussion_r490732936 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ## @@ -705,7 +705,8 @@ abstract class SparkStrategies extends

[GitHub] [spark] AmplabJenkins commented on pull request #28921: [SPARK-32086][YARN]Bug fix for RemoveBroadcast RPC failed after executor is shutdown

2020-09-18 Thread GitBox
AmplabJenkins commented on pull request #28921: URL: https://github.com/apache/spark/pull/28921#issuecomment-694943473 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] srowen closed pull request #29711: [SPARK-32808][SQL] Pass all test of sql/core module in Scala 2.13

2020-09-18 Thread GitBox
srowen closed pull request #29711: URL: https://github.com/apache/spark/pull/29711 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] srowen commented on pull request #29711: [SPARK-32808][SQL] Pass all test of sql/core module in Scala 2.13

2020-09-18 Thread GitBox
srowen commented on pull request #29711: URL: https://github.com/apache/spark/pull/29711#issuecomment-694939769 Merged to master This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] gatorsmile commented on pull request #29798: [SPARK-32931][SQL] Unevaluable Expressions are not Foldable

2020-09-18 Thread GitBox
gatorsmile commented on pull request #29798: URL: https://github.com/apache/spark/pull/29798#issuecomment-694935675 cc @cloud-fan @rednaxelafx This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29806: [SPARK-32187][PYTHON][DOCS] Doc on Python packaging

2020-09-18 Thread GitBox
AmplabJenkins removed a comment on pull request #29806: URL: https://github.com/apache/spark/pull/29806#issuecomment-694910695 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29806: [SPARK-32187][PYTHON][DOCS] Doc on Python packaging

2020-09-18 Thread GitBox
AmplabJenkins commented on pull request #29806: URL: https://github.com/apache/spark/pull/29806#issuecomment-694910695 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29806: [SPARK-32187][PYTHON][DOCS] Doc on Python packaging

2020-09-18 Thread GitBox
SparkQA commented on pull request #29806: URL: https://github.com/apache/spark/pull/29806#issuecomment-694910213 **[Test build #128878 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128878/testReport)** for PR 29806 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #29806: [SPARK-32187][PYTHON][DOCS] Doc on Python packaging

2020-09-18 Thread GitBox
SparkQA removed a comment on pull request #29806: URL: https://github.com/apache/spark/pull/29806#issuecomment-694896356 **[Test build #128878 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128878/testReport)** for PR 29806 at commit

  1   2   3   4   >