[GitHub] [spark] ulysses-you commented on a change in pull request #30368: [SPARK-33442][SQL] Change Combine Limit to Eliminate limit using max row

2020-11-16 Thread GitBox
ulysses-you commented on a change in pull request #30368: URL: https://github.com/apache/spark/pull/30368#discussion_r524038654 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -1452,11 +1452,27 @@ object PushPredicateThro

[GitHub] [spark] AmplabJenkins commented on pull request #30377: [SPARK-33453][SQL][TESTS] Unify v1 and v2 SHOW PARTITIONS tests

2020-11-16 Thread GitBox
AmplabJenkins commented on pull request #30377: URL: https://github.com/apache/spark/pull/30377#issuecomment-727862842 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28386: [SPARK-26199][SPARK-31517][R] Fix strategy for handling ... names in mutate

2020-11-16 Thread GitBox
HyukjinKwon commented on a change in pull request #28386: URL: https://github.com/apache/spark/pull/28386#discussion_r524038504 ## File path: R/pkg/R/DataFrame.R ## @@ -3444,7 +3445,8 @@ setMethod("as.data.frame", #' @note attach since 1.6.0 setMethod("attach", sig

[GitHub] [spark] ulysses-you commented on a change in pull request #30368: [SPARK-33442][SQL] Change Combine Limit to Eliminate limit using max row

2020-11-16 Thread GitBox
ulysses-you commented on a change in pull request #30368: URL: https://github.com/apache/spark/pull/30368#discussion_r524034982 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -1452,11 +1452,27 @@ object PushPredicateThro

[GitHub] [spark] sarutak commented on pull request #30336: [SPARK-33287][SS][UI]Expose state custom metrics information on SS UI

2020-11-16 Thread GitBox
sarutak commented on pull request #30336: URL: https://github.com/apache/spark/pull/30336#issuecomment-727861148 Hi @gaborgsomogyi , you'd like to add new feature but you say you tested this feature manually so could you explain how you tested to us in the description? It helps reviewers.

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30377: [SPARK-33453][SQL][TESTS] Unify v1 and v2 SHOW PARTITIONS tests

2020-11-16 Thread GitBox
AmplabJenkins removed a comment on pull request #30377: URL: https://github.com/apache/spark/pull/30377#issuecomment-727858768 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131

[GitHub] [spark] SparkQA removed a comment on pull request #30377: [SPARK-33453][SQL][TESTS] Unify v1 and v2 SHOW PARTITIONS tests

2020-11-16 Thread GitBox
SparkQA removed a comment on pull request #30377: URL: https://github.com/apache/spark/pull/30377#issuecomment-727854942 **[Test build #131148 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131148/testReport)** for PR 30377 at commit [`47925f2`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30377: [SPARK-33453][SQL][TESTS] Unify v1 and v2 SHOW PARTITIONS tests

2020-11-16 Thread GitBox
AmplabJenkins removed a comment on pull request #30377: URL: https://github.com/apache/spark/pull/30377#issuecomment-727858761 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #30377: [SPARK-33453][SQL][TESTS] Unify v1 and v2 SHOW PARTITIONS tests

2020-11-16 Thread GitBox
AmplabJenkins commented on pull request #30377: URL: https://github.com/apache/spark/pull/30377#issuecomment-727858761 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #30377: [SPARK-33453][SQL][TESTS] Unify v1 and v2 SHOW PARTITIONS tests

2020-11-16 Thread GitBox
SparkQA commented on pull request #30377: URL: https://github.com/apache/spark/pull/30377#issuecomment-727858738 **[Test build #131148 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131148/testReport)** for PR 30377 at commit [`47925f2`](https://github.co

[GitHub] [spark] sarutak commented on a change in pull request #30336: [SPARK-33287][SS][UI]Expose state custom metrics information on SS UI

2020-11-16 Thread GitBox
sarutak commented on a change in pull request #30336: URL: https://github.com/apache/spark/pull/30336#discussion_r524027024 ## File path: sql/core/src/main/scala/org/apache/spark/sql/streaming/ui/StreamingQueryStatisticsPage.scala ## @@ -199,49 +201,99 @@ private[ui] class Str

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30300: [SPARK-33399][SQL] Normalize output partitioning and sortorder with respect to aliases to avoid unneeded exchange/sort nodes

2020-11-16 Thread GitBox
AmplabJenkins removed a comment on pull request #30300: URL: https://github.com/apache/spark/pull/30300#issuecomment-727855901 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] MaxGekk commented on a change in pull request #30377: [SPARK-33453][SQL][TESTS] Unify v1 and v2 SHOW PARTITIONS tests

2020-11-16 Thread GitBox
MaxGekk commented on a change in pull request #30377: URL: https://github.com/apache/spark/pull/30377#discussion_r524024781 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/command/ShowPartitionsSuite.scala ## @@ -0,0 +1,39 @@ +/* + * Licensed to the A

[GitHub] [spark] SparkQA commented on pull request #30300: [SPARK-33399][SQL] Normalize output partitioning and sortorder with respect to aliases to avoid unneeded exchange/sort nodes

2020-11-16 Thread GitBox
SparkQA commented on pull request #30300: URL: https://github.com/apache/spark/pull/30300#issuecomment-727855878 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35745/ ---

[GitHub] [spark] AmplabJenkins commented on pull request #30300: [SPARK-33399][SQL] Normalize output partitioning and sortorder with respect to aliases to avoid unneeded exchange/sort nodes

2020-11-16 Thread GitBox
AmplabJenkins commented on pull request #30300: URL: https://github.com/apache/spark/pull/30300#issuecomment-727855901 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #30377: [SPARK-33453][SQL][TESTS] Unify v1 and v2 SHOW PARTITIONS tests

2020-11-16 Thread GitBox
SparkQA commented on pull request #30377: URL: https://github.com/apache/spark/pull/30377#issuecomment-727854942 **[Test build #131148 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131148/testReport)** for PR 30377 at commit [`47925f2`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #29497: [WIP][SPARK-32670][SQL]Group exception messages in Catalyst Analyzer in one file

2020-11-16 Thread GitBox
SparkQA commented on pull request #29497: URL: https://github.com/apache/spark/pull/29497#issuecomment-727852949 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35747/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29497: [WIP][SPARK-32670][SQL]Group exception messages in Catalyst Analyzer in one file

2020-11-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29497: URL: https://github.com/apache/spark/pull/29497#issuecomment-727850763 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29497: [WIP][SPARK-32670][SQL]Group exception messages in Catalyst Analyzer in one file

2020-11-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29497: URL: https://github.com/apache/spark/pull/29497#issuecomment-727850742 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA commented on pull request #29497: [WIP][SPARK-32670][SQL]Group exception messages in Catalyst Analyzer in one file

2020-11-16 Thread GitBox
SparkQA commented on pull request #29497: URL: https://github.com/apache/spark/pull/29497#issuecomment-727850717 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35743/ ---

[GitHub] [spark] AmplabJenkins commented on pull request #29497: [WIP][SPARK-32670][SQL]Group exception messages in Catalyst Analyzer in one file

2020-11-16 Thread GitBox
AmplabJenkins commented on pull request #29497: URL: https://github.com/apache/spark/pull/29497#issuecomment-727850742 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #30364: [SPARK-33140][SQL][FOLLOW-UP] Revert code that not use passed-in SparkSession to get SQLConf.

2020-11-16 Thread GitBox
SparkQA commented on pull request #30364: URL: https://github.com/apache/spark/pull/30364#issuecomment-727848744 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35746/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30385: [MINOR][SQL][DOCS] Fix a reference to `spark.sql.sources.useV1SourceList`

2020-11-16 Thread GitBox
AmplabJenkins removed a comment on pull request #30385: URL: https://github.com/apache/spark/pull/30385#issuecomment-727847086 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf

2020-11-16 Thread GitBox
AmplabJenkins removed a comment on pull request #30299: URL: https://github.com/apache/spark/pull/30299#issuecomment-727846909 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #30385: [MINOR][SQL][DOCS] Fix a reference to `spark.sql.sources.useV1SourceList`

2020-11-16 Thread GitBox
AmplabJenkins commented on pull request #30385: URL: https://github.com/apache/spark/pull/30385#issuecomment-727847086 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf

2020-11-16 Thread GitBox
SparkQA commented on pull request #30299: URL: https://github.com/apache/spark/pull/30299#issuecomment-727846882 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35744/ ---

[GitHub] [spark] AmplabJenkins commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf

2020-11-16 Thread GitBox
AmplabJenkins commented on pull request #30299: URL: https://github.com/apache/spark/pull/30299#issuecomment-727846909 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] yaooqinn commented on pull request #30045: [SPARK-32991][SQL] Use conf in shared state as the original configuraion for RESET

2020-11-16 Thread GitBox
yaooqinn commented on pull request #30045: URL: https://github.com/apache/spark/pull/30045#issuecomment-727845596 make sense to me too, I will raise a followup later. This is an automated message from the Apache Git Service.

[GitHub] [spark] MaxGekk commented on a change in pull request #30377: [SPARK-33453][SQL][TESTS] Unify v1 and v2 SHOW PARTITIONS tests

2020-11-16 Thread GitBox
MaxGekk commented on a change in pull request #30377: URL: https://github.com/apache/spark/pull/30377#discussion_r524002484 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowPartitionsSuite.scala ## @@ -0,0 +1,198 @@ +/* + * Licensed to the Ap

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30352: [SPARK-23499][MESOS] Support for priority queues in Mesos scheduler

2020-11-16 Thread GitBox
AmplabJenkins removed a comment on pull request #30352: URL: https://github.com/apache/spark/pull/30352#issuecomment-727842852 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30352: [SPARK-23499][MESOS] Support for priority queues in Mesos scheduler

2020-11-16 Thread GitBox
AmplabJenkins removed a comment on pull request #30352: URL: https://github.com/apache/spark/pull/30352#issuecomment-727842834 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA commented on pull request #30352: [SPARK-23499][MESOS] Support for priority queues in Mesos scheduler

2020-11-16 Thread GitBox
SparkQA commented on pull request #30352: URL: https://github.com/apache/spark/pull/30352#issuecomment-727842818 **[Test build #131146 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131146/testReport)** for PR 30352 at commit [`7df5cb6`](https://github.co

[GitHub] [spark] AmplabJenkins commented on pull request #30352: [SPARK-23499][MESOS] Support for priority queues in Mesos scheduler

2020-11-16 Thread GitBox
AmplabJenkins commented on pull request #30352: URL: https://github.com/apache/spark/pull/30352#issuecomment-727842834 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #30300: [SPARK-33399][SQL] Normalize output partitioning and sortorder with respect to aliases to avoid unneeded exchange/sort nodes

2020-11-16 Thread GitBox
SparkQA commented on pull request #30300: URL: https://github.com/apache/spark/pull/30300#issuecomment-727842806 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35745/ -

[GitHub] [spark] SparkQA removed a comment on pull request #30352: [SPARK-23499][MESOS] Support for priority queues in Mesos scheduler

2020-11-16 Thread GitBox
SparkQA removed a comment on pull request #30352: URL: https://github.com/apache/spark/pull/30352#issuecomment-727841788 **[Test build #131146 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131146/testReport)** for PR 30352 at commit [`7df5cb6`](https://gi

[GitHub] [spark] SparkQA commented on pull request #30309: [SPARK-33407][PYTHON] Simplify the exception message from Python UDFs (disabled by default)

2020-11-16 Thread GitBox
SparkQA commented on pull request #30309: URL: https://github.com/apache/spark/pull/30309#issuecomment-727841854 **[Test build #131147 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131147/testReport)** for PR 30309 at commit [`2bc3c34`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #30352: [SPARK-23499][MESOS] Support for priority queues in Mesos scheduler

2020-11-16 Thread GitBox
SparkQA commented on pull request #30352: URL: https://github.com/apache/spark/pull/30352#issuecomment-727841788 **[Test build #131146 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131146/testReport)** for PR 30352 at commit [`7df5cb6`](https://github.com

[GitHub] [spark] HyukjinKwon closed pull request #30385: [MINOR][SQL][DOCS] Fix a reference to `spark.sql.sources.useV1SourceList`

2020-11-16 Thread GitBox
HyukjinKwon closed pull request #30385: URL: https://github.com/apache/spark/pull/30385 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] HyukjinKwon commented on pull request #30385: [MINOR][SQL][DOCS] Fix a reference to `spark.sql.sources.useV1SourceList`

2020-11-16 Thread GitBox
HyukjinKwon commented on pull request #30385: URL: https://github.com/apache/spark/pull/30385#issuecomment-727836179 Relevant test such as linter and compilation passed. Let me just merge this in. Seems like it's from SPARK-28747. I will merge it to branch-3.0 too. Merged to master a

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf

2020-11-16 Thread GitBox
AmplabJenkins removed a comment on pull request #30299: URL: https://github.com/apache/spark/pull/30299#issuecomment-727828610 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #30336: [SPARK-33287][SS][UI]Expose state custom metrics information on SS UI

2020-11-16 Thread GitBox
gaborgsomogyi commented on a change in pull request #30336: URL: https://github.com/apache/spark/pull/30336#discussion_r523984658 ## File path: sql/core/src/main/scala/org/apache/spark/sql/streaming/ui/StreamingQueryStatisticsPage.scala ## @@ -199,49 +201,99 @@ private[ui] cla

[GitHub] [spark] SparkQA commented on pull request #29497: [WIP][SPARK-32670][SQL]Group exception messages in Catalyst Analyzer in one file

2020-11-16 Thread GitBox
SparkQA commented on pull request #29497: URL: https://github.com/apache/spark/pull/29497#issuecomment-727834734 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35743/ -

[GitHub] [spark] HyukjinKwon closed pull request #30384: [SPARK-33456][SQL][TEST][FOLLOWUP] Fix SUBEXPRESSION_ELIMINATION_ENABLED config name

2020-11-16 Thread GitBox
HyukjinKwon closed pull request #30384: URL: https://github.com/apache/spark/pull/30384 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] SparkQA commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf

2020-11-16 Thread GitBox
SparkQA commented on pull request #30299: URL: https://github.com/apache/spark/pull/30299#issuecomment-727833976 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35744/ -

[GitHub] [spark] HyukjinKwon commented on pull request #30384: [SPARK-33456][SQL][TEST][FOLLOWUP] Fix SUBEXPRESSION_ELIMINATION_ENABLED config name

2020-11-16 Thread GitBox
HyukjinKwon commented on pull request #30384: URL: https://github.com/apache/spark/pull/30384#issuecomment-727833882 Merged to master. This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [spark] c21 commented on a change in pull request #30347: [SPARK-33209][SS] Refactor unit test of stream-stream join in UnsupportedOperationsSuite

2020-11-16 Thread GitBox
c21 commented on a change in pull request #30347: URL: https://github.com/apache/spark/pull/30347#discussion_r523980835 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala ## @@ -414,209 +412,135 @@ class Unsupporte

[GitHub] [spark] ScrapCodes commented on pull request #27735: [SPARK-30985][k8s] Support propagating SPARK_CONF_DIR files to driver and executor pods.

2020-11-16 Thread GitBox
ScrapCodes commented on pull request #27735: URL: https://github.com/apache/spark/pull/27735#issuecomment-727831428 @dongjoon-hyun Thanks a lot, for reviewing and helping this move forward. :) This is an automated message fr

[GitHub] [spark] cloud-fan commented on a change in pull request #30341: [SPARK-33427][SQL] Add subexpression elimination for interpreted expression evaluation

2020-11-16 Thread GitBox
cloud-fan commented on a change in pull request #30341: URL: https://github.com/apache/spark/pull/30341#discussion_r523977667 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SubExprEvaluationRuntime.scala ## @@ -0,0 +1,126 @@ +/* + * License

[GitHub] [spark] xuanyuanking commented on a change in pull request #30336: [SPARK-33287][SS][UI]Expose state custom metrics information on SS UI

2020-11-16 Thread GitBox
xuanyuanking commented on a change in pull request #30336: URL: https://github.com/apache/spark/pull/30336#discussion_r523976903 ## File path: core/src/main/scala/org/apache/spark/internal/config/UI.scala ## @@ -203,4 +203,15 @@ private[spark] object UI { .stringConf

[GitHub] [spark] cloud-fan commented on a change in pull request #30341: [SPARK-33427][SQL] Add subexpression elimination for interpreted expression evaluation

2020-11-16 Thread GitBox
cloud-fan commented on a change in pull request #30341: URL: https://github.com/apache/spark/pull/30341#discussion_r523976909 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SubExprEvaluationRuntime.scala ## @@ -0,0 +1,126 @@ +/* + * License

[GitHub] [spark] MaxGekk commented on a change in pull request #30377: [SPARK-33453][SQL][TESTS] Unify v1 and v2 SHOW PARTITIONS tests

2020-11-16 Thread GitBox
MaxGekk commented on a change in pull request #30377: URL: https://github.com/apache/spark/pull/30377#discussion_r523977001 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/command/ShowPartitionsSuite.scala ## @@ -0,0 +1,39 @@ +/* + * Licensed to the A

[GitHub] [spark] SparkQA commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf

2020-11-16 Thread GitBox
SparkQA commented on pull request #30299: URL: https://github.com/apache/spark/pull/30299#issuecomment-727828601 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35742/ ---

[GitHub] [spark] AmplabJenkins commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf

2020-11-16 Thread GitBox
AmplabJenkins commented on pull request #30299: URL: https://github.com/apache/spark/pull/30299#issuecomment-727828610 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #30385: [MINOR][SQL][DOCS] Fix a reference to `spark.sql.sources.useV1SourceList`

2020-11-16 Thread GitBox
SparkQA commented on pull request #30385: URL: https://github.com/apache/spark/pull/30385#issuecomment-727825347 **[Test build #131145 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131145/testReport)** for PR 30385 at commit [`a0d35b0`](https://github.com

[GitHub] [spark] AmplabJenkins commented on pull request #30364: [SPARK-33140][SQL][FOLLOW-UP] Revert code that not use passed-in SparkSession to get SQLConf.

2020-11-16 Thread GitBox
AmplabJenkins commented on pull request #30364: URL: https://github.com/apache/spark/pull/30364#issuecomment-727824819 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] SparkQA commented on pull request #30364: [SPARK-33140][SQL][FOLLOW-UP] Revert code that not use passed-in SparkSession to get SQLConf.

2020-11-16 Thread GitBox
SparkQA commented on pull request #30364: URL: https://github.com/apache/spark/pull/30364#issuecomment-727824797 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35741/ ---

[GitHub] [spark] cloud-fan commented on pull request #30045: [SPARK-32991][SQL] Use conf in shared state as the original configuraion for RESET

2020-11-16 Thread GitBox
cloud-fan commented on pull request #30045: URL: https://github.com/apache/spark/pull/30045#issuecomment-727824653 makes sense. @yaooqinn what do you think? This is an automated message from the Apache Git Service. To respond

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30364: [SPARK-33140][SQL][FOLLOW-UP] Revert code that not use passed-in SparkSession to get SQLConf.

2020-11-16 Thread GitBox
AmplabJenkins removed a comment on pull request #30364: URL: https://github.com/apache/spark/pull/30364#issuecomment-727824819 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] cloud-fan commented on a change in pull request #30377: [SPARK-33453][SQL][TESTS] Unify v1 and v2 SHOW PARTITIONS tests

2020-11-16 Thread GitBox
cloud-fan commented on a change in pull request #30377: URL: https://github.com/apache/spark/pull/30377#discussion_r523970758 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/command/ShowPartitionsSuite.scala ## @@ -0,0 +1,39 @@ +/* + * Licensed to the

[GitHub] [spark] MaxGekk commented on a change in pull request #30385: [MINOR][SQL][DOCS] Fix a reference to `spark.sql.sources.useV1SourceList`

2020-11-16 Thread GitBox
MaxGekk commented on a change in pull request #30385: URL: https://github.com/apache/spark/pull/30385#discussion_r523970602 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogManager.scala ## @@ -78,7 +78,7 @@ class CatalogManager( * Th

[GitHub] [spark] cloud-fan commented on a change in pull request #30377: [SPARK-33453][SQL][TESTS] Unify v1 and v2 SHOW PARTITIONS tests

2020-11-16 Thread GitBox
cloud-fan commented on a change in pull request #30377: URL: https://github.com/apache/spark/pull/30377#discussion_r523970184 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowPartitionsSuite.scala ## @@ -0,0 +1,198 @@ +/* + * Licensed to the

[GitHub] [spark] MaxGekk opened a new pull request #30385: [MINOR][SQL][DOCS] Fix a reference to `spark.sql.sources.useV1SourceList`

2020-11-16 Thread GitBox
MaxGekk opened a new pull request #30385: URL: https://github.com/apache/spark/pull/30385 ### What changes were proposed in this pull request? Replace `spark.sql.sources.write.useV1SourceList` by `spark.sql.sources.useV1SourceList` in the comment for `CatalogManager.v2SessionCatalog()`.

[GitHub] [spark] cloud-fan commented on a change in pull request #30377: [SPARK-33453][SQL][TESTS] Unify v1 and v2 SHOW PARTITIONS tests

2020-11-16 Thread GitBox
cloud-fan commented on a change in pull request #30377: URL: https://github.com/apache/spark/pull/30377#discussion_r523969357 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowPartitionsSuite.scala ## @@ -0,0 +1,198 @@ +/* + * Licensed to the

[GitHub] [spark] viirya commented on a change in pull request #30341: [SPARK-33427][SQL] Add subexpression elimination for interpreted expression evaluation

2020-11-16 Thread GitBox
viirya commented on a change in pull request #30341: URL: https://github.com/apache/spark/pull/30341#discussion_r523968830 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SubExprEvaluationRuntime.scala ## @@ -0,0 +1,126 @@ +/* + * Licensed t

[GitHub] [spark] SparkQA commented on pull request #29497: [WIP][SPARK-32670][SQL]Group exception messages in Catalyst Analyzer in one file

2020-11-16 Thread GitBox
SparkQA commented on pull request #29497: URL: https://github.com/apache/spark/pull/29497#issuecomment-727821409 **[Test build #131144 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131144/testReport)** for PR 29497 at commit [`645d81b`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #30300: [SPARK-33399][SQL] Normalize output partitioning and sortorder with respect to aliases to avoid unneeded exchange/sort nodes

2020-11-16 Thread GitBox
SparkQA commented on pull request #30300: URL: https://github.com/apache/spark/pull/30300#issuecomment-727821362 **[Test build #131143 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131143/testReport)** for PR 30300 at commit [`16e1db2`](https://github.com

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #30336: [SPARK-33287][SS][UI]Expose state custom metrics information on SS UI

2020-11-16 Thread GitBox
gaborgsomogyi commented on a change in pull request #30336: URL: https://github.com/apache/spark/pull/30336#discussion_r523967561 ## File path: core/src/main/scala/org/apache/spark/internal/config/UI.scala ## @@ -203,4 +203,15 @@ private[spark] object UI { .stringConf

[GitHub] [spark] SparkQA commented on pull request #30364: [SPARK-33140][SQL][FOLLOW-UP] Revert code that not use passed-in SparkSession to get SQLConf.

2020-11-16 Thread GitBox
SparkQA commented on pull request #30364: URL: https://github.com/apache/spark/pull/30364#issuecomment-727821317 **[Test build #131142 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131142/testReport)** for PR 30364 at commit [`5cd23d7`](https://github.com

[GitHub] [spark] cloud-fan commented on pull request #29497: [WIP][SPARK-32670][SQL]Group exception messages in Catalyst Analyzer in one file

2020-11-16 Thread GitBox
cloud-fan commented on pull request #29497: URL: https://github.com/apache/spark/pull/29497#issuecomment-727818488 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] cloud-fan commented on pull request #30364: [SPARK-33140][SQL][FOLLOW-UP] Revert code that not use passed-in SparkSession to get SQLConf.

2020-11-16 Thread GitBox
cloud-fan commented on pull request #30364: URL: https://github.com/apache/spark/pull/30364#issuecomment-727818623 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] cloud-fan commented on pull request #30300: [SPARK-33399][SQL] Normalize output partitioning and sortorder with respect to aliases to avoid unneeded exchange/sort nodes

2020-11-16 Thread GitBox
cloud-fan commented on pull request #30300: URL: https://github.com/apache/spark/pull/30300#issuecomment-727817546 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] cloud-fan commented on a change in pull request #30341: [SPARK-33427][SQL] Add subexpression elimination for interpreted expression evaluation

2020-11-16 Thread GitBox
cloud-fan commented on a change in pull request #30341: URL: https://github.com/apache/spark/pull/30341#discussion_r523962907 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SubExprEvaluationRuntime.scala ## @@ -0,0 +1,126 @@ +/* + * License

[GitHub] [spark] cloud-fan commented on a change in pull request #30341: [SPARK-33427][SQL] Add subexpression elimination for interpreted expression evaluation

2020-11-16 Thread GitBox
cloud-fan commented on a change in pull request #30341: URL: https://github.com/apache/spark/pull/30341#discussion_r523962095 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/SubExprEvaluationRuntimeSuite.scala ## @@ -0,0 +1,99 @@ +/* + * Lic

[GitHub] [spark] viirya commented on a change in pull request #30341: [SPARK-33427][SQL] Add subexpression elimination for interpreted expression evaluation

2020-11-16 Thread GitBox
viirya commented on a change in pull request #30341: URL: https://github.com/apache/spark/pull/30341#discussion_r523961911 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SubExprEvaluationRuntime.scala ## @@ -0,0 +1,126 @@ +/* + * Licensed t

[GitHub] [spark] cloud-fan commented on a change in pull request #30341: [SPARK-33427][SQL] Add subexpression elimination for interpreted expression evaluation

2020-11-16 Thread GitBox
cloud-fan commented on a change in pull request #30341: URL: https://github.com/apache/spark/pull/30341#discussion_r523961435 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/SubExprEvaluationRuntimeSuite.scala ## @@ -0,0 +1,99 @@ +/* + * Lic

[GitHub] [spark] SparkQA commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf

2020-11-16 Thread GitBox
SparkQA commented on pull request #30299: URL: https://github.com/apache/spark/pull/30299#issuecomment-727814224 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35742/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30300: [SPARK-33399][SQL] Normalize output partitioning and sortorder with respect to aliases to avoid unneeded exchange/sort nodes

2020-11-16 Thread GitBox
AmplabJenkins removed a comment on pull request #30300: URL: https://github.com/apache/spark/pull/30300#issuecomment-727812985 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30300: [SPARK-33399][SQL] Normalize output partitioning and sortorder with respect to aliases to avoid unneeded exchange/sort nodes

2020-11-16 Thread GitBox
AmplabJenkins removed a comment on pull request #30300: URL: https://github.com/apache/spark/pull/30300#issuecomment-727812979 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins commented on pull request #30300: [SPARK-33399][SQL] Normalize output partitioning and sortorder with respect to aliases to avoid unneeded exchange/sort nodes

2020-11-16 Thread GitBox
AmplabJenkins commented on pull request #30300: URL: https://github.com/apache/spark/pull/30300#issuecomment-727812979 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30384: [SPARK-33456][SQL][TEST][FOLLOWUP] Fix SUBEXPRESSION_ELIMINATION_ENABLED config name

2020-11-16 Thread GitBox
AmplabJenkins removed a comment on pull request #30384: URL: https://github.com/apache/spark/pull/30384#issuecomment-727812474 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #30300: [SPARK-33399][SQL] Normalize output partitioning and sortorder with respect to aliases to avoid unneeded exchange/sort nodes

2020-11-16 Thread GitBox
SparkQA commented on pull request #30300: URL: https://github.com/apache/spark/pull/30300#issuecomment-727812953 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35739/ ---

[GitHub] [spark] cloud-fan commented on a change in pull request #30341: [SPARK-33427][SQL] Add subexpression elimination for interpreted expression evaluation

2020-11-16 Thread GitBox
cloud-fan commented on a change in pull request #30341: URL: https://github.com/apache/spark/pull/30341#discussion_r523957768 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SubExprEvaluationRuntime.scala ## @@ -0,0 +1,126 @@ +/* + * License

[GitHub] [spark] SparkQA commented on pull request #30384: [SPARK-33456][SQL][TEST][FOLLOWUP] Fix SUBEXPRESSION_ELIMINATION_ENABLED config name

2020-11-16 Thread GitBox
SparkQA commented on pull request #30384: URL: https://github.com/apache/spark/pull/30384#issuecomment-727812452 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35740/ ---

[GitHub] [spark] AmplabJenkins commented on pull request #30384: [SPARK-33456][SQL][TEST][FOLLOWUP] Fix SUBEXPRESSION_ELIMINATION_ENABLED config name

2020-11-16 Thread GitBox
AmplabJenkins commented on pull request #30384: URL: https://github.com/apache/spark/pull/30384#issuecomment-727812474 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] cloud-fan commented on a change in pull request #30341: [SPARK-33427][SQL] Add subexpression elimination for interpreted expression evaluation

2020-11-16 Thread GitBox
cloud-fan commented on a change in pull request #30341: URL: https://github.com/apache/spark/pull/30341#discussion_r523956362 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SubExprEvaluationRuntime.scala ## @@ -0,0 +1,126 @@ +/* + * License

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30300: [SPARK-33399][SQL] Normalize output partitioning and sortorder with respect to aliases to avoid unneeded exchange/sort nodes

2020-11-16 Thread GitBox
AmplabJenkins removed a comment on pull request #30300: URL: https://github.com/apache/spark/pull/30300#issuecomment-727809856 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30378: [SPARK-33454][INFRA] Add GitHub Action job for Hadoop 2

2020-11-16 Thread GitBox
AmplabJenkins removed a comment on pull request #30378: URL: https://github.com/apache/spark/pull/30378#issuecomment-727810574 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30364: [SPARK-33140][SQL][FOLLOW-UP] Revert code that not use passed-in SparkSession to get SQLConf.

2020-11-16 Thread GitBox
AmplabJenkins removed a comment on pull request #30364: URL: https://github.com/apache/spark/pull/30364#issuecomment-727809769 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf

2020-11-16 Thread GitBox
AmplabJenkins removed a comment on pull request #30299: URL: https://github.com/apache/spark/pull/30299#issuecomment-727809703 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131

[GitHub] [spark] AmplabJenkins commented on pull request #30378: [SPARK-33454][INFRA] Add GitHub Action job for Hadoop 2

2020-11-16 Thread GitBox
AmplabJenkins commented on pull request #30378: URL: https://github.com/apache/spark/pull/30378#issuecomment-727810563 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30384: [SPARK-33456][SQL][TEST][FOLLOWUP] Fix SUBEXPRESSION_ELIMINATION_ENABLED config name

2020-11-16 Thread GitBox
AmplabJenkins removed a comment on pull request #30384: URL: https://github.com/apache/spark/pull/30384#issuecomment-727809770 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29497: [WIP][SPARK-32670][SQL]Group exception messages in Catalyst Analyzer in one file

2020-11-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29497: URL: https://github.com/apache/spark/pull/29497#issuecomment-727809960 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30378: [SPARK-33454][INFRA] Add GitHub Action job for Hadoop 2

2020-11-16 Thread GitBox
AmplabJenkins removed a comment on pull request #30378: URL: https://github.com/apache/spark/pull/30378#issuecomment-727810563 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] SparkQA commented on pull request #30299: [SPARK-33389][SQL] Make internal classes of SparkSession always using active SQLConf

2020-11-16 Thread GitBox
SparkQA commented on pull request #30299: URL: https://github.com/apache/spark/pull/30299#issuecomment-727810438 **[Test build #131141 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131141/testReport)** for PR 30299 at commit [`0cc0b42`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30300: [SPARK-33399][SQL] Normalize output partitioning and sortorder with respect to aliases to avoid unneeded exchange/sort nodes

2020-11-16 Thread GitBox
AmplabJenkins removed a comment on pull request #30300: URL: https://github.com/apache/spark/pull/30300#issuecomment-727809847 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30364: [SPARK-33140][SQL][FOLLOW-UP] Revert code that not use passed-in SparkSession to get SQLConf.

2020-11-16 Thread GitBox
AmplabJenkins removed a comment on pull request #30364: URL: https://github.com/apache/spark/pull/30364#issuecomment-727809756 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29497: [WIP][SPARK-32670][SQL]Group exception messages in Catalyst Analyzer in one file

2020-11-16 Thread GitBox
AmplabJenkins removed a comment on pull request #29497: URL: https://github.com/apache/spark/pull/29497#issuecomment-727809699 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #30300: [SPARK-33399][SQL] Normalize output partitioning and sortorder with respect to aliases to avoid unneeded exchange/sort nodes

2020-11-16 Thread GitBox
SparkQA removed a comment on pull request #30300: URL: https://github.com/apache/spark/pull/30300#issuecomment-727778057 **[Test build #131136 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131136/testReport)** for PR 30300 at commit [`16e1db2`](https://gi

[GitHub] [spark] SparkQA removed a comment on pull request #29497: [WIP][SPARK-32670][SQL]Group exception messages in Catalyst Analyzer in one file

2020-11-16 Thread GitBox
SparkQA removed a comment on pull request #29497: URL: https://github.com/apache/spark/pull/29497#issuecomment-727806593 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30384: [SPARK-33456][SQL][TEST][FOLLOWUP] Fix SUBEXPRESSION_ELIMINATION_ENABLED config name

2020-11-16 Thread GitBox
AmplabJenkins removed a comment on pull request #30384: URL: https://github.com/apache/spark/pull/30384#issuecomment-727809758 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To r

<    4   5   6   7   8   9   10   >