[GitHub] [spark] SparkQA commented on pull request #31148: [SPARK-33867][SQL] Instant and LocalDate values aren't handled when generating SQL queries

2021-01-27 Thread GitBox
SparkQA commented on pull request #31148: URL: https://github.com/apache/spark/pull/31148#issuecomment-768430404 **[Test build #134551 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134551/testReport)** for PR 31148 at commit [`4f058af`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #31363: [WIP][SPARK-34154][YARN] Fix flaky test in LocalityPlacementStrategySuite

2021-01-27 Thread GitBox
SparkQA removed a comment on pull request #31363: URL: https://github.com/apache/spark/pull/31363#issuecomment-768414005 **[Test build #134559 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134559/testReport)** for PR 31363 at commit [`2c51957`](https://gi

[GitHub] [spark] SparkQA commented on pull request #31363: [WIP][SPARK-34154][YARN] Fix flaky test in LocalityPlacementStrategySuite

2021-01-27 Thread GitBox
SparkQA commented on pull request #31363: URL: https://github.com/apache/spark/pull/31363#issuecomment-768427808 **[Test build #134559 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134559/testReport)** for PR 31363 at commit [`2c51957`](https://github.co

[GitHub] [spark] razajafri commented on pull request #31284: [SPARK-34167][SQL]Reading parquet with IntDecimal written as a LongDecimal blows up

2021-01-27 Thread GitBox
razajafri commented on pull request #31284: URL: https://github.com/apache/spark/pull/31284#issuecomment-768424921 > > ... but write it as an int by downcasting it ... > > @razajafri would you mind pointing out where it happens? Sure, here is the original [code](https://githu

[GitHub] [spark] SparkQA commented on pull request #31366: [SPARK-34267][SQL] Remove `refreshTable()` from `SessionState`

2021-01-27 Thread GitBox
SparkQA commented on pull request #31366: URL: https://github.com/apache/spark/pull/31366#issuecomment-768415695 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39142/ ---

[GitHub] [spark] SparkQA commented on pull request #31363: [WIP][SPARK-34154][YARN] Fix flaky test in LocalityPlacementStrategySuite

2021-01-27 Thread GitBox
SparkQA commented on pull request #31363: URL: https://github.com/apache/spark/pull/31363#issuecomment-768414005 **[Test build #134559 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134559/testReport)** for PR 31363 at commit [`2c51957`](https://github.com

[GitHub] [spark] AmplabJenkins commented on pull request #31367: [SPARK-34265][PYTHON][SQL] Instrument Python UDF using SQL Metrics

2021-01-27 Thread GitBox
AmplabJenkins commented on pull request #31367: URL: https://github.com/apache/spark/pull/31367#issuecomment-768407960 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To resp

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31360: [SPARK-34260][SQL] Fix UnresolvedException when creating temp view twice

2021-01-27 Thread GitBox
AmplabJenkins removed a comment on pull request #31360: URL: https://github.com/apache/spark/pull/31360#issuecomment-768406912 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134547/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31365: [SPARK-34260][SQL][3.0] Fix UnresolvedException when creating temp view twice

2021-01-27 Thread GitBox
AmplabJenkins removed a comment on pull request #31365: URL: https://github.com/apache/spark/pull/31365#issuecomment-768406911 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134552/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31358: [SPARK-34261][SQL] Avoid side effect if create exists temporary function

2021-01-27 Thread GitBox
AmplabJenkins removed a comment on pull request #31358: URL: https://github.com/apache/spark/pull/31358#issuecomment-768406910 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39141/

[GitHub] [spark] AmplabJenkins commented on pull request #31358: [SPARK-34261][SQL] Avoid side effect if create exists temporary function

2021-01-27 Thread GitBox
AmplabJenkins commented on pull request #31358: URL: https://github.com/apache/spark/pull/31358#issuecomment-768406910 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39141/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31360: [SPARK-34260][SQL] Fix UnresolvedException when creating temp view twice

2021-01-27 Thread GitBox
AmplabJenkins commented on pull request #31360: URL: https://github.com/apache/spark/pull/31360#issuecomment-768406912 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134547/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31365: [SPARK-34260][SQL][3.0] Fix UnresolvedException when creating temp view twice

2021-01-27 Thread GitBox
AmplabJenkins commented on pull request #31365: URL: https://github.com/apache/spark/pull/31365#issuecomment-768406911 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134552/ -

[GitHub] [spark] srowen commented on a change in pull request #31354: [SPARK-34256][ML] VectorSlicer refine numFeatures checking and toString method

2021-01-27 Thread GitBox
srowen commented on a change in pull request #31354: URL: https://github.com/apache/spark/pull/31354#discussion_r565452315 ## File path: mllib/src/main/scala/org/apache/spark/ml/feature/VectorSlicer.scala ## @@ -100,10 +100,10 @@ final class VectorSlicer @Since("1.5.0") (@Since

[GitHub] [spark] SparkQA commented on pull request #31254: [SPARK-34165][SQL] Add count_distinct as an option to Dataset#summary

2021-01-27 Thread GitBox
SparkQA commented on pull request #31254: URL: https://github.com/apache/spark/pull/31254#issuecomment-768405843 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39144/ -

[GitHub] [spark] SparkQA commented on pull request #31366: [SPARK-34267][SQL] Remove `refreshTable()` from `SessionState`

2021-01-27 Thread GitBox
SparkQA commented on pull request #31366: URL: https://github.com/apache/spark/pull/31366#issuecomment-768396895 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39142/ -

[GitHub] [spark] xkrogen commented on pull request #31332: [SPARK-34231][AVRO][TEST] Make proper use of resource file within AvroSuite test case

2021-01-27 Thread GitBox
xkrogen commented on pull request #31332: URL: https://github.com/apache/spark/pull/31332#issuecomment-768394879 Good catch on the PR title as well, thank you for fixing 🙏🏼 This is an automated message from the Apache Git Se

[GitHub] [spark] xkrogen commented on pull request #31332: [SPARK-34231][AVRO][TEST] Make proper use of resource file within AvroSuite test case

2021-01-27 Thread GitBox
xkrogen commented on pull request #31332: URL: https://github.com/apache/spark/pull/31332#issuecomment-768394279 Thanks @HyukjinKwon ! This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [spark] LucaCanali commented on a change in pull request #26953: [SPARK-30306][CORE][PYTHON][WIP] Instrument Python UDF execution time and throughput metrics using Spark Metrics system

2021-01-27 Thread GitBox
LucaCanali commented on a change in pull request #26953: URL: https://github.com/apache/spark/pull/26953#discussion_r565433850 ## File path: core/src/main/scala/org/apache/spark/api/python/PythonRunner.scala ## @@ -434,7 +443,10 @@ private[spark] abstract class BasePythonRunner

[GitHub] [spark] LucaCanali opened a new pull request #31367: [SPARK-34265][PYTHON][SQL] Instrument Python UDF using SQL Metrics

2021-01-27 Thread GitBox
LucaCanali opened a new pull request #31367: URL: https://github.com/apache/spark/pull/31367 ### What changes were proposed in this pull request? This proposes to add SQLMetrics instrumentation for Python UDF execution. ### Why are the changes needed? This is aimed at improving

[GitHub] [spark] SparkQA commented on pull request #31358: [SPARK-34261][SQL] Avoid side effect if create exists temporary function

2021-01-27 Thread GitBox
SparkQA commented on pull request #31358: URL: https://github.com/apache/spark/pull/31358#issuecomment-768383743 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39141/ ---

[GitHub] [spark] SparkQA removed a comment on pull request #31360: [SPARK-34260][SQL] Fix UnresolvedException when creating temp view twice

2021-01-27 Thread GitBox
SparkQA removed a comment on pull request #31360: URL: https://github.com/apache/spark/pull/31360#issuecomment-768225482 **[Test build #134547 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134547/testReport)** for PR 31360 at commit [`3f4e73c`](https://gi

[GitHub] [spark] SparkQA removed a comment on pull request #31365: [SPARK-34260][SQL][3.0] Fix UnresolvedException when creating temp view twice

2021-01-27 Thread GitBox
SparkQA removed a comment on pull request #31365: URL: https://github.com/apache/spark/pull/31365#issuecomment-768332676 **[Test build #134552 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134552/testReport)** for PR 31365 at commit [`3a048a7`](https://gi

[GitHub] [spark] SparkQA commented on pull request #31365: [SPARK-34260][SQL][3.0] Fix UnresolvedException when creating temp view twice

2021-01-27 Thread GitBox
SparkQA commented on pull request #31365: URL: https://github.com/apache/spark/pull/31365#issuecomment-768377458 **[Test build #134552 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134552/testReport)** for PR 31365 at commit [`3a048a7`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #31360: [SPARK-34260][SQL] Fix UnresolvedException when creating temp view twice

2021-01-27 Thread GitBox
SparkQA commented on pull request #31360: URL: https://github.com/apache/spark/pull/31360#issuecomment-768377046 **[Test build #134547 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134547/testReport)** for PR 31360 at commit [`3f4e73c`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31363: [WIP][SPARK-34154][YARN] Fix flaky test in LocalityPlacementStrategySuite

2021-01-27 Thread GitBox
AmplabJenkins removed a comment on pull request #31363: URL: https://github.com/apache/spark/pull/31363#issuecomment-768373131 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39140/

[GitHub] [spark] AmplabJenkins commented on pull request #31363: [WIP][SPARK-34154][YARN] Fix flaky test in LocalityPlacementStrategySuite

2021-01-27 Thread GitBox
AmplabJenkins commented on pull request #31363: URL: https://github.com/apache/spark/pull/31363#issuecomment-768373131 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39140/ -

[GitHub] [spark] SparkQA commented on pull request #31363: [WIP][SPARK-34154][YARN] Fix flaky test in LocalityPlacementStrategySuite

2021-01-27 Thread GitBox
SparkQA commented on pull request #31363: URL: https://github.com/apache/spark/pull/31363#issuecomment-768373098 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39140/ ---

[GitHub] [spark] SparkQA commented on pull request #31366: [SPARK-34267][SQL] Remove `refreshTable()` from `SessionState`

2021-01-27 Thread GitBox
SparkQA commented on pull request #31366: URL: https://github.com/apache/spark/pull/31366#issuecomment-768372607 **[Test build #134556 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134556/testReport)** for PR 31366 at commit [`3f57b7c`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #31254: [SPARK-34165][SQL] Add count_distinct as an option to Dataset#summary

2021-01-27 Thread GitBox
SparkQA commented on pull request #31254: URL: https://github.com/apache/spark/pull/31254#issuecomment-768367512 **[Test build #134558 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134558/testReport)** for PR 31254 at commit [`bc547a2`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #31362: [SPARK-34263][SQL] Simplify the code for treating unicode/octal/escaped characters in string literals

2021-01-27 Thread GitBox
SparkQA commented on pull request #31362: URL: https://github.com/apache/spark/pull/31362#issuecomment-768367359 **[Test build #134557 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134557/testReport)** for PR 31362 at commit [`82b8fb9`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31364: [SPARK-34266][SQL][DOCS] Update comments for `SessionCatalog.refreshTable()` and `CatalogImpl.refreshTable()`

2021-01-27 Thread GitBox
AmplabJenkins removed a comment on pull request #31364: URL: https://github.com/apache/spark/pull/31364#issuecomment-768365330 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39139/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31363: [WIP][SPARK-34154][YARN] Fix flaky test in LocalityPlacementStrategySuite

2021-01-27 Thread GitBox
AmplabJenkins removed a comment on pull request #31363: URL: https://github.com/apache/spark/pull/31363#issuecomment-768365331 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134554/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31362: [SPARK-34263][SQL] Simplify the code for treating unicode/octal/escaped characters in string literals

2021-01-27 Thread GitBox
AmplabJenkins removed a comment on pull request #31362: URL: https://github.com/apache/spark/pull/31362#issuecomment-768365325 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31365: [SPARK-34260][SQL][3.0] Fix UnresolvedException when creating temp view twice

2021-01-27 Thread GitBox
AmplabJenkins removed a comment on pull request #31365: URL: https://github.com/apache/spark/pull/31365#issuecomment-768365557 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39138/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31361: [SPARK-34262][SQL] Refresh cached data of v1 table in `ALTER TABLE .. SET LOCATION`

2021-01-27 Thread GitBox
AmplabJenkins removed a comment on pull request #31361: URL: https://github.com/apache/spark/pull/31361#issuecomment-768365323 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134546/ -

[GitHub] [spark] SparkQA commented on pull request #31365: [SPARK-34260][SQL][3.0] Fix UnresolvedException when creating temp view twice

2021-01-27 Thread GitBox
SparkQA commented on pull request #31365: URL: https://github.com/apache/spark/pull/31365#issuecomment-768365523 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39138/ ---

[GitHub] [spark] AmplabJenkins commented on pull request #31365: [SPARK-34260][SQL][3.0] Fix UnresolvedException when creating temp view twice

2021-01-27 Thread GitBox
AmplabJenkins commented on pull request #31365: URL: https://github.com/apache/spark/pull/31365#issuecomment-768365557 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39138/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31364: [SPARK-34266][SQL][DOCS] Update comments for `SessionCatalog.refreshTable()` and `CatalogImpl.refreshTable()`

2021-01-27 Thread GitBox
AmplabJenkins commented on pull request #31364: URL: https://github.com/apache/spark/pull/31364#issuecomment-768365330 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39139/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31362: [SPARK-34263][SQL] Simplify the code for treating unicode/octal/escaped characters in string literals

2021-01-27 Thread GitBox
AmplabJenkins commented on pull request #31362: URL: https://github.com/apache/spark/pull/31362#issuecomment-768365325 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [spark] AmplabJenkins commented on pull request #31363: [WIP][SPARK-34154][YARN] Fix flaky test in LocalityPlacementStrategySuite

2021-01-27 Thread GitBox
AmplabJenkins commented on pull request #31363: URL: https://github.com/apache/spark/pull/31363#issuecomment-768365331 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134554/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31361: [SPARK-34262][SQL] Refresh cached data of v1 table in `ALTER TABLE .. SET LOCATION`

2021-01-27 Thread GitBox
AmplabJenkins commented on pull request #31361: URL: https://github.com/apache/spark/pull/31361#issuecomment-768365323 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134546/ -

[GitHub] [spark] SparkQA commented on pull request #31358: [SPARK-34261][SQL] Avoid side effect if create exists temporary function

2021-01-27 Thread GitBox
SparkQA commented on pull request #31358: URL: https://github.com/apache/spark/pull/31358#issuecomment-768358955 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39141/ -

[GitHub] [spark] cristichircu commented on pull request #31148: [SPARK-33867][SQL] Instant and LocalDate values aren't handled when generating SQL queries

2021-01-27 Thread GitBox
cristichircu commented on pull request #31148: URL: https://github.com/apache/spark/pull/31148#issuecomment-768358260 Thanks you for pointing that out, @HyukjinKwon! Done This is an automated message from the Apache Git Servi

[GitHub] [spark] cloud-fan commented on a change in pull request #31349: [SPARK-34246][SQL] New type coercion syntax rules in ANSI mode

2021-01-27 Thread GitBox
cloud-fan commented on a change in pull request #31349: URL: https://github.com/apache/spark/pull/31349#discussion_r565394361 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala ## @@ -211,34 +105,27 @@ object TypeCoercion {

[GitHub] [spark] SparkQA commented on pull request #31364: [SPARK-34266][SQL][DOCS] Update comments for `SessionCatalog.refreshTable()` and `CatalogImpl.refreshTable()`

2021-01-27 Thread GitBox
SparkQA commented on pull request #31364: URL: https://github.com/apache/spark/pull/31364#issuecomment-768355248 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39139/ ---

[GitHub] [spark] cloud-fan commented on a change in pull request #31349: [SPARK-34246][SQL] New type coercion syntax rules in ANSI mode

2021-01-27 Thread GitBox
cloud-fan commented on a change in pull request #31349: URL: https://github.com/apache/spark/pull/31349#discussion_r565391447 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala ## @@ -31,126 +31,20 @@ import org.apache.spark.sql

[GitHub] [spark] SparkQA commented on pull request #31363: [WIP][SPARK-34154][YARN] Fix flaky test in LocalityPlacementStrategySuite

2021-01-27 Thread GitBox
SparkQA commented on pull request #31363: URL: https://github.com/apache/spark/pull/31363#issuecomment-768352788 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39140/ -

[GitHub] [spark] SparkQA commented on pull request #31364: [SPARK-34266][SQL][DOCS] Update comments for `SessionCatalog.refreshTable()` and `CatalogImpl.refreshTable()`

2021-01-27 Thread GitBox
SparkQA commented on pull request #31364: URL: https://github.com/apache/spark/pull/31364#issuecomment-768352342 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39139/ -

[GitHub] [spark] MaxGekk commented on pull request #31366: [SPARK-34267][SQL] Remove `refreshTable()` from `SessionState`

2021-01-27 Thread GitBox
MaxGekk commented on pull request #31366: URL: https://github.com/apache/spark/pull/31366#issuecomment-768352178 @cloud-fan @sunchao @HyukjinKwon @dongjoon-hyun Please, review this PR. This is an automated message from the Ap

[GitHub] [spark] MaxGekk opened a new pull request #31366: [SPARK-34267][SQL] Remove `refreshTable()` from `SessionState`

2021-01-27 Thread GitBox
MaxGekk opened a new pull request #31366: URL: https://github.com/apache/spark/pull/31366 ### What changes were proposed in this pull request? Remove `SessionState.refreshTable()` and modify the tests where the method is used. ### Why are the changes needed? There are already 2

[GitHub] [spark] SparkQA commented on pull request #31365: [SPARK-34260][SQL][3.0] Fix UnresolvedException when creating temp view twice

2021-01-27 Thread GitBox
SparkQA commented on pull request #31365: URL: https://github.com/apache/spark/pull/31365#issuecomment-768351022 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39138/ -

[GitHub] [spark] SparkQA removed a comment on pull request #31363: [WIP][SPARK-34154][YARN] Fix flaky test in LocalityPlacementStrategySuite

2021-01-27 Thread GitBox
SparkQA removed a comment on pull request #31363: URL: https://github.com/apache/spark/pull/31363#issuecomment-768333480 **[Test build #134554 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134554/testReport)** for PR 31363 at commit [`c6ca806`](https://gi

[GitHub] [spark] cloud-fan commented on a change in pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly

2021-01-27 Thread GitBox
cloud-fan commented on a change in pull request #31341: URL: https://github.com/apache/spark/pull/31341#discussion_r565382661 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ## @@ -972,10 +972,9 @@ case class ShowColumnsCommand( */

[GitHub] [spark] SparkQA commented on pull request #31363: [WIP][SPARK-34154][YARN] Fix flaky test in LocalityPlacementStrategySuite

2021-01-27 Thread GitBox
SparkQA commented on pull request #31363: URL: https://github.com/apache/spark/pull/31363#issuecomment-768348150 **[Test build #134554 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134554/testReport)** for PR 31363 at commit [`c6ca806`](https://github.co

[GitHub] [spark] cloud-fan commented on pull request #31355: [SPARK-34255][SQL] Support partitioning with static number on required distribution and ordering on V2 write

2021-01-27 Thread GitBox
cloud-fan commented on pull request #31355: URL: https://github.com/apache/spark/pull/31355#issuecomment-768347645 The use case makes sense to me. This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [spark] cloud-fan commented on a change in pull request #31355: [SPARK-34255][SQL] Support partitioning with static number on required distribution and ordering on V2 write

2021-01-27 Thread GitBox
cloud-fan commented on a change in pull request #31355: URL: https://github.com/apache/spark/pull/31355#discussion_r565381214 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/connector/distributions/distributions.scala ## @@ -29,31 +29,47 @@ private[sql] object L

[GitHub] [spark] SparkQA commented on pull request #31362: [SPARK-34263][SQL] Simplify the code for treating unicode/octal/escaped characters in string literals

2021-01-27 Thread GitBox
SparkQA commented on pull request #31362: URL: https://github.com/apache/spark/pull/31362#issuecomment-768343073 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39135/ ---

[GitHub] [spark] cloud-fan commented on a change in pull request #31355: [SPARK-34255][SQL] Support partitioning with static number on required distribution and ordering on V2 write

2021-01-27 Thread GitBox
cloud-fan commented on a change in pull request #31355: URL: https://github.com/apache/spark/pull/31355#discussion_r565370445 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/distributions/OrderedDistribution.java ## @@ -32,4 +32,13 @@ * Returns orde

[GitHub] [spark] srowen commented on pull request #31254: [SPARK-34165][SQL] Add count_distinct as an option to Dataset#summary

2021-01-27 Thread GitBox
srowen commented on pull request #31254: URL: https://github.com/apache/spark/pull/31254#issuecomment-768337997 Jenkins retest this please This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [spark] cloud-fan commented on a change in pull request #31355: [SPARK-34255][SQL] Support partitioning with static number on required distribution and ordering on V2 write

2021-01-27 Thread GitBox
cloud-fan commented on a change in pull request #31355: URL: https://github.com/apache/spark/pull/31355#discussion_r565369889 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/distributions/ClusteredDistribution.java ## @@ -32,4 +32,13 @@ * Returns cl

[GitHub] [spark] SparkQA removed a comment on pull request #31362: [SPARK-34263][SQL] Simplify the code for treating unicode/octal/escaped characters in string literals

2021-01-27 Thread GitBox
SparkQA removed a comment on pull request #31362: URL: https://github.com/apache/spark/pull/31362#issuecomment-768260104 **[Test build #134549 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134549/testReport)** for PR 31362 at commit [`c2ae791`](https://gi

[GitHub] [spark] SparkQA commented on pull request #31362: [SPARK-34263][SQL] Simplify the code for treating unicode/octal/escaped characters in string literals

2021-01-27 Thread GitBox
SparkQA commented on pull request #31362: URL: https://github.com/apache/spark/pull/31362#issuecomment-768335952 **[Test build #134549 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134549/testReport)** for PR 31362 at commit [`c2ae791`](https://github.co

[GitHub] [spark] cloud-fan commented on a change in pull request #31364: [SPARK-34266][SQL][DOCS] Update comments for `SessionCatalog.refreshTable()` and `CatalogImpl.refreshTable()`

2021-01-27 Thread GitBox
cloud-fan commented on a change in pull request #31364: URL: https://github.com/apache/spark/pull/31364#discussion_r565365100 ## File path: sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala ## @@ -515,14 +515,19 @@ class CatalogImpl(sparkSession: SparkSes

[GitHub] [spark] SparkQA commented on pull request #31358: [SPARK-34261][SQL] Avoid side effect if create exists temporary function

2021-01-27 Thread GitBox
SparkQA commented on pull request #31358: URL: https://github.com/apache/spark/pull/31358#issuecomment-768333557 **[Test build #134555 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134555/testReport)** for PR 31358 at commit [`590b0b3`](https://github.com

[GitHub] [spark] SparkQA removed a comment on pull request #31361: [SPARK-34262][SQL] Refresh cached data of v1 table in `ALTER TABLE .. SET LOCATION`

2021-01-27 Thread GitBox
SparkQA removed a comment on pull request #31361: URL: https://github.com/apache/spark/pull/31361#issuecomment-768225449 **[Test build #134546 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134546/testReport)** for PR 31361 at commit [`a759c20`](https://gi

[GitHub] [spark] linhongliu-db commented on a change in pull request #31360: [SPARK-34260][SQL] Fix UnresolvedException when creating temp view twice

2021-01-27 Thread GitBox
linhongliu-db commented on a change in pull request #31360: URL: https://github.com/apache/spark/pull/31360#discussion_r565364575 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewTestSuite.scala ## @@ -249,6 +249,15 @@ abstract class SQLViewTestSuite

[GitHub] [spark] SparkQA commented on pull request #31364: [SPARK-34266][SQL][DOCS] Update comments for `SessionCatalog.refreshTable()` and `CatalogImpl.refreshTable()`

2021-01-27 Thread GitBox
SparkQA commented on pull request #31364: URL: https://github.com/apache/spark/pull/31364#issuecomment-768333446 **[Test build #134553 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134553/testReport)** for PR 31364 at commit [`c20579e`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #31363: [WIP][SPARK-34154][YARN] Fix flaky test in LocalityPlacementStrategySuite

2021-01-27 Thread GitBox
SparkQA commented on pull request #31363: URL: https://github.com/apache/spark/pull/31363#issuecomment-768333480 **[Test build #134554 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134554/testReport)** for PR 31363 at commit [`c6ca806`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #31361: [SPARK-34262][SQL] Refresh cached data of v1 table in `ALTER TABLE .. SET LOCATION`

2021-01-27 Thread GitBox
SparkQA commented on pull request #31361: URL: https://github.com/apache/spark/pull/31361#issuecomment-768333292 **[Test build #134546 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134546/testReport)** for PR 31361 at commit [`a759c20`](https://github.co

[GitHub] [spark] cloud-fan commented on a change in pull request #31364: [SPARK-34266][SQL][DOCS] Update comments for `SessionCatalog.refreshTable()` and `CatalogImpl.refreshTable()`

2021-01-27 Thread GitBox
cloud-fan commented on a change in pull request #31364: URL: https://github.com/apache/spark/pull/31364#discussion_r565363710 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala ## @@ -998,7 +998,26 @@ class SessionCatalog( }

[GitHub] [spark] SparkQA commented on pull request #31365: [SPARK-34260][SQL][3.0] Fix UnresolvedException when creating temp view twice

2021-01-27 Thread GitBox
SparkQA commented on pull request #31365: URL: https://github.com/apache/spark/pull/31365#issuecomment-768332676 **[Test build #134552 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134552/testReport)** for PR 31365 at commit [`3a048a7`](https://github.com

[GitHub] [spark] cloud-fan commented on a change in pull request #31364: [SPARK-34266][SQL][DOCS] Update comments for `SessionCatalog.refreshTable()` and `CatalogImpl.refreshTable()`

2021-01-27 Thread GitBox
cloud-fan commented on a change in pull request #31364: URL: https://github.com/apache/spark/pull/31364#discussion_r565363369 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala ## @@ -998,7 +998,26 @@ class SessionCatalog( }

[GitHub] [spark] cloud-fan commented on a change in pull request #31360: [SPARK-34260][SQL] Fix UnresolvedException when creating temp view twice

2021-01-27 Thread GitBox
cloud-fan commented on a change in pull request #31360: URL: https://github.com/apache/spark/pull/31360#discussion_r565355510 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewTestSuite.scala ## @@ -249,6 +249,15 @@ abstract class SQLViewTestSuite ext

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31148: [SPARK-33867][SQL] Instant and LocalDate values aren't handled when generating SQL queries

2021-01-27 Thread GitBox
AmplabJenkins removed a comment on pull request #31148: URL: https://github.com/apache/spark/pull/31148#issuecomment-768323405 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39137/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31204: [SPARK-26399][WEBUI][CORE] Add new stage-level REST APIs and parameters

2021-01-27 Thread GitBox
AmplabJenkins removed a comment on pull request #31204: URL: https://github.com/apache/spark/pull/31204#issuecomment-768323406 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134548/ -

[GitHub] [spark] zero323 commented on a change in pull request #31254: [SPARK-34165][SQL] Add count_distinct as an option to Dataset#summary

2021-01-27 Thread GitBox
zero323 commented on a change in pull request #31254: URL: https://github.com/apache/spark/pull/31254#discussion_r565353751 ## File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ## @@ -2670,6 +2670,7 @@ class Dataset[T] private[sql]( * min * max

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31264: [SPARK-34144][SQL] Exception thrown when trying to write LocalDate and Instant values to a table

2021-01-27 Thread GitBox
AmplabJenkins removed a comment on pull request #31264: URL: https://github.com/apache/spark/pull/31264#issuecomment-763830848 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #31148: [SPARK-33867][SQL] Instant and LocalDate values aren't handled when generating SQL queries

2021-01-27 Thread GitBox
AmplabJenkins commented on pull request #31148: URL: https://github.com/apache/spark/pull/31148#issuecomment-768323405 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39137/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31264: [SPARK-34144][SQL] Exception thrown when trying to write LocalDate and Instant values to a table

2021-01-27 Thread GitBox
AmplabJenkins commented on pull request #31264: URL: https://github.com/apache/spark/pull/31264#issuecomment-768323404 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39136/ -

[GitHub] [spark] zero323 commented on a change in pull request #31207: [SPARK-34136][PYTHON][SQL] Add support for complex literals in PySpark

2021-01-27 Thread GitBox
zero323 commented on a change in pull request #31207: URL: https://github.com/apache/spark/pull/31207#discussion_r565336841 ## File path: python/pyspark/sql/functions.py ## @@ -91,13 +92,48 @@ def lit(col): Creates a :class:`Column` of literal value. .. versionadded

[GitHub] [spark] AmplabJenkins commented on pull request #31204: [SPARK-26399][WEBUI][CORE] Add new stage-level REST APIs and parameters

2021-01-27 Thread GitBox
AmplabJenkins commented on pull request #31204: URL: https://github.com/apache/spark/pull/31204#issuecomment-768323406 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134548/ -

[GitHub] [spark] cloud-fan commented on a change in pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

2021-01-27 Thread GitBox
cloud-fan commented on a change in pull request #31245: URL: https://github.com/apache/spark/pull/31245#discussion_r565350592 ## File path: docs/sql-migration-guide.md ## @@ -40,6 +40,10 @@ license: | - In Spark 3.2, script transform default FIELD DELIMIT is `\u0001` for no

[GitHub] [spark] cloud-fan commented on a change in pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

2021-01-27 Thread GitBox
cloud-fan commented on a change in pull request #31245: URL: https://github.com/apache/spark/pull/31245#discussion_r565350592 ## File path: docs/sql-migration-guide.md ## @@ -40,6 +40,10 @@ license: | - In Spark 3.2, script transform default FIELD DELIMIT is `\u0001` for no

[GitHub] [spark] cloud-fan commented on a change in pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

2021-01-27 Thread GitBox
cloud-fan commented on a change in pull request #31245: URL: https://github.com/apache/spark/pull/31245#discussion_r565350592 ## File path: docs/sql-migration-guide.md ## @@ -40,6 +40,10 @@ license: | - In Spark 3.2, script transform default FIELD DELIMIT is `\u0001` for no

[GitHub] [spark] linhongliu-db commented on pull request #31360: [SPARK-34260][SQL] Fix UnresolvedException when creating temp view twice

2021-01-27 Thread GitBox
linhongliu-db commented on pull request #31360: URL: https://github.com/apache/spark/pull/31360#issuecomment-768321063 the fix for 3.0 branch: https://github.com/apache/spark/pull/31365 This is an automated message from the A

[GitHub] [spark] linhongliu-db commented on pull request #31365: [SPARK-34260][SQL][3.0] Fix UnresolvedException when creating temp view twice

2021-01-27 Thread GitBox
linhongliu-db commented on pull request #31365: URL: https://github.com/apache/spark/pull/31365#issuecomment-768320069 cc @maropu This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] linhongliu-db opened a new pull request #31365: [SPARK-34260][SQL][3.0] Fix UnresolvedException when creating temp view twice

2021-01-27 Thread GitBox
linhongliu-db opened a new pull request #31365: URL: https://github.com/apache/spark/pull/31365 ### What changes were proposed in this pull request? In PR #30140, it will compare new and old plans when replacing view and uncache data if the view has changed. But the compared new plan

[GitHub] [spark] cloud-fan commented on a change in pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

2021-01-27 Thread GitBox
cloud-fan commented on a change in pull request #31245: URL: https://github.com/apache/spark/pull/31245#discussion_r565346135 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2CommandExec.scala ## @@ -61,7 +61,7 @@ abstract class V2CommandEx

[GitHub] [spark] cloud-fan commented on a change in pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

2021-01-27 Thread GitBox
cloud-fan commented on a change in pull request #31245: URL: https://github.com/apache/spark/pull/31245#discussion_r565345334 ## File path: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ## @@ -680,7 +687,7 @@ class SQLContext private[sql](val sparkSession: Spar

[GitHub] [spark] cloud-fan commented on a change in pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

2021-01-27 Thread GitBox
cloud-fan commented on a change in pull request #31245: URL: https://github.com/apache/spark/pull/31245#discussion_r565344640 ## File path: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ## @@ -668,7 +675,7 @@ class SQLContext private[sql](val sparkSession: Spar

[GitHub] [spark] linhongliu-db closed pull request #31360: [SPARK-34260][SQL] Fix UnresolvedException when creating temp view twice

2021-01-27 Thread GitBox
linhongliu-db closed pull request #31360: URL: https://github.com/apache/spark/pull/31360 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] attilapiros commented on pull request #31363: [WIP][SPARK-34154][YARN] Fix flaky test in LocalityPlacementStrategySuite

2021-01-27 Thread GitBox
attilapiros commented on pull request #31363: URL: https://github.com/apache/spark/pull/31363#issuecomment-768315179 Well, I had no luck here. All of them successful: ``` [info] LocalityPlacementStrategySuite: [info] - handle large number of containers and tasks (SPARK-18750) 1

[GitHub] [spark] HyukjinKwon commented on pull request #31207: [SPARK-34136][PYTHON][SQL] Add support for complex literals in PySpark

2021-01-27 Thread GitBox
HyukjinKwon commented on pull request #31207: URL: https://github.com/apache/spark/pull/31207#issuecomment-768313838 Okie, I am good with this. This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [spark] zero323 commented on a change in pull request #31207: [SPARK-34136][PYTHON][SQL] Add support for complex literals in PySpark

2021-01-27 Thread GitBox
zero323 commented on a change in pull request #31207: URL: https://github.com/apache/spark/pull/31207#discussion_r565336841 ## File path: python/pyspark/sql/functions.py ## @@ -91,13 +92,48 @@ def lit(col): Creates a :class:`Column` of literal value. .. versionadded

[GitHub] [spark] MaxGekk commented on pull request #31364: [SPARK-34266][SQL][DOCS] Update comments for `SessionCatalog.refreshTable()` and `CatalogImpl.refreshTable()`

2021-01-27 Thread GitBox
MaxGekk commented on pull request #31364: URL: https://github.com/apache/spark/pull/31364#issuecomment-768309780 @cloud-fan @sunchao @HyukjinKwon @dongjoon-hyun Please, review this PR. This is an automated message from the Ap

[GitHub] [spark] MaxGekk opened a new pull request #31364: [SPARK-34266][SQL][DOCS] Update comments for `SessionCatalog.refreshTable()` and `CatalogImpl.refreshTable()`

2021-01-27 Thread GitBox
MaxGekk opened a new pull request #31364: URL: https://github.com/apache/spark/pull/31364 ### What changes were proposed in this pull request? Describe `SessionCatalog.refreshTable()` and `CatalogImpl.refreshTable()`. what they do and when they are supposed to be used. ### Why are

[GitHub] [spark] SparkQA removed a comment on pull request #31204: [SPARK-26399][WEBUI][CORE] Add new stage-level REST APIs and parameters

2021-01-27 Thread GitBox
SparkQA removed a comment on pull request #31204: URL: https://github.com/apache/spark/pull/31204#issuecomment-768225560 **[Test build #134548 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134548/testReport)** for PR 31204 at commit [`73c4777`](https://gi

[GitHub] [spark] SparkQA commented on pull request #31204: [SPARK-26399][WEBUI][CORE] Add new stage-level REST APIs and parameters

2021-01-27 Thread GitBox
SparkQA commented on pull request #31204: URL: https://github.com/apache/spark/pull/31204#issuecomment-768297758 **[Test build #134548 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134548/testReport)** for PR 31204 at commit [`73c4777`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #31148: [SPARK-33867][SQL] Instant and LocalDate values aren't handled when generating SQL queries

2021-01-27 Thread GitBox
SparkQA commented on pull request #31148: URL: https://github.com/apache/spark/pull/31148#issuecomment-768295776 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39137/ ---

<    1   2   3   4   5   6   7   8   >