[GitHub] [spark] SparkQA removed a comment on pull request #31378: [SPARK-34240][SQL] Unify output of SHOW TBLPROPERTIES pass output attribute properly

2021-02-01 Thread GitBox
SparkQA removed a comment on pull request #31378: URL: https://github.com/apache/spark/pull/31378#issuecomment-770965994 **[Test build #134739 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134739/testReport)** for PR 31378 at commit [`e229662`](https://gi

[GitHub] [spark] SparkQA commented on pull request #31378: [SPARK-34240][SQL] Unify output of SHOW TBLPROPERTIES pass output attribute properly

2021-02-01 Thread GitBox
SparkQA commented on pull request #31378: URL: https://github.com/apache/spark/pull/31378#issuecomment-771137858 **[Test build #134739 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134739/testReport)** for PR 31378 at commit [`e229662`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #31422: [SPARK-34313][SQL] Migrate ALTER TABLE SET/UNSET TBLPROPERTIES commands to use UnresolvedTable to resolve the identifier

2021-02-01 Thread GitBox
SparkQA commented on pull request #31422: URL: https://github.com/apache/spark/pull/31422#issuecomment-771122421 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39329/ ---

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31286: [SPARK-34199][SQL] Block `table.*` inside function to follow ANSI standard and other SQL engines

2021-02-01 Thread GitBox
AmplabJenkins removed a comment on pull request #31286: URL: https://github.com/apache/spark/pull/31286#issuecomment-771115508 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134738/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31286: [SPARK-34199][SQL] Block `table.*` inside function to follow ANSI standard and other SQL engines

2021-02-01 Thread GitBox
AmplabJenkins commented on pull request #31286: URL: https://github.com/apache/spark/pull/31286#issuecomment-771115508 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134738/ -

[GitHub] [spark] SparkQA commented on pull request #31423: [SPARK-34314][SQL] Rebuild the file index after partition schema inferring

2021-02-01 Thread GitBox
SparkQA commented on pull request #31423: URL: https://github.com/apache/spark/pull/31423#issuecomment-771115304 **[Test build #134744 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134744/testReport)** for PR 31423 at commit [`66ee353`](https://github.com

[GitHub] [spark] SparkQA removed a comment on pull request #31286: [SPARK-34199][SQL] Block `table.*` inside function to follow ANSI standard and other SQL engines

2021-02-01 Thread GitBox
SparkQA removed a comment on pull request #31286: URL: https://github.com/apache/spark/pull/31286#issuecomment-770925348 **[Test build #134738 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134738/testReport)** for PR 31286 at commit [`882ac3d`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31286: [SPARK-34199][SQL] Block `table.*` inside function to follow ANSI standard and other SQL engines

2021-02-01 Thread GitBox
AmplabJenkins removed a comment on pull request #31286: URL: https://github.com/apache/spark/pull/31286#issuecomment-770997063 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39324/

[GitHub] [spark] MaxGekk commented on pull request #31399: [SPARK-34259][SQL] Don't attempt to parse file-based partitions as special timestamps

2021-02-01 Thread GitBox
MaxGekk commented on pull request #31399: URL: https://github.com/apache/spark/pull/31399#issuecomment-771114617 > The bug described by @MaxGekk seems true and we should fix it as well. Here is the bug fix: https://github.com/apache/spark/pull/31423 with a test w/o special timestamp/

[GitHub] [spark] SparkQA commented on pull request #31286: [SPARK-34199][SQL] Block `table.*` inside function to follow ANSI standard and other SQL engines

2021-02-01 Thread GitBox
SparkQA commented on pull request #31286: URL: https://github.com/apache/spark/pull/31286#issuecomment-771114357 **[Test build #134738 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134738/testReport)** for PR 31286 at commit [`882ac3d`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31405: [SPARK-34304][SQL] Remove view checks in v1 alter table commands

2021-02-01 Thread GitBox
AmplabJenkins removed a comment on pull request #31405: URL: https://github.com/apache/spark/pull/31405#issuecomment-770456458 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31402: [SPARK-34296][SQL] AggregateWindowFunction frame should not always use UnboundedPreceding

2021-02-01 Thread GitBox
AmplabJenkins removed a comment on pull request #31402: URL: https://github.com/apache/spark/pull/31402#issuecomment-771113962 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134740/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31421: [SPARK-33591][SQL][FOLLOWUP] Add legacy config for recognizing null partition spec values

2021-02-01 Thread GitBox
AmplabJenkins removed a comment on pull request #31421: URL: https://github.com/apache/spark/pull/31421#issuecomment-771113965 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39327/

[GitHub] [spark] AmplabJenkins commented on pull request #31402: [SPARK-34296][SQL] AggregateWindowFunction frame should not always use UnboundedPreceding

2021-02-01 Thread GitBox
AmplabJenkins commented on pull request #31402: URL: https://github.com/apache/spark/pull/31402#issuecomment-771113962 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134740/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31421: [SPARK-33591][SQL][FOLLOWUP] Add legacy config for recognizing null partition spec values

2021-02-01 Thread GitBox
AmplabJenkins commented on pull request #31421: URL: https://github.com/apache/spark/pull/31421#issuecomment-771113965 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39327/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31405: [SPARK-34304][SQL] Remove view checks in v1 alter table commands

2021-02-01 Thread GitBox
AmplabJenkins commented on pull request #31405: URL: https://github.com/apache/spark/pull/31405#issuecomment-771113963 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134737/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31284: [SPARK-34167][SQL]Reading parquet with IntDecimal written as a LongDecimal blows up

2021-02-01 Thread GitBox
AmplabJenkins removed a comment on pull request #31284: URL: https://github.com/apache/spark/pull/31284#issuecomment-771113964 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39328/

[GitHub] [spark] AmplabJenkins commented on pull request #31284: [SPARK-34167][SQL]Reading parquet with IntDecimal written as a LongDecimal blows up

2021-02-01 Thread GitBox
AmplabJenkins commented on pull request #31284: URL: https://github.com/apache/spark/pull/31284#issuecomment-771113964 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39328/ -

[GitHub] [spark] MaxGekk opened a new pull request #31423: [SPARK-34314][SQL] Rebuild the file index after partition schema inferring

2021-02-01 Thread GitBox
MaxGekk opened a new pull request #31423: URL: https://github.com/apache/spark/pull/31423 ### What changes were proposed in this pull request? Create new file index after partition schema inferring, and use the inferred partition schema in it. ### Why are the changes needed? Th

[GitHub] [spark] alefischer13 edited a comment on pull request #26624: [SPARK-8981][CORE][test-hadoop3.2][test-java11] Add MDC support in Executor

2021-02-01 Thread GitBox
alefischer13 edited a comment on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-771017526 @igreenfield this does not seem to be working for me. I'm trying to log spark application_id by setting `mdc.applicationId` to sparkContext's applicationId and addin

[GitHub] [spark] SparkQA commented on pull request #31422: [SPARK-34313][SQL] Migrate ALTER TABLE SET/UNSET TBLPROPERTIES commands to use UnresolvedTable to resolve the identifier

2021-02-01 Thread GitBox
SparkQA commented on pull request #31422: URL: https://github.com/apache/spark/pull/31422#issuecomment-771108148 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39329/ -

[GitHub] [spark] SparkQA removed a comment on pull request #31405: [SPARK-34304][SQL] Remove view checks in v1 alter table commands

2021-02-01 Thread GitBox
SparkQA removed a comment on pull request #31405: URL: https://github.com/apache/spark/pull/31405#issuecomment-770923341 **[Test build #134737 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134737/testReport)** for PR 31405 at commit [`0dedf33`](https://gi

[GitHub] [spark] SparkQA commented on pull request #31405: [SPARK-34304][SQL] Remove view checks in v1 alter table commands

2021-02-01 Thread GitBox
SparkQA commented on pull request #31405: URL: https://github.com/apache/spark/pull/31405#issuecomment-771098149 **[Test build #134737 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134737/testReport)** for PR 31405 at commit [`0dedf33`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #31402: [SPARK-34296][SQL] AggregateWindowFunction frame should not always use UnboundedPreceding

2021-02-01 Thread GitBox
SparkQA removed a comment on pull request #31402: URL: https://github.com/apache/spark/pull/31402#issuecomment-771008925 **[Test build #134740 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134740/testReport)** for PR 31402 at commit [`84ed1b5`](https://gi

[GitHub] [spark] SparkQA commented on pull request #31402: [SPARK-34296][SQL] AggregateWindowFunction frame should not always use UnboundedPreceding

2021-02-01 Thread GitBox
SparkQA commented on pull request #31402: URL: https://github.com/apache/spark/pull/31402#issuecomment-771095646 **[Test build #134740 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134740/testReport)** for PR 31402 at commit [`84ed1b5`](https://github.co

[GitHub] [spark] imback82 commented on a change in pull request #31422: [SPARK-34313][SQL] Migrate ALTER TABLE SET/UNSET TBLPROPERTIES commands to use UnresolvedTable to resolve the identifier

2021-02-01 Thread GitBox
imback82 commented on a change in pull request #31422: URL: https://github.com/apache/spark/pull/31422#discussion_r568074584 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala ## @@ -431,6 +431,17 @@ class DataSourceV

[GitHub] [spark] SparkQA commented on pull request #31284: [SPARK-34167][SQL]Reading parquet with IntDecimal written as a LongDecimal blows up

2021-02-01 Thread GitBox
SparkQA commented on pull request #31284: URL: https://github.com/apache/spark/pull/31284#issuecomment-771088240 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39328/ ---

[GitHub] [spark] SparkQA commented on pull request #31422: [SPARK-34313][SQL] Migrate ALTER TABLE SET/UNSET TBLPROPERTIES commands to use UnresolvedTable to resolve the identifier

2021-02-01 Thread GitBox
SparkQA commented on pull request #31422: URL: https://github.com/apache/spark/pull/31422#issuecomment-771086398 **[Test build #134743 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134743/testReport)** for PR 31422 at commit [`ef56bc3`](https://github.com

[GitHub] [spark] imback82 opened a new pull request #31422: [SPARK-34313][SQL] Migrate ALTER TABLE SET/UNSET TBLPROPERTIES commands to use UnresolvedTable to resolve the identifier

2021-02-01 Thread GitBox
imback82 opened a new pull request #31422: URL: https://github.com/apache/spark/pull/31422 ### What changes were proposed in this pull request? This PR proposes to migrate `ALTER TABLE ... SET/UNSET TBLPROPERTIES` to use `UnresolvedTable` to resolve the table identifier. This

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31420: [SPARK-34312][SQL] Support partition(s) truncation by `Supports(Atomic)PartitionManagement`

2021-02-01 Thread GitBox
AmplabJenkins removed a comment on pull request #31420: URL: https://github.com/apache/spark/pull/31420#issuecomment-770997064 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31378: [SPARK-34240][SQL] Unify output of SHOW TBLPROPERTIES pass output attribute properly

2021-02-01 Thread GitBox
AmplabJenkins removed a comment on pull request #31378: URL: https://github.com/apache/spark/pull/31378#issuecomment-771076553 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39325/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31402: [SPARK-34296][SQL] AggregateWindowFunction frame should not always use UnboundedPreceding

2021-02-01 Thread GitBox
AmplabJenkins removed a comment on pull request #31402: URL: https://github.com/apache/spark/pull/31402#issuecomment-771076554 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39326/

[GitHub] [spark] AmplabJenkins commented on pull request #31378: [SPARK-34240][SQL] Unify output of SHOW TBLPROPERTIES pass output attribute properly

2021-02-01 Thread GitBox
AmplabJenkins commented on pull request #31378: URL: https://github.com/apache/spark/pull/31378#issuecomment-771076553 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39325/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31402: [SPARK-34296][SQL] AggregateWindowFunction frame should not always use UnboundedPreceding

2021-02-01 Thread GitBox
AmplabJenkins commented on pull request #31402: URL: https://github.com/apache/spark/pull/31402#issuecomment-771076554 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39326/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31420: [SPARK-34312][SQL] Support partition(s) truncation by `Supports(Atomic)PartitionManagement`

2021-02-01 Thread GitBox
AmplabJenkins commented on pull request #31420: URL: https://github.com/apache/spark/pull/31420#issuecomment-771076552 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134736/ -

[GitHub] [spark] rxin commented on pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs

2021-02-01 Thread GitBox
rxin commented on pull request #31408: URL: https://github.com/apache/spark/pull/31408#issuecomment-771075815 This makes sense, assuming we don't break backward compatibility. This is an automated message from the Apache Git

[GitHub] [spark] srowen commented on a change in pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs

2021-02-01 Thread GitBox
srowen commented on a change in pull request #31408: URL: https://github.com/apache/spark/pull/31408#discussion_r568056115 ## File path: R/pkg/R/functions.R ## @@ -636,20 +636,33 @@ setMethod("bin", }) #' @details -#' \code{bitwiseNOT}: Computes bitwise NOT. +#' \

[GitHub] [spark] SparkQA commented on pull request #31284: [SPARK-34167][SQL]Reading parquet with IntDecimal written as a LongDecimal blows up

2021-02-01 Thread GitBox
SparkQA commented on pull request #31284: URL: https://github.com/apache/spark/pull/31284#issuecomment-771071318 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39328/ -

[GitHub] [spark] imback82 commented on pull request #31414: [SPARK-34303][SQL] Migrate ALTER TABLE .. SET LOCATION to new resolution framework

2021-02-01 Thread GitBox
imback82 commented on pull request #31414: URL: https://github.com/apache/spark/pull/31414#issuecomment-771065961 Oh, just bringing this up to make sure we create a JIRA first before working on it. I usually create a JIRA after PR is ready, so if you are already following this process, we

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31408: [SPARK-34306][SQL][PYTHON][R] Use Snake naming rule across the function APIs

2021-02-01 Thread GitBox
dongjoon-hyun commented on a change in pull request #31408: URL: https://github.com/apache/spark/pull/31408#discussion_r568043656 ## File path: R/pkg/R/functions.R ## @@ -636,20 +636,33 @@ setMethod("bin", }) #' @details -#' \code{bitwiseNOT}: Computes bitwise NOT

[GitHub] [spark] SparkQA commented on pull request #31378: [SPARK-34240][SQL] Unify output of SHOW TBLPROPERTIES pass output attribute properly

2021-02-01 Thread GitBox
SparkQA commented on pull request #31378: URL: https://github.com/apache/spark/pull/31378#issuecomment-771059685 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39325/ ---

[GitHub] [spark] MaxGekk commented on pull request #31414: [SPARK-34303][SQL] Migrate ALTER TABLE .. SET LOCATION to new resolution framework

2021-02-01 Thread GitBox
MaxGekk commented on pull request #31414: URL: https://github.com/apache/spark/pull/31414#issuecomment-771053011 @imback82 I created https://issues.apache.org/jira/browse/SPARK-34303 as a sub-task of SPARK-29900 yesterday when I worked on https://github.com/apache/spark/pull/31405 . And on

[GitHub] [spark] SparkQA removed a comment on pull request #31420: [SPARK-34312][SQL] Support partition(s) truncation by `Supports(Atomic)PartitionManagement`

2021-02-01 Thread GitBox
SparkQA removed a comment on pull request #31420: URL: https://github.com/apache/spark/pull/31420#issuecomment-770877581 **[Test build #134736 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134736/testReport)** for PR 31420 at commit [`6db21ab`](https://gi

[GitHub] [spark] SparkQA commented on pull request #31420: [SPARK-34312][SQL] Support partition(s) truncation by `Supports(Atomic)PartitionManagement`

2021-02-01 Thread GitBox
SparkQA commented on pull request #31420: URL: https://github.com/apache/spark/pull/31420#issuecomment-771050517 **[Test build #134736 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134736/testReport)** for PR 31420 at commit [`6db21ab`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #31402: [SPARK-34296][SQL] AggregateWindowFunction frame should not always use UnboundedPreceding

2021-02-01 Thread GitBox
SparkQA commented on pull request #31402: URL: https://github.com/apache/spark/pull/31402#issuecomment-771049442 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39326/ ---

[GitHub] [spark] MaxGekk commented on a change in pull request #31421: [SPARK-33591][SQL][FOLLOWUP] Add legacy config for recognizing null partition spec values

2021-02-01 Thread GitBox
MaxGekk commented on a change in pull request #31421: URL: https://github.com/apache/spark/pull/31421#discussion_r568030062 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowPartitionsSuite.scala ## @@ -81,6 +82,18 @@ trait ShowPartitionsSuite

[GitHub] [spark] SparkQA commented on pull request #31421: [SPARK-33591][SQL][FOLLOWUP] Add legacy config for recognizing null partition spec values

2021-02-01 Thread GitBox
SparkQA commented on pull request #31421: URL: https://github.com/apache/spark/pull/31421#issuecomment-771045274 **[Test build #134741 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134741/testReport)** for PR 31421 at commit [`b062f8b`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31407: [SPARK-34233][SQL][3.1] FIX NPE for char padding in binary comparison

2021-02-01 Thread GitBox
AmplabJenkins removed a comment on pull request #31407: URL: https://github.com/apache/spark/pull/31407#issuecomment-771036658 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134734/ -

[GitHub] [spark] SparkQA removed a comment on pull request #31407: [SPARK-34233][SQL][3.1] FIX NPE for char padding in binary comparison

2021-02-01 Thread GitBox
SparkQA removed a comment on pull request #31407: URL: https://github.com/apache/spark/pull/31407#issuecomment-770840122 **[Test build #134734 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134734/testReport)** for PR 31407 at commit [`7893201`](https://gi

[GitHub] [spark] SparkQA commented on pull request #31284: [SPARK-34167][SQL]Reading parquet with IntDecimal written as a LongDecimal blows up

2021-02-01 Thread GitBox
SparkQA commented on pull request #31284: URL: https://github.com/apache/spark/pull/31284#issuecomment-771037753 **[Test build #134742 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134742/testReport)** for PR 31284 at commit [`5c7db35`](https://github.com

[GitHub] [spark] AmplabJenkins commented on pull request #31407: [SPARK-34233][SQL][3.1] FIX NPE for char padding in binary comparison

2021-02-01 Thread GitBox
AmplabJenkins commented on pull request #31407: URL: https://github.com/apache/spark/pull/31407#issuecomment-771036658 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134734/ -

[GitHub] [spark] SparkQA commented on pull request #31407: [SPARK-34233][SQL][3.1] FIX NPE for char padding in binary comparison

2021-02-01 Thread GitBox
SparkQA commented on pull request #31407: URL: https://github.com/apache/spark/pull/31407#issuecomment-771033226 **[Test build #134734 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134734/testReport)** for PR 31407 at commit [`7893201`](https://github.co

[GitHub] [spark] imback82 commented on pull request #31414: [SPARK-34303][SQL] Migrate ALTER TABLE .. SET LOCATION to new resolution framework

2021-02-01 Thread GitBox
imback82 commented on pull request #31414: URL: https://github.com/apache/spark/pull/31414#issuecomment-771031914 Btw, @MaxGekk let's create a subtask under https://issues.apache.org/jira/browse/SPARK-29900 before starting the work so that our work doesn't overlap. Thanks! --

[GitHub] [spark] SparkQA commented on pull request #31402: [SPARK-34296][SQL] AggregateWindowFunction frame should not always use UnboundedPreceding

2021-02-01 Thread GitBox
SparkQA commented on pull request #31402: URL: https://github.com/apache/spark/pull/31402#issuecomment-771030480 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39326/ -

[GitHub] [spark] DavidToneian commented on a change in pull request #31401: [SPARK-34300][PYSPARK][DOCS][MINOR] Fix some typos and syntax issues in docstrings and output of `dev/lint-python`

2021-02-01 Thread GitBox
DavidToneian commented on a change in pull request #31401: URL: https://github.com/apache/spark/pull/31401#discussion_r568012010 ## File path: python/pyspark/sql/avro/functions.py ## @@ -37,7 +37,7 @@ def from_avro(data, jsonFormatSchema, options=None): Parameters -

[GitHub] [spark] razajafri commented on pull request #31284: [SPARK-34167][SQL]Reading parquet with IntDecimal written as a LongDecimal blows up

2021-02-01 Thread GitBox
razajafri commented on pull request #31284: URL: https://github.com/apache/spark/pull/31284#issuecomment-771025263 @tgravescs I have updated the test with comment that you recommeded, PTAL @cloud-fan do you have any other questions? -

[GitHub] [spark] imback82 commented on a change in pull request #31414: [SPARK-34303][SQL] Migrate ALTER TABLE .. SET LOCATION to new resolution framework

2021-02-01 Thread GitBox
imback82 commented on a change in pull request #31414: URL: https://github.com/apache/spark/pull/31414#discussion_r568006395 ## File path: sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala ## @@ -190,19 +190,6 @@ class ResolveSessionCat

[GitHub] [spark] gengliangwang commented on pull request #31421: [SPARK-33591][SQL][FOLLOWUP] Add legacy config for recognizing null partition spec values

2021-02-01 Thread GitBox
gengliangwang commented on pull request #31421: URL: https://github.com/apache/spark/pull/31421#issuecomment-771022906 cc @cloud-fan @HyukjinKwon @MaxGekk This is an automated message from the Apache Git Service. To respond

[GitHub] [spark] gengliangwang opened a new pull request #31421: [SPARK-33591][SQL][FOLLOWUP] Add legacy config for recognizing null partition spec values

2021-02-01 Thread GitBox
gengliangwang opened a new pull request #31421: URL: https://github.com/apache/spark/pull/31421 ### What changes were proposed in this pull request? This is a follow up for https://github.com/apache/spark/pull/30538. It adds a legacy conf `spark.sql.legacy.parseNullPartiti

[GitHub] [spark] cloud-fan commented on a change in pull request #31414: [SPARK-34303][SQL] Migrate ALTER TABLE .. SET LOCATION to new resolution framework

2021-02-01 Thread GitBox
cloud-fan commented on a change in pull request #31414: URL: https://github.com/apache/spark/pull/31414#discussion_r568005544 ## File path: sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala ## @@ -190,19 +190,6 @@ class ResolveSessionCa

[GitHub] [spark] viirya commented on a change in pull request #31413: [SPARK-32985][SQL] Decouple bucket scan and bucket filter pruning for data source v1

2021-02-01 Thread GitBox
viirya commented on a change in pull request #31413: URL: https://github.com/apache/spark/pull/31413#discussion_r568004172 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala ## @@ -591,20 +590,34 @@ case class FileSourceScanExec(

[GitHub] [spark] alefischer13 commented on pull request #26624: [SPARK-8981][CORE][test-hadoop3.2][test-java11] Add MDC support in Executor

2021-02-01 Thread GitBox
alefischer13 commented on pull request #26624: URL: https://github.com/apache/spark/pull/26624#issuecomment-771017526 @igreenfield this does not seem to be working for me. I'm trying to log spark application_id by setting `mdc.applicationId` to sparkContext's applicationId and adding `%X{a

[GitHub] [spark] imback82 commented on a change in pull request #31414: [SPARK-34303][SQL] Migrate ALTER TABLE .. SET LOCATION to new resolution framework

2021-02-01 Thread GitBox
imback82 commented on a change in pull request #31414: URL: https://github.com/apache/spark/pull/31414#discussion_r567996642 ## File path: sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala ## @@ -190,19 +190,6 @@ class ResolveSessionCat

[GitHub] [spark] SparkQA commented on pull request #31402: [SPARK-34296][SQL] AggregateWindowFunction frame should not always use UnboundedPreceding

2021-02-01 Thread GitBox
SparkQA commented on pull request #31402: URL: https://github.com/apache/spark/pull/31402#issuecomment-771008925 **[Test build #134740 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134740/testReport)** for PR 31402 at commit [`84ed1b5`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #31378: [SPARK-34240][SQL] Unify output of SHOW TBLPROPERTIES pass output attribute properly

2021-02-01 Thread GitBox
SparkQA commented on pull request #31378: URL: https://github.com/apache/spark/pull/31378#issuecomment-770997602 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39325/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31405: [SPARK-34304][SQL] Remove view checks in v1 alter table commands

2021-02-01 Thread GitBox
AmplabJenkins commented on pull request #31405: URL: https://github.com/apache/spark/pull/31405#issuecomment-770997060 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39323/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31420: [SPARK-34312][SQL] Support partition(s) truncation by `Supports(Atomic)PartitionManagement`

2021-02-01 Thread GitBox
AmplabJenkins commented on pull request #31420: URL: https://github.com/apache/spark/pull/31420#issuecomment-770997064 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39322/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31286: [SPARK-34199][SQL] Block `table.*` inside function to follow ANSI standard and other SQL engines

2021-02-01 Thread GitBox
AmplabJenkins commented on pull request #31286: URL: https://github.com/apache/spark/pull/31286#issuecomment-770997063 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39324/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31419: [SPARK-34311][SQL] PostgresDialect can't treat arrays of some types

2021-02-01 Thread GitBox
AmplabJenkins commented on pull request #31419: URL: https://github.com/apache/spark/pull/31419#issuecomment-770997062 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134735/ -

[GitHub] [spark] SparkQA removed a comment on pull request #31419: [SPARK-34311][SQL] PostgresDialect can't treat arrays of some types

2021-02-01 Thread GitBox
SparkQA removed a comment on pull request #31419: URL: https://github.com/apache/spark/pull/31419#issuecomment-770880340 **[Test build #134735 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134735/testReport)** for PR 31419 at commit [`b0c3ba4`](https://gi

[GitHub] [spark] SparkQA commented on pull request #31419: [SPARK-34311][SQL] PostgresDialect can't treat arrays of some types

2021-02-01 Thread GitBox
SparkQA commented on pull request #31419: URL: https://github.com/apache/spark/pull/31419#issuecomment-770987388 **[Test build #134735 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134735/testReport)** for PR 31419 at commit [`b0c3ba4`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #31405: [SPARK-34304][SQL] Remove view checks in v1 alter table commands

2021-02-01 Thread GitBox
SparkQA commented on pull request #31405: URL: https://github.com/apache/spark/pull/31405#issuecomment-770970519 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39323/ ---

[GitHub] [spark] SparkQA commented on pull request #31420: [SPARK-34312][SQL] Support partition(s) truncation by `Supports(Atomic)PartitionManagement`

2021-02-01 Thread GitBox
SparkQA commented on pull request #31420: URL: https://github.com/apache/spark/pull/31420#issuecomment-770966330 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39322/ ---

[GitHub] [spark] SparkQA commented on pull request #31378: [SPARK-34240][SQL] Unify output of SHOW TBLPROPERTIES pass output attribute properly

2021-02-01 Thread GitBox
SparkQA commented on pull request #31378: URL: https://github.com/apache/spark/pull/31378#issuecomment-770965994 **[Test build #134739 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134739/testReport)** for PR 31378 at commit [`e229662`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #31286: [SPARK-34199][SQL] Block `table.*` inside function to follow ANSI standard and other SQL engines

2021-02-01 Thread GitBox
SparkQA commented on pull request #31286: URL: https://github.com/apache/spark/pull/31286#issuecomment-770964101 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39324/ ---

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31407: [SPARK-34233][SQL][3.1] FIX NPE for char padding in binary comparison

2021-02-01 Thread GitBox
AmplabJenkins removed a comment on pull request #31407: URL: https://github.com/apache/spark/pull/31407#issuecomment-770955459 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39320/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31419: [SPARK-34311][SQL] PostgresDialect can't treat arrays of some types

2021-02-01 Thread GitBox
AmplabJenkins removed a comment on pull request #31419: URL: https://github.com/apache/spark/pull/31419#issuecomment-770955458 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39321/

[GitHub] [spark] AmplabJenkins commented on pull request #31419: [SPARK-34311][SQL] PostgresDialect can't treat arrays of some types

2021-02-01 Thread GitBox
AmplabJenkins commented on pull request #31419: URL: https://github.com/apache/spark/pull/31419#issuecomment-770955458 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39321/ -

[GitHub] [spark] AmplabJenkins commented on pull request #31407: [SPARK-34233][SQL][3.1] FIX NPE for char padding in binary comparison

2021-02-01 Thread GitBox
AmplabJenkins commented on pull request #31407: URL: https://github.com/apache/spark/pull/31407#issuecomment-770955459 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39320/ -

[GitHub] [spark] SparkQA commented on pull request #31405: [SPARK-34304][SQL] Remove view checks in v1 alter table commands

2021-02-01 Thread GitBox
SparkQA commented on pull request #31405: URL: https://github.com/apache/spark/pull/31405#issuecomment-770949428 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39323/ -

[GitHub] [spark] SparkQA commented on pull request #31420: [SPARK-34312][SQL] Support partition(s) truncation by `Supports(Atomic)PartitionManagement`

2021-02-01 Thread GitBox
SparkQA commented on pull request #31420: URL: https://github.com/apache/spark/pull/31420#issuecomment-770948779 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39322/ -

[GitHub] [spark] SparkQA commented on pull request #31286: [SPARK-34199][SQL] Block `table.*` inside function to follow ANSI standard and other SQL engines

2021-02-01 Thread GitBox
SparkQA commented on pull request #31286: URL: https://github.com/apache/spark/pull/31286#issuecomment-770944839 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39324/ -

[GitHub] [spark] SparkQA commented on pull request #31419: [SPARK-34311][SQL] PostgresDialect can't treat arrays of some types

2021-02-01 Thread GitBox
SparkQA commented on pull request #31419: URL: https://github.com/apache/spark/pull/31419#issuecomment-770935633 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39321/ ---

[GitHub] [spark] SparkQA commented on pull request #31407: [SPARK-34233][SQL][3.1] FIX NPE for char padding in binary comparison

2021-02-01 Thread GitBox
SparkQA commented on pull request #31407: URL: https://github.com/apache/spark/pull/31407#issuecomment-770933523 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39320/ ---

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #31378: [SPARK-34240][SQL] Unify output of SHOW TBLPROPERTIES pass output attribute properly

2021-02-01 Thread GitBox
AngersZh commented on a change in pull request #31378: URL: https://github.com/apache/spark/pull/31378#discussion_r567903240 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala ## @@ -129,7 +129,7 @@ class HiveCommandSuite exten

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #31378: [SPARK-34240][SQL] Unify output of SHOW TBLPROPERTIES pass output attribute properly

2021-02-01 Thread GitBox
AngersZh commented on a change in pull request #31378: URL: https://github.com/apache/spark/pull/31378#discussion_r567901541 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala ## @@ -129,7 +129,7 @@ class HiveCommandSuite exten

[GitHub] [spark] tgravescs commented on pull request #30650: [SPARK-24818][CORE] Support delay scheduling for barrier execution

2021-02-01 Thread GitBox
tgravescs commented on pull request #30650: URL: https://github.com/apache/spark/pull/30650#issuecomment-770930298 > After times thinking, I think we should just keep the original behavior for the barrier taskset with the legacy delay scheduling. That means we should still abort the taskse

[GitHub] [spark] MaxGekk commented on a change in pull request #31387: [SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests

2021-02-01 Thread GitBox
MaxGekk commented on a change in pull request #31387: URL: https://github.com/apache/spark/pull/31387#discussion_r567900934 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/v2/TruncateTableSuite.scala ## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apac

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #31378: [SPARK-34240][SQL] Unify output of SHOW TBLPROPERTIES pass output attribute properly

2021-02-01 Thread GitBox
AngersZh commented on a change in pull request #31378: URL: https://github.com/apache/spark/pull/31378#discussion_r567899325 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala ## @@ -129,7 +129,7 @@ class HiveCommandSuite exten

[GitHub] [spark] cloud-fan commented on a change in pull request #31387: [SPARK-34282][SQL][TESTS] Unify v1 and v2 TRUNCATE TABLE tests

2021-02-01 Thread GitBox
cloud-fan commented on a change in pull request #31387: URL: https://github.com/apache/spark/pull/31387#discussion_r567898359 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/v2/TruncateTableSuite.scala ## @@ -0,0 +1,45 @@ +/* + * Licensed to the Ap

[GitHub] [spark] linhongliu-db commented on pull request #30363: [SPARK-33438][SQL] Eagerly init all SQLConf objects for command `set -v`

2021-02-01 Thread GitBox
linhongliu-db commented on pull request #30363: URL: https://github.com/apache/spark/pull/30363#issuecomment-770925696 @srowen, Thanks for reviewing. I think this PR is a kind of bug fix since the `set -v` doesn't output expected results in some cases. Also, even though it would work lat

[GitHub] [spark] SparkQA commented on pull request #31286: [SPARK-34199][SQL] Block `table.*` inside function to follow ANSI standard and other SQL engines

2021-02-01 Thread GitBox
SparkQA commented on pull request #31286: URL: https://github.com/apache/spark/pull/31286#issuecomment-770925348 **[Test build #134738 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134738/testReport)** for PR 31286 at commit [`882ac3d`](https://github.com

[GitHub] [spark] cloud-fan commented on a change in pull request #31378: [SPARK-34240][SQL] Unify output of SHOW TBLPROPERTIES pass output attribute properly

2021-02-01 Thread GitBox
cloud-fan commented on a change in pull request #31378: URL: https://github.com/apache/spark/pull/31378#discussion_r567894564 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala ## @@ -129,7 +129,7 @@ class HiveCommandSuite extends

[GitHub] [spark] SparkQA commented on pull request #31405: [SPARK-34304][SQL] Remove view checks in v1 alter table commands

2021-02-01 Thread GitBox
SparkQA commented on pull request #31405: URL: https://github.com/apache/spark/pull/31405#issuecomment-770923341 **[Test build #134737 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134737/testReport)** for PR 31405 at commit [`0dedf33`](https://github.com

[GitHub] [spark] cloud-fan commented on a change in pull request #30363: [SPARK-33438][SQL] Eagerly init all SQLConf objects for command `set -v`

2021-02-01 Thread GitBox
cloud-fan commented on a change in pull request #30363: URL: https://github.com/apache/spark/pull/30363#discussion_r567893851 ## File path: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala ## @@ -106,6 +114,16 @@ class SQLConfSuite extends QueryTest wit

[GitHub] [spark] linhongliu-db commented on a change in pull request #30363: [SPARK-33438][SQL] Eagerly init all SQLConf objects for command `set -v`

2021-02-01 Thread GitBox
linhongliu-db commented on a change in pull request #30363: URL: https://github.com/apache/spark/pull/30363#discussion_r567885935 ## File path: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala ## @@ -106,6 +114,16 @@ class SQLConfSuite extends QueryTest

[GitHub] [spark] linhongliu-db commented on a change in pull request #30363: [SPARK-33438][SQL] Eagerly init all SQLConf objects for command `set -v`

2021-02-01 Thread GitBox
linhongliu-db commented on a change in pull request #30363: URL: https://github.com/apache/spark/pull/30363#discussion_r567883709 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -3811,6 +3811,8 @@ class SQLConf extends Serializable w

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31413: [SPARK-32985][SQL] Decouple bucket scan and bucket filter pruning for data source v1

2021-02-01 Thread GitBox
AmplabJenkins removed a comment on pull request #31413: URL: https://github.com/apache/spark/pull/31413#issuecomment-770798933 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134717/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31286: [SPARK-34199][SQL] Block `table.*` inside function to follow ANSI standard and other SQL engines

2021-02-01 Thread GitBox
AmplabJenkins removed a comment on pull request #31286: URL: https://github.com/apache/spark/pull/31286#issuecomment-770798940 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31407: [SPARK-34233][SQL][3.1] FIX NPE for char padding in binary comparison

2021-02-01 Thread GitBox
AmplabJenkins removed a comment on pull request #31407: URL: https://github.com/apache/spark/pull/31407#issuecomment-770912563 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134726/ -

<    1   2   3   4   5   6   7   8   >