[GitHub] [spark] SparkQA commented on pull request #31785: [SPARK-33498][SQL][TESTS][FOLLOWUP] Remove SQLConf.withExistingConf in CastSuite

2021-03-08 Thread GitBox
SparkQA commented on pull request #31785: URL: https://github.com/apache/spark/pull/31785#issuecomment-793509967 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40485/

[GitHub] [spark] c21 commented on pull request #31736: [SPARK-34620][SQL] Code-gen broadcast nested loop join (inner/cross)

2021-03-08 Thread GitBox
c21 commented on pull request #31736: URL: https://github.com/apache/spark/pull/31736#issuecomment-793509585 Close & reopen PR to trigger test rerun as some transient unit test failure happened. This is an automated message

[GitHub] [spark] c21 closed pull request #31736: [SPARK-34620][SQL] Code-gen broadcast nested loop join (inner/cross)

2021-03-08 Thread GitBox
c21 closed pull request #31736: URL: https://github.com/apache/spark/pull/31736 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] SparkQA commented on pull request #31735: [WIP][SPARK-34600][Pyspark][SQL] Return User-defined types from Pandas UDF

2021-03-08 Thread GitBox
SparkQA commented on pull request #31735: URL: https://github.com/apache/spark/pull/31735#issuecomment-793508584 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40480/

[GitHub] [spark] SparkQA commented on pull request #31758: [SPARK-34639][SQL] Always remove unnecessary Alias in Analyzer.resolveExpression

2021-03-08 Thread GitBox
SparkQA commented on pull request #31758: URL: https://github.com/apache/spark/pull/31758#issuecomment-793507832 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40479/

[GitHub] [spark] SparkQA commented on pull request #31783: [SPARK-34152][SQL][FOLLOW-UP] Global temp view's identifier should be correctly stored

2021-03-08 Thread GitBox
SparkQA commented on pull request #31783: URL: https://github.com/apache/spark/pull/31783#issuecomment-793506545 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40482/

[GitHub] [spark] dongjoon-hyun commented on pull request #31785: [SPARK-33498][SQL][TESTS][FOLLOWUP] Remove SQLConf.withExistingConf in CastSuite

2021-03-08 Thread GitBox
dongjoon-hyun commented on pull request #31785: URL: https://github.com/apache/spark/pull/31785#issuecomment-793505377 Oh, BTW, @maropu . I realized that this is a follow-up of old SPARK-33498 who fixed version is 3.1.0. It looks a little weird because this goes only to 3.2.0 and 3.1.2.

[GitHub] [spark] dongjoon-hyun commented on pull request #31785: [SPARK-33498][SQL][TESTS][FOLLOWUP] Remove SQLConf.withExistingConf in CastSuite

2021-03-08 Thread GitBox
dongjoon-hyun commented on pull request #31785: URL: https://github.com/apache/spark/pull/31785#issuecomment-793504046 There is a conflict on branch-3.1. Could you make a backporting PR? This is an automated message from the

[GitHub] [spark] dongjoon-hyun closed pull request #31785: [SPARK-33498][SQL][TESTS][FOLLOWUP] Remove SQLConf.withExistingConf in CastSuite

2021-03-08 Thread GitBox
dongjoon-hyun closed pull request #31785: URL: https://github.com/apache/spark/pull/31785 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] cloud-fan commented on a change in pull request #31783: [SPARK-34152][SQL][FOLLOW-UP] Global temp view's identifier should be correctly stored

2021-03-08 Thread GitBox
cloud-fan commented on a change in pull request #31783: URL: https://github.com/apache/spark/pull/31783#discussion_r590039084 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewTestSuite.scala ## @@ -293,22 +295,45 @@ abstract class SQLViewTestSuite

[GitHub] [spark] cloud-fan commented on pull request #31522: [SPARK-34399][SQL] Add commit duration to SQL tab's graph node.

2021-03-08 Thread GitBox
cloud-fan commented on pull request #31522: URL: https://github.com/apache/spark/pull/31522#issuecomment-793499270 How often is that? We can also improve the log to make it easier to search for a certain job. This is an

[GitHub] [spark] SparkQA commented on pull request #31783: [SPARK-34152][SQL][FOLLOW-UP] Global temp view's identifier should be correctly stored

2021-03-08 Thread GitBox
SparkQA commented on pull request #31783: URL: https://github.com/apache/spark/pull/31783#issuecomment-793495385 **[Test build #135900 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135900/testReport)** for PR 31783 at commit

[GitHub] [spark] SparkQA commented on pull request #31721: [SPARK-34603][SQL] Support ADD ARCHIVE and LIST ARCHIVES command

2021-03-08 Thread GitBox
SparkQA commented on pull request #31721: URL: https://github.com/apache/spark/pull/31721#issuecomment-793489191 **[Test build #135902 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135902/testReport)** for PR 31721 at commit

[GitHub] [spark] SparkQA commented on pull request #31769: [SPARK-34649][SQL][DOCS] org.apache.spark.sql.DataFrameNaFunctions.replace() fails for column name having a dot

2021-03-08 Thread GitBox
SparkQA commented on pull request #31769: URL: https://github.com/apache/spark/pull/31769#issuecomment-793489039 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40481/

[GitHub] [spark] AngersZhuuuu commented on pull request #31522: [SPARK-34399][SQL] Add commit duration to SQL tab's graph node.

2021-03-08 Thread GitBox
AngersZh commented on pull request #31522: URL: https://github.com/apache/spark/pull/31522#issuecomment-793484750 In fact, the cluster environment of many companies is not so healthy, and there are often slow nodes that cause the commit and hive metadata load table/partition to be

[GitHub] [spark] sarutak commented on a change in pull request #31754: [SPARK-25769][SPARK-34636][SPARK-34626][SQL] sql method in UnresolvedAttribute, AttributeReference and Alias don't quote qualifie

2021-03-08 Thread GitBox
sarutak commented on a change in pull request #31754: URL: https://github.com/apache/spark/pull/31754#discussion_r590018226 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala ## @@ -141,8 +140,7 @@ case class

[GitHub] [spark] SparkQA commented on pull request #31735: [WIP][SPARK-34600][Pyspark][SQL] Return User-defined types from Pandas UDF

2021-03-08 Thread GitBox
SparkQA commented on pull request #31735: URL: https://github.com/apache/spark/pull/31735#issuecomment-793479185 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40480/

[GitHub] [spark] SparkQA commented on pull request #31758: [SPARK-34639][SQL] Always remove unnecessary Alias in Analyzer.resolveExpression

2021-03-08 Thread GitBox
SparkQA commented on pull request #31758: URL: https://github.com/apache/spark/pull/31758#issuecomment-793478886 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40479/

[GitHub] [spark] SparkQA commented on pull request #31736: [SPARK-34620][SQL] Code-gen broadcast nested loop join (inner/cross)

2021-03-08 Thread GitBox
SparkQA commented on pull request #31736: URL: https://github.com/apache/spark/pull/31736#issuecomment-793476281 **[Test build #135901 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135901/testReport)** for PR 31736 at commit

[GitHub] [spark] imback82 commented on a change in pull request #31783: [SPARK-34152][SQL][FOLLOW-UP] Global temp view's identifier should be correctly stored

2021-03-08 Thread GitBox
imback82 commented on a change in pull request #31783: URL: https://github.com/apache/spark/pull/31783#discussion_r590009335 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewTestSuite.scala ## @@ -293,22 +295,45 @@ abstract class SQLViewTestSuite

[GitHub] [spark] maropu opened a new pull request #31785: [SPARK-33498][SQL][FOLLOWUP] Remove SQLConf.withExistingConf in CastSuite

2021-03-08 Thread GitBox
maropu opened a new pull request #31785: URL: https://github.com/apache/spark/pull/31785 ### What changes were proposed in this pull request? This PR intends to remove unnecessary `SQLConf.withExistingConf` in `CastSuite`; since we've remove `ParVector ` in #31775, we no

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31769: [SPARK-34649][SQL][DOCS] org.apache.spark.sql.DataFrameNaFunctions.replace() fails for column name having a dot

2021-03-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31769: URL: https://github.com/apache/spark/pull/31769#issuecomment-793474381 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31758: [SPARK-34639][SQL] Always remove unnecessary Alias in Analyzer.resolveExpression

2021-03-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31758: URL: https://github.com/apache/spark/pull/31758#issuecomment-793474383 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135897/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31204: [SPARK-26399][WEBUI][CORE] Add new stage-level REST APIs and parameters

2021-03-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31204: URL: https://github.com/apache/spark/pull/31204#issuecomment-793474386 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135893/

[GitHub] [spark] AmplabJenkins commented on pull request #31758: [SPARK-34639][SQL] Always remove unnecessary Alias in Analyzer.resolveExpression

2021-03-08 Thread GitBox
AmplabJenkins commented on pull request #31758: URL: https://github.com/apache/spark/pull/31758#issuecomment-793474383 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135897/

[GitHub] [spark] AmplabJenkins commented on pull request #31204: [SPARK-26399][WEBUI][CORE] Add new stage-level REST APIs and parameters

2021-03-08 Thread GitBox
AmplabJenkins commented on pull request #31204: URL: https://github.com/apache/spark/pull/31204#issuecomment-793474386 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135893/

[GitHub] [spark] AmplabJenkins commented on pull request #31769: [SPARK-34649][SQL][DOCS] org.apache.spark.sql.DataFrameNaFunctions.replace() fails for column name having a dot

2021-03-08 Thread GitBox
AmplabJenkins commented on pull request #31769: URL: https://github.com/apache/spark/pull/31769#issuecomment-793474382 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] cloud-fan commented on pull request #31522: [SPARK-34399][SQL] Add commit duration to SQL tab's graph node.

2021-03-08 Thread GitBox
cloud-fan commented on pull request #31522: URL: https://github.com/apache/spark/pull/31522#issuecomment-793469062 After a second look, I think it's rare that job committing takes a lot of time. If it happens, we can look at the logs to see the commit duration (as well as the hive LOAD

[GitHub] [spark] SparkQA commented on pull request #31769: [SPARK-34649][SQL][DOCS] org.apache.spark.sql.DataFrameNaFunctions.replace() fails for column name having a dot

2021-03-08 Thread GitBox
SparkQA commented on pull request #31769: URL: https://github.com/apache/spark/pull/31769#issuecomment-793467166 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40478/

[GitHub] [spark] SparkQA removed a comment on pull request #31204: [SPARK-26399][WEBUI][CORE] Add new stage-level REST APIs and parameters

2021-03-08 Thread GitBox
SparkQA removed a comment on pull request #31204: URL: https://github.com/apache/spark/pull/31204#issuecomment-793384593 **[Test build #135893 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135893/testReport)** for PR 31204 at commit

[GitHub] [spark] SparkQA commented on pull request #31204: [SPARK-26399][WEBUI][CORE] Add new stage-level REST APIs and parameters

2021-03-08 Thread GitBox
SparkQA commented on pull request #31204: URL: https://github.com/apache/spark/pull/31204#issuecomment-793467097 **[Test build #135893 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135893/testReport)** for PR 31204 at commit

[GitHub] [spark] Ngone51 commented on a change in pull request #31763: [SPARK-33114][CORE] Add metadata in MapStatus to support custom shuffle manager

2021-03-08 Thread GitBox
Ngone51 commented on a change in pull request #31763: URL: https://github.com/apache/spark/pull/31763#discussion_r589993348 ## File path: core/src/main/scala/org/apache/spark/scheduler/MapStatus.scala ## @@ -52,6 +52,13 @@ private[spark] sealed trait MapStatus { *

[GitHub] [spark] cloud-fan closed pull request #31779: [SPARK-34663][SQL][TESTS] Test year-month and day-time intervals in UDF

2021-03-08 Thread GitBox
cloud-fan closed pull request #31779: URL: https://github.com/apache/spark/pull/31779 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] cloud-fan commented on pull request #31779: [SPARK-34663][SQL][TESTS] Test year-month and day-time intervals in UDF

2021-03-08 Thread GitBox
cloud-fan commented on pull request #31779: URL: https://github.com/apache/spark/pull/31779#issuecomment-793466305 thanks, merging to master! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] SparkQA commented on pull request #31769: [SPARK-34649][SQL][DOCS] org.apache.spark.sql.DataFrameNaFunctions.replace() fails for column name having a dot

2021-03-08 Thread GitBox
SparkQA commented on pull request #31769: URL: https://github.com/apache/spark/pull/31769#issuecomment-793465124 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40478/

[GitHub] [spark] yaooqinn commented on pull request #31782: [SPARK-34666][SQL][TESTS] Test DayTimeIntervalType and YearMonthIntervalType as ordered and atomic types

2021-03-08 Thread GitBox
yaooqinn commented on pull request #31782: URL: https://github.com/apache/spark/pull/31782#issuecomment-793464997 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] dongjoon-hyun commented on pull request #31774: [SPARK-34659] Fix that Web UI always correctly get appId

2021-03-08 Thread GitBox
dongjoon-hyun commented on pull request #31774: URL: https://github.com/apache/spark/pull/31774#issuecomment-793459875 Thank you for making a PR, @ornew . cc @gengliangwang This is an automated message from the

[GitHub] [spark] cloud-fan commented on pull request #31782: [SPARK-34666][SQL][TESTS] Test DayTimeIntervalType and YearMonthIntervalType as ordered and atomic types

2021-03-08 Thread GitBox
cloud-fan commented on pull request #31782: URL: https://github.com/apache/spark/pull/31782#issuecomment-793459044 thanks, merging to master! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] cloud-fan closed pull request #31782: [SPARK-34666][SQL][TESTS] Test DayTimeIntervalType and YearMonthIntervalType as ordered and atomic types

2021-03-08 Thread GitBox
cloud-fan closed pull request #31782: URL: https://github.com/apache/spark/pull/31782 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] dongjoon-hyun commented on pull request #31784: [SPARK-34670][BUILD] Upgrade ZSTD-JNI to 1.4.9-1

2021-03-08 Thread GitBox
dongjoon-hyun commented on pull request #31784: URL: https://github.com/apache/spark/pull/31784#issuecomment-793458106 Merged to master. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] dongjoon-hyun closed pull request #31784: [SPARK-34670][BUILD] Upgrade ZSTD-JNI to 1.4.9-1

2021-03-08 Thread GitBox
dongjoon-hyun closed pull request #31784: URL: https://github.com/apache/spark/pull/31784 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] sarutak commented on a change in pull request #31721: [SPARK-34603][SQL] Support ADD ARCHIVE and LIST ARCHIVES command

2021-03-08 Thread GitBox
sarutak commented on a change in pull request #31721: URL: https://github.com/apache/spark/pull/31721#discussion_r589978096 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala ## @@ -857,6 +857,47 @@ class HiveQuerySuite extends

[GitHub] [spark] sarutak commented on a change in pull request #31721: [SPARK-34603][SQL] Support ADD ARCHIVE and LIST ARCHIVES command

2021-03-08 Thread GitBox
sarutak commented on a change in pull request #31721: URL: https://github.com/apache/spark/pull/31721#discussion_r589978011 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala ## @@ -857,6 +857,47 @@ class HiveQuerySuite extends

[GitHub] [spark] c21 commented on pull request #31736: [SPARK-34620][SQL] Code-gen broadcast nested loop join (inner/cross)

2021-03-08 Thread GitBox
c21 commented on pull request #31736: URL: https://github.com/apache/spark/pull/31736#issuecomment-793454012 Addressed all comments for now, and the PR is ready for check again, thanks. This is an automated message from the

[GitHub] [spark] c21 commented on a change in pull request #31736: [SPARK-34620][SQL] Code-gen broadcast nested loop join (inner/cross)

2021-03-08 Thread GitBox
c21 commented on a change in pull request #31736: URL: https://github.com/apache/spark/pull/31736#discussion_r589976077 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/JoinCodegenSupport.scala ## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache

[GitHub] [spark] amandeep-sharma commented on a change in pull request #31769: [SPARK-34649][SQL][DOCS] org.apache.spark.sql.DataFrameNaFunctions.replace() fails for column name having a dot

2021-03-08 Thread GitBox
amandeep-sharma commented on a change in pull request #31769: URL: https://github.com/apache/spark/pull/31769#discussion_r589975656 ## File path: docs/sql-migration-guide.md ## @@ -66,6 +66,8 @@ license: | - In Spark 3.2, the output schema of `SHOW TBLPROPERTIES` becomes

[GitHub] [spark] SparkQA commented on pull request #31769: [SPARK-34649][SQL][DOCS] org.apache.spark.sql.DataFrameNaFunctions.replace() fails for column name having a dot

2021-03-08 Thread GitBox
SparkQA commented on pull request #31769: URL: https://github.com/apache/spark/pull/31769#issuecomment-793452495 **[Test build #135898 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135898/testReport)** for PR 31769 at commit

[GitHub] [spark] cloud-fan commented on pull request #31769: [SPARK-34649][SQL][DOCS] org.apache.spark.sql.DataFrameNaFunctions.replace() fails for column name having a dot

2021-03-08 Thread GitBox
cloud-fan commented on pull request #31769: URL: https://github.com/apache/spark/pull/31769#issuecomment-793451199 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] dongjoon-hyun commented on pull request #31784: [SPARK-34670][BUILD] Upgrade ZSTD-JNI to 1.4.9-1

2021-03-08 Thread GitBox
dongjoon-hyun commented on pull request #31784: URL: https://github.com/apache/spark/pull/31784#issuecomment-793447703 Thank you, @HyukjinKwon ! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31749: [SPARK-34627][SQL] Use FunctionIdentifier in UnresolvedTableValuedFunction

2021-03-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31749: URL: https://github.com/apache/spark/pull/31749#issuecomment-793445250 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135886/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31735: [WIP][SPARK-34600][Pyspark][SQL] Return User-defined types from Pandas UDF

2021-03-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31735: URL: https://github.com/apache/spark/pull/31735#issuecomment-793445252 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135895/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31204: [SPARK-26399][WEBUI][CORE] Add new stage-level REST APIs and parameters

2021-03-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31204: URL: https://github.com/apache/spark/pull/31204#issuecomment-793445253 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40476/

[GitHub] [spark] AmplabJenkins commented on pull request #31749: [SPARK-34627][SQL] Use FunctionIdentifier in UnresolvedTableValuedFunction

2021-03-08 Thread GitBox
AmplabJenkins commented on pull request #31749: URL: https://github.com/apache/spark/pull/31749#issuecomment-793445250 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135886/

[GitHub] [spark] AmplabJenkins commented on pull request #31735: [WIP][SPARK-34600][Pyspark][SQL] Return User-defined types from Pandas UDF

2021-03-08 Thread GitBox
AmplabJenkins commented on pull request #31735: URL: https://github.com/apache/spark/pull/31735#issuecomment-793445252 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135895/

[GitHub] [spark] AmplabJenkins commented on pull request #31204: [SPARK-26399][WEBUI][CORE] Add new stage-level REST APIs and parameters

2021-03-08 Thread GitBox
AmplabJenkins commented on pull request #31204: URL: https://github.com/apache/spark/pull/31204#issuecomment-793445253 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40476/

[GitHub] [spark] AmplabJenkins commented on pull request #31784: [SPARK-34670][BUILD] Upgrade ZSTD-JNI to 1.4.9-1

2021-03-08 Thread GitBox
AmplabJenkins commented on pull request #31784: URL: https://github.com/apache/spark/pull/31784#issuecomment-793445256 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #31204: [SPARK-26399][WEBUI][CORE] Add new stage-level REST APIs and parameters

2021-03-08 Thread GitBox
SparkQA commented on pull request #31204: URL: https://github.com/apache/spark/pull/31204#issuecomment-793438522 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40476/

[GitHub] [spark] hiboyang commented on a change in pull request #31763: [SPARK-33114][CORE] Add metadata in MapStatus to support custom shuffle manager

2021-03-08 Thread GitBox
hiboyang commented on a change in pull request #31763: URL: https://github.com/apache/spark/pull/31763#discussion_r589964037 ## File path: core/src/main/scala/org/apache/spark/scheduler/MapStatus.scala ## @@ -52,6 +52,13 @@ private[spark] sealed trait MapStatus { *

[GitHub] [spark] viirya commented on pull request #28715: [SPARK-31897][SQL] Enable codegen for GenerateExec

2021-03-08 Thread GitBox
viirya commented on pull request #28715: URL: https://github.com/apache/spark/pull/28715#issuecomment-793435653 BTW, although there is performance benchmark in the PR description, it will not be tracked later. I think it may be good to have a benchmark suite for Generate codegen on/off

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31783: [SPARK-34152][SQL][FOLLOW-UP] Global temp view's identifier should be correctly stored

2021-03-08 Thread GitBox
dongjoon-hyun commented on a change in pull request #31783: URL: https://github.com/apache/spark/pull/31783#discussion_r589960978 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala ## @@ -909,4 +910,21 @@ abstract class SQLViewSuite

[GitHub] [spark] SparkQA removed a comment on pull request #31749: [SPARK-34627][SQL] Use FunctionIdentifier in UnresolvedTableValuedFunction

2021-03-08 Thread GitBox
SparkQA removed a comment on pull request #31749: URL: https://github.com/apache/spark/pull/31749#issuecomment-793206590 **[Test build #135886 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135886/testReport)** for PR 31749 at commit

[GitHub] [spark] MaxGekk commented on pull request #31782: [SPARK-34666][SQL][TESTS] Test DayTimeIntervalType and YearMonthIntervalType as ordered and atomic types

2021-03-08 Thread GitBox
MaxGekk commented on pull request #31782: URL: https://github.com/apache/spark/pull/31782#issuecomment-793428096 @cloud-fan @yaooqinn @HyukjinKwon Could you review this PR, please. This is an automated message from the

[GitHub] [spark] SparkQA commented on pull request #31749: [SPARK-34627][SQL] Use FunctionIdentifier in UnresolvedTableValuedFunction

2021-03-08 Thread GitBox
SparkQA commented on pull request #31749: URL: https://github.com/apache/spark/pull/31749#issuecomment-793427797 **[Test build #135886 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135886/testReport)** for PR 31749 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #31758: [SPARK-34639][SQL] Always remove unnecessary Alias in Analyzer.resolveExpression

2021-03-08 Thread GitBox
cloud-fan commented on a change in pull request #31758: URL: https://github.com/apache/spark/pull/31758#discussion_r589955898 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -1905,11 +1904,13 @@ class Analyzer(override val

[GitHub] [spark] cloud-fan edited a comment on pull request #31771: [SPARK-34652][AVRO] Support SchemaRegistry in from_avro method

2021-03-08 Thread GitBox
cloud-fan edited a comment on pull request #31771: URL: https://github.com/apache/spark/pull/31771#issuecomment-792717942 And are you sure that's the common way to use schema registry? I'm not a streaming expert but AFAIK the key advantage of schema registry is to support schema

[GitHub] [spark] cloud-fan commented on a change in pull request #31736: [SPARK-34620][SQL] Code-gen broadcast nested loop join (inner/cross)

2021-03-08 Thread GitBox
cloud-fan commented on a change in pull request #31736: URL: https://github.com/apache/spark/pull/31736#discussion_r589954425 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/JoinCodegenSupport.scala ## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache

[GitHub] [spark] cloud-fan closed pull request #31749: [SPARK-34627][SQL] Use FunctionIdentifier in UnresolvedTableValuedFunction

2021-03-08 Thread GitBox
cloud-fan closed pull request #31749: URL: https://github.com/apache/spark/pull/31749 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] cloud-fan commented on pull request #31749: [SPARK-34627][SQL] Use FunctionIdentifier in UnresolvedTableValuedFunction

2021-03-08 Thread GitBox
cloud-fan commented on pull request #31749: URL: https://github.com/apache/spark/pull/31749#issuecomment-793420963 thanks, merging to master! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] SparkQA commented on pull request #31204: [SPARK-26399][WEBUI][CORE] Add new stage-level REST APIs and parameters

2021-03-08 Thread GitBox
SparkQA commented on pull request #31204: URL: https://github.com/apache/spark/pull/31204#issuecomment-793416850 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40476/

[GitHub] [spark] cloud-fan commented on a change in pull request #31769: [SPARK-34649][SQL][DOCS] org.apache.spark.sql.DataFrameNaFunctions.replace() fails for column name having a dot

2021-03-08 Thread GitBox
cloud-fan commented on a change in pull request #31769: URL: https://github.com/apache/spark/pull/31769#discussion_r589949658 ## File path: docs/sql-migration-guide.md ## @@ -66,6 +66,8 @@ license: | - In Spark 3.2, the output schema of `SHOW TBLPROPERTIES` becomes `key:

[GitHub] [spark] cloud-fan commented on a change in pull request #31769: [SPARK-34649][SQL][DOCS] org.apache.spark.sql.DataFrameNaFunctions.replace() fails for column name having a dot

2021-03-08 Thread GitBox
cloud-fan commented on a change in pull request #31769: URL: https://github.com/apache/spark/pull/31769#discussion_r589949658 ## File path: docs/sql-migration-guide.md ## @@ -66,6 +66,8 @@ license: | - In Spark 3.2, the output schema of `SHOW TBLPROPERTIES` becomes `key:

[GitHub] [spark] cloud-fan commented on a change in pull request #31783: [SPARK-34152][SQL][FOLLOW-UP] Global temp view's identifier should be correctly stored

2021-03-08 Thread GitBox
cloud-fan commented on a change in pull request #31783: URL: https://github.com/apache/spark/pull/31783#discussion_r589948567 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala ## @@ -909,4 +910,21 @@ abstract class SQLViewSuite extends

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31781: [SPARK-34665][SQL][DOCS] Revise the type coercion section of ANSI Compliance

2021-03-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31781: URL: https://github.com/apache/spark/pull/31781#issuecomment-793408468 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #31781: [SPARK-34665][SQL][DOCS] Revise the type coercion section of ANSI Compliance

2021-03-08 Thread GitBox
AmplabJenkins commented on pull request #31781: URL: https://github.com/apache/spark/pull/31781#issuecomment-793408468 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] cloud-fan commented on pull request #31781: [SPARK-34665][SQL][DOCS] Revise the type coercion section of ANSI Compliance

2021-03-08 Thread GitBox
cloud-fan commented on pull request #31781: URL: https://github.com/apache/spark/pull/31781#issuecomment-793406886 late LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] dongjoon-hyun opened a new pull request #31784: [SPARK-34670][BUILD] Upgrade ZSTD-JNI to 1.4.9-1

2021-03-08 Thread GitBox
dongjoon-hyun opened a new pull request #31784: URL: https://github.com/apache/spark/pull/31784 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ###

[GitHub] [spark] SparkQA commented on pull request #31204: [SPARK-26399][WEBUI][CORE] Add new stage-level REST APIs and parameters

2021-03-08 Thread GitBox
SparkQA commented on pull request #31204: URL: https://github.com/apache/spark/pull/31204#issuecomment-793384593 **[Test build #135893 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135893/testReport)** for PR 31204 at commit

[GitHub] [spark] maropu closed pull request #31781: [SPARK-34665][SQL][DOCS] Revise the type coercion section of ANSI Compliance

2021-03-08 Thread GitBox
maropu closed pull request #31781: URL: https://github.com/apache/spark/pull/31781 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] maropu commented on pull request #31781: [SPARK-34665][SQL][DOCS] Revise the type coercion section of ANSI Compliance

2021-03-08 Thread GitBox
maropu commented on pull request #31781: URL: https://github.com/apache/spark/pull/31781#issuecomment-793360706 Thanks for the update, @gengliangwang ! LGTM and I'll merge this. This is an automated message from the Apache

[GitHub] [spark] imback82 commented on pull request #31783: [SPARK-34152][SQL][FOLLOW-UP] Global temp view's identifier should be correctly stored

2021-03-08 Thread GitBox
imback82 commented on pull request #31783: URL: https://github.com/apache/spark/pull/31783#issuecomment-793343978 cc @cloud-fan TIA! This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31778: [SPARK-34545][SQL][3.0] Fix issues with valueCompare feature of pyrolite

2021-03-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31778: URL: https://github.com/apache/spark/pull/31778#issuecomment-793316732 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135885/

[GitHub] [spark] AmplabJenkins commented on pull request #31778: [SPARK-34545][SQL][3.0] Fix issues with valueCompare feature of pyrolite

2021-03-08 Thread GitBox
AmplabJenkins commented on pull request #31778: URL: https://github.com/apache/spark/pull/31778#issuecomment-793316732 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135885/

[GitHub] [spark] SparkQA removed a comment on pull request #31778: [SPARK-34545][SQL][3.0] Fix issues with valueCompare feature of pyrolite

2021-03-08 Thread GitBox
SparkQA removed a comment on pull request #31778: URL: https://github.com/apache/spark/pull/31778#issuecomment-793209612 **[Test build #135885 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135885/testReport)** for PR 31778 at commit

[GitHub] [spark] SparkQA commented on pull request #31778: [SPARK-34545][SQL][3.0] Fix issues with valueCompare feature of pyrolite

2021-03-08 Thread GitBox
SparkQA commented on pull request #31778: URL: https://github.com/apache/spark/pull/31778#issuecomment-793315043 **[Test build #135885 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135885/testReport)** for PR 31778 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31782: [SPARK-34666][SQL][TESTS] Test DayTimeIntervalType and YearMonthIntervalType as ordered and atomic types

2021-03-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31782: URL: https://github.com/apache/spark/pull/31782#issuecomment-793313342 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135883/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31693: [SPARK-34448][ML] Binary logistic regression incorrectly computes the intercept and coefficients with small var features

2021-03-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31693: URL: https://github.com/apache/spark/pull/31693#issuecomment-793313120 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40471/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31769: [SPARK-34649][SQL][DOCS] org.apache.spark.sql.DataFrameNaFunctions.replace() fails for column name having a dot

2021-03-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31769: URL: https://github.com/apache/spark/pull/31769#issuecomment-793313121 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40474/

[GitHub] [spark] AmplabJenkins commented on pull request #31782: [SPARK-34666][SQL][TESTS] Test DayTimeIntervalType and YearMonthIntervalType as ordered and atomic types

2021-03-08 Thread GitBox
AmplabJenkins commented on pull request #31782: URL: https://github.com/apache/spark/pull/31782#issuecomment-793313342 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135883/

[GitHub] [spark] AmplabJenkins commented on pull request #31783: [SPARK-34152][SQL][FOLLOW-UP] Global temp view's identifier should be correctly stored

2021-03-08 Thread GitBox
AmplabJenkins commented on pull request #31783: URL: https://github.com/apache/spark/pull/31783#issuecomment-793313125 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40473/

[GitHub] [spark] AmplabJenkins commented on pull request #31693: [SPARK-34448][ML] Binary logistic regression incorrectly computes the intercept and coefficients with small var features

2021-03-08 Thread GitBox
AmplabJenkins commented on pull request #31693: URL: https://github.com/apache/spark/pull/31693#issuecomment-793313120 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40471/

[GitHub] [spark] AmplabJenkins commented on pull request #31769: [SPARK-34649][SQL][DOCS] org.apache.spark.sql.DataFrameNaFunctions.replace() fails for column name having a dot

2021-03-08 Thread GitBox
AmplabJenkins commented on pull request #31769: URL: https://github.com/apache/spark/pull/31769#issuecomment-793313121 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40474/

[GitHub] [spark] SparkQA removed a comment on pull request #31782: [SPARK-34666][SQL][TESTS] Test DayTimeIntervalType and YearMonthIntervalType as ordered and atomic types

2021-03-08 Thread GitBox
SparkQA removed a comment on pull request #31782: URL: https://github.com/apache/spark/pull/31782#issuecomment-793141449 **[Test build #135883 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135883/testReport)** for PR 31782 at commit

[GitHub] [spark] SparkQA commented on pull request #31782: [SPARK-34666][SQL][TESTS] Test DayTimeIntervalType and YearMonthIntervalType as ordered and atomic types

2021-03-08 Thread GitBox
SparkQA commented on pull request #31782: URL: https://github.com/apache/spark/pull/31782#issuecomment-793312224 **[Test build #135883 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135883/testReport)** for PR 31782 at commit

[GitHub] [spark] SparkQA commented on pull request #31693: [SPARK-34448][ML] Binary logistic regression incorrectly computes the intercept and coefficients with small var features

2021-03-08 Thread GitBox
SparkQA commented on pull request #31693: URL: https://github.com/apache/spark/pull/31693#issuecomment-793295064 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40471/

[GitHub] [spark] Ngone51 commented on a change in pull request #31763: [SPARK-33114][CORE] Add metadata in MapStatus to support custom shuffle manager

2021-03-08 Thread GitBox
Ngone51 commented on a change in pull request #31763: URL: https://github.com/apache/spark/pull/31763#discussion_r589899892 ## File path: core/src/main/scala/org/apache/spark/scheduler/MapStatus.scala ## @@ -52,6 +52,13 @@ private[spark] sealed trait MapStatus { *

[GitHub] [spark] AngersZhuuuu commented on pull request #31598: [SPARK-34478][SQL] When build SparkSession, we should check config keys

2021-03-08 Thread GitBox
AngersZh commented on pull request #31598: URL: https://github.com/apache/spark/pull/31598#issuecomment-793286274 > This might get a little hard to remember to maintain, but pretty OK. @cloud-fan WDYT? After https://github.com/apache/spark/pull/31598#discussion_r586110532, I

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31769: [SPARK-34649][SQL][DOCS] org.apache.spark.sql.DataFrameNaFunctions.replace() fails for column name having a dot

2021-03-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31769: URL: https://github.com/apache/spark/pull/31769#issuecomment-793282868 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135891/

[GitHub] [spark] AmplabJenkins commented on pull request #31769: [SPARK-34649][SQL][DOCS] org.apache.spark.sql.DataFrameNaFunctions.replace() fails for column name having a dot

2021-03-08 Thread GitBox
AmplabJenkins commented on pull request #31769: URL: https://github.com/apache/spark/pull/31769#issuecomment-793282868 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135891/

[GitHub] [spark] AmplabJenkins commented on pull request #31783: [SPARK-34152][SQL][FOLLOW-UP] Global temp view's identifier should be correctly stored

2021-03-08 Thread GitBox
AmplabJenkins commented on pull request #31783: URL: https://github.com/apache/spark/pull/31783#issuecomment-793282804 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135890/

[GitHub] [spark] sunchao commented on a change in pull request #31761: [SPARK-34295][CORE] Exclude filesystems from token renewal

2021-03-08 Thread GitBox
sunchao commented on a change in pull request #31761: URL: https://github.com/apache/spark/pull/31761#discussion_r589882783 ## File path: core/src/main/scala/org/apache/spark/deploy/security/HadoopFSDelegationTokenProvider.scala ## @@ -99,11 +100,24 @@ private[deploy] class

  1   2   3   4   5   6   >