c21 edited a comment on pull request #31892:
URL: https://github.com/apache/spark/pull/31892#issuecomment-802578765
> How about branch-3.0 and branch-2.4? They have this issue, too?
@maropu - Based on my knowledge I don't think so. The shortcut for
`HashJoin` (not calling parent's
c21 commented on pull request #31892:
URL: https://github.com/apache/spark/pull/31892#issuecomment-802578765
> How about branch-3.0 and branch-2.4? They have this issue, too?
Based on my knowledge I don't think so. The shortcut for `HashJoin` (not
calling parent's doConsume()) was
maropu commented on a change in pull request #31892:
URL: https://github.com/apache/spark/pull/31892#discussion_r597423584
##
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##
@@ -4097,6 +4097,25 @@ class SQLQuerySuite extends QueryTest with
AmplabJenkins commented on pull request #31890:
URL: https://github.com/apache/spark/pull/31890#issuecomment-802577270
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For
AmplabJenkins commented on pull request #31892:
URL: https://github.com/apache/spark/pull/31892#issuecomment-802577267
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For
AmplabJenkins commented on pull request #30018:
URL: https://github.com/apache/spark/pull/30018#issuecomment-802577269
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136235/
--
This
cloud-fan commented on a change in pull request #31892:
URL: https://github.com/apache/spark/pull/31892#discussion_r597422339
##
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##
@@ -4097,6 +4097,25 @@ class SQLQuerySuite extends QueryTest with
yaooqinn commented on pull request #31891:
URL: https://github.com/apache/spark/pull/31891#issuecomment-802574469
please fix the format of the PR title, like `[SPARK-34800][SQL] U...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
cloud-fan commented on a change in pull request #31884:
URL: https://github.com/apache/spark/pull/31884#discussion_r597419979
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
##
@@ -579,6 +573,14 @@ case class DataSource(
yaooqinn commented on pull request #31891:
URL: https://github.com/apache/spark/pull/31891#issuecomment-802573590
ok to test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
maropu edited a comment on pull request #31892:
URL: https://github.com/apache/spark/pull/31892#issuecomment-802573189
How about `branch-3.0` and `branch-2.4`? They have this issue, too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
maropu commented on pull request #31892:
URL: https://github.com/apache/spark/pull/31892#issuecomment-802573189
How about `branch-3.0` and `branch-2.4`? They have the issue, too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
maropu commented on a change in pull request #31874:
URL: https://github.com/apache/spark/pull/31874#discussion_r597418024
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastNestedLoopJoinExec.scala
##
@@ -452,4 +457,50 @@ case class
maropu commented on a change in pull request #31874:
URL: https://github.com/apache/spark/pull/31874#discussion_r597418024
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastNestedLoopJoinExec.scala
##
@@ -452,4 +457,50 @@ case class
cloud-fan closed pull request #31881:
URL: https://github.com/apache/spark/pull/31881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
yaooqinn commented on a change in pull request #31884:
URL: https://github.com/apache/spark/pull/31884#discussion_r597418087
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
##
@@ -579,6 +573,14 @@ case class DataSource(
maropu commented on a change in pull request #31874:
URL: https://github.com/apache/spark/pull/31874#discussion_r597418024
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastNestedLoopJoinExec.scala
##
@@ -452,4 +457,50 @@ case class
LuciferYang edited a comment on pull request #31776:
URL: https://github.com/apache/spark/pull/31776#issuecomment-802570617
> I don't really know enough to evaluate this. It looks reasonable and tests
pass. Are there any compatibility concerns, or possible changes to behavior you
can
LuciferYang commented on pull request #31776:
URL: https://github.com/apache/spark/pull/31776#issuecomment-802570617
> I don't really know enough to evaluate this. It looks reasonable and tests
pass. Are there any compatibility concerns, or possible changes to behavior you
can think of?
warrenzhu25 commented on a change in pull request #31869:
URL: https://github.com/apache/spark/pull/31869#discussion_r597417040
##
File path: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala
##
@@ -786,9 +786,13 @@ private[spark] object ApiHelper {
SparkQA commented on pull request #31890:
URL: https://github.com/apache/spark/pull/31890#issuecomment-802569619
Kubernetes integration test status failure
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40816/
--
This is an automated message from the
wangyum commented on pull request #31864:
URL: https://github.com/apache/spark/pull/31864#issuecomment-802569383
Merged to master, branch-3.1 and branch-3.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
MaxGekk commented on a change in pull request #31884:
URL: https://github.com/apache/spark/pull/31884#discussion_r597415662
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
##
@@ -579,6 +573,14 @@ case class DataSource(
cloud-fan commented on pull request #31881:
URL: https://github.com/apache/spark/pull/31881#issuecomment-802566306
the scala 2.13 failure is unrelated, thanks, merging to 3.1/3.0!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #30018:
URL: https://github.com/apache/spark/pull/30018#issuecomment-802561775
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40817/
AmplabJenkins commented on pull request #30018:
URL: https://github.com/apache/spark/pull/30018#issuecomment-802561775
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40817/
--
ulysses-you commented on pull request #31864:
URL: https://github.com/apache/spark/pull/31864#issuecomment-802561610
thanks all !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
AmplabJenkins removed a comment on pull request #31890:
URL: https://github.com/apache/spark/pull/31890#issuecomment-802531728
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
c21 commented on pull request #31892:
URL: https://github.com/apache/spark/pull/31892#issuecomment-802559650
cc @cloud-fan, @maropu and @HyukjinKwon to take a look if you have time,
thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
c21 opened a new pull request #31892:
URL: https://github.com/apache/spark/pull/31892
### What changes were proposed in this pull request?
This PR is to fix the LIMIT code-gen bug in
https://issues.apache.org/jira/browse/SPARK-34796, where the counter variable
from
SparkQA commented on pull request #31890:
URL: https://github.com/apache/spark/pull/31890#issuecomment-802559214
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40816/
--
This is an automated message from the Apache
wangyum closed pull request #31864:
URL: https://github.com/apache/spark/pull/31864
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
wangyum commented on pull request #31864:
URL: https://github.com/apache/spark/pull/31864#issuecomment-802553916
Yes it is. It is better to backport it to branch-3.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
sarutak commented on pull request #31480:
URL: https://github.com/apache/spark/pull/31480#issuecomment-802542418
This GA failure seems to be what is fixed at c5cadfe.
If you rebase to `master`, the failure will go away.
--
This is an automated message from the Apache Git Service.
To
ulysses-you commented on pull request #31864:
URL: https://github.com/apache/spark/pull/31864#issuecomment-802541943
`RebaseDateTime` is created in branch-3.0, so it would be better to backport
3.0.
--
This is an automated message from the Apache Git Service.
To respond to the message,
AmplabJenkins removed a comment on pull request #31890:
URL: https://github.com/apache/spark/pull/31890#issuecomment-802538422
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136234/
AmplabJenkins commented on pull request #31890:
URL: https://github.com/apache/spark/pull/31890#issuecomment-802538422
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136234/
--
This
mridulm commented on a change in pull request #31881:
URL: https://github.com/apache/spark/pull/31881#discussion_r597394971
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/util/QueryExecutionListener.scala
##
@@ -76,7 +76,11 @@ trait QueryExecutionListener {
class
mridulm commented on a change in pull request #31876:
URL: https://github.com/apache/spark/pull/31876#discussion_r597391662
##
File path: core/src/main/scala/org/apache/spark/scheduler/MapStatus.scala
##
@@ -216,7 +223,10 @@ private[spark] class HighlyCompressedMapStatus
AmplabJenkins removed a comment on pull request #31480:
URL: https://github.com/apache/spark/pull/31480#issuecomment-801561161
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136184/
cloud-fan closed pull request #31855:
URL: https://github.com/apache/spark/pull/31855
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
cloud-fan commented on pull request #31855:
URL: https://github.com/apache/spark/pull/31855#issuecomment-802534666
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Ngone51 commented on pull request #31480:
URL: https://github.com/apache/spark/pull/31480#issuecomment-802534480
Yea, I think so. The Jenkins infra is really unhealthy these days.
For the GA failure, the community has just fixed one failure related to
Scala 2.13 at:
cloud-fan commented on a change in pull request #31884:
URL: https://github.com/apache/spark/pull/31884#discussion_r597391929
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
##
@@ -579,6 +573,14 @@ case class DataSource(
cloud-fan commented on a change in pull request #31884:
URL: https://github.com/apache/spark/pull/31884#discussion_r597391806
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
##
@@ -510,10 +510,7 @@ case class DataSource(
cloud-fan commented on pull request #31864:
URL: https://github.com/apache/spark/pull/31864#issuecomment-802533026
LGTM. How far shall we backport this? 3.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
cloud-fan commented on a change in pull request #31874:
URL: https://github.com/apache/spark/pull/31874#discussion_r597390501
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastNestedLoopJoinExec.scala
##
@@ -452,4 +457,50 @@ case class
AmplabJenkins commented on pull request #31890:
URL: https://github.com/apache/spark/pull/31890#issuecomment-802531728
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
AmplabJenkins commented on pull request #31891:
URL: https://github.com/apache/spark/pull/31891#issuecomment-802531710
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
AmplabJenkins removed a comment on pull request #31588:
URL: https://github.com/apache/spark/pull/31588#issuecomment-802531250
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136233/
AmplabJenkins removed a comment on pull request #31877:
URL: https://github.com/apache/spark/pull/31877#issuecomment-802531248
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40811/
AmplabJenkins removed a comment on pull request #31649:
URL: https://github.com/apache/spark/pull/31649#issuecomment-802531249
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136232/
AmplabJenkins commented on pull request #31649:
URL: https://github.com/apache/spark/pull/31649#issuecomment-802531249
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136232/
--
This
AmplabJenkins commented on pull request #31588:
URL: https://github.com/apache/spark/pull/31588#issuecomment-802531250
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136233/
--
This
AmplabJenkins commented on pull request #31877:
URL: https://github.com/apache/spark/pull/31877#issuecomment-802531248
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40811/
--
viirya closed pull request #28715:
URL: https://github.com/apache/spark/pull/28715
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
viirya commented on pull request #28715:
URL: https://github.com/apache/spark/pull/28715#issuecomment-802530100
Oh, the same Scala 2.13 SBT build error. I think it's because this doesn't
sync up with latest master.
It is unrelated so I'm going to merge this to master.
Thanks
wangyum commented on pull request #31890:
URL: https://github.com/apache/spark/pull/31890#issuecomment-802524235
ok to test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
cloud-fan commented on pull request #31886:
URL: https://github.com/apache/spark/pull/31886#issuecomment-802524020
+1 to have this check!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
woyumen4597 opened a new pull request #31891:
URL: https://github.com/apache/spark/pull/31891
### What changes were proposed in this pull request?
Use fine-grained lock in SessionCatalog.tableExists, in order to lock
currentDB variable rather than lock `tableExists` method which will
opensky142857 opened a new pull request #31890:
URL: https://github.com/apache/spark/pull/31890
### What changes were proposed in this pull request?
join condition 'a.attr == 'c.attr check the reference of these 2 objects
which will always returns false. we need to use
RussellSpitzer commented on a change in pull request #31887:
URL: https://github.com/apache/spark/pull/31887#discussion_r597384076
##
File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
##
@@ -3799,23 +3801,26 @@ object functions {
SparkQA commented on pull request #31877:
URL: https://github.com/apache/spark/pull/31877#issuecomment-802520119
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40811/
--
This is an automated message from the
dmsolow commented on pull request #31887:
URL: https://github.com/apache/spark/pull/31887#issuecomment-802518964
@nvander1 test added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
AmplabJenkins removed a comment on pull request #31588:
URL: https://github.com/apache/spark/pull/31588#issuecomment-802511142
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40815/
AmplabJenkins removed a comment on pull request #31649:
URL: https://github.com/apache/spark/pull/31649#issuecomment-802511097
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40814/
AmplabJenkins commented on pull request #31588:
URL: https://github.com/apache/spark/pull/31588#issuecomment-802511142
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40815/
--
Ngone51 commented on a change in pull request #31881:
URL: https://github.com/apache/spark/pull/31881#discussion_r597378055
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/util/QueryExecutionListener.scala
##
@@ -76,7 +76,11 @@ trait QueryExecutionListener {
class
ekoifman commented on pull request #31653:
URL: https://github.com/apache/spark/pull/31653#issuecomment-802510977
I wanted to have a call because there was disconnect about how the patch is
structured. If you now agree that `OptimizeSkewedJoin` does run as part of
query stage preparation
AmplabJenkins commented on pull request #31649:
URL: https://github.com/apache/spark/pull/31649#issuecomment-802511097
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40814/
--
gengliangwang commented on a change in pull request #31859:
URL: https://github.com/apache/spark/pull/31859#discussion_r597377870
##
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnsiTypeCoercionSuite.scala
##
@@ -377,10 +368,26 @@ class
AmplabJenkins removed a comment on pull request #31880:
URL: https://github.com/apache/spark/pull/31880#issuecomment-802254061
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136218/
AmplabJenkins removed a comment on pull request #31864:
URL: https://github.com/apache/spark/pull/31864#issuecomment-802502145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
AmplabJenkins removed a comment on pull request #31877:
URL: https://github.com/apache/spark/pull/31877#issuecomment-801628249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
jsoref commented on pull request #30679:
URL: https://github.com/apache/spark/pull/30679#issuecomment-802508765
@HyukjinKwon: I filed https://issues.apache.org/jira/browse/SPARK-33717...
@srowen is there something I need to do to push this along?
--
This is an automated message
jsoref commented on pull request #30678:
URL: https://github.com/apache/spark/pull/30678#issuecomment-802507534
@srowen / @bersprockets: anything I need to do to push this along?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
kyoty commented on a change in pull request #31882:
URL: https://github.com/apache/spark/pull/31882#discussion_r597375793
##
File path:
core/src/main/scala/org/apache/spark/deploy/history/ApplicationCache.scala
##
@@ -156,18 +156,19 @@ private[history] class ApplicationCache(
SparkQA commented on pull request #31877:
URL: https://github.com/apache/spark/pull/31877#issuecomment-802506643
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40811/
--
This is an automated message from the Apache
HyukjinKwon commented on a change in pull request #31881:
URL: https://github.com/apache/spark/pull/31881#discussion_r597374876
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/util/QueryExecutionListener.scala
##
@@ -76,7 +76,11 @@ trait QueryExecutionListener {
jsoref commented on pull request #30678:
URL: https://github.com/apache/spark/pull/30678#issuecomment-802505156
Thanks bot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
github-actions[bot] commented on pull request #30679:
URL: https://github.com/apache/spark/pull/30679#issuecomment-802504169
We're closing this PR because it hasn't been updated in a while. This isn't
a judgement on the merit of the PR in any way. It's just a way of keeping the
PR queue
github-actions[bot] commented on pull request #30678:
URL: https://github.com/apache/spark/pull/30678#issuecomment-802504176
We're closing this PR because it hasn't been updated in a while. This isn't
a judgement on the merit of the PR in any way. It's just a way of keeping the
PR queue
github-actions[bot] commented on pull request #29994:
URL: https://github.com/apache/spark/pull/29994#issuecomment-802504186
We're closing this PR because it hasn't been updated in a while. This isn't
a judgement on the merit of the PR in any way. It's just a way of keeping the
PR queue
AmplabJenkins commented on pull request #31889:
URL: https://github.com/apache/spark/pull/31889#issuecomment-802502147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For
AmplabJenkins commented on pull request #31864:
URL: https://github.com/apache/spark/pull/31864#issuecomment-802502145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For
AmplabJenkins commented on pull request #31877:
URL: https://github.com/apache/spark/pull/31877#issuecomment-802502144
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136229/
--
This
srowen commented on a change in pull request #31880:
URL: https://github.com/apache/spark/pull/31880#discussion_r597372248
##
File path: dev/change-scala-version.sh
##
@@ -60,14 +60,13 @@ BASEDIR=$(dirname $0)/..
find "$BASEDIR" -name 'pom.xml' -not -path '*target*' -print \
mridulm commented on a change in pull request #31881:
URL: https://github.com/apache/spark/pull/31881#discussion_r597370114
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/util/QueryExecutionListener.scala
##
@@ -76,7 +76,11 @@ trait QueryExecutionListener {
class
sarutak commented on a change in pull request #31880:
URL: https://github.com/apache/spark/pull/31880#discussion_r597369358
##
File path: dev/change-scala-version.sh
##
@@ -60,14 +60,13 @@ BASEDIR=$(dirname $0)/..
find "$BASEDIR" -name 'pom.xml' -not -path '*target*' -print \
dongjoon-hyun commented on pull request #31877:
URL: https://github.com/apache/spark/pull/31877#issuecomment-802493670
Thank you for review and approval, @HyukjinKwon and @attilapiros .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
cloud-fan commented on pull request #31811:
URL: https://github.com/apache/spark/pull/31811#issuecomment-802492163
I'll open PRs for master/3.0/2.4 shortly, thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dongjoon-hyun commented on a change in pull request #31882:
URL: https://github.com/apache/spark/pull/31882#discussion_r597366145
##
File path:
core/src/main/scala/org/apache/spark/deploy/history/ApplicationCache.scala
##
@@ -156,18 +156,19 @@ private[history] class
zhengruifeng commented on pull request #31588:
URL: https://github.com/apache/spark/pull/31588#issuecomment-802468006
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
zhengruifeng commented on pull request #31889:
URL: https://github.com/apache/spark/pull/31889#issuecomment-802465203
friendly ping @srowen @WeichenXu123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
AmplabJenkins removed a comment on pull request #31886:
URL: https://github.com/apache/spark/pull/31886#issuecomment-802424031
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40809/
zhengruifeng edited a comment on pull request #31889:
URL: https://github.com/apache/spark/pull/31889#issuecomment-802462693
I also test using the two new agg in `LogisticRegressionSuite`, and all test
passed except "multinomial logistic regression with intercept with L1
regularization":
zhengruifeng commented on pull request #31889:
URL: https://github.com/apache/spark/pull/31889#issuecomment-802462693
I also test using the two new agg in `LogisticRegressionSuite`, and all test
passed except "multinomial logistic regression with intercept with L1
regularization":
maropu commented on pull request #31598:
URL: https://github.com/apache/spark/pull/31598#issuecomment-802461832
You've already opened a new PR to address the @cloud-fan comment?
https://github.com/apache/spark/pull/31598#discussion_r586155367 The direction
looks reasonable to me, too.
zhengruifeng opened a new pull request #31889:
URL: https://github.com/apache/spark/pull/31889
### What changes were proposed in this pull request?
1, add `BinaryLogisticBlockAggregator` and
`MultinomialLogisticBlockAggregator` and related testsuites;
2, impl `virtual centering`
dongjoon-hyun commented on pull request #31811:
URL: https://github.com/apache/spark/pull/31811#issuecomment-802459156
Thank you, @cloud-fan and all!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
1 - 100 of 445 matches
Mail list logo