[GitHub] [spark] AmplabJenkins commented on pull request #32241: [SPARK-35140][INFRA] Add error message guidelines to PR template

2021-04-19 Thread GitBox
AmplabJenkins commented on pull request #32241: URL: https://github.com/apache/spark/pull/32241#issuecomment-822996305 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137661/ -- This

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #32228: [SPARK-34035][SQL] Refactor ScriptTransformation to remove input parameter and replace it by child.output

2021-04-19 Thread GitBox
AngersZh commented on a change in pull request #32228: URL: https://github.com/apache/spark/pull/32228#discussion_r616365364 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -772,9 +772,6 @@ object ColumnPruning

[GitHub] [spark] cloud-fan commented on a change in pull request #32072: [SPARK-34974][SQL] Improve subquery decorrelation framework

2021-04-19 Thread GitBox
cloud-fan commented on a change in pull request #32072: URL: https://github.com/apache/spark/pull/32072#discussion_r616364848 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/DecorrelateInnerQuery.scala ## @@ -0,0 +1,484 @@ +/* + * Licensed to

[GitHub] [spark] MaxGekk closed pull request #32240: [SPARK-35018][SQL][TESTS] Check transferring of year-month intervals via Hive Thrift server

2021-04-19 Thread GitBox
MaxGekk closed pull request #32240: URL: https://github.com/apache/spark/pull/32240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [spark] MaxGekk commented on pull request #32240: [SPARK-35018][SQL][TESTS] Check transferring of year-month intervals via Hive Thrift server

2021-04-19 Thread GitBox
MaxGekk commented on pull request #32240: URL: https://github.com/apache/spark/pull/32240#issuecomment-822992928 Merging to master. Thank you, @HyukjinKwon @yaooqinn for your review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] maropu commented on a change in pull request #32201: [SPARK-35026][SQL] Support nested CUBE/ROLLUP/GROUPING SETS in GROUPING SETS

2021-04-19 Thread GitBox
maropu commented on a change in pull request #32201: URL: https://github.com/apache/spark/pull/32201#discussion_r616363181 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -1022,6 +1003,38 @@ class AstBuilder extends

[GitHub] [spark] maropu commented on a change in pull request #32243: [WIP][SPARK-XXXXX][SQL][TESTS] Port minimal TPC-DS datagen code from databricks/spark-sql-perf

2021-04-19 Thread GitBox
maropu commented on a change in pull request #32243: URL: https://github.com/apache/spark/pull/32243#discussion_r616362212 ## File path: .github/workflows/build_and_test.yml ## @@ -528,6 +515,24 @@ jobs: uses: actions/setup-java@v1 with: java-version: 8

[GitHub] [spark] cloud-fan commented on a change in pull request #32072: [SPARK-34974][SQL] Improve subquery decorrelation framework

2021-04-19 Thread GitBox
cloud-fan commented on a change in pull request #32072: URL: https://github.com/apache/spark/pull/32072#discussion_r616361074 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/DecorrelateInnerQuery.scala ## @@ -0,0 +1,484 @@ +/* + * Licensed to

[GitHub] [spark] cloud-fan commented on a change in pull request #32072: [SPARK-34974][SQL] Improve subquery decorrelation framework

2021-04-19 Thread GitBox
cloud-fan commented on a change in pull request #32072: URL: https://github.com/apache/spark/pull/32072#discussion_r616360942 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/DecorrelateInnerQuery.scala ## @@ -0,0 +1,484 @@ +/* + * Licensed to

[GitHub] [spark] maropu commented on a change in pull request #32243: [WIP][SPARK-XXXXX][SQL][TESTS] Port minimal TPC-DS datagen code from databricks/spark-sql-perf

2021-04-19 Thread GitBox
maropu commented on a change in pull request #32243: URL: https://github.com/apache/spark/pull/32243#discussion_r616359685 ## File path: sql/core/src/test/resources/tpcds-query-results/v1_4/q1.sql.out ## @@ -3,103 +3,103 @@ -- !query schema struct -- !query output

[GitHub] [spark] SparkQA removed a comment on pull request #32241: [SPARK-35140][INFRA] Add error message guidelines to PR template

2021-04-19 Thread GitBox
SparkQA removed a comment on pull request #32241: URL: https://github.com/apache/spark/pull/32241#issuecomment-822936898 **[Test build #137661 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137661/testReport)** for PR 32241 at commit

[GitHub] [spark] maropu commented on a change in pull request #32243: [WIP][SPARK-XXXXX][SQL][TESTS] Port minimal TPC-DS datagen code from databricks/spark-sql-perf

2021-04-19 Thread GitBox
maropu commented on a change in pull request #32243: URL: https://github.com/apache/spark/pull/32243#discussion_r616359569 ## File path: sql/core/src/test/resources/tpcds-query-results/v1_4/q1.sql.out ## @@ -3,103 +3,103 @@ -- !query schema struct -- !query output

[GitHub] [spark] SparkQA commented on pull request #32241: [SPARK-35140][INFRA] Add error message guidelines to PR template

2021-04-19 Thread GitBox
SparkQA commented on pull request #32241: URL: https://github.com/apache/spark/pull/32241#issuecomment-822989056 **[Test build #137661 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137661/testReport)** for PR 32241 at commit

[GitHub] [spark] kyoty commented on pull request #32190: [SPARK-35087][UI] Some columns in table Aggregated Metrics by Executor of stage-detail page shows incorrectly.

2021-04-19 Thread GitBox
kyoty commented on pull request #32190: URL: https://github.com/apache/spark/pull/32190#issuecomment-822988713 @HyukjinKwon Sorry to bother you , do you have any experience with this build mistake? ```shell Actions jobs for this repository have been disabled by GitHub staff. If you

[GitHub] [spark] yaooqinn commented on pull request #32179: [SPARK-35080][SQL] Only allow a subset of correlated equality predicates when a subquery is aggregated

2021-04-19 Thread GitBox
yaooqinn commented on pull request #32179: URL: https://github.com/apache/spark/pull/32179#issuecomment-822988608 LGTM > During backport, I found that https://issues.apache.org/jira/browse/SPARK-31225 is not in 2.4, which makes the error message a bit confusing. @viirya shall we

[GitHub] [spark] HyukjinKwon closed pull request #32230: [SPARK-35134][BUILD][TESTS] Manually exclude redundant netty jars in SparkBuild.scala to avoid version conflicts in test

2021-04-19 Thread GitBox
HyukjinKwon closed pull request #32230: URL: https://github.com/apache/spark/pull/32230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [spark] HyukjinKwon commented on pull request #32230: [SPARK-35134][BUILD][TESTS] Manually exclude redundant netty jars in SparkBuild.scala to avoid version conflicts in test

2021-04-19 Thread GitBox
HyukjinKwon commented on pull request #32230: URL: https://github.com/apache/spark/pull/32230#issuecomment-822987980 Merged to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] WeichenXu123 commented on pull request #32245: [SPARK-35142][ML] Fix incorrect return type for `rawPredictionUDF` in `OneVsRestModel`

2021-04-19 Thread GitBox
WeichenXu123 commented on pull request #32245: URL: https://github.com/apache/spark/pull/32245#issuecomment-822987901 CC @zhengruifeng -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] harupy commented on a change in pull request #32245: [SPARK-35142][ML] Fix incorrect return type for `rawPredictionUDF` in `OneVsRestModel`

2021-04-19 Thread GitBox
harupy commented on a change in pull request #32245: URL: https://github.com/apache/spark/pull/32245#discussion_r616358286 ## File path: python/pyspark/ml/classification.py ## @@ -3151,7 +3151,7 @@ def func(predictions): predArray.append(x)

[GitHub] [spark] WeichenXu123 commented on a change in pull request #32245: [SPARK-35142][ML] Fix incorrect return type for `rawPredictionUDF` in `OneVsRestModel`

2021-04-19 Thread GitBox
WeichenXu123 commented on a change in pull request #32245: URL: https://github.com/apache/spark/pull/32245#discussion_r616357907 ## File path: python/pyspark/ml/classification.py ## @@ -3151,7 +3151,7 @@ def func(predictions): predArray.append(x)

[GitHub] [spark] harupy commented on a change in pull request #32245: [SPARK-35142][ML] Fix incorrect return type for `rawPredictionUDF` in `OneVsRestModel`

2021-04-19 Thread GitBox
harupy commented on a change in pull request #32245: URL: https://github.com/apache/spark/pull/32245#discussion_r616310831 ## File path: python/pyspark/ml/classification.py ## @@ -3151,7 +3151,7 @@ def func(predictions): predArray.append(x)

[GitHub] [spark] WeichenXu123 commented on a change in pull request #32245: [SPARK-35142][ML] Fix incorrect return type for `rawPredictionUDF` in `OneVsRestModel`

2021-04-19 Thread GitBox
WeichenXu123 commented on a change in pull request #32245: URL: https://github.com/apache/spark/pull/32245#discussion_r616356650 ## File path: python/pyspark/ml/classification.py ## @@ -3151,7 +3151,7 @@ def func(predictions): predArray.append(x)

[GitHub] [spark] WeichenXu123 commented on a change in pull request #32245: [SPARK-35142][ML] Fix incorrect return type for `rawPredictionUDF` in `OneVsRestModel`

2021-04-19 Thread GitBox
WeichenXu123 commented on a change in pull request #32245: URL: https://github.com/apache/spark/pull/32245#discussion_r616356246 ## File path: python/pyspark/ml/classification.py ## @@ -3151,7 +3151,7 @@ def func(predictions): predArray.append(x)

[GitHub] [spark] gengliangwang closed pull request #32157: [SPARK-35052][SQL] Use static bits for AttributeReference and Literal

2021-04-19 Thread GitBox
gengliangwang closed pull request #32157: URL: https://github.com/apache/spark/pull/32157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [spark] gengliangwang commented on pull request #32157: [SPARK-35052][SQL] Use static bits for AttributeReference and Literal

2021-04-19 Thread GitBox
gengliangwang commented on pull request #32157: URL: https://github.com/apache/spark/pull/32157#issuecomment-822978272 Thanks, merging to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] karenfeng commented on pull request #32241: [SPARK-35140][INFRA] Add error message guidelines to PR template

2021-04-19 Thread GitBox
karenfeng commented on pull request #32241: URL: https://github.com/apache/spark/pull/32241#issuecomment-822977210 Thanks for the feedback @dongjoon-hyun! I addressed your comments; will keep them in mind next time. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [spark] cloud-fan commented on a change in pull request #32229: [SPARK-34837][SQL] Support ANSI SQL intervals by the aggregate function `avg`

2021-04-19 Thread GitBox
cloud-fan commented on a change in pull request #32229: URL: https://github.com/apache/spark/pull/32229#discussion_r616347027 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Average.scala ## @@ -82,6 +87,8 @@ case class

[GitHub] [spark] sarutak edited a comment on pull request #31569: [SPARK-34443][CORE] Replace symbol literals with Symbol constructor invocations to comply with Scala 2.13

2021-04-19 Thread GitBox
sarutak edited a comment on pull request #31569: URL: https://github.com/apache/spark/pull/31569#issuecomment-822972918 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32072: [SPARK-34974][SQL] Improve subquery decorrelation framework

2021-04-19 Thread GitBox
AmplabJenkins removed a comment on pull request #32072: URL: https://github.com/apache/spark/pull/32072#issuecomment-822976062 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42195/

[GitHub] [spark] AmplabJenkins commented on pull request #32072: [SPARK-34974][SQL] Improve subquery decorrelation framework

2021-04-19 Thread GitBox
AmplabJenkins commented on pull request #32072: URL: https://github.com/apache/spark/pull/32072#issuecomment-822976062 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42195/ --

[GitHub] [spark] SparkQA commented on pull request #32072: [SPARK-34974][SQL] Improve subquery decorrelation framework

2021-04-19 Thread GitBox
SparkQA commented on pull request #32072: URL: https://github.com/apache/spark/pull/32072#issuecomment-822976052 Kubernetes integration test unable to build dist. exiting with code: 1 URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42195/ --

[GitHub] [spark] rxin edited a comment on pull request #31569: [SPARK-34443][CORE] Replace symbol literals with Symbol constructor invocations to comply with Scala 2.13

2021-04-19 Thread GitBox
rxin edited a comment on pull request #31569: URL: https://github.com/apache/spark/pull/31569#issuecomment-822969944 With all due respect, the number of functions is not a good measure. Those functions are the most fundamental ones in the DataFrame API. Basically any time anybody wants to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32245: [SPARK-35142][ML] Fix incorrect return type for `rawPredictionUDF` in `OneVsRestModel`

2021-04-19 Thread GitBox
AmplabJenkins removed a comment on pull request #32245: URL: https://github.com/apache/spark/pull/32245#issuecomment-822974434 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42194/

[GitHub] [spark] AmplabJenkins commented on pull request #32245: [SPARK-35142][ML] Fix incorrect return type for `rawPredictionUDF` in `OneVsRestModel`

2021-04-19 Thread GitBox
AmplabJenkins commented on pull request #32245: URL: https://github.com/apache/spark/pull/32245#issuecomment-822974434 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42194/ --

[GitHub] [spark] SparkQA commented on pull request #32245: [SPARK-35142][ML] Fix incorrect return type for `rawPredictionUDF` in `OneVsRestModel`

2021-04-19 Thread GitBox
SparkQA commented on pull request #32245: URL: https://github.com/apache/spark/pull/32245#issuecomment-822974397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32082: [SPARK-34981][SQL] Implement V2 function resolution and evaluation

2021-04-19 Thread GitBox
AmplabJenkins removed a comment on pull request #32082: URL: https://github.com/apache/spark/pull/32082#issuecomment-822973964 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137656/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32243: [WIP][SPARK-XXXXX][SQL][TESTS] Port minimal TPC-DS datagen code from databricks/spark-sql-perf

2021-04-19 Thread GitBox
AmplabJenkins removed a comment on pull request #32243: URL: https://github.com/apache/spark/pull/32243#issuecomment-822973963 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137658/

[GitHub] [spark] AmplabJenkins commented on pull request #32243: [WIP][SPARK-XXXXX][SQL][TESTS] Port minimal TPC-DS datagen code from databricks/spark-sql-perf

2021-04-19 Thread GitBox
AmplabJenkins commented on pull request #32243: URL: https://github.com/apache/spark/pull/32243#issuecomment-822973963 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137658/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32082: [SPARK-34981][SQL] Implement V2 function resolution and evaluation

2021-04-19 Thread GitBox
AmplabJenkins commented on pull request #32082: URL: https://github.com/apache/spark/pull/32082#issuecomment-822973964 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137656/ -- This

[GitHub] [spark] sarutak commented on pull request #31569: [SPARK-34443][CORE] Replace symbol literals with Symbol constructor invocations to comply with Scala 2.13

2021-04-19 Thread GitBox
sarutak commented on pull request #31569: URL: https://github.com/apache/spark/pull/31569#issuecomment-822972918 > DataFrame API. Basically any time anybody wants to refer to a column... just look up stack over low. There are tons of answers with sample code doing ‘col. I mean that

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #32241: [SPARK-35140][MINOR] Add error message guidelines to PR template

2021-04-19 Thread GitBox
dongjoon-hyun edited a comment on pull request #32241: URL: https://github.com/apache/spark/pull/32241#issuecomment-822969005 Hi, @karenfeng . 1. Please revise the PR title by following the PR template . 2. Please remove `[MINOR]` from the PR title. In the PR title and commit title,

[GitHub] [spark] rxin commented on pull request #31569: [SPARK-34443][CORE] Replace symbol literals with Symbol constructor invocations to comply with Scala 2.13

2021-04-19 Thread GitBox
rxin commented on pull request #31569: URL: https://github.com/apache/spark/pull/31569#issuecomment-822969944 With all due respect, the number of functions is not a good measure. Those functions are the most fundamental ones in the DataFrame API. Basically any time anybody wants to refer

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #32241: [SPARK-35140][MINOR] Add error message guidelines to PR template

2021-04-19 Thread GitBox
dongjoon-hyun edited a comment on pull request #32241: URL: https://github.com/apache/spark/pull/32241#issuecomment-822969005 Hi, @karenfeng . 1. Please revise the PR title by following the PR template . 2. Please remove `[MINOR]` from the PR title. In the PR title and commit title,

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #32241: [SPARK-35140][MINOR] Add error message guidelines to PR template

2021-04-19 Thread GitBox
dongjoon-hyun edited a comment on pull request #32241: URL: https://github.com/apache/spark/pull/32241#issuecomment-822969005 Hi, @karenfeng . 1. Please revise the PR title by following the PR template . 2. Please remove `[MINOR]` from the PR title. `[MINOR]` is used when we don't

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #32241: [SPARK-35140][MINOR] Add error message guidelines to PR template

2021-04-19 Thread GitBox
dongjoon-hyun edited a comment on pull request #32241: URL: https://github.com/apache/spark/pull/32241#issuecomment-822969005 Hi, @karenfeng . Please revise the PR title by following the PR template . -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] dongjoon-hyun commented on pull request #32241: [SPARK-35140][MINOR] Add error message guidelines to PR template

2021-04-19 Thread GitBox
dongjoon-hyun commented on pull request #32241: URL: https://github.com/apache/spark/pull/32241#issuecomment-822969005 Hi, @karenfeng . Please recover the PR template. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] sarutak commented on pull request #31569: [SPARK-34443][CORE] Replace symbol literals with Symbol constructor invocations to comply with Scala 2.13

2021-04-19 Thread GitBox
sarutak commented on pull request #31569: URL: https://github.com/apache/spark/pull/31569#issuecomment-822968797 > Public Spark APIs that use Symbols. We can't change them as they are public APIs. We are fine if Scala won't remove the Symbol class. I assume these public APIs will be less

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32243: [WIP][SPARK-XXXXX][SQL][TESTS] Port minimal TPC-DS datagen code from databricks/spark-sql-perf

2021-04-19 Thread GitBox
dongjoon-hyun commented on a change in pull request #32243: URL: https://github.com/apache/spark/pull/32243#discussion_r616338684 ## File path: sql/core/src/test/resources/tpcds-query-results/v1_4/q1.sql.out ## @@ -3,103 +3,103 @@ -- !query schema struct -- !query output

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32243: [WIP][SPARK-XXXXX][SQL][TESTS] Port minimal TPC-DS datagen code from databricks/spark-sql-perf

2021-04-19 Thread GitBox
dongjoon-hyun commented on a change in pull request #32243: URL: https://github.com/apache/spark/pull/32243#discussion_r616337927 ## File path: .github/workflows/build_and_test.yml ## @@ -528,6 +515,24 @@ jobs: uses: actions/setup-java@v1 with:

[GitHub] [spark] SparkQA removed a comment on pull request #32243: [WIP][SPARK-XXXXX][SQL][TESTS] Port minimal TPC-DS datagen code from databricks/spark-sql-perf

2021-04-19 Thread GitBox
SparkQA removed a comment on pull request #32243: URL: https://github.com/apache/spark/pull/32243#issuecomment-822914568 **[Test build #137658 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137658/testReport)** for PR 32243 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #32082: [SPARK-34981][SQL] Implement V2 function resolution and evaluation

2021-04-19 Thread GitBox
SparkQA removed a comment on pull request #32082: URL: https://github.com/apache/spark/pull/32082#issuecomment-822867284 **[Test build #137656 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137656/testReport)** for PR 32082 at commit

[GitHub] [spark] SparkQA commented on pull request #32243: [WIP][SPARK-XXXXX][SQL][TESTS] Port minimal TPC-DS datagen code from databricks/spark-sql-perf

2021-04-19 Thread GitBox
SparkQA commented on pull request #32243: URL: https://github.com/apache/spark/pull/32243#issuecomment-822967198 **[Test build #137658 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137658/testReport)** for PR 32243 at commit

[GitHub] [spark] SparkQA commented on pull request #32082: [SPARK-34981][SQL] Implement V2 function resolution and evaluation

2021-04-19 Thread GitBox
SparkQA commented on pull request #32082: URL: https://github.com/apache/spark/pull/32082#issuecomment-822967110 **[Test build #137656 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137656/testReport)** for PR 32082 at commit

[GitHub] [spark] kyoty commented on a change in pull request #32224: [SPARK-35128][UI] Some columns in table Data Distribution of storage page shows incorrectly when sorted

2021-04-19 Thread GitBox
kyoty commented on a change in pull request #32224: URL: https://github.com/apache/spark/pull/32224#discussion_r616337180 ## File path: core/src/main/resources/org/apache/spark/ui/static/sorttable.js ## @@ -184,6 +184,9 @@ sorttable = { if (text != '') { if

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30542: [SPARK-33594][SQL] Forbid binary type as partition column

2021-04-19 Thread GitBox
AmplabJenkins removed a comment on pull request #30542: URL: https://github.com/apache/spark/pull/30542#issuecomment-822961187 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137663/

[GitHub] [spark] AmplabJenkins commented on pull request #30542: [SPARK-33594][SQL] Forbid binary type as partition column

2021-04-19 Thread GitBox
AmplabJenkins commented on pull request #30542: URL: https://github.com/apache/spark/pull/30542#issuecomment-822961187 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137663/ -- This

[GitHub] [spark] SparkQA removed a comment on pull request #30542: [SPARK-33594][SQL] Forbid binary type as partition column

2021-04-19 Thread GitBox
SparkQA removed a comment on pull request #30542: URL: https://github.com/apache/spark/pull/30542#issuecomment-822938547 **[Test build #137663 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137663/testReport)** for PR 30542 at commit

[GitHub] [spark] SparkQA commented on pull request #30542: [SPARK-33594][SQL] Forbid binary type as partition column

2021-04-19 Thread GitBox
SparkQA commented on pull request #30542: URL: https://github.com/apache/spark/pull/30542#issuecomment-822960968 **[Test build #137663 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137663/testReport)** for PR 30542 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32228: [SPARK-34035][SQL] Refactor ScriptTransformation to remove input parameter and replace it by child.output

2021-04-19 Thread GitBox
AmplabJenkins removed a comment on pull request #32228: URL: https://github.com/apache/spark/pull/32228#issuecomment-822960167 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42191/

[GitHub] [spark] SparkQA commented on pull request #32228: [SPARK-34035][SQL] Refactor ScriptTransformation to remove input parameter and replace it by child.output

2021-04-19 Thread GitBox
SparkQA commented on pull request #32228: URL: https://github.com/apache/spark/pull/32228#issuecomment-822960147 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42191/ -- This is an automated message from the

[GitHub] [spark] AmplabJenkins commented on pull request #32228: [SPARK-34035][SQL] Refactor ScriptTransformation to remove input parameter and replace it by child.output

2021-04-19 Thread GitBox
AmplabJenkins commented on pull request #32228: URL: https://github.com/apache/spark/pull/32228#issuecomment-822960167 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42191/ --

[GitHub] [spark] SparkQA commented on pull request #32072: [SPARK-34974][SQL] Improve subquery decorrelation framework

2021-04-19 Thread GitBox
SparkQA commented on pull request #32072: URL: https://github.com/apache/spark/pull/32072#issuecomment-822956888 **[Test build #137667 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137667/testReport)** for PR 32072 at commit

[GitHub] [spark] SparkQA commented on pull request #32228: [SPARK-34035][SQL] Refactor ScriptTransformation to remove input parameter and replace it by child.output

2021-04-19 Thread GitBox
SparkQA commented on pull request #32228: URL: https://github.com/apache/spark/pull/32228#issuecomment-822956821 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42191/ -- This is an automated message from the Apache

[GitHub] [spark] harupy commented on a change in pull request #32245: [SPARK-35142][ML] Fix incorrect return type for `rawPredictionUDF` in `OneVsRestModel`

2021-04-19 Thread GitBox
harupy commented on a change in pull request #32245: URL: https://github.com/apache/spark/pull/32245#discussion_r616310831 ## File path: python/pyspark/ml/classification.py ## @@ -3151,7 +3151,7 @@ def func(predictions): predArray.append(x)

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32245: [SPARK-35142][ML] Fix incorrect return type for `rawPredictionUDF` in `OneVsRestModel`

2021-04-19 Thread GitBox
AmplabJenkins removed a comment on pull request #32245: URL: https://github.com/apache/spark/pull/32245#issuecomment-822956276 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137666/

[GitHub] [spark] viirya commented on pull request #32179: [SPARK-35080][SQL] Only allow a subset of correlated equality predicates when a subquery is aggregated

2021-04-19 Thread GitBox
viirya commented on pull request #32179: URL: https://github.com/apache/spark/pull/32179#issuecomment-82295 Only affects explain output? Then looks good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [spark] AmplabJenkins commented on pull request #32245: [SPARK-35142][ML] Fix incorrect return type for `rawPredictionUDF` in `OneVsRestModel`

2021-04-19 Thread GitBox
AmplabJenkins commented on pull request #32245: URL: https://github.com/apache/spark/pull/32245#issuecomment-822956276 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137666/ -- This

[GitHub] [spark] SparkQA commented on pull request #32245: [SPARK-35142][ML] Fix incorrect return type for `rawPredictionUDF` in `OneVsRestModel`

2021-04-19 Thread GitBox
SparkQA commented on pull request #32245: URL: https://github.com/apache/spark/pull/32245#issuecomment-822956263 **[Test build #137666 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137666/testReport)** for PR 32245 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #32245: [SPARK-35142][ML] Fix incorrect return type for `rawPredictionUDF` in `OneVsRestModel`

2021-04-19 Thread GitBox
SparkQA removed a comment on pull request #32245: URL: https://github.com/apache/spark/pull/32245#issuecomment-822955744 **[Test build #137666 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137666/testReport)** for PR 32245 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32241: [SPARK-35140][MINOR] Add error message guidelines to PR template

2021-04-19 Thread GitBox
AmplabJenkins removed a comment on pull request #32241: URL: https://github.com/apache/spark/pull/32241#issuecomment-822955497 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42190/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32201: [SPARK-35026][SQL] Support nested CUBE/ROLLUP/GROUPING SETS in GROUPING SETS

2021-04-19 Thread GitBox
AmplabJenkins removed a comment on pull request #32201: URL: https://github.com/apache/spark/pull/32201#issuecomment-822955500 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42192/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32245: [SPARK-35142][ML] Fix incorrect return type for `rawPredictionUDF` in `OneVsRestModel`

2021-04-19 Thread GitBox
AmplabJenkins removed a comment on pull request #32245: URL: https://github.com/apache/spark/pull/32245#issuecomment-822955498 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32072: [SPARK-34974][SQL] Improve subquery decorrelation framework

2021-04-19 Thread GitBox
AmplabJenkins removed a comment on pull request #32072: URL: https://github.com/apache/spark/pull/32072#issuecomment-822955499 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137654/

[GitHub] [spark] AmplabJenkins commented on pull request #32245: [SPARK-35142][ML] Fix incorrect return type for `rawPredictionUDF` in `OneVsRestModel`

2021-04-19 Thread GitBox
AmplabJenkins commented on pull request #32245: URL: https://github.com/apache/spark/pull/32245#issuecomment-822955839 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42193/ --

[GitHub] [spark] SparkQA commented on pull request #32245: [SPARK-35142][ML] Fix incorrect return type for `rawPredictionUDF` in `OneVsRestModel`

2021-04-19 Thread GitBox
SparkQA commented on pull request #32245: URL: https://github.com/apache/spark/pull/32245#issuecomment-822955816 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] SparkQA commented on pull request #32245: [SPARK-35142][ML] Fix incorrect return type for `rawPredictionUDF` in `OneVsRestModel`

2021-04-19 Thread GitBox
SparkQA commented on pull request #32245: URL: https://github.com/apache/spark/pull/32245#issuecomment-822955744 **[Test build #137666 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137666/testReport)** for PR 32245 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #32246: [SPARK-35143][ML] Simplify Python for loop code

2021-04-19 Thread GitBox
AmplabJenkins commented on pull request #32246: URL: https://github.com/apache/spark/pull/32246#issuecomment-822955638 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] AmplabJenkins commented on pull request #32201: [SPARK-35026][SQL] Support nested CUBE/ROLLUP/GROUPING SETS in GROUPING SETS

2021-04-19 Thread GitBox
AmplabJenkins commented on pull request #32201: URL: https://github.com/apache/spark/pull/32201#issuecomment-822955500 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42192/ --

[GitHub] [spark] AmplabJenkins commented on pull request #32241: [SPARK-35140][MINOR] Add error message guidelines to PR template

2021-04-19 Thread GitBox
AmplabJenkins commented on pull request #32241: URL: https://github.com/apache/spark/pull/32241#issuecomment-822955497 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42190/ --

[GitHub] [spark] AmplabJenkins commented on pull request #32245: [SPARK-35142][ML] Fix incorrect return type for `rawPredictionUDF` in `OneVsRestModel`

2021-04-19 Thread GitBox
AmplabJenkins commented on pull request #32245: URL: https://github.com/apache/spark/pull/32245#issuecomment-822955498 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137665/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32072: [SPARK-34974][SQL] Improve subquery decorrelation framework

2021-04-19 Thread GitBox
AmplabJenkins commented on pull request #32072: URL: https://github.com/apache/spark/pull/32072#issuecomment-822955499 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137654/ -- This

[GitHub] [spark] SparkQA commented on pull request #32201: [SPARK-35026][SQL] Support nested CUBE/ROLLUP/GROUPING SETS in GROUPING SETS

2021-04-19 Thread GitBox
SparkQA commented on pull request #32201: URL: https://github.com/apache/spark/pull/32201#issuecomment-822954093 Kubernetes integration test unable to build dist. exiting with code: 1 URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42192/ --

[GitHub] [spark] cloud-fan commented on pull request #32179: [SPARK-35080][SQL] Only allow a subset of correlated equality predicates when a subquery is aggregated

2021-04-19 Thread GitBox
cloud-fan commented on pull request #32179: URL: https://github.com/apache/spark/pull/32179#issuecomment-822954063 During backport, I found that https://issues.apache.org/jira/browse/SPARK-31225 is not in 2.4, which makes the error message a bit confusing. @viirya shall we backport

[GitHub] [spark] SparkQA commented on pull request #32241: [SPARK-35140][MINOR] Add error message guidelines to PR template

2021-04-19 Thread GitBox
SparkQA commented on pull request #32241: URL: https://github.com/apache/spark/pull/32241#issuecomment-822952637 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] SparkQA commented on pull request #32245: [SPARK-35142][ML] Fix incorrect return type for `rawPredictionUDF` in `OneVsRestModel`

2021-04-19 Thread GitBox
SparkQA commented on pull request #32245: URL: https://github.com/apache/spark/pull/32245#issuecomment-822951497 **[Test build #137665 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137665/testReport)** for PR 32245 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #32245: [SPARK-35142][ML] Fix incorrect return type for `rawPredictionUDF` in `OneVsRestModel`

2021-04-19 Thread GitBox
SparkQA removed a comment on pull request #32245: URL: https://github.com/apache/spark/pull/32245#issuecomment-822942777 **[Test build #137665 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137665/testReport)** for PR 32245 at commit

[GitHub] [spark] ChenDou2021 opened a new pull request #32246: [SPARK-35143][ML] Simplify Python for loop code

2021-04-19 Thread GitBox
ChenDou2021 opened a new pull request #32246: URL: https://github.com/apache/spark/pull/32246 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ###

[GitHub] [spark] harupy commented on a change in pull request #32245: [SPARK-35142][ML] Fix incorrect return type for `rawPredictionUDF` in `OneVsRestModel`

2021-04-19 Thread GitBox
harupy commented on a change in pull request #32245: URL: https://github.com/apache/spark/pull/32245#discussion_r616310831 ## File path: python/pyspark/ml/classification.py ## @@ -3151,7 +3151,7 @@ def func(predictions): predArray.append(x)

[GitHub] [spark] harupy commented on a change in pull request #32245: [SPARK-35142][ML] Fix incorrect return type for `rawPredictionUDF` in `OneVsRestModel`

2021-04-19 Thread GitBox
harupy commented on a change in pull request #32245: URL: https://github.com/apache/spark/pull/32245#discussion_r616316046 ## File path: python/pyspark/ml/classification.py ## @@ -3151,7 +3151,7 @@ def func(predictions): predArray.append(x)

[GitHub] [spark] harupy commented on a change in pull request #32245: [SPARK-35142][ML] Fix incorrect return type for `rawPredictionUDF` in `OneVsRestModel`

2021-04-19 Thread GitBox
harupy commented on a change in pull request #32245: URL: https://github.com/apache/spark/pull/32245#discussion_r616310831 ## File path: python/pyspark/ml/classification.py ## @@ -3151,7 +3151,7 @@ def func(predictions): predArray.append(x)

[GitHub] [spark] harupy commented on a change in pull request #32245: [SPARK-35142][ML] Fix incorrect return type for `rawPredictionUDF` in `OneVsRestModel`

2021-04-19 Thread GitBox
harupy commented on a change in pull request #32245: URL: https://github.com/apache/spark/pull/32245#discussion_r616310831 ## File path: python/pyspark/ml/classification.py ## @@ -3151,7 +3151,7 @@ def func(predictions): predArray.append(x)

[GitHub] [spark] SparkQA removed a comment on pull request #32072: [SPARK-34974][SQL] Improve subquery decorrelation framework

2021-04-19 Thread GitBox
SparkQA removed a comment on pull request #32072: URL: https://github.com/apache/spark/pull/32072#issuecomment-822843395 **[Test build #137654 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137654/testReport)** for PR 32072 at commit

[GitHub] [spark] SparkQA commented on pull request #32072: [SPARK-34974][SQL] Improve subquery decorrelation framework

2021-04-19 Thread GitBox
SparkQA commented on pull request #32072: URL: https://github.com/apache/spark/pull/32072#issuecomment-822943013 **[Test build #137654 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137654/testReport)** for PR 32072 at commit

[GitHub] [spark] SparkQA commented on pull request #32245: [SPARK-35142][ML] Fix incorrect return type for `rawPredictionUDF` in `OneVsRestModel`

2021-04-19 Thread GitBox
SparkQA commented on pull request #32245: URL: https://github.com/apache/spark/pull/32245#issuecomment-822942777 **[Test build #137665 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137665/testReport)** for PR 32245 at commit

[GitHub] [spark] harupy commented on a change in pull request #32245: [SPARK-35142][ML] Fix incorrect return type for `rawPredictionUDF` in `OneVsRestModel`

2021-04-19 Thread GitBox
harupy commented on a change in pull request #32245: URL: https://github.com/apache/spark/pull/32245#discussion_r616310831 ## File path: python/pyspark/ml/classification.py ## @@ -3151,7 +3151,7 @@ def func(predictions): predArray.append(x)

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32245: [SPARK-35142][ML] Fix incorrect return type for `rawPredictionUDF` in `OneVsRestModel`

2021-04-19 Thread GitBox
HyukjinKwon commented on a change in pull request #32245: URL: https://github.com/apache/spark/pull/32245#discussion_r616312904 ## File path: python/pyspark/ml/classification.py ## @@ -3151,7 +3151,7 @@ def func(predictions): predArray.append(x)

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32245: [SPARK-35142][ML] Fix incorrect return type for `rawPredictionUDF` in `OneVsRestModel`

2021-04-19 Thread GitBox
AmplabJenkins removed a comment on pull request #32245: URL: https://github.com/apache/spark/pull/32245#issuecomment-822936795 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [spark] HyukjinKwon commented on pull request #32245: [SPARK-35142][ML] Fix incorrect return type for `rawPredictionUDF` in `OneVsRestModel`

2021-04-19 Thread GitBox
HyukjinKwon commented on pull request #32245: URL: https://github.com/apache/spark/pull/32245#issuecomment-822941637 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] SparkQA commented on pull request #32201: [SPARK-35026][SQL] Support nested CUBE/ROLLUP/GROUPING SETS in GROUPING SETS

2021-04-19 Thread GitBox
SparkQA commented on pull request #32201: URL: https://github.com/apache/spark/pull/32201#issuecomment-822941577 **[Test build #137664 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137664/testReport)** for PR 32201 at commit

[GitHub] [spark] harupy commented on a change in pull request #32245: [SPARK-35142][ML] Fix incorrect return type for `rawPredictionUDF` in `OneVsRestModel`

2021-04-19 Thread GitBox
harupy commented on a change in pull request #32245: URL: https://github.com/apache/spark/pull/32245#discussion_r616312217 ## File path: python/pyspark/ml/classification.py ## @@ -3151,7 +3151,7 @@ def func(predictions): predArray.append(x)

  1   2   3   4   5   6   7   8   9   10   >