[GitHub] [spark] cloud-fan closed pull request #32396: [SPARK-34581][SQL] Don't optimize out grouping expressions from aggregate expressions without aggregate function

2021-05-01 Thread GitBox
cloud-fan closed pull request #32396: URL: https://github.com/apache/spark/pull/32396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [spark] cloud-fan commented on pull request #32396: [SPARK-34581][SQL] Don't optimize out grouping expressions from aggregate expressions without aggregate function

2021-05-01 Thread GitBox
cloud-fan commented on pull request #32396: URL: https://github.com/apache/spark/pull/32396#issuecomment-830755716 thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] cloud-fan commented on a change in pull request #32407: [SPARK-35261][SQL] Support static magic method for stateless ScalarFunction

2021-05-01 Thread GitBox
cloud-fan commented on a change in pull request #32407: URL: https://github.com/apache/spark/pull/32407#discussion_r624635432 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/functions/ScalarFunction.java ## @@ -23,39 +23,76 @@ /** *

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32271: [SPARK-35112][SQL] Support Cast string to day-second interval

2021-05-01 Thread GitBox
AmplabJenkins removed a comment on pull request #32271: URL: https://github.com/apache/spark/pull/32271#issuecomment-830752703 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42660/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32415: [WIP][ML] Replace fully com.github.fommil.netlib by dev.ludovic.netlib:2.0

2021-05-01 Thread GitBox
AmplabJenkins removed a comment on pull request #32415: URL: https://github.com/apache/spark/pull/32415#issuecomment-830752701 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138138/

[GitHub] [spark] AmplabJenkins commented on pull request #32271: [SPARK-35112][SQL] Support Cast string to day-second interval

2021-05-01 Thread GitBox
AmplabJenkins commented on pull request #32271: URL: https://github.com/apache/spark/pull/32271#issuecomment-830752703 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42660/ --

[GitHub] [spark] AmplabJenkins commented on pull request #32415: [WIP][ML] Replace fully com.github.fommil.netlib by dev.ludovic.netlib:2.0

2021-05-01 Thread GitBox
AmplabJenkins commented on pull request #32415: URL: https://github.com/apache/spark/pull/32415#issuecomment-830752701 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138138/ -- This

[GitHub] [spark] SparkQA removed a comment on pull request #32415: [WIP][ML] Replace fully com.github.fommil.netlib by dev.ludovic.netlib:2.0

2021-05-01 Thread GitBox
SparkQA removed a comment on pull request #32415: URL: https://github.com/apache/spark/pull/32415#issuecomment-830734787 **[Test build #138138 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138138/testReport)** for PR 32415 at commit

[GitHub] [spark] SparkQA commented on pull request #32415: [WIP][ML] Replace fully com.github.fommil.netlib by dev.ludovic.netlib:2.0

2021-05-01 Thread GitBox
SparkQA commented on pull request #32415: URL: https://github.com/apache/spark/pull/32415#issuecomment-830746622 **[Test build #138138 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138138/testReport)** for PR 32415 at commit

[GitHub] [spark] SparkQA commented on pull request #32271: [SPARK-35112][SQL] Support Cast string to day-second interval

2021-05-01 Thread GitBox
SparkQA commented on pull request #32271: URL: https://github.com/apache/spark/pull/32271#issuecomment-830746310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] vinodkc edited a comment on pull request #32411: [SPARK-28551][SQL]In CTAS with LOCATION , should not allow to a non-empty directory.

2021-05-01 Thread GitBox
vinodkc edited a comment on pull request #32411: URL: https://github.com/apache/spark/pull/32411#issuecomment-830734863 A gentle ping @wangyum @gatorsmile @dongjoon-hyun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] SparkQA commented on pull request #32271: [SPARK-35112][SQL] Support Cast string to day-second interval

2021-05-01 Thread GitBox
SparkQA commented on pull request #32271: URL: https://github.com/apache/spark/pull/32271#issuecomment-830740161 **[Test build #138139 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138139/testReport)** for PR 32271 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

2021-05-01 Thread GitBox
AmplabJenkins removed a comment on pull request #32397: URL: https://github.com/apache/spark/pull/32397#issuecomment-830740047 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138137/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32415: [WIP][ML] Replace fully com.github.fommil.netlib by dev.ludovic.netlib:2.0

2021-05-01 Thread GitBox
AmplabJenkins removed a comment on pull request #32415: URL: https://github.com/apache/spark/pull/32415#issuecomment-830740046 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42659/

[GitHub] [spark] AmplabJenkins commented on pull request #32415: [WIP][ML] Replace fully com.github.fommil.netlib by dev.ludovic.netlib:2.0

2021-05-01 Thread GitBox
AmplabJenkins commented on pull request #32415: URL: https://github.com/apache/spark/pull/32415#issuecomment-830740046 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42659/ --

[GitHub] [spark] AmplabJenkins commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

2021-05-01 Thread GitBox
AmplabJenkins commented on pull request #32397: URL: https://github.com/apache/spark/pull/32397#issuecomment-830740047 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138137/ -- This

[GitHub] [spark] SparkQA commented on pull request #32415: [WIP][ML] Replace fully com.github.fommil.netlib by dev.ludovic.netlib:2.0

2021-05-01 Thread GitBox
SparkQA commented on pull request #32415: URL: https://github.com/apache/spark/pull/32415#issuecomment-830738183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] SparkQA removed a comment on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

2021-05-01 Thread GitBox
SparkQA removed a comment on pull request #32397: URL: https://github.com/apache/spark/pull/32397#issuecomment-830722441 **[Test build #138137 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138137/testReport)** for PR 32397 at commit

[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

2021-05-01 Thread GitBox
SparkQA commented on pull request #32397: URL: https://github.com/apache/spark/pull/32397#issuecomment-830736790 **[Test build #138137 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138137/testReport)** for PR 32397 at commit

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #32271: [SPARK-35112][SQL] Support Cast string to day-second interval

2021-05-01 Thread GitBox
AngersZh commented on a change in pull request #32271: URL: https://github.com/apache/spark/pull/32271#discussion_r624611785 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala ## @@ -1775,6 +1775,48 @@ class CastSuite

[GitHub] [spark] AngersZhuuuu commented on pull request #32271: [SPARK-35112][SQL] Support Cast string to day-second interval

2021-05-01 Thread GitBox
AngersZh commented on pull request #32271: URL: https://github.com/apache/spark/pull/32271#issuecomment-830736256 > Please, address comments. Sorry for my late, since yesterday's run failed so I revert and recheck, but some thing urgent break my work. -- This is an automated

[GitHub] [spark] vinodkc commented on pull request #32411: [SPARK-28551][SQL][WIP]In CTAS with LOCATION , should not allow to a non-empty directory.

2021-05-01 Thread GitBox
vinodkc commented on pull request #32411: URL: https://github.com/apache/spark/pull/32411#issuecomment-830734863 A gentle ping @wangyum @@gatorsmile @dongjoon-hyun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32415: [WIP][ML] Replace fully com.github.fommil.netlib by dev.ludovic.netlib:2.0

2021-05-01 Thread GitBox
AmplabJenkins removed a comment on pull request #32415: URL: https://github.com/apache/spark/pull/32415#issuecomment-830716536 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [spark] SparkQA commented on pull request #32415: [WIP][ML] Replace fully com.github.fommil.netlib by dev.ludovic.netlib:2.0

2021-05-01 Thread GitBox
SparkQA commented on pull request #32415: URL: https://github.com/apache/spark/pull/32415#issuecomment-830734787 **[Test build #138138 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138138/testReport)** for PR 32415 at commit

[GitHub] [spark] srowen commented on pull request #32415: [WIP][ML] Replace fully com.github.fommil.netlib by dev.ludovic.netlib:2.0

2021-05-01 Thread GitBox
srowen commented on pull request #32415: URL: https://github.com/apache/spark/pull/32415#issuecomment-830733619 Jenkins test this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] srowen commented on a change in pull request #32415: [WIP][ML] Replace fully com.github.fommil.netlib by dev.ludovic.netlib:2.0

2021-05-01 Thread GitBox
srowen commented on a change in pull request #32415: URL: https://github.com/apache/spark/pull/32415#discussion_r624608038 ## File path: pom.xml ## @@ -172,7 +172,7 @@ 2.12.2 1.1.8.4 1.1.2 -1.3.2 +2-SNAPSHOT Review comment: Ideally we don't

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

2021-05-01 Thread GitBox
AmplabJenkins removed a comment on pull request #32397: URL: https://github.com/apache/spark/pull/32397#issuecomment-830730568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] AmplabJenkins commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

2021-05-01 Thread GitBox
AmplabJenkins commented on pull request #32397: URL: https://github.com/apache/spark/pull/32397#issuecomment-830730568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

2021-05-01 Thread GitBox
SparkQA commented on pull request #32397: URL: https://github.com/apache/spark/pull/32397#issuecomment-830729189 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] SparkQA removed a comment on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

2021-05-01 Thread GitBox
SparkQA removed a comment on pull request #32397: URL: https://github.com/apache/spark/pull/32397#issuecomment-830710298 **[Test build #138136 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138136/testReport)** for PR 32397 at commit

[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

2021-05-01 Thread GitBox
SparkQA commented on pull request #32397: URL: https://github.com/apache/spark/pull/32397#issuecomment-830727039 **[Test build #138136 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138136/testReport)** for PR 32397 at commit

[GitHub] [spark] wangyum commented on a change in pull request #32350: [SPARK-35231][SQL] logical.Range override maxRowsPerPartition

2021-05-01 Thread GitBox
wangyum commented on a change in pull request #32350: URL: https://github.com/apache/spark/pull/32350#discussion_r624600463 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/CombiningLimitsSuite.scala ## @@ -150,6 +150,14 @@ class

[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

2021-05-01 Thread GitBox
SparkQA commented on pull request #32397: URL: https://github.com/apache/spark/pull/32397#issuecomment-830722441 **[Test build #138137 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138137/testReport)** for PR 32397 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32413: [SPARK-35288][SQL] StaticInvoke should find the method without exact argument classes match

2021-05-01 Thread GitBox
AmplabJenkins removed a comment on pull request #32413: URL: https://github.com/apache/spark/pull/32413#issuecomment-830722164 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138134/

[GitHub] [spark] AmplabJenkins commented on pull request #32413: [SPARK-35288][SQL] StaticInvoke should find the method without exact argument classes match

2021-05-01 Thread GitBox
AmplabJenkins commented on pull request #32413: URL: https://github.com/apache/spark/pull/32413#issuecomment-830722164 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138134/ -- This

[GitHub] [spark] ocworld edited a comment on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

2021-05-01 Thread GitBox
ocworld edited a comment on pull request #32397: URL: https://github.com/apache/spark/pull/32397#issuecomment-830720578 @dongjoon-hyun Thank you for your test and reply. Though rebasing from upstream, checking build and test is failed now. The jenkins build is also failed with logs.

[GitHub] [spark] ocworld commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

2021-05-01 Thread GitBox
ocworld commented on pull request #32397: URL: https://github.com/apache/spark/pull/32397#issuecomment-830720578 @dongjoon-hyun Thank you for your test and reply. Though rebasing from upstream, checking build and test is failed now. Jenkins build is also failed with logs. ```

[GitHub] [spark] SparkQA removed a comment on pull request #32413: [SPARK-35288][SQL] StaticInvoke should find the method without exact argument classes match

2021-05-01 Thread GitBox
SparkQA removed a comment on pull request #32413: URL: https://github.com/apache/spark/pull/32413#issuecomment-830692285 **[Test build #138134 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138134/testReport)** for PR 32413 at commit

[GitHub] [spark] SparkQA commented on pull request #32413: [SPARK-35288][SQL] StaticInvoke should find the method without exact argument classes match

2021-05-01 Thread GitBox
SparkQA commented on pull request #32413: URL: https://github.com/apache/spark/pull/32413#issuecomment-830718800 **[Test build #138134 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138134/testReport)** for PR 32413 at commit

[GitHub] [spark] viirya commented on a change in pull request #32413: [SPARK-35288][SQL] StaticInvoke should find the method without exact argument classes match

2021-05-01 Thread GitBox
viirya commented on a change in pull request #32413: URL: https://github.com/apache/spark/pull/32413#discussion_r624589600 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala ## @@ -236,7 +236,32 @@ case class

[GitHub] [spark] viirya commented on a change in pull request #32413: [SPARK-35288][SQL] StaticInvoke should find the method without exact argument classes match

2021-05-01 Thread GitBox
viirya commented on a change in pull request #32413: URL: https://github.com/apache/spark/pull/32413#discussion_r624589576 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala ## @@ -236,7 +236,32 @@ case class

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32414: Preparing development version 2.4.9-SNAPSHOT

2021-05-01 Thread GitBox
AmplabJenkins removed a comment on pull request #32414: URL: https://github.com/apache/spark/pull/32414#issuecomment-830716520 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138135/

[GitHub] [spark] viirya closed pull request #32414: Preparing development version 2.4.9-SNAPSHOT

2021-05-01 Thread GitBox
viirya closed pull request #32414: URL: https://github.com/apache/spark/pull/32414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [spark] AmplabJenkins commented on pull request #32415: [WIP][ML] Replace fully com.github.fommil.netlib by dev.ludovic.netlib:2.0

2021-05-01 Thread GitBox
AmplabJenkins commented on pull request #32415: URL: https://github.com/apache/spark/pull/32415#issuecomment-830716536 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] AmplabJenkins commented on pull request #32414: Preparing development version 2.4.9-SNAPSHOT

2021-05-01 Thread GitBox
AmplabJenkins commented on pull request #32414: URL: https://github.com/apache/spark/pull/32414#issuecomment-830716520 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138135/ -- This

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

2021-05-01 Thread GitBox
AmplabJenkins removed a comment on pull request #32397: URL: https://github.com/apache/spark/pull/32397#issuecomment-830716406 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42657/

[GitHub] [spark] SparkQA removed a comment on pull request #32414: Preparing development version 2.4.9-SNAPSHOT

2021-05-01 Thread GitBox
SparkQA removed a comment on pull request #32414: URL: https://github.com/apache/spark/pull/32414#issuecomment-830704885 **[Test build #138135 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138135/testReport)** for PR 32414 at commit

[GitHub] [spark] viirya commented on pull request #32414: Preparing development version 2.4.9-SNAPSHOT

2021-05-01 Thread GitBox
viirya commented on pull request #32414: URL: https://github.com/apache/spark/pull/32414#issuecomment-830716465 Thanks @maropu and @dongjoon-hyun! Merging to 2.4. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [spark] wangyum edited a comment on pull request #32410: [SPARK-35286][SQL] Replace SessionState.start with SessionState.setCurrentSessionState

2021-05-01 Thread GitBox
wangyum edited a comment on pull request #32410: URL: https://github.com/apache/spark/pull/32410#issuecomment-830716144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] AmplabJenkins commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

2021-05-01 Thread GitBox
AmplabJenkins commented on pull request #32397: URL: https://github.com/apache/spark/pull/32397#issuecomment-830716406 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42657/ --

[GitHub] [spark] SparkQA commented on pull request #32414: Preparing development version 2.4.9-SNAPSHOT

2021-05-01 Thread GitBox
SparkQA commented on pull request #32414: URL: https://github.com/apache/spark/pull/32414#issuecomment-830716421 **[Test build #138135 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138135/testReport)** for PR 32414 at commit

[GitHub] [spark] wangyum commented on pull request #32410: [SPARK-35286][SQL] Replace SessionState.start with SessionState.setCurrentSessionState

2021-05-01 Thread GitBox
wangyum commented on pull request #32410: URL: https://github.com/apache/spark/pull/32410#issuecomment-830716144 @dongjoon-hyun This patch only use setCurrentSessionState with all versions except for Hive 0.12. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] viirya commented on a change in pull request #32413: [SPARK-35288][SQL] StaticInvoke should find the method without exact argument classes match

2021-05-01 Thread GitBox
viirya commented on a change in pull request #32413: URL: https://github.com/apache/spark/pull/32413#discussion_r624587848 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ObjectExpressionsSuite.scala ## @@ -641,6 +641,18 @@ class

[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

2021-05-01 Thread GitBox
SparkQA commented on pull request #32397: URL: https://github.com/apache/spark/pull/32397#issuecomment-830714990 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] luhenry commented on pull request #32415: [WIP][ML] Replace fully com.github.fommil.netlib by dev.ludovic.netlib:2.0

2021-05-01 Thread GitBox
luhenry commented on pull request #32415: URL: https://github.com/apache/spark/pull/32415#issuecomment-830714185 /cc @srowen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] luhenry opened a new pull request #32415: [WIP][ML] Replace fully com.github.fommil.netlib by dev.ludovic.netlib:2.0

2021-05-01 Thread GitBox
luhenry opened a new pull request #32415: URL: https://github.com/apache/spark/pull/32415 ### What changes were proposed in this pull request? Bump to `dev.ludovic.netlib:2.0` which provides JNI-based wrappers for BLAS, ARPACK, and LAPACK. Theseare not taking

[GitHub] [spark] github-actions[bot] commented on pull request #31268: [SPARK-32165][SQL] Ensure Spark only initiates SharedState once across SparkSessions

2021-05-01 Thread GitBox
github-actions[bot] commented on pull request #31268: URL: https://github.com/apache/spark/pull/31268#issuecomment-830713313 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue

[GitHub] [spark] github-actions[bot] closed pull request #31053: [SPARK-32165][SQL] Ensure Spark only initiates SharedState once across SparkSessions

2021-05-01 Thread GitBox
github-actions[bot] closed pull request #31053: URL: https://github.com/apache/spark/pull/31053 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

2021-05-01 Thread GitBox
AmplabJenkins removed a comment on pull request #32397: URL: https://github.com/apache/spark/pull/32397#issuecomment-829244740 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [spark] SparkQA commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

2021-05-01 Thread GitBox
SparkQA commented on pull request #32397: URL: https://github.com/apache/spark/pull/32397#issuecomment-830710298 **[Test build #138136 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138136/testReport)** for PR 32397 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32414: Preparing development version 2.4.9-SNAPSHOT

2021-05-01 Thread GitBox
AmplabJenkins removed a comment on pull request #32414: URL: https://github.com/apache/spark/pull/32414#issuecomment-830710223 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42656/

[GitHub] [spark] AmplabJenkins commented on pull request #32414: Preparing development version 2.4.9-SNAPSHOT

2021-05-01 Thread GitBox
AmplabJenkins commented on pull request #32414: URL: https://github.com/apache/spark/pull/32414#issuecomment-830710223 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42656/ --

[GitHub] [spark] dongjoon-hyun commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

2021-05-01 Thread GitBox
dongjoon-hyun commented on pull request #32397: URL: https://github.com/apache/spark/pull/32397#issuecomment-830707569 > Can I see logs about failure of build and test? Apache Spark GitHub Action is running in your GitHub Account.

[GitHub] [spark] dongjoon-hyun commented on pull request #32397: [SPARK-35084][CORE] Spark 3: supporting "--packages" in k8s cluster mode

2021-05-01 Thread GitBox
dongjoon-hyun commented on pull request #32397: URL: https://github.com/apache/spark/pull/32397#issuecomment-830707293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] SparkQA commented on pull request #32414: Preparing development version 2.4.9-SNAPSHOT

2021-05-01 Thread GitBox
SparkQA commented on pull request #32414: URL: https://github.com/apache/spark/pull/32414#issuecomment-830706970 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] maropu commented on a change in pull request #32413: [SPARK-35288][SQL] StaticInvoke should find the method without exact argument classes match

2021-05-01 Thread GitBox
maropu commented on a change in pull request #32413: URL: https://github.com/apache/spark/pull/32413#discussion_r624578673 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala ## @@ -236,7 +236,32 @@ case class

[GitHub] [spark] dongjoon-hyun commented on pull request #32398: [WIP] hive version upgraded from 2.3.7 to 2.3.8

2021-05-01 Thread GitBox
dongjoon-hyun commented on pull request #32398: URL: https://github.com/apache/spark/pull/32398#issuecomment-830706462 Well, when it comes to the security, I'd like to recommend to use Apache Spark 3.1.1 which has more latest other patches together. What is the blocker for you,

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32413: [SPARK-35288][SQL] StaticInvoke should find the method without exact argument classes match

2021-05-01 Thread GitBox
dongjoon-hyun commented on a change in pull request #32413: URL: https://github.com/apache/spark/pull/32413#discussion_r624577377 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ObjectExpressionsSuite.scala ## @@ -641,6 +641,18 @@ class

[GitHub] [spark] dongjoon-hyun commented on pull request #32412: [SPARK-35278][SQL][2.4] Invoke should find the method with correct number of parameters

2021-05-01 Thread GitBox
dongjoon-hyun commented on pull request #32412: URL: https://github.com/apache/spark/pull/32412#issuecomment-830705522 +1, late LGTM. Thank you all! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] dongjoon-hyun commented on pull request #32404: [SPARK-35278][SQL] Invoke should find the method with correct number of parameters

2021-05-01 Thread GitBox
dongjoon-hyun commented on pull request #32404: URL: https://github.com/apache/spark/pull/32404#issuecomment-830705483 +1, late LGTM with the last commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [spark] maropu commented on a change in pull request #32413: [SPARK-35288][SQL] StaticInvoke should find the method without exact argument classes match

2021-05-01 Thread GitBox
maropu commented on a change in pull request #32413: URL: https://github.com/apache/spark/pull/32413#discussion_r624576554 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala ## @@ -236,7 +236,32 @@ case class

[GitHub] [spark] SparkQA commented on pull request #32414: Preparing development version 2.4.9-SNAPSHOT

2021-05-01 Thread GitBox
SparkQA commented on pull request #32414: URL: https://github.com/apache/spark/pull/32414#issuecomment-830704885 **[Test build #138135 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138135/testReport)** for PR 32414 at commit

[GitHub] [spark] viirya commented on pull request #32414: Preparing development version 2.4.9-SNAPSHOT

2021-05-01 Thread GitBox
viirya commented on pull request #32414: URL: https://github.com/apache/spark/pull/32414#issuecomment-830703797 Same as #32293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] viirya opened a new pull request #32414: Preparing development version 2.4.9-SNAPSHOT

2021-05-01 Thread GitBox
viirya opened a new pull request #32414: URL: https://github.com/apache/spark/pull/32414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [spark] maropu commented on pull request #32405: [SPARK-35273][SQL] CombineFilters support non-deterministic expressions

2021-05-01 Thread GitBox
maropu commented on pull request #32405: URL: https://github.com/apache/spark/pull/32405#issuecomment-830703604 late lgtm. Thanks you, @wangyum ~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] maropu commented on a change in pull request #32350: [SPARK-35231][SQL] logical.Range override maxRowsPerPartition

2021-05-01 Thread GitBox
maropu commented on a change in pull request #32350: URL: https://github.com/apache/spark/pull/32350#discussion_r624574030 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -1618,12 +1618,18 @@ object EliminateLimits

[GitHub] [spark] viirya closed pull request #32412: [SPARK-35278][SQL][2.4] Invoke should find the method with correct number of parameters

2021-05-01 Thread GitBox
viirya closed pull request #32412: URL: https://github.com/apache/spark/pull/32412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [spark] viirya commented on pull request #32412: [SPARK-35278][SQL][2.4] Invoke should find the method with correct number of parameters

2021-05-01 Thread GitBox
viirya commented on pull request #32412: URL: https://github.com/apache/spark/pull/32412#issuecomment-830700159 Thanks @maropu! Merging to 2.4. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32412: [SPARK-35278][SQL][2.4] Invoke should find the method with correct number of parameters

2021-05-01 Thread GitBox
AmplabJenkins removed a comment on pull request #32412: URL: https://github.com/apache/spark/pull/32412#issuecomment-830698924 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138133/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32413: [SPARK-35288][SQL] StaticInvoke should find the method without exact argument classes match

2021-05-01 Thread GitBox
AmplabJenkins removed a comment on pull request #32413: URL: https://github.com/apache/spark/pull/32413#issuecomment-830698923 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42655/

[GitHub] [spark] AmplabJenkins commented on pull request #32413: [SPARK-35288][SQL] StaticInvoke should find the method without exact argument classes match

2021-05-01 Thread GitBox
AmplabJenkins commented on pull request #32413: URL: https://github.com/apache/spark/pull/32413#issuecomment-830698923 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42655/ --

[GitHub] [spark] AmplabJenkins commented on pull request #32412: [SPARK-35278][SQL][2.4] Invoke should find the method with correct number of parameters

2021-05-01 Thread GitBox
AmplabJenkins commented on pull request #32412: URL: https://github.com/apache/spark/pull/32412#issuecomment-830698924 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138133/ -- This

[GitHub] [spark] SparkQA commented on pull request #32413: [SPARK-35288][SQL] StaticInvoke should find the method without exact argument classes match

2021-05-01 Thread GitBox
SparkQA commented on pull request #32413: URL: https://github.com/apache/spark/pull/32413#issuecomment-830697396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] SparkQA removed a comment on pull request #32412: [SPARK-35278][SQL][2.4] Invoke should find the method with correct number of parameters

2021-05-01 Thread GitBox
SparkQA removed a comment on pull request #32412: URL: https://github.com/apache/spark/pull/32412#issuecomment-830668716 **[Test build #138133 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138133/testReport)** for PR 32412 at commit

[GitHub] [spark] SparkQA commented on pull request #32412: [SPARK-35278][SQL][2.4] Invoke should find the method with correct number of parameters

2021-05-01 Thread GitBox
SparkQA commented on pull request #32412: URL: https://github.com/apache/spark/pull/32412#issuecomment-830694487 **[Test build #138133 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138133/testReport)** for PR 32412 at commit

[GitHub] [spark] SparkQA commented on pull request #32413: [SPARK-35288][SQL] StaticInvoke should find the method without exact argument classes match

2021-05-01 Thread GitBox
SparkQA commented on pull request #32413: URL: https://github.com/apache/spark/pull/32413#issuecomment-830692285 **[Test build #138134 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138134/testReport)** for PR 32413 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32411: [SPARK-28551][SQL][WIP]In CTAS with LOCATION , should not allow to a non-empty directory.

2021-05-01 Thread GitBox
AmplabJenkins removed a comment on pull request #32411: URL: https://github.com/apache/spark/pull/32411#issuecomment-830691948 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138131/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32271: [SPARK-35112][SQL] Support Cast string to day-second interval

2021-05-01 Thread GitBox
AmplabJenkins removed a comment on pull request #32271: URL: https://github.com/apache/spark/pull/32271#issuecomment-830691950 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138132/

[GitHub] [spark] AmplabJenkins commented on pull request #32411: [SPARK-28551][SQL][WIP]In CTAS with LOCATION , should not allow to a non-empty directory.

2021-05-01 Thread GitBox
AmplabJenkins commented on pull request #32411: URL: https://github.com/apache/spark/pull/32411#issuecomment-830691948 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138131/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32271: [SPARK-35112][SQL] Support Cast string to day-second interval

2021-05-01 Thread GitBox
AmplabJenkins commented on pull request #32271: URL: https://github.com/apache/spark/pull/32271#issuecomment-830691950 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138132/ -- This

[GitHub] [spark] viirya commented on a change in pull request #32413: [SPARK-35288][SQL] StaticInvoke should find the method without exact argument classes match

2021-05-01 Thread GitBox
viirya commented on a change in pull request #32413: URL: https://github.com/apache/spark/pull/32413#discussion_r624563330 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala ## @@ -236,7 +236,32 @@ case class

[GitHub] [spark] viirya opened a new pull request #32413: [SPARK-35288][SQL] StaticInvoke should find the method without exact argument classes match

2021-05-01 Thread GitBox
viirya opened a new pull request #32413: URL: https://github.com/apache/spark/pull/32413 ### What changes were proposed in this pull request? This patch proposes to make StaticInvoke able to find method with given method name even the parameter types do not exactly match

[GitHub] [spark] SparkQA removed a comment on pull request #32411: [SPARK-28551][SQL][WIP]In CTAS with LOCATION , should not allow to a non-empty directory.

2021-05-01 Thread GitBox
SparkQA removed a comment on pull request #32411: URL: https://github.com/apache/spark/pull/32411#issuecomment-830652565 **[Test build #138131 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138131/testReport)** for PR 32411 at commit

[GitHub] [spark] SparkQA commented on pull request #32411: [SPARK-28551][SQL][WIP]In CTAS with LOCATION , should not allow to a non-empty directory.

2021-05-01 Thread GitBox
SparkQA commented on pull request #32411: URL: https://github.com/apache/spark/pull/32411#issuecomment-830691400 **[Test build #138131 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138131/testReport)** for PR 32411 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #32271: [SPARK-35112][SQL] Support Cast string to day-second interval

2021-05-01 Thread GitBox
SparkQA removed a comment on pull request #32271: URL: https://github.com/apache/spark/pull/32271#issuecomment-830652613 **[Test build #138132 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138132/testReport)** for PR 32271 at commit

[GitHub] [spark] SparkQA commented on pull request #32271: [SPARK-35112][SQL] Support Cast string to day-second interval

2021-05-01 Thread GitBox
SparkQA commented on pull request #32271: URL: https://github.com/apache/spark/pull/32271#issuecomment-830688029 **[Test build #138132 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138132/testReport)** for PR 32271 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32412: [SPARK-35278][SQL][2.4] Invoke should find the method with correct number of parameters

2021-05-01 Thread GitBox
AmplabJenkins removed a comment on pull request #32412: URL: https://github.com/apache/spark/pull/32412#issuecomment-830676935 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42654/

[GitHub] [spark] AmplabJenkins commented on pull request #32412: [SPARK-35278][SQL][2.4] Invoke should find the method with correct number of parameters

2021-05-01 Thread GitBox
AmplabJenkins commented on pull request #32412: URL: https://github.com/apache/spark/pull/32412#issuecomment-830676935 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42654/ --

[GitHub] [spark] SparkQA commented on pull request #32412: [SPARK-35278][SQL][2.4] Invoke should find the method with correct number of parameters

2021-05-01 Thread GitBox
SparkQA commented on pull request #32412: URL: https://github.com/apache/spark/pull/32412#issuecomment-830672076 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] peter-toth commented on pull request #32396: [SPARK-34581][SQL] Don't optimize out grouping expressions from aggregate expressions without aggregate function

2021-05-01 Thread GitBox
peter-toth commented on pull request #32396: URL: https://github.com/apache/spark/pull/32396#issuecomment-830670216 TPCDS [benchmark](https://github.com/peter-toth/spark/commit/fb9de2e563d712227bd7178dca4ed5a66f06d400) on scaleFactor=5 data looks good, no significant change:

  1   2   3   >