[GitHub] [spark] SparkQA commented on pull request #30565: [WIP][SPARK-33625][SQL] Subexpression elimination for whole-stage codegen in Filter

2021-07-03 Thread GitBox
SparkQA commented on pull request #30565: URL: https://github.com/apache/spark/pull/30565#issuecomment-873533440 **[Test build #140619 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140619/testReport)** for PR 30565 at commit [`ba41720`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #32944: [SPARK-35794][SQL] Allow custom plugin for AQE cost evaluator

2021-07-03 Thread GitBox
SparkQA commented on pull request #32944: URL: https://github.com/apache/spark/pull/32944#issuecomment-873533310 **[Test build #140618 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140618/testReport)** for PR 32944 at commit [`ac5c121`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #33186: [SPARK-35987][SQL] The ANSI flags of Sum and Avg should be kept after being copied

2021-07-03 Thread GitBox
SparkQA commented on pull request #33186: URL: https://github.com/apache/spark/pull/33186#issuecomment-873533267 **[Test build #140617 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140617/testReport)** for PR 33186 at commit [`c484538`](https://github.com

[GitHub] [spark] viirya commented on pull request #30565: [WIP][SPARK-33625][SQL] Subexpression elimination for whole-stage codegen in Filter

2021-07-03 Thread GitBox
viirya commented on pull request #30565: URL: https://github.com/apache/spark/pull/30565#issuecomment-873532291 Okay, now the subexpressions are just pulled before the individual predicate uses it. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [spark] pingsutw commented on pull request #33203: [SPARK-36007][INFRA] Failed to run benchmark in GA

2021-07-03 Thread GitBox
pingsutw commented on pull request #33203: URL: https://github.com/apache/spark/pull/33203#issuecomment-873529684 Benchmark workflow has run successfully. https://github.com/pingsutw/spark/actions/runs/997616866 -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] c21 commented on pull request #32944: [SPARK-35794][SQL] Allow custom plugin for AQE cost evaluator

2021-07-03 Thread GitBox
c21 commented on pull request #32944: URL: https://github.com/apache/spark/pull/32944#issuecomment-873529668 @HyukjinKwon - updated per discussion, and this is ready for review again, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [spark] c21 commented on a change in pull request #32944: [SPARK-35794][SQL] Allow custom plugin for AQE cost evaluator

2021-07-03 Thread GitBox
c21 commented on a change in pull request #32944: URL: https://github.com/apache/spark/pull/32944#discussion_r663452659 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -678,6 +678,15 @@ object SQLConf { .booleanConf .cr

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33203: [SPARK-36007][INFRA] Failed to run benchmark in GA

2021-07-03 Thread GitBox
AmplabJenkins removed a comment on pull request #33203: URL: https://github.com/apache/spark/pull/33203#issuecomment-873526983 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140616/ -

[GitHub] [spark] AmplabJenkins commented on pull request #33203: [SPARK-36007][INFRA] Failed to run benchmark in GA

2021-07-03 Thread GitBox
AmplabJenkins commented on pull request #33203: URL: https://github.com/apache/spark/pull/33203#issuecomment-873526983 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140616/ -- This

[GitHub] [spark] SparkQA removed a comment on pull request #33203: [SPARK-36007][INFRA] Failed to run benchmark in GA

2021-07-03 Thread GitBox
SparkQA removed a comment on pull request #33203: URL: https://github.com/apache/spark/pull/33203#issuecomment-873504243 **[Test build #140616 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140616/testReport)** for PR 33203 at commit [`ba54bd2`](https://gi

[GitHub] [spark] SparkQA commented on pull request #33203: [SPARK-36007][INFRA] Failed to run benchmark in GA

2021-07-03 Thread GitBox
SparkQA commented on pull request #33203: URL: https://github.com/apache/spark/pull/33203#issuecomment-873524618 **[Test build #140616 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140616/testReport)** for PR 33203 at commit [`ba54bd2`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33203: [SPARK-36007][INFRA] Failed to run benchmark in GA

2021-07-03 Thread GitBox
AmplabJenkins removed a comment on pull request #33203: URL: https://github.com/apache/spark/pull/33203#issuecomment-873521212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [spark] AmplabJenkins commented on pull request #33203: [SPARK-36007][INFRA] Failed to run benchmark in GA

2021-07-03 Thread GitBox
AmplabJenkins commented on pull request #33203: URL: https://github.com/apache/spark/pull/33203#issuecomment-873521212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [spark] SparkQA removed a comment on pull request #33203: [SPARK-36007][INFRA] Failed to run benchmark in GA

2021-07-03 Thread GitBox
SparkQA removed a comment on pull request #33203: URL: https://github.com/apache/spark/pull/33203#issuecomment-873499056 **[Test build #140615 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140615/testReport)** for PR 33203 at commit [`e635b8e`](https://gi

[GitHub] [spark] SparkQA commented on pull request #33203: [SPARK-36007][INFRA] Failed to run benchmark in GA

2021-07-03 Thread GitBox
SparkQA commented on pull request #33203: URL: https://github.com/apache/spark/pull/33203#issuecomment-873518711 **[Test build #140615 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140615/testReport)** for PR 33203 at commit [`e635b8e`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #33203: [SPARK-36007][INFRA] Failed to run benchmark in GA

2021-07-03 Thread GitBox
SparkQA commented on pull request #33203: URL: https://github.com/apache/spark/pull/33203#issuecomment-873517385 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45129/ -- This is an automated message from the A

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33203: [SPARK-36007][INFRA] Failed to run benchmark in GA

2021-07-03 Thread GitBox
AmplabJenkins removed a comment on pull request #33203: URL: https://github.com/apache/spark/pull/33203#issuecomment-873515749 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45128/

[GitHub] [spark] AmplabJenkins commented on pull request #33203: [SPARK-36007][INFRA] Failed to run benchmark in GA

2021-07-03 Thread GitBox
AmplabJenkins commented on pull request #33203: URL: https://github.com/apache/spark/pull/33203#issuecomment-873515749 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45128/ -- T

[GitHub] [spark] SparkQA commented on pull request #33203: [SPARK-36007][INFRA] Failed to run benchmark in GA

2021-07-03 Thread GitBox
SparkQA commented on pull request #33203: URL: https://github.com/apache/spark/pull/33203#issuecomment-873509186 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45129/ -- This is an automated message from the Apache

[GitHub] [spark] srowen commented on pull request #33199: [SPARK-36004][INFRA] Update MiMa and audit API changes

2021-07-03 Thread GitBox
srowen commented on pull request #33199: URL: https://github.com/apache/spark/pull/33199#issuecomment-873506320 I think the current state is that this passes only because some exclusions have to be retained that seem unintended - they were excluded for 3.0 - 3.1 not 3.1 - 3.2, but we were

[GitHub] [spark] SparkQA commented on pull request #33203: [SPARK-36007][INFRA] Failed to run benchmark in GA

2021-07-03 Thread GitBox
SparkQA commented on pull request #33203: URL: https://github.com/apache/spark/pull/33203#issuecomment-873505692 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45128/ -- This is an automated message from the A

[GitHub] [spark] SparkQA commented on pull request #33203: [SPARK-36007][INFRA] Failed to run benchmark in GA

2021-07-03 Thread GitBox
SparkQA commented on pull request #33203: URL: https://github.com/apache/spark/pull/33203#issuecomment-873504243 **[Test build #140616 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140616/testReport)** for PR 33203 at commit [`ba54bd2`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #33203: [SPARK-36007][INFRA] Failed to run benchmark in GA

2021-07-03 Thread GitBox
SparkQA commented on pull request #33203: URL: https://github.com/apache/spark/pull/33203#issuecomment-873502895 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45128/ -- This is an automated message from the Apache

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32081: [SPARK-34674][CORE][K8S] Close SparkContext after the Main method has finished

2021-07-03 Thread GitBox
HyukjinKwon commented on a change in pull request #32081: URL: https://github.com/apache/spark/pull/32081#discussion_r663434317 ## File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ## @@ -952,6 +952,12 @@ private[spark] class SparkSubmit extends Logging {

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32081: [SPARK-34674][CORE][K8S] Close SparkContext after the Main method has finished

2021-07-03 Thread GitBox
HyukjinKwon commented on a change in pull request #32081: URL: https://github.com/apache/spark/pull/32081#discussion_r663434289 ## File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ## @@ -952,6 +952,12 @@ private[spark] class SparkSubmit extends Logging {

[GitHub] [spark] pingsutw commented on a change in pull request #33203: [SPARK-36007][INFRA] Failed to run benchmark in GA

2021-07-03 Thread GitBox
pingsutw commented on a change in pull request #33203: URL: https://github.com/apache/spark/pull/33203#discussion_r663433955 ## File path: .github/workflows/benchmark.yml ## @@ -85,6 +85,7 @@ jobs: # In benchmark, we use local as master so set driver memory only. Note

[GitHub] [spark] HyukjinKwon commented on a change in pull request #33154: [SPARK-35949][CORE]Add `is-server` arg for to prevent closing spark context when starting as a server.

2021-07-03 Thread GitBox
HyukjinKwon commented on a change in pull request #33154: URL: https://github.com/apache/spark/pull/33154#discussion_r663433603 ## File path: python/pyspark/pandas/tests/test_stats.py ## @@ -283,7 +283,7 @@ def test_cov_corr_meta(self): index=pd.Index([1, 2, 3]

[GitHub] [spark] HyukjinKwon commented on a change in pull request #33188: [SPARK-35989][SQL] Do not remove REPARTITION_BY_NUM shuffle if AQE is enabled

2021-07-03 Thread GitBox
HyukjinKwon commented on a change in pull request #33188: URL: https://github.com/apache/spark/pull/33188#discussion_r663433014 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/exchange/EnsureRequirementsSuite.scala ## @@ -133,4 +134,27 @@ class EnsureRequi

[GitHub] [spark] HyukjinKwon commented on a change in pull request #33188: [SPARK-35989][SQL] Do not remove REPARTITION_BY_NUM shuffle if AQE is enabled

2021-07-03 Thread GitBox
HyukjinKwon commented on a change in pull request #33188: URL: https://github.com/apache/spark/pull/33188#discussion_r663432910 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/exchange/EnsureRequirementsSuite.scala ## @@ -133,4 +134,27 @@ class EnsureRequi

[GitHub] [spark] HyukjinKwon commented on pull request #33188: [SPARK-35989][SQL] Do not remove REPARTITION_BY_NUM shuffle if AQE is enabled

2021-07-03 Thread GitBox
HyukjinKwon commented on pull request #33188: URL: https://github.com/apache/spark/pull/33188#issuecomment-873499590 @ulysses-you mind updating PR description and title too? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33203: [SPARK-36007][INFRA] Failed to run benchmark in GA

2021-07-03 Thread GitBox
AmplabJenkins removed a comment on pull request #33203: URL: https://github.com/apache/spark/pull/33203#issuecomment-873379366 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [spark] SparkQA commented on pull request #33203: [SPARK-36007][INFRA] Failed to run benchmark in GA

2021-07-03 Thread GitBox
SparkQA commented on pull request #33203: URL: https://github.com/apache/spark/pull/33203#issuecomment-873499056 **[Test build #140615 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140615/testReport)** for PR 33203 at commit [`e635b8e`](https://github.com

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32944: [SPARK-35794][SQL] Allow custom plugin for AQE cost evaluator

2021-07-03 Thread GitBox
HyukjinKwon commented on a change in pull request #32944: URL: https://github.com/apache/spark/pull/32944#discussion_r663432340 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala ## @@ -130,7 +130,11 @@ case class Adaptive

[GitHub] [spark] HyukjinKwon closed pull request #33178: [SPARK-35980][CORE] ThreadAudit logs whether thread is daemon

2021-07-03 Thread GitBox
HyukjinKwon closed pull request #33178: URL: https://github.com/apache/spark/pull/33178 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-un

[GitHub] [spark] HyukjinKwon commented on pull request #33178: [SPARK-35980][CORE] ThreadAudit logs whether thread is daemon

2021-07-03 Thread GitBox
HyukjinKwon commented on pull request #33178: URL: https://github.com/apache/spark/pull/33178#issuecomment-873498265 Merged to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [spark] HyukjinKwon commented on pull request #33201: [SPARK-36005][SQL] The canCast method of type of char/varchar is modified to be consistent with StringType

2021-07-03 Thread GitBox
HyukjinKwon commented on pull request #33201: URL: https://github.com/apache/spark/pull/33201#issuecomment-873498125 @zheniantoushipashi does it cause any user-facing behaviour change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] HyukjinKwon commented on pull request #33203: [SPARK-36007][INFRA] Failed to run benchmark in GA

2021-07-03 Thread GitBox
HyukjinKwon commented on pull request #33203: URL: https://github.com/apache/spark/pull/33203#issuecomment-873497353 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [spark] HyukjinKwon commented on a change in pull request #33203: [SPARK-36007][INFRA] Failed to run benchmark in GA

2021-07-03 Thread GitBox
HyukjinKwon commented on a change in pull request #33203: URL: https://github.com/apache/spark/pull/33203#discussion_r663430840 ## File path: .github/workflows/benchmark.yml ## @@ -85,6 +85,7 @@ jobs: # In benchmark, we use local as master so set driver memory only. No

[GitHub] [spark] HyukjinKwon edited a comment on pull request #33185: [SPARK-35986][PYSPARK] Fix type hint for RDD.histogram's buckets

2021-07-03 Thread GitBox
HyukjinKwon edited a comment on pull request #33185: URL: https://github.com/apache/spark/pull/33185#issuecomment-873496182 Merged to master, branch-3.2 and branch-3.1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [spark] HyukjinKwon edited a comment on pull request #33185: [SPARK-35986][PYSPARK] Fix type hint for RDD.histogram's buckets

2021-07-03 Thread GitBox
HyukjinKwon edited a comment on pull request #33185: URL: https://github.com/apache/spark/pull/33185#issuecomment-873496182 Merged to master, branch-3.2, branch-3.1 and branch-3.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [spark] HyukjinKwon closed pull request #33185: [SPARK-35986][PYSPARK] Fix type hint for RDD.histogram's buckets

2021-07-03 Thread GitBox
HyukjinKwon closed pull request #33185: URL: https://github.com/apache/spark/pull/33185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-un

[GitHub] [spark] HyukjinKwon commented on pull request #33185: [SPARK-35986][PYSPARK] Fix type hint for RDD.histogram's buckets

2021-07-03 Thread GitBox
HyukjinKwon commented on pull request #33185: URL: https://github.com/apache/spark/pull/33185#issuecomment-873496182 Merged to master and branch-3.2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] zhouyejoe commented on a change in pull request #33078: [SPARK-35546][Shuffle] Enable push-based shuffle when multiple app attempts are enabled and manage concurrent access to the sta

2021-07-03 Thread GitBox
zhouyejoe commented on a change in pull request #33078: URL: https://github.com/apache/spark/pull/33078#discussion_r663428118 ## File path: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java ## @@ -403,38 +394,78 @@ public MergeS

[GitHub] [spark] zhouyejoe commented on a change in pull request #33078: [SPARK-35546][Shuffle] Enable push-based shuffle when multiple app attempts are enabled and manage concurrent access to the sta

2021-07-03 Thread GitBox
zhouyejoe commented on a change in pull request #33078: URL: https://github.com/apache/spark/pull/33078#discussion_r663427925 ## File path: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java ## @@ -112,34 +116,48 @@ public Shuffl

[GitHub] [spark] zhouyejoe commented on a change in pull request #33078: [SPARK-35546][Shuffle] Enable push-based shuffle when multiple app attempts are enabled and manage concurrent access to the sta

2021-07-03 Thread GitBox
zhouyejoe commented on a change in pull request #33078: URL: https://github.com/apache/spark/pull/33078#discussion_r663427910 ## File path: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java ## @@ -403,38 +394,78 @@ public MergeS

[GitHub] [spark] github-actions[bot] commented on pull request #29935: [SPARK-33055][PYTHON][SQL] Add Python CalendarIntervalType

2021-07-03 Thread GitBox
github-actions[bot] commented on pull request #29935: URL: https://github.com/apache/spark/pull/29935#issuecomment-873487919 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue ma

[GitHub] [spark] github-actions[bot] closed pull request #31598: [SPARK-34478][SQL] When build SparkSession, we should check config keys

2021-07-03 Thread GitBox
github-actions[bot] closed pull request #31598: URL: https://github.com/apache/spark/pull/31598 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: re

[GitHub] [spark] SparkQA commented on pull request #33200: [SPARK-36006][SQL] Migrate ALTER TABLE ... ADD/REPLACE COLUMNS commands to use UnresolvedTable to resolve the identifier

2021-07-03 Thread GitBox
SparkQA commented on pull request #33200: URL: https://github.com/apache/spark/pull/33200#issuecomment-873446417 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45127/ -- This is an automated message from the A

[GitHub] [spark] AmplabJenkins commented on pull request #33200: [SPARK-36006][SQL] Migrate ALTER TABLE ... ADD/REPLACE COLUMNS commands to use UnresolvedTable to resolve the identifier

2021-07-03 Thread GitBox
AmplabJenkins commented on pull request #33200: URL: https://github.com/apache/spark/pull/33200#issuecomment-873446425 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45127/ -- T

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33200: [SPARK-36006][SQL] Migrate ALTER TABLE ... ADD/REPLACE COLUMNS commands to use UnresolvedTable to resolve the identifier

2021-07-03 Thread GitBox
AmplabJenkins removed a comment on pull request #33200: URL: https://github.com/apache/spark/pull/33200#issuecomment-873437050 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140614/ -

[GitHub] [spark] SparkQA commented on pull request #33200: [SPARK-36006][SQL] Migrate ALTER TABLE ... ADD/REPLACE COLUMNS commands to use UnresolvedTable to resolve the identifier

2021-07-03 Thread GitBox
SparkQA commented on pull request #33200: URL: https://github.com/apache/spark/pull/33200#issuecomment-873441599 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45127/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA removed a comment on pull request #33200: [SPARK-36006][SQL] Migrate ALTER TABLE ... ADD/REPLACE COLUMNS commands to use UnresolvedTable to resolve the identifier

2021-07-03 Thread GitBox
SparkQA removed a comment on pull request #33200: URL: https://github.com/apache/spark/pull/33200#issuecomment-873436260 **[Test build #140614 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140614/testReport)** for PR 33200 at commit [`0c83e37`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #33200: [SPARK-36006][SQL] Migrate ALTER TABLE ... ADD/REPLACE COLUMNS commands to use UnresolvedTable to resolve the identifier

2021-07-03 Thread GitBox
AmplabJenkins commented on pull request #33200: URL: https://github.com/apache/spark/pull/33200#issuecomment-873437050 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140614/ -- This

[GitHub] [spark] SparkQA commented on pull request #33200: [SPARK-36006][SQL] Migrate ALTER TABLE ... ADD/REPLACE COLUMNS commands to use UnresolvedTable to resolve the identifier

2021-07-03 Thread GitBox
SparkQA commented on pull request #33200: URL: https://github.com/apache/spark/pull/33200#issuecomment-873437041 **[Test build #140614 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140614/testReport)** for PR 33200 at commit [`0c83e37`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33183: [SPARK-35972][SQL] When replace ExtractValue in NestedColumnAliasing we should use semanticEquals

2021-07-03 Thread GitBox
AmplabJenkins removed a comment on pull request #33183: URL: https://github.com/apache/spark/pull/33183#issuecomment-873294316 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140596/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33200: [SPARK-36006][SQL] Migrate ALTER TABLE ... ADD/REPLACE COLUMNS commands to use UnresolvedTable to resolve the identifier

2021-07-03 Thread GitBox
AmplabJenkins removed a comment on pull request #33200: URL: https://github.com/apache/spark/pull/33200#issuecomment-873358952 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [spark] SparkQA commented on pull request #33200: [SPARK-36006][SQL] Migrate ALTER TABLE ... ADD/REPLACE COLUMNS commands to use UnresolvedTable to resolve the identifier

2021-07-03 Thread GitBox
SparkQA commented on pull request #33200: URL: https://github.com/apache/spark/pull/33200#issuecomment-873436260 **[Test build #140614 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140614/testReport)** for PR 33200 at commit [`0c83e37`](https://github.com

[GitHub] [spark] viirya closed pull request #33142: [SPARK-35940][SQL] Refactor EquivalentExpressions to make it more efficient

2021-07-03 Thread GitBox
viirya closed pull request #33142: URL: https://github.com/apache/spark/pull/33142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubsc

[GitHub] [spark] viirya commented on pull request #33142: [SPARK-35940][SQL] Refactor EquivalentExpressions to make it more efficient

2021-07-03 Thread GitBox
viirya commented on pull request #33142: URL: https://github.com/apache/spark/pull/33142#issuecomment-873424131 Thanks! Merging to master/branch-3.2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33182: [SPARK-35984][SQL] Config to force applying shuffled hash join

2021-07-03 Thread GitBox
AmplabJenkins removed a comment on pull request #33182: URL: https://github.com/apache/spark/pull/33182#issuecomment-873410235 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140613/ -

[GitHub] [spark] AmplabJenkins commented on pull request #33182: [SPARK-35984][SQL] Config to force applying shuffled hash join

2021-07-03 Thread GitBox
AmplabJenkins commented on pull request #33182: URL: https://github.com/apache/spark/pull/33182#issuecomment-873410235 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140613/ -- This

[GitHub] [spark] SparkQA removed a comment on pull request #33182: [SPARK-35984][SQL] Config to force applying shuffled hash join

2021-07-03 Thread GitBox
SparkQA removed a comment on pull request #33182: URL: https://github.com/apache/spark/pull/33182#issuecomment-873373461 **[Test build #140613 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140613/testReport)** for PR 33182 at commit [`f3474a2`](https://gi

[GitHub] [spark] SparkQA commented on pull request #33182: [SPARK-35984][SQL] Config to force applying shuffled hash join

2021-07-03 Thread GitBox
SparkQA commented on pull request #33182: URL: https://github.com/apache/spark/pull/33182#issuecomment-873407812 **[Test build #140613 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140613/testReport)** for PR 33182 at commit [`f3474a2`](https://github.co

[GitHub] [spark] gengliangwang commented on pull request #33196: [SPARK-35996][BUILD] Setting version to 3.3.0-SNAPSHOT

2021-07-03 Thread GitBox
gengliangwang commented on pull request #33196: URL: https://github.com/apache/spark/pull/33196#issuecomment-873405034 @dongjoon-hyun Thank you so much, have fun on your vacation! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33182: [SPARK-35984][SQL] Config to force applying shuffled hash join

2021-07-03 Thread GitBox
AmplabJenkins removed a comment on pull request #33182: URL: https://github.com/apache/spark/pull/33182#issuecomment-873386756 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45126/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33188: [SPARK-35989][SQL] Do not remove REPARTITION_BY_NUM shuffle if AQE is enabled

2021-07-03 Thread GitBox
AmplabJenkins removed a comment on pull request #33188: URL: https://github.com/apache/spark/pull/33188#issuecomment-873386755 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140610/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32959: [SPARK-35780][SQL] Support DATE/TIMESTAMP literals across the full range

2021-07-03 Thread GitBox
AmplabJenkins removed a comment on pull request #32959: URL: https://github.com/apache/spark/pull/32959#issuecomment-873386754 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [spark] AmplabJenkins commented on pull request #33188: [SPARK-35989][SQL] Do not remove REPARTITION_BY_NUM shuffle if AQE is enabled

2021-07-03 Thread GitBox
AmplabJenkins commented on pull request #33188: URL: https://github.com/apache/spark/pull/33188#issuecomment-873386755 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140610/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32959: [SPARK-35780][SQL] Support DATE/TIMESTAMP literals across the full range

2021-07-03 Thread GitBox
AmplabJenkins commented on pull request #32959: URL: https://github.com/apache/spark/pull/32959#issuecomment-873386757 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [spark] AmplabJenkins commented on pull request #33182: [SPARK-35984][SQL] Config to force applying shuffled hash join

2021-07-03 Thread GitBox
AmplabJenkins commented on pull request #33182: URL: https://github.com/apache/spark/pull/33182#issuecomment-873386756 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45126/ -- T

[GitHub] [spark] SparkQA removed a comment on pull request #32959: [SPARK-35780][SQL] Support DATE/TIMESTAMP literals across the full range

2021-07-03 Thread GitBox
SparkQA removed a comment on pull request #32959: URL: https://github.com/apache/spark/pull/32959#issuecomment-873372513 **[Test build #140612 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140612/testReport)** for PR 32959 at commit [`e94885c`](https://gi

[GitHub] [spark] SparkQA commented on pull request #32959: [SPARK-35780][SQL] Support DATE/TIMESTAMP literals across the full range

2021-07-03 Thread GitBox
SparkQA commented on pull request #32959: URL: https://github.com/apache/spark/pull/32959#issuecomment-873386207 **[Test build #140612 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140612/testReport)** for PR 32959 at commit [`e94885c`](https://github.co

[GitHub] [spark] zero323 removed a comment on pull request #33185: [SPARK-35986][PYSPARK] Fix type hint for RDD.histogram's buckets

2021-07-03 Thread GitBox
zero323 removed a comment on pull request #33185: URL: https://github.com/apache/spark/pull/33185#issuecomment-873383580 ok to test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [spark] zero323 commented on pull request #33185: [SPARK-35986][PYSPARK] Fix type hint for RDD.histogram's buckets

2021-07-03 Thread GitBox
zero323 commented on pull request #33185: URL: https://github.com/apache/spark/pull/33185#issuecomment-873383580 ok to test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [spark] SparkQA commented on pull request #33182: [SPARK-35984][SQL] Config to force applying shuffled hash join

2021-07-03 Thread GitBox
SparkQA commented on pull request #33182: URL: https://github.com/apache/spark/pull/33182#issuecomment-873382869 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45126/ -- This is an automated message from the A

[GitHub] [spark] SparkQA removed a comment on pull request #33188: [SPARK-35989][SQL] Do not remove REPARTITION_BY_NUM shuffle if AQE is enabled

2021-07-03 Thread GitBox
SparkQA removed a comment on pull request #33188: URL: https://github.com/apache/spark/pull/33188#issuecomment-873352553 **[Test build #140610 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140610/testReport)** for PR 33188 at commit [`b2822d5`](https://gi

[GitHub] [spark] SparkQA commented on pull request #33188: [SPARK-35989][SQL] Do not remove REPARTITION_BY_NUM shuffle if AQE is enabled

2021-07-03 Thread GitBox
SparkQA commented on pull request #33188: URL: https://github.com/apache/spark/pull/33188#issuecomment-873382395 **[Test build #140610 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140610/testReport)** for PR 33188 at commit [`b2822d5`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #32959: [SPARK-35780][SQL] Support DATE/TIMESTAMP literals across the full range

2021-07-03 Thread GitBox
SparkQA commented on pull request #32959: URL: https://github.com/apache/spark/pull/32959#issuecomment-873382245 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45125/ -- This is an automated message from the A

[GitHub] [spark] AmplabJenkins commented on pull request #33203: [SPARK-36007][INFRA] Failed to run benchmark in GA

2021-07-03 Thread GitBox
AmplabJenkins commented on pull request #33203: URL: https://github.com/apache/spark/pull/33203#issuecomment-873379366 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33101: [SPARK-35907][CORE] Instead of File#mkdirs, Files#createDirectories is expected.

2021-07-03 Thread GitBox
AmplabJenkins removed a comment on pull request #33101: URL: https://github.com/apache/spark/pull/33101#issuecomment-873379231 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140611/ -

[GitHub] [spark] AmplabJenkins commented on pull request #33101: [SPARK-35907][CORE] Instead of File#mkdirs, Files#createDirectories is expected.

2021-07-03 Thread GitBox
AmplabJenkins commented on pull request #33101: URL: https://github.com/apache/spark/pull/33101#issuecomment-873379231 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140611/ -- This

[GitHub] [spark] SparkQA commented on pull request #33182: [SPARK-35984][SQL] Config to force applying shuffled hash join

2021-07-03 Thread GitBox
SparkQA commented on pull request #33182: URL: https://github.com/apache/spark/pull/33182#issuecomment-873378994 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45126/ -- This is an automated message from the Apache

[GitHub] [spark] pingsutw opened a new pull request #33203: [SPARK-36007][INFRA] Failed to run benchmark in GA

2021-07-03 Thread GitBox
pingsutw opened a new pull request #33203: URL: https://github.com/apache/spark/pull/33203 ### What changes were proposed in this pull request? When I running the benchmark in GA, I met the below error. https://github.com/pingsutw/spark/runs/2867617238?check_suite_f

[GitHub] [spark] SparkQA commented on pull request #32959: [SPARK-35780][SQL] Support DATE/TIMESTAMP literals across the full range

2021-07-03 Thread GitBox
SparkQA commented on pull request #32959: URL: https://github.com/apache/spark/pull/32959#issuecomment-873377950 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45125/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA removed a comment on pull request #33101: [SPARK-35907][CORE] Instead of File#mkdirs, Files#createDirectories is expected.

2021-07-03 Thread GitBox
SparkQA removed a comment on pull request #33101: URL: https://github.com/apache/spark/pull/33101#issuecomment-873357656 **[Test build #140611 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140611/testReport)** for PR 33101 at commit [`6d123ba`](https://gi

[GitHub] [spark] SparkQA commented on pull request #33101: [SPARK-35907][CORE] Instead of File#mkdirs, Files#createDirectories is expected.

2021-07-03 Thread GitBox
SparkQA commented on pull request #33101: URL: https://github.com/apache/spark/pull/33101#issuecomment-873375348 **[Test build #140611 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140611/testReport)** for PR 33101 at commit [`6d123ba`](https://github.co

[GitHub] [spark] SparkQA removed a comment on pull request #33200: [SPARK-36006][SQL] Migrate ALTER TABLE ... ADD/REPLACE COLUMNS commands to use UnresolvedTable to resolve the identifier

2021-07-03 Thread GitBox
SparkQA removed a comment on pull request #33200: URL: https://github.com/apache/spark/pull/33200#issuecomment-873351326 **[Test build #140609 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140609/testReport)** for PR 33200 at commit [`f729d8d`](https://gi

[GitHub] [spark] AmplabJenkins commented on pull request #33200: [SPARK-36006][SQL] Migrate ALTER TABLE ... ADD/REPLACE COLUMNS commands to use UnresolvedTable to resolve the identifier

2021-07-03 Thread GitBox
AmplabJenkins commented on pull request #33200: URL: https://github.com/apache/spark/pull/33200#issuecomment-873373911 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140609/ -- This

[GitHub] [spark] SparkQA commented on pull request #33200: [SPARK-36006][SQL] Migrate ALTER TABLE ... ADD/REPLACE COLUMNS commands to use UnresolvedTable to resolve the identifier

2021-07-03 Thread GitBox
SparkQA commented on pull request #33200: URL: https://github.com/apache/spark/pull/33200#issuecomment-873373753 **[Test build #140609 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140609/testReport)** for PR 33200 at commit [`f729d8d`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #33182: [SPARK-35984][SQL] Config to force applying shuffled hash join

2021-07-03 Thread GitBox
SparkQA commented on pull request #33182: URL: https://github.com/apache/spark/pull/33182#issuecomment-873373461 **[Test build #140613 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140613/testReport)** for PR 33182 at commit [`f3474a2`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #32959: [SPARK-35780][SQL] Support DATE/TIMESTAMP literals across the full range

2021-07-03 Thread GitBox
SparkQA commented on pull request #32959: URL: https://github.com/apache/spark/pull/32959#issuecomment-873372513 **[Test build #140612 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140612/testReport)** for PR 32959 at commit [`e94885c`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33101: [SPARK-35907][CORE] Instead of File#mkdirs, Files#createDirectories is expected.

2021-07-03 Thread GitBox
AmplabJenkins removed a comment on pull request #33101: URL: https://github.com/apache/spark/pull/33101#issuecomment-873366551 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45124/

[GitHub] [spark] SparkQA commented on pull request #33101: [SPARK-35907][CORE] Instead of File#mkdirs, Files#createDirectories is expected.

2021-07-03 Thread GitBox
SparkQA commented on pull request #33101: URL: https://github.com/apache/spark/pull/33101#issuecomment-873366545 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45124/ -- This is an automated message from the A

[GitHub] [spark] AmplabJenkins commented on pull request #33101: [SPARK-35907][CORE] Instead of File#mkdirs, Files#createDirectories is expected.

2021-07-03 Thread GitBox
AmplabJenkins commented on pull request #33101: URL: https://github.com/apache/spark/pull/33101#issuecomment-873366551 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45124/ -- T

[GitHub] [spark] zhaomin1423 closed pull request #33202: remove redundant code

2021-07-03 Thread GitBox
zhaomin1423 closed pull request #33202: URL: https://github.com/apache/spark/pull/33202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-un

[GitHub] [spark] zhaomin1423 opened a new pull request #33202: remove redundant code

2021-07-03 Thread GitBox
zhaomin1423 opened a new pull request #33202: URL: https://github.com/apache/spark/pull/33202 ### What changes were proposed in this pull request? remove redundant code ### Why are the changes needed? keep the code style and avoid avoid unnecessary opera

[GitHub] [spark] AmplabJenkins commented on pull request #33201: [SPARK-36005][SQL] The canCast method of type of char/varchar is modified to be consistent with StringType

2021-07-03 Thread GitBox
AmplabJenkins commented on pull request #33201: URL: https://github.com/apache/spark/pull/33201#issuecomment-873364769 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [spark] zheniantoushipashi opened a new pull request #33201: [SPARK-36005][SQL] The canCast method of type of char/varchar is modified to be consistent with StringType

2021-07-03 Thread GitBox
zheniantoushipashi opened a new pull request #33201: URL: https://github.com/apache/spark/pull/33201 ### What changes were proposed in this pull request? The canCast method of type of char/varchar is modified to be consistent with StringType the method cast will ch

[GitHub] [spark] Peng-Lei commented on a change in pull request #33175: [SPARK-35973][SQL] DataSourceV2: Support SHOW CATALOGS

2021-07-03 Thread GitBox
Peng-Lei commented on a change in pull request #33175: URL: https://github.com/apache/spark/pull/33175#discussion_r663311232 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogManager.scala ## @@ -128,6 +128,10 @@ class CatalogManager(

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33188: [SPARK-35989][SQL] Do not remove REPARTITION_BY_NUM shuffle if AQE is enabled

2021-07-03 Thread GitBox
AmplabJenkins removed a comment on pull request #33188: URL: https://github.com/apache/spark/pull/33188#issuecomment-873364246 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45123/

  1   2   >