[GitHub] [spark] SparkQA commented on pull request #33640: [SPARK-36409][SQL][TESTS] Splitting test cases from datetime.sql

2021-08-04 Thread GitBox
SparkQA commented on pull request #33640: URL: https://github.com/apache/spark/pull/33640#issuecomment-893215751 **[Test build #142072 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142072/testReport)** for PR 33640 at commit [`3d8c2a9`](https://github.com

[GitHub] [spark] cloud-fan commented on a change in pull request #33535: [SPARK-36108][SQL] Refactor first set of 20 query parsing errors to use error classes

2021-08-04 Thread GitBox
cloud-fan commented on a change in pull request #33535: URL: https://github.com/apache/spark/pull/33535#discussion_r683180773 ## File path: core/src/main/resources/error/error-classes.json ## @@ -29,10 +41,30 @@ "message" : [ "Invalid pivot column '%s'. Pivot columns must

[GitHub] [spark] LuciferYang edited a comment on pull request #33556: [SPARK-36324][CORE] Replace revertPartialWritesAndClose with close in ExternalSorter.spill and ExternalAppendOnlyMap.spill

2021-08-04 Thread GitBox
LuciferYang edited a comment on pull request #33556: URL: https://github.com/apache/spark/pull/33556#issuecomment-893215236 I check the code again, and a new discovery was synchronized to you @mridulm @Ngone51 The status of `DiskBlockObjectWriter` is lazy initializing, the `initial

[GitHub] [spark] LuciferYang commented on pull request #33556: [SPARK-36324][CORE] Replace revertPartialWritesAndClose with close in ExternalSorter.spill and ExternalAppendOnlyMap.spill

2021-08-04 Thread GitBox
LuciferYang commented on pull request #33556: URL: https://github.com/apache/spark/pull/33556#issuecomment-893215236 I check the code again, and a new discovery was synchronized to you @mridulm @Ngone51 The status of `DiskBlockObjectWriter` is lazy initializing, the 'initialize()'

[GitHub] [spark] cloud-fan commented on a change in pull request #33640: [SPARK-36409][SQL][TESTS] Splitting test cases from datetime.sql

2021-08-04 Thread GitBox
cloud-fan commented on a change in pull request #33640: URL: https://github.com/apache/spark/pull/33640#discussion_r683179571 ## File path: sql/core/src/test/resources/sql-tests/inputs/timestamp.sql ## @@ -0,0 +1,104 @@ +-- timestamp literals, functions and operations + +select

[GitHub] [spark] AmplabJenkins commented on pull request #33649: [SPARK-36423][SHUFFLE] Randomize order of blocks in a push request to improve block merge ratio for push-based shuffle

2021-08-04 Thread GitBox
AmplabJenkins commented on pull request #33649: URL: https://github.com/apache/spark/pull/33649#issuecomment-893213789 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [spark] AmplabJenkins commented on pull request #33588: [SPARK-36346][SQL] Support TimestampNTZ type in Orc file source

2021-08-04 Thread GitBox
AmplabJenkins commented on pull request #33588: URL: https://github.com/apache/spark/pull/33588#issuecomment-893213590 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142059/ -- This

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33588: [SPARK-36346][SQL] Support TimestampNTZ type in Orc file source

2021-08-04 Thread GitBox
AmplabJenkins removed a comment on pull request #33588: URL: https://github.com/apache/spark/pull/33588#issuecomment-893213590 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142059/ -

[GitHub] [spark] SparkQA removed a comment on pull request #33588: [SPARK-36346][SQL] Support TimestampNTZ type in Orc file source

2021-08-04 Thread GitBox
SparkQA removed a comment on pull request #33588: URL: https://github.com/apache/spark/pull/33588#issuecomment-893112141 **[Test build #142059 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142059/testReport)** for PR 33588 at commit [`0bd85eb`](https://gi

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33646: [SPARK-36388][PYTHON] Fix DataFrame groupby-rolling to follow pandas 1.3

2021-08-04 Thread GitBox
AmplabJenkins removed a comment on pull request #33646: URL: https://github.com/apache/spark/pull/33646#issuecomment-893213047 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46576/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33647: [SPARK-36421][SQL] Validate all SQL configs to prevent from wrong use for ConfigEntry in doc fields

2021-08-04 Thread GitBox
AmplabJenkins removed a comment on pull request #33647: URL: https://github.com/apache/spark/pull/33647#issuecomment-893213042 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46575/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33636: [SPARK-36414][SQL] Disable timeout for BroadcastQueryStageExec in AQE

2021-08-04 Thread GitBox
AmplabJenkins removed a comment on pull request #33636: URL: https://github.com/apache/spark/pull/33636#issuecomment-893213043 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142057/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33635: [SPARK-36410][CORE][SQL][STRUCTURED STREAMING][EXAMPLES] Replace anonymous classes with lambda expressions

2021-08-04 Thread GitBox
AmplabJenkins removed a comment on pull request #33635: URL: https://github.com/apache/spark/pull/33635#issuecomment-893213041 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46577/

[GitHub] [spark] AmplabJenkins commented on pull request #33636: [SPARK-36414][SQL] Disable timeout for BroadcastQueryStageExec in AQE

2021-08-04 Thread GitBox
AmplabJenkins commented on pull request #33636: URL: https://github.com/apache/spark/pull/33636#issuecomment-893213043 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142057/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #33647: [SPARK-36421][SQL] Validate all SQL configs to prevent from wrong use for ConfigEntry in doc fields

2021-08-04 Thread GitBox
AmplabJenkins commented on pull request #33647: URL: https://github.com/apache/spark/pull/33647#issuecomment-893213042 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46575/ -- T

[GitHub] [spark] AmplabJenkins commented on pull request #33646: [SPARK-36388][PYTHON] Fix DataFrame groupby-rolling to follow pandas 1.3

2021-08-04 Thread GitBox
AmplabJenkins commented on pull request #33646: URL: https://github.com/apache/spark/pull/33646#issuecomment-893213047 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46576/ -- T

[GitHub] [spark] AmplabJenkins commented on pull request #33635: [SPARK-36410][CORE][SQL][STRUCTURED STREAMING][EXAMPLES] Replace anonymous classes with lambda expressions

2021-08-04 Thread GitBox
AmplabJenkins commented on pull request #33635: URL: https://github.com/apache/spark/pull/33635#issuecomment-893213041 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46577/ -- T

[GitHub] [spark] SparkQA commented on pull request #33588: [SPARK-36346][SQL] Support TimestampNTZ type in Orc file source

2021-08-04 Thread GitBox
SparkQA commented on pull request #33588: URL: https://github.com/apache/spark/pull/33588#issuecomment-893212680 **[Test build #142059 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142059/testReport)** for PR 33588 at commit [`0bd85eb`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #33615: [SPARK-36374][SHUFFLE][DOC] Push-based shuffle high level user documentation

2021-08-04 Thread GitBox
SparkQA commented on pull request #33615: URL: https://github.com/apache/spark/pull/33615#issuecomment-893208087 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46578/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #33583: [WIP][SPARK-36352][SQL] Spark should check result plan's output schema name

2021-08-04 Thread GitBox
SparkQA commented on pull request #33583: URL: https://github.com/apache/spark/pull/33583#issuecomment-893208024 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46579/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #33647: [SPARK-36421][SQL] Validate all SQL configs to prevent from wrong use for ConfigEntry in doc fields

2021-08-04 Thread GitBox
SparkQA commented on pull request #33647: URL: https://github.com/apache/spark/pull/33647#issuecomment-893207414 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46575/ -- This is an automated message from the A

[GitHub] [spark] SparkQA commented on pull request #33635: [SPARK-36410][CORE][SQL][STRUCTURED STREAMING][EXAMPLES] Replace anonymous classes with lambda expressions

2021-08-04 Thread GitBox
SparkQA commented on pull request #33635: URL: https://github.com/apache/spark/pull/33635#issuecomment-893207242 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46577/ -- This is an automated message from the A

[GitHub] [spark] SparkQA commented on pull request #33646: [SPARK-36388][PYTHON] Fix DataFrame groupby-rolling to follow pandas 1.3

2021-08-04 Thread GitBox
SparkQA commented on pull request #33646: URL: https://github.com/apache/spark/pull/33646#issuecomment-893207228 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46576/ -- This is an automated message from the A

[GitHub] [spark] cloud-fan commented on a change in pull request #33640: [SPARK-36409][SQL][TESTS] Splitting test cases from datetime.sql

2021-08-04 Thread GitBox
cloud-fan commented on a change in pull request #33640: URL: https://github.com/apache/spark/pull/33640#discussion_r683170606 ## File path: sql/core/src/test/resources/sql-tests/results/ansi/date.sql.out ## @@ -0,0 +1,536 @@ +-- Automatically generated by SQLQueryTestSuite +--

[GitHub] [spark] cloud-fan commented on a change in pull request #33640: [SPARK-36409][SQL][TESTS] Splitting test cases from datetime.sql

2021-08-04 Thread GitBox
cloud-fan commented on a change in pull request #33640: URL: https://github.com/apache/spark/pull/33640#discussion_r683168358 ## File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql ## @@ -1,295 +0,0 @@ --- date time functions - --- [SPARK-31710] TIMESTAMP_SECON

[GitHub] [spark] cloud-fan commented on a change in pull request #33640: [SPARK-36409][SQL][TESTS] Splitting test cases from datetime.sql

2021-08-04 Thread GitBox
cloud-fan commented on a change in pull request #33640: URL: https://github.com/apache/spark/pull/33640#discussion_r683168227 ## File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql ## @@ -1,295 +0,0 @@ --- date time functions - --- [SPARK-31710] TIMESTAMP_SECON

[GitHub] [spark] Victsm commented on pull request #33649: [SPARK-36423][SHUFFLE] Randomize order of blocks in a push request to improve block merge ratio for push-based shuffle

2021-08-04 Thread GitBox
Victsm commented on pull request #33649: URL: https://github.com/apache/spark/pull/33649#issuecomment-893200790 @mridulm @Ngone51 @otterc @venkata91 @zhouyejoe @zhuqi-lucas Per comment in https://github.com/apache/spark/pull/33613#discussion_r683101189, move this change into a separate

[GitHub] [spark] Victsm opened a new pull request #33649: [SPARK-36423][SHUFFLE] Randomize order of blocks in a push request to improve block merge ratio for push-based shuffle

2021-08-04 Thread GitBox
Victsm opened a new pull request #33649: URL: https://github.com/apache/spark/pull/33649 ### What changes were proposed in this pull request? On the client side, we are currently randomizing the order of push requests before processing each request. In addition we can fur

[GitHub] [spark] SparkQA removed a comment on pull request #33636: [SPARK-36414][SQL] Disable timeout for BroadcastQueryStageExec in AQE

2021-08-04 Thread GitBox
SparkQA removed a comment on pull request #33636: URL: https://github.com/apache/spark/pull/33636#issuecomment-893101918 **[Test build #142057 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142057/testReport)** for PR 33636 at commit [`b5870e6`](https://gi

[GitHub] [spark] SparkQA commented on pull request #33636: [SPARK-36414][SQL] Disable timeout for BroadcastQueryStageExec in AQE

2021-08-04 Thread GitBox
SparkQA commented on pull request #33636: URL: https://github.com/apache/spark/pull/33636#issuecomment-893198288 **[Test build #142057 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142057/testReport)** for PR 33636 at commit [`b5870e6`](https://github.co

[GitHub] [spark] cloud-fan commented on a change in pull request #33640: [SPARK-36409][SQL][TESTS] Splitting test cases from datetime.sql

2021-08-04 Thread GitBox
cloud-fan commented on a change in pull request #33640: URL: https://github.com/apache/spark/pull/33640#discussion_r683161375 ## File path: sql/core/src/test/resources/sql-tests/inputs/date.sql ## @@ -0,0 +1,106 @@ +-- date literals, functions and operations + +select date '201

[GitHub] [spark] beliefer commented on a change in pull request #33640: [SPARK-36409][SQL][TESTS] Splitting test cases from datetime.sql

2021-08-04 Thread GitBox
beliefer commented on a change in pull request #33640: URL: https://github.com/apache/spark/pull/33640#discussion_r683159860 ## File path: sql/core/src/test/resources/sql-tests/results/timestampNTZ/timestamp.sql.out ## @@ -0,0 +1,579 @@ +-- Automatically generated by SQLQueryT

[GitHub] [spark] SparkQA commented on pull request #33583: [WIP][SPARK-36352][SQL] Spark should check result plan's output schema name

2021-08-04 Thread GitBox
SparkQA commented on pull request #33583: URL: https://github.com/apache/spark/pull/33583#issuecomment-893195693 **[Test build #142071 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142071/testReport)** for PR 33583 at commit [`35013a5`](https://github.com

[GitHub] [spark] gengliangwang commented on a change in pull request #33640: [SPARK-36409][SQL][TESTS] Splitting test cases from datetime.sql

2021-08-04 Thread GitBox
gengliangwang commented on a change in pull request #33640: URL: https://github.com/apache/spark/pull/33640#discussion_r683158809 ## File path: sql/core/src/test/resources/sql-tests/inputs/date.sql ## @@ -0,0 +1,106 @@ +-- date literals, functions and operations + +select date

[GitHub] [spark] SparkQA commented on pull request #33640: [SPARK-36409][SQL][TESTS] Splitting test cases from datetime.sql

2021-08-04 Thread GitBox
SparkQA commented on pull request #33640: URL: https://github.com/apache/spark/pull/33640#issuecomment-893195557 **[Test build #142070 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142070/testReport)** for PR 33640 at commit [`f3e90d9`](https://github.com

[GitHub] [spark] gengliangwang commented on a change in pull request #33640: [SPARK-36409][SQL][TESTS] Splitting test cases from datetime.sql

2021-08-04 Thread GitBox
gengliangwang commented on a change in pull request #33640: URL: https://github.com/apache/spark/pull/33640#discussion_r683158333 ## File path: sql/core/src/test/resources/sql-tests/inputs/date.sql ## @@ -0,0 +1,106 @@ +-- date literals, functions and operations + +select date

[GitHub] [spark] gengliangwang commented on a change in pull request #33640: [SPARK-36409][SQL][TESTS] Splitting test cases from datetime.sql

2021-08-04 Thread GitBox
gengliangwang commented on a change in pull request #33640: URL: https://github.com/apache/spark/pull/33640#discussion_r683158241 ## File path: sql/core/src/test/resources/sql-tests/inputs/date.sql ## @@ -0,0 +1,106 @@ +-- date literals, functions and operations + +select date

[GitHub] [spark] gengliangwang commented on a change in pull request #33640: [SPARK-36409][SQL][TESTS] Splitting test cases from datetime.sql

2021-08-04 Thread GitBox
gengliangwang commented on a change in pull request #33640: URL: https://github.com/apache/spark/pull/33640#discussion_r683158166 ## File path: sql/core/src/test/resources/sql-tests/inputs/date.sql ## @@ -0,0 +1,106 @@ +-- date literals, functions and operations + +select date

[GitHub] [spark] gengliangwang commented on pull request #33640: [SPARK-36409][SQL][TESTS] Splitting test cases from datetime.sql

2021-08-04 Thread GitBox
gengliangwang commented on pull request #33640: URL: https://github.com/apache/spark/pull/33640#issuecomment-893193372 @cloud-fan I think we need to test timestamp_ntz under ANSI mode as well. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] SparkQA commented on pull request #33635: [SPARK-36410][CORE][SQL][STRUCTURED STREAMING][EXAMPLES] Replace anonymous classes with lambda expressions

2021-08-04 Thread GitBox
SparkQA commented on pull request #33635: URL: https://github.com/apache/spark/pull/33635#issuecomment-893189587 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46577/ -- This is an automated message from the Apache

[GitHub] [spark] gengliangwang commented on a change in pull request #33640: [SPARK-36409][SQL][TESTS] Splitting test cases from datetime.sql

2021-08-04 Thread GitBox
gengliangwang commented on a change in pull request #33640: URL: https://github.com/apache/spark/pull/33640#discussion_r683153484 ## File path: sql/core/src/test/resources/sql-tests/results/timestampNTZ/timestamp.sql.out ## @@ -0,0 +1,579 @@ +-- Automatically generated by SQLQ

[GitHub] [spark] SparkQA commented on pull request #33583: [WIP][SPARK-36352][SQL] Spark should check result plan's output schema name

2021-08-04 Thread GitBox
SparkQA commented on pull request #33583: URL: https://github.com/apache/spark/pull/33583#issuecomment-893186935 **[Test build #142069 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142069/testReport)** for PR 33583 at commit [`b5a80f6`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #33615: [SPARK-36374][SHUFFLE][DOC] Push-based shuffle high level user documentation

2021-08-04 Thread GitBox
SparkQA commented on pull request #33615: URL: https://github.com/apache/spark/pull/33615#issuecomment-893186864 **[Test build #142068 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142068/testReport)** for PR 33615 at commit [`fca6c0f`](https://github.com

[GitHub] [spark] cloud-fan commented on a change in pull request #33624: [SPARK-35881][SQL][FOLLOWUP] Add a boolean flag in AdaptiveSparkPlanExec to ask for columnar output

2021-08-04 Thread GitBox
cloud-fan commented on a change in pull request #33624: URL: https://github.com/apache/spark/pull/33624#discussion_r683149985 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala ## @@ -348,34 +344,24 @@ case class AdaptiveS

[GitHub] [spark] AmplabJenkins commented on pull request #33648: [SPARK-36420][Graphx] Use `isEmpty` to improve performance in Pregel‘s superstep

2021-08-04 Thread GitBox
AmplabJenkins commented on pull request #33648: URL: https://github.com/apache/spark/pull/33648#issuecomment-893185191 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33508: [SPARK-36058][K8S] Add support for statefulset APIs in K8s

2021-08-04 Thread GitBox
AmplabJenkins removed a comment on pull request #33508: URL: https://github.com/apache/spark/pull/33508#issuecomment-893184878 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46571/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33646: [SPARK-36388][PYTHON] Fix DataFrame groupby-rolling to follow pandas 1.3

2021-08-04 Thread GitBox
AmplabJenkins removed a comment on pull request #33646: URL: https://github.com/apache/spark/pull/33646#issuecomment-893184880 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142066/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33639: [SPARK-34952][SQL] Aggregate (Min/Max/Count) push down for Parquet

2021-08-04 Thread GitBox
AmplabJenkins removed a comment on pull request #33639: URL: https://github.com/apache/spark/pull/33639#issuecomment-893184876 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142054/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33638: [SPARK-36415][SQL][DOCS] Add docs for try_cast/try_add/try_divide

2021-08-04 Thread GitBox
AmplabJenkins removed a comment on pull request #33638: URL: https://github.com/apache/spark/pull/33638#issuecomment-893184879 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46574/

[GitHub] [spark] AmplabJenkins commented on pull request #33508: [SPARK-36058][K8S] Add support for statefulset APIs in K8s

2021-08-04 Thread GitBox
AmplabJenkins commented on pull request #33508: URL: https://github.com/apache/spark/pull/33508#issuecomment-893184878 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46571/ -- T

[GitHub] [spark] AmplabJenkins commented on pull request #33646: [SPARK-36388][PYTHON] Fix DataFrame groupby-rolling to follow pandas 1.3

2021-08-04 Thread GitBox
AmplabJenkins commented on pull request #33646: URL: https://github.com/apache/spark/pull/33646#issuecomment-893184880 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142066/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #33639: [SPARK-34952][SQL] Aggregate (Min/Max/Count) push down for Parquet

2021-08-04 Thread GitBox
AmplabJenkins commented on pull request #33639: URL: https://github.com/apache/spark/pull/33639#issuecomment-893184876 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142054/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #33638: [SPARK-36415][SQL][DOCS] Add docs for try_cast/try_add/try_divide

2021-08-04 Thread GitBox
AmplabJenkins commented on pull request #33638: URL: https://github.com/apache/spark/pull/33638#issuecomment-893184879 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46574/ -- T

[GitHub] [spark] SparkQA commented on pull request #33647: [SPARK-36421][SQL] Validate all SQL configs to prevent from wrong use for ConfigEntry in doc fields

2021-08-04 Thread GitBox
SparkQA commented on pull request #33647: URL: https://github.com/apache/spark/pull/33647#issuecomment-893182271 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46575/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #33646: [SPARK-36388][PYTHON] Fix DataFrame groupby-rolling to follow pandas 1.3

2021-08-04 Thread GitBox
SparkQA commented on pull request #33646: URL: https://github.com/apache/spark/pull/33646#issuecomment-893182196 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46576/ -- This is an automated message from the Apache

[GitHub] [spark] gengliangwang commented on a change in pull request #33640: [SPARK-36409][SQL][TESTS] Splitting test cases from datetime.sql

2021-08-04 Thread GitBox
gengliangwang commented on a change in pull request #33640: URL: https://github.com/apache/spark/pull/33640#discussion_r683144515 ## File path: sql/core/src/test/resources/sql-tests/results/ansi/date.sql.out ## @@ -0,0 +1,525 @@ +-- Automatically generated by SQLQueryTestSuite

[GitHub] [spark] SparkQA removed a comment on pull request #33639: [SPARK-34952][SQL] Aggregate (Min/Max/Count) push down for Parquet

2021-08-04 Thread GitBox
SparkQA removed a comment on pull request #33639: URL: https://github.com/apache/spark/pull/33639#issuecomment-893079916 **[Test build #142054 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142054/testReport)** for PR 33639 at commit [`3fe9e88`](https://gi

[GitHub] [spark] StefanXiepj opened a new pull request #33648: [SPARK-36420][Graphx] Use `isEmpty` to improve performance in Pregel‘s superstep

2021-08-04 Thread GitBox
StefanXiepj opened a new pull request #33648: URL: https://github.com/apache/spark/pull/33648 ### What changes were proposed in this pull request? When recived active-messages in Pregel, we only need an action operator here and active-messages are not empty, so we don’t need

[GitHub] [spark] SparkQA commented on pull request #33639: [SPARK-34952][SQL] Aggregate (Min/Max/Count) push down for Parquet

2021-08-04 Thread GitBox
SparkQA commented on pull request #33639: URL: https://github.com/apache/spark/pull/33639#issuecomment-893178070 **[Test build #142054 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142054/testReport)** for PR 33639 at commit [`3fe9e88`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #33638: [SPARK-36415][SQL][DOCS] Add docs for try_cast/try_add/try_divide

2021-08-04 Thread GitBox
SparkQA commented on pull request #33638: URL: https://github.com/apache/spark/pull/33638#issuecomment-893177701 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46574/ -- This is an automated message from the A

[GitHub] [spark] SparkQA commented on pull request #33508: [SPARK-36058][K8S] Add support for statefulset APIs in K8s

2021-08-04 Thread GitBox
SparkQA commented on pull request #33508: URL: https://github.com/apache/spark/pull/33508#issuecomment-893177724 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46571/ -- This is an automated message from the A

[GitHub] [spark] LuciferYang commented on pull request #33635: [SPARK-36410][CORE][SQL][STRUCTURED STREAMING][EXAMPLES] Replace anonymous classes with lambda expressions

2021-08-04 Thread GitBox
LuciferYang commented on pull request #33635: URL: https://github.com/apache/spark/pull/33635#issuecomment-893176859 > The changes look good but can you also run the examples that you're fixing manually to verify the changes? @HyukjinKwon 1. I manually verified `JavaUserDefin

[GitHub] [spark] SparkQA removed a comment on pull request #33646: [SPARK-36388][PYTHON] Fix DataFrame groupby-rolling to follow pandas 1.3

2021-08-04 Thread GitBox
SparkQA removed a comment on pull request #33646: URL: https://github.com/apache/spark/pull/33646#issuecomment-893163413 **[Test build #142066 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142066/testReport)** for PR 33646 at commit [`de59b6e`](https://gi

[GitHub] [spark] SparkQA commented on pull request #33646: [SPARK-36388][PYTHON] Fix DataFrame groupby-rolling to follow pandas 1.3

2021-08-04 Thread GitBox
SparkQA commented on pull request #33646: URL: https://github.com/apache/spark/pull/33646#issuecomment-893174169 **[Test build #142066 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142066/testReport)** for PR 33646 at commit [`de59b6e`](https://github.co

[GitHub] [spark] gengliangwang commented on a change in pull request #33584: [SPARK-36351][SQL] Separate partition filters and data filters in PushDownUtils

2021-08-04 Thread GitBox
gengliangwang commented on a change in pull request #33584: URL: https://github.com/apache/spark/pull/33584#discussion_r683135973 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/PushDownUtils.scala ## @@ -117,7 +145,11 @@ object PushDownUtil

[GitHub] [spark] SparkQA commented on pull request #33635: [SPARK-36410][CORE][SQL][STRUCTURED STREAMING][EXAMPLES] Replace anonymous classes with lambda expressions

2021-08-04 Thread GitBox
SparkQA commented on pull request #33635: URL: https://github.com/apache/spark/pull/33635#issuecomment-893171616 **[Test build #142067 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142067/testReport)** for PR 33635 at commit [`2a8d843`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33638: [SPARK-36415][SQL][DOCS] Add docs for try_cast/try_add/try_divide

2021-08-04 Thread GitBox
AmplabJenkins removed a comment on pull request #33638: URL: https://github.com/apache/spark/pull/33638#issuecomment-893168342 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46572/

[GitHub] [spark] SparkQA commented on pull request #33638: [SPARK-36415][SQL][DOCS] Add docs for try_cast/try_add/try_divide

2021-08-04 Thread GitBox
SparkQA commented on pull request #33638: URL: https://github.com/apache/spark/pull/33638#issuecomment-893168320 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46572/ -- This is an automated message from the A

[GitHub] [spark] AmplabJenkins commented on pull request #33638: [SPARK-36415][SQL][DOCS] Add docs for try_cast/try_add/try_divide

2021-08-04 Thread GitBox
AmplabJenkins commented on pull request #33638: URL: https://github.com/apache/spark/pull/33638#issuecomment-893168342 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46572/ -- T

[GitHub] [spark] SparkQA commented on pull request #33646: [SPARK-36388][PYTHON] Fix DataFrame groupby-rolling to follow pandas 1.3

2021-08-04 Thread GitBox
SparkQA commented on pull request #33646: URL: https://github.com/apache/spark/pull/33646#issuecomment-893163413 **[Test build #142066 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142066/testReport)** for PR 33646 at commit [`de59b6e`](https://github.com

[GitHub] [spark] SparkQA commented on pull request #33647: [SPARK-36421][SQL] Validate all SQL configs to prevent from wrong use for ConfigEntry in doc fields

2021-08-04 Thread GitBox
SparkQA commented on pull request #33647: URL: https://github.com/apache/spark/pull/33647#issuecomment-893163457 **[Test build #142065 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142065/testReport)** for PR 33647 at commit [`96f264a`](https://github.com

[GitHub] [spark] cloud-fan commented on pull request #33636: [SPARK-36414][SQL] Disable timeout for BroadcastQueryStageExec in AQE

2021-08-04 Thread GitBox
cloud-fan commented on pull request #33636: URL: https://github.com/apache/spark/pull/33636#issuecomment-893163127 makes sense to me, cc @maryannxue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33645: [SPARK-36173][CORE][PYTHON][FOLLOWUP] Add type hint for TaskContext.cpus

2021-08-04 Thread GitBox
AmplabJenkins removed a comment on pull request #33645: URL: https://github.com/apache/spark/pull/33645#issuecomment-893162910 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46573/

[GitHub] [spark] AmplabJenkins commented on pull request #33645: [SPARK-36173][CORE][PYTHON][FOLLOWUP] Add type hint for TaskContext.cpus

2021-08-04 Thread GitBox
AmplabJenkins commented on pull request #33645: URL: https://github.com/apache/spark/pull/33645#issuecomment-893162910 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46573/ -- T

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33635: [SPARK-36410][CORE][SQL][STRUCTURED STREAMING][EXAMPLES] Replace anonymous classes with lambda expressions

2021-08-04 Thread GitBox
AmplabJenkins removed a comment on pull request #33635: URL: https://github.com/apache/spark/pull/33635#issuecomment-893162904 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142060/ -

[GitHub] [spark] AmplabJenkins commented on pull request #33635: [SPARK-36410][CORE][SQL][STRUCTURED STREAMING][EXAMPLES] Replace anonymous classes with lambda expressions

2021-08-04 Thread GitBox
AmplabJenkins commented on pull request #33635: URL: https://github.com/apache/spark/pull/33635#issuecomment-893162904 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142060/ -- This

[GitHub] [spark] yaooqinn opened a new pull request #33647: [SPARK-36421][SQL] Validate all SQL configs to prevent from wrong use for ConfigEntry in doc field

2021-08-04 Thread GitBox
yaooqinn opened a new pull request #33647: URL: https://github.com/apache/spark/pull/33647 ### What changes were proposed in this pull request? This PR fixes the issue that `ConfigEntry` to be introduced to the doc field directly without calling `.key`, which causes m

[GitHub] [spark] itholic opened a new pull request #33646: [SPARK-36388][PYTHON] Fix DataFrame groupby-rolling to follow pandas 1.3

2021-08-04 Thread GitBox
itholic opened a new pull request #33646: URL: https://github.com/apache/spark/pull/33646 ### What changes were proposed in this pull request? This PR proposes to fix `GroupByRolling` to follow latest pandas behavior. `GroupByRolling` no longer returns grouped-by column in valu

[GitHub] [spark] SparkQA commented on pull request #33638: [SPARK-36415][SQL][DOCS] Add docs for try_cast/try_add/try_divide

2021-08-04 Thread GitBox
SparkQA commented on pull request #33638: URL: https://github.com/apache/spark/pull/33638#issuecomment-893159596 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46574/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA removed a comment on pull request #33635: [SPARK-36410][CORE][SQL][STRUCTURED STREAMING][EXAMPLES] Replace anonymous classes with lambda expressions

2021-08-04 Thread GitBox
SparkQA removed a comment on pull request #33635: URL: https://github.com/apache/spark/pull/33635#issuecomment-893124147 **[Test build #142060 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142060/testReport)** for PR 33635 at commit [`6830d51`](https://gi

[GitHub] [spark] SparkQA commented on pull request #33635: [SPARK-36410][CORE][SQL][STRUCTURED STREAMING][EXAMPLES] Replace anonymous classes with lambda expressions

2021-08-04 Thread GitBox
SparkQA commented on pull request #33635: URL: https://github.com/apache/spark/pull/33635#issuecomment-893156894 **[Test build #142060 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142060/testReport)** for PR 33635 at commit [`6830d51`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #33645: [SPARK-36173][CORE][PYTHON][FOLLOWUP] Add type hint for TaskContext.cpus

2021-08-04 Thread GitBox
SparkQA commented on pull request #33645: URL: https://github.com/apache/spark/pull/33645#issuecomment-893155198 Kubernetes integration test unable to build dist. exiting with code: 1 URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46573/ -- This

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33635: [SPARK-36410][CORE][SQL][STRUCTURED STREAMING][EXAMPLES] Replace anonymous classes with lambda expressions

2021-08-04 Thread GitBox
AmplabJenkins removed a comment on pull request #33635: URL: https://github.com/apache/spark/pull/33635#issuecomment-893151855 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46570/

[GitHub] [spark] AmplabJenkins commented on pull request #33635: [SPARK-36410][CORE][SQL][STRUCTURED STREAMING][EXAMPLES] Replace anonymous classes with lambda expressions

2021-08-04 Thread GitBox
AmplabJenkins commented on pull request #33635: URL: https://github.com/apache/spark/pull/33635#issuecomment-893151855 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46570/ -- T

[GitHub] [spark] SparkQA commented on pull request #33635: [SPARK-36410][CORE][SQL][STRUCTURED STREAMING][EXAMPLES] Replace anonymous classes with lambda expressions

2021-08-04 Thread GitBox
SparkQA commented on pull request #33635: URL: https://github.com/apache/spark/pull/33635#issuecomment-893151803 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46570/ -- This is an automated message from the A

[GitHub] [spark] SparkQA commented on pull request #33638: [SPARK-36415][SQL][DOCS] Add docs for try_cast/try_add/try_divide

2021-08-04 Thread GitBox
SparkQA commented on pull request #33638: URL: https://github.com/apache/spark/pull/33638#issuecomment-893148537 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46572/ -- This is an automated message from the Apache

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33638: [SPARK-36415][SQL][DOCS] Add docs for try_cast/try_add/try_divide

2021-08-04 Thread GitBox
AmplabJenkins removed a comment on pull request #33638: URL: https://github.com/apache/spark/pull/33638#issuecomment-893147784 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142064/ -

[GitHub] [spark] AmplabJenkins commented on pull request #33638: [SPARK-36415][SQL][DOCS] Add docs for try_cast/try_add/try_divide

2021-08-04 Thread GitBox
AmplabJenkins commented on pull request #33638: URL: https://github.com/apache/spark/pull/33638#issuecomment-893147784 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142064/ -- This

[GitHub] [spark] SparkQA removed a comment on pull request #33638: [SPARK-36415][SQL][DOCS] Add docs for try_cast/try_add/try_divide

2021-08-04 Thread GitBox
SparkQA removed a comment on pull request #33638: URL: https://github.com/apache/spark/pull/33638#issuecomment-893142529 **[Test build #142064 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142064/testReport)** for PR 33638 at commit [`5e54b19`](https://gi

[GitHub] [spark] SparkQA commented on pull request #33638: [SPARK-36415][SQL][DOCS] Add docs for try_cast/try_add/try_divide

2021-08-04 Thread GitBox
SparkQA commented on pull request #33638: URL: https://github.com/apache/spark/pull/33638#issuecomment-893147606 **[Test build #142064 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142064/testReport)** for PR 33638 at commit [`5e54b19`](https://github.co

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33645: [SPARK-36173][CORE][PYTHON][FOLLOWUP] Add type hint for TaskContext.cpus

2021-08-04 Thread GitBox
AmplabJenkins removed a comment on pull request #33645: URL: https://github.com/apache/spark/pull/33645#issuecomment-893143589 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142063/ -

[GitHub] [spark] AmplabJenkins commented on pull request #33645: [SPARK-36173][CORE][PYTHON][FOLLOWUP] Add type hint for TaskContext.cpus

2021-08-04 Thread GitBox
AmplabJenkins commented on pull request #33645: URL: https://github.com/apache/spark/pull/33645#issuecomment-893143589 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142063/ -- This

[GitHub] [spark] SparkQA removed a comment on pull request #33645: [SPARK-36173][CORE][PYTHON][FOLLOWUP] Add type hint for TaskContext.cpus

2021-08-04 Thread GitBox
SparkQA removed a comment on pull request #33645: URL: https://github.com/apache/spark/pull/33645#issuecomment-893132595 **[Test build #142063 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142063/testReport)** for PR 33645 at commit [`550c222`](https://gi

[GitHub] [spark] SparkQA commented on pull request #33645: [SPARK-36173][CORE][PYTHON][FOLLOWUP] Add type hint for TaskContext.cpus

2021-08-04 Thread GitBox
SparkQA commented on pull request #33645: URL: https://github.com/apache/spark/pull/33645#issuecomment-893143320 **[Test build #142063 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142063/testReport)** for PR 33645 at commit [`550c222`](https://github.co

[GitHub] [spark] SparkQA commented on pull request #33638: [SPARK-36415][SQL][DOCS] Add docs for try_cast/try_add/try_divide

2021-08-04 Thread GitBox
SparkQA commented on pull request #33638: URL: https://github.com/apache/spark/pull/33638#issuecomment-893142529 **[Test build #142064 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142064/testReport)** for PR 33638 at commit [`5e54b19`](https://github.com

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33622: [SPARK-36391][SHUFFLE] When state is remove will throw NPE, and we should improve the error message

2021-08-04 Thread GitBox
AmplabJenkins removed a comment on pull request #33622: URL: https://github.com/apache/spark/pull/33622#issuecomment-893141965 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142055/ -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33636: [SPARK-36414][SQL] Disable timeout for BroadcastQueryStageExec in AQE

2021-08-04 Thread GitBox
AmplabJenkins removed a comment on pull request #33636: URL: https://github.com/apache/spark/pull/33636#issuecomment-893141966 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46568/

[GitHub] [spark] AmplabJenkins commented on pull request #33638: [SPARK-36415][SQL][DOCS] Add docs for try_cast/try_add/try_divide

2021-08-04 Thread GitBox
AmplabJenkins commented on pull request #33638: URL: https://github.com/apache/spark/pull/33638#issuecomment-893141964 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142062/ -- This

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33638: [SPARK-36415][SQL][DOCS] Add docs for try_cast/try_add/try_divide

2021-08-04 Thread GitBox
AmplabJenkins removed a comment on pull request #33638: URL: https://github.com/apache/spark/pull/33638#issuecomment-893141964 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142062/ -

[GitHub] [spark] AmplabJenkins commented on pull request #33622: [SPARK-36391][SHUFFLE] When state is remove will throw NPE, and we should improve the error message

2021-08-04 Thread GitBox
AmplabJenkins commented on pull request #33622: URL: https://github.com/apache/spark/pull/33622#issuecomment-893141965 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142055/ -- This

  1   2   3   4   5   6   >