Re: [PR] [SPARK-46611][CORE] Remove ThreadLocal by replace SimpleDateFormat with DateTimeFormatter [spark]

2024-01-07 Thread via GitHub
llkj1 commented on PR #44613: URL: https://github.com/apache/spark/pull/44613#issuecomment-1879986625 感谢您与我们联系。(Thank you for contacting us.) 我们收到了您的请求,并会在一至两个工作日内给您回复。您的案例编号是 102195453736。 想了解更多与开发相关主题的信息,请访问 开发者支持

Re: [PR] [SPARK-46611][CORE] Remove ThreadLocal by replace SimpleDateFormat with DateTimeFormatter [spark]

2024-01-07 Thread via GitHub
llkj1 commented on PR #44613: URL: https://github.com/apache/spark/pull/44613#issuecomment-1879987119 感谢您与我们联系。(Thank you for contacting us.) 我们收到了您的请求,并会在一至两个工作日内给您回复。您的案例编号是 102195454870。 想了解更多与开发相关主题的信息,请访问 开发者支持

Re: [PR] [SPARK-46611][CORE] Remove ThreadLocal by replace SimpleDateFormat with DateTimeFormatter [spark]

2024-01-07 Thread via GitHub
llkj1 commented on PR #44613: URL: https://github.com/apache/spark/pull/44613#issuecomment-1879987687 感谢您与我们联系。(Thank you for contacting us.) 我们收到了您的请求,并会在一至两个工作日内给您回复。您的案例编号是 102195455952。 想了解更多与开发相关主题的信息,请访问 开发者支持

Re: [PR] [SPARK-46611][CORE] Remove ThreadLocal by replace SimpleDateFormat with DateTimeFormatter [spark]

2024-01-07 Thread via GitHub
llkj1 commented on PR #44613: URL: https://github.com/apache/spark/pull/44613#issuecomment-1879988255 感谢您与我们联系。(Thank you for contacting us.) 我们收到了您的请求,并会在一至两个工作日内给您回复。您的案例编号是 102195456973。 想了解更多与开发相关主题的信息,请访问 开发者支持

Re: [PR] [SPARK-46611][CORE] Remove ThreadLocal by replace SimpleDateFormat with DateTimeFormatter [spark]

2024-01-07 Thread via GitHub
llkj1 commented on PR #44613: URL: https://github.com/apache/spark/pull/44613#issuecomment-1879988857 感谢您与我们联系。(Thank you for contacting us.) 我们收到了您的请求,并会在一至两个工作日内给您回复。您的案例编号是 102195458623。 想了解更多与开发相关主题的信息,请访问 开发者支持

Re: [PR] [SPARK-46611][CORE] Remove ThreadLocal by replace SimpleDateFormat with DateTimeFormatter [spark]

2024-01-07 Thread via GitHub
llkj1 commented on PR #44613: URL: https://github.com/apache/spark/pull/44613#issuecomment-1879989280 感谢您与我们联系。(Thank you for contacting us.) 我们收到了您的请求,并会在一至两个工作日内给您回复。您的案例编号是 102195459708。 想了解更多与开发相关主题的信息,请访问 开发者支持

Re: [PR] [SPARK-46611][CORE] Remove ThreadLocal by replace SimpleDateFormat with DateTimeFormatter [spark]

2024-01-07 Thread via GitHub
llkj1 commented on PR #44613: URL: https://github.com/apache/spark/pull/44613#issuecomment-1879989714 感谢您与我们联系。(Thank you for contacting us.) 我们收到了您的请求,并会在一至两个工作日内给您回复。您的案例编号是 102195460870。 想了解更多与开发相关主题的信息,请访问 开发者支持

Re: [PR] [SPARK-46611][CORE] Remove ThreadLocal by replace SimpleDateFormat with DateTimeFormatter [spark]

2024-01-07 Thread via GitHub
llkj1 commented on PR #44613: URL: https://github.com/apache/spark/pull/44613#issuecomment-1879990138 感谢您与我们联系。(Thank you for contacting us.) 我们收到了您的请求,并会在一至两个工作日内给您回复。您的案例编号是 102195462227。 想了解更多与开发相关主题的信息,请访问 开发者支持

Re: [PR] [SPARK-46611][CORE] Remove ThreadLocal by replace SimpleDateFormat with DateTimeFormatter [spark]

2024-01-07 Thread via GitHub
llkj1 commented on PR #44613: URL: https://github.com/apache/spark/pull/44613#issuecomment-1879990723 感谢您与我们联系。(Thank you for contacting us.) 我们收到了您的请求,并会在一至两个工作日内给您回复。您的案例编号是 102195463590。 想了解更多与开发相关主题的信息,请访问 开发者支持

Re: [PR] [SPARK-46611][CORE] Remove ThreadLocal by replace SimpleDateFormat with DateTimeFormatter [spark]

2024-01-07 Thread via GitHub
llkj1 commented on PR #44613: URL: https://github.com/apache/spark/pull/44613#issuecomment-1879991168 感谢您与我们联系。(Thank you for contacting us.) 我们收到了您的请求,并会在一至两个工作日内给您回复。您的案例编号是 102195464943。 想了解更多与开发相关主题的信息,请访问 开发者支持

Re: [PR] [SPARK-46611][CORE] Remove ThreadLocal by replace SimpleDateFormat with DateTimeFormatter [spark]

2024-01-07 Thread via GitHub
llkj1 commented on PR #44613: URL: https://github.com/apache/spark/pull/44613#issuecomment-1879991487 感谢您与我们联系。(Thank you for contacting us.) 我们收到了您的请求,并会在一至两个工作日内给您回复。您的案例编号是 102195465744。 想了解更多与开发相关主题的信息,请访问 开发者支持

Re: [PR] [SPARK-46611][CORE] Remove ThreadLocal by replace SimpleDateFormat with DateTimeFormatter [spark]

2024-01-07 Thread via GitHub
llkj1 commented on PR #44613: URL: https://github.com/apache/spark/pull/44613#issuecomment-1879991934 感谢您与我们联系。(Thank you for contacting us.) 我们收到了您的请求,并会在一至两个工作日内给您回复。您的案例编号是 102195466919。 想了解更多与开发相关主题的信息,请访问 开发者支持

Re: [PR] [SPARK-46611][CORE] Remove ThreadLocal by replace SimpleDateFormat with DateTimeFormatter [spark]

2024-01-07 Thread via GitHub
llkj1 commented on PR #44613: URL: https://github.com/apache/spark/pull/44613#issuecomment-1879992467 感谢您与我们联系。(Thank you for contacting us.) 我们收到了您的请求,并会在一至两个工作日内给您回复。您的案例编号是 102195468388。 想了解更多与开发相关主题的信息,请访问 开发者支持

Re: [PR] [SPARK-46248][SQL] XML: Support for ignoreCorruptFiles and ignoreMissingFiles options [spark]

2024-01-07 Thread via GitHub
sandip-db commented on code in PR #44163: URL: https://github.com/apache/spark/pull/44163#discussion_r1443960176 ## sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/xml/TestXmlData.scala: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] [SPARK-46606][PYTHON][DOCS] Refine docstring of `convert_timezone/make_dt_interval/make_interval` [spark]

2024-01-07 Thread via GitHub
llkj1 commented on PR #44610: URL: https://github.com/apache/spark/pull/44610#issuecomment-1880014154 感谢您与我们联系。(Thank you for contacting us.) 我们收到了您的请求,并会在一至两个工作日内给您回复。您的案例编号是 102195518948。 想了解更多与开发相关主题的信息,请访问 开发者支持

Re: [PR] [SPARK-46606][PYTHON][DOCS] Refine docstring of `convert_timezone/make_dt_interval/make_interval` [spark]

2024-01-07 Thread via GitHub
llkj1 commented on PR #44610: URL: https://github.com/apache/spark/pull/44610#issuecomment-1880014553 感谢您与我们联系。(Thank you for contacting us.) 我们收到了您的请求,并会在一至两个工作日内给您回复。您的案例编号是 102195519869。 想了解更多与开发相关主题的信息,请访问 开发者支持

Re: [PR] [SPARK-46606][PYTHON][DOCS] Refine docstring of `convert_timezone/make_dt_interval/make_interval` [spark]

2024-01-07 Thread via GitHub
llkj1 commented on PR #44610: URL: https://github.com/apache/spark/pull/44610#issuecomment-1880015118 感谢您与我们联系。(Thank you for contacting us.) 我们收到了您的请求,并会在一至两个工作日内给您回复。您的案例编号是 102195521122。 想了解更多与开发相关主题的信息,请访问 开发者支持

Re: [PR] [SPARK-42332][SQL][DOCS] Changing the require to a SparkException in ComplexTypeMergingExpression [spark]

2024-01-07 Thread via GitHub
MaxGekk commented on PR #44336: URL: https://github.com/apache/spark/pull/44336#issuecomment-1880015640 @hannahkamundson Please, check the failed tests. It seems they are related to your changes: ``` Map("expression" -> ""coalesce(1, a, a)"", "inputTypes" -> "["INT", "STRING", "STRING

Re: [PR] [SPARK-46606][PYTHON][DOCS] Refine docstring of `convert_timezone/make_dt_interval/make_interval` [spark]

2024-01-07 Thread via GitHub
llkj1 commented on PR #44610: URL: https://github.com/apache/spark/pull/44610#issuecomment-1880015812 感谢您与我们联系。(Thank you for contacting us.) 我们收到了您的请求,并会在一至两个工作日内给您回复。您的案例编号是 102195522251。 想了解更多与开发相关主题的信息,请访问 开发者支持

Re: [PR] [SPARK-46606][PYTHON][DOCS] Refine docstring of `convert_timezone/make_dt_interval/make_interval` [spark]

2024-01-07 Thread via GitHub
llkj1 commented on PR #44610: URL: https://github.com/apache/spark/pull/44610#issuecomment-1880016197 感谢您与我们联系。(Thank you for contacting us.) 我们收到了您的请求,并会在一至两个工作日内给您回复。您的案例编号是 102195523175。 想了解更多与开发相关主题的信息,请访问 开发者支持

Re: [PR] [SPARK-42332][SQL][DOCS] Changing the require to a SparkException in ComplexTypeMergingExpression [spark]

2024-01-07 Thread via GitHub
llkj1 commented on PR #44336: URL: https://github.com/apache/spark/pull/44336#issuecomment-1880016324 感谢您与我们联系。(Thank you for contacting us.) 我们收到了您的请求,并会在一至两个工作日内给您回复。您的案例编号是 102195523219。 想了解更多与开发相关主题的信息,请访问 开发者支持

Re: [PR] [SPARK-46606][PYTHON][DOCS] Refine docstring of `convert_timezone/make_dt_interval/make_interval` [spark]

2024-01-07 Thread via GitHub
llkj1 commented on PR #44610: URL: https://github.com/apache/spark/pull/44610#issuecomment-1880016691 感谢您与我们联系。(Thank you for contacting us.) 我们收到了您的请求,并会在一至两个工作日内给您回复。您的案例编号是 102195524177。 想了解更多与开发相关主题的信息,请访问 开发者支持

Re: [PR] [SPARK-42332][SQL][DOCS] Changing the require to a SparkException in ComplexTypeMergingExpression [spark]

2024-01-07 Thread via GitHub
llkj1 commented on PR #44336: URL: https://github.com/apache/spark/pull/44336#issuecomment-1880016835 感谢您与我们联系。(Thank you for contacting us.) 我们收到了您的请求,并会在一至两个工作日内给您回复。您的案例编号是 102195524488。 想了解更多与开发相关主题的信息,请访问 开发者支持

Re: [PR] [SPARK-46606][PYTHON][DOCS] Refine docstring of `convert_timezone/make_dt_interval/make_interval` [spark]

2024-01-07 Thread via GitHub
llkj1 commented on PR #44610: URL: https://github.com/apache/spark/pull/44610#issuecomment-1880017334 感谢您与我们联系。(Thank you for contacting us.) 我们收到了您的请求,并会在一至两个工作日内给您回复。您的案例编号是 102195525174。 想了解更多与开发相关主题的信息,请访问 开发者支持

Re: [PR] [SPARK-42332][SQL][DOCS] Changing the require to a SparkException in ComplexTypeMergingExpression [spark]

2024-01-07 Thread via GitHub
llkj1 commented on PR #44336: URL: https://github.com/apache/spark/pull/44336#issuecomment-1880017451 感谢您与我们联系。(Thank you for contacting us.) 我们收到了您的请求,并会在一至两个工作日内给您回复。您的案例编号是 102195525426。 想了解更多与开发相关主题的信息,请访问 开发者支持

Re: [PR] [SPARK-46606][PYTHON][DOCS] Refine docstring of `convert_timezone/make_dt_interval/make_interval` [spark]

2024-01-07 Thread via GitHub
llkj1 commented on PR #44610: URL: https://github.com/apache/spark/pull/44610#issuecomment-1880018142 感谢您与我们联系。(Thank you for contacting us.) 我们收到了您的请求,并会在一至两个工作日内给您回复。您的案例编号是 102195526680。 想了解更多与开发相关主题的信息,请访问 开发者支持

Re: [PR] [SPARK-42332][SQL][DOCS] Changing the require to a SparkException in ComplexTypeMergingExpression [spark]

2024-01-07 Thread via GitHub
llkj1 commented on PR #44336: URL: https://github.com/apache/spark/pull/44336#issuecomment-1880018252 感谢您与我们联系。(Thank you for contacting us.) 我们收到了您的请求,并会在一至两个工作日内给您回复。您的案例编号是 102195526981。 想了解更多与开发相关主题的信息,请访问 开发者支持

Re: [PR] [SPARK-46611][CORE] Remove ThreadLocal by replace SimpleDateFormat with DateTimeFormatter [spark]

2024-01-07 Thread via GitHub
MaxGekk commented on PR #44613: URL: https://github.com/apache/spark/pull/44613#issuecomment-1880018422 I sent info about the spam from @llkj1 to GitHub support. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [SPARK-46606][PYTHON][DOCS] Refine docstring of `convert_timezone/make_dt_interval/make_interval` [spark]

2024-01-07 Thread via GitHub
llkj1 commented on PR #44610: URL: https://github.com/apache/spark/pull/44610#issuecomment-1880018680 感谢您与我们联系。(Thank you for contacting us.) 我们收到了您的请求,并会在一至两个工作日内给您回复。您的案例编号是 102195527999。 想了解更多与开发相关主题的信息,请访问 开发者支持

Re: [PR] [SPARK-42332][SQL][DOCS] Changing the require to a SparkException in ComplexTypeMergingExpression [spark]

2024-01-07 Thread via GitHub
llkj1 commented on PR #44336: URL: https://github.com/apache/spark/pull/44336#issuecomment-1880018760 感谢您与我们联系。(Thank you for contacting us.) 我们收到了您的请求,并会在一至两个工作日内给您回复。您的案例编号是 102195528265。 想了解更多与开发相关主题的信息,请访问 开发者支持

Re: [PR] [SPARK-46611][CORE] Remove ThreadLocal by replace SimpleDateFormat with DateTimeFormatter [spark]

2024-01-07 Thread via GitHub
llkj1 commented on PR #44613: URL: https://github.com/apache/spark/pull/44613#issuecomment-1880018950 感谢您与我们联系。(Thank you for contacting us.) 我们收到了您的请求,并会在一至两个工作日内给您回复。您的案例编号是 102195528798。 想了解更多与开发相关主题的信息,请访问 开发者支持

Re: [PR] [SPARK-42332][SQL][DOCS] Changing the require to a SparkException in ComplexTypeMergingExpression [spark]

2024-01-07 Thread via GitHub
llkj1 commented on PR #44336: URL: https://github.com/apache/spark/pull/44336#issuecomment-1880019229 感谢您与我们联系。(Thank you for contacting us.) 我们收到了您的请求,并会在一至两个工作日内给您回复。您的案例编号是 102195529243。 想了解更多与开发相关主题的信息,请访问 开发者支持

Re: [PR] [SPARK-46606][PYTHON][DOCS] Refine docstring of `convert_timezone/make_dt_interval/make_interval` [spark]

2024-01-07 Thread via GitHub
llkj1 commented on PR #44610: URL: https://github.com/apache/spark/pull/44610#issuecomment-1880019225 感谢您与我们联系。(Thank you for contacting us.) 我们收到了您的请求,并会在一至两个工作日内给您回复。您的案例编号是 102195529244。 想了解更多与开发相关主题的信息,请访问 开发者支持

Re: [PR] [SPARK-46611][CORE] Remove ThreadLocal by replace SimpleDateFormat with DateTimeFormatter [spark]

2024-01-07 Thread via GitHub
llkj1 commented on PR #44613: URL: https://github.com/apache/spark/pull/44613#issuecomment-1880019490 感谢您与我们联系。(Thank you for contacting us.) 我们收到了您的请求,并会在一至两个工作日内给您回复。您的案例编号是 102195530026。 想了解更多与开发相关主题的信息,请访问 开发者支持

Re: [PR] [SPARK-46611][CORE] Remove ThreadLocal by replace SimpleDateFormat with DateTimeFormatter [spark]

2024-01-07 Thread via GitHub
srowen commented on PR #44613: URL: https://github.com/apache/spark/pull/44613#issuecomment-1880020941 I tried to block the user and have been deleting the spam -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] [SPARK-46442][SQL] DS V2 supports push down PERCENTILE_CONT and PERCENTILE_DISC [spark]

2024-01-07 Thread via GitHub
beliefer commented on code in PR #44397: URL: https://github.com/apache/spark/pull/44397#discussion_r1444003277 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java: ## @@ -271,6 +279,15 @@ protected String visitAggregateFunction( }

[PR] [WIP][CORE] Replace SimpleDateFormat with DateTimeFormatter [spark]

2024-01-07 Thread via GitHub
beliefer opened a new pull request, #44616: URL: https://github.com/apache/spark/pull/44616 ### What changes were proposed in this pull request? This PR propose to replace `SimpleDateFormat` with `DateTimeFormatter`. ### Why are the changes needed? According to the javadoc of

Re: [PR] [SPARK-46610][SQL] Create table should throw exception when no value for a key in options [spark]

2024-01-07 Thread via GitHub
MaxGekk commented on code in PR #44615: URL: https://github.com/apache/spark/pull/44615#discussion_r1444051000 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -3380,6 +3380,10 @@ class AstBuilder extends DataTypeAstBuilder with SQLCon

Re: [PR] Do not convert array type string retrieved from jdbc driver [spark]

2024-01-07 Thread via GitHub
phanhuyn commented on PR #44459: URL: https://github.com/apache/spark/pull/44459#issuecomment-1880206832 > Thanks for the PR. Mind creating a JIRA please? (see also https://spark.apache.org/contributing.html). Thanks for the reply @HyukjinKwon. I've applied for a JIRA account at http

Re: [PR] [SPARK-46382][SQL] XML: Refactor inference and parsing [spark]

2024-01-07 Thread via GitHub
HyukjinKwon commented on PR #44571: URL: https://github.com/apache/spark/pull/44571#issuecomment-1880225723 Merged to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [SPARK-46382][SQL] XML: Refactor inference and parsing [spark]

2024-01-07 Thread via GitHub
HyukjinKwon closed pull request #44571: [SPARK-46382][SQL] XML: Refactor inference and parsing URL: https://github.com/apache/spark/pull/44571 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] [SPARK-46248][SQL] XML: Support for ignoreCorruptFiles and ignoreMissingFiles options [spark]

2024-01-07 Thread via GitHub
HyukjinKwon commented on PR #44163: URL: https://github.com/apache/spark/pull/44163#issuecomment-1880226508 Merged to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [SPARK-46248][SQL] XML: Support for ignoreCorruptFiles and ignoreMissingFiles options [spark]

2024-01-07 Thread via GitHub
HyukjinKwon closed pull request #44163: [SPARK-46248][SQL] XML: Support for ignoreCorruptFiles and ignoreMissingFiles options URL: https://github.com/apache/spark/pull/44163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [SPARK-46607][PYTHON][TESTS] Check the testing mode [spark]

2024-01-07 Thread via GitHub
HyukjinKwon commented on PR #44611: URL: https://github.com/apache/spark/pull/44611#issuecomment-1880226914 Merged to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [SPARK-46607][PYTHON][TESTS] Check the testing mode [spark]

2024-01-07 Thread via GitHub
HyukjinKwon closed pull request #44611: [SPARK-46607][PYTHON][TESTS] Check the testing mode URL: https://github.com/apache/spark/pull/44611 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[PR] [SPARK-46613][SQL][PYTHON] Log full exception when failed to lookup Python Data Sources [spark]

2024-01-07 Thread via GitHub
HyukjinKwon opened a new pull request, #44617: URL: https://github.com/apache/spark/pull/44617 ### What changes were proposed in this pull request? This PR proposes to log full exception when failed to lookup Python Data Sources ### Why are the changes needed? In my inte

Re: [PR] [WIP][CORE] Replace SimpleDateFormat with DateTimeFormatter [spark]

2024-01-07 Thread via GitHub
HyukjinKwon commented on PR #44616: URL: https://github.com/apache/spark/pull/44616#issuecomment-1880231491 cc @MaxGekk BTW, we would have to replace `FastDateFormat` too if possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] [SPARK-46606][PYTHON][DOCS] Refine docstring of `convert_timezone/make_dt_interval/make_interval` [spark]

2024-01-07 Thread via GitHub
HyukjinKwon closed pull request #44610: [SPARK-46606][PYTHON][DOCS] Refine docstring of `convert_timezone/make_dt_interval/make_interval` URL: https://github.com/apache/spark/pull/44610 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] [SPARK-46606][PYTHON][DOCS] Refine docstring of `convert_timezone/make_dt_interval/make_interval` [spark]

2024-01-07 Thread via GitHub
HyukjinKwon commented on PR #44610: URL: https://github.com/apache/spark/pull/44610#issuecomment-1880232651 Merged to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [SPARK-46603][PYTHON][DOCS] Refine docstring of `parse_url/url_encode/url_decode` [spark]

2024-01-07 Thread via GitHub
HyukjinKwon commented on PR #44604: URL: https://github.com/apache/spark/pull/44604#issuecomment-1880232889 Merged to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [SPARK-46603][PYTHON][DOCS] Refine docstring of `parse_url/url_encode/url_decode` [spark]

2024-01-07 Thread via GitHub
HyukjinKwon closed pull request #44604: [SPARK-46603][PYTHON][DOCS] Refine docstring of `parse_url/url_encode/url_decode` URL: https://github.com/apache/spark/pull/44604 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [SPARK-46613][SQL][PYTHON] Log full exception when failed to lookup Python Data Sources [spark]

2024-01-07 Thread via GitHub
HyukjinKwon commented on PR #44617: URL: https://github.com/apache/spark/pull/44617#issuecomment-1880233908 Build https://github.com/HyukjinKwon/spark/actions/runs/7441506339 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [SPARK-45372][CORE] Handle ClassNotFoundException when load extension [spark]

2024-01-07 Thread via GitHub
github-actions[bot] commented on PR #43173: URL: https://github.com/apache/spark/pull/43173#issuecomment-1880242312 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.

Re: [PR] [SPARK-46613][SQL][PYTHON] Log full exception when failed to lookup Python Data Sources [spark]

2024-01-07 Thread via GitHub
HyukjinKwon commented on PR #44617: URL: https://github.com/apache/spark/pull/44617#issuecomment-1880262341 Merged to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [SPARK-46613][SQL][PYTHON] Log full exception when failed to lookup Python Data Sources [spark]

2024-01-07 Thread via GitHub
HyukjinKwon closed pull request #44617: [SPARK-46613][SQL][PYTHON] Log full exception when failed to lookup Python Data Sources URL: https://github.com/apache/spark/pull/44617 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] [SPARK-46603][PYTHON][DOCS] Refine docstring of `parse_url/url_encode/url_decode` [spark]

2024-01-07 Thread via GitHub
LuciferYang commented on PR #44604: URL: https://github.com/apache/spark/pull/44604#issuecomment-1880271792 Thanks @HyukjinKwon ~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] [SPARK-46604][SQL] Make `Literal.apply` support `s.c.immuable.ArraySeq` [spark]

2024-01-07 Thread via GitHub
LuciferYang commented on PR #44607: URL: https://github.com/apache/spark/pull/44607#issuecomment-1880271931 Thanks @dongjoon-hyun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] [SPARK-46605][CONNECT] Make `lit/typedLit` function in connect module support `s.c.immutable.ArraySeq` [spark]

2024-01-07 Thread via GitHub
LuciferYang commented on PR #44608: URL: https://github.com/apache/spark/pull/44608#issuecomment-1880272118 Thanks @dongjoon-hyun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] [SPARK-46601] [CORE] Fix log error in handleStatusMessage [spark]

2024-01-07 Thread via GitHub
jiaoqingbo commented on PR #44606: URL: https://github.com/apache/spark/pull/44606#issuecomment-1880276332 The CI failure seems not related to this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [SPARK-46611][CORE] Remove ThreadLocal by replace SimpleDateFormat with DateTimeFormatter [spark]

2024-01-07 Thread via GitHub
LuciferYang commented on PR #44613: URL: https://github.com/apache/spark/pull/44613#issuecomment-1880284683 is this one ready to go? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] [SPARK-46586][SQL] Support `s.c.immutable.ArraySeq` as `customCollectionCls` in `MapObjects` [spark]

2024-01-07 Thread via GitHub
panbingkun commented on code in PR #44591: URL: https://github.com/apache/spark/pull/44591#discussion_r1444118744 ## sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala: ## @@ -830,6 +831,22 @@ class UDFSuite extends QueryTest with SharedSparkSession { Row(ArrayBu

Re: [PR] [SPARK-38488][INFRA] Upgrade ffi to 1.15.5 with --enable-libffi-alloc to fix doc build error on MacOS M1 [spark]

2024-01-07 Thread via GitHub
itholic commented on PR #35918: URL: https://github.com/apache/spark/pull/35918#issuecomment-1880320525 Hi, @Yikun . Do you happen to know if it's working well with MacOS M2?? Spark doc build is not working from me with MacOS M2, but not sure if it's really an issue or just my local e

Re: [PR] [SPARK-46607][PYTHON][TESTS] Check the testing mode [spark]

2024-01-07 Thread via GitHub
zhengruifeng commented on PR #44611: URL: https://github.com/apache/spark/pull/44611#issuecomment-1880363583 thanks @HyukjinKwon and @itholic for reivews -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [SPARK-46608][SQL] Restore backward compatibility of `JdbcDialect.classifyException` [spark]

2024-01-07 Thread via GitHub
cloud-fan commented on code in PR #9: URL: https://github.com/apache/spark/pull/9#discussion_r1444165085 ## sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala: ## @@ -633,13 +633,31 @@ abstract class JdbcDialect extends Serializable with Logging {

Re: [PR] [SPARK-46600][SQL] Move shared code between SqlConf and SqlApiConf to SqlApiConfHelper [spark]

2024-01-07 Thread via GitHub
cloud-fan commented on code in PR #44602: URL: https://github.com/apache/spark/pull/44602#discussion_r1444166378 ## sql/api/src/main/scala/org/apache/spark/sql/internal/SqlApiConfHelper.scala: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] [SPARK-46515] Add MONTHNAME function [spark]

2024-01-07 Thread via GitHub
cloud-fan commented on code in PR #44483: URL: https://github.com/apache/spark/pull/44483#discussion_r1444167519 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala: ## @@ -911,6 +911,23 @@ case class WeekOfYear(child: Expression) e

Re: [PR] [SPARK-46437][DOCS] Remove cruft from the built-in SQL functions documentation [spark]

2024-01-07 Thread via GitHub
HyukjinKwon commented on code in PR #44393: URL: https://github.com/apache/spark/pull/44393#discussion_r1444169083 ## docs/sql-ref-functions-builtin.md: ## @@ -17,202 +17,125 @@ license: | limitations under the License. --- -{% for static_file in site.static_files %} Revi

Re: [PR] [SPARK-46437][DOCS] Remove cruft from the built-in SQL functions documentation [spark]

2024-01-07 Thread via GitHub
HyukjinKwon commented on code in PR #44393: URL: https://github.com/apache/spark/pull/44393#discussion_r1444169163 ## docs/sql-ref-functions-builtin.md: ## @@ -17,202 +17,125 @@ license: | limitations under the License. --- -{% for static_file in site.static_files %} Revi

Re: [PR] [SPARK-46437][DOCS] Remove cruft from the built-in SQL functions documentation [spark]

2024-01-07 Thread via GitHub
nchammas commented on code in PR #44393: URL: https://github.com/apache/spark/pull/44393#discussion_r1444171117 ## docs/sql-ref-functions-builtin.md: ## @@ -17,202 +17,125 @@ license: | limitations under the License. --- -{% for static_file in site.static_files %} Review

Re: [PR] [SPARK-46437][DOCS] Remove cruft from the built-in SQL functions documentation [spark]

2024-01-07 Thread via GitHub
HyukjinKwon commented on code in PR #44393: URL: https://github.com/apache/spark/pull/44393#discussion_r1444171559 ## docs/sql-ref-functions-builtin.md: ## @@ -17,202 +17,125 @@ license: | limitations under the License. --- -{% for static_file in site.static_files %} Revi

Re: [PR] [SPARK-46437][DOCS] Remove cruft from the built-in SQL functions documentation [spark]

2024-01-07 Thread via GitHub
HyukjinKwon commented on code in PR #44393: URL: https://github.com/apache/spark/pull/44393#discussion_r1444171782 ## docs/sql-ref-functions-builtin.md: ## @@ -17,202 +17,125 @@ license: | limitations under the License. --- -{% for static_file in site.static_files %} Revi

Re: [PR] [SPARK-46437][DOCS] Remove cruft from the built-in SQL functions documentation [spark]

2024-01-07 Thread via GitHub
HyukjinKwon commented on code in PR #44393: URL: https://github.com/apache/spark/pull/44393#discussion_r1444171705 ## docs/sql-ref-functions-builtin.md: ## @@ -17,202 +17,125 @@ license: | limitations under the License. --- -{% for static_file in site.static_files %} Revi

Re: [PR] [SPARK-46437][DOCS] Remove cruft from the built-in SQL functions documentation [spark]

2024-01-07 Thread via GitHub
nchammas commented on code in PR #44393: URL: https://github.com/apache/spark/pull/44393#discussion_r1444173343 ## docs/sql-ref-functions-builtin.md: ## @@ -17,202 +17,125 @@ license: | limitations under the License. --- -{% for static_file in site.static_files %} Review

Re: [PR] [SPARK-46522][PYTHON] Block Python data source registration with name conflicts [spark]

2024-01-07 Thread via GitHub
HyukjinKwon commented on code in PR #44507: URL: https://github.com/apache/spark/pull/44507#discussion_r1444175715 ## sql/core/src/main/scala/org/apache/spark/sql/DataSourceRegistration.scala: ## @@ -43,6 +46,33 @@ private[sql] class DataSourceRegistration private[sql] (dataSou

Re: [PR] [SPARK-46611][CORE] Remove ThreadLocal by replace SimpleDateFormat with DateTimeFormatter [spark]

2024-01-07 Thread via GitHub
LuciferYang closed pull request #44613: [SPARK-46611][CORE] Remove ThreadLocal by replace SimpleDateFormat with DateTimeFormatter URL: https://github.com/apache/spark/pull/44613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [SPARK-46611][CORE] Remove ThreadLocal by replace SimpleDateFormat with DateTimeFormatter [spark]

2024-01-07 Thread via GitHub
LuciferYang commented on PR #44613: URL: https://github.com/apache/spark/pull/44613#issuecomment-1880416195 Merged into master. Thanks @beliefer@srowen @mridulm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [SPARK-46522][PYTHON] Block Python data source registration with name conflicts [spark]

2024-01-07 Thread via GitHub
allisonwang-db commented on code in PR #44507: URL: https://github.com/apache/spark/pull/44507#discussion_r1444195840 ## sql/core/src/main/scala/org/apache/spark/sql/DataSourceRegistration.scala: ## @@ -43,6 +46,33 @@ private[sql] class DataSourceRegistration private[sql] (data

[PR] [SPARK-46615][CONNECT] Support s.c.immutable.ArraySeq in ArrowDeserializers [spark]

2024-01-07 Thread via GitHub
panbingkun opened a new pull request, #44618: URL: https://github.com/apache/spark/pull/44618 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How

Re: [PR] [SPARK-46615][CONNECT] Support s.c.immutable.ArraySeq in ArrowDeserializers [spark]

2024-01-07 Thread via GitHub
panbingkun commented on code in PR #44618: URL: https://github.com/apache/spark/pull/44618#discussion_r1444202975 ## sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala: ## @@ -840,7 +840,7 @@ class UDFSuite extends QueryTest with SharedSparkSession { Row(ArrayBuffe

Re: [PR] [SPARK-46408][SQL] Support date_sub on V2ExpressionBuilder [spark]

2024-01-07 Thread via GitHub
caicancai commented on PR #44357: URL: https://github.com/apache/spark/pull/44357#issuecomment-1880445464 @beliefer rebase, thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [SPARK-46522][PYTHON] Block Python data source registration with name conflicts [spark]

2024-01-07 Thread via GitHub
HyukjinKwon commented on PR #44507: URL: https://github.com/apache/spark/pull/44507#issuecomment-1880490248 Merged to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [SPARK-46522][PYTHON] Block Python data source registration with name conflicts [spark]

2024-01-07 Thread via GitHub
HyukjinKwon closed pull request #44507: [SPARK-46522][PYTHON] Block Python data source registration with name conflicts URL: https://github.com/apache/spark/pull/44507 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] [SPARK-46615][CONNECT] Support s.c.immutable.ArraySeq in ArrowDeserializers [spark]

2024-01-07 Thread via GitHub
LuciferYang commented on code in PR #44618: URL: https://github.com/apache/spark/pull/44618#discussion_r1444238701 ## connector/connect/common/src/main/scala/org/apache/spark/sql/connect/client/arrow/ScalaCollectionUtils.scala: ## @@ -34,4 +34,8 @@ private[arrow] object ScalaCol