asfgit closed pull request #47464: [SPARK-48985][CONNECT] Connect Compatible
Expression Constructors
URL: https://github.com/apache/spark/pull/47464
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
hvanhovell commented on PR #47464:
URL: https://github.com/apache/spark/pull/47464#issuecomment-2254315594
Merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
ericm-db commented on code in PR #47508:
URL: https://github.com/apache/spark/pull/47508#discussion_r1694043815
##
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/OperatorStateMetadata.scala:
##
@@ -89,6 +91,40 @@ case class OperatorStateMetadataV2(
ove
anishshri-db commented on code in PR #47508:
URL: https://github.com/apache/spark/pull/47508#discussion_r1694039021
##
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/OperatorStateMetadata.scala:
##
@@ -89,6 +91,40 @@ case class OperatorStateMetadataV2(
anishshri-db commented on code in PR #47508:
URL: https://github.com/apache/spark/pull/47508#discussion_r1694037393
##
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TransformWithStateVariableUtils.scala:
##
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Softw
anishshri-db commented on code in PR #47508:
URL: https://github.com/apache/spark/pull/47508#discussion_r1694037223
##
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TransformWithStateExec.scala:
##
@@ -667,3 +711,32 @@ object TransformWithStateExec {
}
// sc
github-actions[bot] closed pull request #46085: [SPARK-47870][SQL] Optimize
predicate after push extra predicate through join
URL: https://github.com/apache/spark/pull/46085
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
SemyonSinchenko commented on PR #46368:
URL: https://github.com/apache/spark/pull/46368#issuecomment-2254250916
@HyukjinKwon @zhengruifeng Sorry for tagging but maybe you can take a look
again? I fixed everything from the last review round... Tnx in advance!
--
This is an automated messag
uros-db commented on code in PR #47154:
URL: https://github.com/apache/spark/pull/47154#discussion_r1694013340
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSQLExpressionsSuite.scala:
##
@@ -1789,44 +1798,90 @@ class CollationSQLExpressionsSuite
s"named_str
uros-db commented on code in PR #47154:
URL: https://github.com/apache/spark/pull/47154#discussion_r1694012773
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Mode.scala:
##
@@ -106,11 +155,13 @@ case class Mode(
val collationAwareBuffer =
HyukjinKwon commented on PR #47402:
URL: https://github.com/apache/spark/pull/47402#issuecomment-2254243027
Vote passed. This should be ready for a look, cc @hvanhovell
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
HyukjinKwon closed pull request #47497: [SPARK-49013] Change key in
collationsMap for Map and Array types in scala
URL: https://github.com/apache/spark/pull/47497
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
HyukjinKwon commented on PR #47497:
URL: https://github.com/apache/spark/pull/47497#issuecomment-2254241810
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
HyukjinKwon commented on code in PR #47493:
URL: https://github.com/apache/spark/pull/47493#discussion_r1694011602
##
python/pyspark/sql/dataframe.py:
##
@@ -30,6 +30,7 @@
overload,
TYPE_CHECKING,
)
+from typing_extensions import Concatenate, ParamSpec
Review Comment
HyukjinKwon commented on PR #47500:
URL: https://github.com/apache/spark/pull/47500#issuecomment-2254241177
hm, this works to be with this change:
```bash
sbin/start-connect-server.sh --conf spark.log.structuredLogging.enabled=false
starting org.apache.spark.sql.connect.service.S
HyukjinKwon commented on code in PR #47506:
URL: https://github.com/apache/spark/pull/47506#discussion_r1694010916
##
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala:
##
@@ -1739,6 +1739,32 @@ abstract class CSVSuite
Row(1, Date.value
HyukjinKwon commented on code in PR #47506:
URL: https://github.com/apache/spark/pull/47506#discussion_r1694010907
##
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala:
##
@@ -1739,6 +1739,32 @@ abstract class CSVSuite
Row(1, Date.value
GideonPotok commented on code in PR #47154:
URL: https://github.com/apache/spark/pull/47154#discussion_r1693998767
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Mode.scala:
##
@@ -106,11 +155,13 @@ case class Mode(
val collationAwareBuff
hvanhovell commented on code in PR #47464:
URL: https://github.com/apache/spark/pull/47464#discussion_r1693954290
##
connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##
@@ -1893,33 +1855,6 @@ class SparkConnectPlanner(
val un
junyuc25 commented on code in PR #47354:
URL: https://github.com/apache/spark/pull/47354#discussion_r1693947793
##
sql/core/src/test/scala/org/apache/spark/sql/RowSuite.scala:
##
@@ -123,4 +123,17 @@ class RowSuite extends SparkFunSuite with
SharedSparkSession {
paramete
ilicmarkodb commented on code in PR #47502:
URL: https://github.com/apache/spark/pull/47502#discussion_r1693311745
##
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/HashExpressionsSuite.scala:
##
@@ -620,6 +620,33 @@ class HashExpressionsSuite extends Spar
dongjoon-hyun commented on PR #47511:
URL: https://github.com/apache/spark/pull/47511#issuecomment-2253983087
Merged to master for Apache Spark 4.0.0-preview2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
dongjoon-hyun closed pull request #47511: [SPARK-49034][CORE] Support
server-side `sparkProperties` replacement in REST Submission API
URL: https://github.com/apache/spark/pull/47511
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
dongjoon-hyun commented on PR #47511:
URL: https://github.com/apache/spark/pull/47511#issuecomment-2253932363
Thank you, @yaooqinn .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
yaooqinn commented on PR #47485:
URL: https://github.com/apache/spark/pull/47485#issuecomment-2253877409
Thank you @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
yaooqinn commented on PR #47509:
URL: https://github.com/apache/spark/pull/47509#issuecomment-2253875178
@dongjoon-hyun, Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
26 matches
Mail list logo
