GitHub user adrian-wang reopened a pull request:
https://github.com/apache/spark/pull/6986
[SPARK-8195] [SPARK-8196] [WIP] [SQL] udf next_day last_day
I'll add unit test/function registry/codegen after #6782 get in.
You can merge this pull request into a Git repository by running
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/6988#issuecomment-124043548
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6988#discussion_r35299866
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala
---
@@ -258,3 +258,68 @@ case class
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/6988#issuecomment-123795012
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/6988#issuecomment-123572617
@chenghao-intel
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user adrian-wang opened a pull request:
https://github.com/apache/spark/pull/7589
[SPARK-8186] [SPARK-8187] [SQL] datetime function: date_add, date_sub
This subsumes #6782
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/7589#issuecomment-123584116
cc @chenghao-intel
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6988#discussion_r35186942
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -573,4 +573,10 @@ object DateTimeUtils
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7589#discussion_r35186862
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala
---
@@ -62,6 +62,53 @@ case class
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6988#discussion_r35185944
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala
---
@@ -258,3 +258,70 @@ case class
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6988#discussion_r35185903
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2262,6 +2246,22 @@ object functions
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6988#discussion_r35185971
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala
---
@@ -246,4 +247,45 @@ class
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7589#discussion_r35187996
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala
---
@@ -62,6 +62,53 @@ case class
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7589#discussion_r35189328
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala
---
@@ -62,6 +62,53 @@ case class
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7589#discussion_r35187201
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala
---
@@ -62,6 +62,53 @@ case class
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6988#discussion_r35187489
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala
---
@@ -258,3 +258,70 @@ case class
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/6988#issuecomment-123588320
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6988#discussion_r35184895
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala
---
@@ -258,3 +258,70 @@ case class
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6988#discussion_r35184929
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala
---
@@ -258,3 +258,70 @@ case class
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/6988#issuecomment-123662738
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/6988#issuecomment-123663017
@rxin something is wrong with Jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7589#discussion_r35196236
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala
---
@@ -62,6 +62,53 @@ case class
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6988#discussion_r35186005
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala
---
@@ -258,3 +258,70 @@ case class
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7589#discussion_r35281284
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala
---
@@ -258,3 +305,59 @@ case class
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/7589#issuecomment-123745566
@rxin On my second thought, I think we should keep date_add and date_sub as
simple as it should be. When it comes to Datetime IntervalType computation, we
need
GitHub user adrian-wang reopened a pull request:
https://github.com/apache/spark/pull/6988
[WIP] [SPARK-8176] [SPARK-8197] [SQL] Udf to_date/ trunc
I'll add unit test/function registry/codegen after #6782 get in.
You can merge this pull request into a Git repository by running
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/6984#issuecomment-122667450
Sure, will update it soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/5643#issuecomment-121587531
@marmbrus
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/7387#issuecomment-121141030
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user adrian-wang closed the pull request at:
https://github.com/apache/spark/pull/7387
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/6851#issuecomment-120885669
oh, it seems this pr has been merged but stay unclosed...
@davies @rxin
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user adrian-wang opened a pull request:
https://github.com/apache/spark/pull/7387
[SPARK-6851] [SQL] function least/greatest follow up
This is a follow up of remaining comments from #6851
You can merge this pull request into a Git repository by running:
$ git pull
Github user adrian-wang closed the pull request at:
https://github.com/apache/spark/pull/6851
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/6851#issuecomment-120831630
cc @davies
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6851#discussion_r34439865
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionals.scala
---
@@ -312,3 +313,103 @@ case class CaseKeyWhen(key
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6851#discussion_r34422678
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionals.scala
---
@@ -312,3 +313,103 @@ case class CaseKeyWhen(key
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6783#discussion_r34337039
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -387,3 +387,67 @@ case class MinOf(left
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6783#discussion_r34336689
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -387,3 +387,67 @@ case class MinOf(left
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6783#discussion_r34336814
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -387,3 +387,67 @@ case class MinOf(left
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/6851#issuecomment-120267517
@rxin @davies
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/6851#issuecomment-120227302
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/6851#issuecomment-120230751
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6783#discussion_r34323514
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ArithmeticExpressionSuite.scala
---
@@ -158,4 +157,18 @@ class
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6762#discussion_r34220506
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -206,6 +207,198 @@ public UTF8String toLowerCase() {
return
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6783#discussion_r34219567
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
---
@@ -439,6 +439,12 @@ object HiveTypeCoercion
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6762#discussion_r34219910
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
---
@@ -188,6 +189,302 @@ case class EndsWith
GitHub user adrian-wang opened a pull request:
https://github.com/apache/spark/pull/7234
[MINOR] [SQL] remove unused code in Exchange
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/adrian-wang/spark exchangeclean
Alternatively
GitHub user adrian-wang reopened a pull request:
https://github.com/apache/spark/pull/6985
[SPARK-8192] [SPARK-8193] [SQL] [WIP] udf current_date, current_timestamp
I'll add unit test/function registry/codegen after #6782 get in.
You can merge this pull request into a Git
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6985#discussion_r33805544
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DatetimeFunctionsSuite.scala
---
@@ -0,0 +1,40
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/6985#issuecomment-118092931
I think it again, and since System.currentTimeMillis is not so close to
what's inside, I designed to put it back.
---
If your project is set up for it, you can
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/6981#issuecomment-116949713
https://github.com/apache/spark/pull/6782#issuecomment-116888516
as @rxin mentioned, let's close this for now.
---
If your project is set up for it, you
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/6782#issuecomment-116949501
OK, I'll close these for now. Could you assign them all to me in case
duplicated work here?
---
If your project is set up for it, you can reply to this email
Github user adrian-wang closed the pull request at:
https://github.com/apache/spark/pull/6782
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/6984#issuecomment-116949836
Close it because
https://github.com/apache/spark/pull/6782#issuecomment-116888516 for now
---
If your project is set up for it, you can reply to this email
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/6988#issuecomment-116949768
Close it because
https://github.com/apache/spark/pull/6782#issuecomment-116888516 for now
---
If your project is set up for it, you can reply to this email
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/6986#issuecomment-116949809
Close it because
https://github.com/apache/spark/pull/6782#issuecomment-116888516 for now
---
If your project is set up for it, you can reply to this email
Github user adrian-wang closed the pull request at:
https://github.com/apache/spark/pull/6984
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user adrian-wang closed the pull request at:
https://github.com/apache/spark/pull/6985
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user adrian-wang closed the pull request at:
https://github.com/apache/spark/pull/6987
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user adrian-wang closed the pull request at:
https://github.com/apache/spark/pull/6988
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user adrian-wang closed the pull request at:
https://github.com/apache/spark/pull/6986
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/6985#issuecomment-116949828
Close it because
https://github.com/apache/spark/pull/6782#issuecomment-116888516 for now
---
If your project is set up for it, you can reply to this email
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/6987#issuecomment-116949793
Close it because
https://github.com/apache/spark/pull/6782#issuecomment-116888516 for now
---
If your project is set up for it, you can reply to this email
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6782#discussion_r0601
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala
---
@@ -0,0 +1,176 @@
+/*
+ * Licensed
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6782#discussion_r1281
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala
---
@@ -0,0 +1,176 @@
+/*
+ * Licensed
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6782#discussion_r1698
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala
---
@@ -0,0 +1,176 @@
+/*
+ * Licensed
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6782#discussion_r3367
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala
---
@@ -0,0 +1,176 @@
+/*
+ * Licensed
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6782#discussion_r3522
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala
---
@@ -0,0 +1,176 @@
+/*
+ * Licensed
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7035#discussion_r5998
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -188,6 +189,87 @@ case class Rint(child: Expression
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6976#discussion_r33124584
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -275,9 +279,6 @@ case class Atan2(left: Expression
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6976#discussion_r33124278
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -289,6 +290,97 @@ case class Pow(left: Expression
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/6981#issuecomment-114793713
I think this should wait #6782 , since we are creating a file with same
usage.
---
If your project is set up for it, you can reply to this email and have your
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6976#discussion_r33124454
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MathFunctionsSuite.scala
---
@@ -20,7 +20,7 @@ package
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6976#discussion_r33124487
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1047,6 +1047,22 @@ object functions {
def floor(columnName: String
GitHub user adrian-wang opened a pull request:
https://github.com/apache/spark/pull/6985
[SPARK-8192] [SPARK-8193] [SQL] [WIP] udf current_date, current_timestamp
I'll add unit test/function registry/codegen after #6782 get in.
You can merge this pull request into a Git repository
GitHub user adrian-wang opened a pull request:
https://github.com/apache/spark/pull/6984
[SPARK-8174] [SPARK-8175] [SPARK-8188] [SPARK-8191] [WIP] [SQL]
from_utc_timestamp, to_utc_timestamp,from_unixtime,unix_timestamp
I'll add unit test/function registry/codegen after #6782 get
GitHub user adrian-wang opened a pull request:
https://github.com/apache/spark/pull/6986
[SPARK-8195] [SPARK-8196] [WIP] [SQL] udf next_day last_day
I'll add unit test/function registry/codegen after #6782 get in.
You can merge this pull request into a Git repository by running
GitHub user adrian-wang opened a pull request:
https://github.com/apache/spark/pull/6987
[SPARK-8185] [SPARK-8194] [SPARK-8198] [WIP] [SQL] udf datediff
months_between add_months
I'll add unit test/function registry/codegen after #6782 get in.
You can merge this pull request
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6782#discussion_r33214991
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala
---
@@ -0,0 +1,176 @@
+/*
+ * Licensed
GitHub user adrian-wang opened a pull request:
https://github.com/apache/spark/pull/6988
[WIP] [SPARK-8176] [SPARK-8197] [SQL] Udf to_date/ trunc
I'll add unit test/function registry/codegen after #6782 get in.
You can merge this pull request into a Git repository by running
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6782#discussion_r33118085
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -946,6 +947,38 @@ object functions {
def cosh(columnName: String
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6782#discussion_r33117423
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala
---
@@ -0,0 +1,176 @@
+/*
+ * Licensed
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6782#discussion_r33117362
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -946,6 +947,38 @@ object functions {
def cosh(columnName: String
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/5717#discussion_r33010716
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoin.scala
---
@@ -82,86 +130,169 @@ case class SortMergeJoin
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/5717#issuecomment-113669761
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6782#discussion_r32807518
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala
---
@@ -0,0 +1,176 @@
+/*
+ * Licensed
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6782#discussion_r32807054
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala
---
@@ -0,0 +1,176 @@
+/*
+ * Licensed
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6782#discussion_r32807237
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala
---
@@ -0,0 +1,176 @@
+/*
+ * Licensed
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/6782#issuecomment-113399141
ping @rxin @marmbrus
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/6822#issuecomment-113362888
The return null comment?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/5717#discussion_r32802825
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoin.scala
---
@@ -36,46 +36,91 @@ import
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6782#discussion_r32798643
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala
---
@@ -0,0 +1,176 @@
+/*
+ * Licensed
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6779#discussion_r32802294
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6872#discussion_r32703641
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -154,6 +156,220 @@ case class Cos(child: Expression
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/6782#issuecomment-113061411
cc @rxin
Can you review this? This pr is the first PR for datetime functions and it
will created several files in upstream, hence all other datetime functions
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6843#discussion_r32702589
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
---
@@ -313,3 +313,131 @@ case class StringLength
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6775#discussion_r32702637
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
---
@@ -313,3 +312,78 @@ case class StringLength
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6843#discussion_r32672177
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
---
@@ -313,3 +313,131 @@ case class StringLength
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/6782#issuecomment-112997633
@chenghao-intel
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6775#discussion_r32691936
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
@@ -85,6 +86,52 @@ class DataFrameFunctionsSuite extends
201 - 300 of 794 matches
Mail list logo
