[GitHub] spark pull request: [SPARK-14513][CORE] Fix threads left behind af...

Github user chtyim commented on a diff in the pull request: https://github.com/apache/spark/pull/12318#discussion_r59338307 --- Diff: core/src/main/scala/org/apache/spark/HttpServer.scala --- @@ -155,6 +156,7 @@ private[spark] class HttpServer( throw new

[GitHub] spark pull request: [SPARK-14513][CORE] Fix threads left behind af...

Github user chtyim commented on a diff in the pull request: https://github.com/apache/spark/pull/12318#discussion_r59331847 --- Diff: core/src/main/scala/org/apache/spark/HttpServer.scala --- @@ -155,6 +156,7 @@ private[spark] class HttpServer( throw new

[GitHub] spark pull request: [SPARK-14513][CORE] Fix threads left behind af...

Github user chtyim commented on a diff in the pull request: https://github.com/apache/spark/pull/12318#discussion_r59326211 --- Diff: core/src/main/scala/org/apache/spark/HttpServer.scala --- @@ -155,6 +156,7 @@ private[spark] class HttpServer( throw new

[GitHub] spark pull request: [SPARK-14513][CORE] Fix threads left behind af...

Github user chtyim commented on the pull request: https://github.com/apache/spark/pull/12318#issuecomment-208718393 Addressed comment. Please have a look again. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-14513][CORE] Fix threads left behind af...

Github user chtyim commented on a diff in the pull request: https://github.com/apache/spark/pull/12318#discussion_r59320494 --- Diff: core/src/main/scala/org/apache/spark/HttpServer.scala --- @@ -155,6 +158,7 @@ private[spark] class HttpServer( throw new

[GitHub] spark pull request: [SPARK-14513][CORE] Fix threads left behind af...

Github user chtyim commented on a diff in the pull request: https://github.com/apache/spark/pull/12318#discussion_r59317619 --- Diff: core/src/main/scala/org/apache/spark/HttpServer.scala --- @@ -155,6 +158,7 @@ private[spark] class HttpServer( throw new

[GitHub] spark pull request: [SPARK-14513][CORE] Fix threads left behind af...

GitHub user chtyim opened a pull request: https://github.com/apache/spark/pull/12318 [SPARK-14513][CORE] Fix threads left behind after stopping SparkContext ## What changes were proposed in this pull request? Shutting down `QueuedThreadPool` used by Jetty `Server` to avoid

[GitHub] spark pull request: [SPARK-13441] [YARN] Fix NPE in yarn Client.cr...

Github user chtyim commented on the pull request: https://github.com/apache/spark/pull/11337#issuecomment-188707421 The reason why failing is bad in this case is because if either the `HADOOP_CONF_DIR` or the `YARN_CONF_DIR` is not readable, exception is raised, even if one of those

[GitHub] spark pull request: [SPARK-13441] [YARN] Fix NPE in yarn Client.cr...

Github user chtyim commented on the pull request: https://github.com/apache/spark/pull/11337#issuecomment-188416520 Thanks @srowen for the review. Do I need to do anything to get this PR merge? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-13441] [YARN] Fix NPE in yarn Client.cr...

Github user chtyim commented on a diff in the pull request: https://github.com/apache/spark/pull/11337#discussion_r53968653 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala --- @@ -537,9 +537,14 @@ private[spark] class Client( sys.env.get(envKey

[GitHub] spark pull request: [SPARK-13441] [YARN] Fix NPE in yarn Client.cr...

GitHub user chtyim opened a pull request: https://github.com/apache/spark/pull/11337 [SPARK-13441] [YARN] Fix NPE in yarn Client.createConfArchive method ## What changes were proposed in this pull request? Instead of using result of File.listFiles() directly, which may