[GitHub] spark pull request #17886: [SPARK-13983][SQL][WIP] Fix HiveThriftServer2 can...

2017-05-08 Thread chutium
Github user chutium commented on a diff in the pull request: https://github.com/apache/spark/pull/17886#discussion_r115196548 --- Diff: sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/HiveSessionImpl.java --- @@ -71,6 +71,10 @@ import

[GitHub] spark pull request: [SPARK-11100][SQL]HiveThriftServer HA issue,Hi...

2016-03-19 Thread chutium
Github user chutium commented on the pull request: https://github.com/apache/spark/pull/9113#issuecomment-197969602 +1 to this feature, may need to add this doc http://spark.apache.org/docs/latest/sql-programming-guide.html#running-the-thrift-jdbcodbc-server --- If your project is

[GitHub] spark pull request: [SPARK-10810] [SPARK-10902] [SQL] Improve sess...

2016-03-19 Thread chutium
Github user chutium commented on the pull request: https://github.com/apache/spark/pull/8909#issuecomment-198071715 anyone tried use --hivevar or --hiveconf with beeline after this change? variables from JDBC client is no more available in the hive session. refer to https

[GitHub] spark pull request: [SPARK-12053][CORE] EventLoggingListener.getLo...

2015-12-01 Thread chutium
Github user chutium commented on the pull request: https://github.com/apache/spark/pull/10044#issuecomment-160913033 it was caused by this commit about half years ago: https://github.com/apache/spark/commit/3bee0f1466ddd69f26e95297b5e0d2398b6c6268#diff

[GitHub] spark pull request: [SPARK-12053][CORE] EventLoggingListener.getLo...

2015-12-01 Thread chutium
Github user chutium commented on the pull request: https://github.com/apache/spark/pull/10044#issuecomment-160909430 @sarutak it seems branch-1.4 was correct with ```EventLoggingListener.getLogPath``` https://github.com/apache/spark/blob/v1.4.1/core/src/main/scala/org/apache

[GitHub] spark pull request: [SPARK-12053][CORE] EventLoggingListener.getLo...

2015-12-01 Thread chutium
Github user chutium commented on the pull request: https://github.com/apache/spark/pull/10044#issuecomment-160908412 thanks for merging, i will check this for branch-1.4 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-12053][CORE] EventLoggingListener.getLo...

2015-11-30 Thread chutium
Github user chutium commented on the pull request: https://github.com/apache/spark/pull/10044#issuecomment-160729514 ha, yes, it happens, okey, i will add some parameter names --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-12053][CORE] EventLoggingListener.getLo...

2015-11-30 Thread chutium
GitHub user chutium opened a pull request: https://github.com/apache/spark/pull/10044 [SPARK-12053][CORE] EventLoggingListener.getLogPath needs 4 parameters ```EventLoggingListener.getLogPath``` needs 4 input arguments: https://github.com/apache/spark/blob/v1.6.0-preview2/core

[GitHub] spark pull request: [SPARK-6910] [SQL] Support for pushing predica...

2015-07-17 Thread chutium
Github user chutium commented on the pull request: https://github.com/apache/spark/pull/7421#issuecomment-122318896 getPartitionsByFilter is really a great improvement, normally in a production hive data warehouse, there are tables with huge amount of partitions. looking forward to

[GitHub] spark pull request: [SPARK-2710] [SQL] Build SchemaRDD from a Jdbc...

2014-09-11 Thread chutium
Github user chutium commented on the pull request: https://github.com/apache/spark/pull/1612#issuecomment-55317048 thanks for the review, i will try to improve it soon, adding more external datasources is always helpful, then we can use Spark SQL as a data integration platform, and

[GitHub] spark pull request: [SPARK-2710] [SQL] Build SchemaRDD from a Jdbc...

2014-09-05 Thread chutium
Github user chutium commented on a diff in the pull request: https://github.com/apache/spark/pull/1612#discussion_r17203025 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcResultSetRDD.scala --- @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-2710] [SQL] Build SchemaRDD from a Jdbc...

2014-09-04 Thread chutium
Github user chutium commented on a diff in the pull request: https://github.com/apache/spark/pull/1612#discussion_r17101449 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcResultSetRDD.scala --- @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-3131][SQL] Allow user to set parquet co...

2014-08-26 Thread chutium
Github user chutium commented on the pull request: https://github.com/apache/spark/pull/2039#issuecomment-53408822 thanks @marmbrus , i change the property name and default codec --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-2710] [SQL] Build SchemaRDD from a Jdbc...

2014-08-26 Thread chutium
Github user chutium commented on a diff in the pull request: https://github.com/apache/spark/pull/1612#discussion_r16705825 --- Diff: core/src/main/scala/org/apache/spark/rdd/JdbcRDD.scala --- @@ -81,8 +113,14 @@ class JdbcRDD[T: ClassTag]( logInfo("statement fetch

[GitHub] spark pull request: [SPARK-2710] [SQL] Build SchemaRDD from a Jdbc...

2014-08-26 Thread chutium
Github user chutium commented on a diff in the pull request: https://github.com/apache/spark/pull/1612#discussion_r16705207 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JdbcResultSetRDDSuite.scala --- @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-2710] [SQL] Build SchemaRDD from a Jdbc...

2014-08-26 Thread chutium
Github user chutium commented on a diff in the pull request: https://github.com/apache/spark/pull/1612#discussion_r16704875 --- Diff: core/src/main/scala/org/apache/spark/rdd/JdbcRDD.scala --- @@ -57,6 +61,8 @@ class JdbcRDD[T: ClassTag]( mapRow: (ResultSet) =>

[GitHub] spark pull request: [SPARK-3065][SQL] Timestamp support in the par...

2014-08-25 Thread chutium
Github user chutium commented on the pull request: https://github.com/apache/spark/pull/2084#issuecomment-53243726 is this PR for SPARK-3065 or SPARK-3173 ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-3011][SQL] _temporary directory should ...

2014-08-22 Thread chutium
Github user chutium commented on a diff in the pull request: https://github.com/apache/spark/pull/1959#discussion_r16589482 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetTypes.scala --- @@ -373,9 +373,11 @@ private[parquet] object ParquetTypesConverter

[GitHub] spark pull request: [SPARK-3011][SQL] _temporary directory should ...

2014-08-21 Thread chutium
Github user chutium commented on a diff in the pull request: https://github.com/apache/spark/pull/1959#discussion_r16530668 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetTypes.scala --- @@ -373,9 +373,11 @@ private[parquet] object ParquetTypesConverter

[GitHub] spark pull request: [SPARK-3011][SQL] _temporary directory should ...

2014-08-21 Thread chutium
Github user chutium commented on a diff in the pull request: https://github.com/apache/spark/pull/1959#discussion_r16527681 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetTypes.scala --- @@ -373,9 +373,11 @@ private[parquet] object ParquetTypesConverter

[GitHub] spark pull request: [SPARK-3138][SQL] sqlContext.parquetFile shoul...

2014-08-20 Thread chutium
Github user chutium commented on the pull request: https://github.com/apache/spark/pull/2044#issuecomment-52748630 actually i totally agree with you @liancheng , this was reported in user list http://apache-spark-user-list.1001560.n3.nabble.com/sqlContext-parquetFile-path-fails-if

[GitHub] spark pull request: [SPARK-3138][SQL] sqlContext.parquetFile shoul...

2014-08-20 Thread chutium
Github user chutium commented on the pull request: https://github.com/apache/spark/pull/2044#issuecomment-52747630 actually i totally agree with you @liancheng , and it is not "try to handle", it is more like "try to ignore useless check"

[GitHub] spark pull request: [SPARK-3126][SPARK-3127][SQL] Fixed HiveThrift...

2014-08-19 Thread chutium
Github user chutium commented on the pull request: https://github.com/apache/spark/pull/2036#issuecomment-52713289 hmm... jenkins is not working again?... https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18886/consoleFull --- If your project is set up for it, you

[GitHub] spark pull request: [SPARK-3138][SQL] sqlContext.parquetFile shoul...

2014-08-19 Thread chutium
GitHub user chutium opened a pull request: https://github.com/apache/spark/pull/2044 [SPARK-3138][SQL] sqlContext.parquetFile should be able to take a single file as parameter ```if (!fs.getFileStatus(path).isDir) throw Exception``` make no sense after this commit #1370

[GitHub] spark pull request: [SPARK-3131][SQL] Allow user to set parquet co...

2014-08-19 Thread chutium
Github user chutium commented on the pull request: https://github.com/apache/spark/pull/2039#issuecomment-52707530 it seems failed test cases are not related to this PR, all of them are in sql/hive-thriftserver modul --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-3131][SQL] Allow user to set parquet co...

2014-08-19 Thread chutium
GitHub user chutium opened a pull request: https://github.com/apache/spark/pull/2039 [SPARK-3131][SQL] Allow user to set parquet compression codec for writing ParquetFile in SQLContext There are 4 different compression codec available for ```ParquetOutputFormat

[GitHub] spark pull request: [SPARK-2927][SQL] Add a conf to configure if w...

2014-08-18 Thread chutium
Github user chutium commented on a diff in the pull request: https://github.com/apache/spark/pull/1855#discussion_r16345194 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetTypes.scala --- @@ -403,7 +406,10 @@ private[parquet] object ParquetTypesConverter

[GitHub] spark pull request: [SPARK-2927][SQL] Add a conf to configure if w...

2014-08-15 Thread chutium
Github user chutium commented on a diff in the pull request: https://github.com/apache/spark/pull/1855#discussion_r16294353 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetTypes.scala --- @@ -403,7 +406,10 @@ private[parquet] object ParquetTypesConverter

[GitHub] spark pull request: [SPARK-2678] Follow-up commit for #1715 #1801,...

2014-08-08 Thread chutium
Github user chutium commented on the pull request: https://github.com/apache/spark/pull/1861#issuecomment-51660191 maybe ```spark-shell.cmd``` should also be changed? ```cmd /V /E /C %SPARK_HOME%\bin\spark-submit.cmd spark-shell --class org.apache.spark.repl.Main

[GitHub] spark pull request: [SPARK-2678] Follow-up commit for #1715 #1801,...

2014-08-08 Thread chutium
GitHub user chutium opened a pull request: https://github.com/apache/spark/pull/1861 [SPARK-2678] Follow-up commit for #1715 #1801, spark-shell is broken all options are not working... just run spark-shell with any options, such as --master ```./bin/spark-shell --master

[GitHub] spark pull request: Spark parquet improvements

2014-08-07 Thread chutium
Github user chutium commented on a diff in the pull request: https://github.com/apache/spark/pull/195#discussion_r15936076 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetRelation.scala --- @@ -72,16 +71,56 @@ case class ParquetRelation(val tableName: String

[GitHub] spark pull request: [SPARK-2179][SQL] Public API for DataTypes and...

2014-08-06 Thread chutium
Github user chutium commented on a diff in the pull request: https://github.com/apache/spark/pull/1346#discussion_r15862768 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala --- @@ -89,6 +88,44 @@ class SQLContext(@transient val sparkContext: SparkContext

[GitHub] spark pull request: [SPARK-2179][SQL] Public API for DataTypes and...

2014-08-05 Thread chutium
Github user chutium commented on a diff in the pull request: https://github.com/apache/spark/pull/1346#discussion_r15799720 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala --- @@ -89,6 +88,44 @@ class SQLContext(@transient val sparkContext: SparkContext

[GitHub] spark pull request: [SPARK-2179][SQL] Public API for DataTypes and...

2014-08-04 Thread chutium
Github user chutium commented on a diff in the pull request: https://github.com/apache/spark/pull/1346#discussion_r15766362 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala --- @@ -89,6 +88,44 @@ class SQLContext(@transient val sparkContext: SparkContext

[GitHub] spark pull request: [SPARK-2700] [SQL] Hidden files (such as .impa...

2014-08-01 Thread chutium
Github user chutium commented on the pull request: https://github.com/apache/spark/pull/1691#issuecomment-50859555 done, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-2700] [SQL] Hidden files (such as .impa...

2014-07-31 Thread chutium
GitHub user chutium opened a pull request: https://github.com/apache/spark/pull/1691 [SPARK-2700] [SQL] Hidden files (such as .impala_insert_staging) should be filtered out by sqlContext.parquetFile You can merge this pull request into a Git repository by running: $ git pull

[GitHub] spark pull request: [SPARK-2700] [SQL] Hidden files (such as .impa...

2014-07-31 Thread chutium
Github user chutium closed the pull request at: https://github.com/apache/spark/pull/1599 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-2729] [SQL] Forgot to match Timestamp t...

2014-07-31 Thread chutium
Github user chutium commented on the pull request: https://github.com/apache/spark/pull/1636#issuecomment-50733743 thanks a lot to you both, cast string to timestamp is really clever :) --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-2729] [SQL] Forgot to match Timestamp t...

2014-07-30 Thread chutium
Github user chutium commented on the pull request: https://github.com/apache/spark/pull/1636#issuecomment-50625472 if you have time, maybe take a look at #1612 ? it is about this ticket, https://issues.apache.org/jira/browse/SPARK-2710 , test suite just added. it will be a

[GitHub] spark pull request: [SPARK-2710] [SQL] Build SchemaRDD from a Jdbc...

2014-07-30 Thread chutium
Github user chutium commented on the pull request: https://github.com/apache/spark/pull/1612#issuecomment-50617738 Test Suite added --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-2729] [SQL] Forgot to match Timestamp t...

2014-07-30 Thread chutium
Github user chutium commented on the pull request: https://github.com/apache/spark/pull/1636#issuecomment-50593505 NullableColumnBuilderSuite: ... ... - TIMESTAMP column builder: empty column - TIMESTAMP column builder: buffer size auto growth - TIMESTAMP column

[GitHub] spark pull request: [SPARK-2710] [SQL] Build SchemaRDD from a Jdbc...

2014-07-30 Thread chutium
Github user chutium commented on a diff in the pull request: https://github.com/apache/spark/pull/1612#discussion_r15573659 --- Diff: core/src/main/scala/org/apache/spark/rdd/JdbcRDD.scala --- @@ -67,6 +69,28 @@ class JdbcRDD[T: ClassTag]( }).toArray

[GitHub] spark pull request: [SPARK-2710] [SQL] Build SchemaRDD from a Jdbc...

2014-07-30 Thread chutium
Github user chutium commented on a diff in the pull request: https://github.com/apache/spark/pull/1612#discussion_r15573636 --- Diff: core/src/main/scala/org/apache/spark/rdd/JdbcRDD.scala --- @@ -81,8 +105,10 @@ class JdbcRDD[T: ClassTag]( logInfo("statement fetch

[GitHub] spark pull request: [SPARK-2729] [SQL] Forgot to match Timestamp t...

2014-07-30 Thread chutium
Github user chutium commented on the pull request: https://github.com/apache/spark/pull/1636#issuecomment-50592256 it seems should be this one? NullableColumnBuilderSuite.scala i can do it --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-2729] Forgot to match Timestamp type in...

2014-07-29 Thread chutium
Github user chutium commented on the pull request: https://github.com/apache/spark/pull/1636#issuecomment-50531836 jo, thanks, i will add [SQL] next time --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-2729] Forgot to match Timestamp type in...

2014-07-29 Thread chutium
GitHub user chutium opened a pull request: https://github.com/apache/spark/pull/1636 [SPARK-2729] Forgot to match Timestamp type in ColumnBuilder just a match forgot, found after SPARK-2710 , TimestampType can be used by a SchemaRDD generated from JDBC ResultSet You can merge this

[GitHub] spark pull request: [SPARK-2710] [SQL] Build SchemaRDD from a Jdbc...

2014-07-29 Thread chutium
Github user chutium commented on a diff in the pull request: https://github.com/apache/spark/pull/1612#discussion_r15528919 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcResultSetRDD.scala --- @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-2710] [SQL] Build SchemaRDD from a Jdbc...

2014-07-29 Thread chutium
Github user chutium commented on a diff in the pull request: https://github.com/apache/spark/pull/1612#discussion_r15522818 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcResultSetRDD.scala --- @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-2710] [SQL] Build SchemaRDD from a Jdbc...

2014-07-29 Thread chutium
Github user chutium commented on a diff in the pull request: https://github.com/apache/spark/pull/1612#discussion_r15522485 --- Diff: core/src/main/scala/org/apache/spark/rdd/JdbcRDD.scala --- @@ -67,6 +69,28 @@ class JdbcRDD[T: ClassTag]( }).toArray

[GitHub] spark pull request: [SPARK-2710] [SQL] Build SchemaRDD from a Jdbc...

2014-07-28 Thread chutium
Github user chutium commented on a diff in the pull request: https://github.com/apache/spark/pull/1612#discussion_r15452368 --- Diff: core/src/main/scala/org/apache/spark/rdd/JdbcRDD.scala --- @@ -81,8 +105,10 @@ class JdbcRDD[T: ClassTag]( logInfo("statement fetch

[GitHub] spark pull request: [SPARK-2710] [SQL] Build SchemaRDD from a Jdbc...

2014-07-28 Thread chutium
Github user chutium commented on a diff in the pull request: https://github.com/apache/spark/pull/1612#discussion_r15451376 --- Diff: core/src/main/scala/org/apache/spark/rdd/JdbcRDD.scala --- @@ -67,6 +69,28 @@ class JdbcRDD[T: ClassTag]( }).toArray

[GitHub] spark pull request: SPARK-2710 Build SchemaRDD from a JdbcRDD with...

2014-07-27 Thread chutium
GitHub user chutium opened a pull request: https://github.com/apache/spark/pull/1612 SPARK-2710 Build SchemaRDD from a JdbcRDD with MetaData SPARK-2710 Build SchemaRDD from a JdbcRDD with MetaData and a small bug fix on JdbcRDD, line 109 it seems conn will never be

[GitHub] spark pull request: [SPARK-2700] [SQL] Hidden files (such as .impa...

2014-07-25 Thread chutium
Github user chutium closed the pull request at: https://github.com/apache/spark/pull/1599 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-2700] [SQL] Hidden files (such as .impa...

2014-07-25 Thread chutium
GitHub user chutium reopened a pull request: https://github.com/apache/spark/pull/1599 [SPARK-2700] [SQL] Hidden files (such as .impala_insert_staging) should be filtered out by sqlContext.parquetFile check if the path name starts with '.' You can merge this pull requ

[GitHub] spark pull request: [SPARK-2700] [SQL] Hidden files (such as .impa...

2014-07-25 Thread chutium
GitHub user chutium opened a pull request: https://github.com/apache/spark/pull/1599 [SPARK-2700] [SQL] Hidden files (such as .impala_insert_staging) should be filtered out by sqlContext.parquetFile check if the path name starts with '.' You can merge this pull request

[GitHub] spark pull request: SPARK-2407: Added Parser of SQL SUBSTR()

2014-07-18 Thread chutium
Github user chutium commented on the pull request: https://github.com/apache/spark/pull/1442#issuecomment-49407883 @egraldlo @willb thanks guys, substring is also added, @marmbrus test also done and passed. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: SPARK-2407: Added Parser of SQL SUBSTR()

2014-07-17 Thread chutium
Github user chutium commented on the pull request: https://github.com/apache/spark/pull/1442#issuecomment-49381658 and... how can i run a single test class using maven? i tried: mvn -Pyarn -Phive -Dhadoop.version=2.3.0-cdh5.0.3 -Dtest=SQLQuerySuite test but it does not work

[GitHub] spark pull request: SPARK-2407: Added Parser of SQL SUBSTR()

2014-07-17 Thread chutium
Github user chutium commented on the pull request: https://github.com/apache/spark/pull/1442#issuecomment-49379575 added a simple test in SQLQuerySuite --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: SPARK-2407: Added internal implementation of S...

2014-07-16 Thread chutium
Github user chutium commented on the pull request: https://github.com/apache/spark/pull/1359#issuecomment-49159677 PR submitted #1442 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: SPARK-2407: Added Parse of SQL SUBSTR()

2014-07-16 Thread chutium
GitHub user chutium opened a pull request: https://github.com/apache/spark/pull/1442 SPARK-2407: Added Parse of SQL SUBSTR() follow-up of #1359 You can merge this pull request into a Git repository by running: $ git pull https://github.com/chutium/spark master Alternatively

[GitHub] spark pull request: SPARK-2407: Added internal implementation of S...

2014-07-16 Thread chutium
Github user chutium commented on the pull request: https://github.com/apache/spark/pull/1359#issuecomment-49154812 hi, it is really very useful for us, i tried this implementation from @willb , in spark-shell, i still got java.lang.UnsupportedOperationException by Query Plan, i made