Github user evacchi commented on a diff in the pull request:
https://github.com/apache/spark/pull/6356#discussion_r41085605
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala ---
@@ -114,7 +114,7 @@ private[sql] object DataFrame {
@Experimental
class
Github user evacchi commented on the pull request:
https://github.com/apache/spark/pull/6356#issuecomment-139590891
Rerun tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user evacchi commented on the pull request:
https://github.com/apache/spark/pull/6356#issuecomment-139134399
Hope this still merges cleanly, I'm writing this from my phone. Otherwise
it'll have to wait till I'm back from holidays
---
If your project is set up
Github user evacchi commented on the pull request:
https://github.com/apache/spark/pull/6356#issuecomment-137717489
@marmbrus I have brought this up to date. Might need fixes in order to
merge cleanly, though
---
If your project is set up for it, you can reply to this email and have
Github user evacchi commented on the pull request:
https://github.com/apache/spark/pull/6356#issuecomment-124541682
tests should pass now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user evacchi commented on the pull request:
https://github.com/apache/spark/pull/6356#issuecomment-124413110
test build has not started
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user evacchi commented on the pull request:
https://github.com/apache/spark/pull/6356#issuecomment-124006964
@rxin I fixed today's merge conflicts; I would advise doing a merged build
once again and then (if, of course, the patch is good enough) to go ahead and
merge it
Github user evacchi commented on the pull request:
https://github.com/apache/spark/pull/6356#issuecomment-123202611
@rxin weird, didn't get those during local testing. BTW, they should now
pass
---
If your project is set up for it, you can reply to this email and have your
Github user evacchi commented on the pull request:
https://github.com/apache/spark/pull/6356#issuecomment-122858622
@rxin merge conflicts fixed; should pass tests as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user evacchi commented on the pull request:
https://github.com/apache/spark/pull/6356#issuecomment-122785825
ok, will check today
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user evacchi commented on the pull request:
https://github.com/apache/spark/pull/6349#issuecomment-107017015
Not exactly, this version uses a companion object. Same purpose, though
Il 30/mag/2015 09:31, "Reynold Xin" ha scritto:
> Is this change ident
Github user evacchi commented on the pull request:
https://github.com/apache/spark/pull/6319#issuecomment-106210025
@chenghao-intel although Batch may not be supposed to be public, inner
classes are still bad when it comes to sharing code (because they are not
static inner). I&#
Github user evacchi commented on a diff in the pull request:
https://github.com/apache/spark/pull/6356#discussion_r30967193
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -1321,3 +1201,137 @@ object SQLContext
Github user evacchi commented on a diff in the pull request:
https://github.com/apache/spark/pull/6356#discussion_r30966486
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -166,9 +166,9 @@ class SQLContext(@transient val sparkContext:
SparkContext
Github user evacchi commented on the pull request:
https://github.com/apache/spark/pull/6356#issuecomment-105153556
@chenghao-intel to me both solutions are fine, see PR #6122; however, this
solution would retain binary compatibility
---
If your project is set up for it, you can
Github user evacchi commented on the pull request:
https://github.com/apache/spark/pull/6122#issuecomment-104666150
addressed in PR #6356
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user evacchi opened a pull request:
https://github.com/apache/spark/pull/6356
[SQL] SPARK-6981: Factor out SparkPlanner and QueryExecution from SQLContext
Alternative to PR #6122; in this case the refactored out classes are
replaced by inner classes with the same name for
GitHub user evacchi opened a pull request:
https://github.com/apache/spark/pull/6349
[SPARK-7823] Refactor Strategy, Batch, FixedPoint out of class
RuleExecutor[T]
* Add companion object
* Add imports where necessary
You can merge this pull request into a Git repository by
Github user evacchi commented on the pull request:
https://github.com/apache/spark/pull/6122#issuecomment-104221975
Possible solution: add shims to preserve binary compatibility as follows:
```scala
class SQLContext {
...
@deprecated
class
Github user evacchi commented on the pull request:
https://github.com/apache/spark/pull/6122#issuecomment-104193613
Build fails because of this:
```
[info] spark-sql: found 3 potential binary incompatibilities (filtered 328)
[error] * class
Github user evacchi commented on the pull request:
https://github.com/apache/spark/pull/6122#issuecomment-104174843
@rxin may I ask if you can trigger a test build? code is the same as PR
#5556
---
If your project is set up for it, you can reply to this email and have your
reply
Github user evacchi commented on the pull request:
https://github.com/apache/spark/pull/6122#issuecomment-103014016
If everybody agrees, I think we can restart the Jenkins build (this is just
the same as the other PR, after all)
---
If your project is set up for it, you can reply to
Github user evacchi commented on the pull request:
https://github.com/apache/spark/pull/5806#issuecomment-102085238
Is `FunctionRegistry` supposed to use this `CatalystConf` as well ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user evacchi commented on a diff in the pull request:
https://github.com/apache/spark/pull/6122#discussion_r30308578
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -131,7 +181,7 @@ private[sql] abstract class SparkStrategies
Github user evacchi commented on a diff in the pull request:
https://github.com/apache/spark/pull/6122#discussion_r30307278
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -1429,3 +1293,95 @@ class SQLContext(@transient val sparkContext:
SparkContext
Github user evacchi commented on the pull request:
https://github.com/apache/spark/pull/5556#issuecomment-101699747
cleaned up in PR #6122. Disregard this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user evacchi closed the pull request at:
https://github.com/apache/spark/pull/5556
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user evacchi opened a pull request:
https://github.com/apache/spark/pull/6122
[SQL] SPARK-6981: Factor out SparkPlanner and QueryExecution from SQLContext
Cleaned-up version of PR #5556
You can merge this pull request into a Git repository by running:
$ git pull https
Github user evacchi commented on the pull request:
https://github.com/apache/spark/pull/5556#issuecomment-101552104
can you restart the Jenkins build? let's see if anything got messed up.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user evacchi commented on the pull request:
https://github.com/apache/spark/pull/5556#issuecomment-95485118
I tried to rebase. Hope it's not a problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user evacchi commented on the pull request:
https://github.com/apache/spark/pull/5556#issuecomment-95181457
I can confirm that the pyspark/sql/dataframe.py test case passes
successfully on my branch.
---
If your project is set up for it, you can reply to this email and have
Github user evacchi commented on the pull request:
https://github.com/apache/spark/pull/5556#issuecomment-94738010
I may be mistaken here but my code does not change any of PySpark, and the
stack trace seems to be pointing at a config error?
> akka.ConfigurationExcept
GitHub user evacchi opened a pull request:
https://github.com/apache/spark/pull/5556
[SQL] SPARK-6981: Factor out SparkPlanner and QueryExecution from SQLContext
Dependent types add additional, unnecessary complexity to third-parties who
may want to extend SQLContext with new
33 matches
Mail list logo
