[GitHub] spark issue #23224: [SPARK-26277][SQL][TEST] WholeStageCodegen metrics shoul...

2018-12-08 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/23224 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark issue #22707: [SPARK-25717][SQL] Insert overwrite a recreated external...

2018-12-07 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/22707 cc @wangyum --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #22683: [SPARK-25696] The storage memory displayed on spark Appl...

2018-12-07 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/22683 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark issue #23225: [SPARK-26287][CORE]Don't need to create an empty spill f...

2018-12-07 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/23225 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #23244: [SPARK-26289][CORE]cleanup enablePerfMetrics parameter f...

2018-12-06 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/23244 thanks, @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark pull request #23244: [SPARK-26289][CORE]cleanup enablePerfMetrics para...

2018-12-06 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/23244#discussion_r239671696 --- Diff: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java --- @@ -209,23 +205,14 @@ public BytesToBytesMap

[GitHub] spark issue #23244: [SPARK-26289][CORE]cleanup enablePerfMetrics parameter f...

2018-12-06 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/23244 cc @cloud-fan, @maropu, @kiszk --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark pull request #23244: [SPARK-26289][CORE]cleanup enablePerfMetrics para...

2018-12-06 Thread heary-cao
GitHub user heary-cao opened a pull request: https://github.com/apache/spark/pull/23244 [SPARK-26289][CORE]cleanup enablePerfMetrics parameter from BytesToBytesMap ## What changes were proposed in this pull request? `enablePerfMetrics `was originally designed in

[GitHub] spark pull request #23225: [MINOR][CORE]Don't need to create an empty spill ...

2018-12-05 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/23225#discussion_r239305307 --- Diff: core/src/main/java/org/apache/spark/shuffle/sort/ShuffleExternalSorter.java --- @@ -167,64 +167,67 @@ private void writeSortedFile(boolean

[GitHub] spark issue #23227: [SPARK-26271][FOLLOW-UP][SQL] remove unuse object SparkP...

2018-12-05 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/23227 thanks,@cloud-fan,@HyukjinKwon --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark issue #23227: [SPARK-26271][FOLLOW-UP][SQL] remove unuse object SparkP...

2018-12-05 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/23227 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark issue #23229: [MINOR][CORE] Modify some field name because it may be c...

2018-12-05 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/23229 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #23224: [MINOR][SQL][TEST] WholeStageCodegen metrics should be t...

2018-12-05 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/23224 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark issue #23229: [MINOR][CORE] Modify some field name because it may be c...

2018-12-05 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/23229 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #23163: [SPARK-26164][SQL] Allow FileFormatWriter to write multi...

2018-12-05 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/23163 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark issue #23227: [SPARK-16958][FOLLOW-UP][SQL] remove unuse object SparkP...

2018-12-05 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/23227 cc @cloud-fan, @gatorsmile, @hvanhovell ,@davies --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #23227: [SPARK-16958][FOLLOW-UP][SQL] remove unuse object...

2018-12-05 Thread heary-cao
GitHub user heary-cao opened a pull request: https://github.com/apache/spark/pull/23227 [SPARK-16958][FOLLOW-UP][SQL] remove unuse object SparkPlan ## What changes were proposed in this pull request? this code come from PR: https://github.com/apache/spark/pull/11190

[GitHub] spark issue #23194: [MINOR][SQL] Combine the same codes in test cases

2018-12-04 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/23194 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark issue #23194: [MINOR][SQL] Combine the same codes in test cases

2018-12-03 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/23194 LGTM, cc @HyukjinKwon. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #23190: [SPARK-26117][FOLLOW-UP][SQL]throw SparkOutOfMemoryError...

2018-12-03 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/23190 thanks, @cloud-fan @gatorsmile @kiszk. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23190: [MINOR][SQL]throw SparkOutOfMemoryError intead of SparkE...

2018-12-01 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/23190 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark issue #23190: [MINOR][SQL]throw SparkOutOfMemoryError intead of SparkE...

2018-11-30 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/23190 cc @cloud-fan @gatorsmile @kiszk --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands

[GitHub] spark pull request #23190: [MINOR][SQL]throw SparkOutOfMemoryError intead of...

2018-11-30 Thread heary-cao
GitHub user heary-cao opened a pull request: https://github.com/apache/spark/pull/23190 [MINOR][SQL]throw SparkOutOfMemoryError intead of SparkException in UnsafeHashedRelation ## What changes were proposed in this pull request? When build hash Map with one row of data and

[GitHub] spark pull request #23151: [SPARK-26180][CORE][TEST] Reuse withTempDir funct...

2018-11-30 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/23151#discussion_r238049434 --- Diff: core/src/test/scala/org/apache/spark/SparkContextSuite.scala --- @@ -245,8 +245,7 @@ class SparkContextSuite extends SparkFunSuite with

[GitHub] spark pull request #23151: [SPARK-26180][CORE][TEST] Add a withCreateTempDir...

2018-11-28 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/23151#discussion_r237362372 --- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala --- @@ -105,5 +105,16 @@ abstract class SparkFunSuite logInfo(s"

[GitHub] spark pull request #23151: [SPARK-26180][CORE][TEST] Add a withCreateTempDir...

2018-11-28 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/23151#discussion_r237344805 --- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala --- @@ -105,5 +105,16 @@ abstract class SparkFunSuite logInfo(s"

[GitHub] spark pull request #23151: [SPARK-26180][CORE][TEST] Add a withCreateTempDir...

2018-11-28 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/23151#discussion_r237333755 --- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala --- @@ -105,5 +105,16 @@ abstract class SparkFunSuite logInfo(s"

[GitHub] spark pull request #23151: [SPARK-26180][CORE][TEST] Add a withCreateTempDir...

2018-11-27 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/23151#discussion_r236922709 --- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala --- @@ -105,5 +105,16 @@ abstract class SparkFunSuite logInfo(s"

[GitHub] spark pull request #23151: [SPARK-26180][CORE][TEST] Add a withCreateTempDir...

2018-11-27 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/23151#discussion_r236919725 --- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala --- @@ -105,5 +105,16 @@ abstract class SparkFunSuite logInfo(s"

[GitHub] spark issue #23151: [SPARK-26180][CORE][TEST] Add a withCreateTempDir functi...

2018-11-27 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/23151 cc @cloud-fan, @kiszk, @dongjoon-hyun --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23138: [SPARK-23356][SQL][TEST] add new test cases for a + 1,a ...

2018-11-27 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/23138 @cloud-fan, @gatorsmile, @srowen thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23151: [SPARK-26180][CORE][TEST] Add a withCreateTempDir functi...

2018-11-27 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/23151 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark pull request #23151: [SPARK-26180][CORE][TEST] Add a withCreateTempDir...

2018-11-26 Thread heary-cao
GitHub user heary-cao opened a pull request: https://github.com/apache/spark/pull/23151 [SPARK-26180][CORE][TEST] Add a withCreateTempDir function to the SparkCore test case ## What changes were proposed in this pull request? Currently, the common `withTempDir` function is

[GitHub] spark issue #23138: [SPARK-23356][SQL][TEST] add new test cases for a + 1,a ...

2018-11-26 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/23138 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark issue #23138: [SPARK-23356][SQL][TEST] add new test cases for a + 1,a ...

2018-11-25 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/23138 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark issue #23138: [SPARK-23356][SQL] add new test cases for a + 1,a + b an...

2018-11-25 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/23138 cc @gatorsmile, @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #23138: [SPARK-23356][SQL] add new test cases for a + 1,a...

2018-11-25 Thread heary-cao
GitHub user heary-cao opened a pull request: https://github.com/apache/spark/pull/23138 [SPARK-23356][SQL] add new test cases for a + 1,a + b and Rand in SetOperationSuite ## What changes were proposed in this pull request? The purpose of this PR is supplement new test

[GitHub] spark pull request #20541: [SPARK-23356][SQL]Pushes Project to both sides of...

2018-11-25 Thread heary-cao
Github user heary-cao closed the pull request at: https://github.com/apache/spark/pull/20541 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20541: [SPARK-23356][SQL]Pushes Project to both sides of Union ...

2018-11-25 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/20541 @gatorsmile, OK, I will do it. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands

[GitHub] spark issue #23084: [SPARK-26117][CORE][SQL]use SparkOutOfMemoryError instea...

2018-11-23 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/23084 @cloud-fan,thanks --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark issue #23084: [SPARK-26117][CORE][SQL]use SparkOutOfMemoryError instea...

2018-11-21 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/23084 so this PR is just code cleanup, not a real bug. thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #23084: [SPARK-26117][CORE][SQL]use SparkOutOfMemoryError instea...

2018-11-21 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/23084 I think `growAndRehash` always thrown `SparkOutOfMemoryError`. catch `SparkOutOfMemoryError` or `OutOfMemoryError` will make `canGrowArray = false`. please correct if i understand something

[GitHub] spark issue #23084: [SPARK-26117][CORE][SQL]use SparkOutOfMemoryError instea...

2018-11-20 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/23084 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark issue #23084: [SPARK-26117][CORE][SQL]use SparkOutOfMemoryError instea...

2018-11-19 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/23084 @cloud-fan, I think not kill executor. the memory allocate fails, and the caller is notified to perform other operations. for example, HashAggregateExec will carry out spill the map and fallback

[GitHub] spark issue #23084: [SPARK-26117][CORE][SQL]use SparkOutOfMemoryError instea...

2018-11-19 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/23084 cc @cloud-fan @kiszk @dongjoon-hyun --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #23084: [SPARK-26117][CORE][SQL]use SparkOutOfMemoryError...

2018-11-19 Thread heary-cao
GitHub user heary-cao opened a pull request: https://github.com/apache/spark/pull/23084 [SPARK-26117][CORE][SQL]use SparkOutOfMemoryError instead of OutOfMemoryError when catch exception ## What changes were proposed in this pull request? the pr #20014 which introduced

[GitHub] spark issue #23044: [SPARK-26073][SQL][FOLLOW-UP] remove invalid comment as ...

2018-11-16 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/23044 thanks, @cloud-fan, @viirya, @kiszk. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23044: [SPARK-26073][SQL][FOLLOW-UP] remove invalid comment as ...

2018-11-15 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/23044 cc @cloud-fan, @viirya --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #23044: [SPARK-26073][SQL][FOLLOW-UP] remove invalid comm...

2018-11-15 Thread heary-cao
GitHub user heary-cao opened a pull request: https://github.com/apache/spark/pull/23044 [SPARK-26073][SQL][FOLLOW-UP] remove invalid comment as we don't use it anymore ## What changes were proposed in this pull request? remove invalid comment as we don't use

[GitHub] spark issue #22976: [SPARK-25974][SQL]Optimizes Generates bytecode for order...

2018-11-15 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/22976 thanks, All @cloud-fan, @rednaxelafx, @viirya, @kiszk --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark pull request #22998: [SPARK-26001][SQL]Reduce memory copy when writing...

2018-11-12 Thread heary-cao
Github user heary-cao closed the pull request at: https://github.com/apache/spark/pull/22998 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22998: [SPARK-26001][SQL]Reduce memory copy when writing decima...

2018-11-11 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/22998 @kiszk thank you for review it. - when writing null decimals: ``` OpenJDK 64-Bit Server VM 1.8.0_163-b01 on Windows 7 6.1 Intel64 Family 6 Model 94 Stepping 3, GenuineIntel

[GitHub] spark issue #22998: [SPARK-26001][SQL]Reduce memory copy when writing decima...

2018-11-11 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/22998 @mgaido91 thank you for review it. I added a test case to test "write a decimal with 16 bytes and then one with less than 8". then the current change the remaining 8 bytes would

[GitHub] spark pull request #22976: [SPARK-25974][SQL]Optimizes Generates bytecode fo...

2018-11-10 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/22976#discussion_r232474090 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala --- @@ -133,7 +126,6 @@ object

[GitHub] spark issue #22998: [SPARK-26001][SQL]Reduce memory copy when writing decima...

2018-11-09 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/22998 cc @mgaido91, @dongjoon-hyun , @cloud-fan , @kiszk --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #22998: [SPARK-26001][SQL]Reduce memory copy when writing...

2018-11-09 Thread heary-cao
GitHub user heary-cao opened a pull request: https://github.com/apache/spark/pull/22998 [SPARK-26001][SQL]Reduce memory copy when writing decimal ## What changes were proposed in this pull request? this PR fix 2 here: - when writing non-null decimals, we not zero

[GitHub] spark issue #22976: [SPARK-25974][SQL]Optimizes Generates bytecode for order...

2018-11-08 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/22976 cc @cloud-fan, @maropu, @kiszk --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark pull request #22976: [SPARK-25974][SQL]Optimizes Generates bytecode fo...

2018-11-08 Thread heary-cao
GitHub user heary-cao opened a pull request: https://github.com/apache/spark/pull/22976 [SPARK-25974][SQL]Optimizes Generates bytecode for ordering based on the given order ## What changes were proposed in this pull request? Currently, when generates the code for ordering

[GitHub] spark issue #22945: [SPARK-24066][SQL]Add new optimization rule to eliminate...

2018-11-05 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/22945 ping @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #22945: [SPARK-24066][SQL]Add new optimization rule to el...

2018-11-05 Thread heary-cao
GitHub user heary-cao opened a pull request: https://github.com/apache/spark/pull/22945 [SPARK-24066][SQL]Add new optimization rule to eliminate unnecessary sort by exchanged adjacent Window expressions ## What changes were proposed in this pull request? Currently, when

[GitHub] spark pull request #21139: [SPARK-24066][SQL]Add a window exchange rule to e...

2018-11-05 Thread heary-cao
Github user heary-cao closed the pull request at: https://github.com/apache/spark/pull/21139 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21860: [SPARK-24901][SQL]Merge the codegen of RegularHashMap an...

2018-10-31 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/21860 thanks, @cloud-fan, @maropu, @kiszk --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands

[GitHub] spark issue #22845: [SPARK-25848][SQL][TEST] Refactor CSVBenchmarks to use m...

2018-10-31 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/22845 thanks,@dongjoon-hyum --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #22755: [SPARK-25755][SQL][Test] Supplementation of non-CodeGen ...

2018-10-30 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/22755 thanks @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark issue #22845: [SPARK-25848][SQL][TEST] Refactor CSVBenchmarks to use m...

2018-10-29 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/22845 @dongjoon-hyun, Well, my office machine. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22845: [SPARK-25848][SQL][TEST] Refactor CSVBenchmarks to use m...

2018-10-29 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/22845 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark issue #22845: [SPARK-25848][SQL][TEST] Refactor CSVBenchmarks to use m...

2018-10-26 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/22845 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark issue #22844: [SPARK-25847][SQL][TEST] Refactor JSONBenchmarks to use ...

2018-10-26 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/22844 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark issue #22844: [SPARK-25847][SQL][TEST] Refactor JSONBenchmarks to use ...

2018-10-25 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/22844 cc @dongjoon-hyun, @wangyum --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #22845: [SPARK-25848][SQL][TEST] Refactor CSVBenchmarks to use m...

2018-10-25 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/22845 cc @dongjoon-hyun, @wangyum --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #22845: [SPARK-25848][SQL][TEST] Refactor CSVBenchmarks t...

2018-10-25 Thread heary-cao
GitHub user heary-cao opened a pull request: https://github.com/apache/spark/pull/22845 [SPARK-25848][SQL][TEST] Refactor CSVBenchmarks to use main method ## What changes were proposed in this pull request? use spark-submit: bin/spark-submit --class

[GitHub] spark pull request #22844: [SPARK-25847][SQL][TEST] Refactor JSONBenchmarks ...

2018-10-25 Thread heary-cao
GitHub user heary-cao opened a pull request: https://github.com/apache/spark/pull/22844 [SPARK-25847][SQL][TEST] Refactor JSONBenchmarks to use main method ## What changes were proposed in this pull request? Refactor JSONBenchmarks to use main method use spark

[GitHub] spark pull request #22842: [SPARK-25846][SQL][TEST] Refactor ExternalAppendO...

2018-10-25 Thread heary-cao
Github user heary-cao closed the pull request at: https://github.com/apache/spark/pull/22842 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22842: [SPARK-25846][SQL][TEST] Refactor ExternalAppendOnlyUnsa...

2018-10-25 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/22842 cc @dongjoon-hyun, @wangyum --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #22842: [SPARK-25846][SQL][TEST] Refactor ExternalAppendO...

2018-10-25 Thread heary-cao
GitHub user heary-cao opened a pull request: https://github.com/apache/spark/pull/22842 [SPARK-25846][SQL][TEST] Refactor ExternalAppendOnlyUnsafeRowArrayBenchmark to use main method ## What changes were proposed in this pull request? use spark-submit: bin/spark-submit

[GitHub] spark issue #21860: [SPARK-24901][SQL]Merge the codegen of RegularHashMap an...

2018-10-25 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/21860 cc @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #21860: [SPARK-24901][SQL]Merge the codegen of RegularHashMap an...

2018-10-24 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/21860 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark pull request #21860: [SPARK-24901][SQL]Merge the codegen of RegularHas...

2018-10-24 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/21860#discussion_r227706394 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala --- @@ -831,7 +832,14 @@ case class HashAggregateExec

[GitHub] spark issue #21860: [SPARK-24901][SQL]Merge the codegen of RegularHashMap an...

2018-10-23 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/21860 thanks, @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark issue #21860: [SPARK-24901][SQL]Merge the codegen of RegularHashMap an...

2018-10-23 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/21860 thanks, @cloud-fan , I will updated it. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22755: [SPARK-25755][SQL][Test] Supplementation of non-CodeGen ...

2018-10-23 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/22755 cc @maropu, @kiszk --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark issue #22755: [SPARK-25755][SQL][Test] Supplementation of non-CodeGen ...

2018-10-23 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/22755 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark issue #22755: [SPARK-25755][SQL][Test] Supplementation of non-CodeGen ...

2018-10-17 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/22755 cc @gatorsmile, @HyukjinKwon --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark pull request #22755: [SPARK-25755][SQL][Test] Supplementation of non-C...

2018-10-17 Thread heary-cao
GitHub user heary-cao opened a pull request: https://github.com/apache/spark/pull/22755 [SPARK-25755][SQL][Test] Supplementation of non-CodeGen unit tested for BroadcastHashJoinExec ## What changes were proposed in this pull request? Currently, the BroadcastHashJoinExec

[GitHub] spark issue #22695: [MINOR][SQL]remove Redundant semicolons

2018-10-11 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/22695 @srowen,thanks --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #22695: [MINOR][SQL]remove Redundant semicolons

2018-10-11 Thread heary-cao
GitHub user heary-cao opened a pull request: https://github.com/apache/spark/pull/22695 [MINOR][SQL]remove Redundant semicolons ## What changes were proposed in this pull request? remove Redundant semicolons in SortMergeJoinExec, thanks. ## How was this patch

[GitHub] spark issue #21860: [SPARK-24901][SQL]Merge the codegen of RegularHashMap an...

2018-09-16 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/21860 cc @maropu @kiszk @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark issue #21860: [SPARK-24901][SQL]Merge the codegen of RegularHashMap an...

2018-09-12 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/21860 cc @cloud-fan @hvanhovell thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands

[GitHub] spark issue #21968: [SPARK-24999][SQL]Reduce unnecessary 'new' memory operat...

2018-09-10 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/21968 @cloud-fan thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #21968: [SPARK-24999][SQL]Reduce unnecessary 'new' memory operat...

2018-09-05 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/21968 cc @cloud-fan @hvanhovell @maropu --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands

[GitHub] spark issue #21860: [SPARK-24901][SQL]Merge the codegen of RegularHashMap an...

2018-09-05 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/21860 cc @cloud-fan @hvanhovell @maropu --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands

[GitHub] spark pull request #21860: [SPARK-24901][SQL]Merge the codegen of RegularHas...

2018-09-03 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/21860#discussion_r214625811 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala --- @@ -853,33 +853,47 @@ case class

[GitHub] spark pull request #21968: [SPARK-24999][SQL]Reduce unnecessary 'new' memory...

2018-08-31 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/21968#discussion_r214502781 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/RowBasedHashMapGenerator.scala --- @@ -48,6 +48,8 @@ class

[GitHub] spark pull request #21968: [SPARK-24999][SQL]Reduce unnecessary 'new' memory...

2018-08-31 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/21968#discussion_r214502585 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/RowBasedHashMapGenerator.scala --- @@ -48,6 +48,8 @@ class

[GitHub] spark pull request #21968: [SPARK-24999][SQL]Reduce unnecessary 'new' memory...

2018-08-31 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/21968#discussion_r214294682 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/RowBasedHashMapGenerator.scala --- @@ -130,6 +134,12 @@ class

[GitHub] spark pull request #21968: [SPARK-24999][SQL]Reduce unnecessary 'new' memory...

2018-08-31 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/21968#discussion_r214294339 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/RowBasedHashMapGenerator.scala --- @@ -48,6 +48,12 @@ class

[GitHub] spark pull request #21968: [SPARK-24999][SQL]Reduce unnecessary 'new' memory...

2018-08-31 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/21968#discussion_r214293534 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/RowBasedHashMapGenerator.scala --- @@ -141,11 +151,8 @@ class

[GitHub] spark pull request #21968: [SPARK-24999][SQL]Reduce unnecessary 'new' memory...

2018-08-31 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/21968#discussion_r214293612 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/RowBasedHashMapGenerator.scala --- @@ -141,11 +151,8 @@ class

[GitHub] spark issue #21860: [SPARK-24901][SQL]Merge the codegen of RegularHashMap an...

2018-08-30 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/21860 cc @cloud-fan @maropu @kiszk --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark issue #21968: [SPARK-24999][SQL]Reduce unnecessary 'new' memory operat...

2018-08-30 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/21968 cc @cloud-fan @maropu --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

  1   2   3   4   5   >