[GitHub] spark issue #11205: [SPARK-11334][Core] Handle maximum task failure situatio...

2017-10-08 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/11205 I guess the issue still exists, let me verify the issue again, if it still exists I will bring the PR to latest. Thanks

[GitHub] spark issue #19396: [SPARK-22172][CORE] Worker hangs when the external shuff...

2017-09-29 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19396 IMO I think it might be better to throw an exception instead of shifting to another shuffle. Since user want to use external shuffle explicitly, letting user to know the issues and fix the issue

[GitHub] spark issue #19398: [SPARK-22174][CORE]Support to automatically create the d...

2017-09-29 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19398 AFAIK, this is a by-design choice to manually create event log directory. --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark issue #19358: [SPARK-22135] [MESOS] metrics in spark-dispatcher not be...

2017-09-28 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19358 Merging to master and branch 2.2. Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19287: [SPARK-22074][Core] Task killed by other attempt task sh...

2017-09-28 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19287 Generally it looks fine to me. CC @markhamstra @squito , would you please help to review it? Thanks

[GitHub] spark pull request #19287: [SPARK-22074][Core] Task killed by other attempt ...

2017-09-27 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19287#discussion_r141510861 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskInfo.scala --- @@ -74,6 +81,10 @@ class TaskInfo( gettingResultTime = time

[GitHub] spark issue #19358: [SPARK-22135] [MESOS] metrics in spark-dispatcher not be...

2017-09-27 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19358 LGTM. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #19338: [SPARK-22123][CORE] Add latest failure reason for task s...

2017-09-27 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19338 lGTM, merging to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #19346: [SAPRK-20785][WEB-UI][SQL] Spark should provide jump lin...

2017-09-27 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19346 OK, let me merge to master branch. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands

[GitHub] spark pull request #19338: [SPARK-22123][CORE] Add latest failure reason for...

2017-09-27 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19338#discussion_r141329721 --- Diff: core/src/test/scala/org/apache/spark/scheduler/BlacklistIntegrationSuite.scala --- @@ -115,8 +115,9 @@ class BlacklistIntegrationSuite extends

[GitHub] spark issue #19274: [SPARK-22056][Streaming] Add subconcurrency for KafkaRDD...

2017-09-27 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19274 This is because it is the only way to guarantee the ordering of data in Kafka partition mapping to Spark partition. Maybe some other users took as as an assumption to write the code

[GitHub] spark issue #19338: [SPARK-22123][CORE] Add latest failure reason for task s...

2017-09-27 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19338 Jenkins, retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark issue #19184: [SPARK-21971][CORE] Too many open files in Spark due to ...

2017-09-27 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19184 After discussed with @mridulm offline. Though the patch here cannot address the issue of `getSortedIterator` - which uses a PriorityQueue, somehow it solves the problem of `getIterator

[GitHub] spark issue #19338: [SPARK-22123][CORE] Add latest failure reason for task s...

2017-09-26 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19338 There's one related test failure, can you please check. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #19184: [SPARK-21971][CORE] Too many open files in Spark due to ...

2017-09-26 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19184 Hi @mridulm , sorry for late response. I agree with you that the scenario is different between here and shuffle, but the underlying structure and solutions to spill data is the same, so

[GitHub] spark pull request #19338: [SPARK-22123][CORE] Add latest failure reason for...

2017-09-26 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19338#discussion_r141235801 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -670,9 +670,12 @@ private[spark] class TaskSetManager

[GitHub] spark pull request #19338: [SPARK-22123][CORE] Add latest failure reason for...

2017-09-26 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19338#discussion_r141235459 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -670,9 +670,12 @@ private[spark] class TaskSetManager

[GitHub] spark issue #19358: [SPARK-22135] metrics in spark-dispatcher not being regi...

2017-09-26 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19358 Would you please add a [MESOS]tag in your PR title, like other PR did. Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark issue #19358: [SPARK-22135] metrics in spark-dispatcher not being regi...

2017-09-26 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19358 ok to test. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #19338: [SPARK-22123][CORE] Add latest failure reason for...

2017-09-26 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19338#discussion_r141234485 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -670,9 +670,12 @@ private[spark] class TaskSetManager

[GitHub] spark pull request #19338: [SPARK-22123][CORE] Add latest failure reason for...

2017-09-26 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19338#discussion_r141226978 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -671,8 +671,10 @@ private[spark] class TaskSetManager

[GitHub] spark pull request #19338: [SPARK-22123][CORE] Add latest failure reason for...

2017-09-26 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19338#discussion_r141226456 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetBlacklist.scala --- @@ -61,6 +61,16 @@ private[scheduler] class TaskSetBlacklist(val conf

[GitHub] spark issue #19263: [SPARK-22050][CORE] Allow BlockUpdated events to be opti...

2017-09-26 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19263 I see, thanks for the explanation. @vanzin would you please help to review this PR, thanks! --- - To unsubscribe, e

[GitHub] spark issue #19274: [SPARK-22056][Streaming] Add subconcurrency for KafkaRDD...

2017-09-26 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19274 Yes, I understand your scenario, but my concern is that your proposal is quite scenario specific, it may well serve your scenario, but somehow it breaks the design purpose of KafkaRDD. From my

[GitHub] spark issue #19263: [SPARK-22050][CORE] Allow BlockUpdated events to be opti...

2017-09-26 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19263 Hi @michaelmalak , history server only shows the last state of application before finished, and cached blocks can be evicted/unpersisted during the middle of application. So you probably cannot

[GitHub] spark issue #19274: [SPARK-22056][Streaming] Add subconcurrency for KafkaRDD...

2017-09-26 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19274 Hi @loneknightpy , think a bit on your PR, I think this can also be done in the user side. User could create several threads in one task (RDD#mapPartitions) to consume the records concurrently

[GitHub] spark pull request #19338: [SPARK-22123][CORE] Add latest failure reason for...

2017-09-26 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19338#discussion_r141002261 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetBlacklist.scala --- @@ -61,6 +61,8 @@ private[scheduler] class TaskSetBlacklist(val conf

[GitHub] spark pull request #19338: [SPARK-22123][CORE] Add latest failure reason for...

2017-09-26 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19338#discussion_r141001713 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -671,8 +671,9 @@ private[spark] class TaskSetManager

[GitHub] spark pull request #19287: [SPARK-22074][Core] Task killed by other attempt ...

2017-09-26 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19287#discussion_r140996395 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskInfo.scala --- @@ -74,6 +81,10 @@ class TaskInfo( gettingResultTime = time

[GitHub] spark pull request #19287: [SPARK-22074][Core] Task killed by other attempt ...

2017-09-26 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19287#discussion_r140995846 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskInfo.scala --- @@ -66,6 +66,13 @@ class TaskInfo( */ var finishTime: Long = 0

[GitHub] spark issue #19346: [SAPRK-20785][WEB-UI][SQL] Spark should provide jump lin...

2017-09-26 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19346 GLTM. @gatorsmile , would you please take a look at this PR, is it good for you? --- - To unsubscribe, e-mail: reviews

[GitHub] spark issue #19346: Spark should provide jump links and add (count) in the S...

2017-09-25 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19346 Please fix the title. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #19346: Spark should provide jump links and add (count) in the S...

2017-09-25 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19346 ok to test. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #18015: [SAPRK-20785][WEB-UI][SQL]Spark should provide jump link...

2017-09-25 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/18015 There's still left comment not addressed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19303: [SPARK-22085][CORE]When the application has no core left...

2017-09-22 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19303 IIUC, if there's no core left, requesting new executors should be a no-op, am I right? So there should be no problem even without your fix? From your patch, it looks like you're putting

[GitHub] spark issue #19315: Updated english.txt word ordering

2017-09-21 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19315 @animenon can you please fix the PR title like what other PR did. Also is this only for better readability or do you fix any other issue? IMO, I found that previous txt is more readable than your

[GitHub] spark issue #18015: [SAPRK-20785][WEB-UI][SQL]Spark should provide jump link...

2017-09-21 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/18015 Yes, I'm fine with it. @ajbozarth would you please take another look on this PR? Thanks. --- - To unsubscribe, e-mail

[GitHub] spark issue #18015: [SAPRK-20785][WEB-UI][SQL]Spark should provide jump link...

2017-09-21 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/18015 Jenkins, retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark pull request #18015: [SAPRK-20785][WEB-UI][SQL]Spark should provide ju...

2017-09-21 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/18015#discussion_r140416046 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala --- @@ -61,7 +59,37 @@ private[ui] class AllExecutionsPage

[GitHub] spark issue #19074: [SPARK-21714][CORE][BACKPORT-2.2] Avoiding re-uploading ...

2017-09-21 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19074 @loneknightpy can you please elaborate more about the issue? I believe you brought this remote resources support in #18078. It doesn't support cluster mode from beginning. Also your

[GitHub] spark pull request #19074: [SPARK-21714][CORE][BACKPORT-2.2] Avoiding re-upl...

2017-09-21 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19074#discussion_r140159631 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -366,7 +376,7 @@ object SparkSubmit extends CommandLineUtils

[GitHub] spark pull request #19074: [SPARK-21714][CORE][BACKPORT-2.2] Avoiding re-upl...

2017-09-21 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19074#discussion_r140159376 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -376,8 +386,8 @@ object SparkSubmit extends CommandLineUtils

[GitHub] spark pull request #19074: [SPARK-21714][CORE][BACKPORT-2.2] Avoiding re-upl...

2017-09-21 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19074#discussion_r140159253 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -366,7 +376,7 @@ object SparkSubmit extends CommandLineUtils

[GitHub] spark issue #19274: [SPARK-22056][Streaming] Add subconcurrency for KafkaRDD...

2017-09-21 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19274 Will this break the assumption that one Kafka partition will map to one Spark partition? --- - To unsubscribe, e-mail

[GitHub] spark issue #19160: [SPARK-21934][CORE] Expose Shuffle Netty memory usage to...

2017-09-20 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19160 Thanks all for your review, let me merge to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #19277: [SPARK-22058][CORE]the BufferedInputStream will not be c...

2017-09-20 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19277 Strictly saying, this line `new BufferedInputStream(fs.open(log))` will also throw exception, shouldn't you try-catch

[GitHub] spark issue #19145: [spark-21933][yarn] Spark Streaming request more executo...

2017-09-20 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19145 @klion26 , this is not a problem related to Spark Streaming and Structured Streaming. For any Spark application it will run into this problem. This is basically a YARN problem and looks hard

[GitHub] spark pull request #19277: [SPARK-22058][CORE]the BufferedInputStream will n...

2017-09-19 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19277#discussion_r139867429 --- Diff: core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala --- @@ -351,11 +351,11 @@ private[spark] object EventLoggingListener

[GitHub] spark pull request #19277: [SPARK-22058][CORE]the BufferedInputStream will n...

2017-09-19 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19277#discussion_r139867369 --- Diff: core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala --- @@ -351,11 +351,11 @@ private[spark] object EventLoggingListener

[GitHub] spark issue #19285: [SPARK-22068][CORE]Reduce the duplicate code between put...

2017-09-19 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19285 ok to test. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #19160: [SPARK-21934][CORE] Expose Shuffle Netty memory u...

2017-09-19 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19160#discussion_r139861892 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleClient.java --- @@ -117,6 +118,12 @@ public void

[GitHub] spark pull request #19160: [SPARK-21934][CORE] Expose Shuffle Netty memory u...

2017-09-19 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19160#discussion_r139861341 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -115,6 +115,7 @@ private[spark] class Executor( if (!isLocal

[GitHub] spark pull request #19160: [SPARK-21934][CORE] Expose Shuffle Netty memory u...

2017-09-19 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19160#discussion_r139861303 --- Diff: core/src/main/scala/org/apache/spark/deploy/ExternalShuffleServiceSource.scala --- @@ -19,19 +19,19 @@ package org.apache.spark.deploy

[GitHub] spark pull request #19160: [SPARK-21934][CORE] Expose Shuffle Netty memory u...

2017-09-19 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19160#discussion_r139860969 --- Diff: core/src/main/scala/org/apache/spark/network/netty/NettyBlockTransferService.scala --- @@ -18,11 +18,14 @@ package

[GitHub] spark pull request #19160: [SPARK-21934][CORE] Expose Shuffle Netty memory u...

2017-09-19 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19160#discussion_r139860924 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -248,6 +251,16 @@ private[spark] class BlockManager( logInfo(s

[GitHub] spark issue #19130: [SPARK-21917][CORE][YARN] Supporting adding http(s) reso...

2017-09-19 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19130 Hi @cloud-fan , the main purpose of `spark.yarn.dist.forceDownloadSchemes` is to explicitly using Spark's own logic to handle remote resources instead of relying on Hadoop. For example

[GitHub] spark pull request #19130: [SPARK-21917][CORE][YARN] Supporting adding http(...

2017-09-19 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19130#discussion_r139608374 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -385,4 +385,14 @@ package object config { .checkValue(v

[GitHub] spark issue #19145: [spark-21933][yarn] Spark Streaming request more executo...

2017-09-19 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19145 And based on your fix: 1. looks like you don't have retention mechanism, which will potential introduce memory leak. 2. I don't see your logic to avoid requesting new containers

[GitHub] spark issue #19145: [spark-21933][yarn] Spark Streaming request more executo...

2017-09-19 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19145 >But if we restart the RM, then, the lost containers in the NM will be reported to RM as lost again because of recovery Since you already enabled RM and NM recovery, IIUC the fail

[GitHub] spark pull request #19211: [SPARK-18838][core] Add separate listener queues ...

2017-09-19 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19211#discussion_r139606603 --- Diff: core/src/main/scala/org/apache/spark/scheduler/AsyncEventQueue.scala --- @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #19210: [SPARK-22030][CORE] GraphiteSink fails to re-connect to ...

2017-09-18 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19210 LGTM, merging to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #19074: [SPARK-21714][CORE][BACKPORT-2.2] Avoiding re-uploading ...

2017-09-18 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19074 @loneknightpy did you open a new JIRA about this issue? AFAIK, downloading resources to local disk is not supported for cluster mode even from beginning, would you please elaborate

[GitHub] spark pull request #19130: [SPARK-21917][CORE][YARN] Supporting adding http(...

2017-09-18 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19130#discussion_r139577257 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -385,4 +385,13 @@ package object config { .checkValue(v

[GitHub] spark pull request #19130: [SPARK-21917][CORE][YARN] Supporting adding http(...

2017-09-18 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19130#discussion_r139577191 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -367,6 +368,54 @@ object SparkSubmit extends CommandLineUtils with Logging

[GitHub] spark pull request #19130: [SPARK-21917][CORE][YARN] Supporting adding http(...

2017-09-18 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19130#discussion_r139576893 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -367,6 +368,54 @@ object SparkSubmit extends CommandLineUtils with Logging

[GitHub] spark pull request #19130: [SPARK-21917][CORE][YARN] Supporting adding http(...

2017-09-18 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19130#discussion_r139576814 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -367,6 +368,54 @@ object SparkSubmit extends CommandLineUtils with Logging

[GitHub] spark issue #19145: [spark-21933][yarn] Spark Streaming request more executo...

2017-09-18 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19145 Did you enable RM or NM recovery, can you please clarify it? Normally, if we assume there's are 2 containers running on this NM, after 10 minutes, RM will detect the failure of NM

[GitHub] spark issue #19160: [SPARK-21934][CORE] Expose Shuffle Netty memory usage to...

2017-09-18 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19160 @zsxwing @jiangxb1987 would you please help to review this PR when you have time, thanks a lot. --- - To unsubscribe, e-mail

[GitHub] spark issue #19263: Optionally add block updates to log

2017-09-18 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19263 @michaelmior would you please follow the instruction (https://spark.apache.org/contributing.html) to update PR title and create a corresponding JIRA, thanks

[GitHub] spark issue #19145: [spark-21933][yarn] Spark Streaming request more executo...

2017-09-18 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19145 Hi @klion26 , sorry for the late response. Can we please understand the problem first, would you please describe your problem in detail and how to reproduce your issue

[GitHub] spark issue #19210: [SPARK-22030][CORE] GraphiteSink fails to re-connect to ...

2017-09-18 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19210 LGTM, let me retest this again. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark issue #19210: [SPARK-22030][CORE] GraphiteSink fails to re-connect to ...

2017-09-18 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19210 Jenkins, retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark issue #19171: [SPARK-21902][CORE] Print root cause for BlockManager#do...

2017-09-15 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19171 Ok, seems the test is passed, let me merge to master branch. Please be noted such trivial fix usually doesn't require a JIRA, also please think carefully about the necessity of such fix

[GitHub] spark issue #19233: [Spark-22008][Streaming]Spark Streaming Dynamic Allocati...

2017-09-14 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19233 IIUC streaming DRA seems an obsolete code. Long ago when I played with it, there existed some bugs, but seems not so many users used this feature. I'm not sure if we really need to put efforts

[GitHub] spark pull request #19130: [SPARK-21917][CORE][YARN] Supporting adding http(...

2017-09-14 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19130#discussion_r139053961 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -367,6 +368,54 @@ object SparkSubmit extends CommandLineUtils with Logging

[GitHub] spark issue #19171: [SPARK-21902][CORE] Print root cause for BlockManager#do...

2017-09-14 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19171 ok to test. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #19171: [SPARK-21902][CORE] Print root cause for BlockMan...

2017-09-14 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19171#discussion_r139053438 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -988,6 +988,12 @@ private[spark] class BlockManager

[GitHub] spark issue #19210: Fix Graphite re-connects for Graphite instances behind E...

2017-09-14 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19210 BTW, can you please create a JIRA, and fix the PR title like other PRs. --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark issue #19133: [SPARK-21902][CORE] Uniform calling for DiskBlockManager...

2017-09-14 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19133 This is not a necessary fix. We usually don't do such changes without really fix anything. --- - To unsubscribe, e-mail

[GitHub] spark pull request #19227: [SPARK-20060][CORE] Support accessing secure Hado...

2017-09-14 Thread jerryshao
Github user jerryshao closed the pull request at: https://github.com/apache/spark/pull/19227 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19227: [SPARK-20060][CORE] Support accessing secure Hadoop clus...

2017-09-14 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19227 I see, so based on your comments: 1. Mesos should not honor principal/keytab configuration. Instead of rename them, we should remove the `MESOS` here

[GitHub] spark issue #19227: [SPARK-20060][CORE] Support accessing secure Hadoop clus...

2017-09-14 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19227 > I don't think Mesos honors it (and it shouldn't be, since IIRC it hasn't implemented long-lived app support yet). Current Spark on Mesos code actually hon

[GitHub] spark pull request #19210: Fix Graphite re-connects for Graphite instances b...

2017-09-14 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19210#discussion_r139045423 --- Diff: core/src/main/scala/org/apache/spark/metrics/sink/GraphiteSink.scala --- @@ -69,7 +69,7 @@ private[spark] class GraphiteSink(val property

[GitHub] spark issue #19227: [SPARK-20060][CORE] Support accessing secure Hadoop clus...

2017-09-14 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19227 The purpose of changing configuration name is that these configurations are not only used by yarn mode in `SparkSubmit`, Mesos, local will also honor this, so that's why I rename them. What do

[GitHub] spark pull request #19130: [SPARK-21917][CORE][YARN] Supporting adding http(...

2017-09-14 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19130#discussion_r139041065 --- Diff: core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala --- @@ -897,6 +897,76 @@ class SparkSubmitSuite sysProps

[GitHub] spark issue #19227: [SPARK-20060][CORE] Support accessing secure Hadoop clus...

2017-09-14 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19227 Hi @vanzin thanks a lot for your comments. Would you please elaborate more? I'm not sure if I really understand your comment. According to this PR I don't think I ship the keytab around

[GitHub] spark issue #19132: [SPARK-21922] Fix duration always updating when task fai...

2017-09-14 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19132 Cannot cleanly merge to 2.2, so this will only land to master branch. --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark issue #19132: [SPARK-21922] Fix duration always updating when task fai...

2017-09-14 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19132 LGTM, merging to master, if possible to 2.2. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19210: Fix Graphite re-connects for Graphite instances b...

2017-09-14 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19210#discussion_r138879962 --- Diff: core/src/main/scala/org/apache/spark/metrics/sink/GraphiteSink.scala --- @@ -69,7 +69,7 @@ private[spark] class GraphiteSink(val property

[GitHub] spark pull request #19130: [SPARK-21917][CORE][YARN] Supporting adding http(...

2017-09-14 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19130#discussion_r138827462 --- Diff: core/src/main/scala/org/apache/spark/deploy/DependencyUtils.scala --- @@ -123,6 +123,11 @@ private[deploy] object DependencyUtils

[GitHub] spark issue #19210: Fix Graphite re-connects for Graphite instances behind E...

2017-09-14 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19210 Jenkins, retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark pull request #19132: [SPARK-21922] Fix duration always updating when t...

2017-09-14 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19132#discussion_r138805063 --- Diff: core/src/main/scala/org/apache/spark/status/api/v1/AllStagesResource.scala --- @@ -69,7 +70,8 @@ private[v1] object AllStagesResource

[GitHub] spark pull request #19130: [SPARK-21917][CORE][YARN] Supporting adding http(...

2017-09-13 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19130#discussion_r138801682 --- Diff: core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala --- @@ -897,6 +897,80 @@ class SparkSubmitSuite sysProps

[GitHub] spark pull request #19130: [SPARK-21917][CORE][YARN] Supporting adding http(...

2017-09-13 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19130#discussion_r138801550 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -367,6 +368,53 @@ object SparkSubmit extends CommandLineUtils with Logging

[GitHub] spark pull request #19130: [SPARK-21917][CORE][YARN] Supporting adding http(...

2017-09-13 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19130#discussion_r138791246 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -367,6 +368,53 @@ object SparkSubmit extends CommandLineUtils with Logging

[GitHub] spark issue #19210: Fix Graphite re-connects for Graphite instances behind E...

2017-09-13 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19210 @HyukjinKwon would you please help to trigger the Jenkins? Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark pull request #19132: [SPARK-21922] Fix duration always updating when t...

2017-09-13 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19132#discussion_r138789492 --- Diff: core/src/main/scala/org/apache/spark/status/api/v1/OneStageResource.scala --- @@ -81,7 +83,8 @@ private[v1] class OneStageResource(ui: SparkUI

[GitHub] spark pull request #19132: [SPARK-21922] Fix duration always updating when t...

2017-09-13 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19132#discussion_r138789213 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/UIData.scala --- @@ -97,6 +97,7 @@ private[spark] object UIData { var memoryBytesSpilled

[GitHub] spark pull request #19227: [SPARK-20060][CORE] Support accessing secure Hado...

2017-09-13 Thread jerryshao
GitHub user jerryshao opened a pull request: https://github.com/apache/spark/pull/19227 [SPARK-20060][CORE] Support accessing secure Hadoop cluster in standalone client mode ## What changes were proposed in this pull request? This PR leverages the facility of SPARK-16742

[GitHub] spark issue #19135: [SPARK-21923][CORE]Avoid calling reserveUnrollMemoryForT...

2017-09-13 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19135 So it somehow reflects that CPU core contention is the main issue for memory pre-occupation , am I right? AFAIK from our customer, we usually don't allocate so many cores to one executor

<    3   4   5   6   7   8   9   10   11   12   >