GitHub user jiangxb1987 opened a pull request:
https://github.com/apache/spark/pull/19669
[BUILD] Close stale PRs
Closes #11494
Closes #14158
Closes #16803
Closes #16864
Closes #17455
Closes #17936
Closes #18406
Closes #19377
Also cc @srowen
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/17436
ping @kiszk
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/17702
cc @zsxwing
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19408
@obermeier Could you please rebase this with the latest master? Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19285
@ConeyLiu Could you rebase this with the latest master so we can continue
review it? Thanks!
---
-
To unsubscribe, e-mail
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19170
ping @zhouyejoe
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19118
ping @awarrior Could you please fix the test failure?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/17980
@dongjoon-hyun Do we still need this PR?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/18624
ping @WeichenXu123
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19045
Are you still working on this? @holdenk
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/18916
Should we continue with this PR? @gatorsmile @srowen @HyukjinKwon
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/11994
@jerryshao Could you please rebase this PR then we can start review it?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/18791
@ericvandenbergfb Could you please rebase this to the latest master so we
can continue review it? Also cc @vanzin @jerryshao
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19640
cc @ueshin
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19532
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19532
lgtm
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19586
also cc @WeichenXu123
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19649#discussion_r148810633
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -619,8 +619,10 @@ private[spark] class HiveExternalCatalog
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19649#discussion_r148810142
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogEventSuite.scala
---
@@ -104,6 +109,8 @@ class
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r148569836
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactory.scala
---
@@ -0,0 +1,227
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r148566806
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactory.scala
---
@@ -0,0 +1,227
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r148578359
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactory.scala
---
@@ -0,0 +1,227
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r148300912
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala
---
@@ -0,0
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r148044235
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala
---
@@ -0,0 +1,103
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r148040015
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/SchedulerBackendUtils.scala
---
@@ -0,0 +1,47 @@
+/*
+ * Licensed
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r148300842
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala
---
@@ -0,0
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r148042590
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/ConfigurationUtils.scala
---
@@ -0,0 +1,58
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19396
The change itself looks good to me, WDYT @jerryshao @cloud-fan ?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/18251
lgtm
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19532#discussion_r147665765
--- Diff: core/src/main/scala/org/apache/spark/ui/SparkUI.scala ---
@@ -120,7 +120,7 @@ private[spark] class SparkUI private (
attemptId
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15049#discussion_r147555719
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala
---
@@ -370,13 +372,11 @@ class
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19077#discussion_r147179694
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -118,7 +118,8 @@ private [sql] object
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19529#discussion_r146591649
--- Diff: core/src/test/scala/org/apache/spark/SharedSparkContext.scala ---
@@ -29,10 +29,25 @@ trait SharedSparkContext extends BeforeAndAfterAll
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19529#discussion_r146595869
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/SharedSQLContext.scala ---
@@ -17,86 +17,8 @@
package org.apache.spark.sql.test
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19529#discussion_r146595345
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/SQLTestUtils.scala ---
@@ -52,17 +55,142 @@ import org.apache.spark.util
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19540
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19540
Could you check why the test cases failed? Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19534
@sitalkedia That makes sense. The proposed solutions are quite similar, we
can choose to continue with either PR, WDYT @jerryshao @sitalkedia
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19485
Sure, I'll be working on this for this weekend. Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19458
ping @superbobry
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19396
IMO we should throw a new Exception in order to fail fast, it may cause
some weird issues running with an ESS that you can't connect
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19534
Do you mean we may first set `numRunningTasks` to 0 and then run into
`onTaskEnd` and have `numRunningTasks -= 1`? Could we simply check
`stageIdToSpeculativeTaskIndices`/`stageIdToTaskIndices
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19532
Please update the title to:
```
Modify the duration real-time calculation and update the API doc
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19476#discussion_r145013046
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -653,15 +663,34 @@ private[spark] class BlockManager(
require
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19476#discussion_r144859135
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -684,7 +713,7 @@ private[spark] class BlockManager
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19476#discussion_r144857068
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -653,15 +663,34 @@ private[spark] class BlockManager(
require
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19476#discussion_r144855916
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -653,15 +663,34 @@ private[spark] class BlockManager(
require
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19504
cc @liutang123 @HyukjinKwon @gatorsmile @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
GitHub user jiangxb1987 opened a pull request:
https://github.com/apache/spark/pull/19504
[SPARK-22233] [CORE] [FOLLOW-UP] Allow user to filter out empty split in
HadoopRDD
## What changes were proposed in this pull request?
Update the config `spark.files.ignoreEmptySplits
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19464#discussion_r144745063
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -270,6 +270,12 @@ package object config {
.longConf
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19464#discussion_r144745022
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -270,6 +270,12 @@ package object config {
.longConf
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/18784
@skonto @ArtRand @susanxhuynh Do we still want this?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/17422
@noodle-fb could you rebase this so we can review it? Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/17402
ping @jsoltren
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19475#discussion_r144293579
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ExpressionSet.scala
---
@@ -74,8 +81,24 @@ class ExpressionSet
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19448
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19448#discussion_r144289264
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetCommitterSuite.scala
---
@@ -0,0 +1,152
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19077#discussion_r144038007
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -116,9 +116,10 @@ private [sql] object
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19077#discussion_r144037194
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryBlock.java ---
@@ -48,6 +49,15 @@ public long size
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19077#discussion_r144037771
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeArrayWriter.java
---
@@ -57,7 +57,7 @@ public void
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19077#discussion_r144037069
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryBlock.java ---
@@ -48,6 +49,15 @@ public long size
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19456
Could you elaborate on the scenario that you should need to make these
settings configurable?
---
-
To unsubscribe, e-mail
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19464#discussion_r144030461
--- Diff: core/src/main/scala/org/apache/spark/rdd/HadoopRDD.scala ---
@@ -196,7 +196,10 @@ class HadoopRDD[K, V](
// add the credentials here
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19316#discussion_r144034339
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -388,7 +388,13 @@ private[spark] class MemoryStore
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19464#discussion_r144029852
--- Diff: docs/configuration.md ---
@@ -1211,6 +1211,14 @@ Apart from these, the following properties are also
available, and may be useful
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19464#discussion_r144031728
--- Diff: core/src/test/scala/org/apache/spark/FileSuite.scala ---
@@ -510,4 +510,16 @@ class FileSuite extends SparkFunSuite with
LocalSparkContext
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19464#discussion_r144030646
--- Diff: core/src/main/scala/org/apache/spark/rdd/HadoopRDD.scala ---
@@ -196,7 +196,10 @@ class HadoopRDD[K, V](
// add the credentials here
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19464#discussion_r144031167
--- Diff: core/src/test/scala/org/apache/spark/FileSuite.scala ---
@@ -510,4 +510,16 @@ class FileSuite extends SparkFunSuite with
LocalSparkContext
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19444#discussion_r143390226
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -405,6 +405,11 @@ object CatalogTypes
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19438
Maybe we can run some of the major test suites locally and update all the
results.
---
-
To unsubscribe, e-mail: reviews
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19444
cc @gatorsmile @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19444#discussion_r143168926
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -638,12 +638,14 @@ private[hive] class HiveClientImpl
GitHub user jiangxb1987 opened a pull request:
https://github.com/apache/spark/pull/19444
[SPARK-22214][SQL] Refactor the list hive partitions code
## What changes were proposed in this pull request?
In this PR we make a few changes to the list hive partitions code, to make
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19061#discussion_r143085886
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -203,6 +203,10 @@ package object config {
private[spark] val
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19406
This is actually a bugfix instead of improvement, I think we should follow
the approach that @srowen have suggested
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/17357
@ScrapCodes Could you rebase this with the latest master? Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/15219
@kiszk This PR has been stale for a long time, if we don't plan to continue
work on that in the near future, could you please temporally close this? We can
always reopen the PR when it's good
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/17436
Is this good to merge? @cloud-fan @kiszk
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/15666
Should we continue with this? @HyukjinKwon
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/18251
ping @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/18714
Do we still want this? @cloud-fan @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/18861
@maropu any update on this issue?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/18711
@10110346 Could you update the PR as @jerryshao suggested? Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/17357
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/17455
@okoethibm Have you got any time to rebase this PR to the latest master?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/16803
Should we close this PR since it goes staleï¼ @cloud-fan @jerryshao
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/16864
Should we close this PR since it goes stale? WDYT @WeichenXu123 ?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/18306
ping @zsxwing
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19413#discussion_r142418306
--- Diff: core/src/main/scala/org/apache/spark/rdd/HadoopRDD.scala ---
@@ -157,20 +157,23 @@ class HadoopRDD[K, V](
if (conf.isInstanceOf
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19405#discussion_r142310673
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveMetadataCacheSuite.scala
---
@@ -31,14 +31,22 @@ import
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19388#discussion_r142155120
--- Diff:
core/src/main/scala/org/apache/spark/internal/io/SparkHadoopWriter.scala ---
@@ -102,14 +102,14 @@ object SparkHadoopWriter extends Logging
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19388#discussion_r142163204
--- Diff:
core/src/test/scala/org/apache/spark/rdd/PairRDDFunctionsSuite.scala ---
@@ -864,6 +873,45 @@ class NewFakeFormatWithCallback() extends
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19388#discussion_r142154955
--- Diff:
core/src/main/scala/org/apache/spark/internal/io/SparkHadoopWriter.scala ---
@@ -60,17 +60,17 @@ object SparkHadoopWriter extends Logging
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19388#discussion_r142155725
--- Diff:
core/src/test/scala/org/apache/spark/rdd/PairRDDFunctionsSuite.scala ---
@@ -524,6 +525,14 @@ class PairRDDFunctionsSuite extends
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19369#discussion_r141653377
--- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala ---
@@ -67,7 +67,7 @@ private[spark] class DiskStore(
var threwException
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15769#discussion_r140930985
--- Diff:
core/src/main/scala/org/apache/spark/internal/io/SparkHadoopMapReduceWriter.scala
---
@@ -0,0 +1,249 @@
+/*
+ * Licensed
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19303
Personally I don't suggest we add extra logic to resolve a non-bug.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19317
cc @WeichenXu123 mind take a look?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19294
IMO it should be fine to not provide output directory if you are not using
absolute output paths, I also don't think we should always create absolute
output paths
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19277#discussion_r140059471
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala ---
@@ -351,14 +351,14 @@ private[spark] object
801 - 900 of 1796 matches
Mail list logo
