Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/12524
Also, the approach in this PR was discussed and rejected in #16620 (see
https://github.com/apache/spark/pull/16620#issuecomment-279125227 for a
description of why; the approach here will also
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/12524
I just closed the PR as a duplicate and agree with @markhamstra that this
duplicates #16620 (let's move discussion about whether this is a duplicate to
the JIRA so it's recorded
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16992
@erenavsarogullari there are currently a bunch of higher priority
outstanding scheduler PRs, so I'm guessing it will take a while for anyone to
get a chance to review this, just so you know
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16992
Jenkins this is ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/15604#discussion_r102829684
--- Diff: core/src/test/scala/org/apache/spark/scheduler/PoolSuite.scala ---
@@ -31,16 +31,17 @@ class PoolSuite extends SparkFunSuite
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/15604#discussion_r102831022
--- Diff: core/src/test/scala/org/apache/spark/scheduler/PoolSuite.scala ---
@@ -201,12 +202,96 @@ class PoolSuite extends SparkFunSuite
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/17018
Ignored the appveyor failure based on advice from @shivaram that this was
broken by the SQL folks (and it does seem clearly unrelated to this PR), and
merged this into master. Thanks
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16892#discussion_r102821513
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -2031,6 +2051,11 @@ class DAGSchedulerSuite extends
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16892#discussion_r102821009
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -1569,24 +1569,44 @@ class DAGSchedulerSuite extends
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16905
Jenkins this is OK to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user kayousterhout opened a pull request:
https://github.com/apache/spark/pull/17018
[SPARK-19684] [DOCS] Remove developer info from docs.
This commit moves developer-specific information from the release-
specific documentation in this repo to the developer tools page
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16905
Awesome thanks Shane!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16905
@shaneknapp is @markhamstra on the Jenkins whitelist? Wanted to double
check since his attempt to trigger the build above didn't work
---
If your project is set up for it, you can reply
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16905
@erenavsarogullari the reason this was happening on past PRs is that Imran
and I weren't on the Jenkins whitelist (which neither of us realized -- and has
since been fixed). I think Mark
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16905
Jenkins test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16620
Thanks all for the work on this! I've merged this into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16620
LGTM! Thanks for finding this subtle bug and all of the hard work to fix it
@jinxing64. I'll wait until tomorrow to merge this to give Mark and Imran a
chance for any last comments
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16620
LGTM pending one last comment improvement
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16892
Jenkins retest this please (filed
https://issues.apache.org/jira/browse/SPARK-19613 for the flaky test)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16620#discussion_r101392190
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -1181,15 +1181,34 @@ class DAGScheduler(
case
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16901
Jenkins this is OK to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16901
After looking at my other test cleanup PR I realized the "map stage
submission with executor failure late map task completions" test already tests
this functionality, only for
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16892
Ok I added back the other test but improved the commenting there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16620#discussion_r100922127
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -2161,6 +2161,58 @@ class DAGSchedulerSuite extends
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16620#discussion_r100922010
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -2161,6 +2161,58 @@ class DAGSchedulerSuite extends
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16620#discussion_r100921953
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -2161,6 +2161,58 @@ class DAGSchedulerSuite extends
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16620#discussion_r100922486
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -2161,6 +2161,58 @@ class DAGSchedulerSuite extends
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16620#discussion_r100921788
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -2161,6 +2161,58 @@ class DAGSchedulerSuite extends
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16620#discussion_r100921653
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -2161,6 +2161,58 @@ class DAGSchedulerSuite extends
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16620#discussion_r100922270
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -2161,6 +2161,58 @@ class DAGSchedulerSuite extends
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16620#discussion_r100922388
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -2161,6 +2161,58 @@ class DAGSchedulerSuite extends
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16901#discussion_r100885960
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -2161,6 +2161,48 @@ class DAGSchedulerSuite extends
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16901#discussion_r100885083
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -2161,6 +2161,48 @@ class DAGSchedulerSuite extends
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16901#discussion_r100886335
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -2161,6 +2161,48 @@ class DAGSchedulerSuite extends
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16901#discussion_r100886876
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -2161,6 +2161,48 @@ class DAGSchedulerSuite extends
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16901#discussion_r100886451
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -2161,6 +2161,48 @@ class DAGSchedulerSuite extends
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16902
Thanks for fixing this @lw-lin!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16892
Jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16620
Also, if you implement the new change I proposed, I think it's relatively
straightforward to write a new test in DAGSchedulerSuite for the new behavior
(which will be pretty similar
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16892
cc @mateiz, whose test I deleted / rolled into the existing one
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16876
Thanks all for the review; merged this into master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16876
@jinxing64 I wrote a long comment on your other PR to attempt to explain
(my current understanding of) these issues!
---
If your project is set up for it, you can reply to this email
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16620
tl;dr I donât think Markâs change is quite correct, which is why the
tests were failing. Instead, I think we need to replace the failedEpoch
if/else statement and the pendingPartitions
GitHub user kayousterhout opened a pull request:
https://github.com/apache/spark/pull/16892
[SPARK-19560] Improve DAGScheduler tests.
This commit improves the tests that check the case when a
ShuffleMapTask completes successfully on an executor that has
failed. This commit
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16889
FYI the test that failed here seems to be flaky and probably not related to
this PR: https://issues.apache.org/jira/browse/SPARK-19559
---
If your project is set up for it, you can reply
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16686
I recently have noticed a few flaky test failures of
KafkaSourceSuite.subscribing topic by pattern with topic deletions (e.g.,
https://amplab.cs.berkeley.edu/jenkins/job
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16813
I merged this into master -- thanks for your work on this
@erenavsarogullari, and for adding Imran and I to the Jenkins admin group
@shaneknapp!
---
If your project is set up for it, you
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16620
I spent a long time looking at this and I think @markhamsta's solution is
the way to go, and that we should update the tests to address the failures (I
think the two tests that fail
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16876#discussion_r100472977
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -1038,9 +1038,8 @@ class DAGScheduler
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16813
Thanks Shane!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16813
Jenkins, this is ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16813
Ok I asked Shane about this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16813
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16831
I merged this but just realized the current JIRA number is wrong. I won't
do a revert / recommit because this is such a small PR, but in the future, each
PR should have its own JIRA (so
GitHub user kayousterhout opened a pull request:
https://github.com/apache/spark/pull/16877
[WIP] [SPARK-19538] Explicitly tell the DAGScheduler when a TaskSet is
complete
This is not intended to be merged! (see note at bottom) Posting to
facilitate discussion around #16620
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16876
Thanks for the quick look @markhamstra !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user kayousterhout opened a pull request:
https://github.com/apache/spark/pull/16876
[SPARK-19537] Move pendingPartitions to ShuffleMapStage.
The pendingPartitions instance variable should be moved to ShuffleMapStage,
because it is only used by ShuffleMapStages
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16813
Jenkins test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16813
Jenkins, this is OK to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16813#discussion_r100420228
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SchedulableBuilder.scala ---
@@ -83,15 +83,19 @@ private[spark] class FairSchedulableBuilder
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16639#discussion_r100413021
--- Diff: core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala
---
@@ -133,6 +123,153 @@ class ExecutorSuite extends SparkFunSuite
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16639#discussion_r100409667
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -340,6 +342,14 @@ private[spark] class Executor
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16639#discussion_r100409974
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -405,6 +415,13 @@ private[spark] class Executor
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16639#discussion_r100413764
--- Diff: core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala
---
@@ -133,6 +123,153 @@ class ExecutorSuite extends SparkFunSuite
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16639#discussion_r100413614
--- Diff: core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala
---
@@ -133,6 +123,153 @@ class ExecutorSuite extends SparkFunSuite
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16639#discussion_r100414154
--- Diff: core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala
---
@@ -133,6 +123,153 @@ class ExecutorSuite extends SparkFunSuite
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16639#discussion_r100413863
--- Diff: core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala
---
@@ -133,6 +123,153 @@ class ExecutorSuite extends SparkFunSuite
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16639#discussion_r100412522
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -405,6 +415,13 @@ private[spark] class Executor
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16639
Ok I'm convinced re: not walking up the cause tree. I didn't think about
that finally case. I'll do another review now.
Re: larger integration test, I didn't have a particular thing
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16855#discussion_r100405998
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala ---
@@ -664,6 +665,55 @@ class TaskSetManagerSuite extends
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16813#discussion_r100405459
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SchedulableBuilder.scala ---
@@ -69,19 +70,31 @@ private[spark] class FairSchedulableBuilder
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/15604
Ok thanks for the update!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/15604
Ok thanks for the update!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16813#discussion_r100193866
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SchedulableBuilder.scala ---
@@ -69,19 +70,31 @@ private[spark] class FairSchedulableBuilder
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16813#discussion_r100194712
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SchedulableBuilder.scala ---
@@ -140,14 +157,15 @@ private[spark] class
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16813#discussion_r100194109
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SchedulableBuilder.scala ---
@@ -69,19 +70,31 @@ private[spark] class FairSchedulableBuilder
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16855#discussion_r100187460
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala ---
@@ -664,6 +665,55 @@ class TaskSetManagerSuite extends
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16855#discussion_r100190769
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala ---
@@ -664,6 +665,55 @@ class TaskSetManagerSuite extends
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16855#discussion_r100188875
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala ---
@@ -664,6 +665,55 @@ class TaskSetManagerSuite extends
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16855#discussion_r100186410
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -874,7 +874,8 @@ private[spark] class TaskSetManager
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16855#discussion_r100189090
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala ---
@@ -664,6 +665,55 @@ class TaskSetManagerSuite extends
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16855#discussion_r100187114
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -874,7 +874,8 @@ private[spark] class TaskSetManager
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16855#discussion_r100190631
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala ---
@@ -664,6 +665,55 @@ class TaskSetManagerSuite extends
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16855#discussion_r100189015
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala ---
@@ -664,6 +665,55 @@ class TaskSetManagerSuite extends
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16855
Can you make the PR and JIRA description something more specific? Maybe
"[SPARK-13931] Stage can hang if an executor fails while speculated tasks are
running"
---
If your project
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16855
Jenkins, this is OK to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16620
After thinking about this for a few more minutes, I'm going to retract my
earlier statement about preferring my approach to yours. I think we can file a
JIRA for the bigger problem
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16620
BTW Mark one slightly different version of your suggestion I'd considered
is:
(1) move stage.pendingPartitions -= task.partitionId so that it's
duplicated in each of the two case
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16813#discussion_r99962965
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SchedulableBuilder.scala ---
@@ -69,60 +72,81 @@ private[spark] class FairSchedulableBuilder
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16620
@markhamstra I prefer that approach to the approach in the existing PR, but
I still have some hesitation about that because of the inconsistencies between
the TaskSetManager (which still
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16813#discussion_r99945422
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SchedulableBuilder.scala ---
@@ -69,60 +72,81 @@ private[spark] class FairSchedulableBuilder
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16813#discussion_r99943253
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SchedulableBuilder.scala ---
@@ -69,60 +72,81 @@ private[spark] class FairSchedulableBuilder
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16813#discussion_r99943518
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SchedulableBuilder.scala ---
@@ -69,60 +72,81 @@ private[spark] class FairSchedulableBuilder
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16813#discussion_r99942555
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SchedulableBuilder.scala ---
@@ -69,60 +72,81 @@ private[spark] class FairSchedulableBuilder
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16813#discussion_r99944578
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SchedulableBuilder.scala ---
@@ -140,14 +164,15 @@ private[spark] class
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16813#discussion_r99944612
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SchedulableBuilder.scala ---
@@ -166,11 +191,12 @@ private[spark] class
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16813#discussion_r99944122
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SchedulableBuilder.scala ---
@@ -69,60 +72,81 @@ private[spark] class FairSchedulableBuilder
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16813#discussion_r99940562
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SchedulableBuilder.scala ---
@@ -69,60 +72,81 @@ private[spark] class FairSchedulableBuilder
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16639#discussion_r99935445
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -405,6 +415,13 @@ private[spark] class Executor
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16639#discussion_r99935656
--- Diff: core/src/main/scala/org/apache/spark/scheduler/Task.scala ---
@@ -137,6 +132,8 @@ private[spark] abstract class Task[T
201 - 300 of 1796 matches
Mail list logo
