[GitHub] spark pull request: [SPARK-9882][Core] Priority-based scheduling f...

2015-08-28 Thread thegiive
Github user thegiive commented on the pull request: https://github.com/apache/spark/pull/8129#issuecomment-135786660 hi @JoshRosen , @andrewor14 , @srowen Viirya and I are in the same team. Currently Spark standalone has only one FIFO scheduler outside the application and

[GitHub] spark pull request: [SPARK-9637][Core] Add interface for implement...

2015-08-05 Thread thegiive
Github user thegiive commented on the pull request: https://github.com/apache/spark/pull/7958#issuecomment-128226959 Hi @CodingCat : Thanks for commenting. Viirya and I are in the same team. We know currently Spark standalone has only one FIFO scheduler outside the application and

[GitHub] spark pull request: [SPARK-8656][WebUI] Fix the webUI and JSON API...

2015-07-03 Thread thegiive
Github user thegiive commented on the pull request: https://github.com/apache/spark/pull/7038#issuecomment-118449368 HI @andrewor14 The test is passed. If there is any problem, please let me know. Thanks --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-8656][WebUI] Fix the webUI and JSON API...

2015-07-03 Thread thegiive
Github user thegiive commented on a diff in the pull request: https://github.com/apache/spark/pull/7038#discussion_r33881472 --- Diff: core/src/main/scala/org/apache/spark/deploy/JsonProtocol.scala --- @@ -76,12 +76,13 @@ private[deploy] object JsonProtocol

[GitHub] spark pull request: [SPARK-8656][WebUI] Fix the webUI and JSON API...

2015-07-03 Thread thegiive
Github user thegiive commented on a diff in the pull request: https://github.com/apache/spark/pull/7038#discussion_r33881442 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/WorkerInfo.scala --- @@ -107,4 +107,6 @@ private[spark] class WorkerInfo( def setState

[GitHub] spark pull request: [SPARK-8656][WebUI] Fix the webUI and JSON API...

2015-07-03 Thread thegiive
Github user thegiive commented on a diff in the pull request: https://github.com/apache/spark/pull/7038#discussion_r33881396 --- Diff: core/src/main/scala/org/apache/spark/deploy/JsonProtocol.scala --- @@ -76,12 +76,13 @@ private[deploy] object JsonProtocol

[GitHub] spark pull request: [SPARK-8656][WebUI] Fix the webUI and JSON API...

2015-07-03 Thread thegiive
Github user thegiive commented on a diff in the pull request: https://github.com/apache/spark/pull/7038#discussion_r33881284 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/WorkerInfo.scala --- @@ -107,4 +107,6 @@ private[spark] class WorkerInfo( def setState

[GitHub] spark pull request: [SPARK-8656][WebUI] Fix the webUI and JSON API...

2015-07-03 Thread thegiive
Github user thegiive commented on a diff in the pull request: https://github.com/apache/spark/pull/7038#discussion_r33881264 --- Diff: core/src/main/scala/org/apache/spark/deploy/JsonProtocol.scala --- @@ -76,12 +76,13 @@ private[deploy] object JsonProtocol

[GitHub] spark pull request: [SPARK-8656][WebUI] Fix the webUI and JSON API...

2015-07-02 Thread thegiive
Github user thegiive commented on the pull request: https://github.com/apache/spark/pull/7038#issuecomment-118214522 Hi all reviewer I modified the code base on the comment. Can you check if it is ok ? --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-8690][SQL] Add a setting to disable Spa...

2015-07-02 Thread thegiive
Github user thegiive commented on the pull request: https://github.com/apache/spark/pull/7070#issuecomment-118172236 Thanks you. @liancheng --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8690][SQL] Add a setting to disable Spa...

2015-07-01 Thread thegiive
Github user thegiive commented on the pull request: https://github.com/apache/spark/pull/7070#issuecomment-117893056 HI @liancheng , thanks for the suggestion. I think your comment is really good and I have modified it already. Please help to check if there is anything else

[GitHub] spark pull request: [SPARK-8690][SQL] Add a setting to disable Spa...

2015-07-01 Thread thegiive
Github user thegiive commented on the pull request: https://github.com/apache/spark/pull/7070#issuecomment-117645649 Hi @liancheng , Can you help to check if it is what you suggest ? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-8690][SQL] Add a setting to disable Spa...

2015-06-30 Thread thegiive
Github user thegiive commented on the pull request: https://github.com/apache/spark/pull/7070#issuecomment-117364855 Sure. I have already finish the coding. But I need some more time to write the test case --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-8611] [WebUI] Fix wrong REST UI Protoco...

2015-06-30 Thread thegiive
Github user thegiive commented on the pull request: https://github.com/apache/spark/pull/7006#issuecomment-117363716 OK. It looks wired in first. But your comment looks reasonable. BTW, I found this PR is close already. --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-8611] [WebUI] Fix wrong REST UI Protoco...

2015-06-29 Thread thegiive
Github user thegiive commented on the pull request: https://github.com/apache/spark/pull/7006#issuecomment-116732542 Hi, is there anyone who can confirm this patch? @andrewor14 or someone else --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [Spark-8690][SQL] Add a setting to disable Spa...

2015-06-28 Thread thegiive
GitHub user thegiive opened a pull request: https://github.com/apache/spark/pull/7070 [Spark-8690][SQL] Add a setting to disable SparkSQL parquet schema merge by using datasource API The detail problem story is in https://issues.apache.org/jira/browse/SPARK-8690 General

[GitHub] spark pull request: [SPARK-8656][WebUI] Fix the webUI and JSON API...

2015-06-26 Thread thegiive
Github user thegiive commented on the pull request: https://github.com/apache/spark/pull/7038#issuecomment-115898969 Base on git blame, I think the JSON API creator is @rxin ( 9db1e503 ) Hi Reynold #6317 has already change some master UI's data's definit

[GitHub] spark pull request: [SPARK-8656][WebUI] Fix the webUI and JSON API...

2015-06-26 Thread thegiive
Github user thegiive commented on the pull request: https://github.com/apache/spark/pull/7038#issuecomment-115725659 HI Sean, thanks for your opinion. My feeling is that WebUI and API is just different presentation format. But the content should be the same. Different

[GitHub] spark pull request: [SPARK-8656][WebUI] Fix the webUI and JSON API...

2015-06-26 Thread thegiive
Github user thegiive commented on a diff in the pull request: https://github.com/apache/spark/pull/7038#discussion_r33364777 --- Diff: core/src/main/scala/org/apache/spark/deploy/JsonProtocol.scala --- @@ -77,11 +77,11 @@ private[deploy] object JsonProtocol { def

[GitHub] spark pull request: [SPARK-8656][WebUI] Fix the webUI and JSON API...

2015-06-26 Thread thegiive
Github user thegiive commented on a diff in the pull request: https://github.com/apache/spark/pull/7038#discussion_r33364667 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/WorkerInfo.scala --- @@ -107,4 +107,8 @@ private[spark] class WorkerInfo( def setState

[GitHub] spark pull request: [SPARK-8656][WebUI] Fix the webUI and JSON API...

2015-06-26 Thread thegiive
GitHub user thegiive opened a pull request: https://github.com/apache/spark/pull/7038 [SPARK-8656][WebUI] Fix the webUI and JSON API number is not synced Spark standalone master web UI show "Alive workers" worker number, "Alive Workers" total core, total u

[GitHub] spark pull request: [SPARK-8611] [WebUI] Fix wrong REST UI Protoco...

2015-06-25 Thread thegiive
Github user thegiive commented on the pull request: https://github.com/apache/spark/pull/7006#issuecomment-115262668 Hi Sean What is the proper way to confirm with @andrewor14 ? By email? --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-8611] [WebUI] Fix wrong REST UI Protoco...

2015-06-24 Thread thegiive
GitHub user thegiive opened a pull request: https://github.com/apache/spark/pull/7006 [SPARK-8611] [WebUI] Fix wrong REST UI Protocol on standalone cluster Web UI Page Just easily change the "spark://" to "http://"; You can merge this pull request into

[GitHub] spark pull request: Refactor the JAVA example to Java 8 lambda ver...

2014-05-15 Thread thegiive
GitHub user thegiive opened a pull request: https://github.com/apache/spark/pull/777 Refactor the JAVA example to Java 8 lambda version Spark 1.0 has a great feature supporting the Java 8 lambda version but I barely find any Java 8 example for Spark 1.0. I refactor the

[GitHub] spark pull request: Refactor the JAVA example to Java 8 lambda ver...

2014-05-15 Thread thegiive
Github user thegiive commented on the pull request: https://github.com/apache/spark/pull/777#issuecomment-43162048 Hi Reynold I think your thought is right. I will keep these code on my own git repos :) --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: Refactor the JAVA example to Java 8 lambda ver...

2014-05-15 Thread thegiive
Github user thegiive closed the pull request at: https://github.com/apache/spark/pull/777 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is