[GitHub] [spark] EnricoMi commented on a diff in pull request #35965: [SPARK-38647][SQL] Add SupportsReportOrdering mix in interface for Scan (DataSourceV2)

2022-06-18 Thread GitBox
EnricoMi commented on code in PR #35965: URL: https://github.com/apache/spark/pull/35965#discussion_r900735519 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2ScanPartitioningAndOrdering.scala: ## @@ -21,18 +21,28 @@ import

[GitHub] [spark] EnricoMi commented on a diff in pull request #35965: [SPARK-38647][SQL] Add SupportsReportOrdering mix in interface for Scan (DataSourceV2)

2022-06-08 Thread GitBox
EnricoMi commented on code in PR #35965: URL: https://github.com/apache/spark/pull/35965#discussion_r892865243 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2ScanExecBase.scala: ## @@ -138,6 +138,15 @@ trait DataSourceV2ScanExecBase extends

[GitHub] [spark] EnricoMi commented on a diff in pull request #35965: [SPARK-38647][SQL] Add SupportsReportOrdering mix in interface for Scan (DataSourceV2)

2022-05-04 Thread GitBox
EnricoMi commented on code in PR #35965: URL: https://github.com/apache/spark/pull/35965#discussion_r864668175 ## sql/core/src/test/java/test/org/apache/spark/sql/connector/JavaOrderAndPartitionAwareDataSource.java: ## @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] EnricoMi commented on a diff in pull request #35965: [SPARK-38647][SQL] Add SupportsReportOrdering mix in interface for Scan (DataSourceV2)

2022-05-04 Thread GitBox
EnricoMi commented on code in PR #35965: URL: https://github.com/apache/spark/pull/35965#discussion_r864666010 ## sql/core/src/test/java/test/org/apache/spark/sql/connector/JavaOrderAndPartitionAwareDataSource.java: ## @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] EnricoMi commented on a diff in pull request #35965: [SPARK-38647][SQL] Add SupportsReportOrdering mix in interface for Scan (DataSourceV2)

2022-05-04 Thread GitBox
EnricoMi commented on code in PR #35965: URL: https://github.com/apache/spark/pull/35965#discussion_r864664046 ## sql/core/src/test/java/test/org/apache/spark/sql/connector/JavaOrderAndPartitionAwareDataSource.java: ## @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] EnricoMi commented on a diff in pull request #35965: [SPARK-38647][SQL] Add SupportsReportOrdering mix in interface for Scan (DataSourceV2)

2022-05-04 Thread GitBox
EnricoMi commented on code in PR #35965: URL: https://github.com/apache/spark/pull/35965#discussion_r864662649 ## sql/core/src/test/java/test/org/apache/spark/sql/connector/JavaOrderAndPartitionAwareDataSource.java: ## @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] EnricoMi commented on a diff in pull request #35965: [SPARK-38647][SQL] Add SupportsReportOrdering mix in interface for Scan (DataSourceV2)

2022-05-04 Thread GitBox
EnricoMi commented on code in PR #35965: URL: https://github.com/apache/spark/pull/35965#discussion_r864659237 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2ScanExecBase.scala: ## @@ -138,6 +138,15 @@ trait DataSourceV2ScanExecBase extends

[GitHub] [spark] EnricoMi commented on a diff in pull request #35965: [SPARK-38647][SQL] Add SupportsReportOrdering mix in interface for Scan (DataSourceV2)

2022-05-02 Thread GitBox
EnricoMi commented on code in PR #35965: URL: https://github.com/apache/spark/pull/35965#discussion_r863144390 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2ScanExecBase.scala: ## @@ -138,6 +138,12 @@ trait DataSourceV2ScanExecBase extends

[GitHub] [spark] EnricoMi commented on a diff in pull request #35965: [SPARK-38647][SQL] Add SupportsReportOrdering mix in interface for Scan (DataSourceV2)

2022-05-02 Thread GitBox
EnricoMi commented on code in PR #35965: URL: https://github.com/apache/spark/pull/35965#discussion_r862688879 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2ScanExecBase.scala: ## @@ -138,6 +138,12 @@ trait DataSourceV2ScanExecBase extends

[GitHub] [spark] EnricoMi commented on a diff in pull request #35965: [SPARK-38647][SQL] Add SupportsReportOrdering mix in interface for Scan (DataSourceV2)

2022-05-02 Thread GitBox
EnricoMi commented on code in PR #35965: URL: https://github.com/apache/spark/pull/35965#discussion_r862668354 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/read/SupportsReportOrdering.java: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation