[GitHub] [spark] Fokko commented on a change in pull request #29122: [SPARK-32320][PYSPARK] Remove mutable default arguments

Fokko commented on a change in pull request #29122: URL: https://github.com/apache/spark/pull/29122#discussion_r529496929 ## File path: python/pyspark/sql/functions.py ## @@ -3471,7 +3473,7 @@ def from_json(col, schema, options={}): return Column(jc) -def to_json(col,

[GitHub] [spark] Fokko commented on a change in pull request #29122: [SPARK-32320][PYSPARK] Remove mutable default arguments

Fokko commented on a change in pull request #29122: URL: https://github.com/apache/spark/pull/29122#discussion_r529496774 ## File path: python/pyspark/sql/functions.py ## @@ -3471,7 +3473,7 @@ def from_json(col, schema, options={}): return Column(jc) -def to_json(col,

[GitHub] [spark] Fokko commented on a change in pull request #29122: [SPARK-32320][PYSPARK] Remove mutable default arguments

Fokko commented on a change in pull request #29122: URL: https://github.com/apache/spark/pull/29122#discussion_r509536477 ## File path: python/pyspark/ml/regression.py ## @@ -1654,7 +1656,7 @@ class _AFTSurvivalRegressionParams(_PredictorParams, HasMaxIter, HasTol, HasFitI

[GitHub] [spark] Fokko commented on a change in pull request #29122: [SPARK-32320][PYSPARK] Remove mutable default arguments

Fokko commented on a change in pull request #29122: URL: https://github.com/apache/spark/pull/29122#discussion_r508872469 ## File path: python/pyspark/sql/avro/functions.py ## @@ -26,7 +26,7 @@ @since(3.0) -def from_avro(data, jsonFormatSchema, options={}): +def

[GitHub] [spark] Fokko commented on a change in pull request #29122: [SPARK-32320][PYSPARK] Remove mutable default arguments

Fokko commented on a change in pull request #29122: URL: https://github.com/apache/spark/pull/29122#discussion_r508871957 ## File path: python/pyspark/ml/regression.py ## @@ -1654,7 +1656,7 @@ class _AFTSurvivalRegressionParams(_PredictorParams, HasMaxIter, HasTol, HasFitI

[GitHub] [spark] Fokko commented on a change in pull request #29122: [SPARK-32320][PYSPARK] Remove mutable default arguments

Fokko commented on a change in pull request #29122: URL: https://github.com/apache/spark/pull/29122#discussion_r508858955 ## File path: python/pyspark/ml/regression.py ## @@ -1654,7 +1656,7 @@ class _AFTSurvivalRegressionParams(_PredictorParams, HasMaxIter, HasTol, HasFitI

[GitHub] [spark] Fokko commented on a change in pull request #29122: [SPARK-32320][PYSPARK] Remove mutable default arguments

Fokko commented on a change in pull request #29122: URL: https://github.com/apache/spark/pull/29122#discussion_r508857704 ## File path: python/pyspark/ml/regression.py ## @@ -1740,7 +1742,7 @@ class AFTSurvivalRegression(_JavaRegressor, _AFTSurvivalRegressionParams,

[GitHub] [spark] Fokko commented on a change in pull request #29122: [SPARK-32320][PYSPARK] Remove mutable default arguments

Fokko commented on a change in pull request #29122: URL: https://github.com/apache/spark/pull/29122#discussion_r508856371 ## File path: python/pyspark/sql/avro/functions.py ## @@ -26,7 +26,7 @@ @since(3.0) -def from_avro(data, jsonFormatSchema, options={}): +def

[GitHub] [spark] Fokko commented on a change in pull request #29122: [SPARK-32320][PYSPARK] Remove mutable default arguments

Fokko commented on a change in pull request #29122: URL: https://github.com/apache/spark/pull/29122#discussion_r508385826 ## File path: python/pyspark/sql/functions.py ## @@ -2392,7 +2393,7 @@ def json_tuple(col, *fields): @since(2.1) -def from_json(col, schema,

[GitHub] [spark] Fokko commented on a change in pull request #29122: [SPARK-32320][PYSPARK] Remove mutable default arguments

Fokko commented on a change in pull request #29122: URL: https://github.com/apache/spark/pull/29122#discussion_r458327734 ## File path: python/pyspark/sql/functions.py ## @@ -2392,7 +2393,7 @@ def json_tuple(col, *fields): @since(2.1) -def from_json(col, schema,

[GitHub] [spark] Fokko commented on a change in pull request #29122: [SPARK-32320][PYSPARK] Remove mutable default arguments

Fokko commented on a change in pull request #29122: URL: https://github.com/apache/spark/pull/29122#discussion_r458010885 ## File path: python/pyspark/sql/functions.py ## @@ -2392,7 +2393,7 @@ def json_tuple(col, *fields): @since(2.1) -def from_json(col, schema,

[GitHub] [spark] Fokko commented on a change in pull request #29122: [SPARK-32320][PYSPARK] Remove mutable default arguments

Fokko commented on a change in pull request #29122: URL: https://github.com/apache/spark/pull/29122#discussion_r456896310 ## File path: python/pyspark/ml/tuning.py ## @@ -500,13 +501,13 @@ class CrossValidatorModel(Model, _CrossValidatorParams, MLReadable, MLWritable):

[GitHub] [spark] Fokko commented on a change in pull request #29122: [SPARK-32320][PYSPARK] Remove mutable default arguments

Fokko commented on a change in pull request #29122: URL: https://github.com/apache/spark/pull/29122#discussion_r456688795 ## File path: python/pyspark/sql/functions.py ## @@ -2440,7 +2442,7 @@ def from_json(col, schema, options={}): @since(2.1) -def to_json(col,

[GitHub] [spark] Fokko commented on a change in pull request #29122: [SPARK-32320][PYSPARK] Remove mutable default arguments

Fokko commented on a change in pull request #29122: URL: https://github.com/apache/spark/pull/29122#discussion_r454886119 ## File path: python/pyspark/sql/functions.py ## @@ -2392,7 +2393,7 @@ def json_tuple(col, *fields): @since(2.1) -def from_json(col, schema,

[GitHub] [spark] Fokko commented on a change in pull request #29122: [SPARK-32320][PYSPARK] Remove mutable default arguments

Fokko commented on a change in pull request #29122: URL: https://github.com/apache/spark/pull/29122#discussion_r454886119 ## File path: python/pyspark/sql/functions.py ## @@ -2392,7 +2393,7 @@ def json_tuple(col, *fields): @since(2.1) -def from_json(col, schema,