[GitHub] [spark] Hisoka-X commented on a diff in pull request #41496: [SPARK-42750][SQL][FOLLOWUP] Add INSERT OVERWRITE BY NAME statement

2023-06-13 Thread via GitHub
Hisoka-X commented on code in PR #41496: URL: https://github.com/apache/spark/pull/41496#discussion_r1229021708 ## sql/core/src/test/scala/org/apache/spark/sql/SQLInsertTestSuite.scala: ## @@ -440,14 +476,49 @@ trait SQLInsertTestSuite extends QueryTest with SQLTestUtils { }

[GitHub] [spark] Hisoka-X commented on a diff in pull request #41496: [SPARK-42750][SQL][FOLLOWUP] Add INSERT OVERWRITE BY NAME statement

2023-06-08 Thread via GitHub
Hisoka-X commented on code in PR #41496: URL: https://github.com/apache/spark/pull/41496#discussion_r1222908269 ## sql/core/src/test/scala/org/apache/spark/sql/SQLInsertTestSuite.scala: ## @@ -440,14 +476,49 @@ trait SQLInsertTestSuite extends QueryTest with SQLTestUtils { }

[GitHub] [spark] Hisoka-X commented on a diff in pull request #41496: [SPARK-42750][SQL][FOLLOWUP] Add INSERT OVERWRITE BY NAME statement

2023-06-08 Thread via GitHub
Hisoka-X commented on code in PR #41496: URL: https://github.com/apache/spark/pull/41496#discussion_r1222908269 ## sql/core/src/test/scala/org/apache/spark/sql/SQLInsertTestSuite.scala: ## @@ -440,14 +476,49 @@ trait SQLInsertTestSuite extends QueryTest with SQLTestUtils { }

[GitHub] [spark] Hisoka-X commented on a diff in pull request #41496: [SPARK-42750][SQL][FOLLOWUP] Add INSERT OVERWRITE BY NAME statement

2023-06-08 Thread via GitHub
Hisoka-X commented on code in PR #41496: URL: https://github.com/apache/spark/pull/41496#discussion_r1222901581 ## sql/core/src/test/scala/org/apache/spark/sql/SQLInsertTestSuite.scala: ## @@ -440,14 +476,49 @@ trait SQLInsertTestSuite extends QueryTest with SQLTestUtils { }

[GitHub] [spark] Hisoka-X commented on a diff in pull request #41496: [SPARK-42750][SQL][FOLLOWUP] Add INSERT OVERWRITE BY NAME statement

2023-06-08 Thread via GitHub
Hisoka-X commented on code in PR #41496: URL: https://github.com/apache/spark/pull/41496#discussion_r1222832772 ## sql/core/src/test/scala/org/apache/spark/sql/SQLInsertTestSuite.scala: ## @@ -160,6 +160,42 @@ trait SQLInsertTestSuite extends QueryTest with SQLTestUtils {