[GitHub] [spark] HyukjinKwon commented on a change in pull request #28365: [SPARK-31571][R] overhaul stop/message/warning calls to be more translation-friendly/canonical

HyukjinKwon commented on a change in pull request #28365: URL: https://github.com/apache/spark/pull/28365#discussion_r415660015 ## File path: R/pkg/R/DataFrame.R ## @@ -2587,18 +2589,18 @@ setMethod("join", if (is.null(joinType)) { sdf <- callJMe

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28365: [SPARK-31571][R] overhaul stop/message/warning calls to be more translation-friendly/canonical

HyukjinKwon commented on a change in pull request #28365: URL: https://github.com/apache/spark/pull/28365#discussion_r415660279 ## File path: R/pkg/R/DataFrame.R ## @@ -829,8 +829,11 @@ setMethod("repartitionByRange", jcol <- lapply(cols, function(c) { c@jc })

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28365: [SPARK-31571][R] overhaul stop/message/warning calls to be more translation-friendly/canonical

HyukjinKwon commented on a change in pull request #28365: URL: https://github.com/apache/spark/pull/28365#discussion_r415659247 ## File path: R/pkg/R/SQLContext.R ## @@ -207,7 +209,8 @@ getSchema <- function(schema, firstRow = NULL, rdd = NULL) { names <- lapply(names, fun

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28365: [SPARK-31571][R] overhaul stop/message/warning calls to be more translation-friendly/canonical

HyukjinKwon commented on a change in pull request #28365: URL: https://github.com/apache/spark/pull/28365#discussion_r415659034 ## File path: R/pkg/R/client.R ## @@ -102,10 +102,17 @@ checkJavaVersion <- function() { javaVersionNum <- as.integer(versions[1]) } if (ja

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28365: [SPARK-31571][R] overhaul stop/message/warning calls to be more translation-friendly/canonical

HyukjinKwon commented on a change in pull request #28365: URL: https://github.com/apache/spark/pull/28365#discussion_r415658286 ## File path: R/pkg/R/install.R ## @@ -103,12 +103,14 @@ install.spark <- function(hadoopVersion = "2.7", mirrorUrl = NULL, # can use dir.exists(p

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28365: [SPARK-31571][R] overhaul stop/message/warning calls to be more translation-friendly/canonical

HyukjinKwon commented on a change in pull request #28365: URL: https://github.com/apache/spark/pull/28365#discussion_r415657976 ## File path: R/pkg/R/install.R ## @@ -201,11 +200,11 @@ robustDownloadTar <- function(mirrorUrl, version, hadoopVersion, packageName, pa # remo

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28365: [SPARK-31571][R] overhaul stop/message/warning calls to be more translation-friendly/canonical

HyukjinKwon commented on a change in pull request #28365: URL: https://github.com/apache/spark/pull/28365#discussion_r415657792 ## File path: R/pkg/R/install.R ## @@ -231,24 +230,21 @@ getPreferredMirror <- function(version, packageName) { directDownloadTar <- function(mirro

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28365: [SPARK-31571][R] overhaul stop/message/warning calls to be more translation-friendly/canonical

HyukjinKwon commented on a change in pull request #28365: URL: https://github.com/apache/spark/pull/28365#discussion_r415656778 ## File path: R/pkg/R/install.R ## @@ -293,7 +289,7 @@ sparkCachePath <- function() { Sys.getenv("XDG_CACHE_HOME", file.path(Sys.getenv("HOME

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28365: [SPARK-31571][R] overhaul stop/message/warning calls to be more translation-friendly/canonical

HyukjinKwon commented on a change in pull request #28365: URL: https://github.com/apache/spark/pull/28365#discussion_r415655632 ## File path: R/pkg/R/sparkR.R ## @@ -439,8 +439,11 @@ sparkR.session <- function( rPackageVersion <- paste0(packageVersion("SparkR")) if (jvm

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28365: [SPARK-31571][R] overhaul stop/message/warning calls to be more translation-friendly/canonical

HyukjinKwon commented on a change in pull request #28365: URL: https://github.com/apache/spark/pull/28365#discussion_r415655342 ## File path: R/pkg/R/utils.R ## @@ -354,8 +354,10 @@ varargsToStrEnv <- function(...) { } else { value <- pairs[[name]] if (

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28365: [SPARK-31571][R] overhaul stop/message/warning calls to be more translation-friendly/canonical

HyukjinKwon commented on a change in pull request #28365: URL: https://github.com/apache/spark/pull/28365#discussion_r415655186 ## File path: R/pkg/R/utils.R ## @@ -369,8 +371,9 @@ varargsToStrEnv <- function(...) { } if (length(ignoredNames) != 0) { -warning(paste0