[GitHub] [spark] HyukjinKwon commented on a change in pull request #31148: [SPARK-33867][SQL] Instant and LocalDate values aren't handled when generating SQL queries

2021-01-27 Thread GitBox
HyukjinKwon commented on a change in pull request #31148: URL: https://github.com/apache/spark/pull/31148#discussion_r565239091 ## File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ## @@ -175,7 +179,14 @@ abstract class JdbcDialect extends Serializ

[GitHub] [spark] HyukjinKwon commented on a change in pull request #31148: [SPARK-33867][SQL] Instant and LocalDate values aren't handled when generating SQL queries

2021-01-27 Thread GitBox
HyukjinKwon commented on a change in pull request #31148: URL: https://github.com/apache/spark/pull/31148#discussion_r565239091 ## File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ## @@ -175,7 +179,14 @@ abstract class JdbcDialect extends Serializ

[GitHub] [spark] HyukjinKwon commented on a change in pull request #31148: [SPARK-33867][SQL] Instant and LocalDate values aren't handled when generating SQL queries

2021-01-27 Thread GitBox
HyukjinKwon commented on a change in pull request #31148: URL: https://github.com/apache/spark/pull/31148#discussion_r565238860 ## File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ## @@ -63,6 +66,7 @@ case class JdbcType(databaseTypeDefinition : S

[GitHub] [spark] HyukjinKwon commented on a change in pull request #31148: [SPARK-33867][SQL] Instant and LocalDate values aren't handled when generating SQL queries

2021-01-26 Thread GitBox
HyukjinKwon commented on a change in pull request #31148: URL: https://github.com/apache/spark/pull/31148#discussion_r564542156 ## File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ## @@ -175,7 +179,12 @@ abstract class JdbcDialect extends Serializ