[GitHub] [spark] HyukjinKwon commented on pull request #30413: [SPARK-33252][PYTHON][DOCS] Migration to NumPy documentation style in MLlib (pyspark.mllib.*)

2020-11-24 Thread GitBox
HyukjinKwon commented on pull request #30413: URL: https://github.com/apache/spark/pull/30413#issuecomment-733403353 Merged to master. This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [spark] HyukjinKwon commented on pull request #30413: [SPARK-33252][PYTHON][DOCS] Migration to NumPy documentation style in MLlib (pyspark.mllib.*)

2020-11-24 Thread GitBox
HyukjinKwon commented on pull request #30413: URL: https://github.com/apache/spark/pull/30413#issuecomment-733348463 @zero323, the only reason I have chosen `cols` over `*cols` is that I felt odds to just document this such as `*cols : tuple`, and thought `` cols: str, :class:`Column` ...

[GitHub] [spark] HyukjinKwon commented on pull request #30413: [SPARK-33252][PYTHON][DOCS] Migration to NumPy documentation style in MLlib (pyspark.mllib.*)

2020-11-19 Thread GitBox
HyukjinKwon commented on pull request #30413: URL: https://github.com/apache/spark/pull/30413#issuecomment-730766150 cc @viirya, @huaxingao, @WeichenXu123, @zhengruifeng , this is the last PR for the initial migration to NumPy documentation style. Would you guys mind taking a quick look wh