[GitHub] [spark] LuciferYang commented on a diff in pull request #39215: [SPARK-41709][CORE][SQL][UI] Explicitly define `Seq` as `collection.Seq` to avoid `toSeq` when create ui objects from protobuf

2022-12-26 Thread GitBox
LuciferYang commented on code in PR #39215: URL: https://github.com/apache/spark/pull/39215#discussion_r1057167898 ## core/src/main/scala/org/apache/spark/status/api/v1/api.scala: ## @@ -461,7 +461,7 @@ class ApplicationEnvironmentInfo private[spark] ( val systemProperties:

[GitHub] [spark] LuciferYang commented on a diff in pull request #39215: [SPARK-41709][CORE][SQL][UI] Explicitly define `Seq` as `collection.Seq` to avoid `toSeq` when create ui objects from protobuf

2022-12-26 Thread GitBox
LuciferYang commented on code in PR #39215: URL: https://github.com/apache/spark/pull/39215#discussion_r1057167898 ## core/src/main/scala/org/apache/spark/status/api/v1/api.scala: ## @@ -461,7 +461,7 @@ class ApplicationEnvironmentInfo private[spark] ( val systemProperties:

[GitHub] [spark] LuciferYang commented on a diff in pull request #39215: [SPARK-41709][CORE][SQL][UI] Explicitly define `Seq` as `collection.Seq` to avoid `toSeq` when create ui objects from protobuf

2022-12-26 Thread GitBox
LuciferYang commented on code in PR #39215: URL: https://github.com/apache/spark/pull/39215#discussion_r1057406919 ## sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListener.scala: ## @@ -486,7 +486,7 @@ private class LiveExecutionData(val executionId: Lon

[GitHub] [spark] LuciferYang commented on a diff in pull request #39215: [SPARK-41709][CORE][SQL][UI] Explicitly define `Seq` as `collection.Seq` to avoid `toSeq` when create ui objects from protobuf

2022-12-27 Thread GitBox
LuciferYang commented on code in PR #39215: URL: https://github.com/apache/spark/pull/39215#discussion_r1057572810 ## project/MimaExcludes.scala: ## @@ -129,7 +129,16 @@ object MimaExcludes { ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.storage.Bloc

[GitHub] [spark] LuciferYang commented on a diff in pull request #39215: [SPARK-41709][CORE][SQL][UI] Explicitly define `Seq` as `collection.Seq` to avoid `toSeq` when create ui objects from protobuf

2022-12-27 Thread GitBox
LuciferYang commented on code in PR #39215: URL: https://github.com/apache/spark/pull/39215#discussion_r1057583961 ## project/MimaExcludes.scala: ## @@ -129,7 +129,16 @@ object MimaExcludes { ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.storage.Bloc

[GitHub] [spark] LuciferYang commented on a diff in pull request #39215: [SPARK-41709][CORE][SQL][UI] Explicitly define `Seq` as `collection.Seq` to avoid `toSeq` when create ui objects from protobuf

2022-12-27 Thread GitBox
LuciferYang commented on code in PR #39215: URL: https://github.com/apache/spark/pull/39215#discussion_r1057590714 ## sql/core/src/main/scala/org/apache/spark/status/protobuf/sql/SQLExecutionUIDataSerializer.scala: ## @@ -64,7 +64,7 @@ class SQLExecutionUIDataSerializer extends