[GitHub] [spark] anchovYu commented on a diff in pull request #41864: [SPARK-44059] Add analyzer support of named arguments for built-in functions

anchovYu commented on code in PR #41864: URL: https://github.com/apache/spark/pull/41864#discussion_r1263066825 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/maskExpressions.scala: ## @@ -321,3 +322,21 @@ object Mask { } } } + +object MaskExpr

[GitHub] [spark] anchovYu commented on a diff in pull request #41864: [SPARK-44059] Add analyzer support of named arguments for built-in functions

anchovYu commented on code in PR #41864: URL: https://github.com/apache/spark/pull/41864#discussion_r1262848538 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/FunctionBuilderBase.scala: ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [spark] anchovYu commented on a diff in pull request #41864: [SPARK-44059] Add analyzer support of named arguments for built-in functions

anchovYu commented on code in PR #41864: URL: https://github.com/apache/spark/pull/41864#discussion_r1261503016 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/maskExpressions.scala: ## @@ -344,4 +346,13 @@ object Mask extends SupportsNamedArguments {

[GitHub] [spark] anchovYu commented on a diff in pull request #41864: [SPARK-44059] Add analyzer support of named arguments for built-in functions

anchovYu commented on code in PR #41864: URL: https://github.com/apache/spark/pull/41864#discussion_r1259998570 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CountMinSketchAgg.scala: ## @@ -208,3 +209,20 @@ case class CountMinSketchAgg(

[GitHub] [spark] anchovYu commented on a diff in pull request #41864: [SPARK-44059] Add analyzer support of named arguments for built-in functions

anchovYu commented on code in PR #41864: URL: https://github.com/apache/spark/pull/41864#discussion_r1258916558 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/maskExpressions.scala: ## @@ -344,4 +346,13 @@ object Mask extends SupportsNamedArguments {

[GitHub] [spark] anchovYu commented on a diff in pull request #41864: [SPARK-44059] Add analyzer support of named arguments for built-in functions

anchovYu commented on code in PR #41864: URL: https://github.com/apache/spark/pull/41864#discussion_r1258916558 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/maskExpressions.scala: ## @@ -344,4 +346,13 @@ object Mask extends SupportsNamedArguments {

[GitHub] [spark] anchovYu commented on a diff in pull request #41864: [SPARK-44059] Add analyzer support of named arguments for built-in functions

anchovYu commented on code in PR #41864: URL: https://github.com/apache/spark/pull/41864#discussion_r1258881422 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala: ## @@ -897,7 +895,20 @@ object FunctionRegistry { val info = Functio

[GitHub] [spark] anchovYu commented on a diff in pull request #41864: [SPARK-44059] Add analyzer support of named arguments for built-in functions

anchovYu commented on code in PR #41864: URL: https://github.com/apache/spark/pull/41864#discussion_r1258878085 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala: ## @@ -1016,5 +1029,14 @@ object TableFunctionRegistry { } trait Expr

[GitHub] [spark] anchovYu commented on a diff in pull request #41864: [SPARK-44059] Add analyzer support of named arguments for built-in functions

anchovYu commented on code in PR #41864: URL: https://github.com/apache/spark/pull/41864#discussion_r1254897374 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala: ## @@ -894,8 +896,10 @@ object FunctionRegistry { since: Option[St

[GitHub] [spark] anchovYu commented on a diff in pull request #41864: [SPARK-44059] Add analyzer support of named arguments for built-in functions

anchovYu commented on code in PR #41864: URL: https://github.com/apache/spark/pull/41864#discussion_r1254897374 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala: ## @@ -894,8 +896,10 @@ object FunctionRegistry { since: Option[St

[GitHub] [spark] anchovYu commented on a diff in pull request #41864: [SPARK-44059] Add analyzer support of named arguments for built-in functions

anchovYu commented on code in PR #41864: URL: https://github.com/apache/spark/pull/41864#discussion_r1254720472 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/SupportsNamedArguments.scala: ## @@ -0,0 +1,218 @@ +/* + * Licensed to the Apache Software F

[GitHub] [spark] anchovYu commented on a diff in pull request #41864: [SPARK-44059] Add analyzer support of named arguments for built-in functions

anchovYu commented on code in PR #41864: URL: https://github.com/apache/spark/pull/41864#discussion_r1254717223 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/SupportsNamedArguments.scala: ## @@ -0,0 +1,218 @@ +/* + * Licensed to the Apache Software F

[GitHub] [spark] anchovYu commented on a diff in pull request #41864: [SPARK-44059] Add analyzer support of named arguments for built-in functions

anchovYu commented on code in PR #41864: URL: https://github.com/apache/spark/pull/41864#discussion_r1254714134 ## common/utils/src/main/resources/error/error-classes.json: ## @@ -674,6 +674,12 @@ ], "sqlState" : "23505" }, + "DUPLICATE_ROUTINE_PARAMETER_ASSIGNMENT

[GitHub] [spark] anchovYu commented on a diff in pull request #41864: [SPARK-44059] Add analyzer support of named arguments for built-in functions

anchovYu commented on code in PR #41864: URL: https://github.com/apache/spark/pull/41864#discussion_r1253731057 ## common/utils/src/main/resources/error/error-classes.json: ## @@ -674,6 +674,12 @@ ], "sqlState" : "23505" }, + "DUPLICATE_ROUTINE_PARAMETER_ASSIGNMENT

[GitHub] [spark] anchovYu commented on a diff in pull request #41864: [SPARK-44059] Add analyzer support of named arguments for built-in functions

anchovYu commented on code in PR #41864: URL: https://github.com/apache/spark/pull/41864#discussion_r1253721448 ## common/utils/src/main/resources/error/error-classes.json: ## @@ -1781,6 +1787,12 @@ "Not allowed to implement multiple UDF interfaces, UDF class ." ]

[GitHub] [spark] anchovYu commented on a diff in pull request #41864: [SPARK-44059] Add analyzer support of named arguments for built-in functions

anchovYu commented on code in PR #41864: URL: https://github.com/apache/spark/pull/41864#discussion_r1253421717 ## common/utils/src/main/resources/error/error-classes.json: ## @@ -674,6 +674,12 @@ ], "sqlState" : "23505" }, + "DUPLICATE_ROUTINE_PARAMETER_ASSIGNMENT