[GitHub] [spark] beliefer edited a comment on pull request #31390: [SPARK-28123][SQL] String Functions: support btrim

2021-02-22 Thread GitBox
beliefer edited a comment on pull request #31390: URL: https://github.com/apache/spark/pull/31390#issuecomment-783233306 @cloud-fan @gengliangwang There not any database do `trim(binary) => string`, so I think should remove the `ImplicitCastInputTypes` from `String2TrimExpression`. I

[GitHub] [spark] beliefer edited a comment on pull request #31390: [SPARK-28123][SQL] String Functions: support btrim

2021-02-22 Thread GitBox
beliefer edited a comment on pull request #31390: URL: https://github.com/apache/spark/pull/31390#issuecomment-783233306 @cloud-fan @gengliangwang There not any database do `trim(binary) => string`, so I think should remove the `ImplicitCastInputTypes` from `String2TrimExpression`. I

[GitHub] [spark] beliefer edited a comment on pull request #31390: [SPARK-28123][SQL] String Functions: support btrim

2021-02-22 Thread GitBox
beliefer edited a comment on pull request #31390: URL: https://github.com/apache/spark/pull/31390#issuecomment-783233306 @cloud-fan @gengliangwang There not any database do `trim(binary) => string`, so I think should remove the `ImplicitCastInputTypes` from `String2TrimExpression`. I

[GitHub] [spark] beliefer edited a comment on pull request #31390: [SPARK-28123][SQL] String Functions: support btrim

2021-02-22 Thread GitBox
beliefer edited a comment on pull request #31390: URL: https://github.com/apache/spark/pull/31390#issuecomment-783233306 @cloud-fan @gengliangwang There not any database do `trim(binary) => string`, so I think should remove the `ImplicitCastInputTypes` from `String2TrimExpression`. I

[GitHub] [spark] beliefer edited a comment on pull request #31390: [SPARK-28123][SQL] String Functions: support btrim

2021-02-21 Thread GitBox
beliefer edited a comment on pull request #31390: URL: https://github.com/apache/spark/pull/31390#issuecomment-783119022 @gengliangwang Let us ignore the return type of btrim. In Postgresql, Vertica, Redshift, Druid, Greenplum, btrim is used to remove the leading and trailing space charact

[GitHub] [spark] beliefer edited a comment on pull request #31390: [SPARK-28123][SQL] String Functions: support btrim

2021-02-21 Thread GitBox
beliefer edited a comment on pull request #31390: URL: https://github.com/apache/spark/pull/31390#issuecomment-783119022 @gengliangwang Let us ignore the return type of btrim. In Postgresql, Vertica, Redshift, Druid, Greenplum, btrim is used to remove the leading and trailing space charact

[GitHub] [spark] beliefer edited a comment on pull request #31390: [SPARK-28123][SQL] String Functions: support btrim

2021-02-21 Thread GitBox
beliefer edited a comment on pull request #31390: URL: https://github.com/apache/spark/pull/31390#issuecomment-783108294 @gengliangwang btrim means trim from leading and trailing. not binary. You can reference all the database show in PR's description.

[GitHub] [spark] beliefer edited a comment on pull request #31390: [SPARK-28123][SQL] String Functions: support btrim

2021-02-21 Thread GitBox
beliefer edited a comment on pull request #31390: URL: https://github.com/apache/spark/pull/31390#issuecomment-783108294 @gengliangwang btrim means trim from leading and trailing. not binary This is an automated message from