bjornjorgensen commented on PR #40878:
URL: https://github.com/apache/spark/pull/40878#issuecomment-1537531873
ok, I have added
This have be benchmarks tested
With
"com.google.crypto.tink" % "tink" % "1.6.1"
(min, avg, max) = (75024163.500, 76331532.832, 77324718.069), stdev =
bjornjorgensen commented on PR #40878:
URL: https://github.com/apache/spark/pull/40878#issuecomment-1537522027
Reboot and run with `sbt 'jmh:run -i 10 -wi 10 -f 1 -t 1'`
with
"com.google.crypto.tink" % "tink" % "1.9.0"
```
[info] compiling 5 Java sources to
bjornjorgensen commented on PR #40878:
URL: https://github.com/apache/spark/pull/40878#issuecomment-1537501785
Here https://github.com/bjornjorgensen/GoogleThinkBenchmark is the code that
I have used to test it.
"com.google.crypto.tink" % "tink" % "1.6.1"
```
[info] compiling 5
bjornjorgensen commented on PR #40878:
URL: https://github.com/apache/spark/pull/40878#issuecomment-1537199659
Oh.. I think you have found this
https://github.com/tink-crypto/tink-java/issues/6
He is using 1.7.0
bjornjorgensen commented on PR #40878:
URL: https://github.com/apache/spark/pull/40878#issuecomment-1537086687
> If you don't mind, could you update the PR description with a
micro-benchmark like #35679 ?
#35679 is a PR for "There is a performance optimization ..."
This PR is only
bjornjorgensen commented on PR #40878:
URL: https://github.com/apache/spark/pull/40878#issuecomment-1529608564
@HyukjinKwon will you have a look at this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
bjornjorgensen commented on PR #40878:
URL: https://github.com/apache/spark/pull/40878#issuecomment-1517673103
@LuciferYang Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
bjornjorgensen commented on PR #40878:
URL: https://github.com/apache/spark/pull/40878#issuecomment-1516266674
https://github.com/apache/spark/pull/40408 is related to this.
CC @LuciferYang
--
This is an automated message from the Apache Git Service.
To respond to the message,
